Commit graph

236 commits

Author SHA1 Message Date
David Shrewsbury
f71542ccf2 Fix parameters where type is assumed.
A change is coming to Ansible where module params will default to str.
Many of our modules were taking advantage of this by not being explicit
about the type, so they will break when that change merges. This hopefully
catches those cases.
2016-02-12 12:30:52 -05:00
Monty Taylor
5f925d061b Add user_data alias for userdata in os_server
The old nova_compute module called the parameter user_data - having an
alias to the old name is friendly.

Fixes Issue #2920
2016-02-09 07:51:08 -06:00
Brian Coca
a75fa8df05 added missing version_added 2016-01-25 23:43:46 -05:00
Brian Coca
d2c50688de Merge pull request #2814 from Shrews/purge_fip
Add purge option to os_floating_ip module
2016-01-25 23:38:58 -05:00
Brian Coca
5e38b0e0c1 added missing version_Added 2016-01-25 23:42:04 -05:00
Brian Coca
1ebe143618 Merge pull request #2829 from juliakreger/add-os-ironic-node-wait
Add wait support to os_ironic_node
2016-01-25 23:37:07 -05:00
Yair Fried
2692e494e5 Fix glance_client module
Wrong variable name.
2016-01-25 14:49:37 +02:00
Brian Coca
0d1a154fac Merge pull request #2805 from Shrews/fix_os_server_exc
Fix OpenStack module failure output
2016-01-18 20:46:22 -05:00
Julia Kreger
9c7c9e8573 Add wait support to os_ironic_node
Add support for the os_ironic_node module to be capible of waiting
until the baremetal node activation or deactivation has completed.
2016-01-17 17:42:46 -05:00
David Shrewsbury
42ed6124d4 Add purge option to os_floating_ip module
Add the ability to completely delete a floating IP from the pool
when disassociating it from a server. When state is absent and
purge is true, the IP will be completely deleted. The default
keeps the current behavior, which is to only disassociate the IP
from the server.
2016-01-14 13:48:37 -05:00
Brian Coca
fd59dccdd7 Merge pull request #2681 from timrchavez/pass_network_argument
Pass network argument to add_ips_to_server
2016-01-13 17:32:34 -05:00
David Shrewsbury
e8abea25c7 Fix OpenStack module failure output
The exception message, when shade fails, will contain much more
specific information about the failure if the exception is treated
as a string. The 'message' attribute alone is usually not helpful.
2016-01-13 11:15:24 -05:00
Dmitry Labutin
35d32c9378 Fix issue #2721: os_object parameters and docs don't align (file/filename) 2015-12-29 10:31:14 +03:00
Brian Coca
907b7f7cf4 fix bad linebreak 2015-12-22 11:08:43 -05:00
Michael Scherer
90f8228fb1 Fix #2629, replace choices=BOOLEANS by type='bool' 2015-12-22 16:10:01 +01:00
Sam Thursfield
6e9adc4687 os_server: Add some error checking for the 'nics' parameter
If this parameter was not of the right type, the module would fail with a
traceback, with a "AttributeError: 'str' object has no attribute 'get'"
exception.

It now gives a proper error message on type errors.
2015-12-21 12:53:43 +00:00
Alberto Gireud
9cc67e45a6 Update root_volume variable 2015-12-17 07:21:17 -06:00
Toshio Kuratomi
f04cd88d22 Fix os_server docs build 2015-12-16 08:06:29 -08:00
Donovan Jones
cf061dd93a fix typo in os_server security_groups description 2015-12-16 15:20:55 +13:00
Monty Taylor
187a4bd505 Add support for network, boot_from_volume and volumes
nics is a great flexible parameter, but it's wordy. Shade now supports
a simple parameter too, which is just "network" and takes a name or id.
Add passthrough support.

In addition to supporting booting from a pre-existing volume, nova and
shade both support the concept of booting from volume based on an image.
Pass the parameters through.

Shade supports boot-time attachment of additional volumes for OpenStack
instances. Pass through the parameter so that ansible users can also
take advantage of this.
2015-12-15 07:32:28 -05:00
Timothy R. Chavez
05e16c950d Pass network argument to add_ips_to_server
The `network` argument needs to be passed through `add_ips_to_server`
so that the default value can be properly overridden from ansible.
2015-12-13 09:30:20 -08:00
Timothy R. Chavez
b9fe8166fd Get new server object after adding floating IP
We need a new server object once we add the floating ip, otherwise we
will be operating with the older server object pre-floating-ip
assignment.
2015-12-10 13:01:57 -06:00
Markus Suonto
32edc2f56f fixed quantum_ modules to work with minimum access rights if greater access rights are not needed 2015-11-26 15:34:47 +02:00
David Shrewsbury
d13741314e Bug fix for os_image and min_disk/min_ram
The min_disk and min_ram parameters were not being passed to
the shade API. They also need to be integer values. Also
updated the description of these parameters for better
clarification.
2015-11-23 11:29:00 -05:00
David Shrewsbury
2a306c6b8c Fix os_user_group module
This module had a couple of errors in it. Also added check mode
support.
2015-11-18 15:03:07 -05:00
Monty Taylor
ccb39767cf Use add_ips_to_server API
This module is still using an old pre-release API and needs to update
to use the current API.

Co-Authored-By: Marton Kiss <marton.kiss@gmail.com>
2015-11-09 11:38:04 -05:00
Brian Coca
1f9c204178 Merge pull request #2379 from larsks/feature/os_server_facts_returns_list
os_server_facts returns facts about multiple servers
2015-11-05 12:50:29 -05:00
Greg DeKoenigsberg
57dcf2c9dd @lorin stepping down as maintainer 2015-10-28 14:38:11 -04:00
Lars Kellogg-Stedman
e70002d2f9 os_server_facts returns facts about multiple servers
have `os_server_facts` call `list_servers` rather than `get_server`, and
treat the `server` parameter as a wildcard pattern.  This permits one to
get facts on a single server:

    - os_server:
        server: webserver1

On mutiple servers:

    - os_server:
        server: webserver*

Or on all servers:

    - os_server:

Introduces a `detailed` parameter to request additional server details
at the cost of additional API calls.
2015-10-28 13:18:54 -04:00
Brian Coca
30951e2811 Merge pull request #2345 from larsks/bug/port-allow-secgroup-list
allow os_port to accept a list of security groups
2015-10-26 19:45:39 -04:00
Brian Coca
7c1fcd8e13 Merge pull request #2349 from larsks/bug/router-should-return-id
make os_router return a top level 'id' key
2015-10-26 18:20:26 -04:00
Brian Coca
ad8fd86467 Merge pull request #2338 from larsks/bug/flavor-should-return-id
make os_flavor return a top-level 'id' key
2015-10-23 14:52:03 -04:00
Brian Coca
0e0c28bfb1 Merge pull request #2344 from larsks/bug/allow-secgroup-list
allow os_server to accept a list of security groups
2015-10-23 14:51:45 -04:00
Brian Coca
3199a73927 Merge pull request #2339 from larsks/bug/keypair-should-return-id
make os_keypair return a top level 'id' key
2015-10-23 14:51:27 -04:00
Brian Coca
59f11aa973 Merge pull request #2336 from larsks/feature/os-subnet-returns-something
return information about created subnet
2015-10-23 14:51:05 -04:00
Lars Kellogg-Stedman
d82460a372 make os_router return a top level 'id' key
make os_router return a top-level 'id' key, much like other
os_* resources.
2015-10-23 13:32:37 -04:00
Lars Kellogg-Stedman
a2fe8dba68 allow os_port to accept a list of security groups
with this commit, the `security_groups` attribute for `os_port` will
accept either a common-delimited string or ` YAML list.  That is, either
this:

    - os_port:
        [...]
        security_groups: group1,group2

Or this:

    - os_port:
        [...]
        security_groups:
          - group1
          - group2
2015-10-23 09:44:07 -04:00
Brian Coca
12b0582f9e Merge pull request #2343 from larsks/bug/secgroup-allow-empty-description
allow empty description attribute for os_security_group
2015-10-23 09:43:01 -04:00
Brian Coca
49a66eb8d2 Merge pull request #2337 from larsks/bug/os-network-always-unchanged
make os_network correctly report changed status
2015-10-23 09:42:45 -04:00
Lars Kellogg-Stedman
b0c10a7d31 allow os_server to accept a list of security groups
This commit allows the `security_groups` parameter of the `os_server`
module to be either a YAML list or a common-delimited string (much like
the `nics` attribute).  E.g., this:

    - os_nova_server:
        [...]
        security_groups:
          - default
          - webserver

Or this:

    - os_nova_server:
        [...]
        security_groups: default,webserver
2015-10-22 22:53:05 -04:00
Lars Kellogg-Stedman
da0fbfc564 allow empty description attribute for os_security_group
The `os_security_group` module would fail if there was no `description:`
attribute:

    localhost | FAILED! => {
        "changed": false,
        "failed": true,
	"msg": "Error creating security group larstest: Invalid input for
	description. Reason: 'None' is not a valid string."
    }

This commit makes the default description `''` rather than `None`.
2015-10-22 21:26:47 -04:00
Lars Kellogg-Stedman
377811dac2 make os_keypair return a top level 'id' key
make os_keypair return a top-level 'id' key, much like other os_*
resources.
2015-10-22 13:59:45 -04:00
Lars Kellogg-Stedman
8368da4297 make os_flavor return a top-level 'id' key
make os_flavor return a top-level 'id' key, much like other os_*
resources.
2015-10-22 13:56:56 -04:00
Lars Kellogg-Stedman
c54c5c8234 make os_network correctly report changed status
The `os_network` module was incorrectly returning changed=False whether
or not the network was created.  This commit makes the changed return
value useful.
2015-10-22 13:38:32 -04:00
Lars Kellogg-Stedman
d73f5a4adb return information about created subnet
make os_subnet behave like os_network in terms of returning information
about the created resource.  With this commit, os_subnet will return the
created subnet in `subnet` and the subnet id in `id`.
2015-10-22 13:27:17 -04:00
David Shrewsbury
5d73a9a4c5 Fix for routers without external interfaces 2015-10-22 11:52:28 -04:00
Matt Martz
2e49d89be7 Merge pull request #2328 from emonty/bug/is-public
Actually pass in is_public to create_image
2015-10-21 19:46:18 -05:00
Monty Taylor
e7bdf7f7f6 Actually pass in is_public to create_image
Fixes #2325
2015-10-22 08:52:05 +09:00
Brian Coca
88e7dcf174 fixed mispelled description 2015-10-21 19:39:17 -04:00
Matt Martz
dc1f0c6f9f Merge pull request #2319 from Shrews/os_user
Add OpenStack Keystone User module
2015-10-20 15:43:50 -05:00