Toshio Kuratomi
f5654dced9
Merge pull request #15043 from mattclay/docker-user
...
Use docker exec -u only when supported.
2016-03-18 18:46:46 -07:00
Matt Clay
ea1a6c56b9
Use docker exec -u when needed and if supported.
...
If remote_user is given and cannot be set in docker, a warning will
be displayed unless the default container user matches remote_user.
2016-03-18 18:19:41 -07:00
RNanney
8bceff5136
Update nxos.py
2016-03-18 15:55:41 -05:00
James Cammarata
13f3cbaf3b
Renaming per-item and retry callbacks
2016-03-18 15:17:43 -04:00
Toshio Kuratomi
60c943997b
More doc updates regarding ansible_shell_executable
2016-03-18 09:16:21 -07:00
Toshio Kuratomi
8bdf0d4746
And another doc fix
2016-03-18 09:09:31 -07:00
Toshio Kuratomi
08394df8d0
Update submodule links for docs fixes
2016-03-18 09:06:05 -07:00
Abhijit Menon-Sen
efdac490ff
Merge pull request #14924 from mvgrimes/patch-1
...
Dynamically add ssl key to the mysql config hash iff needed
2016-03-18 20:38:33 +05:30
Brian Coca
d43fc631dd
mount facts now include network mounts (nfs)
2016-03-18 07:28:53 -07:00
Brian Coca
b809d23863
fixed typo
2016-03-18 07:04:12 -07:00
Abhijit Menon-Sen
e5460d6a6e
Merge pull request #15002 from camradal/devel
...
add find_host_portgroup_by_name function to vmware utils
2016-03-18 19:32:17 +05:30
Toshio Kuratomi
e25caebe7a
Cleanups to docs and rename of inv var
2016-03-18 06:42:37 -07:00
Toshio Kuratomi
8fc1c26c37
Merge pull request #14936 from bcoca/ansible_executable
...
add ansible_executable inventory var
2016-03-18 06:41:24 -07:00
Toshio Kuratomi
2ba4428424
Catch ValueError as well because of El Capitan provoking a bug in python2's subprocess
...
Fixes #14895
2016-03-18 05:52:53 -07:00
Abhijit Menon-Sen
a61a3e28da
Merge pull request #9776 from MiLk/fixes/git-repo-info-branch
...
ansible.utils._git_repo_info() now supports branch names with slashes
2016-03-18 18:08:02 +05:30
Brian Coca
db61e9be0c
add ansible_executable inventory var
...
also handle the overrides appropriately
also new executable to set shell type
2016-03-17 18:54:37 -07:00
Thomas Steinbach
14dfad730e
use just 'remote_user' as user for the docker connection
2016-03-17 14:39:44 -07:00
Thomas Steinbach
4ac49ed4a8
use remote_user or become_user in docker connection
2016-03-17 14:39:44 -07:00
Brian Coca
5d9b552317
Merge pull request #15024 from bcoca/delegation_vars_fix
...
ensure we use delegated vars on delegation
2016-03-17 14:33:36 -07:00
Toshio Kuratomi
ab693579a9
Clarify the document about the order of matryoshka shells
...
(nesting shells)
2016-03-17 14:29:49 -07:00
James Cammarata
1ee6d489ab
Make sure tuples returned by _get_item() are handled correctly in formatting
...
Fixes #14800
2016-03-17 14:19:58 -04:00
Brian Coca
292be944c6
ensure we use delegated vars on delegation
...
this prevents falling back to connection vars from the inventory_hostname
when matching connection var is not in delegated host.
2016-03-17 11:03:40 -07:00
René Moser
0a457230ab
Merge pull request #14982 from Linuturk/GalaxyInitWhitespaceFix
...
Remove trailing whitespace from the galaxy init Jinja2 template. Defa…
2016-03-17 17:48:08 +01:00
Toshio Kuratomi
2dd6bae9e1
Merge pull request #15003 from ansible/jail-enable-pipelining
...
Enable pipelining for jail connection plugin
2016-03-17 07:55:36 -07:00
Brian Coca
bc60f52db5
avoid exceptiosn when not being called by CLI
2016-03-17 07:19:35 -07:00
Toshio Kuratomi
e80cd8bcaf
Merge pull request #14908 from mattclay/mysql-connect-timeout
...
Document mysql connect_timeout and update tests.
2016-03-17 07:18:01 -07:00
James Cammarata
0e68c6d6fe
Cleaning up use of literal_eval in basic.py AnsibleModule.safe_eval
2016-03-17 02:02:15 -04:00
Matt Clay
6a1f97ad42
Add docs for mysql* modules connect_timeout.
2016-03-16 22:31:48 -07:00
Brian Coca
5ae9955aad
Merge pull request #15011 from dagwieers/fix-unreachable-color
...
Fix the color when unreachable in default cb plugin
2016-03-16 17:02:05 -07:00
Brian Coca
0cb804f0c2
fix lsb fact gathering
...
was erroring out when rc !=0 also fixed redundant paths
fixes #14965
2016-03-16 17:00:17 -07:00
Brian Coca
d7d47bcd75
Merge pull request #14989 from nifoc/patch-fetch_url
...
Check return value of get_distribution()
2016-03-16 16:54:11 -07:00
Dag Wieers
ed457ad53b
Fix the color when unreachable in default cb plugin
...
The dedicated color for unreachable errors was not being used in the default cb plugin.
This corrects the color.
2016-03-17 00:18:13 +01:00
qqo
a7f89cac63
fix TypeError: coercing to Unicode: need string or buffer, AnsibleParserError found
2016-03-17 00:56:47 +03:00
qqo
85e843baee
Revert "fix TypeError: coercing to Unicode: need string or buffer, AnsibleParserError found"
...
This reverts commit d1e0719e4c
.
2016-03-17 00:50:47 +03:00
qqo
d1e0719e4c
fix TypeError: coercing to Unicode: need string or buffer, AnsibleParserError found
2016-03-16 23:47:16 +03:00
Brian Coca
61f05c2e8d
strip keys recursively
2016-03-16 13:18:29 -07:00
Toshio Kuratomi
7346e3098a
Update extras submodule ref
2016-03-16 13:09:45 -07:00
Toshio Kuratomi
1346c209b0
Add changes necessary for enabling pipelining for local connections
2016-03-16 12:47:52 -07:00
Toshio Kuratomi
a8acd7f93e
Enable pipelining for jail connection plugin
2016-03-16 11:39:51 -07:00
Alexey Kalinin
9763e76f6f
add find_host_portgroup_by_name function to vmware utils
2016-03-16 11:24:42 -07:00
Toshio Kuratomi
de306eb5da
Small cleanup to use class attribute directly instead of property for transport names
2016-03-16 11:22:50 -07:00
Toshio Kuratomi
fee73100c4
Move BUFSIZE to __init__ since it's common to many connection plugins
2016-03-16 11:20:02 -07:00
Toshio Kuratomi
0ca4be6fb5
Update submodule refs for docs fixes
2016-03-16 11:00:56 -07:00
Toshio Kuratomi
ec419446b7
Update submodule refs
2016-03-16 10:19:57 -07:00
Daniel Kempkens
696b68f07a
Check return value of get_distribution()
...
On none-Linux systems `get_distribution()` returns `None`, which fails in `fetch_url`, because the return value of `get_distribution()` is not checked before calling `lower()` on the result.
2016-03-16 10:49:21 +01:00
Toshio Kuratomi
fe278202f2
Fix saving of tracebacks on module failure
2016-03-15 20:31:40 -07:00
Justin Phelps
d604c8c3a6
Remove trailing whitespace from the galaxy init Jinja2 template. Default a description.
2016-03-15 16:27:33 -05:00
Toshio Kuratomi
86080fbaa9
Update submodule refs
2016-03-15 07:49:25 -07:00
Toshio Kuratomi
66328e5200
Merge pull request #14967 from ansible/facts-subset-and-cleanup
...
Facts subset and cleanup
2016-03-15 07:17:58 -07:00
夏恺(Xia Kai)
cd6d865e27
use __mro__ for plugin loading when we search for its base class.
...
This would relax the constraint a little bit, allowing subclassing existing plugins.
Signed-off-by: 夏恺(Xia Kai) <xiaket@gmail.com>
2016-03-15 10:01:31 +00:00
Brian Coca
f3b9449e07
don't raise exceptoins on bad hosts files
...
fixes #14969
2016-03-14 20:13:23 -07:00
Peter Sprygada
ace0c9c5c2
fixes ansible-modules-code#3250
...
Sets the default value for transport to 'cli'
2016-03-14 18:49:51 -07:00
Peter Sprygada
c039ac524d
updates to nxos shared module
...
This commit address a number of minor updates the nxos shared module
* connect() is now lazy loaded
* parse inner output messages when errored
* code syntax cleanup
2016-03-14 15:21:05 -07:00
Toshio Kuratomi
512825455e
Make ohai and facter work via module_utils Fact classes rather than in the setup module
2016-03-14 14:53:29 -07:00
Toshio Kuratomi
5a1e35224b
Make changes proposed during review of restrict fact gathering feature:
...
* Make documentation examples into code blocks
* Make code to call the subsets more general.
* Made min subset always execute (cannot disable it).
* Use a passed in modules parameter rather than global modules. This is needed for ziploader
* Remove unneeded __init__()
* Remove uneeded multiple inheritance from a base class
* gather_facts is now a list type
2016-03-14 14:53:29 -07:00
Toshio Kuratomi
d665911bab
Allow FieldAttribute lists and sets to be set from a comma separated string
2016-03-14 14:53:29 -07:00
Yannig Perré
88772b6003
Add a way to restrict gathered facts in Ansible:
...
- Using gather_subset options
- By ignoring ohai/chef or facter/puppet facts
2016-03-14 14:53:28 -07:00
Brian Coca
2984ffdfac
now item callback honors display_skipped_hosts
...
fixes #14956
2016-03-14 13:13:50 -04:00
Peter Sprygada
d211b4c962
feature to implement localized cli prompts to eos
...
This change localizes the cli prompt regexps to the eos shared module
instead of the common prompts implemented in shell
2016-03-13 16:08:55 -07:00
Peter Sprygada
5338d6af28
feature in ios to tell shell not to kickstart
...
This commit is necessary to tell shell not to kickstart the cli session as
it causes problems in IOS to recognize the prompt.
2016-03-13 16:08:47 -07:00
Peter Sprygada
249caac0d3
feature to allow prompts to be configured at instatiation
...
This commit adds a new feature to allow implementations of shell to
specify the command prompt regexp to be used. It allows adds a new
kwarg at instantiation to kick the remote device with a carriage return.
By default the kickstart flag is true but can be disabled by passing
kickstart=False.
2016-03-13 16:08:40 -07:00
Peter Sprygada
c55d1c55af
Merge pull request #14906 from devananda/fix-shell-for-junos
...
Send empty command before recv
2016-03-11 22:49:28 -05:00
Brian Coca
00b8b49112
Merge pull request #14873 from bcoca/paging_aws
...
paging for amazon modules
2016-03-11 22:23:18 -05:00
Brian Coca
fdcd80bf87
Merge pull request #13339 from bcoca/retry_rate
...
draft of common retry and rate limiting decorators for api based modules
2016-03-11 22:23:07 -05:00
Peter Sprygada
e3671a8a83
bugfix for eos shared module and new optimization
...
This commit address to issues in the eos shard module. The first one
is a bug fix for returning the running config when the transport is eapi.
The shared module will now return config text instead of an object. The
second is a optimization that delays when the eos module connects to the
remote devices. This provies a performance enhancement when using
ssh since the module doesn't default to connecting immediately
2016-03-11 22:18:15 -05:00
Toshio Kuratomi
180e70b67a
Merge pull request #14937 from mattclay/unicode-dir
...
Fix missing to_bytes on directory path.
2016-03-11 19:15:14 -08:00
Matt Clay
1e1852c34d
Add missing to_bytes on directory path.
2016-03-11 16:55:51 -08:00
root
2aba1c211d
Modified files to use single quotes rather than double for file path. Powershell does not process $ variables in strings that are single quoted. Powershell DOES process $ variables that are in double quoted strings.
...
Using single quotes enables ansible to handle file paths that contain folders that start with $. (i.e. C:/Users/$admin/...)
2016-03-11 14:00:28 -05:00
mvgrimes
e613737b80
Dynamically add ssl key to the mysql config hash iff needed
...
Just including the `ssl` key in the config for MySQLdb.connect, causes it to check for the existence of SSL support. This patch only adds the key if one of the ssl configuration options is included.
2016-03-11 11:14:48 -05:00
David Shrewsbury
336d19d3b0
Set type for OpenStack 'verify' param
...
The 'verify' param is a bool, so we don't want it to be an assumed
str.
2016-03-11 08:07:30 -05:00
Peter Sprygada
a59fe25bb1
bugfix for shared module shell.py
...
removes get_cli_connection function which was left over from a refactor
but was no longer in use
2016-03-10 21:16:57 -05:00
Matt Clay
ba1bcdfc17
Add noseclabel support to libvirt_lxc plugin.
2016-03-10 15:34:31 -08:00
James Cammarata
16f107a491
Add mysql connection_timeout param to module_utils/mysql.py
2016-03-10 15:06:50 -05:00
Devananda van der Veen
08f270ad71
Send empty command before recv
...
On some switches, starting an SSH connection and immediately calling
recv() will result in a connection timeout. The switch requires some
input on the channel before it provides any prompt.
As such, this patch sends an empty command immediately upon connection,
triggering the switch to send a prompt which the shell can then
interpret.
Signed-off-by: Devananda van der Veen <devananda.vdv@gmail.com>
2016-03-10 11:11:18 -08:00
James Cammarata
52efd7438c
Fixing template/assemble action plugins related to tmp dir use/cleanup
2016-03-10 14:07:58 -05:00
Matt Clay
f878a5d2e0
Fix unicode handling in connection plugins.
2016-03-10 09:04:32 -08:00
James Cammarata
09e5f0578a
Don't always insert failed in the results (again)
2016-03-10 11:02:55 -05:00
Brian Coca
5cbdaff9fd
avoid creating extra tmp dirs we don't delete
...
fixes #14867
2016-03-10 10:31:36 -05:00
James Cammarata
ccf646665b
Revert "Removing explicit setting of failed/failed_when"
...
This reverts commit 4e528e9535
.
2016-03-10 08:01:54 -05:00
James Cammarata
4e528e9535
Removing explicit setting of failed/failed_when
2016-03-10 07:42:16 -05:00
Brian Coca
df1268ed69
Merge pull request #14892 from dagwieers/patch-14
...
Another misspelling
2016-03-09 23:57:56 -05:00
Brian Coca
05983fdaa5
Merge pull request #14891 from dagwieers/patch-13
...
Fix misspelling and some cosmetic change
2016-03-09 23:57:25 -05:00
Brian Coca
1c1f5e9f99
Merge pull request #14889 from nitzmahone/fix_failed_when_blind_override
...
Fix blind override in failed_when
2016-03-09 23:53:11 -05:00
Peter Sprygada
ca2871de20
Merge pull request #14697 from privateip/shared_module_openswitch
...
bugfixes for openswitch shared module
2016-03-09 22:15:35 -05:00
Peter Sprygada
ae5951b97f
Merge pull request #14698 from privateip/plugin_action_ops_template
...
updates the ops_template plugin action backup key
2016-03-09 22:14:56 -05:00
Dag Wieers
a5e11b1325
Another misspelling
...
...while reading the source
2016-03-10 03:24:04 +01:00
Dag Wieers
d7d04ad2cd
Fix misspelling and some cosmetic change
2016-03-10 03:18:09 +01:00
nitzmahone
dbff3a6bbc
Fix blind override in failed_when
...
caused all task failures to be success
2016-03-09 17:48:59 -08:00
Brian Coca
18e9bc9753
common retry and rate limiting decorators for apis
...
allows modules to wrap their request functions in common retry and rate limiting
decorators or functions
2016-03-09 16:55:47 -05:00
Brian Coca
9318727021
corrected changed_when handling
2016-03-09 16:09:05 -05:00
James Cammarata
7f233c4c5e
Updating submodule refs
2016-03-09 15:52:23 -05:00
Toshio Kuratomi
331f62f769
Update submodule refs
2016-03-09 11:28:49 -08:00
Toshio Kuratomi
0628951ac6
Handle shlex incompatibility between python2.6 and python3
2016-03-09 11:27:19 -08:00
Toshio Kuratomi
c0e2dd1693
Fix ssh connection plugin to work with python3
2016-03-09 11:17:10 -08:00
James Cammarata
eb463fab00
Also changing ansible-shell -> ansible-console in cli code comments
2016-03-09 13:53:52 -05:00
James Cammarata
9d61a6cba8
Fixing PlayIterator bugs
...
* Unit tests exposed a problem where nested blocks did not correctly
hit rescue/always portions of parent blocks
* Cleaned up logic in PlayIterator
* Unfortunately fixing the above exposed a potential problem in the
block integration tests, where a failure in an "always" section may
always lead to a failed state and the termination of execution
beyond that point, so certain parts of the block integration test
were disabled.
2016-03-09 13:31:30 -05:00
Brian Coca
d7bd5fc075
Merge pull request #14824 from bcoca/ansible_shell
...
draft 1st release of ansible shell
2016-03-09 13:21:25 -05:00
Brian Coca
7067bb32b8
make all conditionals lists
...
this brings them to equivalence with when:
fixes #13905
2016-03-09 09:33:59 -05:00
Matt Clay
33f93f9241
Fix misplaced paren.
2016-03-08 22:16:23 -08:00
Brian Coca
33b550fc76
paging for amazon modules
...
this adds a decorator for use in amazon modules so retrieval functions
can page using the 'marker' that most boto functions return
2016-03-09 00:53:33 -05:00