Commit graph

834 commits

Author SHA1 Message Date
Erik Nadel
7491a11581 Added statement about escaping characters in chron tasks (#3770) 2016-05-27 14:46:43 -04:00
Dmitry Marakasov
68cb864aad Fix crontab argument order for writing (#3750)
Currently, when writing user's crontab, ansible calls

    crontab <file> -u <user>

This is incorrect according to crontab(1) on both FreeBSD and Linux,
which suggest that file argument should be the last.

At least on FreeBSD, this leads to incorrect cron module bahavior which
writes to root's crontab instead of users's
2016-05-27 06:54:03 +02:00
Brian Coca
96b2bc9084 fixed enabled reporting 2016-05-26 13:55:48 -04:00
Brian Coca
beb9ff9170 fixed typo 2016-05-26 13:22:21 -04:00
Brian Coca
d03914ed63 added state in results for backwards compat 2016-05-26 13:20:49 -04:00
Brian Coca
fb77ab49ab first draft systemd service plugin (#3660)
* first draft systemd service plugin

* now systemd status handles multiline values
2016-05-25 17:20:08 -04:00
Marcos Diez
873a7435df Added one extra example in the authorized_key module. (#3637) 2016-05-24 14:50:22 +02:00
Ken Mitchell
b903c54bac Proposed fix to not require src and fstype arguments for mount. Issue #1259. (#1357) 2016-05-23 11:20:10 -04:00
jctanner
76b7de943b Do not ignore the primary group if modifying the list of secondary groups. (#3585)
Fixes #1118
2016-05-19 22:37:57 -04:00
Michael Scherer
a62f088a24 Port seboolean to py3/py2.4 syntax (#3679) 2016-05-17 10:23:06 -07:00
Michael Scherer
c1e40b73f7 Port mount to python3 and python 2.4 compatible syntax (#3678) 2016-05-17 10:22:29 -07:00
Michael Scherer
f41a90eae4 Port authorized_keys to a syntax compatible with python3 and 2.4 (#3677) 2016-05-17 10:21:55 -07:00
Michael Scherer
2e0307e083 Port hostname to a py24 and py3 compatible syntax (#3676) 2016-05-17 10:21:26 -07:00
Michael Scherer
b19a8a9b8f Port sysctl to a py3 and py24 compatible syntax (#3675) 2016-05-17 10:20:36 -07:00
Michael Scherer
afce9e5855 Port cron to a py3 and py24 compatible syntax (#3674) 2016-05-17 10:19:19 -07:00
Michael Scherer
b49ca52912 Port user module to python3 and 2.4 compatible syntax (#3673) 2016-05-17 10:18:19 -07:00
Toshio Kuratomi
9dfed7c849 Port to dual python2/python3 compat 2016-05-10 21:58:49 -07:00
Toshio Kuratomi
a355b6a1c9 Port ping to dual python3/2 compat. 2016-05-10 21:58:49 -07:00
James Tanner
9be870bb2a Revert "remove checking of stderr for insserv (#1846)"
This reverts commit 2ee6e4cf66.
2016-05-05 10:41:06 -04:00
TheSameCH
2ee6e4cf66 remove checking of stderr for insserv (#1846)
stderr of insserv can also contain warnings which can be ignored. checking rc only is more accurate.
fixes #1502
2016-05-04 22:09:55 -04:00
Brian Coca
4549ea5e85 removed incorrect defaults from docs 2016-04-25 14:43:05 -04:00
Konstantin Gribov
ab53adad4b Escape spaces, backslashes when create new entry in fstab (#3193)
Supplement to PR #1454 and issue #530.

Fixes #3192.
Fixes #1861 (introduced by PR #1454).

Signed-off-by: Konstantin Gribov <grossws@gmail.com>
2016-04-25 10:09:19 -04:00
Toshio Kuratomi
1d25c41844 Merge pull request #3525 from madpilot78/freebsd-service-sleep
Make FreeBSD subclass respect the sleep option.
2016-04-23 08:22:21 -07:00
Guido Falsi
8aac5ae7ba Make FreeBSD subclass respect the sleep option. 2016-04-23 14:10:11 +02:00
Michael Scherer
e3cb90bc2f Change home and ssh_key_file to 'path' in user module 2016-04-23 10:49:55 +02:00
Joshua Kugler
05109d16ec Fix mount's handling of passno 2016-04-12 16:42:55 -08:00
Robin Roth
d3fa192968 use custom ismount function in mount module (#2737)
* based on cpython os.path.ismount
* includes patch from http://bugs.python.org/issue2466
* fixes #2186
* when the upstream bug is fixed this should be removed/rewritten
* use ismount from module_utils
2016-04-12 08:48:42 -07:00
René Moser
6a7dac5bdc Merge pull request #3168 from jdicarreira/hostname_sles10_11
Change hostname SLES 10 & 11
2016-03-23 11:23:48 +01:00
René Moser
f30f4674e4 Merge pull request #3239 from towolf/add_diff_and_check_mode_to_cron
Add diff and check mode to cron module
2016-03-20 17:49:21 +01:00
Toshio Kuratomi
345d9cbca8 Fix documentation. 2016-03-16 10:50:31 -07:00
Toshio Kuratomi
7f6810d6bf Remove the ignore_ohai and ignore_facter parameters as the functionality was merged into gather_subset 2016-03-14 15:05:20 -07:00
Yannig Perré
4c14108b7e Use list type in order to convert directly gather_subset option into list. 2016-03-14 09:31:18 -07:00
Yannig Perré
baf8109dcc Add a way to restrict gathered facts in Ansible:
- Using gather_subset options
- By ignoring ohai/chef or facter/puppet facts
2016-03-14 09:31:18 -07:00
Tobias Wolf
0edf689688 Add diff and check mode to cron module
supports not writing backup file in check mode and new environment
vars.

![example screenshot](http://i.imgur.com/mkAThq8.png)
2016-03-14 15:42:32 +01:00
Brian Coca
84501dbe13 docs updates and fixes
fixes http://github.com/ansible/ansible/issues/14876
2016-03-09 10:06:44 -05:00
Matt Davis
ad2b9b342d Merge pull request #1876 from davidobrien1985/devel
Custom Windows Facts
2016-03-04 17:31:24 +00:00
Joao Carreira
a7c3c82162 added support for sles 10 & 11 2016-03-02 12:33:15 +00:00
Brian Coca
8baecece22 corrected version added 2016-02-29 23:47:37 -05:00
Brian Coca
f0f8d27bff Merge pull request #2010 from lberruti/global_user_crontab_env_variables_rebase
cron module: add enviroment variables management
2016-02-29 23:39:55 -05:00
Toshio Kuratomi
91ac443e8f Set one parameter to be type path 2016-02-29 00:08:26 -08:00
davidobrien1
b33320d3f1 Restore filter on Windows and version reference for Windows facts. 2016-02-26 22:40:43 +11:00
David O'Brien
e4c2cb96ea Add documentation to setup.py and remove use of $params.fact_path in setup.ps1 2016-02-26 16:34:10 +11:00
Ton Kersten
d43d2bc219 Fix facter path
In Puppet 4 and in the PE edition, the Puppet tree is installed in
`/opt/puppetlabs/...` and all commands can be reached from
`/opt/puppetlabs/bin`.
2016-02-19 10:38:23 +01:00
Matt Martz
c7845456a6 Various simple linting type cleanups on modules 2016-02-16 15:58:44 -06:00
jjshoe
c18afbc1ab List which version it was added
fixes https://github.com/ansible/ansible-modules-core/issues/2605
2016-02-12 13:09:24 -06:00
Brian Coca
3d4b5d165c avoid chmod in check mode 2016-02-09 21:49:07 -05:00
Brian Coca
4e49df7b88 revamped checkmode support in user module
- defaulted to commands not executing in checkmode
- added force run for info gathering (for setting changed)
- added debug for what would have been run in check mode
- added check mode for spots that made changes using system calls instead of command
- removed now redundant checkmode checks

better failure now, if i missed anything, it will misreport changed value
instead of old default of actually making the change in checkmode
2016-02-09 10:45:42 -05:00
James Cammarata
b175b11a63 Merge pull request #2954 from mattclay/user-check-mode-aix
Make modify_user_usermod honor check mode on AIX.
2016-02-09 08:04:55 -05:00
Matt Clay
151f981ce5 Make modify_user honor check mode on OS X. 2016-02-04 01:29:56 -08:00
Matt Clay
2645113eda Make modify_user_usermod honor check mode on AIX. 2016-02-03 23:19:17 -08:00