Commit graph

27727 commits

Author SHA1 Message Date
rajaspachipulusu17
753f998262 Pluribus Networks ipv6 security reguard vlan module with UT (#58319) 2019-07-10 14:39:53 +05:30
Chris Archibald
8731fc7a86 returning invalid security (#58595) 2019-07-10 00:40:31 -04:00
Matt Clay
9e67953b2e
Fix collection loader and add unit tests. (#58701)
* Use `compile` before `eval` in collection loader.

This fixes two issues:

1. File names are available when tracing execution, such as with code coverage.
2. Future statements are not inherited from the collection loader.

* Add unit tests for collection loading.

These tests verify several things:

1. That unit tests can import code from collections when the collection loader is installed.
2. That tracing reports the correct file and line numbers (to support code coverage).
3. That collection code does not inherit __future__ statements from the collection loader.

* Update unit test handling of the collection loader.

Since the collection loader is installed simply by importing ansible.plugins.loader,
we may already have a collection loader installed when the test runs. This occurs if
any other tests are collected which use that import during collection. Until that code
is moved into an initialization function to avoid loading during import, the unit tests
will need to replace any existing collection loaders so that they reflect the desired
configuration.

* Insert into sys.modules before calling exec.

This is a requirement of PEP 302.

It will prevent recursion errors when importing the current module or using a relative import.

* Use the correct value for __package__ in modules.

This allows using relative imports in collections.

* Add warning about modifying code for trace test.

* Add test for relative import in collection.

* Add __init__.py to collection to satisfy pylint.

The relative-beyond-top-level rule in pylint may not be appropriate for collections.
However, until that rule is disabled for collections this will keep tests passing.
2019-07-09 17:31:33 -07:00
Benjamin R. Haskell
73a7a0877d Fix Pacman regex for unmatched Arch package name (#48558)
* Fix Pacman regex for unmatched Arch package name

`ansible -m pacman -a upgrade=yes $(hostname)` failed due to not
accounting for the `+` character in the `pacman -Qu` output line:

    libsigc++ 2.10.0-1 -> 2.10.1-1

Per the Arch wiki¹, package names can contain alphanumeric characters,
and any of {`@`, `.`, `_`, `+`, `-`}.

The existing `re` covered `_` (part of `\w` in Python), and `-`
(explicitly included). This change adds `@`, `.`, and `+` (in
ASCII-betical order).

¹: https://wiki.archlinux.org/index.php/Arch_package_guidelines#Package_naming

* Add explanation for `pacman -Qu` regex matching

* Remove unneeded non-capturing groups in regex
2019-07-09 20:14:14 -04:00
Shachaf92
25a6e97046 win_firewall_rule - update doc for remoteport dep. on protocol (#58796) 2019-07-10 05:58:52 +10:00
Jordan Borean
b6791e6ae3
ansible-galaxy: add collection sub command (#57106)
* ansible-galaxy: add collection init sub command

* Fix changelog and other sanity issues

* Slim down skeleton structure, fix encoding issue on template

* Fix doc generation code to include sub commands

* Added build step

* Tidy up the build action

* Fixed up doc changes and slight testing tweaks

* Re-organise tests to use pytest

* Added publish step and fixed up issues after working with Galaxy

* Unit test improvments

* Fix unit test on 3.5

* Add remaining build tests

* Test fixes, make the integration tests clearer to debug on failures

* Removed unicode name tests until I've got further clarification

* Added publish unit tests

* Change expected length value

* Added collection install steps, tests forthcoming

* Added unit tests for collection install entrypoint

* Added some more tests for collection install

* follow proper encoding rules and added more tests

* Add remaining tests

* tidied up tests and code based on review

* exclude pre-release versions from galaxy API
2019-07-10 05:47:25 +10:00
The Magician
d336a989e4 Bug fixes for GCP modules (#58848) 2019-07-09 14:35:35 -04:00
The Magician
9721c4045b Bug fixes for GCP modules (#58849) 2019-07-09 14:35:25 -04:00
The Magician
eb839c94ea Bug fixes for GCP modules (#58850) 2019-07-09 14:35:14 -04:00
The Magician
4eba84ce78 New Module: gcp_appengine_firewall_rule_facts (#58853) 2019-07-09 14:34:52 -04:00
Fred-sun
d1226b7663 Update azure_rm_subnet related document (#58445)
* Update azure_rm_subnet related document
2019-07-09 13:30:07 -05:00
shiro
a269c564c7 Delete the negation symbol "¬" by typo. (#58640)
* Delete the negation symbol "¬"

* Update lib/ansible/modules/packaging/os/yum.py

Co-Authored-By: Sandra McCann <samccann@redhat.com>
2019-07-09 12:27:42 -05:00
egalegal123
dbb1f01a56 Update vsphere_file.py (#58874)
wrong module name in examples
2019-07-09 11:58:43 -05:00
Fred-sun
de7776e25d Update azure_rm_virtualmachinescaleset related document (#58699) 2019-07-09 11:57:21 -05:00
Sebastian Boehm
612223773a Daemonize service start on OpenBSD, fixes #50460 (#58528) 2019-07-09 11:28:10 -04:00
Richlv
1d50d308fc Minor typo/language fixes in the documentation (#58856)
Minor typo/language fixes in the zabbix_map documentation
2019-07-09 18:15:28 +05:30
Miguel Angel Muñoz González
d50531c6bd New Fortinet's module for fortios_user_device (using new httpapi plugin) (#58291)
* New Fortinet's module for fortios_user_device (using new httpapi plugin

* Fix documentation errors

* Update lib/ansible/modules/network/fortios/fortios_user_device.py

Co-Authored-By: Sandra McCann <samccann@redhat.com>

* Update lib/ansible/modules/network/fortios/fortios_user_device.py

Co-Authored-By: Sandra McCann <samccann@redhat.com>

* Update lib/ansible/modules/network/fortios/fortios_user_device.py

Co-Authored-By: Sandra McCann <samccann@redhat.com>

* Update lib/ansible/modules/network/fortios/fortios_user_device.py

Co-Authored-By: Sandra McCann <samccann@redhat.com>

* Update lib/ansible/modules/network/fortios/fortios_user_device.py

Co-Authored-By: Sandra McCann <samccann@redhat.com>

* Update lib/ansible/modules/network/fortios/fortios_user_device.py

Co-Authored-By: Sandra McCann <samccann@redhat.com>
2019-07-09 15:53:36 +05:30
Sam Doran
1c2c1c15d0 dnf - fix error formatting of module name in error message (#58647) 2019-07-09 10:16:42 +02:00
pratikgadiya12
1f427249d5 Fixed examples module name in udm_dns_record (#58814)
Fixes: 58813
2019-07-09 12:52:02 +05:30
Will Thames
446919de6f Add apply to k8s module (#49053)
* Add apply to k8s module

Use apply method for updating k8s resources.

* Improve apply documentation

* k8s: Make apply and merge_type mutually exclusive
2019-07-08 13:47:41 -07:00
Dusan Matejka
105f60cf48 unified required zabbix-api dependency version and removed no longer needed extend of ZabbixAPI class (#53334) 2019-07-08 15:46:25 -04:00
Shachaf92
7ddcaafee5 many pslint fixes (#55862)
* Handles:

PSAvoidTrailingWhitespace
PSAvoidGlobalVars
PSAvoidAssignmentToAutomaticVariable
PSAvoidUsingCmdletAliases
PSAvoidUsingWriteHost
PSUseDeclaredVarsMoreThanAssignments
PSUsePSCredentialType
PSAvoidUsingPositionalParameters
PSAvoidUsingEmptyCatchBlock
PSAvoidUsingWMICmdlet

Replaced Write-Host with Write-Output
Added smart reboot check for win_domain feature installation
Modify the Creation of the pagefileto fit to CIM
Changelog fragment addition
Ignore.txt without fixes

* Changes after community reviews

* Change Out-Null to '> $null'

* Fixes after jborean93 comments

* Test

* Revert "Test"

This reverts commit 35c5c0648fa9d2868a18094d84954e53ffa28880.

* Removed all  > $null since they broke the module since the output got dumped

* run test again

* Revert "run test again"

This reverts commit 80eaf07143f9d8cb0116cbbc68a6a69c0ace840c.

* Changes after community review

* ignore PSUseDeclaredVarsMoreThanAssignments that are on a diffrent PR

* CI failed on extra line in ignore.txt

* Review changes

* PSlint errors

* Trail space

* send to null breaks the tests for  Set-Workgroup

* Lint stuff

* win_domain_user issue of indent.

* Update win_domain_user.ps1

* Update win_domain_membership.ps1

* Fix redirect to null

* lint space issue

* removed return from set-workgroup

* removed send to null
2019-07-09 05:41:58 +10:00
Max Calzavara
5689cc08ce Add examples (#58819)
* Add examples to the ios_vlan docs: vlan using aggregate and move vlan interface example
2019-07-08 14:10:10 -05:00
Nicolas Boutet
6a5bc5f206 Fix wrong unit in documentation example of ec2_metric_alarm (#58622) 2019-07-08 14:07:28 -05:00
Will Thames
88364d4cfd Add purge_tags to s3_bucket to allow preservation of existing tags (#58754)
* Add purge_tags to s3_bucket to allow preservation of existing tags

Adding `purge_tags` with default `True` to maintain existing behaviour
allows users to set it to `False` to preserve existing tags

Fixes #29366

* s3_bucket: Add further tests and improve tag handling further

Additional tests for purge_tags: False suggested some incorrect
logic and thus further improvements

Increase wait timeout on bucket deletion as it wasn't always completing
in the default 100 seconds
2019-07-08 10:19:01 -07:00
François Deppierraz
737da1853e os_user_role: add support for named domain (#49891)
Fixes #49859.
2019-07-08 09:26:15 -04:00
Abhijeet Kasurde
79fdc2190a role: Fix role's hash_params (#55263)
* role: Fix role's hash_params

Fix based upon work done by alikins.

Fixes: #20596

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>

* review comments

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-07-08 09:25:59 -04:00
AndyG
894d19b108 Update ec2_snapshot.py (#58753)
ansible ec2_snapshot ValueError: time data '2019-05-27T12:08:49.929Z' does not match format '%Y-%m-%dT%H:%M:%S.000Z'
2019-07-08 19:20:47 +10:00
Lindsay Hill
5b2d1cc24d Fix broken slxos_config due to changed backup options (#58804) 2019-07-08 09:28:53 +05:30
Lindsay Hill
2eb499cbb3 Minor typo in sros_config docstrings (#58803)
Changed `f` to `If`
2019-07-08 07:58:12 +05:30
Diane Wang
9c140d26d5 VMware: add new module vmware_guest_network (#52075) 2019-07-08 07:54:54 +05:30
Shachaf92
5b953581b4 win_domain_user - MAke the query user try catch block more accurate (#58782)
* win_domain_user - MAke the query user try catch block more accurate for missing identity

* change to minor_changes

* Update win_domain_user-make-query-try-catch-accurate.yml

* Update win_domain_user-make-query-try-catch-accurate.yml
2019-07-08 07:13:48 +10:00
Dominik Holler
6e4c2c61bd Remove redundant line in os_port (#57838)
* Remove redundant line in os_port

The renaming of the key 'vnic_type' to 'binding:vnic_type'
is reduced to a single line.
The old key is removed to avoid to possibility of
inconsistency.

* Add missing parameter in example of os_port

In the example "Create port of type 'direct'" the parameter
"network" is added, because this parameter is required on
creating new ports.
2019-07-07 05:00:09 -04:00
Josh VanDeraa
73db7e2901 Changed command for next-hop-self to next-hop-self instead of activate (#58789) 2019-07-07 02:09:10 +05:30
Klaas Demter
faf50dbace Fix nagios module to recognize if file exists and is fifo pipe (#58569)
add felixfontein suggestion to changelogs/fragments/58569-nagios-fifo-fix.yaml

Co-Authored-By: Felix Fontein <felix@fontein.de>
2019-07-06 22:37:23 +02:00
smile37773
8ff97edd1a Add the singlePlacementGroup in the virtual machine scale set module (#58320) 2019-07-06 06:14:14 +08:00
Joseph
4f642daae5 Correct machinectl become plugin function arguments (#58734)
* Correct get_option function name and change flags to become_flags

* Remove the '--' from the returned command

* add changelog fragment

* change changelog fragment description

* move the -q argument to machinectl before the shell argument to resolve issues with machinectl v230 (see #56571)
2019-07-05 11:03:24 -04:00
Dag Wieers
61647731e2
Fix regression in cron module (#58751)
This reverts the changes to cron from #28662

This fixes #58493
2019-07-05 15:02:29 +02:00
Nilashish Chakraborty
709fbcf804
Fix fetching existing AS (#58756)
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
2019-07-05 18:03:08 +05:30
Nilashish Chakraborty
83f92987b8
Change default behaviour for network resource facts (#58750)
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
2019-07-05 17:30:35 +05:30
Abhijeet Kasurde
5e2471485a
VMware: Warn user about dvswitch permissions (#58579)
Warn user about dvswitch permissions since permissions for
a distributed switch must be defined and managed on either
the datacenter or a folder containing the switch.

Fixes: #55248

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-07-05 17:11:25 +05:30
Sunil Raj
641f7c4ae3 VMware: Updates the DRS rule without deletion (#57119)
* The DRS rule will be updated if any changes in the configuration without deleting the existing rule.
The rule itself is updated by the given configuration.
* Lint errors fixed
* VMware: update vmware_vm_vm_drs_rule testcases
2019-07-05 17:00:05 +05:30
Ganesh Nalawade
ff4001f470
Update junos module utils (#58730)
*  Add utils fucntion to build xml
   subtree
2019-07-05 12:21:38 +05:30
Abhijeet Kasurde
1bd91279d0
Fixed fail_json call in command module (#58615)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-07-05 11:00:10 +05:30
Trishna Guha
5c5d9ad669
Refactor nxos_facts to support resource module (#58705)
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2019-07-05 09:26:33 +05:30
Shachaf92
a6b7d0d00b win_domain_user and win_domain_group: add created result boolean (#57901)
* win_domain_user and win_domain_group: add created result boolean

* Fix YML

* add docs

* brackets

* Update win_domain_group.py

* Update win_domain_user.py

* Update win_domain_user.ps1

* fix indent
2019-07-05 08:44:07 +10:00
Shachaf92
07edcab051 win_acl: Fix problems with special IDRef in different languages than english (#57281)
* Change special id ref recognitionto avoid language diff

* Changelog added

* specialIdRefPrefixes to array

* Changed to the more generic option
2019-07-05 08:08:23 +10:00
Shachaf92
e0b8bc1ef9 win_firewall_rule: Only report changed when change is made (#57267)
* Fix bug https://github.com/ansible/ansible/issues/44450

* Added tests

* I will make this CI work

* Update win_firewall_rule.ps1
2019-07-05 08:06:34 +10:00
Shachaf92
6e319ff088 win_psmodule - Missing SkipPublisherCheck in Prerq installations (#58090)
* win_psmodule - Missing SkipPublisherCheck in Prerq installations

* Handle different minors of PS5

* community revisions

* Update win_psmodule.ps1
2019-07-05 08:00:58 +10:00
PRASOON KARUNAN V
db5656cf6e Add support for pester tags (#57918)
* correct argument name

* added documentation

* adding missing version_added to doc

* correcting description in docs

* change type to list

* add tests

* correct test file
2019-07-05 07:45:52 +10:00