Commit graph

27320 commits

Author SHA1 Message Date
Fred-sun
2cb3094b68 Update azure_rm_mysqlconfiguration related document (#57335) 2019-06-04 09:41:00 -04:00
Fred-sun
15034fb5b5 Update azure_rm_mysqldatabase related document (#57338) 2019-06-04 09:37:22 -04:00
Abhijeet Kasurde
ee8a607cca ipaddr: Handle network address in ipmath (#57149)
* Updated testcase, documentation

Fixes: #54457

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-06-04 14:01:18 +05:30
Sumit Jaiswal
e620e27609
PR to fix the bug 57215 & 56300 under Nios Host_Record module (#57221)
* fix bug 57215 & 56300

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* fix bug 57215 & 56300

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* shippable error fix

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* review comment fix

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
2019-06-04 10:52:16 +05:30
Sandeep Kasargod
78f6a7cbb1 New module for managing export groups in Vexata storage arrays. (#55481)
* Vexata export group module.
* Fix messages / error handling paths.
2019-06-04 10:05:40 +05:30
Chris Van Heuveln
6bb13bbb84 nxos_vlan: fix broken purge behavior (issue #57101) (#57229)
* nxos_vlan: fix broken purge behavior (issue #57101)

Symptoms/Analysis:
- `nxos_vlan` `purge: true` would fail when `purge` was trying to delete all unspecified vlans, including vlan 1.
- `nxos` devices do not allow removing vlan 1 and raise a cli exception error
- Previous fix #55144 caused a side effect when `purge` was used: vlan changes specified by `aggregate` were ignored; e.g.
 - vlan 4 is not present; playbook specifies `aggregate: { vlan: 4 }, purge: true`
 - results in proper purging but vlan 4 is not created

Solutions:
- ignore vlan 1 when purging
- remove the `not purge` check from state present logic

Added additional unit tests and integration tests.
Tested against all regression platforms.

* PEP fixes

* Add agg_show_vlan_brief.txt fixture

* Add warning for removing vlan 1

* change method name check
2019-06-04 09:14:09 +05:30
Aaron Smith
333f54ec3b cloud/amazon/aws_config_recorder: add empty resourceTypes list if undefined (#50286) 2019-06-03 15:45:38 -07:00
Mikhail Naletov
8cf6f56a01 Added sort option for zabbix_screen module (#56237)
* Added sort option for zabbix_screen module

* FIX: sort variable

* Added changelog file

* Fixed misspelling

* Update lib/ansible/modules/monitoring/zabbix/zabbix_screen.py

Changed spelling in the documentation

Co-Authored-By: flowerysong <junk+github@flowerysong.com>
2019-06-03 21:23:20 +02:00
Felix Fontein
7b40b569b2
Rename memset_*_facts to memset_*_info (#57030)
* Rename memset_*_facts to memset_*_info

* Add changelog.
2019-06-03 21:19:49 +02:00
Stefan Horning
ddfaa83ccf s3_bucket: add encryption capabilities to the module (#55985)
* s3_bucket: add encryption capabilities to the module
2019-06-03 11:25:09 -07:00
Fred-sun
3587f346c0 Update azre_rm_mariadbfirewallrule related document (#57288) 2019-06-03 12:51:02 -05:00
Fred-sun
ceb91ef80a Update azure_rm_mariadbdatabase relate document (#57287) 2019-06-03 12:49:38 -05:00
Martin Nečas
ea939c7e3e ovirt vnic profile update readme (#57298)
removes second of two identical examples
2019-06-03 11:35:10 -05:00
Piotr Gbyliczek
ec511e84bc Update azure_rm_appgateway.py (#56780)
* Update azure_rm_appgateway.py documentation to explain the dependency of authentication_certificates on cookie_based_affinity being enabled
2019-06-03 10:44:15 -05:00
Fred-sun
2d5c9e06fa Update azure_rm_manageddisk related document (#57206)
* Update azure_rm_manageddisk related documentation
2019-06-03 10:32:02 -05:00
Abhijeet Kasurde
0f10c4e8d2 aws: Handle exceptions while describing metric alarm (#57304)
Handle exceptions raised while describing the metric alarms rather than
printing tracebacks.

Fixes: #55786

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-06-03 11:23:53 -04:00
schowave
e6166b40cc Fixes typo in get_url (#57305)
Fixes Typo, need instead of ned
2019-06-03 20:36:48 +05:30
Fred-sun
6306f18fc3 Update azure_rm_loganalyticsworkspace related module document (#57158)
* Update azure_rm_loganalyticsworkspace related module documentation
2019-06-03 10:05:20 -05:00
Marcello Barnaba
0e25f8aef2 Add find module patterns option use cases documentation (#57089)
* Specify that the pattern is matched against the dirent basename
* Specify that regexen must match the whole name of the dirent. It has been a pitfall for me.
2019-06-03 10:00:15 -05:00
Andrey Klychkov
86be0985ce removed_module func: removed extra spaces from msg and docstring (#57209) 2019-06-03 10:00:19 -04:00
Sam Doran
2e0229a4b6 ansible-vault: convert vault_password_files to list to prevent traceback (#57186)
* Convert vault_password_files to a list

* Add changelog and tests
2019-06-03 12:14:06 +02:00
Sloane Hertel
21cd24a0dd improve conditional warnings (#57190)
* Fix order for warning on templated conditionals

Fix bare variable warnings when the variable is a boolean

* changelog

* Add tests for cases that should and should not give warnings

If the behavior may change when the default behavior for CONDITIONAL_BARE_VARS becomes False there should be a warning. Boolean type conditionals will not change in behavior so don't warn.

* oops, forgot to add files

* typo
2019-06-03 12:12:32 +02:00
Andrey Klychkov
fecffea370 postgresql_db: add note to doc about pg_dump (#57297)
* postgresql_db: add note to doc about pg_dump

* Update lib/ansible/modules/database/postgresql/postgresql_db.py

Co-Authored-By: Abhijeet Kasurde <akasurde@redhat.com>
2019-06-03 05:19:06 -04:00
Andrey Klychkov
96bf243265 New module postgresql_copy: copy data between a file and a table (#56835)
* New module postgresql_copy

* New module postgresql_copy: added tests

* New module postgresql_copy: changed tests

* New module postgresql_copy: doc format fixes

* New module postgresql_copy: fixes

* New module postgresql_copy: added upper, PostgreSQL

* New module postgresql_copy: fixed description

* New module postgresql_copy: added note about superuser

* New module postgresql_copy: remove SQLParseError

* New module postgresql_copy: fixed opt_need_quotes type

* New module postgresql_copy: fixed check_mode

* New module postgresql_copy: small fix
2019-06-03 19:11:50 +10:00
René Moser
0c66a5d3ca
cloudcscale_floating_ip: add types (#56924) 2019-06-03 10:43:32 +02:00
rajaspachipulusu17
6b2688245e Pluribus Networks ipv6security raguard port module with UT (#57033)
* Pluribus Networks ipv6security raguard port module with UT

* Dox fix
2019-06-03 11:44:28 +05:30
rajaspachipulusu17
b8a317c527 Pluribus Networks vrouter packet relay module with UT (#57155)
* Pluribus Networks vrouter packet relay module with UT

* Doc fix
2019-06-03 11:43:29 +05:30
Felix Fontein
b33c9dad40 Improve docs w.r.t. networks_cli_compatible. (#56971) 2019-06-02 23:38:21 -04:00
Dodge245
012609b09a VMware: Update doc for num_cpus and num_cpu_cores_per_socket calculation (#57227)
Updated document to explain num_cpus is multiple num_cpu_cores_per_socket.
2019-06-02 17:39:33 +05:30
Abhijeet Kasurde
c8eda7773e
VMware: Update vmware_guest_powerstate (#57000)
* Updated documentation
* Updated testcases
* Updated example
* Updated logic
* Provided option to specify task name, task description, task enable status etc.

Fixes: #56987

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-06-01 08:10:05 +05:30
Fabrice
7364e79c0d k8s: Fix .to_dict not needed (#56147)
* k8s: Fix .to_dict not needed

* Add changelog fragment
2019-06-01 11:42:48 +10:00
Matt Martz
8bd4e2a144 cert validation fixes - Attempt 2 (#55953)
* Attempt 2 of cert validation fixes

* Remove unused code

* Cleanup the tmp cert using atexit

* Fix linting issues

* Only add SSLValidationHandler when not HAS_SSLCONTEXT

* Catch value errors on non PEM certs

* Only catch NotImplementedError to avoid masking issues

* set self._context even with PyOpenSSLContext for conformity

* Fix error building

* normalize how we interact with the context we create

* Remove unused code

* Address test for py3.7 message difference

* open_url should pass the ca_path through

* Account for new error in url lookup test

* Guard some code behind whether or not we are validating certs

* Make _make_context public

* Move atexit.register up to where the tmp file is created
2019-05-31 16:35:25 -04:00
Paddy Newman
2ef7759be1 Allow syslog_json callback options to be set in an Ansible configurat… (#57232)
* Allow syslog_json callback options to be set in an Ansible configuration file.

The syslog_json documentation says that it supports options via an Ansible
configuration file. In fact, they can only be specified via environment
variables.

I've updated the module to use the standard "get_options" handling which means
that it can now support options via environment variables *or* the
configuration file.

Options can be set in the configuration file as follows:

```
callback_whitelist = syslog_json

[callback_syslog_json]
syslog_server = localhost
syslog_port = 514
syslog_facility = user
```

* Use the original, documented, names for the modules options.

In the documentation text change syslog_server to server, syslog_port to port
and syslog_facility to facility.

* Add an item to the changelog.

* Update 57232-syslog-json-configuration-options.yml

Fix a YAML syntax error / typo.
2019-05-31 14:29:15 -04:00
Dag Wieers
fd95c7b506 Fix CI issue 2019-05-31 14:12:20 -04:00
Julian Paul Dasmarinas
e1d0795aa3 beadm: Make creation of boot environments in snapshot format idempotent 2019-05-31 14:12:20 -04:00
Andrew Klaus
d8bf4f1ebb Adding support for OpenBSD syspatch (#55561)
* Initial commit

* Fixing issue where applying always returned changed status

* Adding return variables: reboot_needed, rc, stderr, stdout, warnings
2019-05-31 13:42:01 -04:00
Nathaniel Case
4142cd595e
Plugin paths need to be sent in exectutor, too (#57126)
* Combine `_start_connection` methods into executor
2019-05-31 11:44:42 -04:00
Rohit
ae033f1ec3
vyos interfacefix and test cases (#57169)
Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>
2019-05-31 16:13:40 +05:30
Sebastiaan Mannem
223f509ea3 Issue 56430 (#57147)
* Adding integration test for 127.0.0.1/32 and ::1/128.

* Making sure file is not corrupted when render fails

* Fixes #56430

* Adding changelog for MR 57147/Issue 56430
2019-05-31 12:32:28 +02:00
Fred-sun
94b711bac5 Update azure_rm_mariadbconfiguration related document (#57207) 2019-05-31 13:46:08 +08:00
Fred-sun
3ef09496a3 Update azure_rm_hdinsightcluster related document (#57037)
* Update azure_rm_hdinsightcluster related documentation
2019-05-30 10:34:38 -05:00
Ondra Machacek
6bceea4f51 kubevirt: Rewrite merge dict method 2019-05-30 07:41:21 -07:00
Richlv
94e2d87b2f suggest to use sequential IDs (#57142)
##### SUMMARY
Suggest to use sequential IDs - otherwise action is considered to be changed always.


##### ISSUE TYPE
- Docs Pull Request

+label: docsite_pr
2019-05-30 10:39:59 -04:00
Fred-sun
42acf740e4 Update azure_rm_loadbalancer relate module document (#57154) 2019-05-30 10:37:51 -04:00
Fred-sun
511c385da6 Update azure_rm_functionapp related document (#56985)
* Update azure_rm_functionapp related documentation
2019-05-30 09:33:11 -05:00
Fred-sun
df442751f7 Update azure_rm_dnszone related document (#56984)
*  Update azure_rm_dnszone related documentation
2019-05-30 09:31:12 -05:00
Fred-sun
a7e53906a6 Update azure_rm_dnsrecordset relate document (#56895)
* Update azure_rm_dnsrecordset related documentation
2019-05-30 09:25:16 -05:00
Mariusz Mazur
cac34ac568 kubevirt_pvc: improve failure handling (#57163) 2019-05-30 05:14:27 -04:00
Tim Hunter
4c00fc7b32 update pkg_mgr.py for Amazon Linux support (#56618) 2019-05-30 10:18:31 +02:00
Kevin Breit
5008e1d479 meraki_config_template - Enable check mode (#54502)
* Add support for check mode

* Check mode returns proper changed status
- Added is_template_valid()
- Restructured check_mode so it will always return data
- Check mode should show proper changed status
- Code is untested and integration tests need to be expanded

* Fix deleting networks
- Add integration tests for deleting networks
- Refine tests based on changed/unchanged

* Remove one task from integration test
2019-05-29 16:30:26 -04:00
Kevin Breit
4df53f869e meraki_network - Add support for disableRemoteStatusPage (#48971)
* Add support for disableRemoteStatusPage
- New feature in the Meraki API
- Yes, it's a double negative, I may fix at some point

* Remove double negative
- All disables became enable and logic is reversed
- This isn't yet tested

* Switching computers!!!

* Apply changes to make the logic work, even reversed

* Attempt to fix some formatting errors

* Add documentation fragment

* Fix whitespace

* Add disable_my_meraki back, with deprecation notice

* Edit changelog notice

* Update deprecation version

* Update example to be a block and change deprecation message.

* Remove duplicate delegate_to

* Change deprecation notice.
2019-05-29 16:29:40 -04:00
Kevin Backhouse
79bb7bde5f apt_repository: Fix crash caused by cache.update() raising an IOError on timeout. (#51996)
* Fix crash caused by cache.update() raising an IOError on timeout.

* Add changelog fragment.
2019-05-29 15:59:51 -04:00
Felix Fontein
c47e9d22b4
Rename one_image_facts -> one_image_info (#57035)
* Rename one_image_facts -> one_image_info.

* Add changelog.

* Forgot symlink.
2019-05-29 21:23:25 +02:00
Fred-sun
ba18dd713a Update document related with azure_rm_keyvault module (#57110) 2019-05-29 14:15:36 -05:00
Fred-sun
163d3efbf8 Update azure_rm_image relate document (#57043) 2019-05-29 14:12:36 -05:00
szymon3
00067c8d54 Update rabbitmq_queue.py (#56912)
change description for when `state=absent`
2019-05-29 13:57:05 -05:00
Ian Wienand
39945b8570 Make query with errors='ignore' return a blank list (#57038)
The jinja2 query() function (or lookup with wantslist=True, which is
the same thing) should always return a list.

However, if you combine a query with errors='ignore' and take the
error path, the current code returns a None value.  This is important
in a case such as

 - name: Conditional include file
   import_tasks: '{{ item }}'
   vars:
     params:
       files:
         - path/file1.yaml
         - path/file2.yaml
   loop: "{{ q('first_found', params, errors='ignore') }}"

If neither file1.yaml or file2.yaml exist, this should do nothing by
returning an empty list to the loop.  Currently if you run the above
task you'll get a rather unhelpful:

 Invalid data passed to 'loop', it requires a list, got this instead: .

This change ensures that when a query ignores an error, it returns a
empty list.  The errors='ignore' case is tested in several variants
with first_found.  The extant (but deprecated) "skip: True" for
first_found doesn't seem to be explicitly tested; a test is added here
to avoid regressions before removal in 2.12.

This fixes a regression you'll hit if you follow the suggestion in the
deprecation message included with
e17a2b502d to use errors=ignore over
"skip: True" for first_found.  This change adds an example that points
out the query/lookup difference and also fixes the error message to
not mention the now deprecated "skip: True".

Closes #56775
2019-05-29 13:23:02 -04:00
xuxiaowei0512
b7f4e2a190 update ospf modules to fix bugs as software version changes (#56974) 2019-05-29 12:40:30 -04:00
xuxiaowei0512
0137c4343b update ce_ntp.py and remove the root tag name to find all nodes (#56976)
* add a maintainer

* update ce_ntp.py and remove the root tag name to find all node

* update ce_ntp.py and remove the root tag name to find all node
2019-05-29 12:39:37 -04:00
xuxiaowei0512
9e1f184b2d add terminal initial prompt for initial connection (#57057) 2019-05-29 12:37:13 -04:00
Pilou
e5b2e4c1ac tower_credential: ssh_key_data isn't a path anymore (#57113) 2019-05-29 11:15:45 -05:00
Fred-sun
8043940c93 Update azure_rm_devtestlabvirtualmachine relate document (#56828)
* Update azure_rm_devtestlabvirtualmachine documentation
2019-05-29 11:03:42 -05:00
Kevin Breit
7864df8cb9 meraki - Rewrite update requirement check (#48394)
* Rewrite idempotency check
- Check now operates recursively and works on multiple types
- Order of lists matter

* Remove blank line for lint

* Fixed idempotency checks in meraki_ssid
- New sanitize() method for finding keys unique in compared dicts
- Fixed bug in meraki_ssid where SSID specified by number breaks
  - This will require a backport
- Converted ignored_keys from tuple to list

* Made changes required for idempotency

* Add changelog fragment

* Add unidirectional option for testing

* Disable option 1 check

* General fixes for is_update_required testing
- Added commented out debug statements in method
- Fixed ignored_keys modifications

* Remove old commented algorithm
2019-05-29 10:18:01 -04:00
Kevin Breit
57e1063fc7 meraki_config_template - Remove mandatory network lookup (#56525)
* Module only makes network lookups when needed instead of every execution

* Formatting fixes
2019-05-29 19:27:38 +05:30
Rohit
b143918f30
text format fan info mismatch and module info check (#57009)
Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>
2019-05-29 19:08:46 +05:30
MyronFanQiu
a56a9e1eeb switch the deletion order (#57102) 2019-05-29 17:11:54 +08:00
Abhijeet Kasurde
2cf1dfc415 Fixed misc typos (#57103)
* Changed immuteable to immutable
* Changed conig to config

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-05-29 08:56:05 +02:00
Daniel Mellado Area
0ada6b8d8d Fix junos_facts test (#57065)
This commit fixes a non-passing junos_facts integration test, as it was
using a non-ordered frozenset to assert its result.
2019-05-28 20:25:45 -04:00
ShachafGoldstein
486370a744 Fix win_iis_virtualdirectory to remove a virtual directory that contains children (#56569)
* FIX #49755

* Added changelog fragment

* Changes according to review

* Fixed changelog
2019-05-29 05:59:50 +10:00
ShachafGoldstein
4490c0ba51 correct behaviour of win_iis when using site_id if site not found (#56567)
* Fixed #47057

* Fix trailing whitespace

* Change for review
2019-05-29 05:31:00 +10:00
ShachafGoldstein
94566ed79c Win_hostname module: Change name check to WMI (#56420)
* Change name check to WMI

* Changelog fragment

* Fixed per review
2019-05-29 05:30:16 +10:00
Ilya Zonov
35c8739c2a Add full change check for rabbitmq policy (#19073)
Add check for all policy fields (name, apply_to, pattern, tags,
priority) to have correct changed state. Previosly changed state was
based on policy name only.

* Add support for rabbitmq 3.7
* Fix exec args for rabbitmqctl status
* Add changelog and fix description for Ansible 2.9
2019-05-28 15:06:06 -04:00
Tyler Hartley
1d22909f7c Make second group match of ufw status output optional (#56678)
* Make second group match of ufw status output optional

Fixes #56674

* Fix comparison logic.

* Add changelog fragment
2019-05-28 20:54:11 +02:00
Felix Fontein
86928a5f74
docker_image: fix module failing when build option is used without specifying path (#56940)
* Fix module failing when build option is used without specifying path.

* Add changelog.
2019-05-28 20:48:08 +02:00
Felix Fontein
56e2d48612
docker_image: fix default handling of old docker-build options nocache and rm (#56610)
* Fix usage of nocache parameter.

* Fix defaults.

* Add changelog.
2019-05-28 20:47:31 +02:00
Nathaniel Case
1b66a13186
Fix flow in eos_l2_interface (#57059)
* Also fix test debug labels
2019-05-28 14:06:57 -04:00
Matt Williams
cf00883c9d Return results even when the cache is disabled (#55505)
* Return results even when the cache is disabled

By default the cache is disabled and so the results of the API call
are not placed in there for the return statement to fetch.

* Always update self._cache to return
2019-05-28 13:44:00 -04:00
The Magician
a837cc5694 Bug fixes for GCP modules (#55976) 2019-05-28 13:43:19 -04:00
The Magician
713ac29054 Bug fixes for GCP modules (#56689) 2019-05-28 13:42:12 -04:00
The Magician
0ff62fd5c4 Bug fixes for GCP modules (#56764) 2019-05-28 13:41:51 -04:00
The Magician
70ac35da3e Bug fixes for GCP modules (#56765) 2019-05-28 13:41:36 -04:00
The Magician
2220b9c851 Bug fixes for GCP modules (#56766) 2019-05-28 13:41:19 -04:00
Paul Belanger
532de89b44
Fix exception with load_provider function (#56959)
It is possible for provider.authorize to exist, but set to None. Rather
then loading this value blindly, assume the default is False.

   File "/home/zuul/src/github.com/ansible/ansible/lib/ansible/executor/task_executor.py", line 145, in run
     res = self._execute()
   File "/home/zuul/src/github.com/ansible/ansible/lib/ansible/executor/task_executor.py", line 635, in _execute
     result = self._handler.run(task_vars=variables)
   File "/home/zuul/src/github.com/ansible/ansible/lib/ansible/plugins/action/ios.py", line 50, in run
     provider = load_provider(ios_provider_spec, self._task.args)
   File "/home/zuul/src/github.com/ansible/ansible/lib/ansible/module_utils/network/common/utils.py", line 424, in load_provider
     provider['authorize'] = boolean(provider['authorize'])
   File "/home/zuul/src/github.com/ansible/ansible/lib/ansible/module_utils/parsing/convert_bool.py", line 26, in boolean
     raise TypeError("The value '%s' is not a valid boolean.  Valid booleans include: %s" % (to_text(value), ', '.join(repr(i) for i in BOOLEANS)))

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2019-05-28 12:19:34 -04:00
Brian Coca
1a893a48a3
Allow finer grained control for dupe YAML keys (#56933)
* Allow finer grained control for dupe YAML keys

  fixes #16903

* expand option to handle errors

* remove clog for previous version of toggle

* added missing parens

* fix typoe
2019-05-28 11:57:16 -04:00
Brian Coca
615db8e6f4
clarify package facts errors and warnings (#56060)
* clarify package facts errors and warnings

  fixes #56056
2019-05-28 10:01:47 -04:00
Ankur Gupta
a40dc1174e Add support to start a vm and put it on hold in one_vm (#56841)
* Add support to start a vm and put it on hold in one_vm

* Add version_added to vm_start_on_hold option for one_vm

* Add version_added to vm_start_on_hold option for one_vm#2

* Add version_added to vm_start_on_hold option for one_vm#3

* Fix indentation for one_vm
2019-05-28 07:58:13 -04:00
Felix Fontein
61b48778a7
Rename _facts -> _info (#57028) 2019-05-28 13:43:04 +02:00
Felix Fontein
d8dcd20294 docker_container: fix container creation with networks_cli_compatible=yes (#56687)
* Fix behavior.

* Add changelog.

* Add simple test to prevent #56620.
2019-05-28 03:19:52 -04:00
Andrey Klychkov
baac1df935 New module mysql_info - Gather information about MySQL servers (#55434)
* New module mysql_info: collect info about MySQL server instance

* mysql_info - CI tests

* mysql_info: fixes

* mysql_info: fixes Decimal

* mysql_info: fixes Decimal converters.py

* mysql_info: fixed err conn message and check_mode

* mysql_info: added decimal.Decimal to lib/ansible/parsing/ajson.py

* mysql_info: convert Decimal to float

* mysql_info: fix

* mysql_info: fix

* mysql_info: returned the args list as it was

* mysql_info: fix typo

* mysql_info: fixes

* mysql_info: removed aliases for login_db

* mysql_info: changed RETURN condition info

* mysql_info: fixed doc

* mysql_info: fixed role's parsing

* mysql_info: fixed role's parsing

* mysql_info: fixes

* mysql_info: fixed integration tests
2019-05-28 09:10:12 +02:00
ShachafGoldstein
f137527201 $result.reboot_required = $feature_result.RestartNeeded (#56419)
* $result.reboot_required = $feature_result.RestartNeeded

* Update relevent PSLint ignores

* CI Problem with pslint and ignore.txt
2019-05-28 01:21:56 -04:00
Abhijeet Kasurde
c6ba5eb8a0 Remove unnecessary pass (#56992)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-05-28 12:43:22 +08:00
Yury V. Zaytsev
fcfc122205 route53_facts: add check mode support (#56900)
* route53_facts: add check mode support

* route53_facts: add changelog fragment mentioning check mode support

* route53_facts: alter changelog fragment type from `minor_changes` to `bugfixes`

* Update changelogs/fragments/56900-route53-facts-check-mode.yaml

Co-Authored-By: Felix Fontein <felix@fontein.de>
2019-05-27 23:44:55 +02:00
Felix Fontein
7a0af34ba9
First batch _facts -> _info rename. (#56822) 2019-05-27 18:17:42 +02:00
Robert Bridge
0d75e2659e GH-56902 Copy to new list from dict.items() return
dict.items() in pytho2 returns a list of tuples which can be iterated
while modifying the dict. In python 3 it returns a view which is tied to
the underlying dict, meaning the modifications to the dict while
iterating are unsafe.

This commit generates new list containing the tuples from the iterator
in python 3 which breaks the link to the dict, allowing the dict to be
modified while iterating the list.

In python 2 it would simply copy the list.

Fixes #56902
2019-05-27 10:16:17 -04:00
Andrey Klychkov
a946d5d8ce postgresql_owner: added docstrings (#57010) 2019-05-27 08:04:58 -04:00
Martin Ouimet
398f4b8233 Added the 'show commit config diff' output available from the IOSXR device (#54875) 2019-05-27 17:30:14 +05:30
Andrey Klychkov
c0fd1bef7c postgresql_info: removed deprecated checks, added doc strings (#57005) 2019-05-27 07:13:22 -04:00
rajaspachipulusu17
19a78bdc7b Pluribus Networks vrouter bgp module with unit test cases (#56434)
* Pluribus Networks vrouter bgp module with unit test cases
* Sanity fixes
2019-05-27 11:53:57 +05:30
Lukas Kämmerling
7f08de6b6c hcloud_volume attach step should be idempotent (#56906) 2019-05-27 07:48:48 +02:00
Klaus Frank
8f89d1d3da VMware: Fix python 3 incompatibility (#54123)
Add Python2 and Python3 compatible `string.translate` for hostname customzation.

Fixes: #54118
2019-05-27 11:10:49 +05:30