Commit graph

43270 commits

Author SHA1 Message Date
Tony Finch
ccad79d162 get_url: return no change in check mode when checksum matches (#53070)
Signed-off-by: Tony Finch <dot@dotat.at>
2019-03-01 09:53:28 +00:00
Michael Miko
00efa26cdb Do not delete duplicate host when fetching Zabbix Hosts (#53160) 2019-03-01 09:51:39 +00:00
Yunge Zhu
75abb27677 fix class name (#53162) 2019-03-01 15:32:29 +08:00
Yunge Zhu
861b710c73
fix keyvault auth in msi auth (#53100) 2019-03-01 15:26:34 +08:00
Chris Adams
14d4a4fc3b docs: SAN prefixes are required for openssl_csr (#53144)
The openssl_csr docs use “should” where (at least following IETF nomenclature) “must” would be more accurate.

See #53141 

+label: docsite_pr
2019-03-01 01:26:00 -05:00
Matt Clay
eeaff731de
Overhaul ansible-test cloud test plugins. (#53044) 2019-02-28 18:25:49 -08:00
Matt Davis
9c644d9bcc
interpreter discovery message tweaks (#53155)
* fixes #53120 (doclink generator now understands devel)
* added hosts to some warnings
2019-02-28 17:53:55 -08:00
Matt Martz
35f5ca8295 Don't allow an empty version_added 2019-02-28 15:43:46 -08:00
Sloane Hertel
8a02f894a6 replace uses of sort_json_policy_dict with compare_policies (#52943)
* replace uses of sort_json_policy_dict with compare_policies which is compatible with Python 3 and remove sort_json_policy_dict from the AWS guidelines since it only works on Python 2

* Sort any lists containing only strings

* Sort the original policy too
2019-02-28 17:09:00 -05:00
Sam Doran
2a98faee2b
Move _handle_aliases() out of basic.py (#48578)
Refinements:
- return legal_inputs and update class properties
- remove redundant arguments from method and handle in caller
- add better exception types to method

* Add unit tests for handle_aliases
2019-02-28 16:43:19 -05:00
Sam Doran
1c87ea6fa6 Reboot - add parameter for paths to search for shutdown command (#51194)
* Look in /lib/molly-guard for shutdown command

Signed-off-by: Sam Doran <sdoran@redhat.com>

* Add parameter for extra_search_paths

Signed-off-by: Sam Doran <sdoran@redhat.com>

* Change option to search_paths

- Update docs
- Make the parameter replace the default values
- Add some sanity checking on the data type

Signed-off-by: Sam Doran <sdoran@redhat.com>

* Correct parameter in tests, change conditional for molly-guard tasks

Signed-off-by: Sam Doran <sdoran@redhat.com>

* Address feedback

* Simplify field validation

Needed the try except in case a non-iterable type is put in the search_paths field
2019-02-28 13:36:33 -08:00
Dag Wieers
4e6c113bf0 uri/win_uri: Make method a free text field (#49719)
* uri/win_uri: Make method a free text field

Since various interfaces introduce their own HTTP method (e.g. like
PROPFIND, LIST or TRACE) it's better to leave this up to the user.

* Fix HTTP method check in module_utils urls

* Add integration test for method UNKNOWN

* Clarify the change as requested during review
2019-02-28 15:55:18 -05:00
Ted Timmons
81ec48c7b4 botmeta: ignore tedder, fix some grammar (#53133)
* ignore tedder, fix some grammar

I'm less helpful than in the past on reviewing these, adding myself to the 'ignore' keys.

Also fixed some grammar in the instruction block.

* oh, so that's how the default key works. yaml fail
2019-02-28 13:31:05 -06:00
Jiri Tyr
7739b5e96c Last two fields in fstab are optional (fixes #43855) (#43941)
* Last two fields in fstab are optional
* Add changelog
2019-02-28 14:09:30 -05:00
Piotr Wojciechowski
ec4cf26d60 Documentation update for labels operations on swarm/node (#53083)
* Update lib/ansible/modules/cloud/docker/docker_node.py
* Update lib/ansible/modules/cloud/docker/docker_swarm.py

Co-Authored-By: WojciechowskiPiotr <23406016+WojciechowskiPiotr@users.noreply.github.com>
2019-02-28 14:08:35 -05:00
Sloane Hertel
9b4110a50c
Enable ec2_vpc_vgw tests (#53118) 2019-02-28 12:57:55 -06:00
Will Thames
91eee48f1b aws_kms tags fix (#53088)
* Fix TagName and TagValue in aws_kms

Fixes #53061

* Improve test suite to check for tags

Also fixed some obvious failures, need to run the test suite from time
to time!
2019-02-28 12:54:18 -06:00
Nilashish Chakraborty
5d8f307116 Revert back to using section (#53069)
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
2019-02-28 13:43:34 -05:00
Brian Coca
55dc63be3a
properly convert inputs to handle bytes/unicode (#53072)
* properly convert inputs to handle bytes/unicode

  fixes #52186

* Update changelogs/fragments/nmap_bytes_fix.yml

Co-Authored-By: bcoca <bcoca@users.noreply.github.com>
2019-02-28 11:51:15 -05:00
rwagnergit
d2bdbadb03 adding quiet option to assert (ansible#27124) (#52032)
* adding quiet option to assert (ansible#27124)

* adding doc for quiet to assert.py

* fixing PEP8 failure

* improving example

* improving docs

* adding changelog fragment

* adding . at end of descriptions

* removing trailing blank line

* adding integration test for assert

* fixing CI complaints

* disabling gather_facts in quiet.yml test

* rerunning to capture skip

* cleaning up python 2 vs 3

* following rebase

* fixing CI complaints

* fixing CI complaints

* fixing CI complaints

* fixing CI complaints

* fixing CI complaints
2019-02-28 10:25:41 -05:00
Chuck Douglas
0e9a79a589 Change the retry_files_enabled to False and modify the comments to reflect that this has been disabled (#52581)
* Change the retry_files_enabled to False and modify the comments to reflect that
this has been disabled.

* Change the default action of retry_files_enabled to False

* Update porting guide to reflect change in default state of retry_files_enabled variable

* Change log documenting a change in default behaviour of retry_files_enabled

* Revert config change to comment out the retry_files_enabled line to let the user decided what is best.
Comment above still states how to change.
2019-02-28 10:13:26 -05:00
Abhijeet Kasurde
0f353ed99d AWS: handle boto3 credential file parsing error (#53098)
Fixes: #53051

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-02-28 08:41:59 -06:00
Trishna Guha
5f577c7e79
Add type in eos_config module docs (#53117)
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2019-02-28 19:25:13 +05:30
Andrey Klychkov
cf05429b3c postgresql_privs change fail to warn if role(s) does not exist (#52574)
* postgresql_privs change fail to warn if role does not exists

* postgresql_privs change fail to warn if role does not exists: fix sanity

* postgresql_privs change fail to warn if role does not exists: add changelog fragment

* postgresql_privs change fail to warn if role does not exists: fixes

* postgresql_privs change fail to warn if role does not exists: added fail_on_role param
2019-02-28 14:39:08 +01:00
Sam Doran
23a6b88dd2
Modify the correct variable when setting available hashing algorithms (#52994)
* Revert "use list instead of tuple and remove md5 on ValueError (#51357)" c459f040da.
* Modify the correct variable when determining available hashing algorithms
2019-02-28 07:32:00 -05:00
David Passante
644362d0be cloudstack: streamline modules doc (part 2) (#52730)
* cloudstack: streamline modules doc (part 2)

* Parameter types added
* Copyright format fixes
* Doc style fixes
* Examples format fixes

* minor fixes

* fix missing quoting of "version_added"
2019-02-28 07:27:14 -05:00
Bojan Vitnik
88e8330e3e New module: xenserver_guest_powerstate - manages powerstate of XenServer VMs (#49425)
* Initial commit for xenserver_guest_powerstate module
* Added unit tests for the module, removed unused imports
2019-02-28 17:55:05 +05:30
Matt Davis
4d3a6123d5
Python interpreter discovery (#50163)
* Python interpreter discovery

* No longer blindly default to only `/usr/bin/python`
* `ansible_python_interpreter` defaults to `auto_legacy`, which will discover the platform Python interpreter on some platforms (but still favor `/usr/bin/python` if present for backward compatibility). Use `auto` to always use the discovered interpreter, append `_silent` to either value to suppress warnings.
* includes new doc utility method `get_versioned_doclink` to generate a major.minor versioned doclink against docs.ansible.com (or some other config-overridden URL)

* docs revisions for python interpreter discovery

(cherry picked from commit 5b53c0012ab7212304c28fdd24cb33fd8ff755c2)

* verify output on some distros, cleanup
2019-02-27 23:52:02 -08:00
Zim Kalinowski
b8a82f5930 some fixes in vm facts doc (#53089) 2019-02-28 13:47:33 +08:00
Chris Van Heuveln
d69239c440 network.py:ActionModule:run: does not honor _handle_src_option failures (#52745)
* network.py:ActionModule:run: does not honor _handle_src_option failures

PR #50301 moved template error handling out of run() and into its
own method in `_handle_src_option`; however, after the change run()
ignores the return value so any errors are ignored.

Reproduceable with `nxos_config/tests/common/src_invalid.yaml`

Verified fix with `nxos_config/tests/common/src_*` tests.

Ref:
71113ee291 (diff-7477bf046013758366cc85b06f90709aR43)

* nxos_config/tests/common/src_basic: Updated to test with src

This test was not actually testing with `src:` as it should have.

* Revert 412d7e change to plugins/action/network.py

PR #52912 fixed this already.

* nxos_config: fix src_invalid test
2019-02-28 11:07:03 +05:30
Matt Clay
e4d0be39c3 Remove skip/rhel8.0 from osx_defaults test.
The test already has `skip/rhel` which is enough.
2019-02-27 17:48:16 -08:00
Dag Wieers
aaec8e6b47 Fix types 2019-02-27 19:15:13 -05:00
sgerhart@gmail.com
7cb808ff37 create aci_fabric_scheduler module 2019-02-27 19:15:13 -05:00
Dag Wieers
ccc94c0660 Fix types 2019-02-27 19:15:03 -05:00
sgerhart@gmail.com
d99cba6dc5 create aci_firmware_group module 2019-02-27 19:15:03 -05:00
Kevin Breit
9e6e53d1f6 Migrate existing Digital Ocean integration tests to new framework (#51785)
- SSH key and floating IP tests were legacy
- PR moves, but does not enhance tests
- Uses consistent API key variable
2019-02-27 19:14:43 -05:00
Wojciech Sciesinski
c99f3f558a Don't run integration tests for OS'es older than Windows 2016 (#53057) 2019-02-28 09:59:29 +10:00
Dag Wieers
80bdd21317 Fix types 2019-02-27 18:58:46 -05:00
sgerhart@gmail.com
a289fcb803 create aci_firmware_policy module 2019-02-27 18:58:46 -05:00
Dag Wieers
d5ef4d1e33 Fix types 2019-02-27 18:58:37 -05:00
sgerhart@gmail.com
07ff8f0bd5 create aci_firmware_group_node module 2019-02-27 18:58:37 -05:00
Dag Wieers
9abee0385d Fix type 2019-02-27 18:58:29 -05:00
sgerhart@gmail.com
323a0aa7eb create aci_maintenance_group module 2019-02-27 18:58:29 -05:00
Brian Coca
cfba6dfe91
Ensure play order is obeyed (#49897)
* Ensure play order is obeyed

 it was being ignored depending on other options
 also added tests for each order (except shuffle) both serial and not
 fixes #49846
2019-02-27 18:20:16 -05:00
Zim Kalinowski
6583ed0df9 Adding postgresql configuration module (#45072)
* adding postgresqlconfiguration

* removed unnecessary option

* small fixes

* moved tests to main server test

* update comments

* updated module
2019-02-27 14:43:50 -08:00
Zim Kalinowski
6d3789125b adding mysql configuration module (#45076)
* adding mysql configuration module

* fixes in configuration

* move tests

* fixes

* updating test

* updated module

* fixed merge issues

* one more test fix

* adding for debugging purposes

* removed file checked in by mistake

* one more merge problem

* fixed test

* try to get more info

* fix error
2019-02-27 14:42:42 -08:00
Sloane Hertel
c4d0c58c5a
Only run ec2_vpc_vgw on changes to the module to avoid hitting the limit (#53082)
* Only run ec2_vpc_vgw on changes to the module to avoid hitting the resource limit

* actually mark as disabled
2019-02-27 15:58:11 -06:00
Marcos Paulo de Souza
fa83a711b6 hostname.py: Fix openSUSE distribution name (#47020)
All openSUSE distributions changed to the way they are returned from distro.id().

This patches fix the openSUSE Leap and SLES distro names, and adds one entry for Tumbleweed.

These descriptions are capitilized, as expected by Ansible's hostname module.

Signed-off-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
2019-02-27 16:18:32 -05:00
Felix Fontein
04bfec9dfe docker_swarm: more integration tests (#53035)
* Add more tests.

* Added tests for CA options.

* Don't run in docker-in-docker situations where docker daemon becoming instable is really dangerous. Also, restart docker daemon after tests.

* Only run CA tests when openssl_certificate can be run (which is not the case for RHEL7, see #34054).

* Add comment on why docker-based CI runs are skipped.
2019-02-27 14:54:32 -05:00
Anil Kumar Muraleedharan
a78c40322c Lenovo cnos logging (#52978)
* Adding the module cnos_logging.py to the module suite from Lenovo
2019-02-27 14:15:56 -05:00