Commit graph

6140 commits

Author SHA1 Message Date
Jordan Borean
03100cb647 Add Windows Server 2019 to Shippable matrix (#51685)
* Test out Server 2019 - ci_complete

* run tests and continue on error - ci_complete

* Add the full matrix back in

(cherry picked from commit 0334c20630)
2019-02-12 10:29:28 -08:00
Felix Fontein
0093b69935 openssl_csr: ignore empty strings in altnames (#51473)
* Ignore empty strings in altnames.

* Add changelog.

* Add idempotence check without SAN.

* Fix bug in cryptography backend.

(cherry picked from commit 9b1cbcf3a4)
2019-02-11 12:10:22 -08:00
Martin Krizek
1492f46d78 yum: disableexcludes is supported on centos6 (#51698)
(cherry picked from commit 33b07f322c)
2019-02-11 11:18:29 -08:00
Matt Davis
0708c80c40 fix string_format sanity check (#51780)
* newer version of Pylint moved the impl; use conditional import to find for new/old

(cherry picked from commit 6654c7aeea)
2019-02-11 11:15:22 -08:00
Wojciech Sciesinski
90203d0a11 Correct integration tests for the win_disk_facts module (#51044)
* Correct integration tests for the win_disk_facts module

* Exclude W2K8, W2K8-R2 from tests run under CI
2019-02-11 11:14:54 -08:00
Elijah DeLee
fe79534415 Backport aws ec2 missing region discovery (#51626)
* aws_ec2 Implement the missing 'region discovery' (#51333)

* aws_ec2 Implement the missing 'region discovery'

  fixes #45288

  tries to use api as documented (which seems to fail in latest boto3 versions)
  and fallback to boto3 'hardcoded' list of regions

* fixes and cleanup, add error for worst case scenario

* fix tests, remove more unused code

* add load_name

* acually load the plugin

* set plugin as required

* reverted test changes, removed options tests

* fixes as per feedback and cleanup

* Allow default regions list to use flexible credential types
2019-02-11 11:13:48 -08:00
Jordan Borean
ad71a9a7ed Get docker tests working on OpenSUSE (#51896)
(cherry picked from commit c92fcf0b57)
2019-02-07 13:54:22 -08:00
Matt Davis
ac3a3ce599 [stable-2.7] fix azure_rm_deployment test
* recent changes to args for hosted template file broke the test; changed test to use a specific known-working commit instead of `master`.
* long-term may want to consider hosting the template in httptester or just embedding a local copy
(cherry picked from commit 46bf387)

Co-authored-by: Matt Davis <mrd@redhat.com>
2019-02-07 13:15:22 -08:00
Brian Coca
7589d496fc remove default from delegate_facts to inherit (#45492) (#51553)
* remove default from delegate_facts to inherit (#45492)

* remove default from delegate_facts to inherit

fixes #45456

* test delegate_facts

* added note about inheritance and defaults

* yamllint

(cherry picked from commit 8743e6ae2e)

* added changelog
2019-02-04 14:16:32 -08:00
Jordan Borean
bdf7f42b7c test win_setup - make py3 compatible (#51693)
(cherry picked from commit f78cdcd2c5)
2019-02-04 12:57:27 -08:00
Jordan Borean
aedad64c8f win_service - use custom binary for tests (#51689)
(cherry picked from commit 2e99dea867)
2019-02-04 12:57:06 -08:00
Jordan Borean
06505fc521 add pause to make test more stable (#51680)
(cherry picked from commit ebc9e4caf7)
2019-02-04 12:54:08 -08:00
Jordan Borean
9168e6844a win_power_plan: fix for Windows 10 and Server 2008 compatibility (#51471)
(cherry picked from commit f27078df52)
2019-02-04 12:35:53 -08:00
Brian Coca
3bf030ddcc Handle complex quoting in extra args in pull cli (#50212)
* added proper testing

fixes #40729

(cherry picked from commit b6824669df)
(cherry picked from commit e010034151)
2019-02-04 12:27:00 -08:00
Felix Fontein
af977daec7 Adjusting to differences between Ansible 2.7 and Ansible 2.8.
(cherry picked from commit 6cdb357826ffb1446e4ceb1050349fe30f511b41)
2019-01-31 08:42:29 -08:00
Akshay Gaikwad
03bc4be1c3 Add integration tests for docker_image options (#48574)
* Add integration tests for docker_image options

Tests for options in docker_image module

Signed-off-by: Akshay Gaikwad <akgaikwad001@gmail.com>

* Add force option tests

Signed-off-by: Akshay Gaikwad <akgaikwad001@gmail.com>

* Add repository option tests

Signed-off-by: Akshay Gaikwad <akgaikwad001@gmail.com>

* Modify test for option force

Signed-off-by: Akshay Gaikwad <akgaikwad001@gmail.com>
(cherry picked from commit 0493ef359a)
2019-01-31 08:42:29 -08:00
Jordan Borean
1d3f29d4be ansible-test: make the httptester for Windows more resiliant around the shell chosen (#51416)
(cherry picked from commit ce8db479f0)
2019-01-29 17:53:32 -08:00
Dag Wieers
67606bfa66 aci_aaa_user: Fix an issue with clear_password_history 2019-01-29 17:31:32 -08:00
Dag Wieers
0d5f083a52 aci_aaa_user: Fix changing user description
This fixes a reported problem with the aci_aaa_user module.
2019-01-29 11:06:18 -08:00
Dag Wieers
a22f46bacf Docs: Add a "seealso" section to the module docs (#45949)
* Docs: Add a separate  "seealso" section to the module docs
to list related modules and/or related references. This clears up the notes
section for things that are actual notes.

So you can add a section in your module documentation and four types of
references are possible.

    seealso:

    # Reference by module name
    - module: aci_tenant

    # Reference by module name, including description
    - module: aci_tenant
      description: ACI module to create tenants on a Cisco ACI fabric.

    # Reference by rST documentation anchor
    - ref: aci_guide
      description: Detailed information on how to manage your ACI infrastructure using Ansible.

    # Reference by Internet resource
    - name: APIC Management Information Model reference
      description: Complete reference of the APIC object model.
      link: https://developer.cisco.com/docs/apic-mim-ref/

This PR also includes:

- Implements ansible-doc support
- Implements schema support for the seealso options
- Updates to the development documentation
- Rename filter convert_symbols_to_format to rst_ify, cfr the existing html_ify and tty_ify filters
  - This makes the existing template a lot easier to read and fixes the confusion I had myself rereading the template (again).
- We fixed the possible suboption types (which was limited to 'bool' only)

* Use latest stable instead of devel docs

(cherry picked from commit baf0ad2309)
2019-01-28 10:13:05 -08:00
Jordan Borean
7d52c07df2 ansible-test: add Ubuntu 18.04 container (#50790)
* ansible-test: Add Ubuntu 18.04 to Shippable CI nodes

* re-add ubuntu1604/3 to matrix

* forgot to add environment for git kill gpg-agent

(cherry picked from commit 828df4b336)
2019-01-24 12:00:16 -08:00
Sam Doran
44d7c1e23e [stable-2.7] Catch sshpass authentication errors and don't retry multiple times to prevent account lockout (#50776)
* Catch SSH authentication errors and don't retry multiple times to prevent account lock out

Signed-off-by: Sam Doran <sdoran@redhat.com>

* Subclass AnsibleAuthenticationFailure from AnsibleConnectionFailure

Use comparison rather than range() because it's much more efficient.

Signed-off-by: Sam Doran <sdoran@redhat.com>

* Add tests

Signed-off-by: Sam Doran <sdoran@redhat.com>

* Make paramiko_ssh connection plugin behave the same way

Signed-off-by: Sam Doran <sdoran@redhat.com>

* Add changelog

Signed-off-by: Sam Doran <sdoran@redhat.com>.
(cherry picked from commit 9d4c0dc111)

Co-authored-by: Sam Doran <sdoran@redhat.com>
Signed-off-by: Sam Doran <sdoran@redhat.com>
2019-01-24 10:38:08 -08:00
Jordan Borean
44474bf424 file - allow touch on files not owned by user (#50964)
* file - allow touch on files not owned by user

* use Sentinal value and preserved existing args

* Do no instantiate the Sentinel object

(cherry picked from commit 419727a6da)
2019-01-24 10:22:11 -08:00
Matt Clay
22448ce99e [stable-2.7] Disable failing azure_rm_postgresqlserver test..
(cherry picked from commit 37767849ee)

Co-authored-by: Matt Clay <matt@mystile.com>
2019-01-22 22:34:56 -08:00
Matt Clay
278aa94f1f [stable-2.7] Fix subversion integration test on Fedora 29. (#51089)
* Fix subversion integration test on Fedora 29.

This upgrades the sqlite-libs and subversion packages to make sure
that the version of sqlite expected by subversion is installed.

* Fix compatibility with RHEL and CentOS.
(cherry picked from commit d4dbc7f2e0)

Co-authored-by: Matt Clay <matt@mystile.com>
2019-01-18 16:24:32 -08:00
Brian Coca
4a89749dd5 Prevent duplicate role insertion into roles: (#50552)
* Corner case in which import_role would add another instance of a role with the same signature into roles: when it already existed there.

  roles:
	- name: a
  tasks:
       - import_role: name=a

  would execute role 'a' 3 times instead of the intended 2 (x2 in roles: phase +1 in tasks:)

* added tests

(cherry picked from commit eca7c3c8c7)
2019-01-18 12:58:43 -08:00
Jordan Borean
8fcdb0a73c ansible-test git: kill gpg-agent to remove locks (#50917)
* ansible-test git: kill gpg-agent to remove locks

* skip gpg-agent kill for OpenSUSE

(cherry picked from commit 3db6b9b416)
2019-01-18 12:42:48 -08:00
Jordan Borean
80b5b33e2b setup_rabbitmq - fix erlang pinned dependencies (#51048)
(cherry picked from commit 18c35b69fb)
2019-01-17 16:57:47 -08:00
Jordan Borean
49f0ab85d6 ansible-test: fix cloud_init_data_facts for Ubuntu 18.04 (#50916)
(cherry picked from commit 03669cdcdd)
2019-01-14 22:28:20 -08:00
Jordan Borean
e70aa001bf ansible-test: fix dpkg_selections on Ubuntu 18.04 (#50915)
(cherry picked from commit a54eb58156)
2019-01-14 22:28:20 -08:00
Jordan Borean
bca3066a27 ansible-test: add postgresql var file for Ubuntu 18.04 (#50914)
(cherry picked from commit 8c5b2048de)
2019-01-14 22:28:20 -08:00
Jordan Borean
19597c559a ansible-test: rename setup_mysql_db Ubuntu name to work with 18.04 (#50907)
(cherry picked from commit 518699988f)
2019-01-14 22:28:20 -08:00
Jordan Borean
4ca81631b6 ansible-test: apt cleanup and futher 18.04 fixes (#50906)
(cherry picked from commit bbad033a5e)
2019-01-14 22:28:20 -08:00
Jordan Borean
18a3916a76 ansible-test setup_dep_repo trust package repo (#50795)
(cherry picked from commit 2fcc3593cc)
2019-01-14 22:28:20 -08:00
Jordan Borean
7130ffddf6 test subversion - support Ubuntu 18.04 (#50791)
(cherry picked from commit 91522bd9c4)
2019-01-14 22:28:20 -08:00
Felix Fontein
8cc23c0802 [2.7] [docker_container] Failing on non-string env values (#50899)
* [docker_container] Failing on non-string env values (#49843)

* [docker_container] Failing on non-string env values

Fixes #49802

* Clarify failure message

Co-Authored-By: DBendit <David@ibendit.com>

* Fixup from review

(cherry picked from commit d62d7176b0)

* Turn fail into warning for 2.7 backport.

* Fix test for backport

The behaviour in the backport is to warn rather than error
2019-01-14 20:02:24 -08:00
cahlchang
12ee5c9f6e [Backport #46774] fix ec2_instance check mode 2019-01-14 12:36:54 -08:00
Felix Fontein
c532169697 docker_volume: revert #47390 (#50663)
* Revert "Fix option change detection / force support for docker_volume. (#47390)"

This reverts commit 8ef994fbc5.

* Update changelog.

* Adjusting tests.

(cherry picked from commit 0e7a9a2771)
2019-01-14 12:36:00 -08:00
Brian Coca
d20040296b added missing docs for option in acl module (#50775)
* added missing docs for option in acl module
* remove acl from ignore

(cherry picked from commit 91d8383898)
2019-01-14 12:34:39 -08:00
Matt Clay
ffd1590a63 [stable-2.7] Cleanup integration test inventory. (#50753)
* Move var_blending test inventory into test.
* Remove Amazon specific inventory entry for tests.
* Remove Azure specific inventory entry for tests.
* Move var_precedence test inventory into test.
* Move unicode test inventory into test.
* Remove unused inventory entry.
* Move gathering_facts test inventory into test.
* Move delegate_to test inventory into test.
* Clean up inventory for binary_modules test.
* Clean up integration test inventory..
(cherry picked from commit e5094e8071)

Co-authored-by: Matt Clay <matt@mystile.com>
2019-01-11 19:46:38 -08:00
Sloane Hertel
63bb122e37 [stable-2.7] Add unstable alias to s3_bucket integration tests (#50508)
(cherry picked from commit d21ed42f4b)

Co-authored-by: Sloane Hertel <shertel@redhat.com>
2019-01-11 16:59:02 -08:00
Matt Clay
c4e0d4d7a5 [stable-2.7] Move unrelated connection test to separate target.
(cherry picked from commit d59bc9ae48)

Co-authored-by: Matt Clay <matt@mystile.com>
2019-01-11 15:49:49 -08:00
Matt Clay
396edb96c1 [stable-2.7] Fix dpkg_selections integration test.
Download package from S3 since the previous location no longer exists.
(cherry picked from commit fd56788a14)

Co-authored-by: Matt Clay <matt@mystile.com>
2019-01-11 10:27:30 -08:00
Felix Fontein
20eaebd9b2 [2.7] openssl_pkcs12: fix ca_certificates path expansion (#50697)
* Expand user and variables in ca_certificates paths.

This is a fix specific for stable-2.7. In devel (and stable-2.8),
this problem is fixed by #48473. That PR adds argument spec
validation for list elements.

* Add changelog.
2019-01-10 08:37:17 -08:00
Matt Clay
bb94698556 [stable-2.7] Disable retry files for integration tests.
(cherry picked from commit 39824f50b1)

Co-authored-by: Matt Clay <matt@mystile.com>
2019-01-09 23:43:53 -08:00
Matt Clay
97d07a1504 [stable-2.7] Improve performance of no-tests-as-filters test.
(cherry picked from commit 7995f69a44)

Co-authored-by: Matt Clay <matt@mystile.com>
2019-01-09 23:27:03 -08:00
Matt Clay
100e4639aa [stable-2.7] Minor cleanup of code-smell tests. (#45658)
* Minor cleanup of code-smell tests.
* Add exception handling for YAML load..
(cherry picked from commit e7426e3795)

Co-authored-by: Matt Clay <matt@mystile.com>
2019-01-09 21:48:12 -08:00
Matt Clay
5fa8d54488 Use relative inventory paths instead of symlinks.
(cherry picked from commit 4915920d71)
2019-01-09 21:00:26 -08:00
Matt Clay
7a4f2aa47b Move any_errors_fatal test inventory into test.
(cherry picked from commit c04b69208d)
2019-01-09 21:00:26 -08:00
Matt Clay
9eb4161230 Move include_import test inventory into test.
(cherry picked from commit 828e8d4957)
2019-01-09 21:00:26 -08:00