Cristian Ciupitu
7f681c33a2
Micro-optimization: replace s.find(x)!=-1 with x in s
...
timeit shows a speedup of ~3x on Python 2.7.5 x86_64.
It also makes the code a bit shorter.
2014-03-16 13:10:28 -04:00
Ali Asad Lotia
77e6dded62
Fix acl module doc and error messages
...
- Fix typos in module doc
- Provide clearer error message when entry and etype are both missing
2014-03-16 16:41:37 +00:00
Brian Coca
7ca6343ca3
Fixes and cleanup to file functions and module
...
- unified set attribute functions ... not sure why 2 identical functions
exist with diff names, now there are 3 while i repoint all modules to 1
- fixed issue with symlinks being created w/o existing src when force=no
- refactored conditionals, simplified where possible
- added tests for symlink to nonexistant source, with both force options
- made symlink on existing attomic (force)
2014-03-15 13:54:24 -04:00
Michael DeHaan
4f1ccfd66f
Merge pull request #6504 from follower/patch-2
...
Fix typo
2014-03-15 09:15:53 -05:00
follower
5beee66d1d
Fix typo
...
"resort" -> "result"
2014-03-15 20:04:38 +13:00
Brian Coca
5dd041ae7e
fixed bad detection of change on default and premature break
2014-03-15 01:10:15 -04:00
Jakub Jirutka
f39b8cae95
Fix #5679 again after recent changes in core
2014-03-12 18:21:53 +01:00
Brian Coca
3b98ed15bc
now stat skips md5 if file isn't readable
2014-03-11 22:50:05 -04:00
James Tanner
fc33860e5d
Force command action to not be executed by the shell unless specifically enabled
2014-03-10 16:13:30 -05:00
Dolph Mathews
289f8f7ed9
spelling correction for "separate"
...
s/seperate/separate/
http://en.wiktionary.org/wiki/separate
2014-03-08 04:51:34 -06:00
Richard C Isaacson
7fff5abd5b
unarchive module: Add creates functionality.
...
Closes GH-5354.
Forklift copy logic into unarchive. Provides integration unit tests.
2014-03-07 18:19:46 -06:00
Michael DeHaan
87677c96c6
Merge pull request #6308 from muffl0n/file_fix_documentation
...
Module "file": Fix link to "path" in documentation
2014-03-06 11:04:47 -06:00
James Cammarata
bdd3ccec65
Un-escape newlines in delimiters for assemble module
2014-03-06 09:44:56 -06:00
Sven Schliesing
b55f99b803
Fix link in documentation
...
c(dest) -> c(path)
2014-03-06 13:16:29 +01:00
Michael DeHaan
2f12c6ddf6
Simplify file module parameter description.
2014-02-28 13:55:07 -05:00
Richard C Isaacson
7263148156
Typo fix.
2014-02-28 11:02:58 -06:00
Richard C Isaacson
1e2eb88926
Replace mode with octal renaming to mode.
...
Closes GH-6176
This way for mode we return in an octal format which is immediately usable compared to transforming it later.
2014-02-28 10:42:20 -06:00
Richard Isaacson
6ffeaa7ddd
Merge pull request #1 from bcoca/stat_updaates
...
added octal representation of mode and made md5 checksumming optional
2014-02-28 10:39:41 -06:00
Richard C Isaacson
a707e858cd
Minor cleanup.
2014-02-28 10:04:05 -06:00
Richard C Isaacson
3ca9fc64d5
copy module: cleanup and if directory_mode not set default to umask
2014-02-28 10:00:54 -06:00
Richard C Isaacson
326ed4eeeb
Copy Module: Add the ability to set directory attributes on recursive copy.
...
Closes GH-6194.
These changes pass attribute modifications through to new directories during a recursive copy with an addition allowing for the directory mode to be set independantly.
2014-02-28 01:14:32 -06:00
James Cammarata
b667e1d404
Add expanduser calls on src/dest in the module too
2014-02-26 15:19:45 -06:00
James Cammarata
1762557ff4
Merge branch 'devel' of https://github.com/muffl0n/ansible into muffl0n-devel
2014-02-26 12:28:26 -06:00
Brian Coca
21854d54d4
added octal representation of mode and made md5 checksumming optional
...
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
2014-02-25 21:33:14 -05:00
James Cammarata
6283754340
Fixing several bugs in assemble and updating tests
...
Bugfixes:
* the remote_src param was not being converted to a boolean correctly,
resulting in it never being used by the module as the default behavior
was remote_src=True (issue #5581 )
* the remote_src param was not listed in the generic file params, leading
to a failure when the above bug regarding remote_src was fixed
* the delimiter should always end with a newline to ensure that the file
fragments do not run together on one line
Fixes #5581
2014-02-24 14:27:23 -06:00
James Cammarata
33d9a662ee
Adding new tests for assemble role
2014-02-24 14:27:23 -06:00
James Cammarata
d80b9ac137
Adding the backup destination to the resut dictionary for lineinfile
2014-02-20 13:31:54 -05:00
muffl0n
68bef304c8
already call expanduser in action_plugin
2014-02-19 21:41:57 +01:00
Michael DeHaan
62f8ebe51e
Merge pull request #6036 from mxxcon/patch-1
...
docs_pull_request: Add parameters highlighting
2014-02-18 13:58:44 -05:00
James Cammarata
f1ba67e547
Merge branch 'fix-5679' of https://github.com/jirutka/ansible into jirutka-fix-5679
2014-02-17 14:54:29 -06:00
mxxcon
544c08a211
docs_pull_request: Add parameters highlighting
...
Added highlighting to parameter references in docs so that they standout a bit better.
2014-02-15 23:26:21 -05:00
Michael DeHaan
77ac23cc26
Document ansible_managed changing the template.
2014-02-15 14:13:42 -05:00
Michael DeHaan
b1e442639f
Some minor docs corrections.
2014-02-15 14:05:42 -05:00
Richard C Isaacson
54c799d3fb
Cleanup per notes.
...
Some small changes to per notes from @mpdehann.
2014-02-12 10:01:10 -06:00
Richard C Isaacson
9795eec24b
Updates for the unarchive module and action_plugin.
...
There is a bit going on with the changes here. Most of the changes are cleanup of files so that they line up with the standard files.
PR #5136 was merged into the current devel and brought up to working order. A few bug fixes had to be done to get the code to test correctly. Thanks out to @pib!
Issue #5431 was not able to be confirmed as it behaved as expected with a sudo user.
Tests were added via a playbook with archive files to verify functionality.
All tests fire clean including custom playbooks across multiple linux and solaris systems.
2014-02-12 01:57:00 -06:00
Richard C Isaacson
a3be027909
Merge remote-tracking branch 'pib/unarchive_remote' into pull_5136
2014-02-11 22:55:34 -06:00
Mike Grozak
3f74dd6592
Updated the force parameter description; added one example how to create the symlinks pointing to non-absolute paths
2014-02-07 14:29:20 +01:00
Mike Grozak
ecd8b5d064
Found a way how to have symlinks towards files without absolute paths in prefixes; fixed incorrect force setting on the hard links, which can not point to non-existing files
2014-02-07 14:13:41 +01:00
Mike Grozak
4f262779cd
Started the development of the 'chdir' functionality for file module - creation symlinks without the base directory prefix
2014-02-06 17:20:32 +01:00
jctanner
5a6fc3d940
Merge pull request #5363 from bcoca/acl_improved
...
acl module: acl now supports 'default'
2014-02-05 18:40:59 -05:00
Brian Coca
3aa3a42c45
fixed docstring and changed type to etype avoiding python builtin
...
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
2014-02-05 18:36:29 -05:00
jctanner
552ce8b68c
Merge pull request #5051 from deontologician/patch-1
...
Added -FF flag to rsync invocation in synchronize
2014-02-05 12:02:48 -05:00
jctanner
e13a10def7
Merge pull request #5127 from ovcharenko/patches
...
synchronize module: Added existing_only options to skip creating new files on receiver
2014-02-05 11:49:05 -05:00
jctanner
27362ebbf1
Merge pull request #5187 from 42wim/devel
...
Add support for --copy-links in synchronize
2014-02-05 11:26:08 -05:00
Michael DeHaan
f16f2f23f5
Update copy
...
Update copy documentation to reference synchronize module
2014-01-30 17:43:40 -05:00
Wim
7b8918d37c
Add support for --copy-links
2014-01-29 23:05:51 +01:00
Jan-Piet Mens
95c826a533
documentation typos
2014-01-21 09:03:14 +01:00
Jakub Jirutka
ec80066cee
Fixes #5679 : lineinfile ignores newline in line argument
2014-01-19 02:24:26 +01:00
Laurent Defert
9fb39ce4aa
Mark stat module as supporting check_mode
2014-01-18 22:32:58 +01:00
jctanner
95131937df
Merge pull request #5282 from rhaido/hard_link_fix
...
file module: Added to the file module the functionality to force conversion hard link...
2014-01-14 07:15:46 -08:00
jctanner
87b58666f9
Merge pull request #5264 from drewlll2ll/file-fix
...
file module: Fixed missing prev_state == 'directory' in file
2014-01-06 14:07:07 -08:00
Aleksey Ovcharenko
d8b160d385
Downgraded module version_added.
2014-01-03 17:22:10 +02:00
Michael DeHaan
a11e5d609e
Basic docsite formatting fixups
2014-01-02 17:36:52 -05:00
Michael DeHaan
0a3293cf53
add a note about raw/endraw
2013-12-27 15:01:27 -05:00
Michael DeHaan
0ad0f795f3
Merge pull request #5427 from bcoca/template_docs2
...
added more usefull example for jinja2 overrides
2013-12-26 10:30:44 -08:00
Brian Coca
9affb6ed37
added more usefull example for jinja2 overrides (this one is actually
...
used)
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
2013-12-26 12:01:41 -05:00
Maykel Moya
8f766bdcdd
Missing "is" in file module description
2013-12-26 12:34:46 +01:00
Brian Coca
bdd6eaa62a
now handles default and allaows for either shorthand entry or specific
...
fields per entry section
the default option works both when added to entry or as stand alone.
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
2013-12-19 20:36:49 -05:00
Peter Salvatore
4c168abccc
fix typo in synchronize module
2013-12-18 13:06:35 -08:00
Aleksey Ovcharenko
1b2d359a69
Added version_added
2013-12-16 19:20:02 +02:00
Jens Rantil
38d0df65d8
module(file): Fail instead of exit on exception
2013-12-13 21:34:19 +01:00
Jens Rantil
4262e76aec
module(file): state what went wrong on exception
2013-12-13 21:33:19 +01:00
Mike Grozak
5a66a95bf3
Added to the file module the functionality to force conversion hard link and symlink when the force attribute is set to 'yes'
2013-12-13 17:10:50 +01:00
drewlll2ll
8fe3b05262
Added prev_state for directory
2013-12-12 09:44:29 -05:00
Jens Rantil
b8347a3144
file
module: Don't catch SystemExit
...
This fixes issue #5159 .
2013-12-04 13:13:49 +01:00
James Tanner
f210e0c862
Fixes #5109 synchronize module ssh port
...
Added a parameter for dest_port and also check ansible_ssh_port inventory variable.
2013-12-03 14:48:20 -05:00
Paul Bonser
4df9dd9232
Optionally unarchive a file already on the remote machine
2013-12-02 19:51:10 -06:00
James Tanner
4f9aadcc07
Addresses #5023 Fix import comments
2013-12-02 15:13:49 -05:00
James Tanner
38edad70ac
Fixes #5023 Convert all modules to use new snippet import pattern
2013-12-02 15:11:23 -05:00
Aleksey Ovcharenko
8413552642
Fixed a typo.
2013-12-02 16:35:44 +02:00
Michael DeHaan
4c35b7f380
There's a cleaner way to do this, commit to module formatter pending.
...
Revert "No longer need to reference 'version_added' in docs for these, as this was quite a while ago."
This reverts commit ff0a41d446
.
2013-11-27 21:23:03 -05:00
Michael DeHaan
9e4d71203d
No longer need to reference 'version_added' in docs for these, as this was quite a while ago.
2013-11-27 21:19:32 -05:00
Josh Kuhn
c2a59a97c4
Added note about .rsync-filter files, with example
2013-11-25 15:12:58 -05:00
Josh Kuhn
eccaf457af
Added -FF flag to rsync invocation in synchronize
...
The `-FF` option causes rsync to look for files in the source directory named `.rsync-filter` and uses them to filter directories underneath them. If no `.rsync-filter` files are found, the behavior is identical to the command run without the -FF option. This flag does not sync the .rsync-filter files themselves.
This change should be backwards compatible and not produce surprising behavior for users, since they are unlikely to create `.rsync-filter` files unintentionally.
2013-11-25 12:27:58 -05:00
greenbrian
74a2bf4369
Update unarchive
...
Modified argument order provided to unzip command as the -o was being interpreted as a file.
2013-11-25 10:44:39 -06:00
Aleksey Ovcharenko
bb3a23d40a
Added existing_only options to skip creating new files on receiver
2013-11-22 23:59:57 +02:00
Michael Scherer
b3758f6ea4
Do not use construct not compatible with python 2.4, fix #5006
2013-11-22 16:06:41 +01:00
Joshua Lund
4b9227a673
Fixed a typo in the 'unarchive' module documentation
2013-11-21 16:22:20 -07:00
James Tanner
aa0af14734
Fix pep8 errors in unarchive module
2013-11-19 16:35:06 -05:00
Michael DeHaan
08996d78d6
Add version_added to all modules missing version_added information, the docs formatter will now
...
raise errors when omitted, updated changelog with new modules.
2013-11-18 18:55:49 -05:00
Evan Kaufman
2c8b761a65
Added replace module
...
Heavily based on existing lineinfile module, but where it literally tests a regexp against
*each individual line* of a file, this replace module is more analogous to common uses of
a `sed` or `perl` match + replacement of all instances of a pattern anywhere in the file.
Was debating adding `all` boolean or `count` numeric options to control how many
replacements to make in the destfile (vs currently replacing all instances)
Noted use of MULTILINE mode in docs, per suggestion from @jarv
2013-11-16 13:23:50 -06:00
James Tanner
b982a3d353
Clean up erroneous lineinfile.orig file
2013-11-15 12:17:17 -05:00
James Tanner
a3631638e5
Set required = True for src in unarchive module.
2013-11-14 10:59:24 -05:00
jctanner
4e76e6047d
Merge pull request #4625 from pileofrogs/devel
...
unarchive module & action plugin
2013-11-14 07:57:57 -08:00
James Tanner
0f806cfdfa
Merge pull request #4525 from ko-zu/ansible
...
Add a regexp parameter to assemble module to match or exclude filenames.
2013-11-14 10:30:12 -05:00
James Tanner
0f3093516d
Merge pull request #4375 from pfalcon/ansible
...
copy: Implement recursive copying if src is a directory.
2013-11-13 15:52:40 -05:00
James Tanner
53ba890312
Fixes #4884 Do not prematurely exit from file module if src not defined
2013-11-12 18:17:20 -05:00
James Tanner
2e916df20f
Add default for remote_src to assemble dostrings to avoid confusion
2013-11-12 13:21:49 -05:00
jctanner
28de7dab2f
Merge pull request #4738 from bcoca/assemble_action_plugin
...
assemble can now use src from master/origin
2013-11-12 08:23:39 -08:00
James Tanner
1ad4f6e325
Fixes #4522 Document that comments in ini files will be discarded with the ini module
2013-11-08 09:57:22 -05:00
James Tanner
2c57b999fc
Addresses #4801 Update file module docs to indicate behavior for relative src paths
2013-11-07 17:02:34 -05:00
jctanner
f340f916b4
Merge pull request #4801 from sspans/devel
...
Add support for relative symlinks
2013-11-07 13:57:18 -08:00
James Tanner
39fdb934be
Add doc example for lineinfile without a regexp parameter
2013-11-06 18:51:31 -05:00
James Tanner
f8eea4e155
Merge pull request #4660 from kolbyjack/lineinfile_no_regexp
2013-11-06 18:43:10 -05:00
James Tanner
3ae95c8953
Fix merge conflict
2013-11-06 18:38:01 -05:00
James Tanner
7b3fbeee16
Addresses #4676 Add module notes about the behavior of sudo and the destination paths within the synchronize module.
2013-11-04 12:19:31 -05:00
James Tanner
403469bf19
Update synchronize docstrings for rsync_timeout parameter
2013-11-04 10:57:08 -05:00
James Tanner
ae1248dee6
Add a timeout to the synchronize module to prevent infinite hangs while waiting on passwords for misconfigured users
2013-11-04 10:52:44 -05:00
sspans
9f322a5178
skip absolute path creation for old_src, not needed with the new relative links
2013-11-04 10:44:06 +01:00
sspans
4957115e51
only require absolute paths for hardlinks
2013-11-04 10:37:36 +01:00