Commit graph

24651 commits

Author SHA1 Message Date
Sam Doran
7c8af3d684 Reboot - Fix VMware ESXi not working by adding appropriate commands (#49637)
* Add commands for VMware ESXi

* Add changelog
2018-12-11 15:30:11 -05:00
Brian Coca
63279823a7
allow caller to deal with timeout (#49449)
* allow caller to deal with timeout

  a start for #43884 and timeout issues in long operations
2018-12-11 15:21:18 -05:00
Pilou
1bad617f29 Inventory plugins move auto before ini (#44428)
* inventory plugins: try auto before ini

auto plugin should run before ini to avoid ini being able to parse
some plugin configuration YAML files successfully.

* Update comment

comment was added by 2ffe3c42bb but
related code was later removed by
506e6a0b2d.
2018-12-11 15:17:05 -05:00
Nathaniel Case
7af405883f
Don't fail on unable to set terminal width on ios (#47290)
* Don't fail if ios can't set terminal width

* Fix display import
2018-12-11 15:09:00 -05:00
Darragh Bailey
4947936176 Remove sleep and switch to pipe for IPC (#28561)
Use a simple multiprocessing pipe to delay exiting the parent process
until after the child has been doubly forked.

Using a simple IPC to allow the forked process to start avoids the
control node waiting unnecessarily for lightly loaded systems.
2018-12-11 14:26:06 -05:00
Sam Doran
c1589c33c4
Reboot - Fix command not found, add Apline support, fix Solaris command (#49272)
* Fix various bugs related in reboot

- Use format strings for consistency and improve debug log messages
- Use local variables instead of class attributes in order to be thread safe
- Run setup module to get distribution and version
- Run find module to get full path of shutdown command
- Use ansible_os_family and ansible_distribution to find commands and args
- Use same command for all Solaris/SunOS distributions
- Move delay calculations to properties
- Reliably check for module run failure
- Fix bug in run_test_command() that accidentally made the method work properly
- Use better exceptions rather than Exception
- Use dict literals rather than constructors
- Correct _check_delay() so it always returns a value, not None
- Don't store and return result in run_test_command() because it's not used anywhere
- add test for post reboot command that fails
- test negative values for delay parameters
2018-12-11 11:05:10 -05:00
Matt Martz
2a469fd959 Consolidate handler tracking (#49338)
* Consolidate handler tracking
  -  Remove unused code. ci_complete
  - unit test fixes. ci_complete
  - Restore previous behavior of matching a single handler
  - when notifying a host for a handler, return True if it was added, False otherwise, to reduce copied logic
  - rename funcitons for clarity. ci_complete
  - Remove handler logic for static includes which was disabled previously
2018-12-11 10:58:19 -05:00
rajeevarakkal
62b2a08cfb Add DellEMC iDRAC Firmware module (#46675)
Co-Authored-By: rajeevarakkal <36444805+rajeevarakkal@users.noreply.github.com>
Co-Authored-By: Sviatoslav Sydorenko <578543+webknjaz@users.noreply.github.com>
2018-12-11 16:38:01 +01:00
Matt Martz
c9040d7579
Don't just raise AnsibleError with the exception message (#49654)
* Don't just raise AnsibleError with the exception message. Fixes #49252

* Add changelog fragment
2018-12-11 09:27:10 -06:00
Brian Coca
8ce4720f44
pear: More info if failure occurs (#49735)
* added cli errors to error msg for pear
2018-12-11 09:38:06 -05:00
Steven Tobias
260512459d stop requiring description. this is not a mandated jira field for all screens (#46023) 2018-12-11 14:24:24 +00:00
Gonéri Le Bouder
e7750768f7 nmcli example: modern way to install packages (#49110)
- use the generic `package` module, this way it will cover dnf and yum
- to not specify the x86_64 arch, the package manager will pull the fine
  version anyway
- with_items with package is deprecated
- libnm-qt-devel is only in Fedora 27 and 28.
2018-12-11 17:37:07 +05:30
Abhijeet Kasurde
e464c543f6
Add support for variable_{start,end}_string (#49711)
Template lookup plugin now support variable_start_string and
variable_end_string, just like template module.

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-12-11 15:22:12 +05:30
Xijun Dai
7186234a84 Fix Unicode-objects must be encoded before hashing (#46608) 2018-12-10 17:09:29 -08:00
Peter Kirby
41a6c1d220 Update rds.py (#49674)
Adds endpoint and port to the instance return values for rds.py.  Partial fix for #37209
2018-12-10 16:47:55 -06:00
Sandra McCann
418c03a686 added dhcp standard options (#49729) 2018-12-10 13:11:42 -06:00
Sandra McCann
62af321909 added jinja2 example (#49740) 2018-12-10 13:10:17 -06:00
Abhijeet Kasurde
be21140384
VMware: update docs and return docs for vmware_host_service_facts (#49736)
Follow up of 45155

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-12-10 23:57:39 +05:30
Dag Wieers
7b01725bb5 mail: Fix new breakage on python 2.7 (#49197)
* mail: Fix new breakage on python 2.7

* Add changelog fragment

* Add basic SMTP testing

* Add SMTP integration tests using starttls and TLS
2018-12-10 10:25:33 -08:00
Ken Dreyer
eae81e36fd openstack: document RETURNS for os_volume (#49559)
Document the "id" and "volume" return values from the os_volume module.
2018-12-10 11:29:34 -06:00
Brian Coca
758ac1846b
match interpreter on stdout also (#49446)
fixes #46980
2018-12-10 11:43:30 -05:00
Brian Coca
e53a7856f6
simplify vm_guest detection code (#49378)
- remove a lot of repetition
  - change lists to tuples since they are faster to assign
2018-12-10 11:42:51 -05:00
Brian Coca
42a13d15f1
add path info to role list (#49346)
* add path info to role list

 - use same display format for both listing all and specific roles


Co-Authored-By: bcoca <bcoca@users.noreply.github.com>
2018-12-10 11:41:22 -05:00
Brian Coca
0c1f62065c
make adhoc include_role/task work again! (#49247)
* adhoc include_role/task work again!
  - fix task, pass if set
2018-12-10 11:40:44 -05:00
René Moser
e0ad0eb42c Merge pull request #49678 from resmo/fix/cloudstack-tests-unstable
cloudstack: Fixes for unstable tests
2018-12-10 08:39:16 -08:00
Brian Coca
70ba960f6d
More specificity in errors for cfg mgr (#48995)
* More specificity in errors for cfg mgr
2018-12-10 11:38:42 -05:00
Brian Coca
20270680fc
fixes to ansible-doc (#47682)
fixes to ansible-doc
 - change json to always be type dependent
 - change changelog generation to loop over the options
 - warn about ignoring module path
2018-12-10 11:37:15 -05:00
Andreas Krüger
18bf48cec2 Pull documentation of ansible.module_utils.basic from (improved) doc strings. (#48416) 2018-12-10 09:17:15 -06:00
Brian Coca
ba4c2ebeac
ensure ssh retry respects no log (#49569) 2018-12-10 09:55:18 -05:00
Dag Wieers
37820be05b
aci_rest: Fix ignoring custom port (#49715) 2018-12-10 15:08:06 +01:00
Felix Fontein
270b6a2ee2 docker_*: hint at DOCKER_CONFIG environment variable (#49689)
* Hint at DOCKER_CONFIG environment variable directly supported by docker-py.

* Adjust wording.
2018-12-10 13:40:29 +00:00
Dag Wieers
23ae3aa32a read_csv: new module to read CSV files (#49578)
* read_csv: new module to read CSV files

* Add a doc reference to the csvfile lookup plugin

* Enable the use of custom dialect options

* Improve error handling

* Fix PEP8

* Fix more PEP8

* Simplify custom dialect code

* Add integration tests

* Fixes for CI

* Fix for python 2.6
2018-12-10 11:42:47 +00:00
Carsten Koester
e25dac946f openstack: fix parameter handling when cloud provided as dict (#42899)
* openstack: fix parameter handling when cloud provided as dict

If a cloud is provided as dictionary:

 * Do not assert that 'interface' parameter is None. Instead,
   assert that it is 'public'.
 * Assert that 'auth_type' parameter is not set.

Fixes #42858

* os_user: Include domain parameter in user lookup

If a "domain" parameter is provided, use it in looking up
whether the user already exists.

Fixes #42901

* os_user: Include domain parameter in user deletion

If a "domain" parameter is provided, use it in deleting
the user also.

Fixes #42901
2018-12-10 11:41:22 +00:00
Felix Fontein
495a426039 docker_swarm: fix minimal API version (#49691)
* Reduce minimally required docker API version to 1.25, with selective features requiring 1.30.

* Adjust test requirements.

* Forgot some imports.
2018-12-10 14:09:28 +05:30
Dario Zanzico
b183eb4464 docker_swarm_service: ensure idempotency when the user parameter is None (#49235)
* ensure idempotency for user set to None

* Update `user` documentation and add changelog fragment

* clarify changelog fragments and parameters documentation

* use restructuredtext syntax in changelog fragment
2018-12-10 14:09:13 +05:30
Zim Kalinowski
b89eb7a8c9
Support for generalizing VMs (#49704) 2018-12-10 16:21:09 +08:00
Felix Fontein
aec98b6aab Add docker_volume_facts module (#49692)
* Add docker_volume_facts module.

* Fix type confusion.

* Improve tests.
2018-12-10 15:41:46 +10:00
Christian Kotte
36e3edff50 VMware: New module vmware_host_snmp (#47937) 2018-12-10 11:01:41 +05:30
Christian Kotte
4903e42e2f VMware: New module vmware_vcenter_settings (#48083) 2018-12-10 11:01:15 +05:30
Dave Bendit
f545763296 [docker_network_facts] Creating docker_network_facts module (#49644)
Part of #49267
2018-12-10 15:24:05 +10:00
Abhijeet Kasurde
c9325ca247
Override help string version (#49545)
This fix adds additional help message to version command options

Fixes: #20488

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-12-10 10:40:19 +05:30
Yuwei Zhou
5a59748e6c Fix if the route table changed to none (#49533) 2018-12-10 10:30:23 +08:00
Yuwei Zhou
c0d95a73ff azure_rm_image module's source can accept dict value (#48864) 2018-12-10 10:29:12 +08:00
Dag Wieers
ee0df72e49 PSRP: Move default loglevel of pypsrp to WARNING (#49673) 2018-12-10 09:09:59 +10:00
Alicia Cozine
9142cfc86f
fixes typos in ansible-vault docs (#49671) 2018-12-09 17:05:53 -06:00
jgkirschbaum
87cbce3d90 rabbitmq_vhost_limits: Move to rabbitmq subdirectory (#49650) 2018-12-08 23:41:59 +01:00
Matt Martz
9007dbec2f
Add info about loop based on jinja2 loop var (#42134)
* Add info about loop based on jinja2 loop var

* ansible_loop

* Update test count

* Add extended loop_control that defines whether ansible_loop should be added

* Extended needs to be defaulted

* Revert "Update test count"

This reverts commit f1e93ee469825f4cdcd90fb28667d29aa088275c.

* Add docs about loop_control.extended

* Add revindex and revindex0

* Document ansible_loop in special vars

* Add changelog fragment

* Add tests, change items to allitems so that dot notation works, fix logic error with previtem
2018-12-07 13:49:50 -06:00
Brian Coca
597c258e0e
explain 'bare variables' (#49577) 2018-12-07 14:47:56 -05:00
James Tanner
b6220ce16a rhn_channel lacks sufficient testing and supportability 2018-12-07 11:13:19 -08:00
Andreas Calminder
876b637208 move some of basic into common (#48078)
* move file functions into common.file

* move *_PERM_BITS and mark as private (_*_PERM_BITS)

* move get_{platform, distribution, distribution_version} get_all_subclasses and load_platform_subclass into common.sys_info

* forgot get_distribution_version, properly rename get_all_subclasses

* add common/sys_info.py to recursive finder test

* update module paths in test_platform_distribution.py

* update docstrings, _get_all_subclasses -> get_all_subclasses

* forgot to update names

* remove trailing whitespace
2018-12-07 10:21:11 -08:00
Matt Martz
3a4d476512
Add now() jinja2 global func for getting the date/time (#43792)
* Add now() jinja2 global func for getting the date/time

* Docs and changelog

* now isn't a lookup, it doesn't need disabled
2018-12-07 11:25:53 -06:00
Sam Doran
3d5d0d355f Add purge feature to rhsm_repository (#48123)
This feature makes it easy to enforce exactly which repos are enabled on a managed system without the need for multiple tasks.
2018-12-07 11:53:42 -05:00
Alexander Bethke
27fd8e4dc6 Fix two regressions in flatpak and flatpak_remote modules (#49651)
* Fix python 3 compatibility in flatpak_remote module

* Fix flatpak module for recent versions of flatpak

* Add reminder for contributors to run integration tests manually

There has been several Python version compatibility regressions
introduced into the module which could have been avoided by the
integration tests.
2018-12-07 11:38:42 -05:00
Sorin Sbarnea
cba3290621 Record host specific messages to log files (#28661)
Fixes #28660

Change-Id: I0028f16320fd63c6ee0fa3be942fc88c555e4dcb
Signed-off-by: Sorin Sbarnea <ssbarnea@redhat.com>
2018-12-07 11:11:17 -05:00
Patrick Marques
7aa11c441d Print hostname when fails to generate keyed groups (#49609) 2018-12-07 10:18:25 -05:00
Simon Dodsley
f6b211890a Update purefa_host module (#49157) 2018-12-07 09:42:59 -05:00
Miguel Angel Muñoz González
baf99c8b62 Fortinet's FortiOS firewall ippool IPv6 (#49311)
* Fortinet's FortiOS firewall ippool IPv6

* Update fortios_firewall_ippool6.py
2018-12-07 13:53:02 +00:00
Miguel Angel Muñoz González
0732d4e2cf Fortinet's FortiOS firewall ippool (#49310) 2018-12-07 13:52:46 +00:00
Jose Delarosa
4d77d601ff Add new Redfish command module to handle iDRAC-specific extensions (#49572)
- Module extends the existing RedfishUtils class and leverages its methods
- Acknowlegements to Bill Dodd (@billdodd) for creating original Proof-of-Concept
2018-12-07 13:43:30 +00:00
Miguel Angel Muñoz González
913f6e36f1 Fortinet's FortiOS firewall policy for IPv6-IPv4 (#49309) 2018-12-07 13:42:43 +00:00
Miguel Angel Muñoz González
229013e652 Fortinet's FortiOS firewall vip group for IPv6-IPv4 (#49307) 2018-12-07 13:42:28 +00:00
Miguel Angel Muñoz González
fbf311b094 Fortinet's FortiOS firewall vip group for IPv4-IPv6 (#49306) 2018-12-07 13:42:12 +00:00
Miguel Angel Muñoz González
e1f1e83e77 Fortinet's FortiOS firewall vip group for IPv6 (#49305) 2018-12-07 13:41:12 +00:00
Miguel Angel Muñoz González
c5dbbacce9 Fortinet's FortiOS firewal vip group (#49303) 2018-12-07 13:40:56 +00:00
Miguel Angel Muñoz González
9286763181 Fortinet's FortiOS firewal vip64 (#49302) 2018-12-07 13:35:03 +00:00
Miguel Angel Muñoz González
dfccf5c542 Fortinet's FortiOS firewall vip6 (#49297)
* Fortinet's FortiOS firewall vip6

* Update fortios_firewall_vip6.py
2018-12-07 13:34:40 +00:00
Miguel Angel Muñoz González
877d40cef7 Fortinet's FortiOS firewall addgrp6 (#49295) 2018-12-07 13:31:16 +00:00
Miguel Angel Muñoz González
58711a539b Fortinet's FortiOS firewall address6 template (#49293) 2018-12-07 13:30:58 +00:00
Miguel Angel Muñoz González
ea23681c76 Fortinet's FortiOS firewall address6 module (#49292) 2018-12-07 13:30:41 +00:00
Miguel Angel Muñoz González
d15c221615 Initial commit for fortios_firewall_vip46 (#49106) 2018-12-07 13:29:54 +00:00
Miguel Angel Muñoz González
87905063e2 Initial commit for firewall_vip46 (#49105)
* Initial commit for firewall_vip46

* Initial commit for fortios_policy46

* Revert "Initial commit for fortios_policy46"

This reverts commit dd568b6039.
2018-12-07 13:29:32 +00:00
Miguel Angel Muñoz González
06871d1015 Initial commit for firewall_policy6 (#49091) 2018-12-07 13:29:03 +00:00
John Westcott IV
6469baf460 Added get_certificate module (#41735)
* Added get_certificate module.

* Fixed test against bogus_ca.pem file
2018-12-07 13:27:16 +00:00
Thomas O'Donnell
c802790c90 Update postgresql_ext connection methods (#48538)
Have added some extra arguments to the postgresql_ext module to allow
configuring an SSL connection to the postgresql server and explicit
support for connecting via a unix socket. The arguments and method used
here for the connection are the same as used by the postgresql_database
module.
2018-12-07 08:21:39 -05:00
Pavlos Tzianos
a4eb4b2551 Rabbitmq user permission fixes (#49404)
* Simplify permission changing code for rabbitmq_user module

* Add check for multiple permission dicts for same host to rabbitmq_user module

* Add docstring for _get_permission method of rabbitmq_user

* Fix method that compares vhost permissions in rabbitmq_user

* Add tests for rabbitmq_user module

* Add helper function for simulating collections.Counter functionality
2018-12-07 13:19:08 +00:00
Jordan Borean
198f1e1bea
Revert "Fixes #49362 module dnf: install python3-dnf preferably over python2-dnf. (#49402)" (#49633)
This reverts commit 3247eec97a.
2018-12-07 08:29:12 +10:00
Sean Myers
9434f8608a Add rhsm_repository_release module (#43211)
* Add rhsm_repository_release module

* bump ansible version_added

* Fix imports in rhsm_repository_release unit test
2018-12-06 20:16:18 +00:00
Bill Dodd
303c3494e6 remove non-standard CreateBiosConfigJob command (#48740) 2018-12-06 15:05:31 -05:00
Miguel Angel Muñoz González
4f416597b8 Initial commit for firewall vip (#49003)
* Initial commit for firewall vip

* Limit lines to below 160 chars

* Fix trailing whitespace
2018-12-06 19:04:51 +00:00
Jose Delarosa
d459c2c582 Fix idempotency issues 2 (#49333)
* Fix idempotency issues in set_manager_attributes

* Add changed status in set_bios_default_settings
2018-12-06 18:52:31 +00:00
Dave Bendit
73640a4190 [docker_network] Adding scope and attachable flags (#49562)
Incorporating the abandoned work from PRs #35288 and #45552. Also adding in
the version checking from `docker_container.py`, which should be abstracted
out to `docker_common.py`.
2018-12-06 18:50:45 +00:00
lrrb
4f9f1754b4 fix: ensure than all item of a list of excluded files aren't checked (#45122)
* fix: ensure than list of excluded files aren't checked
* test: exclude a list of files
2018-12-06 10:13:31 -08:00
Jordan Borean
0d7e95b4db Clarify that do until loops are unsupported on include tasks (#49581) 2018-12-06 11:02:47 -05:00
Abhijeet Kasurde
d8859a7352 Update lambda documentation for runtimes (#49595)
There is no API or AWS command to list down latest available
runtimes. Updated documentation with AWS official lambda docs.

Fixes: #49552

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-12-06 10:58:58 -05:00
Chris St. Pierre
63b7882cbb Deprecate the github_hooks module (#49296)
It was super incomplete, and the interface was pretty strange; it had
built-in features to handle pretty bespoke workflows ("clean504",
e.g.) but was lacking lots of other useful features (like the ability
to create a webhook with a shared secret). Rather than try to update
the interface in a backwards compatible way, I've replaced it with the
more predictable, single-purpose github_webhook and
github_webhook_facts modules.
2018-12-06 15:56:53 +00:00
Matt Martz
69d230f4bf Make squash deprecation messages less misleading (#49551) 2018-12-06 10:49:01 -05:00
Chris St. Pierre
891f1a59cb Add github_webhook module (#35813)
* Add github_webhook module

github_webhook lets you easily create, update and delete Github
webhooks.

This is part of a two-part replacement for github_hooks, which lacks a
number of important features and has a strange interface.
2018-12-06 13:40:17 +00:00
Chris St. Pierre
edaccc58a4 Add github_webhook_facts module (#35814)
* Add github_webhook_facts module

github_webhook_facts gathers information about Github webhooks.

This is part of a two-part replacement for github_hooks, which lacks a
number of important features and has a strange interface.
2018-12-06 13:29:59 +00:00
Thomas Picariello
c8ecac8dc2 Fix google auth scoping for unscoped credentials (#46740)
* Fix google auth scoping for unscoped credentials

* Add changelog fragment
2018-12-06 11:29:57 +00:00
Adam Miller
6f90d62be3 fix py3 scope for unique filter errors, enable filters integration tests on rhel8 beta (#48961)
* fix py3 scope for unique filter errors, enable filters integration tests on rhel8 beta

Signed-off-by: Adam Miller <admiller@redhat.com>

* add changelog

Signed-off-by: Adam Miller <admiller@redhat.com>
2018-12-06 16:13:26 +10:00
uberjew666
b72187cd2c Fixed win_route module (#46395)
* Changed $IpAddress to $Gateway

* Tweaked win_route unit tests

Checks to see if new static route has the correct gateway

* Create win_route.yaml

* Fixed incorrect variable name
2018-12-05 22:39:06 -05:00
Zim Kalinowski
a74449b05f several vmss fixes (#49580) 2018-12-06 10:23:03 +08:00
Tim Rupp
c0520b94b8
Corrects idempotency for f5 parameters (#49576)
Several parameters in the profile modules were not idempotent.
This patch fixes those modules
2018-12-05 16:17:37 -08:00
Tim Rupp
1c3fa2b07f
Deprecate the bigip_asm_policy module (#49574)
Specific import and export modules should be used instead
2018-12-05 16:02:16 -08:00
Sloane Hertel
ae12be6cd9 Add inventory cache options to config base (#46097) 2018-12-05 17:09:49 -05:00
Rhys Campbell
cdc0011333 mongodb_shard module and test exception (#43673)
* mongodb_shard module and test exception

* Update version_added

* Documentation improvements

* Correct yaml errors

* Correct lines over 160 chars

* Correct replicaset

* Minor documentation changes
2018-12-05 16:29:45 -05:00
Toshio Kuratomi
bd7322a3f6 Simplify FactCache.update()
We only need FactCache.update() for the backwards compatibility shim as
MutableMapping.update() will do the right thing.
2018-12-05 12:33:27 -08:00
Toshio Kuratomi
33f0c1ce22 FactCache changes
* Fix FactCache to conform to the dict API
  * update needs to take a dict rather than a key and a value
  * __init__ needs to allow for setting the intial dictionary
* Remove unneeded _display and _cache attributes
* Move ansible.plugins.cache.FactCache to
  ansible.vars.fact_cache.FactCache because this isn't part of the cache
  plugin API.
* Add backwards compatibility when calling update on the new FactCache
* Remove code for calling old FactCache. There's no way to call the old
  FactCache so there's no need for backwards compatible code for calling
  code.  Backwards compatibility is handling things which are calling
  the new FactCache.
* Port our code to the new FactCache location.
2018-12-05 12:33:27 -08:00
Brian Coca
6096f57880 fix cache 'update' method to be 'mapping' compatible
- also simplify the update functions
 - fix methods and allwow backwards compat with plugins overriding 'update'
2018-12-05 12:33:27 -08:00
Ken Dreyer
8e05d8e329 docs: link to openstacksdk (#49521)
We use the openstacksdk library for OpenStack client configuration now.
Update the doc fragment so we point users at the correct place.
2018-12-05 14:06:20 -05:00
Ganesh B Nalawade
329cbcf973 Fix in dict_merge to check for Mapping
*  Based on review comments for PR #49474 change the check
   for isinstance from `dict` to `Mapping`
2018-12-05 10:31:32 -08:00
Matt Martz
77de219836
Support version 3 of the redis python library (#49445)
* Support version 3 of the redis python library. Fixes #49341

* Document 2.4.5 minimum redis-py version
2018-12-05 12:08:53 -06:00
Brian Coca
e17a2b502d updated ff docs to include and deprecate skip (#45167)
* updated ff docs to include and deprecate skip

* fine tuned requires

* deprecate

* fixes
2018-12-05 12:08:30 -05:00
Ryan Conway
aacd22acc6 Fix an issue retrieving some types of 1Password items. (#47213)
* Some types of 1Password items have a 'password' field alongside the 'fields' attribute, not inside it, so we need to search there as well.

* Add changelog fragement for onepassword_facts PR #47213.
2018-12-05 11:49:26 -05:00
Anil Kumar Muraleedharan
dd004321d4 Refactoring code of cnos_portchannel as cnos_linkagg in tune with other vendors. (#49467)
* Refactoring code of cnos_portchannel as cnos_linkagg in tune with other vendors.
2018-12-05 11:03:42 -05:00
Simon Dodsley
29e071d67a Major update for purefa_pg module (#46771) 2018-12-05 08:21:09 -05:00
Josue David Hernandez
6d42c5020a Fix for changes in clearlinux (#49344)
* Fix for changes in clearlinux

clearlinux is now providing /etc/os-release file and ansible is identifying as NA
then this change allow ansible to find it

Signed-off-by: Josue David Hernandez Gutierrez <josue.d.hernandez.gutierrez@intel.com>

* Add changelog fragment for clearlinux changes

Signed-off-by: Josue David Hernandez Gutierrez <josue.d.hernandez.gutierrez@intel.com>
2018-12-05 13:13:40 +00:00
Klaus Frank
cb24ab3014 VMware: Implement wait_for_customization (#46625)
* Implement wait_for_customization
* Add documentation for vmware_guest's wait_for_customization parameter

Fixes #43082
2018-12-05 18:15:30 +05:30
Abhijeet Kasurde
2af4761677 Documentation update for route53_facts (#49525)
Updates details about required parameters.

Fixes: #49450

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-12-05 10:21:17 +00:00
chris93111
7c8b5a407d VMware: Add option to modify disk type while cloning template (#47859)
* Add parameters to module vmware_guest for conversion of disk to thin or thick when vm is cloned or deployed with template

* unit test for convert clone vm

Co-Authored-By: chris93111 <christopheferreira@ymail.com>
2018-12-05 15:50:23 +05:30
Naval Patel
880390ca0a Added new module lxca_nodes for Lenovo XClarity Administrator (#46767)
* Added new module lxca_nodes
2018-12-05 10:18:36 +00:00
Christian Kotte
f3c4b2fc74 VMware: New module vmware_vcenter_statistics (#48084) 2018-12-05 15:46:42 +05:30
Toshio Kuratomi
c817bef3ae Fix for callback plugins on Python3 when a module returns dictionary keys that aren't strings
This fixes one of the problems reported in https://github.com/ansible/ansible/issues/49343

Upstream Python3 bug for the json traceback:
https://bugs.python.org/issue25457

and PR that may fix it:
https://github.com/python/cpython/pull/8011
2018-12-04 23:03:48 -08:00
Andrey Che
64636d9de0 fix synchronize handling of encrypted hosts on delegation (#49460)
* Fix for #49363

* Replaced str() with to_text() as more python version safe

* Changed to comply to errors stragegy
2018-12-04 22:33:58 -08:00
Tim Rupp
1c644fb042
Adds description param to bigip_data_group (#49527) 2018-12-04 21:54:20 -08:00
Tim Rupp
60b75c2cfd
Adds ASM policy import module (#49526) 2018-12-04 21:34:55 -08:00
Tim Rupp
7a4c7b8c0f
Adds module for gtm topology regions (#49510) 2018-12-04 20:58:52 -08:00
Abhijeet Kasurde
1763c8123b
AWS: Add support for available db types (#48703)
Add several database types which are supported by AWS in valid engine type.

Fixes: #48623

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-12-05 08:59:36 +05:30
James E. King III
79c0e30c5a azure_rm_image: fix creation of image with data disks (#49394) 2018-12-05 09:36:34 +08:00
mattandes
15c5dbcc20 Fix win_nssm credentials quoting (#48761)
* Fix win_nssm credentials quoting

Fix credential quoting for win_nssm after changes to the way nssm command is invoked in Ansible 2.7.1.

* Updating nssm command to update credentials to use Argv-ToString to properly escape password variable.

* Adding changelog fragment for fix of #48728.
2018-12-05 10:38:28 +10:00
James Cassell
2bd6b1415b become_method: make dzdo more like sudo (#47946)
dzdo is basically a drop-in replacement for sudo and supports the same
command line options.

There is no become_flags set for dzdo like there is for sudo, so users
will have to set that separately to have exactly the same functionality.
2018-12-04 18:24:32 -05:00
Toshio Kuratomi
d06cd869b8 Revert "fix cache 'update' method to be 'mapping' compatible"
This reverts commit 68301f890a.
2018-12-04 14:04:13 -08:00
Wojciech Sciesinski
e4a3e73b15 Add win_psrepository (#48828)
* Add win_psrepository

* Small corrections

* Correct requiqurements - add NuGet

* Extend tests

* Post-review updates

* Post-review - updates 2

* Add empty RETURN section in documentation

* Add empty line at EOF

* Post-review updates 3

* Update tests to run in check_mode too

* Minor updates

* Correct installing/updating NuGet

* a few changes for review

* Remove copyrights

* Revert "Remove copyrights"

This reverts commit 2d687ec6a6.
2018-12-04 22:47:28 +01:00
Robert de Bock
3247eec97a Fixes #49362 module dnf: install python3-dnf preferably over python2-dnf. (#49402)
* Create python3and2

Adding tests to see if dnf still works when python-2 and python-3 are installed.

* Update main.yml

Include the tests that run on python 2 and python 3, based on the package manager.

* Update dnf.py

Use python3-dnf by default, otherwise python2-dnf.

* Rename python3and2 to python3and2.yml

Rename.
2018-12-04 16:43:45 -05:00
Tim Rupp
c7dd13758e
Adds bigip_profile_analytics module (#49499) 2018-12-04 12:53:31 -08:00
Bianca Henderson
5499ee30d4 Change GB to GiB in some AWS modules (#49304) 2018-12-04 15:46:34 -05:00
Sloane Hertel
a3e8917b73 [s3_bucket] Handle error paginating object versions when bucket does not exist (#49396) 2018-12-04 15:42:14 -05:00
Toshio Kuratomi
a8fbfe1844 Warn if empty string is present in synchronize's rsync_opts 2018-12-04 12:05:45 -08:00
Tim Rupp
caa6ed3c66
Adds ASM policy fetch module (#49494) 2018-12-04 11:24:34 -08:00
Tim Rupp
138690519d
Various small fixes for f5 ansible modules (#49492) 2018-12-04 11:15:49 -08:00
Sam Doran
6200d32c0d Use IndexError in exception (#49488) 2018-12-04 14:12:00 -05:00
Tim Rupp
7c15417f62
Fixes for examples in f5 modules (#49490)
So that they use provider instead of deprecated args method
2018-12-04 10:31:25 -08:00
Sam Doran
40a5f7bfdf Add better error when k=v syntax is used with YAML in tasks (#41754)
* Add error message for k=v and YAML in a single task

Find the correct line, column, and position for k=v errors since they are different than the position reported initially.

Document bug in quoting syntax check.

* Change tense or error message

Since the error still exists, switch to present tense rather than past tense.

* Remove double spaces after periods in error messages.

http://www.slate.com/articles/technology/technology/2011/01/space_invaders.html

* Add changelog fragment

* Add tests for new error message

* Fix tests

* Add clarifying comments to unit test
2018-12-04 12:32:02 -05:00
Mikhail
2f8d235ce5 Add apt_repo module (#49187) 2018-12-04 16:37:42 +00:00
linnil1
8de46f5cf7 [Junos] Fix bug of setting user password (#44660)
* Add encrypted_password for junos

* Add readme for Junos user encrypted_password

* encrypted_password added in 2.8
2018-12-04 15:49:13 +00:00
Richard Levenberg
5cb39d0d57 Use System.Xml.XmlDocument.Load rather than Get-Content to avoid (#49206)
encoding errors when writing out XML

removing executable bit

refactor tests to handle sanity checking
2018-12-04 15:19:38 +00:00
Łukasz Tomaszkiewicz
9d62cbc2af Fix TargetDBInstanceIdentifier assignment in wrong place (issue #46689) (#47710) 2018-12-04 12:43:49 +00:00
Jon Bergli Heier
9c02ade536 rabbitmq_binding: Add support for state=absent (#48599)
* rabbitmq_binding: Add support for state=absent

* Add integration tests for rabbitmq_binding

* Update testcases

* Add changelog fragment
2018-12-04 12:42:18 +00:00
Brett Maton
6291efd4ea Add module parameter to control Puppet agent noop switch (#43678)
* Puppet agent noop switch

    Add module parameter to control noop switch

    Current module overrides puppet.conf noop setting by forcing '--no-noop' switch  which may not be expected or desired.

    Add parameter to allow user control.

    noop: Undefined - Use agent configuration
    noop: true - Add --noop switch to cmd
    noop: false - Add --no-noop switch to cmd

Ansible check mode always runs with --noop switch

* Update lib/ansible/modules/system/puppet.py

Co-Authored-By: matonb <matonb@ltresources.co.uk>
Co-Authored-By: matonb <matonb@ltresources.co.uk>
Co-Authored-By: matonb <matonb@ltresources.co.uk>
2018-12-04 12:30:19 +00:00
styks1987
bb6a82d2a9 v2 dnsimple api uses type vs record_type (#39301)
* v2 dnsimple api uses type vs record_type

https://developer.dnsimple.com/v2/zones/records/#listZoneRecords

* replace prio with priority
2018-12-04 12:25:29 +00:00
shateq
895c6eea9e Extend functionality of filesystem module to support swap creation (#49456)
* Extended functionality of filesystem module to support swap creation

* Corrected documentation block

* Add a note to for version added

* was
2018-12-04 12:01:29 +00:00
thyme
8a30ceb347 Fix typo in confirm new vault password message (#49468) 2018-12-04 11:04:29 +00:00
Abhijeet Kasurde
a13d1eba93 Correct usages of custom error class (#48778)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-12-04 00:56:04 -05:00
Abhijeet Kasurde
1b04571ea0
VMware: Fix module usages in module_utils (#49421)
* VMware: Fix module usages in module_utils
* Skip test for Python 2.6 as SSL context is not available in Python 2.6

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-12-04 10:11:29 +05:30
Mike Wiebe
dd984709f5 Fix issues related to track feature (#49454) 2018-12-04 09:57:35 +05:30
sdirbach
e2f85b3f6c Implement test case prefix to filter test cases (#40174)
* Implement test case prefix to filter test cases

* Cut line to not exceed 160 chars

* Replace tabs with spaces

* Add version_added field

* Include changelog file
2018-12-03 18:41:44 +00:00
Paul Neumann
4c58fbc64d nxos: Make sure config ends with a linefeed (#48465)
The config parser on NX-OS does not deal with configs that do not end
with a linefeed correctly which leads to various issues when the config
is loaded from startup-config upon reboot. Therefore, ensure that the
config returned is terminated by a linefeed.
2018-12-03 19:26:26 +05:30
Ricardo Carrillo Cruz
5ffb863f0b Fix regex on ASA password prompt (#49438)
On Cisco ASAv on AWS, the prompt is 'Password', thus the privilege
elevation fails, we need to check upper and lower p.
2018-12-03 13:00:28 +00:00
Xaroth
a6db7f7abd -Fix: The Ubuntu 14.04 image on Shippable runs an old version of python, causing issues with checking out bitbucket, adjust tests to compensate. (#49433)
-Add: Mention bitbucket dropping TLSv1 and TLSv1.1 support as per 01 Dec 2018, potentially causing issues with older clients.
2018-12-03 12:35:58 +00:00
Akshay Gaikwad
597e449afe Support for pids_limit parameter in docker_container module (#49319)
* Support for pids_limit parameter in docker_container module

This add pids_limit parameter support in docker_container module

Fixes #43337

Signed-off-by: Akshay <akshay@localhost.localdomain>

* Add changelog for pids_limit parameter

Signed-off-by: Akshay Gaikwad <akgaikwad001@gmail.com>

* Remove unnecessary lines of code

The map is needed if the names are different.

Signed-off-by: Akshay Gaikwad <akgaikwad001@gmail.com>

* Update pids_limit option tests

It also run for docker-py < 1.10.0

Signed-off-by: Akshay Gaikwad <akgaikwad001@gmail.com>
2018-12-03 11:22:43 +00:00
Lukas Pirl
9fd5d01d67 `make` module: check return code (#47861) 2018-12-03 10:29:18 +00:00
Frank Zwart
329922e2dd ec2_instance: add placement_group support (#49286)
* add placement_group support
2018-12-03 10:27:54 +00:00
sdirbach
840ab706ee Implement hide task arguments feature (#40176)
* Implement hide task arguments feature

* Add version_added field

* Include changelog file
2018-12-03 09:22:51 +00:00
John Kerkstra
672acbea68 Adds redshift_cross_region_snapshots module (#35527)
* add redshift_cross_region_snapshots module, unit tests.

* fix errors

* use ec2_argument_spec as the basis for the argument spec. fixed
metadata_version

* follow best practices by naming example tasks.

* code review changes

* fix linting errors

* Update version added
2018-12-03 08:34:53 +00:00
Marcin
8a7d19788c Dont' attempt to remove drive if ID is "None" (#49423) 2018-12-03 15:09:03 +08:00
anasbadaha
7fcd55f3ec Fix Issue:#47076 onyx_l2_interface parameter trunk_allowed_vlans tries to remove all existing vlans on a port (#49418)
Signed-off-by: Anas Badaha <anasb@mellanox.com>
2018-12-03 10:39:39 +05:30
Felix Fontein
b0c7efcc6b ACME: add diff to acme_account, account_public_key to acme_account_facts, and general refactoring (#49410)
* Only one exit point.

* Refactoring account handling.

* Add diff support for acme_account.

* Insert public_account_key into acme_account_facts result and into acme_account diff.

* Add changelog.
2018-12-02 18:40:14 +01:00
Chris Archibald
62dd1fe29e New options of na_ontap_aggregate (#48906)
* add new options for na_ontap_aggregate

* add gpl line

* remove dup option

* Put files in wrong directory

* change unit test to match the request from PR 48941

* Changed for review comments

* pep8
2018-12-02 14:24:27 +00:00
Felix Fontein
34c57b4c42 ACME: fix bug introduced in #49266, work around problem with Pebble (#49407) 2018-12-02 10:07:21 +01:00
Ruben Tsirunyan
d62492e656 zabbix: New zabbix_action module (#49189) 2018-12-02 10:04:45 +01:00
Brian Coca
fc71cde7d3
Yaml inventory more tolerant (#48883)
* make yaml inv more tolerant to comments
* add tests for bad inventory processing

fixes #47254
2018-11-30 22:04:39 -05:00
Bob Vincent
2557373cc8 Do not document buggy behavior. (#49325)
In the pip module, umask should be specified as an octal *string*, not an octal (or decimal) *integer*.
2018-11-30 15:22:15 -06:00
Brian Coca
8c43ce491e unsafe cleanup 2018-11-30 13:07:00 -08:00
Alicia Cozine
031e961c58
removes talk of hardcoded loading from plugin docs (#49383) 2018-11-30 14:37:55 -06:00
Gregor Wegberg
4096d74245 Specify key to use while sorting permissions (#49126)
Without specifying the dictionary key to use while sorting it will fail
in Python 3 environments due to simplifying Python's rules for ordering
comparisons: https://docs.python.org/3.0/whatsnew/3.0.html#ordering-comparisons
2018-11-30 20:18:57 +00:00
Ken Partridge
19035dbcb2 CPM plugcontrol for WTI Power Devices (#47683)
* Add WTI OOB and PDU Device status, control and configuration module

* removed accidental file inclusions

* removed accidental file

* remove unneeded legacy files

* Added the new module cpm_plugcontrol to control the plugs on WTI Power devices
2018-11-30 20:13:48 +00:00
Ken Partridge
837818018d CPM plug configuration for WTI Power Devices (#47989)
* Add WTI OOB and PDU Device status, control and configuration module

* removed accidental file inclusions

* removed accidental file

* remove unneeded legacy files

* added the module cpm_plugconfig
2018-11-30 20:13:05 +00:00
Adam Miller
378cc9668c dnf module load/init dnf pkg mgr plugins properly (#49278)
* dnf module load/init dnf pkg mgr plugins properly

Fixes #45940

Signed-off-by: Adam Miller <admiller@redhat.com>
2018-11-30 10:00:33 -08:00
Jorgen
8ff13db17c Add Windows example of raw command (#47153)
* Add Windows example of raw command

Perform shutdown of Windows OS using Microsoft.PowerShell.Management module

* Capitalized cmdlet, remove quotes and improve description

This commit also cleans up some of the description sections.

* Use another example as suggested by jborean93

I was happy to merge this before I noticed jborean93 objected to the example :-/

* Fix whitespace issue
2018-11-30 17:12:19 +01:00
Martin Krizek
c78c8d389f
Last loaded handler with the same name wins (#49249)
* Last loaded handler with the same name wins

* Add comment explaining reversed
2018-11-30 16:30:27 +01:00
James Cote
aee9209375 Update set_fact doc to reflect updated caching options (#46565)
* Update set_fact doc to reflect updated caching options

* add note about change in precedence caused by caching
2018-11-30 08:42:47 -06:00
Peter Sprygada
2a4be2748f fixes an issue with dict_merge in network utils (#41107)
This change address a problem where the dict_merge function would fail
due to the value being a nested dict.  This will now recursively pass
the value back through the dict_merge function.
2018-11-30 17:52:33 +05:30
Youhua Li
c1a30c743e enable ONE auth file authentication (#49331) 2018-11-30 07:06:05 -05:00
Lars Kellogg-Stedman
b2e5c75131 server.security_groups is a list of dicts (#48798)
os_server was trying to access `[sg.name for sg in
server.security_groups]`, but the items in `server.security_groups`
are dictionaries, so that should be `sg['name']`.
2018-11-30 06:42:50 -05:00
Giovanni Sciortino
95718f7e12 fix archive module can not compress a single file in a tar file (#45117)
fixes #44968
2018-11-30 10:49:35 +00:00
Martin Surovcak
87a9ada188 fix module argument to be boolean (#47134) 2018-11-30 10:43:29 +00:00
Lex Rivera
aa484c0835 Fix GCE and scaleway VM detection (#47193)
* Fix Google cloud engine & Scaleway VM detection
2018-11-30 10:38:43 +00:00
maxstack
0dbac3f3b8 add default nolog param for VPN PreSharedKey (#47788) 2018-11-30 10:37:17 +00:00
Alan Rominger
d536be6530 Avoid duplicated recursive calls in inventory CLI (#48598) 2018-11-30 10:36:19 +00:00
ftntcorecse
b4ce4e1571 Fortinet FortiManager Device Group Module (#46086)
* fmgr_device_group PR candidate

* fgmr_device_group PR candidate

* PR candidate

* PR candidate

* Fixing Edits.

* Fixing Edits.

* Fixing Authors

* Removed State Parameter and replaced with Mode, per request of justjais
2018-11-30 15:54:41 +05:30
bverschueren
5cd31578cc comparing StorageConnection.password breaks idempotency (#48933) 2018-11-30 10:24:04 +00:00
Christian Kotte
68cafbda2b Improve vmware_dvswitch module (#48720) 2018-11-30 03:34:43 -05:00
Matthew Krupcale
93fd323457 Add support for newer FreeIPA SHA256 SSH public key hashes (#40803)
* lib/ansible/modules/identity/ipa/ipa_user.py:
    - Check any existing `ipa_user` SSH public key fingerprints for the hash algorithm to use
    - Generate `module_user` SSH public key fingerprint based on detected or default algorithm
2018-11-30 02:47:58 -05:00
Felix Fontein
2bd8e47247 add acme_inspect module (#48444) 2018-11-30 08:26:18 +01:00
rajaspachipulusu17
fe147289b7 Pluribus Networks pn access list module (#49176)
* Pluribus Networks pn access list module
* Added shlex import which was missing and added correct author
* Added an extra space which is according to pep8
2018-11-30 12:40:43 +05:30
Sofiane Medjkoune
ec73af1d78 Removed the unused argument description from lxd_container module (#31440) 2018-11-30 01:59:34 -05:00
Abhijeet Kasurde
3141fda6b4
Misc typos in ce action plugin (#49348)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-11-30 11:50:00 +05:30
Yunge Zhu
be28794dfc
fix keyvault key secret not support cloud environment (#49182) 2018-11-30 14:08:31 +08:00
Monty Taylor
824c72da5f Set play context on stdout callback plugin (#35910)
The loop on self._callback_plugins does not include the stdout callback,
so the stdout_callback never has set_play_context called.
2018-11-29 23:15:56 -05:00
Gaël Lambert
ad7798c26a Add the ability to download a specific version of an S3 object (#47867)
Add the ability to download a specific version of a S3 Object

Fixes: #47864
2018-11-30 08:59:12 +05:30
Florian Pracht
eb410a9987 Run patch command with --check option instead of --dry-run to support older BSDs (#42168) 2018-11-29 21:53:53 -05:00
Dag Wieers
bc481c2500 PSRP: Improve default logging to ansible.log (#47645) 2018-11-29 18:18:39 -08:00
Dag Wieers
01d66d4431 WinRM: Improve default logging to ansible.log (#49308) 2018-11-29 18:18:18 -08:00
Tomáš Pospíšek
434c421675 improve usage example of tempfile module (#47933)
* Show in example how to use file created by tempfile module
2018-11-29 16:24:58 -06:00
Chris Archibald
73348ae32d Fixes for na_ontap_cluster_peer (#48329)
* Fixes for na_ontap_cluster_peer, incorporating review comments, version, etc.
2018-11-29 16:22:02 -06:00
Laurent G
655b27f571 VMware: Add a pointer on how to get possible values. (#48658)
* Add a pointer on how to get possible values for VMware host config manager
2018-11-29 16:19:21 -06:00
Felix Fontein
3726d467ec Code style adjustment. (#49329) 2018-11-29 21:57:32 +01:00
martinwangjian
d1816d4908 grafana_datasource: Add CloudWatch as grafana datasource type (#48174) 2018-11-29 20:58:49 +01:00
Matt Martz
77befcf5d7
Do not allow addressing an import from handlers via notify. Fixes #48936 (#49317) 2018-11-29 13:50:07 -06:00
Dusan Matejka
a9aa1053a8 zabbix_template: fixed idempotency issues (#49188) 2018-11-29 20:38:32 +01:00