Commit graph

40260 commits

Author SHA1 Message Date
Deepak Agrawal
913b1b0194 Backport/2.7/49922: network_cli - ansible_command_timeout not working as expected (#50068)
* network_cli - ansible_command_timeout not working as expected (#49922)

* fix for command_timeout

Signed-off-by: Deepak Agrawal <deepacks@gmail.com>

* fix ci warning

Signed-off-by: Deepak Agrawal <deepacks@gmail.com>

* fix review comments

Signed-off-by: Deepak Agrawal <deepacks@gmail.com>

(cherry picked from commit 0f2f38b044)

* changelog entry for 2.7 backport

Signed-off-by: Deepak Agrawal <deepacks@gmail.com>
2019-01-07 10:07:02 -08:00
Nathaniel Case
bfa41db5f0 [2.7] Don't fail if a remote_addr with a '/' hits ansible_connection (#49781) (#50037)
* [2.7] Don't fail if a remote_addr with a '/' hits ansible_connection (#49781)

* Fail if a remote_addr with a '/' hist ansible_connection

This is _probably_ a CIDR block, but anything with a slash will fail,
so no need to try to parse to make sure

* Locks are now per-socket_path.

Locks use the same value as socket_path. Locks are also cleaned up in
shutdown like sockets.
(cherry picked from commit 61a649c)

Co-authored-by: Nathaniel Case <this.is@nathanielca.se>

* Add changelog
2019-01-07 09:32:55 -08:00
Felix Fontein
47228b8cf1 [2.7] certificate_complete_chain: fix stacktrace on parsing error (#49988)
* Fix stacktrace when fail_on_error is False and a file cannot be parsed. (#49987)


(cherry picked from commit 65d5f1a4ef)

* Add changelog.
2019-01-07 09:28:59 -08:00
Michael Rose
898ec291b0 Backport/2.7/49084 (#49973)
* influxdb_user: Fixed default password behavior (#47040)

(cherry picked from commit 1eed8900ed)

* Amends #47040 - influxdb_user - Prevents potential accidental password changes to blank (#49084)

* Amends #47040 - Prevents potential accidental password changes to blank

* Added changelog fragment

(cherry picked from commit b422c59ada)
2019-01-07 09:25:36 -08:00
Adam Miller
a9fd20318c add changelog for pr #49912 (#49962)
Signed-off-by: Adam Miller <admiller@redhat.com>
(cherry picked from commit 16f48bb4be)
2019-01-07 09:24:21 -08:00
Adam Miller
b710b40a0c Fix yum/dnf handling of URIs that don't end in .rpm (#49912)
Fixes #49727

Signed-off-by: Adam Miller <admiller@redhat.com>
(cherry picked from commit 0eabb8097b)
2019-01-07 09:24:21 -08:00
Dave Bendit
a11e0c184a Docker common consolidation (#49707)
* [docker] Consolidating Python Boolean conversion for Docker API (#49563)

* [docker] Consolidating docker option min version checks (#49564)

* [docker] Moving option min version checks out of docker_swarm (#49564)

Also renaming Boolean cleanup function and fixing docker_container minimum
version check for network interfaces.

* Cleanup from PR feedback
2019-01-07 09:20:34 -08:00
Dave Bendit
5a7f7f1183 [docker_container] Fixes idempotency checks for network_mode (#49797)
Fixes #49794
2019-01-07 09:20:34 -08:00
Alexander Bethke
f78a5f6332 Add changelog fragment for backported flatpak bugfixes 2019-01-07 09:19:48 -08:00
Alexander Bethke
afd626e0b3 Fix two regressions in flatpak and flatpak_remote modules (#49651)
* Fix python 3 compatibility in flatpak_remote module

* Fix flatpak module for recent versions of flatpak

* Add reminder for contributors to run integration tests manually

There has been several Python version compatibility regressions
introduced into the module which could have been avoided by the
integration tests.

(cherry picked from commit 27fd8e4dc6)
2019-01-07 09:19:48 -08:00
Sam Doran
17109ecedd [stable-2.7] Reboot - Fix command not found, add Apline support, fix Solaris command (#49272)
* Fix various bugs related in reboot

- Use format strings for consistency and improve debug log messages
- Use local variables instead of class attributes in order to be thread safe
- Run setup module to get distribution and version
- Run find module to get full path of shutdown command
- Use ansible_os_family and ansible_distribution to find commands and args
- Use same command for all Solaris/SunOS distributions
- Move delay calculations to properties
- Reliably check for module run failure
- Fix bug in run_test_command() that accidentally made the method work properly
- Use better exceptions rather than Exception
- Use dict literals rather than constructors
- Correct _check_delay() so it always returns a value, not None
- Don't store and return result in run_test_command() because it's not used anywhere
- add test for post reboot command that fails
- test negative values for delay parameters.
(cherry picked from commit c1589c33c4)

Co-authored-by: Sam Doran <sdoran@redhat.com>
2019-01-07 09:16:58 -08:00
Thomas Picariello
2f622fc336 Do not try to encode metadata if it is None (#46739)
* Do not try to encode metadata if it is None

* Add changelog fragment

* Fix fragment missing EOF line
2019-01-07 09:14:30 -08:00
Trishna Guha
cb173f7f1d nxos_logging message fix author:mikewiebe commit 374ca78
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2019-01-07 09:13:38 -08:00
Mike Wiebe
003a4556df Add explicit ansible_httpapi_port setting (#49314)
(cherry picked from commit 49009879b9)
2019-01-07 09:13:38 -08:00
Matt Clay
60843a8d7c [stable-2.7] Add env command to ansible-test and run in CI. (#50176)
* Add `env` command to ansible-test and run in CI.
* Avoid unnecessary docker pull.
(cherry picked from commit 01833b6fb1)

Co-authored-by: Matt Clay <matt@mystile.com>
2018-12-22 00:10:16 -08:00
Matt Clay
55889a9a60 [stable-2.7] Add retries for Invoke-ScriptAnalyzer in pslint.
Hopefully this will work around the intermittent CI failures due
to NullReferenceException, which then succeed on a retry.
(cherry picked from commit 4bd60c313b)

Co-authored-by: Matt Clay <matt@mystile.com>
2018-12-21 20:27:05 -08:00
Zim Kalinowski
6e93965528 [stable-2.7] merging postgresql server and database facts (#45061)
(cherry picked from commit d8cf645a8c)

Co-authored-by: Zim Kalinowski <zikalino@microsoft.com>
2018-12-21 11:31:23 -08:00
Zim Kalinowski
37af665d73 [stable-2.7] merge mysql server and database tests (#45060)
(cherry picked from commit 5c9241fa7c)

Co-authored-by: Zim Kalinowski <zikalino@microsoft.com>
2018-12-21 11:26:39 -08:00
Tom Dietrich
1bd3adf4f4 Warn of standard behavior of 'default' key store (#49903) (#50122)
* Warn of standard behavior of 'default' key store 
The default key store typically results in the key being stored as user. In instances where we're trying to install a cert to enable SSL binding in IIS, this will result in an unbind-able cert, as the IIS APPPOOL identity will not be able to read the private key, and presents a very cryptic error of 'A specified logon session does not exist'.
* specify what's required for successful iis import
- store_location's default value is currently 'LocalMachine' but if this changes it could result in the documentation being inaccurate
- key_exportable is not required for a successful IIS import
Co-Authored-By: tdietrich513 <tom.dietrich@gmail.com>
(cherry picked from commit 2b48c0187c)
2018-12-19 11:21:19 -06:00
Sandra McCann
85764a00c4 link to KB article -certified modules (#50050) (#50052)
(cherry picked from commit b873f34ea3)
2018-12-18 12:16:30 -06:00
Matt Clay
79d3c0eab3 [stable-2.7] Fix MySQL tests when running under Docker. (#50047)
(cherry picked from commit 0ccd231afd)

Co-authored-by: Matt Clay <matt@mystile.com>
2018-12-17 23:02:13 -08:00
Matt Clay
8c8301142e [stable-2.7] Add OverlayFS work-around for CloudStack tests.
(cherry picked from commit 61b5adcf31)

Co-authored-by: Matt Clay <matt@mystile.com>
2018-12-17 23:01:54 -08:00
Martin Krizek
feb971f649 docs: remove not implemented password_hash feature (#49945) (#50008)
(cherry picked from commit 79947245e2)
2018-12-17 08:58:47 -06:00
Jordan Borean
314e9c02f8 ansible-test: do not upgrade homebrew to speed up tests (#49914)
(cherry picked from commit 695feea541)
2018-12-13 19:07:08 -08:00
Toshio Kuratomi
de9647f260 Update Ansible release version to v2.7.5.post0. 2018-12-13 14:08:58 -08:00
Toshio Kuratomi
a771ed93ab New release v2.7.5 2018-12-13 09:26:14 -08:00
Matt Clay
fffd856e8a [stable-2.7] Disable failing ec2_vpc_vpn_facts test.
(cherry picked from commit df1c9d0f25)

Co-authored-by: Matt Clay <matt@mystile.com>
2018-12-10 14:32:41 -08:00
Matt Clay
c1bfe28a5a [stable-2.7] Fix template_jinja2_latest aliases file.
(cherry picked from commit a1a0893ebd)

Co-authored-by: Matt Clay <matt@mystile.com>
2018-12-10 12:47:17 -08:00
Toshio Kuratomi
012d38eae6
[stable-2.7] openstack: fix parameter handling when cloud provided as dict (#42899) (#49745)
* [stable-2.7] openstack: fix parameter handling when cloud provided as dict (#42899)

* openstack: fix parameter handling when cloud provided as dict

If a cloud is provided as dictionary:

 * Do not assert that 'interface' parameter is None. Instead,
   assert that it is 'public'.
 * Assert that 'auth_type' parameter is not set.

Fixes #42858

* os_user: Include domain parameter in user lookup

If a "domain" parameter is provided, use it in looking up
whether the user already exists.

Fixes #42901

* os_user: Include domain parameter in user deletion

If a "domain" parameter is provided, use it in deleting
the user also.

Fixes #42901
(cherry picked from commit e25dac9)

Co-authored-by: Carsten Koester <carsten@ckoester.net>

* Add changelog for openstack fixes
2018-12-10 12:33:34 -08:00
Sandra McCann
87e01a0640 added dhcp standard options (#49729)
(cherry picked from commit 418c03a686)
2018-12-10 11:51:45 -08:00
Felix Fontein
2566219fc8 [2.7] docker_swarm: fix minimal API version (#49709)
* docker_swarm: fix minimal API version (#49691)

* Reduce minimally required docker API version to 1.25, with selective features requiring 1.30.

* Adjust test requirements.

* Forgot some imports.

(cherry picked from commit 495a426039)

* Add changelog for docker swarm minimum api fix
2018-12-10 11:49:36 -08:00
Brian Coca
0954942dfd ensure ssh retry respects no log (#49569) (#49724)
* ensure ssh retry respects no log (#49569)


(cherry picked from commit ba4c2ebeac)
2018-12-10 11:49:16 -08:00
Dario Zanzico
961382bf5e docker_swarm_service: ensure idempotency when the user parameter is None (#49235)
* ensure idempotency for user set to None

* Update `user` documentation and add changelog fragment

* clarify changelog fragments and parameters documentation

* use restructuredtext syntax in changelog fragment

(cherry picked from commit b183eb4464)
2018-12-10 11:48:48 -08:00
Sandra McCann
291c9388ea added jinja2 example (#49740) 2018-12-10 11:40:21 -08:00
Abhijeet Kasurde
d28a903fb3 VMware: update docs and return docs for vmware_host_service_facts (#49736)
Follow up of 45155

(cherry picked from commit be21140384)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-12-10 11:13:26 -08:00
Brian Coca
35f349ae10 match interpreter on stdout also (#49446)
fixes #46980

(cherry picked from commit 758ac1846b)
2018-12-10 10:34:50 -08:00
Dag Wieers
5b349773b0 mail: Fix new breakage on python 2.7 (backport) (#49222)
* mail: Fix new breakage on python 2.7

* Add changelog fragment

* Add basic SMTP testing

* Add SMTP integration tests using starttls and TLS
2018-12-10 10:26:02 -08:00
Dag Wieers
2ba095f89e aci_rest: Fix ignoring custom port 2018-12-10 10:22:41 -08:00
Felix Fontein
db8f13c702 docker_*: hint at DOCKER_CONFIG environment variable (#49689)
* Hint at DOCKER_CONFIG environment variable directly supported by docker-py.

* Adjust wording.

(cherry picked from commit 270b6a2ee2)
2018-12-10 10:20:39 -08:00
Andrey Che
5b54472cfd fix synchronize handling of encrypted hosts on delegation (#49460)
* Fix for #49363

* Replaced str() with to_text() as more python version safe

* Changed to comply to errors stragegy

(cherry picked from commit 64636d9de0)
2018-12-10 10:18:30 -08:00
Yuwei Zhou
0dda61c258 Fix if the route table changed to none (#49533) (#49703)
* Fix if the route table changed to none (#49533)

(cherry picked from commit 5a59748e6c)

* add changelog
2018-12-10 10:17:42 -08:00
lrrb
06ffe7b5d8 fix: Make sure that the files excluded when extracting the archive are not checked (#45122) (#49700)
*  fix: ensure than all item of a list of excluded files aren't checked  (#45122)

* fix: ensure than list of excluded files aren't checked
* test: exclude a list of files

(cherry picked from commit 4f9f1754b4)

* added changelog
2018-12-10 10:15:22 -08:00
Jordan Borean
5e0c292682 win_hotfix: use S3 bucket for update files in test (#49696)
(cherry picked from commit 478fcf7abb)
2018-12-10 10:13:51 -08:00
Jordan Borean
3343be2c56 remove continue on error now that tests are good 2018-12-10 10:11:18 -08:00
Jordan Borean
2eb44f4043 test make sure everything passes 2018-12-10 10:11:18 -08:00
Jordan Borean
75f249ee98 ansible-test - swap Fedora 25 for 29 (#49634)
(cherry picked from commit 6a09db5131)
2018-12-10 10:11:18 -08:00
Jordan Borean
9d19fde3e9 ansible-test: change Fedora 24 to 28 (#49586)
(cherry picked from commit 5392caee14)
2018-12-10 10:11:18 -08:00
Jordan Borean
46fc6caf52 pip tests: skip distribute test case for py3 compat (#49636)
(cherry picked from commit 28a903a1e2)
2018-12-07 07:10:03 -08:00
Tim Burke
c7677eee83 Fix ReST formatting for Galaxy docs link (#49575)
(cherry picked from commit 6e43f9fe8f)
2018-12-06 11:00:57 -08:00
Toshio Kuratomi
ad45bd72c1 Fix for a caching traceback
When the user specified caching plugin doesn't initialize correctly, we
were falling back to a dict.  however, dicts do not have the same
update() method as the FactCache.  We use the update method when we
update a cache with a subsequent value.  So when that combination of
things happened, the code would traceback.

In devel, we made this change to fix things: https://github.com/ansible/ansible/pull/49516
but that involves several deprecations.  So we're doing this smaller
hack in 2.7 to fix the traceback without introducing those deprecations
in a stable release.
2018-12-06 10:59:32 -08:00