Commit graph

8325 commits

Author SHA1 Message Date
Jesse Keating
8cef210aea Make sure ssh pipes are empty before moving on
Resolves issue #5082

Code as it was would hit a scenario where one of the FDs was not ready for
reading the first time through -- but p.poll() would show the process as
complete. This would cause ansible to continue on, while leaving some content
left in a pipe.

The other scenario -- the one that causes the unclosed quote, is if we go
through select.select() and we do get stdout in the ready for reading -- we
read from it (9000 bytes), but that's not all that is there. Again we'd get to
the p.poll() check and it would be indeed not none, but we would have left some
of stdout on the FD and thus the json blob would be malformed.

Tested with and without full ssh debugging.
Tested with and without ControlPersist
Tested with and without ControlPersist sockets already created
2013-12-11 21:32:37 -08:00
Michael DeHaan
929f8a5c93 Had to revert commits due to async. 2013-12-10 19:24:08 -05:00
Michael DeHaan
74e4ccb59b Revert "ssh_alt.py / decrease # of ssh roundtrips"
This reverts commit 7f8863f96d.
2013-12-10 19:23:52 -05:00
Michael DeHaan
f72bb8c7a8 Merge branch 'ansible_ssh_alt' of git://github.com/jeromew/ansible into devel 2013-12-10 18:39:40 -05:00
Michael DeHaan
62b89c7cc3 Merge pull request #5243 from mivor/devel
Fix typo for ANSIBLE_FORCE_COLOR in Changelog
2013-12-10 15:34:36 -08:00
Ferenc Grecu
0c343ad58e Update CHANGELOG.md
Fix typo in ANSIBLE_FORCE_COLOR
2013-12-10 23:40:11 +02:00
jctanner
c04b21dc9a Merge pull request #5232 from jsdalton/fix_elb_instance_state_issue
Account for instances that have not yet been registered. Fixes #5076
2013-12-10 10:02:29 -08:00
Will Thames
e9a0aff77c Fail EC2 inventory better with restricted EC2 users
If a user has full EC2 access but no RDS access, the user
should still be able to query the EC2 inventory, although
will not obtain any information about any RDS instances.
2013-12-10 21:32:54 +10:00
jeromew
7f8863f96d ssh_alt.py / decrease # of ssh roundtrips 2013-12-10 06:00:21 -05:00
Jim Dalton
ac1e84d976 Account for instances that have not yet been registered. Fixes #5076 2013-12-09 19:38:03 -08:00
Michael DeHaan
5cd97e8cf6 Merge pull request #5222 from resmo/fix/apt-update
apt: update index before trying to autoinstall python-apt
2013-12-09 18:32:25 -08:00
Jeffrey Nappi
2b82f7d75f Corrected documentation in ec2_ami module - no_reboot defaults to yes 2013-12-09 18:57:58 -07:00
jeromew
db182ba498 copy ssh.py to ssh_alt.py 2013-12-09 14:11:29 -05:00
Matthew Thode
c0a7f51671 tests depend on the default encoding being utf8
So we set the utils default encoding to be utf8
2013-12-09 12:49:03 -06:00
jctanner
19d4c1aca8 Merge pull request #5215 from dhml/devel
Fix issue #5214: hostname persistence on RedHat/CentOS
2013-12-09 06:51:52 -08:00
Rene Moser
2d805ae5da apt: update index before trying to autoinstall python-apt 2013-12-09 10:21:27 +01:00
Tim Gerla
1063cbea39 tweak some links and phrasing 2013-12-08 19:40:21 -08:00
Michael DeHaan
0078b6b2a9 Merge pull request #5217 from mmoya/docfix
Fix link to playbooks loops
2013-12-08 14:04:13 -08:00
Tim Gerla
101e8c0a31 flesh out the CI/CD and load balancer sections a bit 2013-12-08 13:19:09 -08:00
Maykel Moya
9018d53a3c Fix link to playbooks loops 2013-12-08 22:09:54 +01:00
Tim Gerla
4da5d267d5 initial commit of a basic rolling upgrade guide, based on the lamp_haproxy example 2013-12-08 12:56:57 -08:00
Dimos Alevizos
8c73aa13e4 Minor changes to simplify code 2013-12-08 09:02:50 +02:00
David Hummel
cc3678730c Fix issue #5214: hostname persistence on RedHat/CentOS 2013-12-07 21:10:42 -05:00
Dimos Alevizos
de4e4c54b9 Add get_dmi_facts in setup for FreeBSD systems using dmidecode 2013-12-07 17:16:20 +02:00
Michael DeHaan
fa8a02dcda Merge pull request #5212 from tarka/devel
Cast the retrieved `retries` var to an int before incrementing as it may...
2013-12-07 04:51:19 -08:00
Steve Smith
5b81f88c8f Cast the retrieved retries var to an int before incrementing as it may be in string form.
For example, the following method of calculating the value will result in a type error:

    appstatus_waitfor: 4  # Minutes
    appstatus_delay: 5 # seconds
    appstatus_retries: "{{ mins * 60 / delay }}"
2013-12-07 10:35:14 +01:00
Matt Martz
ead733362f module is not exposed to send_msg, but main() catches exceptions and uses module.fail_json 2013-12-06 11:42:30 -06:00
Matt Martz
b48b22b24a Try to follow RFC2812 for waiting on serverl welcome and join messages before performing more tasks 2013-12-06 11:42:30 -06:00
Wanderlei Antonio Cavassin
6ba93817a9 Avoid UnicodeDecodeError exception when passing module args 2013-12-06 12:59:43 -02:00
jctanner
36a305ce9d Merge pull request #5195 from Multifarious/devel
Fix loading from cache in ec2.py inventory plugin.
2013-12-06 06:53:01 -08:00
Lorrin Nelson
663deff2c2 Fix loading from cache in ec2.py inventory plugin. 2013-12-05 21:33:25 -08:00
Michael DeHaan
a19ef93cf3 Update README.md
remove author section, references old email address
2013-12-05 19:22:05 -05:00
Michael DeHaan
0fc5771eab Update README.md
Clarify docs readme about wordpress
2013-12-05 19:17:02 -05:00
jctanner
66cf819a68 Merge pull request #5192 from jeromew/ansible_user_removal
user module: force= and remove= should not be mutually exclusive
2013-12-05 14:21:28 -08:00
jeromew
1916e8ec90 user module: force= and remove= should not be mutually exclusive 2013-12-05 17:07:24 -05:00
jctanner
364ad44db3 Merge pull request #5188 from Multifarious/devel
ec2 inventory now include Ansible 1.3 style _meta data each host.
2013-12-05 13:58:50 -08:00
jctanner
5e336d7caf Merge pull request #5075 from gservat/patch-1
Added support for parsing in the SLES patch level correctly
2013-12-05 13:34:57 -08:00
gservat
db2f41bdcb This change is meant to replace distribution_release, not version! 2013-12-06 07:53:39 +11:00
gservat
83f35a63dd Oops... fixed an error 2013-12-06 07:49:03 +11:00
Lorrin Nelson
94d60b53de ec2 inventory now include Ansible 1.3 style _meta data each host. 2013-12-05 11:40:18 -08:00
jctanner
6b45c4a6ca Merge pull request #5181 from mvo5/bugfix/apt-fnmatch-remove
add fnmatch() support for apt remove too (just like install)
2013-12-05 09:18:04 -08:00
jctanner
54a43d8cea Merge pull request #5174 from jinnko/devel
Add documentation for usage of encrypted postgresql passwords.
2013-12-05 09:07:57 -08:00
jctanner
9dec25854e Merge pull request #5182 from mscherer/fix_5177
Fix apt module to be able to install package by giving just a provides a...
2013-12-05 09:01:59 -08:00
Jinn Koriech
80d6ca19af Add README info for building the module documentation. 2013-12-05 17:01:49 +00:00
Jinn Koriech
6f2843724d Fix postgresql_user documentation render 2013-12-05 16:57:56 +00:00
Michael Scherer
3df62f1d8a Fix apt module to be able to install package by giving just a provides and not the full name
The apt module check if a packag eis valid by loking in the cache, checking only for
full name, while it should also check that the name is not just provided.
Fix https://github.com/ansible/ansible/issues/5177
2013-12-05 17:56:54 +01:00
Michael Vogt
559de5c65e add fnmatch() support for apt remove too (just like install) 2013-12-05 17:54:43 +01:00
jctanner
85d8587cc0 Merge pull request #5173 from zitterbacke/devel
basic AIX network facts
2013-12-05 08:40:48 -08:00
James Tanner
bf78d8cf73 Addresses #5090 setup module was using path.is_file instead of path.isfile 2013-12-05 11:36:54 -05:00
jctanner
01388d1d21 Merge pull request #5179 from dhml/devel
Fix issue #5043: ec2_vpc module wait=yes state attribute retrieval
2013-12-05 07:55:10 -08:00