Michael DeHaan
1e5d5fc263
Be consistent about underscore usage.
2013-02-28 15:57:27 -05:00
Ton Kersten
7b51f67128
Squashed commit of the following:
...
commit 076501459322cf6c14de742e504339d80ffdeed5
Author: Ton Kersten <tonk@tonkersten.com>
Date: Thu Feb 28 21:32:57 2013 +0100
Added date and time facts to setup
2013-02-28 21:33:56 +01:00
Yves Dorfsman
7cedb7d432
Doc that fetch returns ok when src not present.
2013-02-28 13:24:24 -07:00
Mark Theunissen
34bed2fa2e
Fix bug from copy-paste
2013-02-28 13:55:22 -06:00
Remy van Elst
f094d65fdd
apt update
2013-02-28 20:50:07 +01:00
Remy van Elst
5289fa72b6
apt upgrade support
2013-02-28 20:47:31 +01:00
Mark Theunissen
45949c7643
Add mysql user documentation
2013-02-28 10:25:09 -06:00
Ton Kersten
05c70ca712
Squashed commit of the following:
...
commit e057ea671395ec8847f920a63cf9524f5c8fde5f
Author: Ton Kersten <tonk@tonkersten.com>
Date: Thu Feb 28 13:02:25 2013 +0100
Fixed the service command not working
On Ubuntu 1[02].04 the service name was not recognized because
there is a SysV style init script, but not an upstart config file.
Example: The `ntp` client.
Also removed extra spaces at the end of the lines, while at it.
2013-02-28 13:06:50 +01:00
Nigel Metheringham
e2643cb55f
Broke BSD ifconfig parser into chunks for subclassing
...
This allows minor changes to be handled by adding a new
parse line function to the subclass
2013-02-28 09:58:29 +00:00
Nigel Metheringham
acc1c004d4
Restructured inheritance of BSD network classes
...
Now all BSD network classes directly inherit from Network as well as from the generic BSD network class. This removes the need for itersubclasses().
2013-02-28 09:07:54 +00:00
Patrick Pelletier
2778ee0eb5
Adding support for OpenWrt
2013-02-27 22:16:12 -05:00
Stephen Fromm
8f0d8a8546
Update various modules for check_mode
...
This updates the following modules to support check_mode:
* apt_key
* apt_repository
* easy_install
* pip - will always report changed due to the way it handles state
* seboolean
* selinux
* slurp - since nothing changes, it just adds that it supports
check_mode
* subversion - reports changed when checking out new repo and
when updating.
* supervisorctl
* svr4pkg
See issue #2114 .
2013-02-27 12:23:35 -08:00
Daniel Hokka Zakrisson
1fe744d2af
Fix apt module's boolean check to expect converted value
...
Fixes #2218 .
2013-02-27 20:02:34 +01:00
Michael DeHaan
0342b054fd
Merge pull request #2215 from tastychutney/devel
...
Updated virtualenv note
2013-02-27 08:42:53 -08:00
Scott Anderson
dc476a12a6
Updated virtualenv note
2013-02-27 10:01:12 -05:00
Michael DeHaan
0fc317de08
Merge pull request #2212 from jhoekx/lvol-module
...
Add lvol module to manage logical volumes.
2013-02-27 05:52:23 -08:00
Daniel Hokka Zakrisson
e33e84d24e
Merge pull request #2213 from huberteff/devel
...
Work around hanging module. Thanks to Daniel Hozac for the tip.
2013-02-27 04:30:39 -08:00
Hubert Feyrer
acf8ee9d61
Work around hanging module. Thanks to Daniel Hozac for the tip.
2013-02-27 13:26:12 +01:00
Jeroen Hoekx
01a9d79e11
Add lvol module to manage logical volumes.
2013-02-27 11:27:26 +01:00
Michael DeHaan
b1a4fab7e1
Merge pull request #2208 from tastychutney/devel
...
Better documentation, removed runfcgi, added createcachetable
2013-02-26 19:26:39 -08:00
Scott Anderson
36eeb7562a
Better documentation, removed runfcgi, added createcachetable, merge with Michael's changes
2013-02-26 22:11:30 -05:00
Michael DeHaan
7dbfad8225
baby-JSON not supported, let selinux module warn using regular JSON
2013-02-26 21:57:47 -05:00
Michael DeHaan
d251e68ac5
Resolve merge
2013-02-26 20:57:36 -05:00
Michael DeHaan
1366c663eb
Merge branch 'copy-diff-take2' of git://github.com/stoned/ansible into better_diff
...
Conflicts:
library/file
2013-02-26 20:51:32 -05:00
Michael DeHaan
9e2cb42b4f
Add some aliases for django manage, mainly around underscores, and use the newer (easier) way to do module docs. Also
...
add list of avail commands to docs.
2013-02-26 20:45:44 -05:00
Scott Anderson
06890085d2
Django manage.py administration module
2013-02-26 20:45:44 -05:00
Michael DeHaan
7090ad3aac
Merge pull request #2195 from tbielawa/NOOP
...
First try and making the nagios module NOOPpable
2013-02-26 17:32:41 -08:00
Michael DeHaan
c485cb3700
Remove some tab/space issues in previous commits.
2013-02-26 20:30:33 -05:00
Michael DeHaan
6a487409db
Merge branch 'postgresql-check-mode' of git://github.com/cocoy/ansible into devel
2013-02-26 20:28:04 -05:00
Michael DeHaan
0e1ba5e676
Prevent SVN checkouts from failing due self signed certs.
2013-02-26 20:23:12 -05:00
Michael DeHaan
9f083bfca3
Merge pull request #2207 from marktheunissen/mysql-pass-and-password
...
Adding back support for pass=
2013-02-26 16:12:09 -08:00
Mark Theunissen
234d31bf72
Adding back support for pass=
2013-02-26 16:27:23 -06:00
Daniel Hokka Zakrisson
93f02d614b
Merge pull request #2187 from dhozac/argument-type-check
...
Add type checking for module arguments, converting as much as possible
2013-02-26 14:05:36 -08:00
Tim Bielawa
b0bd0a0f4a
Making the nagios module NOOPpable
2013-02-26 12:28:01 -05:00
Stoned Elipot
10e9f1fc1e
Implement --diff for the copy module.
2013-02-25 23:32:52 +01:00
Seth Vidal
f02ea15f0c
command: make sure that all _handle_aliases() calls returns {}
...
module_common: also work if there are no aliases (shell, command, etc) modules
2013-02-25 17:07:47 -05:00
Seth Vidal
b54887b03c
make sure ec2_secret_key is set to no_log=True
2013-02-25 16:34:06 -05:00
Michael DeHaan
3c40ce5700
Better detection of whether a service is managed by systemd or not.
2013-02-24 11:58:05 -05:00
Michael DeHaan
596c98320a
Service module now knows a little more about systemd. This module is
...
really due for some refactoring, but telling how a service is managed is
a little fuzzy anyway. on a systemd system typoing the service will now
give you a rather systemd specific error which is somewhat suboptimal.
2013-02-24 11:50:39 -05:00
Michael DeHaan
4be3b06842
Run chkconfig enable/disable only when needed. TODO, apply same logic to update-rc.d/systemd
2013-02-24 10:33:40 -05:00
Rodney Quillo
3bf088c084
Fix tabs/spaces.
2013-02-24 15:10:57 +08:00
Michael DeHaan
0380ba7177
If running is given as the state value instead of 'started', still return the correct end state.
2013-02-23 22:28:57 -05:00
Michael DeHaan
624a952c5c
The service module made some assumptions about how a service should be managed based on what was installed on the system in terms of service
...
management tools, which meant upstart services on CentOS6 were not startable. This tweak allows things like vmware-tools to be controlled
via the service module. More testing on other distributions (particularly with systemd) is presumably needed.
2013-02-23 20:31:29 -05:00
Daniel Hokka Zakrisson
578ec127fb
Remove choices=BOOLEANS as it is no longer needed
2013-02-23 22:57:36 +01:00
Michael DeHaan
582f088e7e
Fix module docs formatting
2013-02-23 15:11:15 -05:00
Michael DeHaan
c86b34dae1
Lots of docsite additions for new features + cleanup lineinfile YAML docs
2013-02-23 15:08:33 -05:00
Daniel Hokka Zakrisson
df798d0688
Use argument type checking to convert to boolean
2013-02-23 19:59:52 +01:00
Michael DeHaan
b75b9681a8
more places to use yaml.safe_load
2013-02-23 13:34:14 -05:00
Michael DeHaan
69a199727c
Merge pull request #2180 from jsmartin/cloudformation
...
CloudFormation support.
2013-02-23 09:57:09 -08:00
Michael DeHaan
878eb5a9b1
Merge pull request #2185 from lwade/devel
...
Issue #2158 - add VPC subnet ID support
2013-02-23 09:53:26 -08:00
Michael DeHaan
ac41a9d1f0
Merge pull request #2175 from tyll/devel
...
mysql_db/user: Use password for my.cnf
2013-02-23 09:52:14 -08:00
Michael DeHaan
8b3ebf0d10
mark when various new flags were added to the pip & easy_install modules
2013-02-23 12:51:23 -05:00
Michael DeHaan
9b32ab7ec2
Merge pull request #2150 from jhoekx/venv-command
...
Venv command
2013-02-23 09:50:10 -08:00
lwade
0486c7d51a
missed a spot.
2013-02-23 17:46:35 +00:00
lwade
30ac2edc33
Adding VPC subnet ID support
2013-02-23 17:45:47 +00:00
Michael DeHaan
b739a5860a
Merge branch 'lineinfile_improvements' of git://github.com/leucos/ansible into devel
...
Conflicts:
library/lineinfile
2013-02-23 12:45:36 -05:00
Michael DeHaan
e1f1722e9e
Docs tweak to setup module.
2013-02-23 12:36:01 -05:00
Michael DeHaan
275bd1f400
Merge branch 'setup_filter_argument' of git://github.com/leucos/ansible into devel
2013-02-23 12:33:00 -05:00
Michael DeHaan
9cea292665
Clean up OS family code
2013-02-23 12:32:51 -05:00
Ton Kersten
cf23d64a88
Conflicts:
...
library/setup
2013-02-23 12:32:51 -05:00
Ton Kersten
4d67608a10
Squashed commit of the following:
...
commit 1c9b2a6035913969b515862e37e7e1aca24529e0
Author: Ton Kersten <tonk@master.tonkersten.com>
Date: Tue Feb 19 15:54:36 2013 +0100
Added osfamily fact
2013-02-23 12:32:51 -05:00
Michael DeHaan
7b2c8b302f
Merge pull request #2146 from dagwieers/thirsty-force
...
Add force= and make thirsty= an alias for backward compatibility
2013-02-23 09:15:25 -08:00
Michael DeHaan
467556708a
Merge pull request #2145 from leucos/sysctl_no_file_check
...
Better sysctl module file check
2013-02-23 09:14:45 -08:00
Daniel Hokka Zakrisson
274f15b52c
Fix version_added for insertbefore in lineinfile
2013-02-23 18:11:10 +01:00
Michael DeHaan
333b6bbaac
Show how to use the more simplified way of including EXAMPLES in docs. We should update
...
all module docs to do this.
2013-02-23 12:03:33 -05:00
Michael DeHaan
5a1aef5372
Merge branch 'local-chroot-support-v2' of git://github.com/mmoya/ansible into testing
2013-02-23 11:51:11 -05:00
James Martin
fa63a9b5f4
CloudFormation support.
2013-02-22 15:52:23 -05:00
Michel Blanc
92c679142f
Optimizes using fnmatch only if needed
...
Skips fnmatch'ing if there is only a '*' in filter.
2013-02-22 17:41:18 +01:00
Michel Blanc
633fdede38
Fixes duplicate code
...
Fixed duplicate call for file attributes checking
2013-02-22 17:30:19 +01:00
Johan Wirén
ee517ea53c
Added support for --check in zfs module
2013-02-22 15:01:18 +01:00
Till Maas
cc8fbe34f2
mysql_user: handle unnecessary GRANT revocation
2013-02-22 14:42:41 +01:00
Till Maas
813d2335ad
mysql_db/user: Use password for my.cnf
...
According to the MySQL docs[0] the password should be stored after
'password=' instead of 'pass='.
[0] http://dev.mysql.com/doc/refman/5.1/en/password-security-user.html
2013-02-22 13:25:34 +01:00
Michel Blanc
008dc4831e
Improves lineinfile and adds file attr option
...
Added path expanding for dest in lineinfile
Added common file arguments to lineinfile so the module gets owner,
group, mode and SE options.
Decorated existing example to demonstate usage of file options and added
a couple more examples
Message is not set accordingly when file attributes were changed
'absent' handling code now handles the case where the file doesn't
exists (was issuing a Traceback before)
File attribute handling code has been added to the 'absent' handling
function too.
File attributes handling has been grouped in 'def check_file' since it's
required in both places.
'absent' mode now returns a message like it's counterpart 'present',
telling if file attributes were altered and if lines have matched.
2013-02-22 09:33:21 +01:00
Daniel Hokka Zakrisson
c364e4c77b
cron: Work even without initial crontab
...
Fixes #2165 .
2013-02-21 21:14:29 +01:00
Michel Blanc
7c270078f4
Moved key filtering
...
Key filtering moved before returning results
2013-02-21 01:10:25 +01:00
Maykel Moya
5e68143c46
Check presence of files under /proc before opening them
2013-02-20 20:52:45 +01:00
Maykel Moya
8b27085c34
Prevent traceback when /etc/mtab is not available
...
* get_file_contents returns None when file is not available.
When /etc/mtab is pointing to /proc/mounts and /proc is not
mounted, mtab.split will traceback.
2013-02-20 20:52:45 +01:00
Michel Blanc
627577ecc9
Fixes unused var and avoid reassigning keys
...
Changed code so key doesn't get reassigned in loop
Made use of filtr variable
2013-02-20 19:12:01 +01:00
Michel Blanc
139e06d9af
Added more examples for the filter option in setup
...
Added examples covering all available globs
Added a use case of filtering only facts returned by facter
2013-02-20 18:13:05 +01:00
Michel Blanc
5f4a24557b
Adds example for filter option in setup module
...
Added an example on how to filter keys returned by the module.
2013-02-20 17:57:59 +01:00
Michel Blanc
75b687247a
Adds filter option to setup module
...
Adds facts filtering using fnmatch, via the 'filter' option.
Usage:
ansible -m setup -a 'filter=ansible_*_mb'
2013-02-20 17:53:14 +01:00
Michael DeHaan
a875b63703
Merge pull request #2152 from dagwieers/pause-doc
...
pause: Fix small documentation glitch
2013-02-20 07:20:59 -08:00
Dag Wieers
486889bbbd
Add force= and make thirsty= an alias for backward compatibility
2013-02-20 15:42:55 +01:00
Dag Wieers
577f491368
pause: Fix small documentation glitch
2013-02-20 15:17:49 +01:00
Rodney Quillo
621eb5eccc
Add postgresql_db and postgresql_use checkmode.
2013-02-20 22:12:25 +08:00
Michael DeHaan
7a7d02073a
Merge pull request #2119 from jpmens/uri_json
...
uri: load JSON for content-type: application/json
2013-02-20 05:59:38 -08:00
Jeroen Hoekx
9f65233e96
Easy_install and pip module support a virtualenv_command parameter.
...
This allows flexible selection of the Python version to use while
creating the virtualenv.
2013-02-20 14:52:02 +01:00
Jan-Piet Mens
b448cc8eff
uri: load JSON for content-type: application/json
...
document
check prefix of content-type and merge dicts
amend doc
load JSON into 'json' subkey
2013-02-20 14:45:47 +01:00
Jeroen Hoekx
01e66c6687
Add virtualenv_site_packages param to easy_install
2013-02-20 14:44:27 +01:00
Michael DeHaan
7834d021b9
Merge pull request #2138 from bcoca/2137_fix_setup_bsdjails
...
fixes freebsd setup issues with jails
2013-02-20 05:29:45 -08:00
Michael DeHaan
ae599d8a61
Merge pull request #2115 from kavink/devel
...
teach apt module to support --check mode
2013-02-20 05:28:21 -08:00
Michel Blanc
e0496634c5
Removes useless empty string write
...
It s not necessary to write an empty string for the file to be created.
2013-02-20 14:20:27 +01:00
Michel Blanc
6f9d28c8b1
Changed when new sysctl file is created
...
When destination sysctl file is missing, it is created.
But, for idempotency purposes, the creation process now takes place just before it is used, in the
main code path so an empty file is not left over if the code
module.fail_jsons before the file is really used.
2013-02-20 12:52:30 +01:00
Michel Blanc
0eaa936ba0
Removes exception is sysctl file is missing
...
When syscl file was missing, sysctl module was complaining about it and
bailing out.
This behaviour prevents usage of /etc/sysctl.d directory, present in
some distributions.
This patch accepts a missing sysctl.conf file so sysctl.d directory can
be used.
However, it will bail out if the destination directory doesn't exist.
2013-02-20 12:42:49 +01:00
lwade
107733b174
Add support for security group id parameter, remove default for group name (since AWS already sets a default). ISSUE #2029
2013-02-20 09:31:22 +00:00
Brian Coca
aa713d72ef
fixes freebsd setup issues with jails
...
Signed-off-by: Brian Coca <bcoca@tablethotels.com>
2013-02-19 18:36:25 -05:00
Kavin Kankeshwar
0f166d870a
teach lineinfile module to support --check mode
2013-02-19 14:18:52 -08:00
Kavin Kankeshwar
53924b4599
teach apt module to support --check mode
2013-02-19 14:18:52 -08:00
Daniel Hokka Zakrisson
3f2fd22ed4
Don't consider packages missing from the cache an error on remove
...
Fixes #2017 .
2013-02-19 23:18:17 +01:00
Daniel Hokka Zakrisson
d2bf205a5d
Fix #2125 and clean up a few things along the way
2013-02-19 22:26:38 +01:00
lessmian
a124a7f6a1
sysctl module: fixed issue when checks_after fail on comparing keys with values separated by white strings
2013-02-19 15:45:08 +01:00
lessmian
e8254dee4d
mail module: properly set charset
2013-02-19 11:33:38 +01:00
Lorin Hochstein
eac339e98a
Add documentation about PUBLIC user
2013-02-18 22:59:51 -05:00
Lorin Hochstein
4a90e2b50a
postgresql_user: Add support for PUBLIC
...
This change enables users to add and remove permissions to all roles,
using the PUBLIC user. This is equivalent to using the PUBLIC keyword
in GRANT and DENY postgres SQL commands.
For example, see: <http://www.postgresql.org/docs/current/interactive/sql-grant.html >
Fixes #1833
2013-02-18 21:33:36 -05:00
Romeo Theriault
1c91917ed5
uri doc fixes
2013-02-18 13:03:19 -10:00
lessmian
8a49dac5d1
Fixed remove_key
2013-02-18 17:03:50 +01:00
Michael DeHaan
093935ede1
Merge pull request #2116 from lwade/devel
...
Correct ec2_vol doc errors
2013-02-18 04:52:24 -08:00
Daniel Hokka Zakrisson
4a137641d2
check_mode is a module property
2013-02-18 13:23:45 +01:00
lwade
3b9cf8270f
Correct ec2_vol doc errors
2013-02-18 10:14:09 +00:00
Michael DeHaan
ab389d8908
For consistency, add host should take a key named 'name' in addition to 'hostname'.
2013-02-17 20:45:37 -05:00
Michael DeHaan
cc9bc91a6c
Fix typo in zfs module docs
2013-02-17 20:01:15 -05:00
Michael DeHaan
8097fd18a2
'make pep8' is now clean
2013-02-17 19:48:02 -05:00
Johan Wirén
acc58a37df
Set version_added to 1.1
2013-02-18 01:29:51 +01:00
Johan Wirén
5ae5fe83ac
zfs module no longer destroys the layout in webdocs
2013-02-18 01:25:44 +01:00
Michael DeHaan
18cbb64f25
Teach the yum module to support --check mode.
2013-02-17 18:18:43 -05:00
Michael DeHaan
4f249902b3
Taught service how to use --check mode
2013-02-17 17:45:44 -05:00
Michael DeHaan
ad89ab7c5d
Add group support to check mode.
2013-02-17 17:33:42 -05:00
Michael DeHaan
fdbbb171ba
Teach the user module to understand check mode.
2013-02-17 17:33:42 -05:00
Michael DeHaan
b63bf62b13
Remove debug print message
2013-02-17 15:03:30 -05:00
Michael DeHaan
1ecf4a6943
Working on complex argument support.
2013-02-17 15:01:49 -05:00
Michael DeHaan
5a91873983
resolve merge conflict
2013-02-17 13:13:20 -05:00
Daniel Hokka Zakrisson
6ffc8a1441
Recurse was added in 1.1
2013-02-17 18:48:17 +01:00
Michael DeHaan
931b9f41c8
Make note about enablement bit
2013-02-17 12:13:26 -05:00
Michael DeHaan
934f416387
Avoid the 'state=null' coming back from the service module.
2013-02-17 12:11:53 -05:00
Michael DeHaan
e43abe326f
Added a tunneling example
2013-02-17 11:25:42 -05:00
Michael DeHaan
b365e04616
Allow add_host to add hosts to multiple groups, groups is now an alias for groupname.
2013-02-17 11:22:50 -05:00
Rob Parrott
ef17fc9f20
add the ability to take variables in the add_host module, and be willing to parse a host:port hostname handed to add_host
2013-02-16 20:27:38 -05:00
Michael DeHaan
c000bd846b
Hate to do this, but URI module docs were constructing messed up RST files, so removing examples for now. Will ask someone to work on them.
2013-02-16 18:45:59 -05:00
Michael DeHaan
5f829f9926
Add versionadded element to new option, fix YAML formatting
2013-02-16 15:40:31 -05:00
Michael DeHaan
369d586651
Merge pull request #2086 from lwade/devel
...
Adding a simple EC2 volume module for creation and attach
2013-02-16 10:38:52 -08:00
Michael DeHaan
cb3d26c500
Merge pull request #2084 from johanwiren/zfs
...
Added zfs module
2013-02-16 10:37:58 -08:00
Michael DeHaan
a01525bd30
Merge branch 'aix-fixes' of git://github.com/dagwieers/ansible into devel
...
Conflicts:
library/setup
Tweak formatting.
2013-02-16 13:35:37 -05:00
Michael DeHaan
df63f60b63
Tweak doc examples
2013-02-16 13:32:49 -05:00
Romeo Theriault
1232e498c4
fixed the documentation so it build properly
2013-02-16 13:32:48 -05:00
Romeo Theriault
2ecf3f9b94
moved module checking below module initialization
2013-02-16 13:32:48 -05:00
Romeo Theriault
27145fab7f
uri module
2013-02-16 13:32:48 -05:00
James Martin
7129a9e355
Using "OtherLinux" in module_commons, cleander detection in setup.
2013-02-16 13:32:48 -05:00
James Martin
5646bc278b
Support for amazon linux distribution facts.
2013-02-16 13:32:48 -05:00
Yves Dorfsman
83ce1b2dc5
Modified to follow Daniel Hokka Zakrisson's recommendations.
2013-02-16 13:32:48 -05:00
Yves Dorfsman
4de1b4e8a9
Added an insertbefore option.
2013-02-16 13:32:48 -05:00
Blair Zajac
fa8e653011
Simplify and correct comparisons with None.
2013-02-16 13:32:48 -05:00
Michael DeHaan
2172201795
Merge pull request #2091 from davixx/sysctl2004
...
Solving bug : sysctl check_after failing on multi-value sysctl parameters
2013-02-16 10:19:16 -08:00
Michael DeHaan
21693b2d22
Merge pull request #2079 from huberteff/devel
...
Add NetBSD support for 'service' module, and add an example to 'lineinfile'
2013-02-16 10:08:25 -08:00
Michael DeHaan
7827db6996
Merge pull request #2078 from huberteff/e2158b661d250c04609e7faff4d8e67df9cb37e4
...
Add example for adding to sudoers file
2013-02-16 10:05:08 -08:00
Michael DeHaan
85c87e507e
Slight docs tweak about thirsty mode on the copy module
2013-02-16 12:36:16 -05:00
Michael DeHaan
b5f90ef054
Merge branch 'thirsty_copy' of git://github.com/bcoca/ansible into testing
2013-02-16 12:35:16 -05:00
Michael DeHaan
11c730c4ca
Merge branch 'devel' of git://github.com/trendels/ansible into testing
2013-02-16 12:32:18 -05:00
Johan Wirén
75b52d745e
Updated documentation. Works with ansible-doc
2013-02-16 15:11:07 +01:00
davixx
8bf0c8dc5c
Solving bug https://github.com/ansible/ansible/issues/2004
...
Now handle positive integer value in virtual files if they are separated
by group of space characters where the count is unpredictable.
Thanks to romeotheriault for filing this bug.
2013-02-15 19:14:01 +01:00
Peter Sankauskas
6fd0316fa6
The default for install-recommends is actually Yes, not No, as is
...
visible on line 121
2013-02-14 15:27:20 -08:00