Lucas Costa Beyeler
5559e6a669
Fix #4202 : Can't unarchive remote files ( #4244 )
...
When you try to remote unarchive files with the option copy=no the code always fail, as evidenced in issue #4202 . That happens because the conditional to check "if remote_src=no or copy=yes" will always be true since the default value of them is remote_src=no and copy=yes.
My modification is only to change the condition from or to and, that way only if both the vars stay with the default value will be true, otherwise you can unarchive remote files.
2016-08-11 11:23:29 -07:00
Brian Coca
1eb01d7612
remove X bit
2016-08-11 14:21:24 -04:00
jctanner
37ea0b0b1f
git: save changed submodules in check and non-check mode ( #4392 )
2016-08-11 14:14:20 -04:00
Dag Wieers
f5f1ec65e4
Add diff mode support to git module ( #3364 )
...
* Add diffmode support to git module
This patch adds missing diffmode support to the git module.
* Remodel get_diff() and calls to it
As proposed by @abadger
* Ensure we fetch the required object before performing a diff
Also we handle the return code ourselves, so don't leave this up to run_command().
2016-08-11 13:27:32 -04:00
Indrajit Raychaudhuri
23ebb98570
Improve hostname module to support systemd in more generic way ( #4382 )
...
Now that there is general purpose `Fact` helper to detect if systemd
is active, we would be able to rely on that to apply SystemdStrategy.
Detecting presence of systemd at runtime would be more reliable than
distribution version based heuristics. (e.g., Debian, Ubuntu allows
user to change the default init system, Gentoo allows switching as
well, and so on).
2016-08-11 17:44:16 +02:00
Brian Coca
f3e761f0c8
improved logic when dealing with init scripts
2016-08-11 09:43:16 -04:00
Brian Coca
92b4ae4768
fixes corner case for systemd services
...
when both unit file and sysv init script exist
Thanks to @olfway for fix.
fixes #3764
2016-08-11 09:24:42 -04:00
Dag Wieers
4fddb21980
Improve the documentation ( #4385 )
...
Improvements to make it more clear that pure compressed files (.gz, .bz2 and .xz) files are not supported.
This improves on #3241 .
2016-08-11 08:53:37 -04:00
Sam Doran
06e9dc5236
Improve regexp for matching file permissions ( #4306 )
...
A capital "S" appears when the the setuid or setgid bit are set but have no effect. Likewise, a capital "T" appears when the sticky bit is set but it has no effect.
2016-08-10 23:54:29 +02:00
Roman
78adaf2116
get_url headers param values parsing ( #4245 )
2016-08-10 23:49:58 +02:00
Evan
b5ad8b83be
pip: Fix uninitialized variable during check_mode ( #4379 )
...
During check_mode (`--check`), the variable change could be
used uninitialized, yielding this error:
`UnboundLocalError: local variable 'changed' referenced before assignment`
This changeset simply initializes it to False.
2016-08-10 23:45:54 +02:00
Evan Kaufman
4905ab66d6
Fixes #3791 cron always returning changed state for multiline jobs ( #4285 )
...
Strip only newlines and carriage returns. Instead of stripping ALL whitespace, which may have unintended side effects
2016-08-10 23:43:58 +02:00
BradLook
7c4de52693
Allow cron to target remote user ( #4270 )
2016-08-10 23:30:09 +02:00
René Moser
a216ef210b
mysql_db: use new exception handling, fixes build ( #4373 )
2016-08-10 12:35:01 +02:00
Jan Malte Gerth
6a78349f65
reuse already split output for filtering ( #4310 )
...
there is no need to call out.split('\n') multiple times (line 275 and 277)
2016-08-10 11:26:18 +02:00
Brian Coca
9dde201d87
unsafe writes! ( #4314 )
...
* unsafe writes!
* moved unsafe_write docs and args to file common
* added unsafe_writes option handling
2016-08-09 12:39:25 -04:00
Peter Sprygada
3480561254
Merge pull request #4319 from gundalow/docs-cumulus
...
Cumulus - consistent docs formatting
2016-08-09 07:52:59 -04:00
Peter Sprygada
4c5ad987ce
Merge pull request #4303 from gundalow/docs-eos
...
General EOS documentation improvements
2016-08-09 07:52:26 -04:00
Peter Sprygada
0bb0c1b2d8
Merge pull request #4323 from Qalthos/ios_config_bugfix
...
Fix ios_config broken logic
2016-08-09 07:38:38 -04:00
Peter Sprygada
1a71fff02b
Merge pull request #4341 from gundalow/docs-vyos
...
vyos: Docs fixes
2016-08-09 07:38:08 -04:00
Peter Sprygada
3d37d5c835
Merge pull request #4338 from gundalow/docs-openswitch
...
openswitch: Docs fixes
2016-08-09 07:37:22 -04:00
Peter Sprygada
56a59824b2
Merge pull request #4336 from gundalow/docs-nxos
...
NXOS Docs update
2016-08-09 07:36:21 -04:00
Peter Sprygada
04b200059d
Merge pull request #4326 from gundalow/docs-junos
...
junos: Docs update
2016-08-09 07:35:26 -04:00
Peter Sprygada
c15a84b690
Merge pull request #4360 from alvaroaleman/bugfix/ios_command_docs
...
Make ios_command example working
2016-08-09 07:34:16 -04:00
Saurabh Sharma
fcee7d08b3
error handling for importing non-existent db. Fixes ##2068 ( #3617 )
...
* error handling for importing non-existent db
* creating db on import state and suitable message on deleting db
* handling all possible cases when db exists/not-exists
2016-08-08 12:36:18 -07:00
Toshio Kuratomi
5d7b46e0dd
Be explicit about specifying the ssh port if it was user specified ( #4302 )
...
Previously, if the port specified by the user or inventory was 22, then
the ssh client port would be used instead.
Fixes #3895
2016-08-08 08:59:25 -07:00
Zoltán Müllner
8218e7ba25
Revert "Reset all locale environment variables before running svn commands" ( #4358 )
...
* Revert "Reset all locale environment variables before running svn commands"
This reverts commit 99456fbc98
.
* Reset locale environment variables before running svn commands
2016-08-08 10:18:50 -04:00
Michael Scherer
c46e425846
Add a example with a non service unit ( #4355 )
...
Since the documentation focus mostly on service
units, a explicit example may help people realizing
it can be used for socket and timer too.
2016-08-08 08:48:33 -04:00
Alvaro Aleman
12b579f92d
Make ios_command example working
2016-08-08 14:42:39 +02:00
muxator
24fa1ab426
typo in the documentation of the "state" parameter ( #4353 )
2016-08-07 17:23:42 +02:00
John R Barker
d05ed8e2d8
ios & iosxr Documentation improvements ( #4321 )
2016-08-05 19:26:09 -04:00
Chris Houseknecht
0358dee095
Add buildargs parameter to support Dockerfile ARG directive. ( #4349 )
...
* Add buildargs parameter to support Dockerfile ARG directive.
* Fix doc_strings. Doc string for load_path was completely missing.
2016-08-05 19:14:31 -04:00
Chris Houseknecht
4f2bf6cac1
Merge pull request #4346 from chouseknecht/devel
...
Default repository tag value to tag parameter value or 'latest'.
2016-08-05 16:36:04 -05:00
chouseknecht
cc101164a8
Default repository tag value to tag parameter value or 'latest'.
2016-08-05 16:08:11 -04:00
Chris Houseknecht
d30fd103cf
Merge pull request #4345 from chouseknecht/fix_4184
...
Always returns changed when state present and name includes :tag.
2016-08-05 13:40:55 -05:00
chouseknecht
d36f04e7f2
Always returns changed when state present and name includes :tag.
2016-08-05 14:29:06 -04:00
John R Barker
4148b74433
Update junos_config.py
2016-08-05 17:01:52 +01:00
John R Barker
5f02f54ff9
Update junos_config.py
2016-08-05 16:38:58 +01:00
Chris Houseknecht
c0d373f258
Add *build* to state parameter choices. Updated deprecation message. Will be deprecated in release 2.3. Removed ( #4342 )
...
mention of *tagged* state in the force parameter doc strings. There is no *tagged* state.
2016-08-05 10:47:29 -04:00
Chris Houseknecht
85ed6f488b
Merge pull request #4339 from chouseknecht/fix_4235
...
Fix image tag operation
2016-08-05 09:27:56 -05:00
John Barker
4d0f5cc3f5
vyos: Docs fixes
2016-08-05 15:14:04 +01:00
John Barker
d45a75bc01
openswitch: Docs fixes
2016-08-05 14:40:52 +01:00
John Barker
d319328d03
NXOS Docs update
2016-08-05 13:01:13 +01:00
chouseknecht
c27054090a
Fix image tag operation. Allows repository in form of repo:tag. If no tag value, defaults to 'latest'.
2016-08-05 05:08:52 -04:00
Ryan Brown
95a7ee271a
Merge pull request #3773 from jbaublitz/gce_net_nwmode
...
gce_net: Add ability to create new-style networks on Google Cloud
2016-08-04 14:22:35 -04:00
John Barker
bd08631e58
junos: Docs update
2016-08-04 17:16:38 +01:00
Nathaniel Case
8bb4b9818c
Fix ios_config broken logic
2016-08-04 11:24:28 -04:00
John Barker
5599ab14f6
Cumulus - consistent docs formatting
2016-08-04 12:18:06 +01:00
Peter Sprygada
b8c1edc04d
Merge pull request #4317 from Qalthos/nxos_command_fix
...
Quick fix to nxos_command and minify imports
2016-08-03 19:37:51 -04:00
Nathaniel Case
104d753730
Quick fix to nxos_command and minify imports
2016-08-03 18:06:33 -04:00