Commit graph

239 commits

Author SHA1 Message Date
James Cammarata
38487ea464 Merge pull request #4222 from lessmian/devel
Module lvol fails when decimal point is a colon
2013-09-25 14:54:58 -07:00
James Cammarata
a774f686f7 Merge branch 'obsd-fix-release' of https://github.com/johanwiren/ansible into johanwiren-obsd-fix-release 2013-09-25 14:49:57 -05:00
James Cammarata
6dbb1ff878 Fixing up some open_iscsi docs and CHANGELOG update 2013-09-25 14:37:56 -05:00
James Cammarata
d920cbc25f Merge branch 'open_iscsi_bis' of https://github.com/sergevanginderachter/ansible into sergevanginderachter-open_iscsi_bis 2013-09-25 14:35:01 -05:00
Tomasz Lesniewski
0eb92ac852 Module lvol fails when decimal point is a colon 2013-09-24 16:19:07 +02:00
Rene Moser
9f969cd3ec host: minor doc style improvements 2013-09-24 15:47:39 +02:00
Tomasz Lesniewski
75ca71bf2c Module lvol fails when decimal point is a colon 2013-09-24 15:06:18 +02:00
Michael DeHaan
eca73d3c82 Merge pull request #4220 from dagwieers/setup-dmidecode-fix
Fix for commented dmidecode output
2013-09-24 05:04:33 -07:00
Dag Wieers
b4cdd15843 Fix for commented dmidecode output
This patch fixes the problem that on some system dmidecode prints out warning information as commented text. For example:

    [user@system ~]# dmidecode -s system-manufacturer
    # SMBIOS implementations newer than version 2.6 are not
    # fully supported by this version of dmidecode.
    HP

So we remove all commented lines from the output.
2013-09-24 12:46:48 +02:00
Rene Moser
497b742935 host: added another example 2013-09-24 09:15:16 +02:00
James Cammarata
28592ed64f Minor pep8 cleanup 2013-09-23 16:37:42 -05:00
James Cammarata
d4ba1f9ded Fixing some bugs found during testing in the host module 2013-09-23 16:05:43 -05:00
James Cammarata
339f17d560 Merge branch 'feature/host' of https://github.com/resmo/ansible into resmo-feature/host 2013-09-23 15:42:30 -05:00
James Cammarata
104535ac48 Merge branch 'devel' of https://github.com/drybjed/ansible into drybjed-devel 2013-09-23 15:10:40 -05:00
James Cammarata
65180fa530 Added version_added string to new modprobe module and CHANGELOG update 2013-09-23 15:02:02 -05:00
James Cammarata
04683f554b Merge branch 'modprobe-module' of https://github.com/stygstra/ansible into stygstra-modprobe-module 2013-09-23 15:00:50 -05:00
James Cammarata
aadf8175c6 Modified env fact gathering to use the native python method
Also updated CHANGELOG for this feature
2013-09-23 14:17:40 -05:00
James Cammarata
d16a382935 Merge branch 'env_facts' of https://github.com/bcoca/ansible into bcoca-env_facts 2013-09-23 13:46:11 -05:00
Maciej Delmanowski
669b345937 Made re.search string shorter 2013-09-23 12:27:14 +02:00
Maciej Delmanowski
fa879a63a1 Add Linux Container identification 2013-09-23 12:15:33 +02:00
Johan Wirén
9120303446 Fixed setup module to no longer break on OpenBSD release versions. 2013-09-22 14:05:22 +02:00
James Cammarata
6eec6f776e More housekeeping
* Modified version_added strings in recent modules
* Added firewalld inclusion to the CHANGELOG
2013-09-21 01:06:34 -05:00
James Cammarata
6b5b004232 Moving firewalld module from net_infra to system 2013-09-21 01:02:19 -05:00
René Moser
d2d6b20d99 host: code cleanup 2013-09-20 22:50:03 +02:00
James Cammarata
3511687dad Minor tweak to service changed logic from the previous commit 2013-09-19 15:00:25 -05:00
James Cammarata
8bdb95a014 Merge branch 'service-enable-fix' of https://github.com/gottwald/ansible into gottwald-service-enable-fix 2013-09-19 14:59:53 -05:00
Petr Svoboda
f82d3f7fa9 Fix traceback in service module when svc_cmd is None (2nd fix)
When service module is used on unsupported Linux system where init
script is used directly, LinuxService.svc_cmd is None so .endswith()
fails.

This extends fix from e2f20db534 also
for state=restarted.

Fixes issue #3533
2013-09-19 14:36:02 -05:00
René Moser
9f5d8f8482 host: updated version_added 2013-09-19 20:09:38 +02:00
Rene Moser
318c956a22 added module host
Add or remove entries in /etc/hosts using tasks:
- host: ip=127.0.0.1 hostname=localhost aliases=foobar.com,localhost.foobar.com
- host: ip=127.0.0.1 hostname=localhost state=present
- host: ip=192.168.1.1 state=absent
- host: hostname=localhost state=absent
- host: ip=::1 hostname=localhost aliases=ip6-localhost,ip6-loopback
2013-09-19 20:09:38 +02:00
David Stygstra
86d4331e3b Add Python 2.4 support to modprobe module 2013-09-19 00:04:20 -04:00
David Stygstra
d6a5e05a21 Module to manage kernel modules 2013-09-19 00:02:44 -04:00
James Cammarata
7a52ad498d Merge branch 'issue_3417_systemd_stuff' into devel 2013-09-16 09:30:39 -05:00
James Cammarata
3d09c6441e Merge branch 'archlinux-fact' of https://github.com/Schnouki/ansible into Schnouki-archlinux-fact 2013-09-16 07:45:38 -05:00
r-p-e
df746b4fb7 Add some more OpenBSD facts
added:
 * ansible_distribution
 * ansible_distribution_release
 * ansible_distribution_version
2013-09-15 17:58:29 +02:00
Ingo Gottwald
08af5f833f Bugfix service module: Only change service state when needed 2013-09-13 22:04:37 +02:00
Thomas Jost
725dd43fca Add Archlinux "distribution" fact 2013-09-12 11:55:08 +02:00
James Cammarata
0449470f21 Allow service module to manage services not ending in .service
Fixes #3417
2013-09-11 15:48:36 -05:00
James Cammarata
3e7511609e Slight refactorization of the sysctl module
* Added in support for freebsd-style sysctl commands
* Replaced some functionality that was provided by module_common
* Simplified some logic in a couple of places (ie, not checking
  a split with len() but instead limiting the split to 1)

Fixes #3380
2013-09-11 13:15:17 -05:00
James Cammarata
8d6e302cf8 Compare exploded values in the sysctl module to avoid whitespace errors
Fixes #3931
2013-09-10 23:24:24 -05:00
James Cammarata
5fe192e5e7 Fixes to the service module for Ubuntu 12.04 (LTS)
Fixes #3615
Fixes #3572
2013-09-10 22:19:15 -05:00
James Cammarata
5e8918cb2c Check for systemd ownership of a service even if an init.d script exists
Also slight modification to the error message in the earlier commit that
modified the update-rc.d detection portion of the code

Fixes #3474
2013-09-10 19:37:51 -05:00
James Cammarata
ef02c6107a Minor fix to account for template service names in systemctl 2013-09-10 11:31:13 -05:00
James Cammarata
f22ffab259 Fix for update-rc.d based systems that also have systemd installed
By default, the service module had assumed that if the system had the
update-rc.d binary, the service was either managed via upstart or standard
sysV init-style scripts. This patch adds a check for systemctl ahead
of the other methods when update-rc.d is detected, and also simplifies
the logic around the detection of systemctl-managed services
2013-09-10 11:15:30 -05:00
James Laska
5dc830c279 The required package for selinux is libselinux-python 2013-09-06 16:26:48 -04:00
Brian Coca
849d7b282b Added collection of user's env
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
2013-09-06 08:55:37 -04:00
James Cammarata
21ae255fb3 Merge branch 'aix_wpar_facts' of https://github.com/mplonka/ansible into mplonka-aix_wpar_facts 2013-09-05 23:49:29 -05:00
James Cammarata
17f683aad7 Added 'reloaded' state to list of states checked for bounced services
Fixes #3556
2013-09-03 09:49:19 -05:00
Serge van Ginderachter
129fa6689f Introduce open-iscsi module to manage targets on the initiator. 2013-09-03 13:31:28 +02:00
Raul Melo
b0ffba472f Fix issue 3908. There was some ilegal operations over the sets 2013-08-27 17:07:42 +02:00
James Cammarata
b4306920ce Fix for the cron module on FreeBSD
Apparently crontab on freebsd does not like the file path coming before
the "-u username" portion of the command to install the crontab
2013-08-24 21:37:10 -05:00
Marcin Płonka
4a43bb3b00 Skipping facts not available on AIX WPARs 2013-08-24 07:24:05 +02:00
shirou
26e6ac4340 supports nested values of ohai. 2013-08-23 17:00:56 +09:00
Michael DeHaan
003c86e250 Merge branch 'fix_service_with_initscript' of git://github.com/psvo/ansible into devel 2013-08-10 18:05:35 -04:00
Andy Wilson
85e34cc107 docfix: grammar in docstring for sysctl module 2013-08-08 12:23:30 -05:00
Petr Svoboda
48b064b55b Fix traceback in service module when svc_cmd is None
When service module is used on unsupported Linux system where init
script is used directly, LinuxService.svc_cmd is None so .endswith()
fails.

Fixes issue #3533
2013-08-08 14:24:20 +02:00
Michael Scherer
bb9d0a9493 Add urpmi as a package manager for mandriva-based distribution 2013-08-04 00:03:50 +02:00
James Cammarata
494030aa6c Removing skipped=True so the task is just marked as not-changed 2013-08-03 12:15:09 -05:00
James Cammarata
f3384374b9 Set result to skipped when vol group is missing and lv state=absent
Fixes issue #3714 - lvol module state=absent fails (with error) if
the volume group doesn't exist
2013-08-02 20:32:56 -05:00
rishid
fea38f44ac Verify groups string is not empty before trying add user to groups 2013-08-01 21:19:11 -04:00
Brian Coca
e8e8779dfa fixed bug from prev update
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
2013-08-01 00:24:34 -04:00
Brian Coca
2c06418f6d whitespace updates on new lines
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
2013-07-31 23:26:28 -04:00
Brian Coca
fe57037f84 now uses get_bin_path for lvg executables
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
2013-07-31 22:32:41 -04:00
Michael DeHaan
5b80299231 Make exceptions handling python 2.4 compatible. 2013-07-29 13:27:16 -04:00
Michael DeHaan
ecf074865f Continue on mount errors, don't fail the setup module. 2013-07-22 13:57:35 -04:00
Brian Coca
220fe24d39 use global to fail as its not in self
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
2013-07-22 10:54:20 -04:00
Michael DeHaan
3f4c6affa3 Update CHANGELOG 2013-07-21 10:12:28 -04:00
Michael DeHaan
9ebde16e3a Merge branch 'iss_cron' of git://github.com/dirtyharrycallahan/ansible into dh_cron 2013-07-21 10:00:11 -04:00
Michael DeHaan
4281f773bb Merge pull request #3602 from bcoca/fine_tune_stat_exception
narrowed down exception
2013-07-20 09:45:31 -07:00
Michael DeHaan
517c318989 Merge pull request #3470 from langemeijer/devel
Only append non_unique parameter if a uid is provided as well to user module
2013-07-20 09:11:52 -07:00
Brian Coca
7132f7e792 narrowed down exception we ignore and fail if any other unexpected one
crops up.
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
2013-07-20 11:51:52 -04:00
Florian Tham
865a663d05 fix fatal error when removing logical volumes 2013-07-19 10:59:11 +02:00
Antti Rasinen
f9e9286b2c Make zfs set_property accept values with embedded spaces
Converting the argument list to a string with ' '.join causes
the shell interpreter to misparse spaces in property values.
Since the zfs command does not need shell anywhere, using
a list instead of a string works just as well with run_command. 

Fixes #3545.
2013-07-16 14:01:14 +03:00
Antti Rasinen
8bfe9f6942 Fix zfs property parsing
Current property parser breaks when values contain spaces. Since
zfs get -H returns tab separated lines,  it is better to explicitly
split on tabs than on whitespace.
2013-07-16 13:49:19 +03:00
trbs
98b284159f fix missing json module for issue #3363 print JSON error as string instead 2013-07-15 16:50:31 +02:00
Brian Coca
dd1ffce0a0 now won't throw exception if we don't have permission to stat a mtab
entry on linux (weird chromebook issue)
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
2013-07-14 22:59:24 -04:00
Michael DeHaan
b22428d87e Merge pull request #3426 from trbs/services_sleep_option
sleep option for service module which adds a pauze between stopping and ...
2013-07-12 08:18:22 -07:00
Michael DeHaan
7dfafc6ec4 Merge pull request #3496 from johanwiren/bsd-ipv6-facts
Fix for populating default_ipv6 on BSD systems
2013-07-11 05:55:53 -07:00
Michael DeHaan
38ac6c9abd Merge pull request #3497 from johanwiren/bsd-gateway
Updated setup module to collect gateway fact for BSD systems
2013-07-11 05:55:26 -07:00
Michael DeHaan
03605484f8 Merge pull request #3388 from bcoca/fixed_user_create_doc
updated module docs to reflect 'correct' on_create vs on_creation
2013-07-11 05:34:37 -07:00
Johan Wirén
3e765f7775 Updated GenericBsdIfconfigNetwork to collect gateway 2013-07-11 00:05:53 +02:00
Johan Wirén
a03125e0cf Fix for populating default_ipv6 on BSD systems 2013-07-10 22:54:33 +02:00
Joshua Lund
d75f73fffe Added a new with_file example to the authorized_key documentation 2013-07-10 14:09:03 -06:00
Patrick Callahan
f37becb94a Bug fixes and enhancements.
Bugs:
(1) no longer allow empty jobs
(2) strip the header added by crontab package used in openSuSE and SuSE
(3) try not to leak temp files when things go wrong
(4) issue returning job names under certain conditions

Enhancements:
(1) Allow all special times not just reboot.
(2) Fail earlier by performing more input validation
(3) Add feature to allow removing cron file under /etc/cron.d

ToDo:
(1) Validate times (minute, hour, ...)
(2) Strip white space from fields such as name and job such that name=foo equals name=' foo'.
(3) More testing
2013-07-09 03:21:40 +00:00
Brian Coca
e0e50b5936 fixed check mode
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
2013-07-08 15:41:39 -04:00
Casper Langemeijer
8727f0ce11 Only append non_unique parameter if a uid is provided as well 2013-07-08 11:46:38 +02:00
Aaron Brady
34617476d0 Make the CPU facts Hyperthreading aware 2013-07-03 16:25:35 +01:00
trbs
0d8da6eeb0 sleep option for service module which adds a pauze between stopping and starting a service using state=restarted. This helps for bad scripts that exist immediatly after signaling a process to stop. 2013-07-03 17:08:07 +02:00
Antti Rasinen
c2a4645349 Fix service enable on FreeBSD
Some services have a knob (i.e. rc.conf setting) whose name
differs from that of the script. For example, lockd process
is controlled with a script called lockd, but the rc.conf
value is rpc_lockd_enable.

Fixes issue #3382.
2013-07-03 14:52:23 +03:00
Brian Coca
b494d6d2ae updated module docs to reflect 'correct' on_create vs on_creation
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
2013-06-30 20:32:05 -04:00
Michael DeHaan
8d23df3576 Merge pull request #3315 from madduck/fix-service-updatercd-changed
Let update-rc.d set changed flag properly
2013-06-30 16:09:39 -07:00
Michael DeHaan
da0e718698 Styling: semicolon 2013-06-30 18:56:03 -04:00
Michael DeHaan
936ad65726 Styling: blank lines 2013-06-30 18:52:33 -04:00
Serge van Ginderachter
fc01f88228 add more support for different size formats 2013-06-24 22:37:31 +02:00
martin f. krafft
3b7b061b07 Expand usage of Python 2.6 if statement
Syntax like "'foo' if bar else 'baz'" is not supported by all Python
versions targetted by Ansible. Hence we break it up.

Signed-off-by: martin f. krafft <madduck@madduck.net>
2013-06-23 09:19:27 +02:00
martin f. krafft
22b30b9281 Let update-rc.d set changed flag properly
When update-rc.d is used to enable/disable service, the changed flag was
always true (see #2189). This commit fixes that.

Signed-off-by: martin f. krafft <madduck@madduck.net>
2013-06-22 20:04:37 +02:00
Michael DeHaan
997bf64f3f Fix up some module docs formatting errors. 2013-06-19 22:37:09 -04:00
Patrick Callahan
d76151d47b bug fix: modify get_device_facts to handle servers with multiple pci domains
On machines with multiple pci domains get_device_facts would fail to
find a matching pci device causing setup to fail. Also on some platforms
there is additional information between the pci information and 'host'.
Modified get_device_facts to call lspci with the -D option and modified
the regex to account for the pci domain and to be more selective.
2013-06-18 22:48:05 -04:00
Michael DeHaan
0596f474cf Merge pull request #3147 from toshywoshy/setup_mtab_without_bind
changed get_mount_facts to ignore mount types 'none'
2013-06-18 17:56:49 -07:00
Michael DeHaan
e4f3c4e286 Clarify module docs 2013-06-18 20:19:29 -04:00
Michael DeHaan
f53bc323a5 Merge pull request #3230 from sayap/openrc
Add OpenRC support to the service module.
2013-06-18 17:13:06 -07:00