Commit graph

728 commits

Author SHA1 Message Date
Harlan Lieberman-Berg
06a4efa1cf Add missing brace. 2015-11-02 13:04:12 -08:00
Harlan Lieberman-Berg
a234e9b7b2 Change install_recommended in apt to a trinary.
Conditions are now "yes", "no", and "default", with the latter falling
back to the OS default.
2015-11-02 13:04:12 -08:00
Harlan Lieberman-Berg
baafcfc091 Change behavior of apt.py around installing recommended packages.
Closes #1189.

This will cause the settings in Ansible to override the system settings.
That will have no effect except on systems that have an out-of-Ansible
configuration that disables automatic installation of recommended
packages.  Previously, ansible would use the OS default whenever
install_recommends wasn't part of the playbook.  This change will cause
the Ansible default configuration setting of installing recommended
packages to override the configuration files set on the OS for things
installed through ansible, even when there is no install_recommends
specified in the playbook.  Because the OS default matches the Ansible
default, this shouldn't have wide impact.
2015-11-02 13:04:12 -08:00
Toshio Kuratomi
eeaeeb5a1f Correct typo in yum module docs 2015-10-27 12:51:48 -07:00
Patrick Galbraith
2a93f21821 Fix to issue 12912. Supply 'force' to install of python-apt. 2015-10-26 13:28:10 -04:00
Toshio Kuratomi
06f301b05b Note the difference between yum package groups and environment groups.
Fixes https://github.com/ansible/ansible/issues/12873
2015-10-26 08:37:03 -07:00
Toshio Kuratomi
01dcee98d2 Fix for state=latest with wildcard or virtual provide package names 2015-10-08 09:56:43 -07:00
Brian Coca
22bfb54d9d added comment explaining chdir defaults 2015-10-07 12:19:50 -04:00
Brian Coca
a639da7c44 default chdir to tmpdir to avoid virtualenv issues 2015-10-07 12:18:36 -04:00
Brian Coca
8c353d0516 make chdir a path so it resolves shell aliases
also removed this_dir logic as it is not needed, chdir is None by default and run_command can handle that.
2015-10-07 10:38:47 -04:00
Brian Coca
f6bbd2ac5b removed syslog in favor of common module logging functions 2015-10-01 00:13:58 -04:00
Greg DeKoenigsberg
0813c5fb40 Change author field for os_redhat_subscription.py 2015-09-22 05:51:02 -04:00
Brian Coca
cf2be9607c Merge pull request #533 from thataustin/devel
Updating rubygems --no-document param
2015-09-11 11:21:27 -04:00
Marius Gedminas
eb17b6a36c apt: check for "0 upgraded" to be at the beginning of the line
Fixes #1678.
2015-08-25 19:15:33 +03:00
Toshio Kuratomi
b29276df34 Merge pull request #1204 from detiber/test_rhsm
bugfixes for redhat_subscription
2015-08-24 12:54:03 -07:00
Toshio Kuratomi
4721d6d8b5 Fix for the case where plugins aren't loaded on old RHEL systems 2015-08-20 15:34:57 -07:00
Toshio Kuratomi
c228739f2d Merge pull request #1946 from ansible/pr/1657
Update check-mode results to be a dictionary (finishes pr 1657)
2015-08-20 13:14:02 -07:00
Toshio Kuratomi
9d4694122d Return change results in a dictionary listing the package names.
Fix a parsing problem when package names contain a dot.
2015-08-20 13:02:29 -07:00
Brian Coca
5913f5e5e1 deal with more failures when apt module fails to instantiate pkg
fixes #1499
2015-08-18 14:59:35 -04:00
Brian Coca
8ff80c2c91 updated docs for package 2015-08-13 14:57:55 -04:00
Brian Coca
d139825169 fixed typo 2015-08-11 11:53:52 -04:00
Brian Coca
afb9b8e2f3 added gpg2 as fallback
fixes #1796
2015-08-11 11:53:52 -04:00
Pierre-Louis Bonicoli
2fdb197245 fix error occurring with Debian
Error was: AttributeError: 'SourcesList' object has no attribute 'repos_urls'
2015-07-30 13:16:56 +05:30
Abhijit Menon-Sen
74a27ffe52 Simplify distribution test
If it's Ubuntu, use UbuntuSourcesList; if it's any other apt-friendly
distribution, use SourcesList; otherwise, fail.
2015-07-30 13:16:56 +05:30
Abhijit Menon-Sen
44d16240a8 Make SourcesList __init__ method also set self.module
This was originally required to allow other methods in SourcesList to
fail, but subsequent changes rendered that unnecessary, and it's just
a cleanup now, and avoids passing in module separately to save().
2015-07-30 13:11:43 +05:30
Abhijit Menon-Sen
6afa1da910 Clarify HAVE_PYTHON_APT/install_python_apt handling in apt_repository
1. Don't test check_mode in both the caller and in the callee.
2. Don't test HAVE_PYTHON_APT inside an if that tests HAVE_PYTHON_APT
3. Don't be irritatingly vague about why the module fails ("You may be
   seeing this because…").

Note that if «apt-get -y install python-apt» succeeds with rc==0, but
for some reason python_apt is not usable afterwards, this will break
because the imports in install_python_apt aren't wrapped inside a
try/except.

In other words, we assume that install_python_apt either succeeds or
fails with a traceback. This commit doesn't affect that behaviour.
2015-07-30 13:03:10 +05:30
Abhijit Menon-Sen
653fd34ed7 Fix call to _expand_ppa 2015-07-30 09:02:18 +05:30
Jason DeTiberus
c458b5e96c python 2.4 syntax fix 2015-07-28 06:30:37 -04:00
Jason DeTiberus
0802102634 Add example for changing consumed subscriptions 2015-07-28 06:26:04 -04:00
Jason DeTiberus
520a125693 bugfixes for redhat_subscription
- correctly return pool ids for newer versions of subscription-manager
- allow for managing subscriptions after initial registration.
2015-07-28 06:26:04 -04:00
queridiculo
e5e0a70fc1 yum: improved check_mode handling and package update flow. 2015-07-22 18:07:57 -04:00
Yuhui Huang
51666c6def Checking pip uninstall output in both stdout and stderr 2015-07-21 16:07:25 -07:00
Brian Coca
1dafa427c3 added versionadded to new option in pip module 2015-07-20 20:53:33 -04:00
Brian Coca
5c17fd3f9a Merge pull request #629 from wbolster/issue-586-virtualenv-python-version
Add virtualenv_python arg to pip module
2015-07-20 20:46:30 -04:00
Brian Coca
963eb242f1 updated to add missing 'use' option 2015-07-16 16:53:17 -04:00
Toshio Kuratomi
d46c036b75 Add notes about loop squashing and 1.9.2 change to install packages in one yum transaction 2015-07-09 08:17:00 -07:00
Brian Coca
93754b903f updated upgrade to a more sensible default as the previous was prone to confusion
fixes #1667
2015-07-03 14:44:17 -04:00
Matt Martz
9eb4219f79 Replaced tabbed indentation with spaces for apt module 2015-07-01 09:39:18 -05:00
Toshio Kuratomi
4ef5a45347 Add version that the profilename param was added 2015-06-30 05:08:38 -07:00
Toshio Kuratomi
6b8e6c0a0a Merge pull request #425 from gerhardsam/devel
rhn_register: add support for profilename
2015-06-30 05:07:29 -07:00
Austin Brown
bb816f046c Adding version detection 2015-06-29 23:13:29 -07:00
Brian Coca
a0d663bc65 Merge pull request #413 from JimPatterson/412_pip_check_venv
Correct check mode for pip in virtualenv.
2015-06-29 18:17:59 -04:00
Austin Brown
3c72e87152 Merge branch 'devel' of github.com:ansible/ansible-modules-core into devel
Conflicts:
	packaging/language/gem.py
2015-06-26 11:21:43 -07:00
verm666
d435d5ce0a This change is in response to issue #133.
The original problem is: apt_repository.py connect to launchpad on
every playbook run. In this patch apt_repository.py checks if required
repository already exists or not. If no - paa will be added, if yes -
just skip actions.
2015-06-25 10:56:29 -07:00
Toshio Kuratomi
50912c9092 Fix apt_repository so that it does not modify the mode of existing repositories 2015-06-24 16:32:47 -07:00
Toshio Kuratomi
720632f568 Merge pull request #338 from pilou-/apt_repository_filemode
apt_repository: fix file mode
2015-06-24 16:01:45 -07:00
Toshio Kuratomi
dba3bc7539 Read the url in in chunks so that we don't use as much memory for large packages 2015-06-24 08:12:49 -07:00
Toshio Kuratomi
4519dd5f4d Small cleanups.
* Import url(lib|parse|lib2) if needed by the module rather than relying
  on module_utils.urls to do so.
* Remove stdlib modules from requirements
* Use the if __name__ conditional for invoking main()
2015-06-24 06:51:00 -07:00
Brian Coca
7a33832606 fixed typo 2015-06-19 15:29:43 -04:00
Brian Coca
665265d285 Merge pull request #60 from az7arul/devel
added `include_doc` option
2015-06-19 12:39:56 -04:00
Toshio Kuratomi
0950593d53 Merge pull request #1516 from ansible/use-yum-api
Yum API is faster than calling out to repoquery.
2015-06-18 11:37:41 -07:00
Toshio Kuratomi
86c30e68a1 Restore setting cachedir when non-root but don't take a useless cachedir parameter to the function
* Revert "Remove unused code"
  This reverts commit bcfba0c050.
* Re-add the changes to remove cachedir as a parameter
2015-06-16 13:10:17 -07:00
Toshio Kuratomi
7c6c518003 Fix bugs found by @kustodian 2015-06-16 06:28:46 -07:00
Greg DeKoenigsberg
2a5f0bde87 Proper author info for all remaining modules 2015-06-15 15:53:30 -04:00
Toshio Kuratomi
08c17814fb Fix incorrect line breaking 2015-06-15 10:46:59 -07:00
Toshio Kuratomi
ef7a75938a Further optimizations pointed out by @kustodian in #1516
* Only install yum-utils if needed (b/c we're going to use repoquery)
* Add a warning message explaining that why slower repoquery was used
  rather than yum API.
2015-06-15 09:51:15 -07:00
Toshio Kuratomi
9c88f91092 Yum API is faster than calling out to repoquery. Looking through the
commit logs it looks like we weren't previously doing that because of
commit 14479e6adc

The message there is that Yum API prints an error message if the
rhn-plugin is in use and no rhn-certificate is available.  So instead of
using repoquery in preference always here we use repoquery in preference
if the rhn-plugin is enabled.
2015-06-13 17:08:32 -07:00
Edward Torbett
bcbf8c5556 Renamed previous pkgs variable to installed_pkgs as spotted by @strahinja 2015-06-12 18:06:25 +01:00
Edward Torbett
1fe79801f8 Corrected pkg to pkgs as noted by @abadger 2015-06-12 11:18:14 +01:00
Edward Torbett
fc36506b9e Added multi package operation to remove as suggested by @abadger. Adding to latest is a little more complex due to '*' support. 2015-06-11 15:21:30 +01:00
Edward Torbett
471824b451 Comments by @abadger 2015-06-11 15:13:28 +01:00
Edward Torbett
48422fba85 Rather than executing yum once per package, execute yum once for all supplied packages. This is necessary when performing a yum upgrade involving multiple dependent packages installed from RPM, for example when upgrading from PostgreSQL 9.0.11 to 9.0.21 on a Red Hat server. 2015-06-11 12:39:42 +01:00
Brian Coca
fd18aba076 updated package examples 2015-06-08 20:25:39 -04:00
Brian Coca
75c2bc54f5 corrected copyright ... does a copied the copyrightnotice require copyright? 2015-06-08 20:18:59 -04:00
Brian Coca
d6ed6113a7 may root help us all 2015-06-08 20:12:30 -04:00
az7arul
627933049c add include_doc option 2015-06-06 01:54:00 +06:00
Albert Mikaelyan
fef463f17c Update yum.py 2015-06-03 16:48:19 +03:00
Brian Coca
abcd276955 Merge pull request #963 from u2ix/devel
Allow to add build flags for gem installation
2015-06-03 08:54:00 -04:00
Toshio Kuratomi
f3277f0f1f Import ansible module_utils at bottom of file to not mess with line numbers in tracebacks 2015-05-29 13:37:47 -07:00
Toshio Kuratomi
00e54793a2 Merge pull request #1408 from Jmainguy/yum_http_el5
forces EL5 to fail if name=:// url style path to rpm
2015-05-29 13:32:58 -07:00
Jonathan Mainguy
7a5ad0c7f3 add :// url support for EL 5 2015-05-29 16:21:17 -04:00
Brian Coca
6d088169ef Merge pull request #1348 from devjatkin/issue_1230
fix apt to handle virtual packages correctly
2015-05-26 11:55:44 -04:00
Brian Coca
0d41af23c2 Merge pull request #909 from bcoca/apt_return_cacheinfo
added updated cache time to apt, also started documenting return values
2015-05-26 11:54:03 -04:00
Vasyl Kaigorodov
f0dc27227c Fix "_is_package_installed() takes exactly 4 arguments, 3 provided" error 2015-05-21 23:24:20 +02:00
Toshio Kuratomi
0877aae3fe Merge pull request #1383 from schlueter/add-state-to-easy_install
Add state to easy_install
2015-05-21 11:07:00 -07:00
Schlueter
1030cb48a7 Add 'version_added' to state documentation for easy_install resource 2015-05-21 12:54:48 -04:00
Schlueter
17544062ec Correct reference to gem in easy_install resource 2015-05-21 12:49:43 -04:00
Schlueter
02cd8489c1 Add Documentation 2015-05-21 12:23:05 -04:00
Schlueter
3bae8bda10 Use standard if statement to check state in easy_install resource 2015-05-21 12:16:26 -04:00
Schlueter
9b6a741615 Correct pass by object reference issue 2015-05-21 12:04:13 -04:00
Zoltan Kozma
364536a76e - Fixed annoying bug that disablerepo was essentially broken if a package needed updating by state latest.
- Replaced some unsafe practice with default parameters. However looking at the code this does not seem to matter much as the calling functions always seem to supply these parameters anyway.
2015-05-20 19:46:39 +01:00
Schlueter
9468a65bed Add state to easy_install 2015-05-20 13:43:53 -04:00
Semyon Deviatkin
adf34a6ccd Fix issue #1230
When virtual package providing only one package, look up status of target package
2015-05-18 08:10:22 +00:00
Matt Martz
7ca732830f Python2.4 fixes
* Ignore accelerate.py
* Don't use a lambda or a ternary
2015-05-11 11:04:44 -05:00
Toshio Kuratomi
7540cbb845 Explain why the apt module does not do implicit regex matches on package name since this is different than the apt-get command line tool.
Fixes #1258
2015-05-07 08:16:46 -07:00
Dominic Hargreaves
d197f898a5 apt_key documentation: add a note explaining the benefit of including 'id' 2015-05-07 15:49:50 +01:00
Toshio Kuratomi
1fa3efd7b4 Fix documentation 2015-05-05 13:58:41 -07:00
Jonathan Mainguy
3e66e409d5 Adds the exclude= option to the yum module. Works the same way --exclude does when yum install or yum update 2015-05-05 14:00:49 -04:00
Toshio Kuratomi
3782ec0225 Allow yum module to take a yaml list of package names and also ", " separated string-list (in addition to comma separated string-list) 2015-04-21 10:07:11 -07:00
James Cammarata
74e69d1fd1 Merge branch 'nixpanic-rhsm/org_id' into devel 2015-04-14 13:57:42 -05:00
James Cammarata
c9f0c87b59 Add version_added string to new org_id param in rhn_subscription 2015-04-14 13:56:55 -05:00
Brian Coca
da59efbc4b Merge pull request #623 from mscherer/small_yum_cleanup
Remove unused option in yum's repoquery call
2015-04-13 17:04:51 -04:00
Brian Coca
5e970f79e3 Merge pull request #1012 from DavidWittman/yum-disable-enable-ordering
[yum] Set disabled repos before enabled repos
2015-04-13 16:42:11 -04:00
Toshio Kuratomi
509403a50d Merge pull request #1087 from bugchecker/devel
prevent using undefined variable
2015-04-13 08:47:51 -07:00
Brian Coca
788230c43e ifxed error message as code remove the repo r var 2015-04-10 14:59:52 -04:00
Niels de Vos
011d240abc redhat_subscription: add the org_id parameter
When subscribing a system with an activationkey, it seems (sometimes?)
required to pass the "--org <number>" parameter to subscription-manager.
Activation Keys can be created through the Red Hat Customer Portal, and
a subscription can be attached to those. This makes is easy to register
systems without passing username/passwords around.

The organisation ID can be retrieved by executing the following command
on a registered system (*not* the account number):

  # subscription-manager identity

URL: https://access.redhat.com/management/activation_keys
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: Ken Dreyer <kdreyer@redhat.com>
2015-04-06 22:23:59 +05:30
bugchecker
496f9ca180 prevent using undefined variable 2015-04-05 20:40:11 +05:00
Ken Dreyer
bd617353cb redhat_subscription: fix activationkeys argument
Prior to this commit, Ansible would pass '--activationkeys <value>' as a
literal string, which the remote server would interpret as a single
argument to subscription-manager.

This led to the following failure message when using an activation key:

  subscription-manager: error: no such option: --activationkey "mykey"

Update the arguments so that the remote server will properly interpret
them as two separate values.
2015-04-02 14:21:20 -06:00
Florian Apolloner
7f4f89abda Added os.path.expanduser when searching for pip executable. 2015-03-29 21:06:36 +02:00
David Wittman
6d8437617c Set disabled repos before enabled repos
The ordering of disabling/enabling yum repositories matters, and
the yum module was mixing and matching the order. Specifically,
when yum-utils isn't installed, the codepath which uses the yum
python module was incorrectly ordering enabling and disabling.

The preferred order is to disable repositories and then enable them
to prevent clobbering. This was previously discussed in
ansible/ansible#5255 and incompletely addressed in 0cca4a3.
2015-03-27 11:07:51 -05:00