6599 commits

Author	SHA1	Message	Date
Charles Paul	9f9bff88c2	doc fragments for vmware_ vca_	2016-01-12 11:06:22 -06:00
Brian Coca	cf9dfde15b	Merge pull request #13751 from bcoca/module_internal_options ... pass diff and verbosity settings to modules	2016-01-12 11:49:48 -05:00
Chrrrles Paul	bd147ab592	Merge pull request #13736 from chrrrles/nolog ... adding password no_log and cleaning up argument spec for vca module	2016-01-12 10:24:37 -06:00
Brian Coca	c91df36ebe	added module name to missing interpreter error ... fixes #13816	2016-01-12 11:25:11 -05:00
Brian Coca	f56c15e7e2	Merge pull request #13766 from nflx/devel ... Allow InventoryScript JSON with childgroups only	2016-01-12 10:01:11 -05:00
James Cammarata	b58673289a	Split up comma-separated tags properly ... Fixes #13795	2016-01-12 08:18:06 -05:00
Peter Sprygada	4d3aa72143	bugfix in nxos shared module for including defaults	2016-01-11 22:46:42 -05:00
Peter Sprygada	a758806287	bugfix in ios shared module for including defaults	2016-01-11 22:46:32 -05:00
Peter Sprygada	935ae2801f	bugfix in eos shared module for including defaults	2016-01-11 22:45:40 -05:00
Toshio Kuratomi	d274fea358	Update submodules ref to pick up fix #558	2016-01-11 17:16:40 -08:00
Brian Coca	477d632118	now file mode diff shows octal values	2016-01-11 19:47:47 -05:00
Brian Coca	247ae748f5	Merge pull request #13786 from quinot/bug/attributes_typo ... Fix minor typo in comment	2016-01-11 14:32:45 -05:00
Toshio Kuratomi	4ac76f60ee	Merge pull request #13694 from resmo/fix/case-insensitivity ... [2.0] cloudstack: fix more case insensitivity	2016-01-11 11:00:53 -08:00
Tom Paine	76ac6294e0	profile_tasks README.md ... As agreed with Brian Coca in Ansible Project group: https://groups.google.com/forum/#!searchin/ansible-project/tom$20paine/ansible-project/__nv6BZs2yU/AkYQ0HU-BQAJ	2016-01-11 18:21:28 +00:00
Matt Martz	45d9cfcc6f	Coalesce forms of ssh_args in order of most specific to least	2016-01-11 11:55:25 -06:00
James Cammarata	6ec4d98764	When setting fail state skip RESCUE/ALWAYS if cur_block doesn't have them ... Fixes #13749	2016-01-11 12:51:04 -05:00
Robin Roth	e01ff3b352	remove unused imports ... clean up imports of time.sleep and stat that are no (longer) used here	2016-01-11 14:14:20 +01:00
Karthik T	c4cbeeffa8	Fixes #13763 Update connections _play_context on every iteration ... If this isnt updated, the _connection is reused, and thus has an outdated _play_context This results in outdated `success_key` and `prompt` causing issues if sudo is run in a loop Refer to the issue #13763 for more debugging and details	2016-01-11 16:30:52 +08:00
Rene Moser	766738ef7c	cloudstack: fix case insensitivity ... cloudstack: fix has_change reports changed for case insensitivity values	2016-01-10 22:38:18 +01:00
Peter Sprygada	c3dd0213ef	deletes nxapi from shared modules ... The nxapi module has been superseded by the nxos shared module and is not longer needed. This commit removes (deletes) nxapi from module_utils. All custom modules that have used nxapi should be using nxos instead.	2016-01-10 14:56:15 -05:00
Peter Sprygada	f99b834583	Merge pull request #13789 from privateip/shared_module_netcfg ... adds network config file parser to shared modules	2016-01-10 14:44:00 -05:00
Peter Sprygada	b7fec945be	Merge pull request #13788 from privateip/shared_module_junos ... initial add of junos shared module	2016-01-10 14:39:37 -05:00
Peter Sprygada	60e0e1a12e	Merge pull request #13784 from privateip/shared_module_openswitch ... initial add of openswitch shared module	2016-01-10 14:35:42 -05:00
Peter Sprygada	771d8014fc	Merge pull request #13779 from privateip/shared_module_nxos ... adds shared module nxos for building cisco nxos modules	2016-01-10 14:32:23 -05:00
Peter Sprygada	a0a4edd494	Merge pull request #13777 from privateip/shared_module_ios ... updates the ios shared module with new shell	2016-01-10 14:28:00 -05:00
Peter Sprygada	a648097285	Merge pull request #13778 from privateip/shared_module_iosxr ... adds new iosxr shared module for developing modules that work with IO…	2016-01-10 14:23:22 -05:00
Peter Sprygada	41fed323bc	Merge pull request #13776 from privateip/shared_module_eos ... initial add of eos shared module	2016-01-10 14:19:31 -05:00
Peter Sprygada	7e677899a4	Merge pull request #13775 from privateip/shared_module_shell ... adds shared module shell for creating cli based transports	2016-01-10 14:09:43 -05:00
Peter Sprygada	01bf3940e3	adds network config file parser to shared modules ... This commit adds a new shared module that parses network device configuration files. It is used to build modules that work with the various supported network device operating systems	2016-01-10 10:47:28 -05:00
Peter Sprygada	e709095f53	initial add of junos shared module ... This commit adds a new shared module for working with network devices running the Juniper Junos operating system. The commit includes a new document fragment junos to be used when building modules. The junos shared module currently only supports CLI	2016-01-10 10:36:44 -05:00
Thomas Quinot	2eb22d5536	Fix minor typo in comment	2016-01-10 10:27:50 +01:00
Peter Sprygada	3ae6fd4b31	initial add of openswitch shared module ... This commit adds a new shared module openswitch for building modules that work with OpenSwitch. This shared module supports connectivity to OpenSwitch devices over SSH, CLI or REST. It also adds an openswitch documentation fragment for use in modules	2016-01-09 10:38:48 -05:00
Peter Sprygada	01a99f52a9	adds shared module nxos for building cisco nxos modules ... This commit refactors the nxapi into a new shared module nxos that supports connectivity over both ssh (cli) and nxapi. It supercedes the nxapi shared module and removes it from module_utils. This commit also adds a documentation fragement supporting the nxos shared module	2016-01-09 09:10:02 -05:00
Brian Coca	c9a5f7ea7e	updated self to cls to match convention ... tempted to just use this. in all cases	2016-01-08 17:57:09 -05:00
Brian Coca	792db08259	Merge pull request #13772 from bcoca/vars_prompt_fixes ... restructure vars_prompt and fix regression	2016-01-08 17:51:48 -05:00
Peter Sprygada	456b3d2c23	adds new iosxr shared module for developing modules that work with IOS XR devices ... This commit adds a new shared module for working with Cisco IOS XR devices over CLI (SSH). It also provides a documentation fragement for the commmon arguments provided by the iosxr module.	2016-01-08 14:14:29 -05:00
Peter Sprygada	d1dacfb3ca	updates the ios shared module with new shell ... This update refactor the ios shared module to use the new shell shared library instead of issh and cli. It also adds the ios documentation fragment to be used when building ios based modules.	2016-01-08 14:14:08 -05:00
Peter Sprygada	87ccc5c869	initial add of eos shared module ... This adds a shared module for communicating with Arista EOS devices over SSH (cli) or JSON-RPC (eapi). This modules replaces the eapi.py module previously added to module_utils. This commit includes a documentation fragment that describes the eos common arguments	2016-01-08 14:13:48 -05:00
Matt Martz	5f0a348447	Restore ability for a module to specify WANT_JSON	2016-01-08 11:37:28 -06:00
Brian Coca	1cc5ac06e7	restructure vars_prompt and fix regression ... pushed it to use the existing propmpt from display and moved the vars prompt code there also for uniformity changed vars_prompt to check extra vars vs the empty play.vars to restore 1.9 behaviour sipmlified the code as it didn't need to check for syntax again (tqm is made none prior based on that) fixes #13770	2016-01-08 11:46:04 -05:00
Brian Coca	737090dd13	now show full callback stacktrace when vvv+ ... Still is a warning as we don't want to repeat it multiple times nor additional callbacks to stop ansible execution. hopefully we can avoid shipping w/o exceptions in the default/minimal callbacks... Also added feature that now allows for 'preformated' strings passed to warning	2016-01-08 10:42:12 -05:00
Peter Sprygada	1d240902c6	adds shared module shell for creating cli based transports ... This commit add a new shared module shell that is used to build connections to network devices that operate in a CLI environment. This commit supercedes the issh.py and cli.py commits and removes them from module_utils.	2016-01-08 10:24:44 -05:00
Emil Lind	b0fe705384	Allow InventoryScript JSON with childgroups only ... and without hosts and vars Without this patch, the simplified syntax is triggered when a group is defined like this: "platforms": { "children": [ "cloudstack" ] } Which results in a group 'platforms' with 1 host 'platforms'. more details in https://github.com/ansible/ansible/issues/13655	2016-01-08 13:52:44 +01:00
nitzmahone	45355cd566	convert winrm put_file script template to Unicode string literal ... Fixes traceback on homedirs with non-ascii chars	2016-01-07 16:23:55 -08:00
Brian Coca	eb4ab5fa2a	Revert "Show version without supplying a dummy action" ... This reverts commit 11b55be5bb. Parsing before action will fail if one of the action specific options is used As per issue #13743	2016-01-07 08:28:18 -05:00
Brian Coca	b7dcd7a3a0	pass diff and verbosity settings to modules ... also simplifies and guarantees that all flags are always passed, even when false this should make checks simpler as you always expect them to exist	2016-01-07 01:37:19 -05:00
Toshio Kuratomi	d26d76ea58	Fix typo	2016-01-06 15:46:42 -08:00
Toshio Kuratomi	46903c80fa	More fixes for unicode handling in the connection plugins. ... Tested that ssh, docker, local, lxc-libvirt, chroot all work with the updated unicode integration test.	2016-01-06 15:19:40 -08:00
James Cammarata	90cb7e1937	Don't drop noops from task counting code in linear strategy	2016-01-06 14:02:33 -05:00
Tomasz Kontusz	9ac9c75d76	linear strategy: don't look at tasks from the next block	2016-01-06 14:02:33 -05:00
muffl0n	11b55be5bb	Show version without supplying a dummy action ... fixes #12004 parsing x2 does not seem to break anything	2016-01-06 11:53:33 -05:00
Abhijit Menon-Sen	7c8374e0f8	Strip string terms before templating ... The earlier code did call terms.strip(), but ignored the return value instead of passing that in to templar.template(). Clearly an oversight.	2016-01-06 20:44:19 +05:30
James Cammarata	dc47c25e58	Minor tweak to ensure diff is not empty in callback for file diffs	2016-01-05 22:01:01 -05:00
Charles Paul	a65543bbaf	adding password no_log and cleaning up argument spec	2016-01-05 14:52:22 -06:00
Brian Coca	095790ac5c	Merge pull request #13691 from bcoca/colors ... output color is now configurable	2016-01-05 14:33:01 -05:00
Brian Coca	84f46701d0	Merge pull request #13626 from bcoca/hostvars_vars ... move hostvars.vars to vars	2016-01-05 14:32:13 -05:00
Brian Coca	f3c45adfb8	simplified diff handling in callback ... no need for the copy or other complexity	2016-01-05 14:26:38 -05:00
Brian Coca	9972c27a9b	now handles 'non file diffs' ... this allows modules to pass back a 'diff' dict and it will still show using the file interface	2016-01-05 14:26:38 -05:00
Toshio Kuratomi	22d4dc9d85	Merge pull request #13700 from feliksik/shred-vault-tmpfile ... [security] shred ansible-vault tmp_file. Also when editor is interruped	2016-01-05 09:25:42 -08:00
Eric Feliksik	11ce08b9dd	cleaner implementation and random chunk length.	2016-01-05 18:04:38 +01:00
Toshio Kuratomi	6470f7de2c	Update submodule refs	2016-01-05 07:53:22 -08:00
Toshio Kuratomi	c0a8cd950b	Fix problems with non-ascii values passed as part of the command to connection plugins ... @drybjed discovered this with non-ascii environment variables and command line arguments to script and raw module.	2016-01-04 20:35:25 -08:00
Toshio Kuratomi	8d57ffd16b	Revert "Transform the command we pass to subprocess into a byte string in _low_level-exec_command" ... This reverts commit 0c013f592a. Going to do this in the connection plugin	2016-01-04 19:25:40 -08:00
Toshio Kuratomi	559ba467c0	Revert "Convert to bytes later so that make_become_command can jsut operate on text type." ... This reverts commit c4da5840b5. Going to do this in the connection plugins	2016-01-04 19:25:40 -08:00
Eric Feliksik	151e09d129	use unix shred if possible, otherwise fast custom impl; do not shred encrypted file	2016-01-05 01:43:42 +01:00
Eric Feliksik	1e911375e8	add docs, remove unnecessary int() cast	2016-01-04 18:13:59 +01:00
Michael Scherer	8599c56670	Do not set 'changed' to True when using group_by ... Since group_by is not changing in any way to the remote system, there is no change. This also make things more consistent with the set_fact plugin.	2016-01-04 17:46:40 +01:00
Eric Feliksik	7193d27acc	add os.fsync() so that the shredding data (hopefully) hits the drive	2016-01-04 17:22:18 +01:00
James Cammarata	210cf06d9a	Tweak how strategies evaluate failed hosts via the iterator and bug fixes ... * Added additional methods to the iterator code to assess host failures while also taking into account the block rescue/always states * Fixed bugs in the free strategy, where results were not always being processed after being collected * Added some prettier printing to the state output from iterator Fixes #13699	2016-01-02 01:00:12 -05:00
Brian Coca	6f2f7a79b3	add support for diff in file settings ... this allows modules to report on what specifically changed when using common file functions	2016-01-01 21:53:19 -05:00
Yannig Perré	c4d2dbfcdb	Replace to_string by to_unicode. ... Fix https://github.com/ansible/ansible/issues/13707	2016-01-01 15:55:51 +01:00
Thilo Uttendorfer	5c34be15b1	Fix unsupported format character	2015-12-31 02:31:38 +01:00
James Cammarata	e39e8ba308	Fix logic mistake in unarchive action plugin	2015-12-30 13:49:39 -05:00
Eric Feliksik	946b82bef7	shred ansible-vault tmp_file. Also when editor is interruped.	2015-12-30 18:21:34 +01:00
Brian Coca	d3deb24ead	output color is now configurable	2015-12-29 17:40:47 -05:00
James Cammarata	2d11cfab92	Squashed commit of the following: ... commit 24efa310b58c431b4d888a6315d1285da918f670 Author: James Cammarata <jimi@sngx.net> Date: Tue Dec 29 11:23:52 2015 -0500 Adding an additional test for copy exclusion Adds a negative test for the situation when an exclusion doesn't exist in the target to be copied. commit 643ba054877cf042177d65e6e2958178bdd2fe88 Merge: e6ee59f 66a8f7e Author: James Cammarata <jimi@sngx.net> Date: Tue Dec 29 10:59:18 2015 -0500 Merge branch 'speedup' of https://github.com/chrismeyersfsu/ansible into chrismeyersfsu-speedup commit 66a8f7e873 Author: Chris Meyers <chris.meyers.fsu@gmail.com> Date: Mon Dec 28 09:47:00 2015 -0500 better api and tests added * _copy_results = deepcopy for better performance * _copy_results_exclude to deepcopy but exclude certain fields. Pop fields that do not need to be deep copied. Re-assign popped fields after deep copy so we don't modify the original, to be copied, object. * _copy_results_exclude unit tests commit 93490960ff Author: Chris Meyers <chris.meyers.fsu@gmail.com> Date: Fri Dec 25 23:17:26 2015 -0600 remove uneeded deepcopy fields	2015-12-29 11:40:18 -05:00
Brian Coca	56454d6a91	added newer vars to 'reset_vars' ... these vars pass back info to the task about the connection moved to their own block at start at file for readability and added the newer standard vars	2015-12-28 12:25:27 -05:00
Etherdaemon	0b92abaf67	Proposed fix for ansible/ansible-modules-extras#1348 due to datetime.datetime type not being matched	2015-12-27 21:36:02 +10:00
Toshio Kuratomi	d70a97b562	Update submodule refs	2015-12-25 12:17:22 -08:00
Matt Martz	2587edb4f3	Move proxycommand parsing into _parse_proxy_command	2015-12-24 15:10:42 -06:00
Matt Martz	0296209bc1	Parse ansible_ssh_common_args looking for ProxyCommand, for use in paramiko	2015-12-24 15:01:41 -06:00
Matt Martz	a8e0763d1e	Move _split_args from ssh.py to ConnectionBase so we can use it in other connection plugins	2015-12-24 15:00:53 -06:00
Toshio Kuratomi	deac4d00b2	bigip changes as requested by bcoca and abadger: ... * Fix to error if validate_cert is True and python doesn't support it. * Only globally disable certificate checking if really needed. Use bigip verify parameter if available instead. * Remove public disable certificate function to make it less likely people will attempt to reuse that	2015-12-24 11:49:31 -08:00
Brian Coca	fd7e01696f	updated submodule refs to pick up module changes	2015-12-23 17:16:21 -05:00
Matt Martz	630a35adb0	Add ProxyCommand support to the paramiko connection plugin	2015-12-23 15:15:07 -06:00
Brian Coca	db1d153aca	Merge pull request #13647 from bcoca/fix_role_search ... corrected role path search order	2015-12-23 15:11:49 -05:00
Brian Coca	9a118ce213	Merge pull request #13648 from bcoca/fix_invocation_and_moderrors ... better module error handling	2015-12-23 10:42:40 -05:00
Michael Scherer	42b9a206ad	Fix last commit, make it python3 compatible (and py24)	2015-12-23 13:24:11 +01:00
Brian Coca	957b376f9e	better module error handling ... * now module errors clearly state msg=MODULE FAILURE * module's stdout and stderr go into module_stdout and module_stderr keys which only appear during parsing failure * invocation module_args are deleted from results provided by action plugin as errors can keep us from overwriting and then disclosing info that was meant to be kept hidden due to no_log * fixed invocation module_args set by basic.py as it was creating different keys as the invocation in action plugin base. * results now merge	2015-12-22 23:01:56 -05:00
Brian Coca	202b92179d	corrected role path search order ... the unfraking was matching roles in current dir as it always returns a full path, pushed to the bottom as match of last resort fixes #13645	2015-12-22 22:09:45 -05:00
Brian Coca	010839aedc	fix no_log disclosure when using aliases	2015-12-22 17:15:58 -05:00
Toshio Kuratomi	c4da5840b5	Convert to bytes later so that make_become_command can jsut operate on text type.	2015-12-22 08:22:02 -08:00
Brian Coca	474772c81c	Merge pull request #13639 from emonty/bool-conversion ... Also convert ints to bool for type=bool	2015-12-22 10:21:18 -05:00
Monty Taylor	c60749c922	Also convert ints to bool for type=bool	2015-12-22 09:14:12 -06:00
Brian Coca	bbdfaf0522	move hostvars.vars to vars ... this fixes duplication under hostvars and exposes all vars in the vars dict which makes dynamic reference possible on 'non hostvars'	2015-12-22 00:24:35 -05:00
Andrew Gaffney	0f4d1eb051	Add 'filtered' stdout callback plugin ... This plugin filters output for any task that is 'ok' or 'skipped'. It works by subclassing the 'default' stdout callback plugin and overriding certain functions. It will suppress display of the task banner until there is a 'changed' or 'failed' result or an unreachable host.	2015-12-21 22:41:52 +00:00
Toshio Kuratomi	0c013f592a	Transform the command we pass to subprocess into a byte string in _low_level-exec_command	2015-12-21 13:53:35 -08:00
Brian Coca	75e94e0cba	allow for non standard hostnames ... * Changed parse_addresses to throw exceptions instead of passing None * Switched callers to trap and pass through the original values. * Added very verbose notice * Look at deprecating this and possibly validate at plugin instead fixes #13608	2015-12-21 13:42:34 -05:00
Yannig Perré	a4674906c6	Merge role params into variables separately from other variables ... Fixes #13617	2015-12-21 13:03:09 -05:00
James Cammarata	6ae04c1e4f	Fix logic in PlayIterator when inserting tasks during rescue/always ... Because the fail_state is potentially non-zero in these block sections, the prior logic led to included tasks not being inserted at all. Related issue: #13605	2015-12-20 12:39:08 -05:00
James Cammarata	3ec0104128	Fixing bugs in conditional testing with until and some integration runner tweaks	2015-12-19 21:14:48 -05:00
Brian Coca	bb2935549f	corrected service detection in docker versions ... now if 1 == bash it falls back into tool detection	2015-12-19 16:16:10 -05:00
Toshio Kuratomi	e66c070e5c	Add package module to squash list	2015-12-19 13:00:58 -08:00
Toshio Kuratomi	224d596336	Remove args from get_name() as we can't tell if any of the args are no_log	2015-12-19 11:51:16 -08:00
Toshio Kuratomi	8ffc1fa838	Comment to explain why we strip _ansible_notify specially	2015-12-19 11:31:46 -08:00
Toshio Kuratomi	d32a885e98	Make return invocation information so that our sanitized copy will take precedence over what the executor knows.	2015-12-19 11:24:59 -08:00
Toshio Kuratomi	2936682f00	Revert "removed invocation info as it is not no_log aware" ... This reverts commit 6127a8585e.	2015-12-19 11:09:20 -08:00
Brian Coca	6127a8585e	removed invocation info as it is not no_log aware ... This was added in 1.9 and 2.0 tried to copy, but since it cannot obey no_log restrictions I commented it out. I did not remove as it is still very useful for module invocation debugging.	2015-12-19 11:48:48 -05:00
Toshio Kuratomi	07a0059306	update submodule ref for doc fix	2015-12-18 22:23:25 -08:00
Toshio Kuratomi	3197eeaaa8	update submodule refs	2015-12-18 22:16:49 -08:00
James Cammarata	a3dcb910b8	Fixing bugs with {changed,failed}_when and until with registered vars ... * Saving of the registered variable was occuring after the tests for changed/failed_when. * Each of the above fields and until were being post_validated too early, so variables which were not defined at that time were causing task failures. Fixes #13591	2015-12-18 10:58:55 -05:00
Toshio Kuratomi	3057fc1753	Update submodule ref for mysql_user fix	2015-12-17 13:46:15 -08:00
James Cammarata	4ba7158282	Fixing a mistake from tweaking list stuff too much ... Use the action only if the task name is not set	2015-12-17 16:33:23 -05:00
James Cammarata	d4ffc96c80	Further tweaks to the output format of list tasks/tags	2015-12-17 16:30:23 -05:00
James Cammarata	5929ffc7c3	Make --list-tasks respect tags ... Also makes the output closer to the appearance of v1 Fixes #13260	2015-12-17 16:10:27 -05:00
Toshio Kuratomi	bad1c173b8	Update core submodule for mysql_db fix	2015-12-17 11:36:36 -08:00
Toshio Kuratomi	1b5e7ce025	Update submodule refs	2015-12-17 10:23:30 -08:00
James Cammarata	e546219426	Revert "Enable host_key checking at the strategy level" ... This reverts commit 1a6d660d7e285cceec474952a33af4d8dffd0a8d.	2015-12-17 12:43:47 -05:00
James Cammarata	586208234c	Revert "Fixing bugs in ssh known_host fetching" ... This reverts commit 21c127c581.	2015-12-17 12:43:47 -05:00
James Cammarata	21c127c581	Fixing bugs in ssh known_host fetching ... * If remote_addr is not set in the PlayContext, use the host.address field instead (which is how the action plugin works) Fixes #13581	2015-12-17 12:06:17 -05:00
James Cammarata	d9c74536be	Fix handling of environment inheritence, and template each inherited env ... Environments were not being templated individually, so a variable environment value was causing the exception regarding dicts to be hit. Also, environments as inherited were coming through with the tasks listed first, followed by the parents, so they were being merged backwards. Reversing the list of environments fixed this.	2015-12-17 09:44:40 -05:00
James Cammarata	e5c2c03dea	Enable host_key checking at the strategy level ... Implements a new method in the ssh connection plugin (fetch_and_store_key) which is used to prefetch the key using ssh-keyscan.	2015-12-16 21:41:07 -05:00
James Cammarata	15135f3c16	Make sure we're using the original host when processing include results ... Also fixes a bug where we were passing an incorrect number of parameters to _do_handler_run() when processing an include file in a handler task/block. Fixes #13560	2015-12-16 19:13:45 -05:00
James Cammarata	857456ea5f	Fixing template integration test for python 2.6 versions ... No longer immediately fallback to to_json if simplejson is not installed	2015-12-16 18:22:22 -05:00
Toshio Kuratomi	fd4ad2c8f2	Update submodule ref to fix a bug in mysql_user with mariadb	2015-12-16 14:08:08 -08:00
James Cammarata	8716bf8021	All variables in complex args again ... Also updates the CHANGELOG to note the slight change, where bare variables in args are no longer allowed to be bare variables Fixes #13518	2015-12-16 16:39:08 -05:00
James Cammarata	76b4b9ed2c	Merge pull request #13501 from chouseknecht/galaxy-2.0-update ... Galaxy 2.0 update	2015-12-16 15:01:12 -05:00
nitzmahone	baece499df	fix plugin loading for Windows modules ... force plugin loader to only consider .py files, since that's the only place docs can live ATM...	2015-12-16 11:47:12 -08:00
Toshio Kuratomi	9724117bbb	Update submodule refs for mysql refactor	2015-12-16 11:15:39 -08:00
Toshio Kuratomi	1116bc6ca6	Merge pull request #13191 from Jmainguy/mysql ... Add shared connection code for mysql modules	2015-12-16 10:47:49 -08:00
Jonathan Mainguy	34e88e48a5	Add shared connection code for mysql modules	2015-12-16 13:36:18 -05:00
James Cammarata	6a252a3f77	Preserve the cumulative path for checking includes which have parents ... Otherwise, each relative include path is checked on its own, rather than in relation to the (possibly relative) path of its parent, meaning includes multiple level deep may fail to find the correct (or any) file. Fixes #13472	2015-12-16 11:23:06 -05:00
Toshio Kuratomi	0095d04af9	Update submodule refs	2015-12-16 08:02:46 -08:00
Toshio Kuratomi	7d519127fe	Merge pull request #13573 from ansible/ssl-context-with-proxy ... Fix a few problems with url handling.	2015-12-16 08:00:59 -08:00
Toshio Kuratomi	33863eb653	Conditionally create the CustomHTTPSConnection class only if we have the required baseclasses. ... Fixes #11918	2015-12-16 07:47:09 -08:00
Toshio Kuratomi	72a0654b81	Fixes for proxy on RHEL5	2015-12-16 07:47:07 -08:00
Toshio Kuratomi	73ead4fbba	First attempt to fix https certificate errors through a proxy with python-2.7.9+ ... Fixes #12549	2015-12-16 07:46:54 -08:00
Brian Coca	97275110d7	Merge pull request #13533 from bcoca/debug_fixes ... debug now validates its params	2015-12-16 10:36:20 -05:00
James Cammarata	fcc9258b74	Use the original host rather than the serialized one when processing results ... Fixes #13526 Fixes #13564 Fixes #13566	2015-12-16 01:48:22 -05:00
Toshio Kuratomi	d203438a2c	Merge pull request #13554 from Yannig/devel_fix_python3_tests ... Use six lib to import urlparse properly.	2015-12-15 07:55:56 -08:00
Brian Coca	be5488cb60	clean debug output to match prev versions	2015-12-15 09:27:53 -05:00
Brian Coca	a0842781a6	renamed ssh.py shared module file to clarify	2015-12-15 08:45:12 -05:00
Yannig Perré	be4d1f9ee3	Fix a part of python 3 tests (make tests-py3, see https://github.com/ansible/ansible/issues/13553 for more details).	2015-12-15 13:37:35 +01:00
Peter Sprygada	27cd7668c1	the ssh shared module will try to use keys if the password is not supplied ... The current ssh shared module forces only password based authentication. This change will allow the ssh module to use keys if a password is not provided.	2015-12-15 07:16:28 -05:00
Toshio Kuratomi	8d16638fec	Fix for template module not creating a file that was not present when force=false	2015-12-14 10:55:21 -08:00
Michael Scherer	a7ac98262d	Make module_utils.known_hosts.get_fqdn work on ipv6	2015-12-14 19:30:54 +01:00
Toshio Kuratomi	c9eb41109f	Update submodule refs	2015-12-14 08:03:56 -08:00
James Cammarata	80d23d639c	Use an octal representation that works from 2.4->3+ for known_hosts	2015-12-14 10:43:30 -05:00
James Cammarata	6312e38133	Fixing up some non-py3 things for unit tests	2015-12-14 10:35:58 -05:00
Brian Coca	2a37f11738	Merge pull request #13542 from h0nIg/devel_default_ask ... ansible vault, ask pass: use default settings from ansible.cfg	2015-12-14 09:14:48 -05:00
Hans-Joachim Kliemeck	f5f9b2fd35	use default settings from ansible.cfg	2015-12-14 15:04:31 +01:00
James Cammarata	f8ff63f8c8	A few tweaks to improve new forking code	2015-12-14 03:06:52 -05:00
Brian Coca	175c2d6510	Merge pull request #13502 from robinro/patch-3 ... use shallow clones by default in ansible-pull	2015-12-13 09:31:35 -05:00
Toshio Kuratomi	2bc3683d41	Restore comment about for-else since it is an uncommon idiom	2015-12-13 05:55:31 -08:00
chouseknecht	06dde0d332	Fixed documentation typos and bits that needed clarification. Fixed missing spaces in VALID_ACTIONS.	2015-12-13 05:23:04 -05:00
chouseknecht	342dee0023	Define and handle ignore_certs correctly. Preserve search term order. Tweak to Galaxy docsite.	2015-12-13 05:23:04 -05:00
chouseknecht	bc73920090	Updated ansible-galaxy man page. Removed -b option for import.	2015-12-13 05:23:04 -05:00
chouseknecht	d8e6bc98a2	Fix overloaded options. Show an error when no action given. Don't show a helpful list of commands and descriptions.	2015-12-13 05:23:04 -05:00
Robin Roth	1bd8d97093	fix whitespace	2015-12-13 11:19:50 +01:00
Robin Roth	1b2ebe8def	make shallow clone the default for ansibel-pull	2015-12-13 10:56:47 +01:00
Brian Coca	d73562902b	debug now validates its params ... simplified var handling made default message the same as in pre 2.0 fixes #13532	2015-12-13 00:13:13 -05:00
Brian Coca	f3bedbae29	simplified skippy ... thanks agaffney!	2015-12-12 17:50:55 -05:00
Brian Coca	99e46440bd	changed shell delimiters for csh ... fixes #13459	2015-12-12 16:10:18 -05:00
Brian Coca	8e445c551a	removed unused imports in galaxy/cli	2015-12-12 13:43:10 -05:00
James Cammarata	120b9a7ac6	Changing the way workers are forked	2015-12-11 23:35:07 -05:00
Brian Coca	ae988ed753	avoid set to unique hosts to preserver order ... swiched to using a list comp and set to still unique but keep expected order fixes #13522	2015-12-11 15:38:04 -05:00
Brian Coca	de71171fc2	removed merge conflict	2015-12-11 15:11:26 -05:00
James Cammarata	7f7e730dea	Don't mark hosts failed if they've moved to a rescue portion of a block ... Fixes #13521	2015-12-11 14:55:44 -05:00
Brian Coca	d9e510b192	narrow down exception catching in block builds ... this was obscuring other errors and should have always been narrow scope	2015-12-11 13:13:05 -05:00
Chrrrles Paul	e56efa49c4	Merge pull request #13509 from chrrrles/vca_default_host ... fix default host for non vcd service types	2015-12-11 10:17:55 -05:00
Abhijit Menon-Sen	37c4e9aee3	Clean up debug logging around _low_level_execute_command ... We were logging the command to be executed many times, which made debug logs very hard to read. Now we do it only once. Also makes the logged ssh command line cut-and-paste-able (the lack of which has confused a number of people by now; the problem being that we pass the command as a single argument to execve(), so it doesn't need an extra level of quoting as it does when you try to run it by hand).	2015-12-11 07:11:48 +05:30
Charles Paul	a6a58d6947	fix default host for non vcd service types	2015-12-10 16:39:27 -05:00
Toshio Kuratomi	bd9582d072	Update submodule refs	2015-12-10 08:10:45 -08:00
Toshio Kuratomi	1dda8158ff	become_pass needs to be bytes when it is passed to ssh. ... Fixes #13240	2015-12-10 07:29:38 -08:00
Charles Paul	6680cc7052	allow custom callbacks with adhoc cli for scripting ... missing import of CallbackBase	2015-12-10 09:49:54 -05:00
Robin Roth	c20c1a6d49	add depth option to ansible-pull ... Allows shallow checkouts in ansible-pull by adding `--depth 1` (or higher number)	2015-12-10 11:16:21 +01:00
James Cammarata	2b36343451	Missed one place we were appending the incorrectly escaped item to raw params	2015-12-09 17:58:44 -05:00
Toshio Kuratomi	62cbc03af6	Revert "Remove the funcd connection plugin" ... This reverts commit c0d79cf7e1. We may still port the funcd connection plugin, just not in time for 2.0.0	2015-12-09 13:32:11 -08:00
James Cammarata	30b6dd8bcd	Merge pull request #13495 from Yannig/devel_debug_null_error ... Do not fail when variable is not correct in debug action.	2015-12-09 16:27:05 -05:00
Yannig Perré	18ac12aee6	Do not fail when variable is not correct in debug action. ... See https://github.com/ansible/ansible/issues/13484 for more information.	2015-12-09 22:08:30 +01:00
Toshio Kuratomi	c0d79cf7e1	Remove the funcd connection plugin	2015-12-09 13:07:00 -08:00
Brian Coca	64864829c4	changed deprecation to removal warning	2015-12-09 12:37:56 -08:00
Toshio Kuratomi	61dc4a7e67	Update module refs	2015-12-09 12:10:21 -08:00
James Cammarata	14e19c239d	Make on_file_diff callback item-aware	2015-12-09 14:52:53 -05:00
Brian Coca	04d74fd680	reenabled --tree for ansible adhoc command ... previous fix to avoid callbacks now conflicted with tree optoin which is implemented as a callback in 2.0	2015-12-09 10:13:50 -08:00
Brian Coca	7936a4687e	adhoc avoids callbacks by default as it did before ... Previous emptying of whitelist only affected callbacks that were constructed for need whitelist. This now works for all callbacks.	2015-12-09 10:01:21 -08:00
Brian Coca	ae2447df91	attribute defaults that are containers are a copy ... This is simpler way to prevent persistent containers across instances of classes that use field attributes	2015-12-09 08:40:06 -08:00
Brian Coca	2bfb13bfb3	removed unused 'pattern' from ansible.cfg ... also moved the config param to a 'deprecated' list in constants.py added TODO for producing a deprecation warning for such vars	2015-12-09 08:40:06 -08:00
Brian Coca	2820b4c243	removed default from hosts to make it requried ... prevents writing a play w/o a hosts entry which would default to all/empty	2015-12-09 08:40:06 -08:00
Brian Coca	c64298de02	Revert "avoid persistent containers in attribute defaults" ... This reverts commit 87969868d4. found better way to do it	2015-12-09 08:40:06 -08:00
James Cammarata	332a008273	Merge pull request #13489 from chouseknecht/galaxy-2.0 ... Galaxy 2.0	2015-12-09 11:29:20 -05:00
chouseknecht	4f84769a17	Galaxy 2.0	2015-12-09 10:51:12 -05:00
Brian Coca	87969868d4	avoid persistent containers in attribute defaults ... moved from the field attribute declaration and created a placeholder which then is resolved in the field attribute class. this is to avoid unwanted persistent of the defaults across objects which introduces stealth bugs when multiple objects of the same kind are used in succession while not overriding the default values.	2015-12-09 07:29:36 -08:00
Brian Coca	0719eb3e2d	clarified warning from tree callback	2015-12-09 07:29:12 -08:00
Brian Coca	d82d65ee7b	keep string type filters as strings ... now we don't try to convert types if using a filter that outputs a specifically formated string made list of filters configurable	2015-12-08 12:52:20 -08:00
James Cammarata	1799de8528	Preserve original token when appending to _raw_params in parse_kv ... Fixes #13311	2015-12-08 15:06:36 -05:00
Brian Coca	795fac917e	fixed typo in tree callback, added default dir ... this would allow it to work with playbooks also	2015-12-08 11:59:04 -08:00
James Cammarata	398f6bbb89	Fix typo from 5ae850c	2015-12-08 14:36:36 -05:00
James Cammarata	de690445bc	Make fact delegating configurable, defaulting to 1.x behavior	2015-12-08 14:36:33 -05:00
Brian Coca	7ffd578a9d	Revert "Fix always_run support in the action plugin for template when copying" ... This reverts commit 9c4eae5253.	2015-12-08 09:24:20 -08:00
Brian Coca	d4ccb0be59	have always_run override check mode for a task ... Fixes #13418	2015-12-08 09:24:07 -08:00
James Cammarata	9c4eae5253	Fix always_run support in the action plugin for template when copying ... Fixes #13418	2015-12-08 11:56:39 -05:00
David L Ballenger	cdc3c88018	Merge remote-tracking branch 'ansible/devel' into issue_13438	2015-12-08 07:42:49 -08:00
Peter Sprygada	2d5b4b1799	Merge pull request #13273 from privateip/nxapi ... adds new device argument to nxapi command arguments	2015-12-08 10:24:07 -05:00
David L Ballenger	970d7cadb7	Add ssh_host support for MacOSX El Capitan. ... OS X El Capitan moved the /etc/ssh_* files into /etc/ssh/. This fix adds a distribution version check for Darwin to set the keydir appropriately on El Capitan and later.	2015-12-08 07:11:02 -08:00
Brian Coca	9ae1dede03	adhoc does not load plugins by default ... reimplemented feature from 1.x which kept additional callbacks from poluting adhoc unless specifically asked for through configuration.	2015-12-08 06:37:57 -08:00
Brian Coca	17b334d4a5	Merge pull request #13450 from privateip/feature_ios_shared_module ... bugfix for ios.py shared module argument creation	2015-12-07 09:59:04 -05:00
James Cammarata	540cbe0f64	Merge pull request #13445 from n-st/tasks-string-repr ... More meaningful string representation for meta tasks (like 'noop' and 'flush_handlers')	2015-12-07 08:10:54 -05:00
James Cammarata	2884ff3932	Merge pull request #13455 from Yannig/devel_fix_debug_var_when_content_same_as_name ... Fix issue when var name is the same as content.	2015-12-07 08:02:22 -05:00
Yannig Perré	2c8eee956f	Fix issue when var name is the same as content. ... See https://github.com/ansible/ansible/issues/13453 for more details.	2015-12-07 09:25:37 +01:00
Toshio Kuratomi	4d637e5780	Use self.args when we parse arguments that way the arguments can be constructed manually	2015-12-06 22:17:47 -08:00
Toshio Kuratomi	a8e015cc22	Add representers so we can output yaml for all the types we read in from yaml	2015-12-06 22:17:47 -08:00
Peter Sprygada	41773630ed	adds new device argument to nxapi command arguments ... The device argument allows a dict of nxapi parameters to be passed to the module to simplify passing the nxapi parameters	2015-12-05 22:51:40 -05:00
Brian Coca	8607aa527d	Merge pull request #13446 from lberruti/no_target_syslog ... Make no_target_syslog consistent.	2015-12-05 16:08:00 -05:00
Brian Coca	955710267c	only set become defaults at last possible moment ... tasks were overriding commandline with their defaults, not with the explicit setting, removed the setting of defaults from task init and pushed down to play context at last possible moment. fixes #13362	2015-12-05 16:03:50 -05:00
Luca Berruti	8ea45e8608	Make no_target_syslog consistent. ... no_target_syslog = False --> do log on target	2015-12-05 19:43:02 +01:00
Brian Coca	f89f906f87	simplified get_hosts code to have 1 retrun point	2015-12-05 10:10:25 -05:00
Nils Steinger	a1f6d17e37	More meaningful string representation for meta tasks (like 'noop' and 'flush_handlers')	2015-12-05 15:55:39 +01:00
Nils Steinger	0129fb0a44	Remove duplicates from host list *before* caching it ... Ansible previously added hosts to the host list multiple times for commands like `ansible -i 'localhost,' -c local -m ping 'localhost,localhost' --list-hosts`. 8d5f36a fixed the obvious error, but still added the un-deduplicated list to a cache, so all future invocations of get_hosts() would retrieve a non-deduplicated list. This caused problems down the line: For some reason, Ansible only ever schedules "flush_handlers" tasks (instead of scheduling any actual tasks from the playbook) for hosts that are contained in the host lists multiple times. This probably happens because the host states are stored in a dictionary indexed by the hostnames, so duplicate hostname would cause the state to be overwritten by subsequent invocations of … something.	2015-12-05 15:54:08 +01:00
Toshio Kuratomi	c8fd599e14	Merge pull request #13373 from no2a/boolean ... BOOLEAN should contain boolean literals	2015-12-04 12:17:12 -08:00
Toshio Kuratomi	0434644d12	Transform exceptions into ansible messages via to_unicode instead of str to avoid tracebacks. ... Fixes #13385	2015-12-04 11:50:39 -08:00
James Cammarata	84507aedd4	Adding a uuid field so we can track host equality across serialization too	2015-12-04 13:33:27 -05:00
James Cammarata	750adbaa27	Changing up how host (in)equality is checked ... Fixes #13397	2015-12-04 12:57:46 -05:00
Toshio Kuratomi	e385c91fa5	Update submodule refs#	2015-12-04 09:57:06 -08:00
Brian Coca	d5446f9804	fixed ansible-pull broken options ... * sudo was not working, now it supports full become * now default checkout dir works, not only when specifying * paths for checkout dir get expanded * fixed limit options for playbook * added verbose and debug info	2015-12-03 20:47:02 -08:00
Brian Coca	e1c62fb5af	reverted to previous pull checkout dir behaviour ... This fixes bugs with not finding plays when not specifying checkout dir Also makes it backwards compatible	2015-12-03 19:42:05 -08:00
Brian Coca	8d5f36a6c2	return unique list of hosts	2015-12-03 19:39:57 -08:00
Thomas Steinbach	349fb42f54	Allow setup of docker remote connections	2015-12-04 03:24:44 +01:00
Brian Coca	a1f516824e	corrected playbook path, reformated options help ... the last just to make the help consistent and readable	2015-12-03 18:23:53 -08:00
Brian Coca	26520442bd	Now and/or shell expressions depend on shell plugin ... This should fix issues with fish shell users as && and || are not valid syntax, fish uses actual 'and' and 'or' programs. Also updated to allow for fish backticks pushed quotes to subshell, fish seems to handle spaces w/o them. Lastly, removed encompassing subshell () for fish compatibility. fixes #13199	2015-12-03 16:38:34 -08:00
James Cammarata	f467f1770f	Properly compare object references for Hosts when adding new ones ... Fixes #13397	2015-12-03 15:25:54 -05:00
James Cammarata	4426b7f6e0	fix sorting of groups for host vars ... Fixes #13371	2015-12-03 14:23:02 -05:00
Brian Coca	7d073bdd17	Merge pull request #13345 from amenonsen/extract ... Add an 'extract' filter	2015-12-03 11:19:06 -08:00
Peter Sprygada	29f5c5db71	bugfix for ios.py shared module argument creation ... This patch fixes a bug in module_utils/ios.py where the the wrong shared module arguments are being generated. This bug prevented the shared module from operating correctly. This patch should be generally applied.	2015-12-03 12:53:07 -05:00
James Cammarata	5f83a6aeda	Properly default remote_user for delegated-to hosts ... Fixes #13323	2015-12-03 11:31:33 -05:00
Toshio Kuratomi	e201a255d1	Revert "Make sudo+requiretty and ANSIBLE_PIPELINING work together" ... This reverts commit f488de8599. Reverting for now due to hard to pin down bugs: #13410 #13411	2015-12-03 08:01:05 -08:00
Toshio Kuratomi	9b81c35d06	Don't compare or merge str with unicode ... Fixes #13387	2015-12-02 20:53:50 -08:00
James Cammarata	a183972477	Don't use play vars in HostVars ... Fixes #13398	2015-12-02 14:16:47 -05:00
James Cammarata	8ff67e0494	Default msg param to AnsibleError to avoid serialization problems	2015-12-02 14:16:47 -05:00
James Cammarata	5f1f2acfea	Merge pull request #13405 from sivel/v2-playbook-on-start ... Get v2_playbook_on_start working	2015-12-02 12:40:24 -05:00
Matt Martz	384b2e0234	Get v2_playbook_on_start working ... * Move self._tqm.load_callbacks() earlier to ensure that v2_on_playbook_start can fire * Pass the playbook instance to v2_on_playbook_start * Add a _file_name instance attribute to the playbook	2015-12-02 11:29:51 -06:00
Brian Coca	7708661270	Merge pull request #13402 from amenonsen/expandpath ... Use CLI.expand_tilde also for the vault --output file	2015-12-02 09:23:46 -08:00
Brian Coca	94d2958e1f	Merge pull request #13403 from amenonsen/module-lang ... Make module_lang default to whatever LANG is set to on the control node	2015-12-02 09:06:57 -08:00
Abhijit Menon-Sen	0d16d16ab8	Make module_lang default to whatever LANG is set to on the control node	2015-12-02 22:25:10 +05:30
Abhijit Menon-Sen	fac7626230	Use CLI.expand_tilde also for the vault --output file	2015-12-02 22:08:37 +05:30
Matt Martz	ce54a59cdc	Catch additional assertion errors for load_list_of_blocks	2015-12-02 10:35:20 -06:00
Brian Coca	53cd802251	better error on invalid task lists	2015-12-02 08:14:20 -08:00
James Cammarata	f7dc5a9515	Minor tweak and comment addition to 974a0ce3	2015-12-02 09:11:08 -05:00
James Cammarata	f1d53a87e5	Merge pull request #13394 from Christoph-D/issue-13370 ... Fix #13370	2015-12-02 08:57:09 -05:00
Abhijit Menon-Sen	8cf1815867	Add an 'extract' filter ... At its most basic, this is nothing more than an array or hash lookup, but when used in conjunction with map, it is very useful. For example, while constructing an "ssh-keyscan …" command to update known_hosts on all hosts in a group, one can get a list of IP addresses with: groups['x']|map('extract', hostvars, 'ec2_ip_address')|list This returns hostvars[a].ec2_ip_address, hostvars[b].ec2_ip_address, and so on. You can even specify an array of keys for a recursive lookup, and mix string and integer keys depending on what you're looking up: ['localhost']|map('extract', hostvars, ['vars','group_names',0])|first == hostvars['localhost']['vars']['group_names'][0] == 'ungrouped' Includes documentation and tests.	2015-12-02 18:16:38 +05:30
Abhijit Menon-Sen	22381be253	Bump version in devel now that stable-2.0 has been branched	2015-12-02 17:57:53 +05:30
Christoph Dittmann	267199fdd5	Update debug messages and comments ... The comment was taken literally from lib/plugins/strategy/linear.py and makes no sense in free.py where we have no noop tasks. Also update the debug messages.	2015-12-02 11:17:24 +01:00
Christoph Dittmann	c6e400fbea	Fix issue #13370 ... all_blocks is referenced after the loop over included_files, so it needs to be initialized before this loop, not inside.	2015-12-02 11:17:24 +01:00
Christoph Dittmann	9a6ae1d62a	Let PlayIterator.add_tasks accept empty task lists ... PlayIterator.add_tasks raised an error when trying to add an empty task list. This was the root cause of ansible issue #13370.	2015-12-02 11:17:24 +01:00
Brian Coca	b92cb93539	unconditionally set vars on init to avoid issues with var precedence	2015-12-01 21:24:46 -08:00
Peter Sprygada	2491afc8b6	fixes a syntax issue with module_utils/eapi.py ... This patch fixes an issue with the common args dict in the eapi shared module. This patch is required for the eapi shared module to be properly imported and is therefore should be applied to all instances.	2015-12-01 23:34:59 -05:00
Brian Coca	8c630406c9	Merge pull request #13357 from privateip/feature_ssh_shared_module ... initial add of ssh shared module.	2015-12-01 19:15:03 -08:00
Brian Coca	923b5467e3	Merge pull request #13354 from privateip/feature_eapi ... adds device common argument to shared module	2015-12-01 19:14:07 -08:00
Brian Coca	574d7be8d5	Merge pull request #13358 from privateip/feature_ios_shared_module ... Feature ios shared module	2015-12-01 19:04:24 -08:00
Peter Sprygada	93cd7a2a5f	adds module create function for eapi.py shared module ... This commit changes the way modules create an instance of AnsibleModule to now use a common function, eapi_module. This function will now automatically append the common argument spec to the module argument_spec. Module arguments can override common module arguments	2015-12-01 20:00:41 -05:00
Peter Sprygada	8638e0ccf8	initial add of the ios shared module ... This adds shared module support for building modules that connect to Cisco IOS devices. It builds on the module_utils/ssh.py shared module.	2015-12-01 19:55:41 -05:00
Brian Coca	3e01516783	fixed signature for init on callbacks ... also removed passing display to base class which already handles this	2015-12-01 14:06:54 -08:00
nitzmahone	c94509f273	allow shell plugin to affect remote module filename ... Fix for 13368, added get_remote_filename to shell plugins, powershell version appends .ps1 if necessary, base shell plugin no-ops	2015-12-01 13:39:02 -08:00
Abhijit Menon-Sen	f488de8599	Make sudo+requiretty and ANSIBLE_PIPELINING work together ... Pipelining is a *significant* performance benefit, because each task can be completed with a single SSH connection (vs. one ssh connection at the start to mkdir, plus one sftp and one ssh per task). Pipelining is disabled by default in Ansible because it conflicts with the use of sudo if 'Defaults requiretty' is set in /etc/sudoers (as it is on Red Hat) and su (which always requires a tty). We can (and already do) make sudo/su happy by using "ssh -t" to allocate a tty, but then the python interpreter goes into interactive mode and is unhappy with module source being written to its stdin, per the following comment from connections/ssh.py: # we can only use tty when we are not pipelining the modules. # piping data into /usr/bin/python inside a tty automatically # invokes the python interactive-mode but the modules are not # compatible with the interactive-mode ("unexpected indent" # mainly because of empty lines) Instead of the (current) drastic solution of turning off pipelining when we use a tty, we can instead use a tty but suppress the behaviour of the Python interpreter to switch to interactive mode. The easiest way to do this is to make its stdin *not* be a tty, e.g. with cat|python. This works, but there's a problem: ssh will ignore -t if its input isn't really a tty. So we could open a pseudo-tty and use that as ssh's stdin, but if we then write Python source into it, it's all echoed back to us (because we're a tty). So we have to use -tt to force tty allocation; in that case, however, ssh puts the tty into "raw" mode (~ICANON), so there is no good way for the process on the other end to detect EOF on stdin. So if we do: echo -e "print('hello world')\n"|ssh -tt someho.st "cat|python" …it hangs forever, because cat keeps on reading input even after we've closed our pipe into ssh's stdin. We can get around this by writing a special __EOF__ marker after writing in_data, and doing this: echo -e "print('hello world')\n__EOF__\n"|ssh -tt someho.st "sed -ne '/__EOF__/q' -e p|python" This works fine, but in fact I use a clever python one-liner by mgedmin to achieve the same effect without depending on sed (at the expense of a much longer command line, alas; Python really isn't one-liner-friendly). We also enable pipelining by default as a consequence.	2015-12-01 23:32:20 +05:30
Toshio Kuratomi	50553bc2ba	_connect no longer takes a port argument	2015-12-01 09:12:25 -08:00
Brian Coca	f1fcab4610	ignore password flags in become conflict check ... since all the --ask pass options end up triggering the same code and are functionally equivalent, ignore them when it comes to checking privilege escalation conflicts. This allows using -K when --become-method=su and so on.	2015-12-01 08:18:31 -08:00
Brian Coca	a6f6a80caa	avoid inheritance issues with default=dict declaration at class level ... this should avoid the issue of subsequent plays not prompting for a var prompted for in a previous play.	2015-12-01 08:18:31 -08:00
Toshio Kuratomi	30094912eb	boto is expecting that we pass it unicode strings. ... The secret_key parameter especially can contain non-ascii characters and will throw an error if such a string is passed as a byte str. Potential fix for #13303	2015-12-01 07:03:57 -08:00
Arata Notsu	6d6d4f0c8e	BOOLEAN should contain boolean literals ... It is natural that an argument_spec with choises=BOOLEAN accepts boolean literal (True, False) though the current implementation allows only string or int.	2015-12-01 23:51:39 +09:00
Toshio Kuratomi	ba4e571029	Update submodule refs to go along with the StandardError change in ec2 moudles	2015-11-30 19:05:33 -08:00
Toshio Kuratomi	19d5759771	raise AnsibleAWSError instead of StandardError. ... * StandardError doesn't exist in python3 * because it is the root of builtin expections, we can't catch it separate from the builtin exceptions * It doesn't tell us anything about the error being thrown as it's too generic	2015-11-30 19:05:33 -08:00
James Cammarata	dc0fae1af7	Also make sure remote_user is defaulted correctly for delegated hosts ... Fixes #13323	2015-11-30 16:15:14 -05:00
Toshio Kuratomi	e2ddc2f6ab	Call the function :-) ... Fixes #13330	2015-11-30 12:34:20 -08:00
James Cammarata	cc36eedf76	Ensure port is (re)set for delegated-to hosts ... Fixes #13265	2015-11-30 14:40:23 -05:00
Brian Coca	b5f2c3def2	fixed typo	2015-11-30 09:20:59 -08:00
Brian Coca	eefb4931dd	allow for bad stdout return from make temp dir command ... fixes #13359	2015-11-30 09:19:16 -08:00
Brian Coca	005b17afec	corrected become_methods class variable in winrm ... This should now correctly react when using become with winrm fixes #13331	2015-11-30 08:35:08 -08:00
James Cammarata	80db6bacc4	Make sure run_once tasks properly set variables for all active hosts ... Fixes #13267	2015-11-30 11:27:05 -05:00
James Cammarata	fbc9553bd4	Use text_type instead of unicode	2015-11-30 10:33:36 -05:00
James Cammarata	c6a30f7000	Make sure the uuid in vars is string	2015-11-30 10:26:12 -05:00
James Cammarata	f926e81782	Re-implement lookup wantlist ... Fixes #13285	2015-11-29 23:45:54 -05:00
James Cammarata	dfa576b037	Merge pull request #13307 from Yannig/devel_fix_big_include_vars ... Fix for https://github.com/ansible/ansible/issues/13221	2015-11-29 23:14:03 -05:00
Peter Sprygada	c087160652	initial add of ssh shared module. ... This ssh shared module is used for building modules that require an interactive shell environment such as those required for connecting to network devices	2015-11-29 21:48:52 -05:00
James Cammarata	6671d78f95	Tweak location of stats callback execution and properly relocate stats output code	2015-11-28 14:03:21 -05:00
James Cammarata	ea23159be4	Merge pull request #13348 from emonty/bug/iterate-on-none ... Put in trap for args being None	2015-11-28 13:44:09 -05:00
Monty Taylor	d20e67d708	Put in trap for args being None ... _normalize_old_style_args can return None. If it does, the loop "for args in args" blows up.	2015-11-28 13:38:11 -05:00
James Cammarata	800811a15f	Trigger on_stats just once, not once for each play ... Fixes #13271	2015-11-28 13:37:43 -05:00
James Cammarata	a7f7f8bd29	Merge pull request #13297 from amenonsen/ssh-escalation ... Explicitly accept become_success in awaiting_prompt state	2015-11-28 10:03:00 -05:00
James Cammarata	5b6162a166	Re-adding role_name/role_uuid variables	2015-11-28 09:08:24 -05:00
James Cammarata	8d9835c40b	Merge pull request #13342 from Yannig/devel_fix_bomb_shell ... Devel fix bomb shell	2015-11-28 09:02:12 -05:00
Yannig Perré	5227c6bb52	Do not copy variable_manager each time. Instead, keep host and local variable_manager sync. ... Fix https://github.com/ansible/ansible/issues/13221	2015-11-28 14:58:33 +01:00
Yannig Perré	2fc7c8b460	More restrictive test against variable name to allow setting variable starting with _.	2015-11-28 10:35:06 +01:00
Brian Coca	fa358d9d61	avoids prompting for vars during syntax check ... fixes #13319	2015-11-27 11:41:00 -08:00
Yannig Perré	2c54fb1339	Switch parameters validation after parsing in order to be more consistent between old and new style.	2015-11-26 13:33:58 +01:00
Abhijit Menon-Sen	f20e2630b0	Explicitly accept become_success in awaiting_prompt state ... If we request escalation with a password, we start in expecting_prompt state. If the escalation then succeeds without the password, i.e., the become_success response arrives, we must explicitly move into the next state (awaiting_escalation, which immediately goes into ready_to_send), so that we no longer try to apply the timeout. Otherwise, we would leak the success notification and eventually timeout. But if the module response did arrive before the timeout expired, the "process has already exited" test would do the right thing by accident (which is why it didn't fail more often). Fixes #13289	2015-11-26 06:06:01 +05:30
Toshio Kuratomi	1b743436b9	Do not double transform to unicode	2015-11-25 07:48:52 -08:00
Chrrrles Paul	157230c3e8	Merge pull request #13257 from chrrrles/utf8 ... fixing error with using non-ascii values for ask-sudo-password	2015-11-25 11:52:17 +09:00
Charles Paul	1e5a205389	fixing errors with utf-8 values ... removing utf-8 stanza changing cast to binary_type instead using to_unicode	2015-11-25 11:47:25 +09:00
Brian Coca	71fe49ee3a	Merge pull request #13247 from bcoca/fetch_fixes ... fixes to fetch action module	2015-11-24 10:55:23 -08:00
Brian Coca	7244b5ae49	added missing :	2015-11-25 10:52:42 -08:00
Brian Coca	0ec60ac09b	added missing events to base class	2015-11-25 10:49:03 -08:00
James Cammarata	70de8bc96f	Fix ssh state issues by simply assuming it's never connected	2015-11-24 12:00:37 -05:00
James Cammarata	65747285a4	Properly check for prompting state when re-using ssh connection ... Fixes #13278	2015-11-24 09:09:54 -05:00
James Cammarata	96fcfe45d0	Merge pull request #13264 from Yannig/devel_debug_var_list_or_dict ... Allow debug var parameter to accept a list or dict.	2015-11-23 16:47:45 -05:00
Yannig Perré	5fa49a9ad8	Use to_unicode instead of str()	2015-11-23 22:04:55 +01:00
James Cammarata	679488fdb5	Merge pull request #13239 from sysreq0/devel ... We should give pipes.quote() a string every time	2015-11-23 14:27:26 -05:00
James Cammarata	53e86f3130	Merge pull request #13261 from cchurch/with_items_reuse_connection ... Modify task executor to reuse connections inside a loop.	2015-11-23 13:57:12 -05:00
James Cammarata	e06b107d2d	Template (and include vars) PlaybookInclude paths ... Fixes #13249	2015-11-23 11:54:06 -05:00
Chris Church	272778f732	Modify task executor to reuse connection inside a loop. Fix WinRM connection to set _connected properly and display when remote shell is opened/closed. Add integration test using raw + with_items.	2015-11-23 11:53:05 -05:00
Toshio Kuratomi	adf2d53fa2	Update submodule refs	2015-11-23 08:41:19 -08:00
Yannig Perré	0480b44f50	Allow debug var parameter to accept a list or dict. Fix https://github.com/ansible/ansible/issues/13252	2015-11-23 16:58:24 +01:00
Brian Coca	478c6c756a	marked spot that should send per item reulsts	2015-11-22 14:44:51 -08:00
Brian Coca	fb96748d7c	fixes to fetch action module ... * now only runs remote checksum when needed (fixes #12290) * unified return points to simplify program flow	2015-11-22 09:52:34 -08:00
Toshio Kuratomi	2631a8e6e4	Update extras to fix docs build	2015-11-20 14:14:12 -08:00
Toshio Kuratomi	8fd15ae2a3	Merge pull request #13217 from ansible/more-strict-plugin-lookup ... Fix non-module plugins picking up files that did not end in .py.	2015-11-20 13:50:45 -08:00
Toshio Kuratomi	77c83fd520	Commit submodule refs to the devel HEAD	2015-11-20 12:46:22 -08:00
Toshio Kuratomi	664c7980a2	Update submodule refs	2015-11-20 12:42:44 -08:00
Sebastien Couture	087dbc1ed5	We should give pipes.quote() a string every time	2015-11-20 12:58:50 -05:00
Toshio Kuratomi	591c81e95f	Docker cp sets file ownership to root:root so we can't use it. ... Fixes #13219	2015-11-20 07:45:00 -08:00
Toshio Kuratomi	d75e707af5	Simplify code a little	2015-11-19 09:55:06 -08:00
Toshio Kuratomi	72558f7ecd	Merge pull request #13074 from joernheissler/patch-13073 ... Use ansible_host in synchronize module	2015-11-19 09:51:43 -08:00
Toshio Kuratomi	c86120cea6	Fix non-module plugins picking up files that did not end in .py. ... This was caused by accessing the cache using the passed in mod_type rather than the suffix that we calculate with knowledge of whether this is a module or non-module plugin.	2015-11-19 09:39:37 -08:00
James Cammarata	c97c101bd3	Merge pull request #13209 from nitzmahone/winrm_put_file ... fast winrm put_file without size restrictions	2015-11-19 09:58:06 -05:00
James Cammarata	8a0d2e0ef2	Submodule pointer update	2015-11-19 09:08:49 -05:00
James Cammarata	91500f8f5f	Fix include param precedence in variable manager	2015-11-19 09:01:51 -05:00
James Cammarata	78e4f176e6	Return skipped/failed async results directly ... Fixes #13205	2015-11-19 08:30:00 -05:00
James Cammarata	3b16ad973c	Merge pull request #13201 from ma82/patch-1 ... Fix DataLoader's docstring	2015-11-19 08:13:02 -05:00
Marius Gedminas	66347c9449	Fix NameError when using loops ... vars_copy disappeared in 3d1255d190. Fixes #13213.	2015-11-19 09:21:06 +02:00
nitzmahone	db83c0e7cd	winrm error handling tweaks	2015-11-18 23:09:16 -08:00
James Cammarata	3d1255d190	Don't update job vars too early when getting loop items in TaskExecutor ... Fixes #13113	2015-11-18 19:12:38 -05:00
Brian Coca	f8ed99e5e4	Revert "success should not include skipped" ... This reverts commit 300ee227a2.	2015-11-19 11:12:18 -08:00
nitzmahone	549163170f	fast winrm put_file without size restrictions	2015-11-18 10:33:45 -08:00
Mick Bass	9761250a4b	Allow tree-ish to be used for galaxy role version ... Ensure that ansible-galaxy version can be a branch, a tag, or any tree-ish supported by git including specific commit IDs. For git scm roles, adds an explicit git checkout of the specified role_version prior to the git archive. This means that we'll always archive from HEAD of whatever role_version is checked out. role_version can be a branch, a tag, or any <tree-ish> supported by git including specific commit IDs. These changes also ensure ansible-galaxy works for scm clones when specified version differs from repository default branch.	2015-11-18 20:47:15 +10:00
Matteo Acerbi	0127d32652	Fix DataLoader's docstring ... DataLoader.__init__ doesn't take an argument named vault_password	2015-11-18 11:20:34 +01:00
James Cammarata	9b9fb51d9d	Template the final_environment value in _compute_environment_string() ... Fixes #13123	2015-11-17 15:39:03 -05:00
Toshio Kuratomi	782aa9a7fd	Update submodule refs	2015-11-17 12:09:46 -08:00
James Cammarata	180159b01d	Adding vars back in and trying to add a little more speed by avoiding copies	2015-11-17 14:44:46 -05:00
James Cammarata	25807f5404	Don't modify things we've put on the queue ... Fixes #12937	2015-11-17 14:22:52 -05:00
Brian Coca	d35f615af8	added more debug info for command results	2015-11-18 11:18:03 -08:00
Brian Coca	aa55db69fe	Merge pull request #12687 from nitzmahone/pywinrm_arg_passthru ... Force SSL transport for pywinrm updates, get host+group vars	2015-11-17 11:14:19 -08:00
James Cammarata	f10d2c57c8	Restoring templating of hostvars returned by __getitem__	2015-11-17 10:19:56 -05:00
James Cammarata	9f31c073fe	Fixing a few bugs in the HostVars performance areas ... * Also refresh inventory in the HostVars manager process when things are changed via add_host/group_by * Raise j2undefined rather than return it	2015-11-17 09:15:10 -05:00
James Cammarata	984729016e	Fix tag filtering on included files and add more debugging ... Previously, we were filtering the task list on tags for each host that was including the file, based on the idea that the variables had to include the host information. However, the top level task filtering is play-context only, which should also apply to the included tasks. Tags cannot and should not be based on hostvars.	2015-11-16 17:15:52 -05:00
James Cammarata	5cbeab5a3c	Performance improvements for HostVars and some bugfixes	2015-11-16 17:15:52 -05:00
Dann Bohn	7f2cae5405	add REPLACER_SELINUX back into module_common	2015-11-16 16:35:55 -05:00
Brian Coca	355fa4797a	Merge pull request #13186 from nitzmahone/add_host_cache_fix ... fix for dynamic (add_host) hosts not available in hostvars	2015-11-16 12:01:00 -08:00
Brian Coca	6a2559be02	Merge pull request #13184 from nitzmahone/hostvars_undefined_fix ... hostvars should return j2 undefined as instance, not type	2015-11-16 11:59:20 -08:00
Toshio Kuratomi	fc7e2912f2	zone connection plugin bugfixes and pipelining and sudo become methods enabled! ... Thanks to peinheber for helping test and debug this!	2015-11-16 11:14:13 -08:00
nitzmahone	349e072a74	fix for dynamic (add_host) hosts not available in hostvars ... Looks like there are two pattern caches that need to be cleared for this to work- added the second one. Added integration tests for add_host to prevent future regressions.	2015-11-16 10:53:10 -08:00
nitzmahone	3bb1f7a561	hostvars should return j2 undefined as instance, not type ... Looks like someone forgot to create an instance of undefined here- we were returning the undefined type object, which broke all the undefined checks. Added an integration test around add_host that will catch this (separate PR to follow)	2015-11-16 09:58:23 -08:00
Brian Coca	db27541a0e	Merge pull request #13053 from Etherdaemon/fix_13010_boto3_aws_profile ... Fixes #13010 by updating boto3 methods	2015-11-16 09:46:26 -08:00
Brian Coca	89646d4253	no need to be executable	2015-11-16 14:40:35 -08:00
Jonathan Davila	1b76a9cef2	Patch to remove dependency on boto when only using boto3 ... Updated with explicit check for HAS_BOTO3	2015-11-16 09:21:26 -05:00
Brian Coca	2083a2dffa	Merge pull request #13174 from sebi-hgdata/sebi/consul_kv_issue ... Consul kv lookup super invocation fix	2015-11-15 14:37:51 -08:00
Brian Coca	83f7942dcf	removed print entries, corrected display calls to match latest devel	2015-11-16 11:35:10 -08:00
Brian Coca	78be81b96d	Merge pull request #12510 from jcftang/devel ... Initial add of logentries callback plugin	2015-11-15 11:28:02 -08:00
Brian Coca	f1db99caa7	updated with latest changes to default	2015-11-15 10:09:24 -08:00
Brian Coca	eeedaf2cbc	fixed var name typo	2015-11-15 08:43:42 -08:00
Brian Coca	e174247734	evaluate includes for skipped tags ... cannot evaluate for include tags as underlying tasks might have them, but skips override so this should be a performance boost	2015-11-15 07:51:36 -08:00
Sebi Calbaza	1f052d5ce6	fixed super invocation	2015-11-15 13:48:40 +02:00
Brian Coca	300ee227a2	success should not include skipped ... fixes #13161	2015-11-14 14:39:42 -08:00
Jimmy Tang	19ba54c9fd	Don't be fatal on import errors so plays don't fail if plugin doesn't have required dependencies	2015-11-14 20:02:03 +00:00
Jimmy Tang	125370ab48	Run when whitelisted	2015-11-14 19:46:00 +00:00
Jimmy Tang	5f2f5e2b59	Add boilerplate and fix initialisation to match what 2.0 expects	2015-11-14 08:54:41 +00:00
Jimmy Tang	c02ceb8f12	Remove threading and queues. Added license information and cleaned up callback.	2015-11-14 08:40:16 +00:00
Jimmy Tang	85277c8aae	Initial add of logentries callback plugin ... This callback plugin will generate json objects to be sent to the logentries service for auditing/debugging purposes. To use: Add this to your ansible.cfg file in the defaults block [defaults] callback_plugins = ./callback_plugins callback_stdout = logentries callback_whitelist = logentries Copy the callback plugin into the callback_plugings directory Either set the environment variables export LOGENTRIES_API=data.logentries.com export LOGENTRIES_PORT=10000 export LOGENTRIES_ANSIBLE_TOKEN=dd21fc88-f00a-43ff-b977-e3a4233c53af Or create a logentries.ini config file that sites next to the plugin with the following contents [logentries] api = data.logentries.com port = 10000 tls_port = 20000 use_tls = no token = dd21fc88-f00a-43ff-b977-e3a4233c53af	2015-11-14 08:40:16 +00:00
James Cammarata	07b588f6c0	Version bump for new beta 2.0.0-0.5.beta3	2015-11-13 16:48:25 -05:00
James Cammarata	2b25b7974c	Remove unnecessary sleep from result process	2015-11-13 16:45:45 -05:00
Brian Coca	634e10e5b8	Merge pull request #13156 from amenonsen/broken-timeout ... If ssh died, it's an error, not a timeout	2015-11-13 10:45:21 -08:00
Abhijit Menon-Sen	26ea9c4351	If ssh died, it's an error, not a timeout	2015-11-13 20:10:08 +05:30
David M. Lee	5bd096208c	Increase the escalation prompt timeout ... It was set to match the SSH connect timeout. Unfortunately, they would race when ssh fails to connect, and the connect timeout usually failed. This led to some misleading error messages. Fixes #12916	2015-11-13 08:02:37 -06:00
James Cammarata	31b1abf580	Merge pull request #13146 from nitzmahone/gce_error_messaging ... fix gce module error reporting	2015-11-13 08:46:51 -05:00
nitzmahone	4163655099	fix gce module error reporting ... Error reporting was broken for GCE modules- pprint didn't work with exceptions, so you'd always get "Unexpected response: {}" instead of the real error.	2015-11-12 16:30:46 -08:00
Toshio Kuratomi	958fb29b78	Merge pull request #12881 from Scypho/devel ... fix for issue #11885 - allowing json in lookup template calls	2015-11-12 15:39:35 -08:00
James Cammarata	13750f68ee	Reduce spinning while waiting on queues	2015-11-12 14:41:09 -05:00
Daniel Menet	0918416b83	substitute tilde and env vars before storing C.CACHE_PLUGIN_CONNECTION as instance attribute	2015-11-12 16:52:02 +01:00
Toshio Kuratomi	7fd8b86a10	Fix documentation build problems	2015-11-11 12:39:06 -08:00
Toshio Kuratomi	d38ac6a394	Update submodule ref for another new module	2015-11-11 12:33:32 -08:00
Toshio Kuratomi	7807e99bca	A bunch of shipit's merged	2015-11-11 12:19:34 -08:00
Toshio Kuratomi	8aa2cbd647	Fix traceback because we're using display from another object that no ... longer has it.	2015-11-11 12:19:00 -08:00
James Cammarata	b2b0fa8d13	Changed do/until failed color ... Fixes #13130	2015-11-11 14:43:15 -05:00
James Cammarata	94c20c9ac6	Cleanup failed/changed logic in TaskExecutor ... Fixes #12980	2015-11-11 14:23:37 -05:00
Toshio Kuratomi	62979efa14	Finish up plugin porting to global display ... Also remove display = display which does nothing	2015-11-11 10:44:23 -08:00
Toshio Kuratomi	2bd695ed42	Port cache plugins to global display	2015-11-11 10:44:22 -08:00
Toshio Kuratomi	b05d0b8c9c	Port lookup plugins to global display.	2015-11-11 10:44:22 -08:00
Toshio Kuratomi	4c7128da17	Port action plugins to global display	2015-11-11 10:44:22 -08:00
Toshio Kuratomi	186e034515	Move the rest of executor code to global display	2015-11-11 10:44:22 -08:00
Toshio Kuratomi	7ecfa072da	Move the rest of the playbook code to use global display	2015-11-11 10:44:22 -08:00
Toshio Kuratomi	aa4f213cb5	Move connection plugins to using global display	2015-11-11 10:44:22 -08:00
Toshio Kuratomi	318bfbb207	Migrate cli and dependencies to use global display	2015-11-11 10:44:22 -08:00
Brian Coca	1b7d3f2898	updated submodule refs	2015-11-12 09:41:51 -08:00
Brian Coca	99f45f2e19	pass task args without filtering, copy module needs to explcitly support ... remote_src or it will remove the src file	2015-11-12 09:40:43 -08:00
Toshio Kuratomi	c7b69127ec	Remove dead code	2015-11-11 08:12:21 -08:00
Toshio Kuratomi	e45ce871a7	Fix for traceback when neither name nor pkg are in the module params	2015-11-11 07:32:21 -08:00
Toshio Kuratomi	4737305837	Remove dead code as this was moved to another class	2015-11-10 12:18:20 -08:00
Brian Coca	be22a670e5	addes deprecated information to ansible-doc display ... fixes #13118	2015-11-11 11:15:22 -08:00
Brian Coca	1b349fdf34	Merge pull request #13112 from privateip/eapi ... add initial support for Arista eAPI	2015-11-10 10:31:26 -08:00
James Cammarata	566144461f	Remove internal use of display and use the top-level import	2015-11-10 12:02:29 -05:00
James Cammarata	0fc187893d	Catch import warnings in a common location for both get() and all() ... Potential solution for #12979	2015-11-10 11:25:07 -05:00
James Cammarata	9f0c2cfda5	Merge pull request #13114 from mgedmin/fix-plugin-loader ... Check sys.modules before loading modules	2015-11-10 11:04:35 -05:00
Marius Gedminas	54eae4a793	Check sys.modules before loading modules ... Code for a plugin is usually loaded by a PluginLoader(), and henceforth available from self._module_cache, which prevents duplicate loading. However there are situations (e.g. where one action plugin imports code from another one) where the plugin module might be already imported (and resident in sys.modules), but not present in the PluginLoader's _module_cache, which causes imp.load_source() to effectively reload the module, overwriting global class declarations and causing subtle latent bugs. Fixes #13110. Fixes #12979.	2015-11-10 17:57:43 +02:00
James Cammarata	a99f2fd52f	Save delegated vars in result for use in callback methods ... Fixes #13014	2015-11-10 10:14:30 -05:00
Peter Sprygada	2e98f7f429	add initial support for Arista eAPI ... This commit adds the shared module support for Arisat EOS devices running eAPI. The shared module builds on top of module_utils/urls.py.	2015-11-10 07:59:59 -06:00
James Cammarata	e56fd9e95d	Make sure pattern cache components are converted to unicode	2015-11-10 08:28:45 -05:00
James Cammarata	0b999c602a	Properly figure subset and restrictions into host cache pattern ... Fixes #13111	2015-11-10 08:23:51 -05:00
James Cammarata	d8fb5efa90	Merge pull request #13102 from Yannig/devel_cache_enhancement ... New method template_no_cache for template object.	2015-11-10 02:23:42 -05:00
Yannig Perré	0c360d17cb	New parameter for template method. ... We do not compute hash when we know that the result does not need to be cached (like with_items loop). It also result in a small speed improvement.	2015-11-10 07:19:19 +01:00
Etherdaemon	27398131cf	Fixes #13010 by updating boto3 methods to update boto3_conn to check for profile_name and if detected, remove from params and set a new variable of profile which is passed into Session separately	2015-11-10 15:22:07 +10:00
James Cammarata	09994c18f3	Correct logic around determining environment variable existence ... Fixes #13105	2015-11-09 21:04:24 -05:00
James Cammarata	c753ae6e22	Fixing up host pattern caching to avoid bugs ... * Always cache and return unique list objects, so that if the list is changed later it does not impact the cached results * Take additional parameters and the type of the pattern into account when building the hash string	2015-11-09 20:55:13 -05:00
James Cammarata	e8f83dcba3	Revert "Temporarily disable template caching" ... This reverts commit 4d1757ce64.	2015-11-09 20:41:59 -05:00
James Cammarata	4d1757ce64	Temporarily disable template caching	2015-11-09 17:09:13 -05:00
Toshio Kuratomi	995db275f8	Update submodule refs	2015-11-09 13:48:34 -08:00
Toshio Kuratomi	db5d3f03a9	Fix first_found not finding files in roles (only templates)	2015-11-09 13:47:17 -08:00
James Cammarata	ccbcfcddfc	Move where we add environment and make it conditional on not existing ... Also displays a warning now, because users should not be using that variable name as it causes a collision with the internal variable of the same name.	2015-11-09 16:28:54 -05:00
Brian Coca	37ae243587	made get_file_lines rely on get_file_content which deals with many error ... conditions that the former did not.	2015-11-10 13:22:45 -08:00
ghislainbourgeois	eb850d7e5b	Fix get_dns_facts on inexistent resolv.conf	2015-11-09 15:02:03 -05:00
James Cammarata	e36b4e2a13	Merge pull request #13072 from Yannig/devel_cache_optimization ... Cache optimization	2015-11-09 14:54:06 -05:00
James Cammarata	76ae577519	Ensure environment is inherited properly (task->block/include->play)	2015-11-09 14:51:07 -05:00
James Cammarata	937584cd52	Ensure 'environment' is set in the magic variables ... Fixes #13033	2015-11-09 14:50:39 -05:00
James Cammarata	7e04947599	Be more selective about what variables we cache during templating ... Fixes #13087	2015-11-09 14:07:48 -05:00
Toshio Kuratomi	1a04f354f3	For with_first_found loops, set undefined variables to fall through rather than failing the task	2015-11-09 10:51:54 -08:00
Brian Coca	240acb1924	Merge pull request #13092 from privateip/nxapi ... initial shared module support for nxapi	2015-11-09 08:43:30 -08:00
Peter Sprygada	f88273eb87	changes the nxapi argument spec to require url_password	2015-11-09 09:45:26 -05:00
Peter Sprygada	d3d36eb766	fixes conditional statement for py24 compatibility	2015-11-09 09:36:17 -05:00
Peter Sprygada	64e139adb1	add initial support for Cisco NXAPI ... This commit adds the shared module support for Cisco NXAPI. The shared module builds on top of the urls shared module. The urls module provides the http/s transport. This module only supports the JSON request message format.	2015-11-09 09:18:38 -05:00
Rene Moser	1d59caed07	cloudstack: change order of tags handling, fixes update of tag value does not work	2015-11-08 20:27:01 +01:00
Rene Moser	3410a855b0	cloudstack: use jop polling in tag handling, fixes outdated tags returned. ... In some cases the async job did not finish fast enough, causing returning an unexpeded result.	2015-11-08 20:23:06 +01:00
Joern Heissler	647b92a79b	Use ansible_host in synchronize module ... Fixes #13073	2015-11-08 13:15:16 +01:00
Yannig Perré	12a6fb9633	Small speed improvement with huge inventory (100+ hosts).	2015-11-07 19:32:10 +01:00
James Cammarata	dd4ca66e1e	Make sure hostvars cache is recreated during serialization	2015-11-06 22:21:50 -05:00
James Cammarata	5040abaaf2	Merge branch 'devel_cache_for_do_template_call' of https://github.com/Yannig/ansible into Yannig-devel_cache_for_do_template_call	2015-11-06 22:04:52 -05:00
Brian Coca	9a25e16140	set corrected force default	2015-11-06 19:06:58 -05:00
Toshio Kuratomi	47f187b221	Update submodule refs	2015-11-06 10:30:42 -08:00
James Cammarata	59b67a2f68	Reset workers list when recreating processes ... Also renames some things to be more accurate	2015-11-06 12:10:15 -05:00
Brian Coca	5b84bd6b5d	Merge pull request #13056 from alxgu/sles_sap_family ... Add SLES_SAP as a Suse family	2015-11-06 08:58:31 -05:00
Brian Coca	226c7f4c7b	Revert "added setting of ansible_ssh_user to current user as backwards compatibilty issue" ... scope was wrong, this var should not be 'reset' here. This reverts commit c271c0eb04.	2015-11-06 08:31:56 -05:00
Brian Coca	9c24f88eca	updated forks comment	2015-11-06 08:31:56 -05:00
Rene Moser	768f2fe6d4	template: fix regression bug in template in case force=false ... Fixes regression bug, previously reported in #12844 fixed with 4b20884719 re-introduced with c64ac90560	2015-11-06 11:24:39 +01:00
Alexander Gubin	215fc12234	Add SLES_SAP as a Suse family	2015-11-06 09:42:39 +01:00
Brian Coca	5c7d717f31	made ansibledoc more consistent with term sizes, it now uses display class column calculations ... cleared up snippet display	2015-11-05 17:42:14 -05:00
James Cammarata	1027abd596	Cleaning up bugs related to perf improvement changes	2015-11-05 16:42:12 -05:00
James Cammarata	f10022dbd2	Fix use of add_tqm_variables	2015-11-05 16:30:03 -05:00
James Cammarata	efbc6054a4	Add variable compression option	2015-11-05 16:22:37 -05:00
James Cammarata	63c47fb271	Fixing up performance	2015-11-05 16:22:37 -05:00
Brian Coca	c64ac90560	fixed check mode change response in template ... fixes #13049	2015-11-05 15:55:19 -05:00
Brian Coca	483c25a609	Revert "switched host patterns to use sets, simplified logic which now uses buitins" ... need this to be lists, for order and other considerations This reverts commit 8e2f0b3f2c.	2015-11-05 15:41:17 -05:00
Brian Coca	88ba46aee0	Revert "fixed append to add" ... good change on top of bad This reverts commit 699f344e17.	2015-11-05 15:40:52 -05:00
Brian Coca	699f344e17	fixed append to add	2015-11-05 15:24:20 -05:00
Brian Coca	8e2f0b3f2c	switched host patterns to use sets, simplified logic which now uses buitins	2015-11-05 15:02:06 -05:00
Brian Coca	883f451158	fixed snippet display, short_desc is a string, not a list	2015-11-05 14:32:18 -05:00
Brian Coca	95604573ee	improved the message when there is no module path override	2015-11-05 14:32:18 -05:00
Brian Coca	f4912dd88a	added callback fallback to v1 methods for backwards compat with existing callbacks	2015-11-05 13:04:50 -05:00
Brian Coca	e2c56efca6	Merge pull request #12867 from bcoca/callback_whitelist_tweak ... make callbacks declare needing whitelisting	2015-11-05 12:58:05 -05:00
Toshio Kuratomi	4f6d4c6bf6	Set task_action when the action does not need to be templated ... Fixes #13042	2015-11-05 08:38:21 -08:00
Brian Coca	9753de35a7	Merge pull request #13038 from bcoca/min_forks_to_play ... use minimal number of forks	2015-11-05 11:22:15 -05:00
Toshio Kuratomi	586cbb9fda	Update core submodule ref	2015-11-04 19:44:42 -08:00
Toshio Kuratomi	483491ddfb	template the task_action before checking whether to optimize with_item loops for it. ... Fixes the second problem discovered in #12976	2015-11-04 19:41:55 -08:00
Toshio Kuratomi	9e758d3d97	Do not optimize with_items loop if the items are not strings ... The code isn't sophisticated enough to understand lists and dicts yet. This mirrors how 1.9.x handled non-string items so its not a regression. One portion of a fix for #12976	2015-11-04 18:48:41 -08:00
Brian Coca	931eb16e55	clearer selection of min value ... cleanup workers at each run to avoid stragglers	2015-11-04 17:28:08 -05:00
Yannig Perre	ccbdd6229a	Use static vars when computing host vars known to be static (inventory_hostname, inventory_dir etc.).	2015-11-04 22:16:14 +01:00
Yannig Perre	e0aa3ff232	Cache against hosts pattern (fix a part of problem describe in https://github.com/ansible/ansible/issues/13023).	2015-11-04 22:15:02 +01:00
Brian Coca	b44f1428d0	use minimal number of forks taking serial, forks and play patterns into account	2015-11-04 15:16:20 -05:00
Brian Coca	3c35655b52	removed serial as it is not avialable for fork control ... fixes #13037	2015-11-04 14:04:47 -05:00
Brian Coca	0abeff4511	better limiting of forks to lowest actual restriction	2015-11-04 12:47:10 -05:00
nitzmahone	113c4350e3	Force SSL transport for pywinrm updates, get host+group vars ... I PR'd a change to pywinrm to allow server certs to be ignored; but it's only on the SSL transport (which we were previously ignoring). For this to work more generally, we're also now pulling the named ansible_winrm_* args from the merged set of host/group vars, not just host_vars.	2015-11-04 09:31:43 -08:00
Lars Larsson	3289670a04	treat forks config parameter as max value instead of always creating that number of workers	2015-11-04 17:13:26 +01:00
Will Thames	91b6004149	Allow blank lines and comments/spaces in galaxy spec files ... Fixes #10641 again. (Regression) Added test to discourage future such regression.	2015-11-04 15:36:20 +10:00
Toshio Kuratomi	07d0d2720c	Update submodule refs	2015-11-03 14:13:16 -08:00
Toshio Kuratomi	9ce3adbeb1	remove assigned but unused variables in module_utils. ... These were mostly saving exceptions but not using them. Getting rid of those will help with eventually running modules via either python2.4 or python3.x.	2015-11-03 09:53:18 -08:00
Toshio Kuratomi	c08648999d	Remove some more unused stdlib deps.	2015-11-03 09:53:18 -08:00
Toshio Kuratomi	658ea053ea	Cleanup timer callback plugin's overwriting of modules it imported	2015-11-03 09:53:18 -08:00
Eric Johnson	dfad7c64fb	Allow PATCH to list of valid HTTP methods	2015-11-03 17:38:52 +00:00
Brian Coca	8d3da20302	fixed bsd service_mgr_facts using removed check_init fucntion	2015-11-03 11:43:50 -05:00
Yannig Perré	30f827d92d	Fix python3 test.	2015-11-03 11:52:09 +01:00
Abhijit Menon-Sen	7caefa5cd9	Fix typo	2015-11-03 10:57:48 +05:30
Toshio Kuratomi	a7d1a39b81	Update core submodule ref	2015-11-02 17:38:28 -08:00
Toshio Kuratomi	2df0022a3e	Update submodule refs	2015-11-02 17:12:16 -08:00
Brian Coca	eb04650ffb	Merge pull request #12162 from bcoca/service_mgr_facts ... fact gathering service_mgr info	2015-11-02 15:34:43 -05:00
Brian Coca	a1a5dadef6	remove uneeded module	2015-11-02 15:36:11 -05:00
Yannig Perré	130139dc80	Fix unicode issue introduced by previous commit.	2015-11-02 21:32:49 +01:00
Toshio Kuratomi	3219744d32	One more stdlib import in module_utils	2015-11-02 12:25:18 -08:00
Brian Coca	d194e2c788	check_systemd is not inline but a private fact function now	2015-11-02 15:23:47 -05:00
Brian Coca	e9efd008ed	moved distutils import to mac, darn solaris would complain in certain cases	2015-11-02 15:23:47 -05:00
Brian Coca	99d775a0c1	fact gathering service_mgr info ... also added dragonfly facts support	2015-11-02 15:23:47 -05:00
Yannig Perré	4a8d1703d4	New patch against hostvars.py. With this patch, Ansible run lose 50% of time. ... Little rewrite of previous patch to use sha1 signature. Use fail_on_undefined to compute sha1 signature.	2015-11-02 21:04:20 +01:00
Toshio Kuratomi	1bc75374dc	Add imports for stdlib modules that are used. ... This is cleanup that will aid us when we get ziploader implemented for 2.1	2015-11-02 12:02:26 -08:00
Toshio Kuratomi	107d025d8a	Update extras submodule ref for doc fixes	2015-11-02 11:39:57 -08:00
Toshio Kuratomi	99561e88d4	Update submodule refs	2015-11-02 10:56:39 -08:00
Brian Coca	79bf66336b	switched clean_data from hardcoded delimiters to actual currently set jinja2 environment delimiters	2015-11-02 09:00:56 -05:00
Yannig Perré	805f768dab	Clear cache when updating template variables.	2015-11-02 07:57:44 +01:00
Brian Coca	467c29e3db	show task path on 2 vs	2015-11-01 17:43:11 -05:00
Yannig Perré	87a9485b2f	Cache for _do_template call. May result in nice speed improvement (4-5 times faster).	2015-11-01 22:30:55 +01:00
Rene Moser	c09a34bb10	cloudstack: clean up unneeded ";"	2015-11-01 17:13:46 +01:00
Brian Coca	f528ad1848	added xbps pkg mgr to facts	2015-10-31 22:03:12 -04:00
Brian Coca	13bf62d0e6	remove deprecation for :, add ; functionality (its deprecated but it should work)	2015-10-31 16:35:40 -04:00
Brian Coca	d341ba14a5	fixed rekey password handling	2015-10-31 14:13:03 -04:00
Brian Coca	00bc74404a	vault noe preserves permissions on edit and rekey and sets a restricitve default umask for all other cases	2015-10-31 14:13:03 -04:00
Brian Coca	7368030651	removed action plugin as service facts and separate modules don't work yet and this forces gathering facts	2015-10-30 17:56:05 -04:00
Brian Coca	f5b095f6c8	properly sanitize registered vars	2015-10-30 16:42:06 -04:00
Brian Coca	b6c92dacb5	removed key striping as they are read up the chain	2015-10-30 14:03:37 -04:00
Brian Coca	57d3245d0d	remove commented out prints	2015-10-30 14:02:41 -04:00
Brian Coca	7ba4f5ee12	removed no_log redundant code	2015-10-30 14:01:47 -04:00
Brian Coca	b97887ba41	simplified invocation removal, added no_log awareness	2015-10-30 10:17:19 -04:00
James Cammarata	c61499168e	Merge pull request #12962 from bcoca/pull_fixes ... fixes options for ansible pull	2015-10-30 09:46:09 -04:00
James Cammarata	56e5e72aaa	Make handlers obey run_once (or BYPASS_HOST_LOOP) ... Fixes #12972	2015-10-30 09:44:35 -04:00
James Cammarata	a5bd92ca4b	Merge branch 'devel_fix_debug_var' of https://github.com/Yannig/ansible into Yannig-devel_fix_debug_var	2015-10-30 08:37:03 -04:00
Brian Coca	237f8c9df7	removed debug print	2015-10-29 20:34:55 -04:00
James Cammarata	479cbfc63c	Don't immediately fail on PlayContext setup ... As we may end up skipping the task due to conditionals. Fixes #12774	2015-10-29 19:23:42 -04:00
Brian Coca	9f148fc046	removed requirement of destination and set documented default	2015-10-29 16:28:46 -04:00
Brian Coca	40d22be2ef	fixes options for ansible pull ... * remove requirement for host patterns, use the defaults * require destination directory (None in cwd is not a good default) * fixed usage messages * updated default inventory to use , and not deprecated :	2015-10-29 16:28:46 -04:00
Brian Coca	b73941b95f	updated submodule refs	2015-10-29 16:06:33 -04:00
Toshio Kuratomi	508bffef02	Update extras submodule ref	2015-10-29 10:20:55 -07:00
Brian Coca	b8bc15fe02	switched to backticks to allow for non bourne shells to work	2015-10-29 12:45:53 -04:00
Yannig Perré	1febf7cb88	Fix for issue #12952: this code interfere with debug+var and seems to be unnecessary.	2015-10-28 22:09:13 +01:00
James Cammarata	5d92b00d9c	Cleanup some include logic ... * Properly mark hosts with failures in includes as failed * Don't send callbacks until we're sure we're done, and also fix how we increment stats so failures don't show up as ok's * Fix a bug in the include file logic where a failed include could lead to an infinite loop in the task iteration logic Fixes #12933	2015-10-28 14:02:24 -04:00
Toshio Kuratomi	56b310b18d	Update submodule refs	2015-10-28 09:04:52 -07:00
James Cammarata	299054852a	Allow tags to be specified in included file params ... Fixes #12940	2015-10-28 10:14:20 -04:00
Brian Coca	b2fc5142eb	moved sudo -S and -n into configurable flags as they might be absent in much older systems ... if password is supplied exsiting -n would get remove from flags	2015-10-28 02:06:25 -04:00
Toshio Kuratomi	e3e2db1119	Improve the warning message about duplicate yaml dict keys	2015-10-27 14:20:36 -07:00
James Cammarata	87269599a0	Also consider the full role name when searching for --start-at-task	2015-10-27 16:31:23 -04:00
Toshio Kuratomi	acbea65b1d	Update core submodule ref to fix doc build	2015-10-27 12:52:41 -07:00
Toshio Kuratomi	2c5da0923a	Update submodule refs	2015-10-27 12:50:24 -07:00
Toshio Kuratomi	7334389de6	Merge pull request #12930 from ansible/dict-key-overwrite-warning ... Break apart a looped dependency to show a warning when parsing playbooks	2015-10-27 12:44:01 -07:00
Toshio Kuratomi	4203850d1a	Break apart a looped dependency to show a warning when parsing playbooks ... Display a warning when a dict key is overwritten by pyyaml Fixes #12888	2015-10-27 12:39:42 -07:00
James Cammarata	3fc2209ca0	Fixing retry/until logic and default value for retries ... Fixes #12928 Fixes #12929	2015-10-27 15:37:48 -04:00
James Cammarata	57fe0d6aed	Merge pull request #12911 from bcoca/manpage_fixes ... Manpage fixes	2015-10-27 14:48:38 -04:00
James Cammarata	1dc23ea779	Merge pull request #12866 from bcoca/more_inheritence ... More inheritence	2015-10-27 14:46:42 -04:00
James Cammarata	cace91df56	Allow hostvars cache to be invalidated so hostvars contain all hosts after add_host ... Fixes #12925	2015-10-27 14:12:17 -04:00
James Cammarata	2825c188bd	Merge pull request #12901 from bcoca/sanitize_results ... sanatize results	2015-10-27 08:42:34 -04:00
Jason O'Donnell	9dfa3719be	Fixing typo	2015-10-26 17:13:49 -04:00
Jason O'Donnell	ac9b35cc2b	Found another typo	2015-10-26 17:04:28 -04:00
Jason O'Donnell	80433c2a2d	Fxing typo	2015-10-26 17:01:30 -04:00
Toshio Kuratomi	de54f26376	Update submodule refs	2015-10-26 13:13:11 -07:00
Brian Coca	c271c0eb04	added setting of ansible_ssh_user to current user as backwards compatibilty issue	2015-10-26 16:10:13 -04:00
Brian Coca	4486e136ea	Merge pull request #12899 from bcoca/vault_fixes ... simplified vault password functions	2015-10-26 14:14:17 -04:00
Brian Coca	5b33b0ddfd	Merge pull request #12896 from bcoca/ssh_current_user_config ... don't set user to current user	2015-10-26 13:26:43 -04:00
James Cammarata	677a2f95e5	Make sure Base attributes are copied cleanly ... Fixes #12882	2015-10-26 12:09:58 -04:00
Toshio Kuratomi	8f77dd1cf2	Update submodule refs	2015-10-26 08:37:37 -07:00
Brian Coca	f3a0adcfa5	added info about using -i 'hostname,' to usage/help	2015-10-26 11:03:15 -04:00
Bernhard Lichtinger	00ccd2ee6e	Fix for SLES 11.4, which has now also an /etc/os-release file.	2015-10-26 14:22:21 +01:00
Brian Coca	7ebfe72015	added missing string_types	2015-10-24 15:49:30 -04:00
Brian Coca	8ce864db6f	sanatize results	2015-10-24 15:23:12 -04:00
Brian Coca	368f4448dc	simplified vault password functions ... also fixes #12864	2015-10-24 15:06:43 -04:00
Toshio Kuratomi	92dd563a75	Fix invocation from bad merge and note where it would need to go to keep ... it out of registered vars as well.	2015-10-24 07:29:42 -07:00
Brian Coca	f78c82b9ee	don't set user to current user ... also remove condition to bypass setting user if user matches current user this enables forcing user when set to the same user as current user and ignoring .ssh/config while keeping .ssh/config with current user if nothing is specified.	2015-10-23 23:15:45 -04:00
Brian Coca	25e3fe04a8	finalized changed to use abridtged_result instead of result ... removed no longer defined no_log	2015-10-23 23:10:57 -04:00
Toshio Kuratomi	b109b83809	Update submodule refs	2015-10-23 14:34:40 -07:00
Toshio Kuratomi	ca32d5bacc	Potential fix for #12816	2015-10-23 13:38:44 -07:00
James Cammarata	3eea4e23d5	Manually add plugin directories when running the adhoc command ... Fixes #12891	2015-10-23 16:33:51 -04:00
Toshio Kuratomi	3812ec8d1d	Implement invocation hiding for all callbacks if the verbosity is low	2015-10-23 11:11:34 -07:00
Brian Coca	275764d4a5	avoid showing invokation when no_log is set or verbosity is low	2015-10-23 14:06:20 -04:00
James Cammarata	63ea614b4c	Version bump for 2.0.0-0.4.beta2	2015-10-23 13:34:30 -04:00
Toshio Kuratomi	99c6f77e59	Fix callback	2015-10-23 09:15:22 -07:00
Jens Peter Schroer	ecae636160	allowing json in lookup template calls	2015-10-23 14:21:46 +02:00
James Cammarata	4fd4f3374a	Merge pull request #12879 from larsks/bug/12876 ... allow include: directive to work during exception processing	2015-10-22 22:15:32 -04:00
Lars Kellogg-Stedman	914f68f9af	allow include: directive to work during exception processing ... prior to this commit, an attempt to use the `include:` directive would fail in a `rescue:` or `always:` block if there were failures in the main block task list. Resolves #12876.	2015-10-22 22:12:20 -04:00
Toshio Kuratomi	ce2b18174e	Merge pull request #12878 from ansible/invocation-fix ... Invocation fix	2015-10-22 16:17:40 -07:00
Toshio Kuratomi	2e87c1f74e	Two fixes to action plugins ... * Fix the task_vars parameter to not default to a mutable type (dict) * Implement invocation in the base class's run() method have each action module call the run() method's implemention in the base class. * Return values from the action plugins' run() method takes the return value from the base class run() method into account so that invocation makes its way to the output. Fixes #12869	2015-10-22 16:07:26 -07:00
Brian Coca	5017a96948	Revert "make callbacks declare needing whitelisting" ... another premature merge This reverts commit df8ff85787.	2015-10-22 16:34:51 -04:00
James Cammarata	86de1429e5	Cleaning up FIXMEs	2015-10-22 16:03:50 -04:00
Toshio Kuratomi	1e50d31cdc	Update submodule refs	2015-10-22 10:14:31 -07:00
Brian Coca	df8ff85787	make callbacks declare needing whitelisting ... this will allow for custom or v1 callbacks locally loaded to automatically be triggered as they were in 1.x	2015-10-22 12:30:23 -04:00
Toshio Kuratomi	75cff7129c	Fix for invocation not being added to output. ... We want invocation to be omitted when we are running async, not when we aren't running async.	2015-10-22 09:03:35 -07:00
Toshio Kuratomi	6b6d03290a	Restore the automatic addition of invocation to the output ... Revert "Remove auto-added invocation return value as it is not used by v2 and could leak sensitive data." This reverts commit 6ce6b20268. Remove the note that invocation was removed as we've now restored it. Revert "keyword not in ubuntu 14.04" This reverts commit 5c01622457. Revert "remove invocation keyword check" This reverts commit 5177cb3f74.	2015-10-22 08:53:37 -07:00
James Cammarata	498c27d09a	Re-adding role_names magic variable ... Fixes #12863	2015-10-22 11:06:47 -04:00
Brian Coca	c267c23020	make callbacks declare needing whitelisting ... this will allow for custom or v1 callbacks locally loaded to automatically be triggered as they were in 1.x	2015-10-22 08:27:32 -04:00
Brian Coca	54e821ca94	added deprecation warning to comma separated role spec	2015-10-22 08:10:51 -04:00
Brian Coca	09899b7c43	Merge pull request #12783 from larsks/bug/12782 ... correct value of remote_user for local connections	2015-10-22 08:10:07 -04:00
Brian Coca	9886829e40	Merge pull request #12861 from willthames/galaxy_spec_in_meta_main_fix ... Allow meta/main.yml to include roles through spec file	2015-10-22 08:01:02 -04:00
Brian Coca	d861e7dd5d	moved several directives so they are not settable at play, block, role and task levels	2015-10-22 07:51:22 -04:00
Brian Coca	fc3a44485b	skip errors on conditional if task is include ... fixes #12843	2015-10-22 07:50:43 -04:00
Will Thames	002972c6cf	Allow meta/main.yml to include roles through spec file ... ansible-playbook now works when run with a playbook that includes a role that includes another role specified using csv format Updated one of the roles used in the tests to fix broken tests - `make test_galaxy` now works Fixes #11486. Also addresses the problem alluded to in #10620.	2015-10-22 13:30:42 +10:00
Brian Coca	08c9e70307	made display part of variable manager and corrected reference to it ... fixes #12859	2015-10-21 22:29:27 -04:00
James Cammarata	2b3c5aa41e	Support cmd param in Tasks by assigning it to _raw_params ... Fixes #12856	2015-10-21 15:47:09 -04:00
James Cammarata	0e447e3f41	Merge branch 'devel' of https://github.com/mathieumd/ansible into mathieumd-devel	2015-10-21 13:59:51 -04:00
James Cammarata	4b20884719	Return correct changed flag when using check mode with template and force=no ... Fixes #12844	2015-10-21 13:51:39 -04:00
Brian Coca	04aa7701d1	fix prompt, static methods don't get 'self' ... fixes #12833	2015-10-21 12:06:29 -04:00
Toshio Kuratomi	42ce3de8d0	Merge pull request #12853 from ansible/winrm-return-bytes ... In v2, exec_command should return bytes and the caller will take responsibility for converting to unicode	2015-10-21 08:42:54 -07:00
Toshio Kuratomi	3d57a202b5	And another fix for docs	2015-10-21 08:40:30 -07:00
Toshio Kuratomi	9dc9a606f6	Correct docs build	2015-10-21 08:36:21 -07:00
Toshio Kuratomi	632d356d22	Update submodule refs	2015-10-21 08:31:58 -07:00
Toshio Kuratomi	6e5055e786	Update the use of no_log values to cover everything that heuristic_log_sanitize does. ... Fixes #12792	2015-10-21 08:15:46 -07:00
James Cammarata	ec56b29ba4	Fix setting of interpreter values for delegated hosts ... Fixes #12772	2015-10-21 11:05:45 -04:00
Toshio Kuratomi	c845181dc1	In v2, exec_command should return bytes and the caller will take responsibility for converting to unicode	2015-10-21 07:59:46 -07:00
gduke	744679601f	Remove mutable default arguments.	2015-10-20 22:13:23 -07:00
Toshio Kuratomi	10e2fc6f60	Update submodule ref	2015-10-20 15:37:50 -07:00
Toshio Kuratomi	1126ce34e3	Merge pull request #12846 from ansible/nolog-for-return-value ... Hide values in json returns which were given in parameters marked no_log.	2015-10-20 15:28:16 -07:00
Toshio Kuratomi	c2d188baff	Hide values in json returns which were given in parameters marked no_log.	2015-10-20 12:42:36 -07:00
James Cammarata	3ddda2f460	Merge pull request #12842 from mcsalgado/include_with_items ... Revert back to copying self._task.args	2015-10-20 15:33:34 -04:00
Brian Coca	1ecad5aed2	now galaxy correctly detects empty requirements file ... also allow for 'scm' and 'src' not to be populated in requirements entries	2015-10-20 14:39:22 -04:00
Victor Salgado	c5c5f3bf7a	Revert back to copying self._task.args	2015-10-20 16:21:25 -02:00
Victor Salgado	0e671baa33	Fix typo	2015-10-20 16:18:01 -02:00
James Cammarata	b46ce47a84	Don't use local transport for delegated hosts if the inventory_hostname isn't local ... For some situations like Vagrant, the remote_addr may be a localhost addr, but ssh is still desired. This corrects the assumption that any localhost remote_addr should be using the local connection by checking the inventory_hostname value as well. Fixes #12817	2015-10-20 14:04:39 -04:00
Toshio Kuratomi	99e7bb35c1	Simplify UnsafeProxy as we don't need to use it for byte strings, only text	2015-10-20 10:57:23 -07:00
James Cammarata	3c87c44af5	Fixing bug in includes caused by 892d9b8 ... Fixes #12837	2015-10-20 13:49:52 -04:00
Toshio Kuratomi	31ebafcbdd	Update submodule refs	2015-10-20 09:22:58 -07:00
Toshio Kuratomi	f34b55ac2b	Add python3-compat boilerplate to all .py files in lib/ansible	2015-10-19 18:36:19 -07:00
Brian Coca	de3ca57a33	avoid relative shlex import ... fixes #12777	2015-10-19 19:55:22 -04:00
James Cammarata	e5b6d802bf	Removing some cruft related to _local_action value on Task, which was removed ... Fixes #12819	2015-10-19 16:52:27 -04:00