Commit graph

3305 commits

Author SHA1 Message Date
Maykel Moya
811aa2611e Add support for string values
The SET GLOBAL statement requires properly quoting of values. For example, the
following correct queries will fail if quotes are toggled:

mysql> SET GLOBAL innodb_lru_scan_depth = 2000;
mysql> SET GLOBAL master_info_repository = "TABLE";

`mysql_variable` module doesn't quote the value argument, therefore
string values will fail.

  # this task will pass, 2000 is passed without quotes
  - name: set a numeric value
    mysql_variable: variable=innodb_lru_scan_depth value=2000

  # this task will fail, TABLE is passed without quotes
  - name: set a string value
    mysql_variable: variable=master_info_repository value=TABLE

With this patch prepared statements are used. Proper quoting will be
done automatically based on the type of the variables thus an attempt
to convert to int, then to float is done in first place.

Booleans values, ie: ON, OFF, are not specially handled because they
can be quoted. For example, the following queries are correct and
equivalent, they all set _innodb_file_per_table_ to logical _True_:

mysql> SET GLOBAL innodb_file_per_table = "ON";
mysql> SET GLOBAL innodb_file_per_table = ON;
mysql> SET GLOBAL innodb_file_per_table = 1;

Tested in mysql 5.5 and 5.6.
2014-02-12 12:44:28 +01:00
Michael DeHaan
f07091ed69 Merge pull request #5962 from sivel/rax-facts-docs-update
rax_facts and rax_keypair modules: update docs
2014-02-11 16:39:59 -05:00
Matt Martz
e8952a5a99 The OpenStack auth attributes apply to rax_keypair also 2014-02-11 14:25:13 -06:00
jctanner
fe94c0cd05 Merge pull request #5957 from sivel/rax-no-default-disk-config
rax module: Don't set a default for disk_config
2014-02-11 11:55:06 -05:00
Matt Martz
8095aa6584 Don't set a default disk_config. Defaulting to 'auto', causes issues with new images 2014-02-10 16:12:32 -06:00
Michael DeHaan
d3c1b8de78 Merge pull request #5883 from amirhhz/improve-ec2-module-docs
Improve ec2 module docs
2014-02-09 14:07:35 -05:00
Jon Chen
970997c764 fix linode typo 2014-02-07 20:47:57 -05:00
Richard Isaacson
66967bde14 Merge pull request #5905 from artursvonda/update-postgresql-docs
Added port documentation to postgresql_db and postgresql_user.
2014-02-07 14:31:09 -06:00
James Tanner
a62af82757 Make ec2 exact_count and count mutually exclusive 2014-02-07 13:42:43 -05:00
James Tanner
70ebb05190 Return a tagged_instances list for hosts that matched the count_tag 2014-02-07 13:07:34 -05:00
Richard Isaacson
5a15762739 Merge pull request #5826 from romeotheriault/fix_follow_redirects
A fix for uri module regarding following redirects. The old behavior would follow redirects either way. This change clarifies the functionality and makes it a bit more explicit. Comparing the old behavior to the new 'yes' == 'all', 'no' == 'safe' and now 'no' will not follow any redirects. Historic behavior is still supported and documented with a push to the new values.
2014-02-07 11:36:51 -06:00
Arturs Vonda
6d85082586 Added port documentation to postgresql_db and postgresql_user 2014-02-07 18:27:55 +02:00
jctanner
6e7f684958 Merge pull request #5901 from jctanner/ec2_tag_exact_count_2
Add exact_count and count_tag to the ec2 module.
2014-02-07 10:57:01 -05:00
James Tanner
f101768a9d Make an example that sets the instance Names 2014-02-07 10:49:13 -05:00
James Tanner
005ef837d9 Update docstrings 2014-02-07 10:34:45 -05:00
James Tanner
fd919062cb Add exact_count and count_tag to the ec2 module. 2014-02-06 23:25:57 -05:00
Afterburn
398c71c1b7 small change to docs 2014-02-06 20:35:42 -07:00
Afterburn
2fe00ac8c9 small change to docs 2014-02-06 20:34:38 -07:00
jctanner
0bc0315171 Merge pull request #5880 from willthames/ec2_modules_refactor
Create a common EC2 connection argument spec for EC2 modules
2014-02-06 11:08:09 -05:00
Will Thames
7600c664fe Create a common EC2 connection argument spec for EC2 modules
Refactor the currently well-factored ec2 modules (i.e. those that already use ec2_connect) to
have a common argument spec. The idea is that new modules can use this spec without duplication
of code, and that new functionality can be added to the ec2 connection code (e.g. security
token argument)
2014-02-06 15:27:41 +10:00
jctanner
a1d2b5f257 Merge pull request #5363 from bcoca/acl_improved
acl module: acl now supports 'default'
2014-02-05 18:40:59 -05:00
Brian Coca
54a79bfc75 fixed docstring and changed type to etype avoiding python builtin
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
2014-02-05 18:36:29 -05:00
Richard Isaacson
66f47c2096 Merge pull request #5891 from offby1/devel
Clarify doc for get_url
2014-02-05 15:49:31 -06:00
James Tanner
7268fe43e7 Use new syntax for module snippets in rabbitmq_policy and update changelog 2014-02-05 16:21:18 -05:00
jctanner
cda3f06117 Merge pull request #4957 from retr0h/rabbitmq_policy
Added module to handle rabbit policies [1]
2014-02-05 16:07:38 -05:00
jctanner
7fcf6cebfe Merge pull request #5881 from willthames/ec2_keys
Minor tweaks to simplify examples and documentation
2014-02-05 15:50:19 -05:00
jctanner
c13161993a Merge pull request #5410 from willthames/rds_snapshot
rds module: add snapshot capabilities
2014-02-05 15:23:08 -05:00
Eric Hanchrow
7e557663c2 Clarify doc for get_url
Move a sentence from doc for the "force" option to that for the "dest" option.
2014-02-05 10:58:48 -08:00
James Cammarata
77d5a18392 When force=yes, get_url should always download the specified file
This is accomplished by not setting the If-Modified-Since header,
and setting "cache-control: no-cache" instead. Note that if the
file content has not changed, the module will still report that
changed=false, as the md5's of the tmp file and existing file are
compared before swapping

Fixes #5104
2014-02-05 11:56:05 -06:00
jctanner
f50f29f304 Merge pull request #5051 from deontologician/patch-1
Added -FF flag to rsync invocation in synchronize
2014-02-05 12:02:48 -05:00
jctanner
825a20780f Merge pull request #5127 from ovcharenko/patches
synchronize module: Added existing_only options to skip creating new files on receiver
2014-02-05 11:49:05 -05:00
jctanner
1f9de0c076 Merge pull request #5187 from 42wim/devel
Add support for --copy-links in synchronize
2014-02-05 11:26:08 -05:00
Amir H. Hajizamani
843f4e7d7c Neaten up example YAML with 2-space indenting 2014-02-05 15:14:44 +00:00
Amir H. Hajizamani
7c38e8a225 Example should put instance_ids list in quotes for avoid YAML error 2014-02-05 15:12:41 +00:00
Amir H. Hajizamani
b0bc2bd86a Fix missing quote mark in route53 doc example 2014-02-05 13:59:31 +00:00
willthames
e0c245f1ae Minor tweaks to simplify examples and documentation
Made a few things more consistent with the bulk of the other EC2
modules and removed an unnecessary check that is handled by
AnsibleModule
2014-02-05 22:25:44 +10:00
jctanner
a877b8b030 Merge pull request #5624 from mattsoftware/route53_ttl
Enable changes to ttl of a record to be propogated to route53
2014-02-04 11:11:44 -08:00
jctanner
5967b463c9 Merge pull request #5554 from ttarabul/devel
Use /etc/rc.conf.local for sevice configuration on FreeBSD
2014-02-04 10:59:19 -08:00
Matthew Jones
31ac3e71df Allow strings containing single and double quotes to be used as passwords for postgres_user 2014-02-03 17:07:17 -05:00
Timur Batyrshin
658c15930e reword "except Error as e:" into "except Error, e:" to be compatible with Python 2.5 (#5852) 2014-02-03 13:00:40 -06:00
Richard C Isaacson
292d84165e Clean up stray space at the end of a line after a period. 2014-02-03 11:52:37 -06:00
Richard Isaacson
f5ed7e1f0a Merge pull request #5828 from mxxcon/patch-1
Updated htpasswd docs to have choices for crypt_scheme
2014-02-03 09:46:10 -08:00
Pedro Romano
30c8f514a2 Allow the 'PATCH' method in the 'uri' module since 'httplib2' allows it
and some APIs require it.
2014-02-02 20:53:52 +00:00
James Cammarata
fcb760c36c Merge pull request #5843 from jimi-c/issue_4088
Adding no_log: capability for tasks
2014-02-01 04:36:29 -08:00
James Cammarata
75e3b59bbd Adding no_log: capability for tasks
Fixes #4088
2014-01-31 16:58:46 -06:00
Michael Porter
8ccbf13a13 (#5822) Use mkstemp to open a temporary file (as NamedTemporaryFile doesn't take a delete argument in Python < 2.6) 2014-01-30 19:39:39 -05:00
Michael DeHaan
a1afd6987c Update copy
Update copy documentation to reference synchronize module
2014-01-30 17:43:40 -05:00
James Cammarata
9574f89471 Detect remote_user change in accelerate daemon and allow a restart
Fixes #5812
2014-01-30 14:40:41 -06:00
jctanner
086f879df9 Merge pull request #5823 from kustodian/authorized_keys
Updated authorized_key module documentation regarding manage_dir
2014-01-30 07:01:41 -08:00
Matt Martz
7498f212fc Update docs for rax_facts to include parameters added for other OpenStack clouds 2014-01-30 07:59:31 -07:00