cmueller/ansible
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity
8663 commits 47 branches 390 tags 440 MiB
Commit graph

87 commits

Author SHA1 Message Date
Maykel Moya 811aa2611e Add support for string values 
The SET GLOBAL statement requires properly quoting of values. For example, the
following correct queries will fail if quotes are toggled:

mysql> SET GLOBAL innodb_lru_scan_depth = 2000;
mysql> SET GLOBAL master_info_repository = "TABLE";

`mysql_variable` module doesn't quote the value argument, therefore
string values will fail.

  # this task will pass, 2000 is passed without quotes
  - name: set a numeric value
    mysql_variable: variable=innodb_lru_scan_depth value=2000

  # this task will fail, TABLE is passed without quotes
  - name: set a string value
    mysql_variable: variable=master_info_repository value=TABLE

With this patch prepared statements are used. Proper quoting will be
done automatically based on the type of the variables thus an attempt
to convert to int, then to float is done in first place.

Booleans values, ie: ON, OFF, are not specially handled because they
can be quoted. For example, the following queries are correct and
equivalent, they all set _innodb_file_per_table_ to logical _True_:

mysql> SET GLOBAL innodb_file_per_table = "ON";
mysql> SET GLOBAL innodb_file_per_table = ON;
mysql> SET GLOBAL innodb_file_per_table = 1;

Tested in mysql 5.5 and 5.6.
 2014-02-12 12:44:28 +01:00
Arturs Vonda 6d85082586 Added port documentation to postgresql_db and postgresql_user 2014-02-07 18:27:55 +02:00
Matthew Jones 31ac3e71df Allow strings containing single and double quotes to be used as passwords for postgres_user 2014-02-03 17:07:17 -05:00
Timur Batyrshin 658c15930e reword "except Error as e:" into "except Error, e:" to be compatible with Python 2.5 (#5852) 2014-02-03 13:00:40 -06:00
jctanner 09f7b11d1d Merge pull request #5435 from jkleckner/fix-mysql-dump-import 
mysql_db module: make dump and import to use port argument
 2014-01-14 13:06:33 -08:00
David Busby b4f86abafd Documentation update to yield example of "WITH GRANT OPTION" which is undocumented previous 2014-01-14 12:04:32 +00:00
Jim Kleckner dacef1915a Add quotes to password argument for dump/import 
The password is passed on a command line for dump and import and needs
quoting.

Ideally, this would not be passed on a command line at all - any ideas?
Or at least have a stronger form of quoting so that embedded single
quotes will be escaped.
 2014-01-02 12:04:03 -08:00
Jim Kleckner f532b449d7 Fix mysql_db dump and import to use port argument 
The code for mysql_db did not pass the port argument when state=dump or
state=import.
 2013-12-26 16:21:16 -08:00
jctanner 7182486fd2 Merge pull request #5099 from tartansandal/postgresql_db_check_mode 
postgres_db CHECKMODE changed status
 2013-12-16 11:39:16 -08:00
Jinn Koriech 6f2843724d Fix postgresql_user documentation render 2013-12-05 16:57:56 +00:00
Jinn Koriech 6b54417bd5 Add documentation for usage of encrypted postgresql passwords. 2013-12-05 10:35:35 +00:00
James Tanner ad837709bd Addresses #5023 Fix import comments 2013-12-02 15:13:49 -05:00
James Tanner 6000d636b3 Fixes #5023 Convert all modules to use new snippet import pattern 2013-12-02 15:11:23 -05:00
Kahlil (Kal) Hodgson ab14ec840b postgres_db CHECKMODE changed status 
Make the changed status for postgres_db under CHECKMODE match the
status that would be returned normally.
 2013-11-29 11:29:03 +11:00
Michael DeHaan 36effd237c There's a cleaner way to do this, commit to module formatter pending. 
Revert "No longer need to reference 'version_added' in docs for these, as this was quite a while ago."

This reverts commit ff0a41d446.
 2013-11-27 21:23:03 -05:00
Michael DeHaan ff0a41d446 No longer need to reference 'version_added' in docs for these, as this was quite a while ago. 2013-11-27 21:19:32 -05:00
Michael DeHaan f7c3975f21 Add version_added to all modules missing version_added information, the docs formatter will now 
raise errors when omitted, updated changelog with new modules.
 2013-11-18 18:55:49 -05:00
James Tanner 15243cd801 Fix typo in postgresql_user module docstrings 2013-11-14 11:57:01 -05:00
jctanner 8041735c56 Merge pull request #4686 from bcoca/postgresql_user_pwds 
postgresql_user now supports users w/o a password, encrypted passwords and expiration
 2013-11-14 08:55:11 -08:00
James Tanner 6cdc99286c Merge pull request #4307 from damianmoore/mysql_gzip_bzip2_support 
Add support for compressing mysql dumps and extracting during import.
 2013-11-07 15:07:59 -05:00
Steve Tjoa 626d41c1d1 Changed parameter from 'user' to 'name' in the examples to coincide with the specs. 2013-11-02 22:42:44 -07:00
James Tanner d3c8832414 Fixes #4720 Use mysql command to restore database instead of mysqldump 2013-10-29 10:33:46 -04:00
Brian Coca 87e886a550 updated to make note that password is required before v1.4 
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
 2013-10-26 12:47:22 -04:00
Brian Coca 594ecc00c1 updated docs 
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
 2013-10-26 11:37:45 -04:00
Brian Coca 61d9472312 now supports users w/o a password, encrypted passwords and expiration 
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
 2013-10-26 11:32:16 -04:00
Maykel Moya 3db7ec8356 Fail if requested variable is not available 2013-10-22 09:30:19 +02:00
James Tanner 3c4dd618e4 Fixes #4454 Make a temporary clean cnf file if unable to parse existing 2013-10-18 17:42:40 -04:00
Maykel Moya b90a250165 Improve change detection in mysql_variables 
mysql_variables bindly executes a SET var = value query even when
the variable already has the requested value.

With this patch the query is executed only if the current value is
different to the requested one.
 2013-10-17 19:13:58 +02:00
James Tanner 807e602228 mysql_db: if connection is a socket, do not specify hostname 2013-10-16 09:59:31 -04:00
James Tanner 84a692bcf7 Fixes #4301 Use module_common functions for mysqldump and return better errors 2013-10-16 09:51:08 -04:00
Michael DeHaan e4036b1bfc Merge pull request #4342 from pileofrogs/devel 
mysql_replication switch to DictCursor for compatibility with more mysql server versions
 2013-10-11 06:21:22 -07:00
Michael DeHaan ce79efc34a Add missing version_added doc to mysql login port parameter. 2013-10-11 09:14:14 -04:00
Dylan Martin 345329b69f toned down the error message for unconfigured master/slave 2013-10-10 09:15:47 -07:00
Jeroen Hoekx 08b0773da5 Add append_privs parameter to MySQL user module. 
This adds the privileges given to the existing list of privileges
instead of overwriting any existing ones.
 2013-10-03 14:57:01 +02:00
Dylan Martin 6b26a73681 switch to DictCursor 2013-10-02 13:00:07 -07:00
Damian Moore 3c57168aaa mysql_db now supports import and dump of gzip and bzip2 compressed files 2013-09-30 19:09:32 +01:00
James Cammarata 30a1560d67 Merge branch 'devel' of https://github.com/tomdymond/ansible into tomdymond-devel 2013-09-23 14:53:46 -05:00
James Cammarata 7752a56091 Merge branch 'devel' of https://github.com/abompard/ansible into abompard-devel 2013-09-06 13:51:45 -05:00
James Cammarata 71bf9495ef Merge branch 'fix_postgresql_db' of https://github.com/yteraoka/ansible into yteraoka-fix_postgresql_db 2013-09-06 13:26:01 -05:00
James Cammarata b65cefe893 Cleaning up pep8 whitepsace issues in the mysql_replication module 2013-09-06 12:50:50 -05:00
James Cammarata 03e124d91f Merge branch 'bugfix' of https://github.com/jsmartin/ansible into jsmartin-bugfix 2013-09-06 12:47:27 -05:00
James Martin 8c1ed028d3 Fixes for python 2.4 support, better collection of riak version. 2013-09-06 13:42:27 -04:00
James Cammarata 3adb91a4b4 Added version_added to the mysql_variables module doc section 2013-09-06 12:32:08 -05:00
James Cammarata a57ced4b66 Merge branch 'mysql_variables' of https://github.com/banyek/ansible into banyek-mysql_variables 2013-09-06 12:25:52 -05:00
James Cammarata a56c695bc8 Added version_added to the mysql_replication module doc section 2013-09-06 12:23:41 -05:00
James Cammarata ff19cdae39 Merge branch 'mysql_replication' of https://github.com/banyek/ansible into banyek-mysql_replication 2013-09-06 12:10:31 -05:00
James Cammarata 441062f061 Cleaning up whitspace issues in the mysql_user module 2013-09-06 10:51:53 -05:00
John Hamelink 892c594319 Fixed #3767 - mysql_user command fails with dots (and underscores) in 
database names.
 2013-09-06 10:51:53 -05:00
Aurélien Bompard 5a949dcafc Module postgresql_privs: fix default arguments 
Defaults arguments must not be added to the connection keywords, as
the other postgresql modules already do.

Closes #4043
 2013-09-06 00:17:49 +02:00
Tom Dymond 11c2378259 Add option to specify the MySQL server port 2013-09-05 16:25:34 +01:00