cmueller/ansible
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity
50363 commits 47 branches 390 tags 440 MiB
Commit graph

50363 commits

This branch
This branch
All branches
Author SHA1 Message Date
jctanner
b019029bf3
Add intentional unit tests for basic._set_cwd and common.dict_merge (#70283) 
* Add unit tests for basic._set_cwd

* incidental coverage for dict_merge

* add test for async stderr inclusion
 2020-06-25 14:45:13 -05:00
Abhijeet Kasurde
29169ae847
stat: Handle colon in filename (#70259) 
Handle colon appearing in filename while parsing the mimetype and charset
using file command.

Fixes: #70256

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
 2020-06-25 14:21:50 -05:00
Adam Miller
3c9be97e16
fix runtime.yml splunk.enterprise_security -> splunk.es (#70305) 
Signed-off-by: Adam Miller <admiller@redhat.com>
 2020-06-25 18:34:11 +01:00
Pavel Březina
45e0f74702
display: use stdout for column width (#70199) 
stdout may differ from stdin so it should be used to determine the column
width, especially since it is the target file descriptor.
 2020-06-25 12:57:24 +05:30
Abhijeet Kasurde
3fe48ecba2
Add collection path in CLI version info (#68633) 
This will provide user default path of collection

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
 2020-06-25 01:58:56 -04:00
Matt Clay
74494a1908 Code cleanup for ansible-test coverage support. 2020-06-24 17:39:35 -07:00
Matt Clay
8d92df4537 Test netconf plugins in ansible-doc sanity test. 2020-06-24 15:53:32 -07:00
Sam Doran
a3c1ea886f
Revert commits related to delegated facts changes (#70272) 
* Revert "Fix storing delegate_to facts (#70231)"

This reverts commit 88bb76f248.

* Revert "Fix storing local task_vars facts for the retry (#70171)"

This reverts commit eaf6086eea.
 2020-06-24 15:36:51 -04:00
Rick Elrod
2531d54880
Throw AnsibleError instead of OSError, py3.9 crypt (#70246) 
Change:
- On Python 3.9, `crypt.crypt` will throw instead of returning `None`
  when the algorithm isn't supported. So we catch that and handle it
  the same way we handled the algorithm not being supported on 3.8: by
  throwing AnsibleError.

Test Plan:
- CI for <=3.8.
- Local for 3.9b3:
  ansible -m debug -a "msg=\"{{ 'changeme' | password_hash('bcrypt') }}\"" localhost

  Before:
  localhost | FAILED! => {
      "msg": "Unexpected failure during module execution.",
      "stdout": ""
  }

  After:
  localhost | FAILED! => {
      "msg": "crypt.crypt does not support 'bcrypt' algorithm"
  }

Tickets:
- Fixes #69930

Signed-off-by: Rick Elrod <rick@elrod.me>
 2020-06-24 13:50:28 -05:00
Felix Fontein
ebd20ddca6
Include changelogs/changelog.yaml in distribution. (#70260) 2020-06-24 11:38:20 -05:00
Matt Clay
262f93e22c Code cleanup in the import sanity test. 2020-06-23 23:09:00 -07:00
David Shrewsbury
dd07bdf22d
Fix galaxy role info bug to support multiple roles (#70148) 
* Add changelog fragment
* Update changelog
 2020-06-23 16:57:25 -04:00
Abhijeet Kasurde
4885ebad27
default_callback: Move 'check_mode_markers' in doc_fragments (#70228) 
Callback plugin dense, yaml, and debug implement 'check_mode_markers'
so moving documentation to default callback doc_fragments.

Fixes: https://github.com/ansible-collections/community.general/issues/565

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
 2020-06-23 16:26:09 -04:00
Matt Clay
70c59423fc Pin ansible-test requirements for RHEL. 
The `packaging` and `pyparsing` packages are now installed by `ansible-test` during provisioning of RHEL instances to match the downstream vendored versions.
 2020-06-23 11:52:25 -07:00
Rick Elrod
0073ab5fa6
Nuke strategy.SharedPluginLoaderObj, depr. 2.11 (#70235) 
* Nuke strategy.SharedPluginLoaderObj, depr. 2.11

Change:
- Nuke SharedPluginLoaderObj class
- Update tests (which seemingly didn't use it anyway)
- Changelog

Test Plan:
CI, grep

Signed-off-by: Rick Elrod <rick@elrod.me>

* Nuke from ignore.txt

Signed-off-by: Rick Elrod <rick@elrod.me>
 2020-06-23 13:09:26 -04:00
Samer Deeb
7ef6b174e8
Migrate onyx modules from community.network to mellanox.onyx (#70213) 
Signed-off-by: Samer Deeb <samerd@mellanox.com>
 2020-06-23 17:21:56 +01:00
Rick Elrod
7584e145a9
Nuke _get_item() from callback, deprecated 2.11 (#70233) 
Change:
- Remove _get_item() alias as it has been deprecated
- Update tests
- Remove relevant sanity curtailment
- Add changelog

Test Plan:
CI, grep

Signed-off-by: Rick Elrod <rick@elrod.me>
 2020-06-23 12:03:27 -04:00
Martin Krizek
88bb76f248
Fix storing delegate_to facts (#70231) 
* Fix storing delegate_to facts
 2020-06-23 12:02:16 -04:00
Rick Elrod
c9edb35652
Nuke systemd module user option, 2.11 deprecation (#70211) 
Change:
Remove all references to the 'user' param in systemd module.

Test Plan:
CI and grep.

Signed-off-by: Rick Elrod <rick@elrod.me>
 2020-06-23 11:55:01 -04:00
Rick Elrod
9cfc76a221
Nuke with_ squashing, deprecated for 2.11 (#70209) 
Change:
Removes with_* loop squashing and tests for 2.11

Test Plan:
CI, and grepped for with_items in package manager integration targets.
There might be some test cases in collections which need to stop testing
this behavior.

Signed-off-by: Rick Elrod <rick@elrod.me>
 2020-06-23 11:53:25 -04:00
Abhijeet Kasurde
40a42de081
async_status: Update documentation (#70196) 
Fixes: #38164

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
 2020-06-23 11:45:54 -04:00
John R Barker
4b358c6641
Update config.yml (#70154) 
typos & branding
* Update .github/ISSUE_TEMPLATE/config.yml

Co-authored-by: Rick Elrod <rick@elrod.me>
 2020-06-23 11:17:33 -04:00
Matt Clay
fa48678a08
Rename pylint plugin and add tests. (#70225) 
* Renamed custom pylint plugin for unwanted names.
* Add integration tests for sanity test failures.
 2020-06-22 20:25:35 -07:00
Matt Clay
4816bb4f43
More boilerplate fixes. (#70224) 
* Fix boilerplate in hacking dir.
* Fix boilerplate in docs dir.
* Fix boilerplate in integration tests.
* Fix boilerplate in examples.
 2020-06-22 19:05:30 -07:00
Matt Clay
234994fc07 Fix boilerplate in setup.py and lib/ansible/ dir. 2020-06-22 16:29:16 -07:00
Matt Martz
1fedb95e4b
Use libc wcwidth to calculate print width in display (#66214) 
* Use libc wcwidth to calculate print width in display. Fixes #63105

* Remove errantly added blank lines

* Fixes

* Move setlocale, adjust tests to work around py2 oddity with characters following null

* Don't change cli stub

* emojis

* Remove to_text call

* Special accounting for deletions

* Add initialization function, expand tests, ensure fallback to len

* get_text_width requires text, ensure banner deals with it

* Handle setlocale errors

* Move variable decrement

* Remove unused import
 2020-06-22 16:57:01 -05:00
Matt Clay
26e8c07f32 Remove incidental_lookup_rabbitmq test. 
It is no longer contributing unique code coverage.
 2020-06-22 14:33:03 -07:00
Matt Clay
98a0995fd0 Clean up unit test boilerplate. 2020-06-22 14:20:33 -07:00
Alicia Cozine
4a0f42923b
adds japanese translation as a version-switcher option (#70214) 
Co-authored-by: Alicia Cozine <acozine@users.noreply.github.com>
 2020-06-22 16:25:44 -04:00
Martin Krizek
eaf6086eea
Fix storing local task_vars facts for the retry (#70171) 
* Fix storing local task_vars facts for the retry

Fixes #70168
 2020-06-22 10:07:47 -04:00
Sam Doran
b2d6db7916
Rebalance CI groups to avoid macOS timeouts (#70126) 2020-06-19 16:40:51 -04:00
Westley Argentum Hennigh-Palermo
5885ed4455
remove gendered example (#70117) 
Changed example to not assume things about names and genders
 2020-06-19 14:35:03 -05:00
Abhijeet Kasurde
da868d9d60
docs: Add note about ansible-doc (#70162) 
ansible-doc can only parse Python modules, added a note about
this is developer guide; Fixes: #69109
 2020-06-19 14:28:02 -05:00
Jill R
0ef75f65d9
Fix broken link in AWS Guide (#70153) 
Point to collection rather than ansible/ansible for example.
 2020-06-19 14:18:55 -05:00
Sandra McCann
647c6cd289
updates to ansible-maintained collections guidelines (#70178) 2020-06-19 14:04:19 -05:00
Sam Doran
86606d3ca7
Disable ansible-galaxy-collection test (#70177) 
It it currently failing
 2020-06-19 14:20:06 -04:00
Jill R
8ad46870a4
Update note about AWS collection test requirements in docs (#70176) 2020-06-19 13:40:19 -04:00
Jordan Borean
598c40beb3
Fix up the redirection of the win setup module (#70158) 2020-06-19 09:27:02 -07:00
Jordan Borean
8b24a4c5ed
Fix up the redirection of the win setup module (#70158) 2020-06-19 09:24:35 -07:00
Sam Doran
fd882e0e18
Get test data file directly in rebalance script (#70107) 
Rather than looking through tests.json to find the data file, look for it explicitly
within a given target to avoid problems processing data in tests.json.
 2020-06-19 09:57:50 -04:00
Sam Doran
bc05415109
Only pass kwargs to our string checker not callable checkers (#70151) 
Since only check_type_str() accepts extra param, only pass to our checker and
do not pass kwargs to custom checkers.

* Add unit tests
 2020-06-19 09:52:05 -04:00
Abhijeet Kasurde
87406890cf
find: Specify elements type in paths (#70139) 
Fixes: #35990

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
 2020-06-19 06:56:02 +05:30
Matt Clay
bccf6b85f2 Change comprehension to list() in plugin loader. 2020-06-18 12:29:52 -07:00
Matt Clay
89afb60999 Fix transport defs in test connection plugins. 2020-06-18 11:50:51 -07:00
Matt Clay
c67efe0bd1 Avoid unnecessary comprehensions. 2020-06-18 11:50:31 -07:00
Matt Clay
9bbde9d085 Avoid file module false positive in newer pylint. 2020-06-18 11:36:44 -07:00
Matt Clay
1a0d8a51cd Fix yamllint sanity test line numbers. 
Parse errors from libyaml now compensate for the offset of the documentation within a module.
 2020-06-18 10:03:21 -07:00
Martin Krizek
0ed5b77377
Detect failure in always block after rescue (#70094) 
* Detect failure in always block after rescue

Fixes #70000

ci_complete

* Add more tests
 2020-06-18 11:03:36 -05:00
anshulbehl
33e25504ac
redirecting the conjur lookup plugin to correct collection (#70106) 2020-06-18 07:38:15 +01:00
Matt Clay
feb163e0de
Improve consistency of ansible-test pylint results. (#70132) 
* Disable too-many-ancestors pylint check.

This check was only enabled for ansible-test code.

In some cases this check counts 1 more ancestor in python 3.7+ than under python 3.6, making the check inconsistent and unsuitable for use in ansible-test.

* Disable additional pylint checks:

- import-error
- no-name-in-module

These checks were only enabled for ansible-test code.

These checks provide inconsistent results since they are dependent on available imports, which vary between environments.

It may be practical to enable these checks in the future if changes are made to ensure a consistent test environment for pylint.
 2020-06-17 17:03:41 -07:00