Paul Belanger
81ffc315a4
Remove unused imports for iosxr_acls ( #67711 )
...
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2020-02-24 17:47:35 -05:00
Paul Belanger
fc69f63cec
Remove unused imports in eos_modules unittest ( #67709 )
...
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2020-02-24 16:37:19 -05:00
Paul Belanger
bfea5cfca0
Remove unused imports from vyos_firewall_global ( #67710 )
...
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2020-02-24 15:26:42 -05:00
Graeme Davidson
bd26b6c0b4
updated single quote handling to not strip and error on odd number ( #67500 )
...
Fixes #67274
2020-02-24 13:45:19 -05:00
GomathiselviS
d283126c31
eos_acls : Add eos acls resource module ( #66308 )
...
* Adding files for RM static_routes
* Added Integration tests
* Added Unit testcases
* Addressed review comments
* corrected lint errors
* corrected documentation errors
* Lint errors
* corrected test/sanity
* corrected documentation for deprecation
* corrected case sensitivity
* Again Documentation eroor
* Lint errors again
* corrected deprecated module in ignoretxt
* added new gethered,rendered,parsed state checks to unit test
* New code broke the old flow-fixed
* Lint errs
* Added check for running_config
* eos_acls resource module added
* Corrected errors
* corrected documentation errors
* corrected typo
* Testcases in progress
* Integration tests in progress
* Integration tests
* Added Intergration tcs
* Corrected pylint errors
* Resolving issues due to rebase
* Corrected Typo
* more pylint errors
* more pylint errors
* more pylint errors
* Documentation
* Documentation
* More lint errors
* Fixed Indentation
* Indentation issues - not getting fixed
* Indentation issues - not getting fixed
* Added rtt testcase
* Corrected whitespaces
* addressed review comments
* moved integration tests to common - to support eapi tests
* modification for merge update
* indentation errors
* added line key
* Fixing shippable errors
* fixing doc errors
* fixing doc errors
* fixing doc errors
* fixing doc errors
* fixing indentation
* modified replaced operation
* rebase issue fixed
* Corrected typo
* review comments and flake8 error fixed
2020-02-24 12:27:11 -05:00
Paul Belanger
74e948e6e4
Fix flake8 errors with eos_acl_interfaces ( #67695 )
...
Theses were exposed by our collections testing.
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2020-02-24 09:47:43 -05:00
Rohit
fc05c50b7f
VyOS: firewall global module added ( #66800 )
...
* firewall global module
Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>
* sanity fixed
Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>
* test updated
Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>
* sanity fixes
Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>
* group member handling updated
Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>
* comments incorporated
Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>
2020-02-24 09:03:02 -05:00
Nilashish Chakraborty
b818436c5f
Add iosxr_acls RM ( #66207 )
...
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
2020-02-24 18:34:27 +05:30
GomathiselviS
600d6278f9
eos : Add resource module eos_acl_interfaces ( #67137 )
...
* Added fix for bug # 54400
* Adding files for RM static_routes
* Added Integration tests
* Revert "Added fix for bug # 54400"
This reverts commit bf42db4269dafdd92d43129dc87682bf42db4269dafdd92d43129dc87682
2020-02-21 10:05:16 -05:00
Paul Belanger
493dda94e9
Remove unused imports for vyos ( #67550 )
...
These flake8 errors would caught in our collection testing.
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2020-02-18 17:49:49 -05:00
Rohit
9eb7709c61
Vyos static route module added ( #62193 )
...
* Vyos static route module added
Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>
* sanity fixes
Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>
* empty config traceback fix
Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>
* sanity check fix
* model specific changes and SI test cases updated
Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>
* new state changes and SI test cases updated
Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>
* sanity fixes
Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>
* UT cases added
Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>
* replaced operation fix
Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>
* review comments incorporated
Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>
* shippable fix
Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>
* sanity fix
Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>
* delete opr updated
Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>
* comments incorporated
Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>
2020-02-18 07:32:26 -05:00
Rohit
e76630c4e4
VyOS: firewall_rules module added ( #65680 )
...
* firewall_rules module added
Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>
* state fact gathering code
Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>
* facts and operation code added
Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>
* unit tests added
Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>
* sanity fixes
Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>
* sanity fixes
Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>
* sanity fixes
Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>
* delete opr updated
Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>
2020-02-17 08:08:08 -05:00
Prasad Katti
f21ee7f685
cloudformation - use mutually_exclusive for on_create_failure and disable_rollback ( #65629 )
...
* cloudformation - use mutually_exclusive for on_create_failure and disable_rollback
* cloudformation - remove unit test test_disable_rollback_and_on_failure_defined
2020-02-15 13:00:36 +00:00
GomathiselviS
4ec1437212
Fix to - eos_vlans using state parameter replaced is giving odd behavior ( #67318 )
...
* Added fix for bug # 54400
* Adding files for RM static_routes
* Added Integration tests
* Revert "Added fix for bug # 54400"
This reverts commit bf42db4269dafdd92d43129dc87682bf42db4269dafdd92d43129dc87682#67313
* fixing rebase issue
* fixing rebase issue
* addressed review comments
* addressed review comments
2020-02-12 11:12:12 -05:00
Jiri Hnidek
6f1bb37feb
When no pool quantity is set, then do not set quantity to 1 ( #66807 )
...
* Fixes #66478
* When no quantity is set, then candlepin server usually uses
default value 1. When more quantities are required, then
candlepin server can automatically choose correct minimal
value.
2020-01-29 12:10:47 -05:00
Sato Kenta
a4b59d0213
pamd: Fix AttributeError when removing the first or last rule ( #66398 )
2020-01-23 14:08:42 -05:00
Mike Wiebe
5c158755fc
Fix fact gathering for sensor-groups ( #66439 )
2020-01-22 10:49:12 +05:30
Paul Belanger
1ee47a5969
Fix flake8 errors for junos tests ( #66645 )
...
Deal with F841 local variable foo is assigned to but never used
errors.
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2020-01-21 08:57:39 +01:00
Boyd Hemphill
7129453cd9
Maven Central requires TLS ( #66611 )
...
Fixes : #66609
Maven requires TLS as of 2019-01-15
2020-01-20 11:16:49 +05:30
Paul Belanger
8b0fb9f290
Fix flake8 error with test_eos_lacp_interfaces ( #66552 )
...
F841 local variable 'commands' is assigned to but never used
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2020-01-17 09:32:19 -05:00
GomathiselviS
0ab0e1556b
eos_lacp_interfaces: Add unit testcases to eos_lacp_interfaces ( #64455 )
...
* Add unit testcases to eos_lacp_interfaces
* Add unit testcases to eos_lacp_interfaces
2020-01-16 15:07:57 -05:00
Paul Belanger
0fa556f751
Fix flake8 errors related to vyos.vyos collection ( #66516 )
...
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2020-01-16 08:22:51 -05:00
Andreas Calminder
3b764c6dcb
Add diff and check_mode support to os_server ( #62206 )
...
* don't mix " and '
* rename functions that perform changes
* add diff, reorganize _present/_absent functions
* update tests to match function reorg
* add result to _exit_hostvars and removal of possibly sensitive information
* shallow copy dict for proper diff, add check_mode
* set check_mode to False for unit tests
* move _parse_meta back to it's original place
* use get_openstack_vars for diff when not in check_mode
* add changelog fragment
2020-01-16 10:39:54 +01:00
Chris Van Heuveln
3ebc96e5c7
nxos_l3_interfaces: fix states, add new minor attributes ( #64853 )
...
* (WIP) nxos_l3_interfaces: fix states, add new minor attributes
* sa cleanup
* more regression fixes
* test_8 for add'l code coverage
* Fix regressions to handle mgmt w/o IP
* add 'no system default switchport' to regression setups
* add err msg to terminal_stderr_re so that cli_config will catch L2 failures
* regression test change: /int4/int3/
* Add default rsvd_intf_len for Zuul CI
* Fix replaced-with-no-ipaddr and ip redirect issues
2020-01-10 16:33:22 +05:30
Karthikeyan Singaravelan
891c759832
Fix AttributeError due to cgi.escape removal in Python 3.8. ( #66040 )
...
* Fix cgi.escape AttributeError due to cgi.escape removal in Python 3.8.
* Fix linter errors.
2020-01-09 15:28:02 -05:00
Sara-Touqan
4676e5d60e
New module: onyx_bfd ( #64359 )
...
* Supporting BFD in Ansible
* Modifying BFD module
2020-01-08 12:03:32 -05:00
Sara-Touqan
37dd3c3aa4
Supporting SNMP Hosts Configurations in Ansible ( #63983 )
...
* Supporting SNMP Hosts Configurations in Ansible
* Modifying SNMP Hosts Configuration.
* Modifying SNMP Hosts Configurations.
* Modifying SNMP Hosts Configurations
* Modifying SNMP Hosts Configurations.
* Modifying SNMP Hosts Configurations Code.
2020-01-08 11:51:58 -05:00
Sara-Touqan
24781c01be
Supporting AAA Configs in Ansible. ( #64434 )
2020-01-08 11:51:37 -05:00
Sara-Touqan
96b1efdce4
Supporting bfd command in Ansible. ( #64509 )
2020-01-08 11:51:25 -05:00
Martin Krizek
45240213be
Move bitbucket unit tests to separate dir ( #66237 )
2020-01-07 17:02:27 +01:00
Rohit
2f996fc6e2
vyos_config bug fix #66110 ( #66122 )
...
Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>
2020-01-03 17:35:37 +05:30
Felix Fontein
17ef253ad1
docker_network: fix multiple subnet (of same IP version) idempotence ( #65839 )
...
* Fix multiple subnet (of same IP version) idempotence for docker_network.
* Add changelog.
* Unit tests no longer make sense, since the part of the code they test has been removed.
* Re-add CIDR validation. Move it to better position (module setup instead of idempotence check).
* Update changelog.
* Only run new tests on VM test images.
* Actually do what is documented. Especially since an empty object is a valid value for aux_addresses.
2019-12-29 23:16:17 +01:00
Rohit
52f3ce8a80
allowing banner without stripping spaces ( #62573 )
...
Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>
2019-12-27 12:43:09 +05:30
anas-shami
ec0885cf05
Onyx username ( #63897 )
...
* Support username command to config users and edit capabilities
* Add disconnected param to disconnect all session for such user
* Edit yaml examples, add types to docs and edit the version
* Add fullname attribute
* Add no_log to password field and mutually_execlusive relations
* Fix pep8 issue
* remove debug line
2019-12-17 14:01:03 +05:30
anas-shami
557c8ab161
support syslog remote module ( #63195 )
...
* support syslog remote module
* change enabled implementation and edit the tests, also support disable override class
* fix the level order and delete types from choices
2019-12-17 12:12:55 +05:30
Sara-Touqan
84572c3b67
Supporting ntp servers and ntp peers configuration in Ansible. ( #63714 )
...
* Supporting ntp servers and ntp peers configuration in Ansible.
* Modifing ntp servers and peers config.
* Modifying ntp peers and servers configuration.
2019-12-17 11:51:29 +05:30
Sara-Touqan
d0d8fca334
Supporting SNMP Users Configurations in Ansible ( #63778 )
2019-12-17 11:50:58 +05:30
Sara-Touqan
fe354ed183
Supporting general ntp configurations in Ansible ( #63724 )
...
* Supporting general ntp configurations in Ansible
* Modifying ntp module
2019-12-17 11:50:32 +05:30
Sara-Touqan
13d0ebd603
Supporting general snmp configurations in Ansible ( #63723 )
...
* Supporting general snmp configurations in Ansible
* Modifying SNMP General configurations.
* Fix pycodestyle issues
Signed-off-by: Sara Touqan <sarato@mellanox.com>
* Fix documentation errors
Signed-off-by: Sara Touqan <sarato@mellanox.com>
2019-12-17 11:49:56 +05:30
anas-shami
33338decf7
Feature/onyx syslog files ( #62746 )
...
* support syslog files
* nested doc fix
* required togother
* fix docs type dict
* add file-debug feature same as files logging
* remove duplicated validation and change dict key access method
* add format of upload url and change the way of getting data from dict
2019-12-17 11:24:33 +05:30
Suhas Bharadwaj
0a04a5efc2
adding the modules to /nxos/storage/ folder ( #64269 )
...
* adding the modules to /nxos/storage/ folder
* fix pep8 stuff
* fixed provider specific information from doc
* Fix integration tests
* Added tested against note
* Review comments
* added assertions for the commands sent in the integration tests
2019-12-16 14:44:33 +05:30
Paul Belanger
5046413b6d
Fix flake8 errors for iosxr tests ( #65860 )
...
These were noticed when we migrated to the cisco.iosxr collection.
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2019-12-15 23:48:28 -05:00
Chris Van Heuveln
d72025be75
nxos_interfaces: RMB state fixes ( #63960 )
...
* nxos_interfaces: RMB state fixes
* shippable fixes
* Add add'l comments per review
* fix long line
* Fix mode/enabled system defaults handling
* fix N3L test skips
* lint
* test updates for titanium images
* doc fix
2019-12-13 18:06:21 +05:30
Paul Belanger
ea164fdde7
Clean up flake8 errors on ios unit tests ( #65782 )
...
This was caught during our collection migration process.
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2019-12-12 19:26:54 -05:00
Paul Belanger
80333f9c4b
Clean up flake8 errors for eos unit tests ( #65753 )
...
These were found while migrating our content to eos collections.
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2019-12-12 07:44:13 -05:00
Sebastian Wagner
a0cf42ae32
removed unnecessary ipv* address-family statements from vrf if the ip version is not used ( #53866 )
2019-12-12 00:29:23 +05:30
Felix Fontein
95c85b395c
Add hetzner_firewall_info module. ( #65421 )
2019-12-05 20:40:11 +05:30
GomathiselviS
d710a5cd7f
eos_interfaces: Added unit testcases for eos_interfaces ( #63813 )
...
* Added unit testcases for eos_interfaces
* Corrected lint errors
* Corrected lint errors
* Addressed Review comments
2019-12-03 18:42:26 -05:00
Felix Fontein
5f6057598e
Hetzner: dedicated server firewall module ( #65399 )
2019-12-02 09:19:49 +01:00
Hans Jerry Illikainen
a0b8b85fa5
ufw: add support for interface_in and interface_out ( #65382 )
...
* ufw: escalate privileges in integration tests
A few of the integration tests for the UFW module forgot to `become`.
This is problematic if the test suite is executed as a non-privileged
user. This commit amends that by adding `become` when appropriate.
* ufw: add unit tests for direction and interface
Extend the unit tests for the UFW module to test the `direction` and
`interface` parameters. This will help in the implementation of a fix
for issue #63903 .
* ufw: add support for interface_in and interface_out
The UFW module has support for specifying `direction` and `interface`
for UFW rules. Rules with these parameters are built such that
per-interface filtering only apply to a single direction based on the
value of `direction`.
Not being able to specify multiple interfaces complicates things for
`routed` rules where one might want to apply filtering only for a
specific combination of `in` and `out` interfaces.
This commit introduces two new parameters to the UFW module:
`interface_in` and `interface_out`. These rules are mutually exclusive
with the old `direction` and `interface` parameter because of the
ambiguity of having e.g.:
direction: XXX
interface: foo
interface_XXX: bar
Fixes #63903
2019-12-02 08:01:44 +01:00
