Commit graph

4824 commits

Author SHA1 Message Date
Eri Bastos
82ec224a93 Proposed fix for issue #7757 2014-08-25 12:10:14 -05:00
James Cammarata
795eaccecb Merge pull request #8725 from quiver/fix-get_url-content-disposition
[get_url module]parse content-disposition filename parameter even if it's not quoted
2014-08-25 10:43:06 -05:00
James Cammarata
0dda8a7996 Tweaking change to documentation language for cron name param 2014-08-25 09:54:21 -05:00
James Cammarata
a415993142 Merge branch 'devel' of https://github.com/mattparker/ansible into mattparker-devel 2014-08-25 09:51:17 -05:00
James Cammarata
2d683cbd30 Merge pull request #8740 from mattparker/patch-1
Name appears to be a required parameter for cron module
2014-08-25 09:49:58 -05:00
James Cammarata
69484fac7b Merge pull request #8736 from ericdwhite/issue-8735-Trim-docker-module-expose-items
module docker - expose will fail to port forward network connections if there are spaces in the CSV value
2014-08-25 09:46:22 -05:00
James Cammarata
0aec8244c8 Merge pull request #8738 from bcoca/acl_tilde_expansion
now acl expands tildes
2014-08-25 09:32:58 -05:00
James Cammarata
77ef324ab7 Merge pull request #8729 from ercpe/openrc-hostname
Hostname strategy implementation for OpenRC based systems (e.g. Gentoo)
2014-08-25 09:28:29 -05:00
Matt Parker
fd982cf8b7 Update cron documenation
The "name" parameter seems to be rather important as the identifying feature of a cron job.  This is an update to the documentation to further emphasize this.
2014-08-25 10:29:45 +01:00
Matt Parker
dc634bc644 Name appears to be a required parameter
As far as I can tell, `name` is a required parameter.  The guard test at (now) line 458 says you need name if `state == present` and at 464 if `state != present`, although that's not quite as clear.  Each of the code paths at 485 - 495 pass the name param through to `add_job`, `update_job` and `remove_job`, and the actual _update_job method earlier seems to require it too.  However I don't really know python so I may be wrong, but I can't see the circumstances when `name` is not required.
2014-08-25 10:23:54 +01:00
Brian Coca
f6e10b580e now acl expands tildes 2014-08-24 19:16:15 -04:00
Eric D. White
f44125ccb7 Issue 8735 - module docker - expose values should be striped to ensure port forwarding works. 2014-08-24 21:07:26 +01:00
Johann Schmitz
9945a732f7 Hostname strategy implementation for OpenRC based systems (e.g. Gentoo) 2014-08-23 09:00:28 +02:00
George Yoshida
b2385870af For content-disposition response header field, try to parse filename parameter even if it's not quoted. 2014-08-23 12:10:45 +09:00
Michael DeHaan
a419ffdf41 Make command warnings off by default to minimize surprises. 2014-08-22 16:12:48 -04:00
Michael DeHaan
7ffa9cecae Docs for command warnings feature. 2014-08-22 15:37:07 -04:00
Michael DeHaan
fcb610dec4 Slightly trim down the warnings list based on some things being pretty common
for local usage.
2014-08-22 15:37:07 -04:00
Will Thames
ab8490d003 Added warnings to command module
Generate warnings when users are shelling out to commands
rather than using modules

Can be turned off on a per-action line with the documented
warn=False flag. Can be turned off globally using
command_warnings = False in ansible config file.

Print out warnings using the standard playbook callbacks.

Created some additional tests in TestRunner.test_command
and also a demonstration playbook.
2014-08-22 15:37:07 -04:00
James Cammarata
6b3f7a82fb Fixing bug with image/tag pulling in docker module
Fixes #8670
2014-08-22 14:08:40 -05:00
Michael DeHaan
3871eebfbb Merge pull request #8441 from willthames/unarchive_dest_fix
Unarchive should work when parent directory is not writable
2014-08-22 15:05:42 -04:00
Michael DeHaan
b0e863b3f8 Merge pull request #8659 from willthames/rds_module_connection_fix
rds_module: Fix AWS connection
2014-08-22 14:45:27 -04:00
James Cammarata
311ec543af If not specified, do not modify subnet/route_tables for ec2 VPCs
Also fixes a bug whereby any changes to the route_tables were not
properly reflected by setting changed=True.

Fixes #8666
2014-08-22 11:03:41 -05:00
James Cammarata
b98348c2c1 Merge branch 'relative-path-fix' of https://github.com/major/ansible into major-relative-path-fix 2014-08-21 15:32:51 -05:00
Major Hayden
c9cdc9d6f9 File module cannot create relative paths
When trying to create a directory relative to the current working
directory, a directory is created at the root of the filesystem
instead.  This patch ensures that directories specified with relative
paths will be created in the current working directory.  Fully
qualified paths aren't affected

Signed-off-by: Major Hayden <major@mhtx.net>
2014-08-21 15:31:06 -05:00
James Cammarata
8956c636a5 Remove incorrect use of module.fail_json during import check for s3
Fixes #8698
2014-08-20 12:04:46 -05:00
Paul Armstrong
09979ac20d asg-properties Get all the properties from ASG's 2014-08-19 15:25:47 -07:00
Michael DeHaan
e6be619257 Merge pull request #8678 from 0x44/debconf-vtypes
debconf module: add the missing 'error' vtype and reorder vtypes as they...
2014-08-19 17:57:53 -04:00
James Cammarata
8648fa175c Removing skipped=True from result when using creates= and removes=
Fixes #8645
2014-08-19 09:09:13 -05:00
Michael DeHaan
47f4dec676 In order to allow easier updates from upstream hardware vendors, we're going to be hosting network hardware
config modules on Galaxy as announced during the last release cycle.   (This excludes load balancers, which remain in core).

Please refer to https://eos.arista.com/introducing-arista-eos-roles-for-ansible/ and https://galaxy.ansible.com/list#/roles/1359
and where this content now lives.

Thanks to Peter Sprygada for the roles content!
2014-08-19 08:31:49 -04:00
Ding Deng
13db184d7f debconf module: add the missing 'error' vtype and reorder vtypes as they appeared in debconf-devel(7). 2014-08-19 17:44:02 +08:00
James Cammarata
379e31883c Fix check mode issues with copy module
Fixes #8639
2014-08-18 16:02:45 -05:00
James Cammarata
e2b8f05b79 Add option to disable ControlPath to ssh options during rsync
Fixes #8473
2014-08-18 12:59:00 -05:00
James Cammarata
92f7aa79b0 Fix bad commit from #8095 and fix bad splitting on :'s in the image
Fixes #8095
Fixes #8658
2014-08-18 10:37:07 -05:00
Will Thames
0083212704 Fix RDS AWS connection
Use the common AWS connection improvements so that security_token,
boto_profile etc. are taken into account
2014-08-18 14:43:07 +10:00
Michael DeHaan
91560c00a9 Merge pull request #8627 from rghe/devel
fixes #8626 by reverting 0d8b81cd
2014-08-15 13:42:11 -04:00
James Cammarata
8dafacd4e9 Make env param a dict type instead of list
Also modifies param type checking code to remove whitespace from
around params before splitting them into k=v pairs.

Fixes #8199
2014-08-15 11:04:27 -05:00
rghe
9b6df6d9a8 fixes #8626 by reverting 0d8b81cd 2014-08-14 18:10:58 +02:00
Michael DeHaan
9e0090e21b Merge pull request #8612 from mjaschen-forks/devel
Homebrew module: Added `+` and `.` characters to the package name regex.
2014-08-14 10:52:25 -04:00
Marcus Jaschen
c6ac95d403 Homebrew module: Added + and . characters to the package name regex.
Solves installation failures for packages like `bonnie++` or
`virtualhost.sh` as described in #8413.
2014-08-13 22:31:03 +02:00
Eric Brown
8e6c219ee9 Update keystone_user doc for tenant_description
The description var should be tenant_description.

Closes-bug: #8299
2014-08-12 16:49:33 -07:00
James Cammarata
a04efa2d84 Update docs for copy directory_mode param per #8572 2014-08-12 12:19:13 -05:00
Michael DeHaan
f186bcc936 Copy recursion works when source is a parameter, there is no parameter 'recurse' here. 2014-08-11 16:22:13 -04:00
Michael DeHaan
734548d8b4 Merge pull request #8525 from kamaln7/patch-1
Replace all occurrences of "Digital Ocean" with "DigitalOcean"
2014-08-11 16:04:04 -04:00
Matt Martz
315ac22437 Need to check e.errno instead of os.errno. Fixes #8548 2014-08-11 12:26:52 -05:00
James Cammarata
83fa9a8cde Make sure we only use unquote on quoted lines in lineinfile when needed 2014-08-11 11:23:52 -05:00
James Cammarata
b3371b8de8 Unquote lines that were quoted for safety during eval in lineinfile
Fixes #8535
2014-08-11 11:01:23 -05:00
Michael DeHaan
e66e4adedc Merge pull request #8532 from piffey/8502_acl
Issue 8502: Fixed bug where failed when permissions weren't specified.
2014-08-11 08:15:27 -04:00
Michael DeHaan
82564df61a Merge pull request #8544 from Tenzer/faster-apt_repository
apt_repository: Check if key already exists before adding it
2014-08-11 08:09:19 -04:00
Jeppe Toustrup
b811df38a7 apt_repository: Check if key already exists before trying to add it for a speed increase 2014-08-11 11:57:23 +02:00
Piffey Parlance
cb0b06aa42 Issue 8502: Fixed bug where failed when permissions weren't specified. 2014-08-09 12:02:24 -05:00