Commit graph

8338 commits

Author SHA1 Message Date
Brian Coca
ab96ff8b6d service cleanup 2016-12-08 11:22:30 -05:00
Stewart Rutledge
0f1bf6c8c1 Fixed a typo on power options 2016-12-08 11:22:30 -05:00
Jérémie Astori
c52bfe3e35 Fix #91: Expand user home folder for the key_file path of the git module 2016-12-08 11:22:30 -05:00
Chris Church
262624ca12 Update win_feature module to work on server 2008 and fail with error message on non-server windows, fix output messages and error handling. 2016-12-08 11:22:30 -05:00
Chris Church
c81c192dcb Update win_user module to support more user options and group membership changes. 2016-12-08 11:22:30 -05:00
sterutkb
944ce9c7c3 Added support for deploying virtual machine from a virtual template 2016-12-08 11:22:30 -05:00
Michael Scherer
4e4e0cca17 Fix old ticket #9092 where a playbook can enter in recursion
This can be tested with this command :

    ansible -c local -m copy -a 'src=/etc/group dest=foo/' all

This is a corner case of the algorithm used to find how we should
copy recursively a folder, and this commit detect it and avoid it.

Check https://github.com/ansible/ansible/issues/9092 for the story
2016-12-08 11:22:30 -05:00
Philip Misiowiec
3f4d412bff Ability to specify new SSD EBS option 2016-12-08 11:22:30 -05:00
Patrik Lundin
8a6a4a7757 Simplify self.arguments logic.
Strange logic pointed out by @jarmani, thanks!
2016-12-08 11:22:30 -05:00
Patrik Lundin
2b18e544f5 Depend more on rcctl if it is present.
* Make the module support enable/disable of special services like pf via rcctl.
  Idea and method from @jarmani.
* Make the module handle when the user supplied 'arguments' variable does not
  match the current flags in rc.conf.local.
* Update description now that the code tries to use rcctl for everything if it
  is available.
2016-12-08 11:22:30 -05:00
Will Thames
63656e5ef7 Fixed tagging 2016-12-08 11:22:30 -05:00
Denver Janke
61cfccff1c Fix few bugs around renaming db instances. 2016-12-08 11:22:30 -05:00
Will Thames
daac0e3a3e Improved error handling
More tests, particular for failure testing
2016-12-08 11:22:30 -05:00
Patrik Lundin
25c3c03a11 Tweak error checking for "enabled" code.
Based on input from @jarmani:
* A return value of 2 now means a service does not exist. Instead of
  trying to handle the different meanings of rc after running "status",
  just look at stderr to know if something failed.
* Skip looking at stdout to make the code cleaner. Any errors should
  turn up on stderr.
2016-12-08 11:22:30 -05:00
Patrik Lundin
32cb025b85 Fail if "rcctl status" writes to stderr. 2016-12-08 11:22:30 -05:00
Patrik Lundin
03d4b76b14 Check rc and print error message if any.
It is probably good to use stdout before printing a generic error
message as well.
2016-12-08 11:22:29 -05:00
Patrik Lundin
38d8db473f Make "enabled" code aware of --check mode. 2016-12-08 11:22:29 -05:00
Jonathan Armani
d1433eca14 Add enable / disable of services for OpenBSD if rcctl is present 2016-12-08 11:22:29 -05:00
Will Thames
22a3b3f811 RDS rewrite to use boto.rds and boto.rds2
Using rds2 allows tags and the control over whether or not DBs are
publicly accessible.
Move RDS towards a pair of interfaces implementing the details of rds
and rds2
Added tests to ensure that all operations work correctly as well as
requirements files that allow virtualenvs to test either boto.rds or
boto.rds2
2016-12-08 11:22:29 -05:00
Antti Salminen
75e15e2ae9 Find the actual commit annotated tags refer to instead of the tag object. 2016-12-08 11:22:29 -05:00
willthames
ef88ff6dd8 Added the ability to remove snapshots
Added state option, and accompanying snapshot_id option for
when state=absent.
2016-12-08 11:22:29 -05:00
Michael DeHaan
f875cc5197 Remove potentially out of date or specific product references. 2016-12-08 11:22:29 -05:00
Michael DeHaan
76efaa6cfb More EC2 doc tweaks 2016-12-08 11:22:29 -05:00
Michael DeHaan
590d20db24 Misc EC2 doc tweaks. 2016-12-08 11:22:29 -05:00
Toshio Kuratomi
ddc81c7b93 Escape % in db+table names before adding to a format string being passed into db.execute()
Fixes #416
2016-12-08 11:22:29 -05:00
Dan
fe787f1bc9 Adds a login_unix_socket option to the postgresql_privs module. 2016-12-08 11:22:29 -05:00
Dan
ee65c55fb0 Adds a unix_socket/login_unix_socket option to the postgresql_user module. 2016-12-08 11:22:29 -05:00
Dan
789ee410f1 Adds a login_unix_socket option to the postgresql_db module. 2016-12-08 11:22:29 -05:00
René Moser
ceeeea84cd yum: add update_cache option
Yum does not always update to latest package version unless metadata cache has expired. By runing yum makecache, we ensure the metadata cache has been updated.

Signed-off-by: René Moser <mail@renemoser.net>
2016-12-08 11:22:29 -05:00
Toshio Kuratomi
5734838cd1 Fix module traceback instead of returning an error 2016-12-08 11:22:29 -05:00
Eric
11bd0fed9d Fix lineinfile documentation typo 2016-12-08 11:22:28 -05:00
Achilleas Pipinellis
872f6aa559 Clarify supported init systems. 2016-12-08 11:22:28 -05:00
follower
4889701874 Fix typo of "rules_egress"
Or is "rules_egree" supposed to be a plural? The sentence is difficult to parse.

Maybe the correct fix is to "Purge existing rules on security group that are not found in rules_egress"?
2016-12-08 11:22:28 -05:00
Pascal Borreli
187b07e6c0 Fixed typo 2016-12-08 11:22:28 -05:00
Fabrice Bernhard
3d437b068e Typo in comments
Credit goes to @kbsali
@pborreli : you did not see that one? :-)
2016-12-08 11:22:28 -05:00
Toshio Kuratomi
e8081baca9 Fix for single role_attr 2016-12-08 11:22:28 -05:00
Toshio Kuratomi
47b009b001 Add a bare grant to the list of allowed privileges 2016-12-08 11:22:28 -05:00
Toshio Kuratomi
b00e6464e9 Fix cornercase tracebaxk when detecting whether submodules changed 2016-12-08 11:22:28 -05:00
Devin Christensen
b2829cf6b9 Fix user_alter in postgresql_user 2016-12-08 11:22:28 -05:00
Devin Christensen
ff7a9eb625 Fix user_add in postgresql_user 2016-12-08 11:22:28 -05:00
Toshio Kuratomi
bed60553ca Escape mysql identifiers 2016-12-08 11:22:28 -05:00
Toshio Kuratomi
87b2afc272 Correct new function name 2016-12-08 11:22:28 -05:00
Toshio Kuratomi
3e9771f544 Normalize privs and flags to uppercase so comparisons against allowed names will work 2016-12-08 11:22:28 -05:00
Toshio Kuratomi
e0ac340f59 Make sure we quote or confirm good all user provided identifiers 2016-12-08 11:22:28 -05:00
Toshio Kuratomi
d3787840a4 Audit escaping of identifiers in the postgresql_user module 2016-12-08 11:22:28 -05:00
Toshio Kuratomi
32aaa07325 More robust quoting of database identifiers
Note: These aren't database values, those are already using the
appropriate Pyhton DB API method for quoting.
2016-12-08 11:22:27 -05:00
Toshio Kuratomi
f7fafa8c16 Cannot readlink() on a hard link 2016-12-08 11:22:27 -05:00
Toshio Kuratomi
3e09de7aef Fix git module checking out correct version after initial clone
Fixes #313
2016-12-08 11:22:27 -05:00
Toshio Kuratomi
1af6a85492 Correct variable name 2016-12-08 11:22:27 -05:00
Brian Coca
78fb3217d6 service now detects systemd is actually running, not just installed 2016-12-08 11:22:27 -05:00
Jonathan Mainguy
a71ce0615a fixes user module for rhel5 by using -n instead of -N, all other distros will still use -N 2016-12-08 11:22:27 -05:00
Henry Finucane
2363074dd8 If force=true, ignore python-apt's advice
This lets you downgrade packages, for instance.
2016-12-08 11:22:27 -05:00
IndyMichaelB
07d4ddfeff docfix for vsphere_guest.py
Corrected parameter name from user to username in documentation
2016-12-08 11:22:27 -05:00
Sam Kottler
bb9c7acc2f Remove trailing whitespace in digital_ocean_domain 2016-12-08 11:22:27 -05:00
Nejc Zupan
442c8a5457 digital ocean: Remove unsupported states 2016-12-08 11:22:27 -05:00
Toshio Kuratomi
81978cbacb Fix retrieval of package version in apt module 2016-12-08 11:22:27 -05:00
Toshio Kuratomi
83e43415da Documentation update for apt version wildcards from bryanlarsen 2016-12-08 11:22:27 -05:00
Toshio Kuratomi
9472a27345 Clean up the docker module just a little so that we can unittest the get_split_image_tag function 2016-12-08 11:22:27 -05:00
Toshio Kuratomi
f45e70fdbc Moving unittests to the main ansible repo for now 2016-12-08 11:22:27 -05:00
Toshio Kuratomi
615b954cd8 Update package_status and install to account for wildcarded versions. 2016-12-08 11:22:27 -05:00
Toshio Kuratomi
1ca1b80fe8 Decide to allow pkgname and version wildcards so that things like libxml2*=2.9* would work 2016-12-08 11:22:27 -05:00
Toshio Kuratomi
37fa22eb93 Cache pkg name list so we don't recreate the list for every package 2016-12-08 11:22:26 -05:00
Toshio Kuratomi
6b776da7bc Just make things a little more readable 2016-12-08 11:22:26 -05:00
Toshio Kuratomi
f2c1d49de7 Correct trivial spelling. 2016-12-08 11:22:26 -05:00
Toshio Kuratomi
945447e392 if __name__ does work with ansible modules 2016-12-08 11:22:26 -05:00
Michael Vogt
e360582c4a add apt unittest 2016-12-08 11:22:26 -05:00
Michael Vogt
80d520dde8 Allow foo=1.0* like expressions in apt 2016-12-08 11:22:26 -05:00
Robert Estelle
4e2d05b1f3 Remove incorrect executable permissions. 2016-12-08 11:22:26 -05:00
Adam Miller
c707107e1b fix gce_net add firewall rule example 2016-12-08 11:22:26 -05:00
John Batty
dd78dde449 Fix get_flavor_id() when flavor_ram is specified
Without this fix, _get_flavor_id() fails to find a matching flavor if
both:
* the flavor_ram parameter is specified
* the first flavor in the list does not match.

The bug is simply that the module.fail_json() call lies within the loop
iterating through the flavors.  This call should only be made if the
loop completes and no matching flavors have been found.
2016-12-08 11:22:26 -05:00
Brian Coca
5d16410518 corrected comparisson which had accidentally chaned in previous fixes 2016-12-08 11:22:26 -05:00
Brian Coca
9de01b8e10 better handling of deprecated aliases 2016-12-08 11:22:26 -05:00
Brian Coca
f91859c817 make sure 'present' is fully equivalente of 'installed' and remove installed from feedback in favoer of 'present' 2016-12-08 11:22:26 -05:00
James Martin
dd46f7275f asg will now be terminated if state=absent.
adds mutually exclusive options
2016-12-08 11:22:26 -05:00
James Cammarata
e9fbb5f1b6 Serialize tag attributes to ASG properties in ec2_asg
Fixes #108
2016-12-08 11:22:26 -05:00
James Martin
f59a1348ad Removes orphaned code. 2016-12-08 11:22:26 -05:00
James Martin
17cd9d18b0 fixes #240, #274, #108 2016-12-08 11:22:26 -05:00
Brian Coca
ba040784b8 let implied type do the spliting 2016-12-08 11:22:25 -05:00
Brian Coca
7d577e4447 minor fixes to wait_for to avoid tracebacks as per ansible core issue #9244 2016-12-08 11:22:25 -05:00
Jeff Geerling
5d103793ee Add mention of fetch module to the copy module docs. 2016-12-08 11:22:25 -05:00
Brian Coca
c071d6a85c switched to iterator as per comments 2016-12-08 11:22:25 -05:00
James Cammarata
a32a50568e Use new prompt detection in run_command to detect aptitude prompts
Also adds flags to aptitude command when force=yes is used, in order
to bypass the prompts given for untrusted packages.

Fixes #31
2016-12-08 11:22:25 -05:00
Martijn P. Rijkeboer
fcf527557d Fix whitespace around '=' in sysctl.conf. 2016-12-08 11:22:25 -05:00
José Moreira
82450c6811 Fixed small typo on ec2 task name 2016-12-08 11:22:25 -05:00
Francois Deppierraz
9620346c36 Fix a typo in nova_compute documentation string
Without this patch, ansible-doc was failing this way:

$ ansible-doc nova_compute
Traceback (most recent call last):
  File "/home/francois/WORK/dev/ansible/bin/ansible-doc", line 324, in <module>
    main()
  File "/home/francois/WORK/dev/ansible/bin/ansible-doc", line 316, in main
    text += get_man_text(doc)
  File "/home/francois/WORK/dev/ansible/bin/ansible-doc", line 112, in get_man_text
    desc = " ".join(opt['description'])
KeyError: 'description'
2016-12-08 11:22:25 -05:00
Brian Coca
a91b5fc170 made hostname work with python 2.4 2016-12-08 11:22:25 -05:00
Fwiffo
64e07acb19 typo in comments: of -> or 2016-12-08 11:22:25 -05:00
Toshio Kuratomi
34d65647bf Move from md5 to sha1 to work on FIPS-140 enabled systems 2016-12-08 11:22:25 -05:00
Michael DeHaan
98fdc389d0 Deprecate docker_image, use the docker module to deploy docker images, or shell out to docker to call docker build if you want from a playbook. 2016-12-08 11:22:25 -05:00
Brian Coca
a091d8c59a added missing init.py for utilities modules 2016-12-08 11:22:25 -05:00
Brian Coca
5a467bc72c added __init__.py to new cloud subcategories so builds work again 2016-12-08 11:22:25 -05:00
Michael DeHaan
d31ac79269 Move internal category to utilities to remove one more category from the left hand menu, keeping it concise. 2016-12-08 11:22:25 -05:00
Michael DeHaan
677ed39cb4 Renames. 2016-12-08 11:22:25 -05:00
Michael DeHaan
5d814d9fb2 Some more module categorization. 2016-12-08 11:22:25 -05:00
Brian Coca
32e85c0944 made subcategories for cloud modules for better organization 2016-12-08 11:22:24 -05:00
James Cammarata
bb9433f198 Fail in ec2 if exact_count is specified without using count_tag
Fixes ansible/ansible#9431
2016-12-08 11:22:24 -05:00
Toshio Kuratomi
dfd4433fba Fix git module handling of the recursive flag
Fixes: #169
2016-12-08 11:22:24 -05:00
Toshio Kuratomi
5fc463eee7 Update desctiprion, parameter name, and default value as discussed in #55 2016-12-08 11:22:24 -05:00
Lorin Hochstein
5c06bb6dca ec2_snapshot: document wait, wait_timeout params
Document the wait and wait_timeout params for ec2_snapshot.

This is important because snapshots can take a long time to complete,
and the module defaults to wait=yes.
2016-12-08 11:22:24 -05:00
Ashish Ranjan
57ce7b1ea1 fields in /proc/net/tcp* are not always delimited by single space 2016-12-08 11:22:24 -05:00