Commit graph

28 commits

Author SHA1 Message Date
Michael DeHaan
83f06e4162 Slightly trim down the warnings list based on some things being pretty common
for local usage.
2014-08-22 15:37:07 -04:00
Will Thames
9686385898 Added warnings to command module
Generate warnings when users are shelling out to commands
rather than using modules

Can be turned off on a per-action line with the documented
warn=False flag. Can be turned off globally using
command_warnings = False in ansible config file.

Print out warnings using the standard playbook callbacks.

Created some additional tests in TestRunner.test_command
and also a demonstration playbook.
2014-08-22 15:37:07 -04:00
James Cammarata
e55911afb2 Removing skipped=True from result when using creates= and removes=
Fixes #8645
2014-08-19 09:09:13 -05:00
Michael DeHaan
185d5a6221 Merge branch 'spelling' of git://github.com/cgar/ansible into devel
Conflicts:
	docsite/rst/guide_rax.rst
	plugins/callbacks/mail.py
2014-08-08 13:28:45 -04:00
James Cammarata
0963d4aee4 Move splitter to module_utils so modules can use it and fix command arg splitting
Fixes #8338
2014-07-29 14:55:16 -05:00
James Cammarata
0bf0053652 Fixes for module param counting and additional shell quoting issues 2014-07-23 22:54:59 -05:00
James Cammarata
cf8905b2b0 Fixing up shell quoting issues 2014-07-22 10:09:11 -05:00
James Cammarata
274e1f4106 Security fixes:
* Strip lookup calls out of inventory variables and clean unsafe data
  returned from lookup plugins (CVE-2014-4966)
* Make sure vars don't insert extra parameters into module args and prevent
  duplicate params from superseding previous params (CVE-2014-4967)
2014-07-21 11:20:49 -05:00
Michael DeHaan
9b587dafed Add note about useful quote filter. 2014-07-18 18:23:48 -04:00
Rik
8f25698925 Added examples to the command module 2014-06-24 13:47:23 +02:00
Rik
0b8aec9547 Added examples to the shell module 2014-06-24 13:45:33 +02:00
Carlos E. Garcia
4dcaa9d9fb multiple spelling error changes 2014-04-29 10:41:05 -04:00
Michael DeHaan
6fbf707a48 Clarify free_form isn't a real option :) 2014-04-03 17:34:33 -04:00
Cristian Ciupitu
7f681c33a2 Micro-optimization: replace s.find(x)!=-1 with x in s
timeit shows a speedup of ~3x on Python 2.7.5 x86_64.
It also makes the code a bit shorter.
2014-03-16 13:10:28 -04:00
James Tanner
fc33860e5d Force command action to not be executed by the shell unless specifically enabled 2014-03-10 16:13:30 -05:00
jeromew
2fcce7e225 Add creates= and removes= to the script: action 2014-02-18 12:52:09 +00:00
James Cammarata
6ed8c594f4 Adding no_log: capability for tasks
Fixes #4088
2014-01-31 16:58:46 -06:00
Jeff Geerling
128a2fb461 Mention shell module in command documentation
Users who use the command module for pretty much all shell commands may be stymied when they try using a command with <, >, $VAR, etc., and not know that they can use the `shell` module instead. This documentation fix clarifies this.
2014-01-27 14:56:52 -06:00
Stoned Elipot
0955744b3a shell module: document removes option and sync with command module doc 2013-12-25 12:12:11 +01:00
James Tanner
38edad70ac Fixes #5023 Convert all modules to use new snippet import pattern 2013-12-02 15:11:23 -05:00
Michael DeHaan
4c35b7f380 There's a cleaner way to do this, commit to module formatter pending.
Revert "No longer need to reference 'version_added' in docs for these, as this was quite a while ago."

This reverts commit ff0a41d446.
2013-11-27 21:23:03 -05:00
Michael DeHaan
9e4d71203d No longer need to reference 'version_added' in docs for these, as this was quite a while ago. 2013-11-27 21:19:32 -05:00
Michael DeHaan
08996d78d6 Add version_added to all modules missing version_added information, the docs formatter will now
raise errors when omitted, updated changelog with new modules.
2013-11-18 18:55:49 -05:00
Jesse Keating
286ff41167 Allow for relative paths by using abspath
relative pathing comes in handy on occasion, particularly when
delegating to localhost and running some command out of your playbook
repo. Making use of os.path.abspath will allow for the full path to
chdir and executable to be discovered if not provided.
2013-08-20 22:48:42 -07:00
Jan-Piet Mens
98c1423269 Docs: consistently format playbook EXAMPLES 2013-06-17 08:53:46 +02:00
Jan-Piet Mens
3404a0fc16 DOCS: standardize on EXAMPLES (a.k.a. Docs-JumboPatch JetLag Edition)
Migrated all examples: in DOCUMENTATION=''' string to standalone EXAMPLES=''' string
  Added deprecation warning to moduledev.rst and remove deprecated example from it
  Fixed up a few typos and uppercased some acronyms.
  add consistency to how EXAMPLES are formatted
2013-06-15 20:54:25 +02:00
Stoned Elipot
85529d4022 No need to expanduser() command's chdir argument twice 2013-05-29 17:05:11 +02:00
Michael DeHaan
cd97a4cb14 Allow modules to be categorized, and also sort them when generating the documentation. 2013-04-28 15:03:45 -04:00