Commit graph

856 commits

Author SHA1 Message Date
jctanner
4047096ac4 user: Cast all arguments to string before passing to run_command (#4398)
Fixes #4397
2016-08-11 19:16:24 -04:00
Brian Coca
1eb01d7612 remove X bit 2016-08-11 14:21:24 -04:00
Indrajit Raychaudhuri
23ebb98570 Improve hostname module to support systemd in more generic way (#4382)
Now that there is general purpose `Fact` helper to detect if systemd
is active, we would be able to rely on that to apply SystemdStrategy.

Detecting presence of systemd at runtime would be more reliable than
distribution version based heuristics. (e.g., Debian, Ubuntu allows
user to change the default init system, Gentoo allows switching as
well, and so on).
2016-08-11 17:44:16 +02:00
Brian Coca
f3e761f0c8 improved logic when dealing with init scripts 2016-08-11 09:43:16 -04:00
Brian Coca
92b4ae4768 fixes corner case for systemd services
when both unit file and sysv init script exist
Thanks to @olfway for fix.

fixes #3764
2016-08-11 09:24:42 -04:00
Evan Kaufman
4905ab66d6 Fixes #3791 cron always returning changed state for multiline jobs (#4285)
Strip only newlines and carriage returns. Instead of stripping ALL whitespace, which may have unintended side effects
2016-08-10 23:43:58 +02:00
BradLook
7c4de52693 Allow cron to target remote user (#4270) 2016-08-10 23:30:09 +02:00
Michael Scherer
c46e425846 Add a example with a non service unit (#4355)
Since the documentation focus mostly on service
units, a explicit example may help people realizing
it can be used for socket and timer too.
2016-08-08 08:48:33 -04:00
Michael Scherer
21c9f0defc Do not hardcode default ssh key size for RSA (#4074)
By default, ssh-keygen will pick a suitable default for ssh keys
for all type of keys. By hardocing the number of bits to the
RSA default, we make life harder for people picking Elliptic
Curve keys, so this commit make ssh-keygen use its own default
unless specificed otherwise by the playbook
2016-08-02 21:59:10 +02:00
Christian Schwarz
635c37cec6 system/service.py: fix false-positive service enablement on FreeBSD. (#4283)
sysrc(8) does not exit with non-zero status when encountering a
permission error.

By using service(8) `service <name> enabled`, we now check the actual
semantics expressed through calling sysrc(8), i.e. we check if the
service enablement worked from the rc(8) system's perspective.

Note that in case service(8) detects the wrong value is still set,
we still output the sysrc(8) output in the fail_json() call:
the user can derive the exact reason of failure from sysrc(8) output.
2016-08-01 13:35:39 -04:00
Marcos Diez
f7558164b5 better authorized_keys documentation (#3739) 2016-07-12 08:52:00 -04:00
Brian Coca
7437b6b25f updated checkmode for update-rc.d
fixes #4146
2016-07-11 09:39:30 -04:00
jctanner
db8af4c5af add gather_timeout parameter (#4093) 2016-07-08 17:22:05 -04:00
Christian Schwarz
f5e8204dbc service module: use sysrc on FreeBSD (#4042)
* service module: use sysrc on FreeBSD

sysrc(8) is the designated userland program to edit rc files on FreeBSD.

It first appeared in FreeBSD 9.2, hence is available on all supported
versions of FreeBSD.

Side effect: fixes #2664

* Incorporate changes suggested by bcoca.

- Use `get_bin_path` to find sysrc binary.
- Only use sysrc when available (support for legacy versions of FreeBSD)
2016-07-05 09:43:05 -04:00
Brian Coca
380fb2be59 make daemon reload first thing always run
otherwise service detection can fail before we run it which might
be required to actually detect the service.
2016-07-05 08:55:19 -04:00
Michael LoSapio
e626803882 Showing some of the sysctl settings in proper yaml format per Ansible documentation (#4073) 2016-06-30 19:27:41 -04:00
Allen Sanabria
343c3ecfb9 Fixes #1715 Allow authorized_module accept multi. (#3573)
This will allow the authorized_module to accept options that can be
passed multiple times into ssh options. For instance permitopen.
2016-06-20 17:32:44 -04:00
Thomas Quinot
00fb13010c Clarify behaviour when state=present and no name is given (#3904) 2016-06-10 13:03:01 -04:00
Robin Naundorf
9c52f781c9 Fixed Typo in Examples of systemd module (#3870) 2016-06-06 13:50:47 -04:00
Brian Coca
a412451a89 fixed issue with multiline output from systemd
fixes #3868
2016-06-06 09:40:23 -04:00
Brian Coca
c50859d20b fixed enabled state 2016-06-01 12:34:26 -04:00
Brian Coca
b9686fbadf fixed reported state 2016-06-01 12:30:20 -04:00
Erik Nadel
7491a11581 Added statement about escaping characters in chron tasks (#3770) 2016-05-27 14:46:43 -04:00
Dmitry Marakasov
68cb864aad Fix crontab argument order for writing (#3750)
Currently, when writing user's crontab, ansible calls

    crontab <file> -u <user>

This is incorrect according to crontab(1) on both FreeBSD and Linux,
which suggest that file argument should be the last.

At least on FreeBSD, this leads to incorrect cron module bahavior which
writes to root's crontab instead of users's
2016-05-27 06:54:03 +02:00
Brian Coca
96b2bc9084 fixed enabled reporting 2016-05-26 13:55:48 -04:00
Brian Coca
beb9ff9170 fixed typo 2016-05-26 13:22:21 -04:00
Brian Coca
d03914ed63 added state in results for backwards compat 2016-05-26 13:20:49 -04:00
Brian Coca
fb77ab49ab first draft systemd service plugin (#3660)
* first draft systemd service plugin

* now systemd status handles multiline values
2016-05-25 17:20:08 -04:00
Marcos Diez
873a7435df Added one extra example in the authorized_key module. (#3637) 2016-05-24 14:50:22 +02:00
Ken Mitchell
b903c54bac Proposed fix to not require src and fstype arguments for mount. Issue #1259. (#1357) 2016-05-23 11:20:10 -04:00
jctanner
76b7de943b Do not ignore the primary group if modifying the list of secondary groups. (#3585)
Fixes #1118
2016-05-19 22:37:57 -04:00
Michael Scherer
a62f088a24 Port seboolean to py3/py2.4 syntax (#3679) 2016-05-17 10:23:06 -07:00
Michael Scherer
c1e40b73f7 Port mount to python3 and python 2.4 compatible syntax (#3678) 2016-05-17 10:22:29 -07:00
Michael Scherer
f41a90eae4 Port authorized_keys to a syntax compatible with python3 and 2.4 (#3677) 2016-05-17 10:21:55 -07:00
Michael Scherer
2e0307e083 Port hostname to a py24 and py3 compatible syntax (#3676) 2016-05-17 10:21:26 -07:00
Michael Scherer
b19a8a9b8f Port sysctl to a py3 and py24 compatible syntax (#3675) 2016-05-17 10:20:36 -07:00
Michael Scherer
afce9e5855 Port cron to a py3 and py24 compatible syntax (#3674) 2016-05-17 10:19:19 -07:00
Michael Scherer
b49ca52912 Port user module to python3 and 2.4 compatible syntax (#3673) 2016-05-17 10:18:19 -07:00
Toshio Kuratomi
9dfed7c849 Port to dual python2/python3 compat 2016-05-10 21:58:49 -07:00
Toshio Kuratomi
a355b6a1c9 Port ping to dual python3/2 compat. 2016-05-10 21:58:49 -07:00
James Tanner
9be870bb2a Revert "remove checking of stderr for insserv (#1846)"
This reverts commit 2ee6e4cf66.
2016-05-05 10:41:06 -04:00
TheSameCH
2ee6e4cf66 remove checking of stderr for insserv (#1846)
stderr of insserv can also contain warnings which can be ignored. checking rc only is more accurate.
fixes #1502
2016-05-04 22:09:55 -04:00
Brian Coca
4549ea5e85 removed incorrect defaults from docs 2016-04-25 14:43:05 -04:00
Konstantin Gribov
ab53adad4b Escape spaces, backslashes when create new entry in fstab (#3193)
Supplement to PR #1454 and issue #530.

Fixes #3192.
Fixes #1861 (introduced by PR #1454).

Signed-off-by: Konstantin Gribov <grossws@gmail.com>
2016-04-25 10:09:19 -04:00
Toshio Kuratomi
1d25c41844 Merge pull request #3525 from madpilot78/freebsd-service-sleep
Make FreeBSD subclass respect the sleep option.
2016-04-23 08:22:21 -07:00
Guido Falsi
8aac5ae7ba Make FreeBSD subclass respect the sleep option. 2016-04-23 14:10:11 +02:00
Michael Scherer
e3cb90bc2f Change home and ssh_key_file to 'path' in user module 2016-04-23 10:49:55 +02:00
Joshua Kugler
05109d16ec Fix mount's handling of passno 2016-04-12 16:42:55 -08:00
Robin Roth
d3fa192968 use custom ismount function in mount module (#2737)
* based on cpython os.path.ismount
* includes patch from http://bugs.python.org/issue2466
* fixes #2186
* when the upstream bug is fixed this should be removed/rewritten
* use ismount from module_utils
2016-04-12 08:48:42 -07:00
René Moser
6a7dac5bdc Merge pull request #3168 from jdicarreira/hostname_sles10_11
Change hostname SLES 10 & 11
2016-03-23 11:23:48 +01:00