Commit graph

94 commits

Author SHA1 Message Date
Jimena Cabrera-Notari
86e7555554 Don't use keyword error in encode
This is not supported in Python 2.6. Just use positional arguments.
2014-03-06 13:33:53 +00:00
Guido Kollerie
314e621671 Emphasize target is on remote host. List supported file types.
From the documentation it is not immediately clear that the 'target'
option refers to a location on the remote host. This change emphasizes that.
In addition to .sql files, .bz2 and .gz files are supported for dumps and
restores. This is now documented.
2014-02-26 12:56:24 +01:00
Kyle Kelley
70d8be5cc2 Fix expires 2014-02-24 15:54:55 -06:00
James Martin
e312b0e5bf Properly fetching the riak version, and properly setting the python interpreter. 2014-02-19 12:12:02 -05:00
James Cammarata
c85b7d868b Merge branch 'fix-postgres_user_to_understand_pg_namespaces' of https://github.com/alanfairless/ansible into alanfairless-fix-postgres_user_to_understand_pg_namespaces 2014-02-17 10:04:12 -06:00
James Cammarata
a570280b81 Merge branch 'postgres_alter_role' of https://github.com/jinnko/ansible into jinnko-postgres_alter_role
Conflicts:
	library/database/postgresql_user
2014-02-17 09:57:31 -06:00
Arturs Vonda
df853fa92e Added port documentation to postgresql_db and postgresql_user 2014-02-07 18:27:55 +02:00
Matthew Jones
3ddfc8d471 Allow strings containing single and double quotes to be used as passwords for postgres_user 2014-02-03 17:07:17 -05:00
Timur Batyrshin
9ad52632c5 reword "except Error as e:" into "except Error, e:" to be compatible with Python 2.5 (#5852) 2014-02-03 13:00:40 -06:00
jctanner
7bab8656a3 Merge pull request #5435 from jkleckner/fix-mysql-dump-import
mysql_db module: make dump and import to use port argument
2014-01-14 13:06:33 -08:00
David Busby
ab8d5c5924 Documentation update to yield example of "WITH GRANT OPTION" which is undocumented previous 2014-01-14 12:04:32 +00:00
Alan Fairless
927a30c404 Fix postgresql_user to understand PG namespaces
Previously postgresql_user quoted user supplied identifers to create
grant statements that look like this:

    GRANT SELECT on "tablename" to "user";

Which only works if the tablename is not in a namespace.  If you supply
a namespaced tabelname like "report.revenue" then it creates this
incorrect statement:

    GRANT SELECT on "report.revenue" to "user";

Which will not find the "revenue" table in the "report" namespace, but
will rather look for a table named "report.revenue" in the current
(default public) namespace.  The correct form is:

    GRANT SELECT on "report"."revenue" to "user";

This approach could have the unfortunate effect that code that
previously relied on the other behavior to grant privileges on tables
with periods in their names may now break.  PostgreSQL users
typically shouldn't name tables as such, and users can still access the
old behavior and use tablenames with periods in the if they must by
supplying their own quoting.
2014-01-04 15:37:08 -06:00
Jim Kleckner
8ba9019797 Add quotes to password argument for dump/import
The password is passed on a command line for dump and import and needs
quoting.

Ideally, this would not be passed on a command line at all - any ideas?
Or at least have a stronger form of quoting so that embedded single
quotes will be escaped.
2014-01-02 12:04:03 -08:00
Jinn Koriech
57dc4fbea2 postgresql_user module: Gracefully handle ALTER ROLE on read-only postgres servers. 2013-12-31 18:23:45 +00:00
Jim Kleckner
59396d38e2 Fix mysql_db dump and import to use port argument
The code for mysql_db did not pass the port argument when state=dump or
state=import.
2013-12-26 16:21:16 -08:00
jctanner
8b925e93e6 Merge pull request #5099 from tartansandal/postgresql_db_check_mode
postgres_db CHECKMODE changed status
2013-12-16 11:39:16 -08:00
Jinn Koriech
fbb1018abe Fix postgresql_user documentation render 2013-12-05 16:57:56 +00:00
Jinn Koriech
e1aa94896f Add documentation for usage of encrypted postgresql passwords. 2013-12-05 10:35:35 +00:00
James Tanner
4f9aadcc07 Addresses #5023 Fix import comments 2013-12-02 15:13:49 -05:00
James Tanner
38edad70ac Fixes #5023 Convert all modules to use new snippet import pattern 2013-12-02 15:11:23 -05:00
Kahlil (Kal) Hodgson
147783528c postgres_db CHECKMODE changed status
Make the changed status for postgres_db under CHECKMODE match the
status that would be returned normally.
2013-11-29 11:29:03 +11:00
Michael DeHaan
4c35b7f380 There's a cleaner way to do this, commit to module formatter pending.
Revert "No longer need to reference 'version_added' in docs for these, as this was quite a while ago."

This reverts commit ff0a41d446.
2013-11-27 21:23:03 -05:00
Michael DeHaan
9e4d71203d No longer need to reference 'version_added' in docs for these, as this was quite a while ago. 2013-11-27 21:19:32 -05:00
Michael DeHaan
08996d78d6 Add version_added to all modules missing version_added information, the docs formatter will now
raise errors when omitted, updated changelog with new modules.
2013-11-18 18:55:49 -05:00
James Tanner
eccbd21a0d Fix typo in postgresql_user module docstrings 2013-11-14 11:57:01 -05:00
jctanner
6336129f59 Merge pull request #4686 from bcoca/postgresql_user_pwds
postgresql_user now supports users w/o a password, encrypted passwords and expiration
2013-11-14 08:55:11 -08:00
James Tanner
f7db64d69b Merge pull request #4307 from damianmoore/mysql_gzip_bzip2_support
Add support for compressing mysql dumps and extracting during import.
2013-11-07 15:07:59 -05:00
Steve Tjoa
de4b105e09 Changed parameter from 'user' to 'name' in the examples to coincide with the specs. 2013-11-02 22:42:44 -07:00
James Tanner
3370aee870 Fixes #4720 Use mysql command to restore database instead of mysqldump 2013-10-29 10:33:46 -04:00
Brian Coca
9b8b79f1fd updated to make note that password is required before v1.4
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
2013-10-26 12:47:22 -04:00
Brian Coca
0d9a6b63ea updated docs
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
2013-10-26 11:37:45 -04:00
Brian Coca
cdec70eeff now supports users w/o a password, encrypted passwords and expiration
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
2013-10-26 11:32:16 -04:00
Maykel Moya
6155bf2c55 Fail if requested variable is not available 2013-10-22 09:30:19 +02:00
James Tanner
251b52bef8 Fixes #4454 Make a temporary clean cnf file if unable to parse existing 2013-10-18 17:42:40 -04:00
Maykel Moya
2d33cf898c Improve change detection in mysql_variables
mysql_variables bindly executes a SET var = value query even when
the variable already has the requested value.

With this patch the query is executed only if the current value is
different to the requested one.
2013-10-17 19:13:58 +02:00
James Tanner
f233e29386 mysql_db: if connection is a socket, do not specify hostname 2013-10-16 09:59:31 -04:00
James Tanner
9128862b3b Fixes #4301 Use module_common functions for mysqldump and return better errors 2013-10-16 09:51:08 -04:00
Michael DeHaan
c586ed5168 Merge pull request #4342 from pileofrogs/devel
mysql_replication switch to DictCursor for compatibility with more mysql server versions
2013-10-11 06:21:22 -07:00
Michael DeHaan
daa005085d Add missing version_added doc to mysql login port parameter. 2013-10-11 09:14:14 -04:00
Dylan Martin
280ecaa453 toned down the error message for unconfigured master/slave 2013-10-10 09:15:47 -07:00
Jeroen Hoekx
19b52e9fb7 Add append_privs parameter to MySQL user module.
This adds the privileges given to the existing list of privileges
instead of overwriting any existing ones.
2013-10-03 14:57:01 +02:00
Dylan Martin
3c7f8d6272 switch to DictCursor 2013-10-02 13:00:07 -07:00
Damian Moore
85ed9af959 mysql_db now supports import and dump of gzip and bzip2 compressed files 2013-09-30 19:09:32 +01:00
James Cammarata
619a80c505 Merge branch 'devel' of https://github.com/tomdymond/ansible into tomdymond-devel 2013-09-23 14:53:46 -05:00
James Cammarata
e62844653c Merge branch 'devel' of https://github.com/abompard/ansible into abompard-devel 2013-09-06 13:51:45 -05:00
James Cammarata
d93edadbbb Merge branch 'fix_postgresql_db' of https://github.com/yteraoka/ansible into yteraoka-fix_postgresql_db 2013-09-06 13:26:01 -05:00
James Cammarata
51fedb64a9 Cleaning up pep8 whitepsace issues in the mysql_replication module 2013-09-06 12:50:50 -05:00
James Cammarata
07c825d8f5 Merge branch 'bugfix' of https://github.com/jsmartin/ansible into jsmartin-bugfix 2013-09-06 12:47:27 -05:00
James Martin
6539652a28 Fixes for python 2.4 support, better collection of riak version. 2013-09-06 13:42:27 -04:00
James Cammarata
d16ba9758e Added version_added to the mysql_variables module doc section 2013-09-06 12:32:08 -05:00