Commit graph

17529 commits

Author SHA1 Message Date
Ivan Bojer
8b617aaef5 Panos object (#28028)
* - deprecated panos_address and panos_service in lieu of common panos_object

* - deprecated/removed panos_address and panos_service in lieu for panos_object

* squash! - deprecated/removed panos_address and panos_service in lieu for panos_object

* - fixed PEP8 issues

* - ansible_metadata requires metadata_version instead of just version key in 2.4

* add > to multi line descriptions

* update version string to 2.4

* Update legacy-files.txt
2017-08-15 16:24:15 -04:00
Simon Dodsley
08767946cb Add Pure Storage Snap module (#28027)
* Add Pure Storage Snap module

* Use one line GPL license

https://github.com/ansible/community/wiki/Testing:-boilerplate,-wildcard-imports,-and-get_exception
2017-08-15 15:27:34 -04:00
saichint
064ab7a92d fix for remove idempotent issue (#28226) 2017-08-15 13:14:40 -04:00
Adrian Likins
8003437ebc prompt for new pass on create/encrypt if none specified (#28185)
* prompt for new pass on create/encrypt if none specified

Make 'ansible-vault' edit or encrypt prompt for a password
if none or provided elsewhere.

Note: ansible-playbook does not prompt if not vault password
is provided

* dont show vault password prompts if not a tty
2017-08-15 13:09:24 -04:00
giovannisciortino
09cc84c796 Fixes #27635: pam_limits fix add comment (#27999) 2017-08-15 13:07:31 -04:00
Sam Doran
a8e4c9be7a Cause copy module to fail on empty string as source (#27975)
* Fail if an empty string is set as src for copy module

Fixes #27363

* Cleanup task formatting on copy tests

Use multi-line YAML
Add debug statements with verbosity: 1 rather than leave them in there commented out.

* Add test for empty string as source

* Do more checks in order to add more specific errors messages

Add more integration tests for the various failure scenarios.
Cleanup some syntax on existing integration test tasks.
2017-08-15 12:41:16 -04:00
saichint
d69440c4ef Fix nxos_vpc issues (#28188)
* fix for nxos_vpc issues

* fix unit tests

* clean documentation
2017-08-15 12:08:55 -04:00
Nathaniel Case
1d13624eae Clean up nxos_aaa_server (#28177)
* cleanup nxos_aaa_server

* Specify nxos_aaa_server output format

Fixes #27289
2017-08-15 12:08:03 -04:00
Adrian Likins
5739bb075f Vault secrets default vault ids list (#28190)
* Add config option for a default list of vault-ids

This is the vault-id equilivent of ANSIBLE_DEFAULT_PASSWORD_FILE
except ANSIBLE_DEFAULT_VAULT_IDENTITY_LIST is a list.
2017-08-15 11:56:17 -04:00
Jiri Tyr
1b8fe94e5a Support list for baseurl and gpgkey params in yum_repository (fixes #24948) (#24967)
* Support list for baseurl and gpgkey params in yum_repository

* Adding tests
2017-08-15 11:51:33 -04:00
Nathaniel Case
20a35d0c1c Fix python3 str <-> bytes in connection/persistent.py (#28224) 2017-08-15 11:36:20 -04:00
Adrian Likins
e287af1ac8 Vault secrets empty password (#28186)
* Better handling of empty/invalid passwords

empty password files are global error and cause an
exit. A warning is also emitted with more detail.

ie, if any of the password/secret sources provide
a bogus password (ie, empty) or fail (exception,
 ctrl-d, EOFError), we stop at the first error and exit. 

This makes behavior when entering empty password at
prompt match 2.3 (ie, an error)
2017-08-15 11:01:46 -04:00
Sam Doran
271127113f Add comment option to authorized_key (#27781)
* Add comment option to authorized_keys

* Update version_added for authorized_keys comment

* PEP8

* Include index rank in parsed_key_key

*  Properly display diff

Only display diff if specificed via settings

* Fix PEP8 test failure

Removed from legacy files since it is now properly formatted

* Cleanup integration test formatting and add test for new comment feature

* Correct version_added for new option
2017-08-15 10:50:50 -04:00
René Moser
d1fa210bed yum: using install to update specified packages (#26266)
* yum: using install for update packages

* yum: fix return changed when latest version installed

* yum: fix changed when nothing to do
2017-08-15 16:20:10 +02:00
Ganesh Nalawade
a12e9807ba Add intent arguments for ios and iosxr interface modules (#28018)
* Add intent arguments for ios_interface

*  Intent argument support
*  Integration test case for intent arguments

* Fix ci issue

* Add intent arguments for iosxr_interface

*  Add intent check support for iosxr_interface
*  Integration test for intent + configuration

* Fix ci failure
2017-08-15 19:20:28 +05:30
Ganesh Nalawade
38c0b581c3 Handle common argument in aggregate parameter for vyos module (#28182)
* Handle common agrument in aggregate parameter for vyos module

*  Add supoort to set parameter in aggregate to it's respctive
   top level argument if value not provided in aggregate.
*  Aggregate argument spec validation
*  Documentation for aggregate

* Fix unit test failure
2017-08-15 19:09:44 +05:30
Ganesh Nalawade
0c4706897c Fix minor issue in junos_vlan (#28218) 2017-08-15 18:41:53 +05:30
Ondra Machacek
e9c9473819 Add power_manage_enabled option to ovirt_hosts module (#28154)
* cloud: ovirt: Add possibility to enable PM of host

* cloud: ovirt_hosts: user self.param to get module params
2017-08-15 05:32:18 -04:00
Fran Fitzpatrick
5fec649052 ipa_dnsrecord: Allow for PTR Records (supporting reverse DNS) (#26709) 2017-08-15 11:25:28 +02:00
Yanis Guenane
8ed7417ff9 openssl_csr: Allow user to specify criticality of extensions (#28173)
Allow user to mark the x509v3 extensions as critical, by specifying the
$extension_critical boolean, where $extension is the name of the
extension.

Currently this module supports only 3 differents x509v3 extensions:

  * keyUsage
  * extendedKeyUsage
  * subjectAtlName

There are more to come.
2017-08-15 04:29:29 -04:00
Andreas Olsson
c9cdc3a259 Fix zip filter for Python3
Using the now bundled six library.

Fixes #28117
2017-08-14 23:03:15 -07:00
Jordan Borean
f0a0e5674c win_iis_webapppool: tests, check_mode, bugfixes (#25869)
* win_iis_webapppool: Added integration testa and cleanup

* Updated docs and tests

* fixes from linter

* fixed up typo in docs
2017-08-15 01:14:39 -04:00
Andrew Saraceni
b0db1a1cf6 New Module: Manage Windows event logs (win_eventlog) (#27827)
* initial commit for win_eventlog module

* remove type for retention_days in documentation
2017-08-15 01:13:52 -04:00
Andrew Saraceni
bb7813f16f New Module: Write Windows event log entries (win_eventlog_entry) (#27828)
* initial commit for win_eventlog_entry module

* added test module for integration tests and minor documentation fixes
2017-08-15 01:13:14 -04:00
Jacob McGill
a8a3ad70ad ACI Subnet: New Module (#28202)
* ACI Subnet: New Module

* fix docstring

* update docstring
2017-08-15 03:46:39 +02:00
Pilou
a3f91274b3 circonus_annotation: DOCUMENTATION & argument_spec cleaning (#26832)
* circonus_annotation: clean description

- add 'default' field
- default value for 'required' field is false
- use formatting function

* circonus_annotation: clean argument_spec

remove useless conversion
default of 'required' False
use 'default' when possible

* circonus_annotation: fix pep8

* circonus_annotation: add RETURN block

* circonus_annotation: check_mode isn't supported, add a note
2017-08-14 18:40:00 -07:00
Jacob McGill
46956f0273 ACI Subject Filter Binding: New Module (#28201)
* ACI Subject Filter Binding: New Module

* add metadata

* fix whitespace
2017-08-15 03:33:11 +02:00
Dag Wieers
f8d24b4111 new module: Manage MCP interface policies [network/aci/aci_mcp] (#28206)
Manage MCP interface policies on Cisco ACI fabrics.
This module is idempotent, and supports check-mode and has diff-support.
2017-08-15 03:26:43 +02:00
Jacob McGill
5efe713bea ACI EPG Domain: New Module (#28203)
new module: managing EPG to VMM and Physical Domains [network/aci/aci_epg_domain_binding]
2017-08-15 03:24:58 +02:00
Jacob McGill
24ec04cbfc ACI Filter Entry: New Module (#28200)
* ACI Filter Entry: New Module

* fix aliases key
2017-08-15 03:24:04 +02:00
Dag Wieers
835ef7dd66 new module: Manage Layer 2 interface policies [network/aci/aci_l2_policy] (#28205)
Manage Layer 2 interface policies on Cisco ACI fabrics.
This module is idempotent, and supports check-mode and has diff-support.
2017-08-15 03:23:26 +02:00
Jacob McGill
cece18a777 aci_bd_l3out_binding.py (#28199)
new module: support for binding Bridge Domains and L3 Outs [network/aci/aci_bd_l3out_binding]
2017-08-15 03:14:53 +02:00
Jacob McGill
79afb2eff1 new module: manage Bridge Domains [network/aci/aci_bridge_domain] (#28196)
* ACI Bridge Domain: Add new module

* fix type in docstring

* fix type in docstring
2017-08-15 03:13:50 +02:00
Dag Wieers
68d487eacf new module: Manage route tag policies [network/aci/aci_route_tag_policy] (#28204)
Manage route tag policies on Cisco ACI fabrics.
This module is idempotent, and supports check-mode and has diff-support.
2017-08-15 03:13:03 +02:00
Dag Wieers
fdfb4f736d new module: manage LLDP interface policies [network/aci/aci_lldp_policy] (#28099)
* aci_lldp_interface_policy: Manage LLDP interface policies

Module to manage LLDP interface policies on Cisco ACI fabrics.
This module is idempotent, and supports check-mode and has diff-support.

* Rename aci_lldp_interface_policy to aci_lldp_policy
2017-08-15 03:12:20 +02:00
Jacob McGill
5e24fb298e Enhance module_utils to be cleaner and support more modules (#28197) 2017-08-15 02:53:29 +02:00
Dag Wieers
5a887fb1f6 aci_port_channel: Manage port channel interface policies (#28141)
Manage port channel interface policies on Cisco ACI fabrics.
This module is idempotent, and supports check-mode and has diff-support.
2017-08-15 01:51:23 +02:00
Dag Wieers
af39ed86e5 aci_span_dst_group: Manage span destination groups (#28143)
Manage span destination groups on Cisco ACI fabrics.
This module is idempotent, and supports check-mode and has diff-support.
2017-08-15 01:51:13 +02:00
Dag Wieers
9b05195a04 aci_taboo_contract: Manage taboo contracts (#28144)
Manage taboo contracts on Cisco ACI fabrics.
This module is idempotent, and supports check-mode and has diff-support.
2017-08-15 01:51:01 +02:00
Dag Wieers
42d8a9ea89 aci_port_security: Manage port security (#28142)
Manage port security on Cisco ACI fabrics.
This module is idempotent, and supports check-mode and has diff-support.
2017-08-15 01:50:12 +02:00
Dag Wieers
f7244ebb49 aci_monitoring_policy: Manage monitoring policies (#28140)
Manage monitoring policies on Cisco ACI fabrics.
This module is idempotent, and supports check-mode and has diff-support.
2017-08-15 01:49:52 +02:00
Dag Wieers
ec8b99ac06 aci_action_rule_profile: Manage action rule profiles (#28139)
Manage action rule profiles on Cisco ACI fabrics.
This module is idempotent, and supports check-mode and has diff-support.
2017-08-15 01:49:35 +02:00
Dag Wieers
67111e7fec aci_fc_policy: Manage FC interfaces on Cisco ACI fabrics (#28095)
Module to manage FC interfaces on Cisco ACI fabrics.
This module is idempotent, and supports check-mode and has diff-support.
2017-08-15 01:49:19 +02:00
Dag Wieers
4e3c3a1aa1 aci_filter: Manage filter objs on ACI fabrics (#28094)
Module to manage top level filter objects on Cisco ACI fabrics.
This module is idempotent, and supports check-mode and has diff-support.
2017-08-15 01:48:47 +02:00
Dag Wieers
d4fae9bbbc aci_contract: Manage contracts on ACI fabrics (#28093)
Module to manage contracts on ACI fabrics.
This module is idempotent, and supports check-mode and has diff-support.
2017-08-15 01:48:27 +02:00
3onyc
554496c404 [passwordstore] Use builtin _random_password function instead of pwgen (#25843)
* [password] _random_password -> random_password and moved to util/encrypt.py
* [passwordstore] Use built-in random_password instead of pwgen utility
* [passwordstore] Add integration tests
2017-08-14 15:19:40 -07:00
Dag Wieers
f345ba5c38 More maintainers is a good thing, right ? 2017-08-14 23:50:21 +02:00
Evan Kaufman
767be93f77 Replace - Clarified regex docs (#26727)
* Clarified docs regarding multiline mode and negated character sets

Refs #26712

* Escaped newline
2017-08-14 14:25:08 -07:00
René Moser
13dec9259f galaxy-cli: selective install roles in requirements file (#21412)
* galaxy-cli: force install selected roles in requirements file

* only when requirements file but also handle uninstalled roles
2017-08-14 17:17:22 -04:00
Brian Coca
d95fd7414a use proper booleans for vars_prompt 2017-08-14 16:52:53 -04:00
Sam Doran
68060002e8 Rename modules from plural to singular (#27185)
* First batch of modules renamed from plural to singular

Related to this proposal: https://github.com/ansible/proposals/issues/10

* Emit rename deprication warning

* Update legacy-files.txt and skip.txt to reflect new names
2017-08-14 16:35:15 -04:00
saichint
9d84a4e530 fix for nxos_ospf_vrf invalid cmd and ntp errors (#27977)
* fix for nxos_ospf_vrf invalid cmd

* fix for nxos_ntp issues
2017-08-14 16:09:16 -04:00
Nathaniel Case
19a6000d97 Fix nxos_bgp_af networks parameter (#28169)
* Split 'networks' and 'redistribute' in get_value

* Add missing `'` in docs
2017-08-14 15:18:10 -04:00
Jacob McGill
59f704c766 add module to support ACI Contexts (#28091) 2017-08-14 13:11:21 -06:00
Ganesh Nalawade
c9b2869f06 Add regex to retrieve socket path (#28181) 2017-08-15 00:17:20 +05:30
Toshio Kuratomi
47b534d809 Move more modules out of curated
pip to core because users frequently use pip to install packages to run
ansible modules.

win_chocolatey to community as it still needs some work before we'd be
ready to include it in core support.
2017-08-14 10:58:15 -07:00
Abhijeet Kasurde
09cabaf702 Use response.content instead of response object (#25772)
vca module utility uses response object instead of
response.content which raises exception in while fail_json
call. Use content attribute from response object instead which
is exact description of HTTP Response error.

Fixes #25378

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2017-08-14 12:40:06 -04:00
Abhijeet Kasurde
8b7a58c961 Remove redundant get_obj method (#26819)
Fix removes redundant get_obj method in favor of
find_datacenter_by_name API. Also, strict checking for
datacenter object.

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2017-08-14 12:37:36 -04:00
rahushen
b74300b657 Additional fix for #27167: port-channel interface idempotence (#27979) 2017-08-14 11:44:12 -04:00
giovannisciortino
d3e48a51f5 Add check mode support to ansible-pull (#28021)
Fixes #27989
2017-08-14 11:20:05 -04:00
Toshio Kuratomi
3edac559d3 the smart transport is broken by ssh retry code
1fe67f9 introduced retries to the ssh connection put file and fetch
file.  Unfortunately, that change broke the smart transport because it
started raising exceptions instead of returning from _run().  This
breakage is documented in #23711.

An attempt to fix it was made at #23717 but the first attempt was
objected to as needing to touch too much code.  The second attmept was
objected to as smart was forced to encapsulate retries (thus retrying
a sftp "rety" times before trying scp "retry" times and then finally
moving onto piped).  This third attempt has retries encapsulate smart.
So each sub-transport is tried once and if all three fail, another retry
attempt is made which tries each of the three again.

Fixes #23711
Fixes #23717
2017-08-14 08:08:00 -07:00
Giovanni Sciortino
ab81c6c0f3 strategy: lost list order using with_items during displaying results Fixes #21008 2017-08-14 10:59:25 -04:00
Nathaniel Case
820d7e805a Streamline nxos_smu (#28030) 2017-08-14 10:54:50 -04:00
rahushen
b9c3329950 nxos_ip_interface: Fixes for #27170, #27172 (#27935)
* Fixes for #27170, #27172

* Add nxos_ip_interface IT tests

* For ipv6 check if ip address configured before doing a no ip address
2017-08-14 10:16:08 -04:00
Arne Demmers
000df2709d Support downgrade to specific version in yum module. 2017-08-14 04:55:39 -07:00
David Newswanger
cfda267b2b fixes pipe issue (#28127) 2017-08-14 17:21:32 +05:30
Trishna Guha
60ce6438e3 fix nxos_overlay_global idempotence (#28150)
* fix nxos_overlay_global idempotence

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* modify nxos_overlay_global unittest

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2017-08-14 16:09:53 +05:30
David Newswanger
a01aa6e9df Fix structured output not supported in nxos_pim_interface (#28125)
* fixed unstructured error

* fix unit tests so they accept commands in dictionary form
2017-08-14 12:34:05 +05:30
Trishna Guha
12460dd713 Add ios_vrf declarative intent config check (#28001)
* Add ios_vrf declarative intent config check

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* add version for delay param

* modify ios_vrf unit test
2017-08-14 12:27:03 +05:30
Ganesh Nalawade
eb33cc88bd Add state intent argument in vyos interface (#28066)
* Add state intent argument in vyos interface

*  State intent argument support
*  Integration test for supported intent arguments

* Add intent testcase

* FIx ci issue
2017-08-14 10:17:41 +05:30
Ganesh Nalawade
711a6b2326 Add common aggregate arguments for junos modules (#28124)
If parameter value in aggregate is not set, fetch it's corresponding
value from top level parameters.
2017-08-14 10:17:03 +05:30
Rafał Osiecki
33e56ca496 typo fix (#27212) 2017-08-14 02:15:00 +02:00
Pierre-Louis Bonicoli
e52096e78a copy: grammar fix 2017-08-13 08:22:22 -07:00
Pierre-Louis Bonicoli
ed8279cce0 copy: fix YAML documentation format 2017-08-13 08:22:22 -07:00
Pierre-Louis Bonicoli
1f5c908370 copy: state behavior when dest is a nonexisting path 2017-08-13 08:22:22 -07:00
Pierre-Louis Bonicoli
16f2e47559 copy: use formatting options 2017-08-13 08:22:22 -07:00
Pierre-Louis Bonicoli
28eb9466c7 copy: document behavior related to dest creation 2017-08-13 08:22:22 -07:00
Ganesh Nalawade
21bd7bcbb0 junos_interface intent arguments (#27947)
* junos_interface intent arguments

*  Add check for intent argument in junos_interface
*  Integration test for intent arguments

* Minor type fixes

* Add delay only if config diff is present

* add enabled configuration argument

* net_interface test case changes

* Minor doc change
2017-08-13 13:18:15 +05:30
Marko Stanković
6e7cf7377b xml: Add example with namespaces and clarify note (#28113)
* xml: Add example with namespaces and clarify note

* Correct the line length
2017-08-13 05:04:35 +02:00
Toshio Kuratomi
394e1e350c Expand wildcard imports and add boilerplate
More amazon modules with no open PRs.
2017-08-12 10:57:01 -07:00
Pierre-Louis Bonicoli
4ecf85392e udm_user: fix broken import
Tested with:
from datetime import datetime, timedelta
from dateutil.relativedelta import relativedelta
n = datetime.now()
assert n + timedelta(days=365) == n + relativedelta(years=1)
2017-08-12 10:45:12 -07:00
Pierre-Louis Bonicoli
c52f355bcb serverless: fix broken import 2017-08-12 10:39:10 -07:00
Pierre-Louis Bonicoli
dbc422ea1c Fix 'module' object is not callable 2017-08-12 10:21:14 -07:00
Pierre-Louis Bonicoli
f9404b0d85 Fix exit_json usage: really call client.auth.logout 2017-08-12 10:21:14 -07:00
Pierre-Louis Bonicoli
b556def4d3 Update DOCUMENTATION metadata 2017-08-12 10:21:14 -07:00
Pierre-Louis Bonicoli
ac05645bce Remove commented statements 2017-08-12 10:21:14 -07:00
Pierre-Louis Bonicoli
f761fc1d1f rhn_channel: fix py3 compatibility (use six)
and remove unused import
2017-08-12 10:21:14 -07:00
Pierre-Louis Bonicoli
5f62a973da docker_secret: fix broken import 2017-08-12 10:16:05 -07:00
Pilou
feff6abd72 os_client_config: fix broken import (#26839)
* os_client_config: fix broken import
* remove wildcards and add boilerplate
2017-08-12 10:07:49 -07:00
Nick Ward
f52a022022 Python3 compatability for elb_application_lb and elb_target_group 2017-08-12 09:01:29 -07:00
Toshio Kuratomi
9a7e23569e Fix wildcard imports, remove get_exception, add boilerplate
Amazon modules that don't have open PRs against them
2017-08-12 07:43:46 -07:00
Toshio Kuratomi
7cd81b802d Fix wildcard imports, remove get_exception, add boilerplate
Fixed for monitoring modules
2017-08-12 03:13:53 -07:00
Sloane Hertel
aca1950150 iam certificate facts (duplicate): add iam_cert_facts as alias for iam_server_certificate_facts (#25387)
* add iam_cert_facts as alias for iam_server_certificate_facts
* remove from legacy files
2017-08-12 01:44:39 -07:00
Artem Zinenko
6058cb736d rabbitmq_plugin for Windows (#28017)
* Fixes #28016: rabbitmq_plugin for Windows

* Disable documentation check for rabbitmq_plugin.ps1

* Renamed rabbitmq_plugin -> win_rabbitmq_plugin

* Fixed the documentation after review

* Fixed 'RETURN' section

* Fixed docs for original module

* Added dots to original module docs.
2017-08-12 10:35:16 +02:00
Toshio Kuratomi
ac56a2f138 Remove wildcard imports and get_exception calls
Fixed module_utils
2017-08-12 00:48:53 -07:00
T. Miller
93e1caccb7 ini_file: Match tabs before options (#28102) 2017-08-12 09:17:25 +02:00
Peter Sprygada
5ee7862793 update telnet module (#28100)
* accepts list of prompts to expect
* updates doc strings
2017-08-11 23:50:01 -04:00
Brian Coca
40d29936a4 telnet action plugin (#27983)
* draft telnet action plugin

docs in module

* updated per feedback

* fixed imports

* pep8 fixes

* added meta import even though its useless
2017-08-11 22:46:26 -04:00
Toshio Kuratomi
039383d90f Fix symbolic mode usage in unarchive with zip files
Fixes #21090
2017-08-11 19:01:41 -07:00
Toshio Kuratomi
a3132e5dd6 Optimize template (#28044)
* Optimize template

* In fixing template to handle diff correctly #24477, I introduced more
  round trips to the remote end which slowed things down  The new code now
  uses one fewer round trips than the old code.
* Reimplement a large part of template by calling the copy action plugin
  instead of doing it in template's code.  This reduces the code in
  template and gives us one place to fix bugs and optimize.
* Add a follow parameter to template that mirrors the follow parameters
  for file and copy.
* Fix copy's diff handling (probably broken in my rewrite for in 2.4
  development)
* Adjusted when copy creates tmp dirs to rduce round trips in copy and
  template.

Fixes #27956
2017-08-11 17:50:49 -07:00