Commit graph

37 commits

Author SHA1 Message Date
Jesse Keating
4593e3c357 Make sure requested version tag gets downloaded
There is a subtle bug in how the git module currently works. If the
version you request is a tag name, and you've already got the repo
cloned, and the tag name is a new tag, but refers to the already checked
out working copy, the git module would exit early without change. This
is bad as it means the new tag ref was not fetched and could not be used
in later tasks.

This change will check if the version is a remote tag, and if the tag
doesn't exist locally. If that is true, it'll do a fetch.

The activity could still be seen as not a change, because the working
copy won't be updated, if the new tag refers to the already checked out
copy, but that's not different than before and can be fixed as a more
comprehensive overhaul of tracking change in the git module.
2014-02-07 14:13:04 -08:00
Michael Porter
8ccbf13a13 () Use mkstemp to open a temporary file (as NamedTemporaryFile doesn't take a delete argument in Python < 2.6) 2014-01-30 19:39:39 -05:00
James Tanner
3ec043ec17 Fixes Fail on missing ~/.ssh and ignore accept_hostkey if stricthoskeychecking is off 2014-01-28 11:49:35 -05:00
James Tanner
86ba8f4dff Fix git module parameters to conform to code standards 2014-01-23 16:44:17 -05:00
James Tanner
18050d50ec Fixes Add sshopts and keyfile parameters to the git module 2014-01-23 16:22:43 -05:00
James Tanner
eeee1e1c5a Set accept_hostkey to False by default in the git module and fail
early if the key is unknown
2014-01-11 11:02:01 -05:00
James Tanner
8665b0638a Add an "accept_hostkey" parameter to the git module to help automatically
accept hostkeys for git repos and prevent task hangs when the key is unknown
2014-01-11 10:36:45 -05:00
James Tanner
6000d636b3 Fixes Convert all modules to use new snippet import pattern 2013-12-02 15:11:23 -05:00
James Tanner
5c1fbcc9d2 Addresses fix typo in git module 2013-11-25 09:55:05 -05:00
James Tanner
d950a3d1b5 Fixes 5036 add missing parameter to git module function call 2013-11-25 09:51:07 -05:00
jctanner
ad5012f930 Merge pull request from cg-soft/git-bare-ref-repo-support
Add support for bare git reference repos
2013-11-14 10:39:57 -08:00
Michael DeHaan
337b6ce642 Fix documentation formatting. 2013-10-31 20:00:11 -04:00
Michael DeHaan
6d16f85b30 Suggest keyscan for github/other SCM hanging. 2013-10-31 18:00:24 -04:00
Christian Goetze
f41d4ac390 Add support for bare git reference repos
This adds two parameters to the git module:

  bare (boolean)
    Indicates this is to be a bare repositori

  reference (string)
    Indicates the path or url to the reference repo.
    Check out the "--reference" option in the "git clone"
    man page

Added appropriate tests.
2013-10-31 10:56:14 -07:00
Yap Sok Ann
8519d586ba git: Don't add --branch while cloning if the version is a SHA-1 hash. 2013-10-16 20:37:07 +08:00
Yap Sok Ann
9f8cdac0aa git: Handle network problem when running git ls-remote. 2013-10-16 20:37:07 +08:00
Yap Sok Ann
a53e7045a6 git: Always return the before/after revisions, even in check mode.
The return values from check mode and non-check mode should match in all cases,
except when a SHA-1 hash is used as version, as there is no way to check if it
is a valid hash using `git ls-remote`.

Also, to accomodate this change, the force flag for the reset function has been
removed so that we can do the checking in main.
2013-10-16 20:37:07 +08:00
Yap Sok Ann
b9558828e8 git: Make function get_remote_head usable when cloning.
This allows the module to return the before/after revisions in all cases.
2013-10-16 20:37:07 +08:00
Yap Sok Ann
2ad4d77c9a git: Remove unnecessary return code checking.
The functions either return rc=0 or call fail_json themselves.
2013-10-16 20:37:06 +08:00
Yap Sok Ann
9af05f4d2f git: Full length SHA-1 in, full length SHA-1 out.
This removes ambiguity at the expense of slight backward incompatibility.
2013-10-16 20:37:06 +08:00
James Tanner
b98ab745f1 fix docstring indentation on scc modules 2013-10-01 16:46:17 -04:00
Skylar Saveland
5243bd5fa3 executable option to git module 2013-09-26 14:15:28 -07:00
James Cammarata
7bd8c18fa7 Merge branch 'gitfix' of https://github.com/johanwiren/ansible into johanwiren-gitfix 2013-08-22 15:30:58 -05:00
Johan Wirén
dcd556b92f Fixed so that we no longer check with the remote if a checkout already is at the desired sha version. 2013-08-22 22:05:37 +02:00
Drew Blas
9ede377380 Added git disclaimer about dealing with ssh host checking
This disclaimer already exists in library/source_control/hg but not here.  It affects both and was discussed awhile back on: https://groups.google.com/forum/#!msg/ansible-project/q9G9xIdsRxo/XJhQzuS-qSoJ  However no PR was ever sent to fix the doc.
2013-08-07 15:33:29 -05:00
Petr Svoboda
d9576b3529 Tidy up fix of git module traceback 2013-08-02 12:54:06 +02:00
Petr Svoboda
2d5b942ffe Fix traceback in git module when version checkout fails
"UnboundLocalError: local variable 'branch' referenced before assignment" is
raised in git, line 282, in switch_version.

Exception is raised when version is not branch and version checkout fails.
E.g. when version is nonexistant commit.
2013-08-01 12:10:43 +02:00
Michael DeHaan
32d5038d72 Don't add --version HEAD parameter is already HEAD, some versions of git don't like this. 2013-07-20 11:24:16 -04:00
James Laska
95a22338a2 Resolve incompatability between depth and version
Git is unable to checkout the specified `version` when the repository is
cloned with a reduced history (`depth`).  However, if the repository is
already cloned, subsequent git module calls will update the repository
(default update=True), then properly checkout the specified `version`.
To allow the initial call to properly clone the specified `version`, at
the specified `depth`, this patch adds the `--branch` parameter when
cloning the repository.
2013-07-18 17:03:17 -04:00
Matt Spaulding
871f781ec7 Fix git submodule update when version specified 2013-07-03 17:19:14 -07:00
Stephen Fromm
76d848331f Add submodule support to git module
This does two things:
* add --recursive option to git clone command in clone().  This will
  initialize all submodules when cloning a remote repository.
* Add submodule_update() and call that from fetch().  submodule_update()
  calls two git commands iff the file .gitmodules exists in the
  repository:
  * 'git submodule sync' - synchronizes the submodules' remote URL
    configuration setting to the value in .gitmodules.
  * 'git submodule update --init --recursive' - initialize and update
    registered submodules to the commit specified in the index of the
    containing repository.

If a repository was cloned without --recursive, submodule_update() will
ensure that the submodules are initialized and updated.
2013-06-20 14:48:39 -07:00
Jan-Piet Mens
5c69918d53 DOCS: standardize on EXAMPLES (a.k.a. Docs-JumboPatch JetLag Edition)
Migrated all examples: in DOCUMENTATION=''' string to standalone EXAMPLES=''' string
  Added deprecation warning to moduledev.rst and remove deprecated example from it
  Fixed up a few typos and uppercased some acronyms.
  add consistency to how EXAMPLES are formatted
2013-06-15 20:54:25 +02:00
Benjamin Schwarze
a0c89e742e remove unused git function is_current_branch (looks like it returns always True anyway which might be wrong) 2013-05-31 22:27:56 +02:00
Benjamin Schwarze
3cae9d6d0d use module.get_bin_path('git', True) once and pass git_path to functions 2013-05-31 21:42:15 +02:00
Stoned Elipot
c9f268ac48 Fix typo in git module documentation preventing it to be processed by ansible-doc 2013-05-24 01:33:47 +02:00
Jesse Keating
f645d27f5e Add an update option to the git module
This will allow just making sure the repo exists w/out actually making
any chnages to it. Useful if you're going to run a play repeatedly
against a host that might have active development going on in the
repository (think initial bootstrap of a developers system, and
continued playbook runs to work on other projects).
2013-05-15 22:14:17 -07:00
Michael DeHaan
391fb98ee2 Allow modules to be categorized, and also sort them when generating the documentation. 2013-04-28 15:03:45 -04:00
Renamed from library/git (Browse further)