James Cassell
2bd6b1415b
become_method: make dzdo more like sudo ( #47946 )
...
dzdo is basically a drop-in replacement for sudo and supports the same
command line options.
There is no become_flags set for dzdo like there is for sudo, so users
will have to set that separately to have exactly the same functionality.
2018-12-04 18:24:32 -05:00
Toshio Kuratomi
d06cd869b8
Revert "fix cache 'update' method to be 'mapping' compatible"
...
This reverts commit 68301f890a
.
2018-12-04 14:04:13 -08:00
Wojciech Sciesinski
e4a3e73b15
Add win_psrepository ( #48828 )
...
* Add win_psrepository
* Small corrections
* Correct requiqurements - add NuGet
* Extend tests
* Post-review updates
* Post-review - updates 2
* Add empty RETURN section in documentation
* Add empty line at EOF
* Post-review updates 3
* Update tests to run in check_mode too
* Minor updates
* Correct installing/updating NuGet
* a few changes for review
* Remove copyrights
* Revert "Remove copyrights"
This reverts commit 2d687ec6a6
.
2018-12-04 22:47:28 +01:00
Robert de Bock
3247eec97a
Fixes #49362 module dnf: install python3-dnf preferably over python2-dnf. ( #49402 )
...
* Create python3and2
Adding tests to see if dnf still works when python-2 and python-3 are installed.
* Update main.yml
Include the tests that run on python 2 and python 3, based on the package manager.
* Update dnf.py
Use python3-dnf by default, otherwise python2-dnf.
* Rename python3and2 to python3and2.yml
Rename.
2018-12-04 16:43:45 -05:00
Tim Rupp
c7dd13758e
Adds bigip_profile_analytics module ( #49499 )
2018-12-04 12:53:31 -08:00
Bianca Henderson
5499ee30d4
Change GB to GiB in some AWS modules ( #49304 )
2018-12-04 15:46:34 -05:00
Sloane Hertel
a3e8917b73
[s3_bucket] Handle error paginating object versions when bucket does not exist ( #49396 )
2018-12-04 15:42:14 -05:00
Toshio Kuratomi
a8fbfe1844
Warn if empty string is present in synchronize's rsync_opts
2018-12-04 12:05:45 -08:00
Tim Rupp
caa6ed3c66
Adds ASM policy fetch module ( #49494 )
2018-12-04 11:24:34 -08:00
Tim Rupp
138690519d
Various small fixes for f5 ansible modules ( #49492 )
2018-12-04 11:15:49 -08:00
Sam Doran
6200d32c0d
Use IndexError in exception ( #49488 )
2018-12-04 14:12:00 -05:00
Tim Rupp
7c15417f62
Fixes for examples in f5 modules ( #49490 )
...
So that they use provider instead of deprecated args method
2018-12-04 10:31:25 -08:00
Sam Doran
40a5f7bfdf
Add better error when k=v syntax is used with YAML in tasks ( #41754 )
...
* Add error message for k=v and YAML in a single task
Find the correct line, column, and position for k=v errors since they are different than the position reported initially.
Document bug in quoting syntax check.
* Change tense or error message
Since the error still exists, switch to present tense rather than past tense.
* Remove double spaces after periods in error messages.
http://www.slate.com/articles/technology/technology/2011/01/space_invaders.html
* Add changelog fragment
* Add tests for new error message
* Fix tests
* Add clarifying comments to unit test
2018-12-04 12:32:02 -05:00
Mikhail
2f8d235ce5
Add apt_repo module ( #49187 )
2018-12-04 16:37:42 +00:00
linnil1
8de46f5cf7
[Junos] Fix bug of setting user password ( #44660 )
...
* Add encrypted_password for junos
* Add readme for Junos user encrypted_password
* encrypted_password added in 2.8
2018-12-04 15:49:13 +00:00
Richard Levenberg
5cb39d0d57
Use System.Xml.XmlDocument.Load rather than Get-Content to avoid ( #49206 )
...
encoding errors when writing out XML
removing executable bit
refactor tests to handle sanity checking
2018-12-04 15:19:38 +00:00
Łukasz Tomaszkiewicz
9d62cbc2af
Fix TargetDBInstanceIdentifier assignment in wrong place (issue #46689 ) ( #47710 )
2018-12-04 12:43:49 +00:00
Jon Bergli Heier
9c02ade536
rabbitmq_binding: Add support for state=absent ( #48599 )
...
* rabbitmq_binding: Add support for state=absent
* Add integration tests for rabbitmq_binding
* Update testcases
* Add changelog fragment
2018-12-04 12:42:18 +00:00
Brett Maton
6291efd4ea
Add module parameter to control Puppet agent noop switch ( #43678 )
...
* Puppet agent noop switch
Add module parameter to control noop switch
Current module overrides puppet.conf noop setting by forcing '--no-noop' switch which may not be expected or desired.
Add parameter to allow user control.
noop: Undefined - Use agent configuration
noop: true - Add --noop switch to cmd
noop: false - Add --no-noop switch to cmd
Ansible check mode always runs with --noop switch
* Update lib/ansible/modules/system/puppet.py
Co-Authored-By: matonb <matonb@ltresources.co.uk>
Co-Authored-By: matonb <matonb@ltresources.co.uk>
Co-Authored-By: matonb <matonb@ltresources.co.uk>
2018-12-04 12:30:19 +00:00
styks1987
bb6a82d2a9
v2 dnsimple api uses type vs record_type ( #39301 )
...
* v2 dnsimple api uses type vs record_type
https://developer.dnsimple.com/v2/zones/records/#listZoneRecords
* replace prio with priority
2018-12-04 12:25:29 +00:00
shateq
895c6eea9e
Extend functionality of filesystem module to support swap creation ( #49456 )
...
* Extended functionality of filesystem module to support swap creation
* Corrected documentation block
* Add a note to for version added
* was
2018-12-04 12:01:29 +00:00
thyme
8a30ceb347
Fix typo in confirm new vault password message ( #49468 )
2018-12-04 11:04:29 +00:00
Abhijeet Kasurde
a13d1eba93
Correct usages of custom error class ( #48778 )
...
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-12-04 00:56:04 -05:00
Abhijeet Kasurde
1b04571ea0
VMware: Fix module usages in module_utils ( #49421 )
...
* VMware: Fix module usages in module_utils
* Skip test for Python 2.6 as SSL context is not available in Python 2.6
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-12-04 10:11:29 +05:30
Mike Wiebe
dd984709f5
Fix issues related to track feature ( #49454 )
2018-12-04 09:57:35 +05:30
sdirbach
e2f85b3f6c
Implement test case prefix to filter test cases ( #40174 )
...
* Implement test case prefix to filter test cases
* Cut line to not exceed 160 chars
* Replace tabs with spaces
* Add version_added field
* Include changelog file
2018-12-03 18:41:44 +00:00
Paul Neumann
4c58fbc64d
nxos: Make sure config ends with a linefeed ( #48465 )
...
The config parser on NX-OS does not deal with configs that do not end
with a linefeed correctly which leads to various issues when the config
is loaded from startup-config upon reboot. Therefore, ensure that the
config returned is terminated by a linefeed.
2018-12-03 19:26:26 +05:30
Ricardo Carrillo Cruz
5ffb863f0b
Fix regex on ASA password prompt ( #49438 )
...
On Cisco ASAv on AWS, the prompt is 'Password', thus the privilege
elevation fails, we need to check upper and lower p.
2018-12-03 13:00:28 +00:00
Xaroth
a6db7f7abd
-Fix: The Ubuntu 14.04 image on Shippable runs an old version of python, causing issues with checking out bitbucket, adjust tests to compensate. ( #49433 )
...
-Add: Mention bitbucket dropping TLSv1 and TLSv1.1 support as per 01 Dec 2018, potentially causing issues with older clients.
2018-12-03 12:35:58 +00:00
Akshay Gaikwad
597e449afe
Support for pids_limit parameter in docker_container module ( #49319 )
...
* Support for pids_limit parameter in docker_container module
This add pids_limit parameter support in docker_container module
Fixes #43337
Signed-off-by: Akshay <akshay@localhost.localdomain>
* Add changelog for pids_limit parameter
Signed-off-by: Akshay Gaikwad <akgaikwad001@gmail.com>
* Remove unnecessary lines of code
The map is needed if the names are different.
Signed-off-by: Akshay Gaikwad <akgaikwad001@gmail.com>
* Update pids_limit option tests
It also run for docker-py < 1.10.0
Signed-off-by: Akshay Gaikwad <akgaikwad001@gmail.com>
2018-12-03 11:22:43 +00:00
Lukas Pirl
9fd5d01d67
`make
` module: check return code ( #47861 )
2018-12-03 10:29:18 +00:00
Frank Zwart
329922e2dd
ec2_instance: add placement_group support ( #49286 )
...
* add placement_group support
2018-12-03 10:27:54 +00:00
sdirbach
840ab706ee
Implement hide task arguments feature ( #40176 )
...
* Implement hide task arguments feature
* Add version_added field
* Include changelog file
2018-12-03 09:22:51 +00:00
John Kerkstra
672acbea68
Adds redshift_cross_region_snapshots
module ( #35527 )
...
* add redshift_cross_region_snapshots module, unit tests.
* fix errors
* use ec2_argument_spec as the basis for the argument spec. fixed
metadata_version
* follow best practices by naming example tasks.
* code review changes
* fix linting errors
* Update version added
2018-12-03 08:34:53 +00:00
Marcin
8a7d19788c
Dont' attempt to remove drive if ID is "None" ( #49423 )
2018-12-03 15:09:03 +08:00
anasbadaha
7fcd55f3ec
Fix Issue:#47076 onyx_l2_interface parameter trunk_allowed_vlans tries to remove all existing vlans on a port ( #49418 )
...
Signed-off-by: Anas Badaha <anasb@mellanox.com>
2018-12-03 10:39:39 +05:30
Felix Fontein
b0c7efcc6b
ACME: add diff to acme_account, account_public_key to acme_account_facts, and general refactoring ( #49410 )
...
* Only one exit point.
* Refactoring account handling.
* Add diff support for acme_account.
* Insert public_account_key into acme_account_facts result and into acme_account diff.
* Add changelog.
2018-12-02 18:40:14 +01:00
Chris Archibald
62dd1fe29e
New options of na_ontap_aggregate ( #48906 )
...
* add new options for na_ontap_aggregate
* add gpl line
* remove dup option
* Put files in wrong directory
* change unit test to match the request from PR 48941
* Changed for review comments
* pep8
2018-12-02 14:24:27 +00:00
Felix Fontein
34c57b4c42
ACME: fix bug introduced in #49266 , work around problem with Pebble ( #49407 )
2018-12-02 10:07:21 +01:00
Ruben Tsirunyan
d62492e656
zabbix: New zabbix_action module ( #49189 )
2018-12-02 10:04:45 +01:00
Brian Coca
fc71cde7d3
Yaml inventory more tolerant ( #48883 )
...
* make yaml inv more tolerant to comments
* add tests for bad inventory processing
fixes #47254
2018-11-30 22:04:39 -05:00
Bob Vincent
2557373cc8
Do not document buggy behavior. ( #49325 )
...
In the pip module, umask should be specified as an octal *string*, not an octal (or decimal) *integer*.
2018-11-30 15:22:15 -06:00
Brian Coca
8c43ce491e
unsafe cleanup
2018-11-30 13:07:00 -08:00
Alicia Cozine
031e961c58
removes talk of hardcoded loading from plugin docs ( #49383 )
2018-11-30 14:37:55 -06:00
Gregor Wegberg
4096d74245
Specify key to use while sorting permissions ( #49126 )
...
Without specifying the dictionary key to use while sorting it will fail
in Python 3 environments due to simplifying Python's rules for ordering
comparisons: https://docs.python.org/3.0/whatsnew/3.0.html#ordering-comparisons
2018-11-30 20:18:57 +00:00
Ken Partridge
19035dbcb2
CPM plugcontrol for WTI Power Devices ( #47683 )
...
* Add WTI OOB and PDU Device status, control and configuration module
* removed accidental file inclusions
* removed accidental file
* remove unneeded legacy files
* Added the new module cpm_plugcontrol to control the plugs on WTI Power devices
2018-11-30 20:13:48 +00:00
Ken Partridge
837818018d
CPM plug configuration for WTI Power Devices ( #47989 )
...
* Add WTI OOB and PDU Device status, control and configuration module
* removed accidental file inclusions
* removed accidental file
* remove unneeded legacy files
* added the module cpm_plugconfig
2018-11-30 20:13:05 +00:00
Adam Miller
378cc9668c
dnf module load/init dnf pkg mgr plugins properly ( #49278 )
...
* dnf module load/init dnf pkg mgr plugins properly
Fixes #45940
Signed-off-by: Adam Miller <admiller@redhat.com>
2018-11-30 10:00:33 -08:00
Jorgen
8ff13db17c
Add Windows example of raw command ( #47153 )
...
* Add Windows example of raw command
Perform shutdown of Windows OS using Microsoft.PowerShell.Management module
* Capitalized cmdlet, remove quotes and improve description
This commit also cleans up some of the description sections.
* Use another example as suggested by jborean93
I was happy to merge this before I noticed jborean93 objected to the example :-/
* Fix whitespace issue
2018-11-30 17:12:19 +01:00
Martin Krizek
c78c8d389f
Last loaded handler with the same name wins ( #49249 )
...
* Last loaded handler with the same name wins
* Add comment explaining reversed
2018-11-30 16:30:27 +01:00
James Cote
aee9209375
Update set_fact doc to reflect updated caching options ( #46565 )
...
* Update set_fact doc to reflect updated caching options
* add note about change in precedence caused by caching
2018-11-30 08:42:47 -06:00
Peter Sprygada
2a4be2748f
fixes an issue with dict_merge in network utils ( #41107 )
...
This change address a problem where the dict_merge function would fail
due to the value being a nested dict. This will now recursively pass
the value back through the dict_merge function.
2018-11-30 17:52:33 +05:30
Youhua Li
c1a30c743e
enable ONE auth file authentication ( #49331 )
2018-11-30 07:06:05 -05:00
Lars Kellogg-Stedman
b2e5c75131
server.security_groups is a list of dicts ( #48798 )
...
os_server was trying to access `[sg.name for sg in
server.security_groups]`, but the items in `server.security_groups`
are dictionaries, so that should be `sg['name']`.
2018-11-30 06:42:50 -05:00
Giovanni Sciortino
95718f7e12
fix archive module can not compress a single file in a tar file ( #45117 )
...
fixes #44968
2018-11-30 10:49:35 +00:00
Martin Surovcak
87a9ada188
fix module argument to be boolean ( #47134 )
2018-11-30 10:43:29 +00:00
Lex Rivera
aa484c0835
Fix GCE and scaleway VM detection ( #47193 )
...
* Fix Google cloud engine & Scaleway VM detection
2018-11-30 10:38:43 +00:00
maxstack
0dbac3f3b8
add default nolog param for VPN PreSharedKey ( #47788 )
2018-11-30 10:37:17 +00:00
Alan Rominger
d536be6530
Avoid duplicated recursive calls in inventory CLI ( #48598 )
2018-11-30 10:36:19 +00:00
ftntcorecse
b4ce4e1571
Fortinet FortiManager Device Group Module ( #46086 )
...
* fmgr_device_group PR candidate
* fgmr_device_group PR candidate
* PR candidate
* PR candidate
* Fixing Edits.
* Fixing Edits.
* Fixing Authors
* Removed State Parameter and replaced with Mode, per request of justjais
2018-11-30 15:54:41 +05:30
bverschueren
5cd31578cc
comparing StorageConnection.password breaks idempotency ( #48933 )
2018-11-30 10:24:04 +00:00
Christian Kotte
68cafbda2b
Improve vmware_dvswitch module ( #48720 )
2018-11-30 03:34:43 -05:00
Matthew Krupcale
93fd323457
Add support for newer FreeIPA SHA256 SSH public key hashes ( #40803 )
...
* lib/ansible/modules/identity/ipa/ipa_user.py:
- Check any existing `ipa_user` SSH public key fingerprints for the hash algorithm to use
- Generate `module_user` SSH public key fingerprint based on detected or default algorithm
2018-11-30 02:47:58 -05:00
Felix Fontein
2bd8e47247
add acme_inspect module ( #48444 )
2018-11-30 08:26:18 +01:00
rajaspachipulusu17
fe147289b7
Pluribus Networks pn access list module ( #49176 )
...
* Pluribus Networks pn access list module
* Added shlex import which was missing and added correct author
* Added an extra space which is according to pep8
2018-11-30 12:40:43 +05:30
Sofiane Medjkoune
ec73af1d78
Removed the unused argument description from lxd_container module ( #31440 )
2018-11-30 01:59:34 -05:00
Abhijeet Kasurde
3141fda6b4
Misc typos in ce action plugin ( #49348 )
...
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-11-30 11:50:00 +05:30
Yunge Zhu
be28794dfc
fix keyvault key secret not support cloud environment ( #49182 )
2018-11-30 14:08:31 +08:00
Monty Taylor
824c72da5f
Set play context on stdout callback plugin ( #35910 )
...
The loop on self._callback_plugins does not include the stdout callback,
so the stdout_callback never has set_play_context called.
2018-11-29 23:15:56 -05:00
Gaël Lambert
ad7798c26a
Add the ability to download a specific version of an S3 object ( #47867 )
...
Add the ability to download a specific version of a S3 Object
Fixes : #47864
2018-11-30 08:59:12 +05:30
Florian Pracht
eb410a9987
Run patch command with --check option instead of --dry-run to support older BSDs ( #42168 )
2018-11-29 21:53:53 -05:00
Dag Wieers
bc481c2500
PSRP: Improve default logging to ansible.log ( #47645 )
2018-11-29 18:18:39 -08:00
Dag Wieers
01d66d4431
WinRM: Improve default logging to ansible.log ( #49308 )
2018-11-29 18:18:18 -08:00
Tomáš Pospíšek
434c421675
improve usage example of tempfile module ( #47933 )
...
* Show in example how to use file created by tempfile module
2018-11-29 16:24:58 -06:00
Chris Archibald
73348ae32d
Fixes for na_ontap_cluster_peer ( #48329 )
...
* Fixes for na_ontap_cluster_peer, incorporating review comments, version, etc.
2018-11-29 16:22:02 -06:00
Laurent G
655b27f571
VMware: Add a pointer on how to get possible values. ( #48658 )
...
* Add a pointer on how to get possible values for VMware host config manager
2018-11-29 16:19:21 -06:00
Felix Fontein
3726d467ec
Code style adjustment. ( #49329 )
2018-11-29 21:57:32 +01:00
martinwangjian
d1816d4908
grafana_datasource: Add CloudWatch as grafana datasource type ( #48174 )
2018-11-29 20:58:49 +01:00
Matt Martz
77befcf5d7
Do not allow addressing an import from handlers via notify. Fixes #48936 ( #49317 )
2018-11-29 13:50:07 -06:00
Dusan Matejka
a9aa1053a8
zabbix_template: fixed idempotency issues ( #49188 )
2018-11-29 20:38:32 +01:00
Paul Neumann
a914f494a8
ios_facts: Gather CDP neighbor data ( #49129 )
...
* ios_facts: Gather CDP neighbor data
* ios_facts: Create tests for ansible_net_neighbors
2018-11-29 14:05:17 -05:00
Ryan Brown
a51eca364f
New module: AWS EC2 Launch Template ( #46972 )
...
* Add launch template integration tests
2018-11-29 13:59:10 -05:00
Isakov Anton
5a7f2b6b08
Update elb_application_lb_facts.py ( #48983 )
...
<!--- Added example how to see the facts about specific ALB -->
2018-11-29 11:38:46 -05:00
Brian Coca
24e4d26b72
added missing github id
2018-11-29 10:48:38 -05:00
Amy Buck
392a12589e
Update dellos10_command.py ( #48167 )
...
<!--- Your description here -->
Updated Dell OS10 to Dell EMC OS10
2018-11-29 10:29:15 -05:00
spike77453
bd35069495
Non-existent RR returns empty string ( #40680 )
2018-11-29 14:58:16 +00:00
Pilou
62c05033d6
templar: ensure that exceptions are handled, fix 'AttributeError' ( #48792 )
...
* templar: ensure that exceptions are handled
* Fix AttributeError: object has no attribute 'message'
'message' attribute is deprecated since Python 2.6 and not available
with Python 3.
Simple reproducer:
- hosts: localhost
vars:
not_json: "{{ 'test str' | from_json }}"
tasks:
- command: "echo {{ not_json }}"
2018-11-29 09:56:23 -05:00
jpdasma
37f66ee15b
Fix reboot plugin not working in Illumos/Solaris ( #48986 )
2018-11-29 09:54:51 -05:00
Sam Doran
8f9ced4005
Improve log message ( #49004 )
...
This is the only connection plugin that doesn't state explicitly what it is in the log.
2018-11-29 09:53:26 -05:00
Douglas Fraser
d6d16fa619
Extend DMI form factors list to match SMBIOS standard 3.2.0 (2018-04-26) ( #42239 )
...
Signed-off-by: Douglas Fraser <doug+git@idmf.net>
2018-11-29 09:16:32 -05:00
fdeschamps
faed1bbd96
ignore empty lines in rabbitmqctl output ( #43722 )
...
* ignore empty lines in rabbitmqctl output
this fixes a bug with rabbitmq 3.7.5
rabbitmqctl can return empty lines, breaking the rabbitmq_parameter module
especially in a new vhost, the command rabbitmqctl list_parameters -q -p <vhost> will return an empty line
* Strip empty line in rabbitmqctl output
2018-11-29 13:55:05 +00:00
Ryan Brown
af6427bf40
VPC peer module unhandled exception on bad peering ID ( #45306 )
...
* Improve error handling for VPC peer module when a bad peering-id is specified
* changelog
2018-11-29 08:54:16 -05:00
Ryan Brown
7f7c059a04
ec2_asg: Retry Autoscaling Group delete calls when scaling activity is in progress ( #46124 )
...
* Retry delete calls when scaling activity is in progress
* changelog
2018-11-29 08:42:55 -05:00
joaocpinto
bbab4c1b49
Cast int for expire field to avoid call failure to sensu API ( #33239 )
2018-11-29 12:30:59 +00:00
Corey Wanless
6cd321ed8e
sets admin_password to no_log ( #46604 )
2018-11-29 12:17:15 +00:00
John Nelson
571749f3ed
ec2_vpc_nacl: Don't default name into Name unless able ( #48889 )
...
This fixes ansible/ansible#issues/48832
2018-11-29 09:52:17 +00:00
Felix Fontein
1e0ab16247
Add basic unit tests for module_utils/acme.py. ( #49103 )
2018-11-29 09:32:15 +00:00
Alan Rominger
729c3a6767
Fix error where pod has error and no containers ( #49154 )
...
k8s: Fix error where pod has error and no containers
2018-11-29 09:17:04 +00:00
Dusan Matejka
7190c73d50
zabbix_hostmacro: Fixed support for LLD type user macros and added missing validate_certs attribute ( #48730 )
2018-11-29 09:15:13 +01:00
Felix Fontein
b842b1b97e
ACME: improve error handling ( #49266 )
...
* Improve error handling: when parse_json_result is False, still return the error message.
* Remove content body from info dict.
* Add changelog.
2018-11-29 09:00:39 +01:00