Commit graph

1666 commits

Author SHA1 Message Date
Michael DeHaan
b76efa39be Fix some templating issues, needs testing with anti-unicode safeguard around shlex.split 2012-08-02 20:21:59 -04:00
Michael DeHaan
bd7de28a64 Merge pull request #778 from skvidal/devel
remove the tab I found
2012-08-02 16:54:42 -07:00
Seth Vidal
4d29cd6ee3 make virt module command= work again - better error handling should be in its
future
2012-08-02 17:46:21 -04:00
Seth Vidal
f924c96370 remove the tab I found
DIE TAB DIE
pep8
2012-08-02 17:26:04 -04:00
Michael DeHaan
0394ef776f Merge pull request #776 from skvidal/devel
- add a check for repoquery so we can abort politely
2012-08-02 14:06:30 -07:00
Seth Vidal
fd492bebc6 - add a check for repoquery so we can abort politely
- make the results output a bit more readable
- fix up where repoquery is looked for so it is easier to change
2012-08-02 17:02:37 -04:00
Michael DeHaan
98e4034de2 Merge pull request #772 from gottwald/devel-serviceFix
Fixed a Bug in the service module "state changed" recognition
2012-08-02 08:49:30 -07:00
Michael DeHaan
45d2c90169 Merge pull request #771 from sfromm/issue765
Add Blade to FORM_FACTOR list and document SMBIOS spec URL
2012-08-02 08:48:49 -07:00
Ingo Gottwald
25b52109b4 Fixed a Bug in the service module state changed recognition 2012-08-02 17:18:25 +02:00
Stephen Fromm
85c838c835 Add Blade to FORM_FACTOR list and document SMBIOS spec URL 2012-08-02 07:24:05 -07:00
Stephen Fromm
9a3ad060dc Catch exception if form factor id is unknown 2012-08-02 07:06:55 -07:00
Michael DeHaan
38ed7ca7df Merge pull request #759 from lorin/error-feedback
If task action is invalid, output the name in error message
2012-08-02 05:39:53 -07:00
Lorin Hochstein
aed6ee7f74 Report only name in task error, all on one line 2012-08-02 08:37:43 -04:00
Lorin Hochstein
fa9fe9d246 If task action is invalid, output the name and action. 2012-08-01 23:51:25 -04:00
Michael DeHaan
c192d8a2b2 Revert "Apply templating to module arguments in playbook"
Breaks copy module by introducing unicodeness, among other things

This reverts commit 4fedb17e38.
2012-08-01 23:07:15 -04:00
Michael DeHaan
a015c2e581 Merge pull request #767 from sfromm/issue765
Catch exception if form factor id is unknown
2012-08-02 07:08:36 -07:00
Michael DeHaan
fa79d57d13 changelog / remove a failed=False 2012-08-01 22:35:07 -04:00
Michael DeHaan
b7c3fd1246 failed should not be in the result returns for a module upon success 2012-08-01 22:30:22 -04:00
Michael DeHaan
fe87a16a3e Make yum module use one-pass with with_items 2012-08-01 22:27:25 -04:00
Michael DeHaan
91d31d8164 Merge pull request #761 from skvidal/devel
redo of yum module - uses more system calls but should handle
2012-08-02 05:13:23 -07:00
Seth Vidal
c91befda5c redo of yum module - uses more system calls but should handle
random plugin vomit better.
also should handle multiple withitems in a single execution, now.
2012-08-02 01:47:48 -04:00
Will Thames
4fedb17e38 Apply templating to module arguments in playbook
Module arguments should have variable substitution applied
Also, replacing task.action with the templated task.name seems wrong
2012-08-01 22:22:46 -04:00
Michael DeHaan
e820c282be Merge pull request #760 from sfromm/fixes
A couple fixes for the file module
2012-08-02 04:54:16 -07:00
Michael DeHaan
f092a69d77 Merge pull request #763 from willthames/sudo_missing_user
Raise exception when sudo user does not exist
2012-08-02 04:50:06 -07:00
Michael DeHaan
9e0bf168ca Merge pull request #764 from willthames/fail_copy_on_directory
Revert acceptance of directory as dest for copy
2012-08-02 04:49:17 -07:00
Will Thames
0e26ef9bdd Revert acceptance of directory as dest for copy
Although library/copy can be corrected to understand that dest is
a directory, I can't see how to let _execute_copy know this and let the
file module know.

As a better solution than before #733, the copy module now explicitly (rather
than silently) fails when dest is a directory.
2012-08-02 16:54:03 +10:00
Will Thames
d43d81a9a4 Raise exception when sudo user does not exist
sudo can fail before getting to the password prompt if a user does not exist
<pre>
[will@tangerine ansible (sudo_missing_user)]$ sudo -u bobbins echo hello
sudo: unknown user: bobbins
sudo: unable to initialize policy plugin
</pre>
Fix raises a distinct exception when that occurs
2012-08-02 16:19:15 +10:00
Stephen Fromm
d0892c19ad Add setype to file's argument_spec and remove secontext
secontext is used internally and should not be in argument_spec
2012-08-01 22:24:09 -07:00
Stephen Fromm
52afacf475 Fix module_fail_json call when symlink src does not exist 2012-08-01 22:23:02 -07:00
Michael DeHaan
bf25193ec1 changelog updates 2012-08-01 20:34:39 -04:00
Michael DeHaan
25acfa8170 Join with_items for the apt module, yum pending, and various fixes to the yum module to support aliases 2012-08-01 20:33:13 -04:00
Michael DeHaan
86ec639176 add error handling if you try to load files in the wrong data format 2012-08-01 19:51:52 -04:00
Michael DeHaan
08c5fe875b yell if input data for host or group vars are not hashes 2012-08-01 19:46:33 -04:00
Michael DeHaan
ed14312ad6 reinstate invalid argument checks where possible, daisy chainee/chained modules turn it off 2012-08-01 19:42:31 -04:00
Michael DeHaan
08999a2a2f Merge pull request #748 from dagwieers/make-rpm
Implement git commit date into RPM release
2012-08-01 16:29:16 -07:00
Michael DeHaan
3ff03d14e3 Merge pull request #751 from Ernest0x/ignore_errors_task_option
added an 'ignore_errors' option to tasks
2012-08-01 16:28:35 -07:00
Michael DeHaan
77029a4227 Merge pull request #752 from go2sh/apt-patch
Enable apt module to handle multiply packages (comma separated)
2012-08-01 16:27:29 -07:00
Michael DeHaan
128a606a59 Merge pull request #756 from sfromm/issue755
Issue755 - fixes for service module
2012-08-01 16:27:13 -07:00
Michael DeHaan
53c62f2655 Merge pull request #757 from pas256/devel
Smiting Debian packaging instructions that did not work
2012-08-01 16:26:50 -07:00
Peter Sankauskas
b1b543c289 Smiting Debian packaging instructions that did not work, and replacing
them with the correct instructions. Changing file to .md to match 'docs'
file.
2012-08-01 16:12:10 -07:00
Stephen Fromm
abe8d8d4d6 Return extra information from service module
If _do_enable() is run and returns rc == 0, set changed=True
Add enabled and state to result if they are supplied when the module is
run.
2012-08-01 14:58:32 -07:00
Stephen Fromm
42ad1c879f Fix service module for issue 755 and another bug
Allow use of service module with just enable parameter, per issue #755.
Also fixed two other issues:
- fixed parameter to be 'enabled' per docs, not 'enable'.
- fixed if block that checks whether to run _do_enable() to check
  whether the parameter is set, not the value of the enable value which
  may be None or False.  If enabled=no, the service would never be
  disabled.
2012-08-01 14:44:26 -07:00
Petros Moisiadis
2ac4acbf97 fixes for tests 2012-08-01 22:17:16 +03:00
Christoph Seitz
6baaea90ae Tweaked error massages. 2012-08-01 18:45:32 +02:00
Christoph Seitz
b973910283 Some optimizations to previous code. 2012-08-01 18:43:39 +02:00
Petros Moisiadis
5f4bf813b1 added an 'ignore_errors' option to tasks
Failed tasks with ignore_errors=True, allow the remaining tasks in the
play to be executed as if no failure happened. A failure notice is still
written to the output as well as an '...ignoring' message.
2012-08-01 19:13:07 +03:00
Christoph Seitz
418445d3c5 Enable apt module to handle multiply packages (comma separated) 2012-08-01 18:09:30 +02:00
Michael DeHaan
2d9ceafbd4 Merge pull request #749 from jpmens/get_urlcomma
get_url except fix
2012-08-01 06:39:01 -07:00
Michael DeHaan
f60517aa33 temporarily disable failing check on some things 2012-08-01 09:33:20 -04:00
Jan-Piet Mens
31c0e523c2 Fix exeptions, replace 'as' by ',' as reported on IRC for Python 2.4.3 on Centos5 2012-08-01 15:30:16 +02:00