Commit graph

1662 commits

Author SHA1 Message Date
Lorin Hochstein
8c9cceacbf authorized_key: Set manage_dir default value
This commit fixes a bug where the authorized_key module causes
the ~user/.ssh directory to be owned by root instead of the user,
when the manage_dir argument is not specified.

If the manage_dir argument was not specified, the module behaved as if
manage_dir was set to false, even though it's supposed to default to
true.

This module assumed that an optional argument, with no default
specified, will not be present in the module.params dictionary.

What actually seems to happen is that the argument does appear in
the module.params dictionary with a value of None.

The upside is that this line was evaluating to None instead of
true:

    manage_dir = params.get("manage_dir", True)

I fixed the problem in this particular module by explicitly specifying
the default value for the manage_dir arugment. But if this bug
occurred because of a change in behavior in AnsibleModule, then other
modules may be broken as well.
2013-05-30 16:16:14 -04:00
Michael DeHaan
f9a14f0d70 Fixup fetch doc formatting. 2013-05-29 10:45:31 -04:00
Michael DeHaan
01a2384cdd Minor style tweak. 2013-05-29 10:14:47 -04:00
Timothy Appnel
3e774fedea Modified assemble module so the dest file is streamed together rather than built-in memory before writing. 2013-05-29 10:14:47 -04:00
Michael DeHaan
a581077b4d Merge branch 'facter-fix' of git://github.com/flyapen/ansible into devel 2013-05-29 10:00:20 -04:00
Michael DeHaan
575967cee4 Merge pull request #3038 from jsmartin/riak_bugfixes
Riak bugfixes
2013-05-29 06:38:31 -07:00
Guillaume Lasmayous
1c0e01a72b Implement NetBSD-specific subclass of Hardware in the setup module.
Defines memory and CPU facts:
- memfree_mb
- memtotal_mb
- swapfree_mb
- swaptotal_mb
- processor (a list)
- processor_cores
- processor_count
- devices

As a matter of fact, on NetBSD, it is possible to get memory, swap and
processor facts exactly as on Linux. Tested on NetBSD-5, NetBSD-6 and
NetBSD-6.1 (without Linux emulation).
2013-05-29 09:37:46 -04:00
Michael DeHaan
ebf28ff856 Merge pull request #2867 from cstorey/rabbitmq_user-node-parameter
Allow specification of erlang node name for rabbitmq_user/vhost/parameter actions.
2013-05-29 06:35:09 -07:00
James Martin
1aec4c0e74 Now can specify amount of time to wait_for_handoffs or ring ready instead of booleans. 2013-05-27 17:24:10 -04:00
James Martin
633724dc8c Timeouts implemented for riak stats operation. Removed failback mode
for fetching riak stats.
2013-05-27 17:12:13 -04:00
Lorin Hochstein
b432ae5a74 Documentation for keystone_user
Updated the module with proper documentation.
2013-05-27 07:35:05 -04:00
Kristof Keppens
c5b40ca2ff change fix to lookup path with get_bin_path 2013-05-27 07:38:17 +02:00
Ceri Storey
c01992b564 Update rabbitmq_user/vhost/parameter to pass the node to rabbitmqctl using -n flag to rabbitmqctl rather than setting the environment variable. 2013-05-26 14:51:50 +01:00
Michael DeHaan
3a635d2d26 Lots of formatting fixes 2013-05-24 23:46:23 -04:00
Michael DeHaan
9c5d6f11f0 Fix tabs and spaces in OpenStack modules. 2013-05-24 23:34:48 -04:00
Michael DeHaan
b499f0754e Merge pull request #2986 from wbowling/devel
Fixes apt_repository always reporting file uri repos as changed
2013-05-24 20:07:03 -07:00
Michael DeHaan
82909179a0 Merge pull request #2976 from stoned/pip-virtualenv_command-pathname
Allow virtualenv_command argument of the pip module to be a pathname
2013-05-24 20:01:12 -07:00
Michael DeHaan
698b2fe9c5 Merge pull request #2992 from SirScott/service_pattern
Fixes #2991: Service module pattern argument ignored.
2013-05-24 19:58:42 -07:00
Michael DeHaan
84623441e1 Merge pull request #2945 from jsmartin/new_fetch
Fetch destination path can now be overriden.
2013-05-24 19:57:19 -07:00
Michael DeHaan
e68894ea45 Merge pull request #2975 from stoned/doc-pip-fix
Fix pip module documentation (YAML quoting)
2013-05-24 19:55:14 -07:00
Michael DeHaan
e3af9258ae Merge pull request #2995 from SirScott/pip-sudo-user
pip module -- sudo_user permission problem fix
2013-05-24 19:51:38 -07:00
Michael DeHaan
c397969ca3 Merge pull request #3001 from SirScott/user-always-changing
Fixes #2924: User creation always reports 'changed'
2013-05-24 19:50:48 -07:00
Michael DeHaan
9d92125a93 Merge pull request #2989 from lorin/keystone_user
OpenStack Identity (keystone) user module
2013-05-24 19:39:52 -07:00
Michael DeHaan
6ed01d2d9c Merge pull request #2985 from bennojoy/devel
OpenStack Modules
2013-05-24 19:38:19 -07:00
Michael DeHaan
2459255739 Merge pull request #3016 from bpennypacker/airbrake_deployment
new airbrake_deployment module
2013-05-24 19:37:49 -07:00
Bruce Pennypacker
fceaca4a53 new airbrake_deployment module 2013-05-24 14:40:37 -04:00
Michael DeHaan
1d3782cfc7 Merge pull request #3006 from stoned/doc-fix-npm
Fix typo in npm module documentation preventing it to be processed by an...
2013-05-23 18:08:58 -07:00
Stoned Elipot
c9f268ac48 Fix typo in git module documentation preventing it to be processed by ansible-doc 2013-05-24 01:33:47 +02:00
Stoned Elipot
81e0a7adcc Fix typo in npm module documentation preventing it to be processed by ansible-doc 2013-05-24 01:27:46 +02:00
Scott Sturdivant
922a1efbc0 Fixes #2924: User creation always reports 'changed' 2013-05-23 13:43:23 -06:00
James Martin
3c131dbd2b Initial Commit. 2013-05-23 13:33:36 -04:00
Scott Sturdivant
b2542bff72 Chdir to tempdir to prevent permissions problems. 2013-05-23 10:56:52 -06:00
Scott Sturdivant
b274fb9774 Fixes #2991: Service module pattern argument ignored. 2013-05-23 09:39:26 -06:00
Lorin Hochstein
dbd9d92861 OpenStack Identity (keystone) user module
Module for managing users, tenants, and roles within OpenStack.
2013-05-23 10:35:27 -04:00
Kristof Keppens
e2e10c1977 fix for facter being installed in a different location 2013-05-23 11:21:01 +02:00
William Bowling
222f004bfa Fixes apt_repository always reporting file uri repos as changed 2013-05-23 12:39:22 +10:00
bennojoy
b16e2a1d48 OpenStack Modules 2013-05-23 07:55:05 +05:30
Stoned Elipot
d4d0753e03 Allow virtualenv_command argument of the pip module to be a pathname 2013-05-22 18:15:21 +02:00
Stoned Elipot
83cce7d2e0 Fix pip module documentation (YAML quoting) 2013-05-22 18:09:01 +02:00
Bruce Pennypacker
d4429fcb91 Fixed handling of urlopen result to work properly under both python 2.4 and python 2.6 2013-05-21 13:59:42 -04:00
John Jarvis
daf4c358f7 fixes case where name is omitted from pip arg list
This code:
```
    if name.endswith('.tar.gz') or name.endswith('.tar.bz2') or
name.endswith('.zip'):
        is_tar = True
```
was not checking whether name is defined since it is an
optional param.
2013-05-18 20:59:21 -04:00
John Jarvis
423fe82d94 fixing syntax error 2013-05-18 19:49:25 -04:00
Michael DeHaan
5f98c6c246 Merge pull request #2948 from jcbagneris/devel
Fixes in apt module doc: typos, examples
2013-05-18 13:33:27 -07:00
Michael DeHaan
206b34783f Merge pull request #2942 from stoned/doc-requirements
Fix empty requirements specifications in modules documentation
2013-05-18 13:26:41 -07:00
Michael DeHaan
328065506e Merge pull request #2941 from bcoca/setup_bin
no uses get_bin_path for 2nd use of ip tool
2013-05-18 13:22:24 -07:00
Michael DeHaan
39673fe8c0 Merge pull request #2940 from madema/patch-3
-o and -r option don't exist on AIX
2013-05-18 13:21:48 -07:00
Michael DeHaan
fee3d9004f Merge pull request #2934 from j2sol/git-update
Add an update option to the git module
2013-05-18 13:14:04 -07:00
Michael DeHaan
223e4e2349 Merge pull request #2932 from bcoca/apt_getbins
apt now uses module function to find bin paths
2013-05-18 13:13:04 -07:00
Michael DeHaan
3ecae5f21a Merge pull request #2931 from caredotcom/flowdock_nochange
flowdock module returns changed=false on succes
2013-05-18 13:03:00 -07:00
Michael DeHaan
439c2ef684 Merge pull request #2921 from lwade/ec2_fact_doc
Added a helpful example to the ec2_facts doc.
2013-05-18 12:58:33 -07:00