Commit graph

732 commits

Author SHA1 Message Date
Simon Li
428550e179 Don't fail in check_mode if user exists
PR #1651 fixed issue #1515 but the requirement for path to be defined is unecessarily strict. If the user has previously been created a path isn't necessary.
2015-08-21 17:55:28 +01:00
Александр Костырев
31ec203583 Fix documentation of authorized_key.py
man for sshd http://www.openbsd.org/cgi-bin/man.cgi/OpenBSD-current/man8/sshd.8?query=sshd
says there's no "host" option but "from".
2015-08-17 18:00:04 +03:00
Brian Coca
5d7cb981d3 made continue into a pass (there was no loop) 2015-08-13 10:05:30 -04:00
Brian Coca
6d7428527d minor doc fixes 2015-08-12 23:55:01 -04:00
Brian Coca
2fd171a5e1 Merge pull request #878 from EvanK/system-cron--disabled
cron module: Add disabled option for commented jobs
2015-08-12 23:50:47 -04:00
Brian Coca
cd0a1947c2 Merge pull request #1899 from austinhyde/fix-service-rcconf-newlines
Service module incorrectly handles lines not ending in a newline
2015-08-12 19:34:34 -04:00
Brian Coca
7a2687178e avoid shlex exceptions in rc parsing (happens with multiline entries)
fixes #1898
2015-08-12 18:10:24 -04:00
Brian Coca
0c403781a7 Merge pull request #1905 from evverx/fix-legacy-services-enabled
Fix service.enabled on: Debian 8, Ubuntu 15.04
2015-08-12 10:18:50 -04:00
Evgeny Vereshchagin
55e8863cb4 Fix service.enable on: Debian 8, Ubuntu 15.04
Workaround for https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=751638
See https://github.com/systemd/systemd/issues/937
2015-08-12 14:13:19 +00:00
Brian Coca
072c4f38ea Merge pull request #62 from 0x46616c6b/user-add-skeleton-support
Add support for skeleton directory (useradd -k) in user module
2015-08-12 09:17:35 -04:00
Austin Hyde
5c25057868 Always end rc.conf entries with a new line 2015-08-10 17:42:26 -04:00
Brian Coca
0e9fccd098 changed verbose override variable 2015-07-29 14:54:19 -04:00
James Cammarata
bc60c893f5 Prefer non-zero rc's over text analyis in service status checks
Fixes ansible/ansible#10441
2015-07-27 12:51:30 -04:00
saito-hideki
e91ad2ab6c Add Solaris support in hostname module
feature_pull_request: #1804
2015-07-25 23:32:55 +09:00
saito-hideki
b991a2708b Add Solaris support in hostname module 2015-07-25 21:48:13 +09:00
Brian Coca
a2b713edad Merge pull request #1790 from renard/allow-star-password-on-openbsd-2015-07-24
[user] Allow '*' as empty password.
2015-07-24 18:55:13 -04:00
KIKUCHI Koichiro
a3b9fb58bf Fix service enabled check failure on FreeBSD 2015-07-24 21:05:16 +09:00
Sébastien Gross
349195e689 [user] Allow '*' as empty password.
If `password` is defined as `*` `useradd` or `usermod` returns an error:

    msg: usermod: Invalid password: `*'

This works very well on Linux host to not define any password for a
user (mainly useful if your setup is only based on SSH keys for
auth). On OpenBSD this does not work, so we have to ignore the encrypted
password parameter if it defined as `*`.
2015-07-24 10:48:36 +02:00
fti7
6a872469fc mount: Support for Check-Mode 2015-07-23 15:51:24 -04:00
Brian Coca
718fd1f891 prevent usless assignment of home 2015-07-18 23:28:41 -04:00
Brian Coca
045b8e8cff Merge pull request #1733 from tersmitten/the-tilde-expansion-doesnt-work-with-userhome
The tilde expansion doesn't work with user.home
2015-07-18 23:26:20 -04:00
bambou
e04f75d872 Check if the gid is set 2015-07-18 17:53:02 +02:00
Mischa ter Smitten
0ca732baaf The tilde expansion doesn't work with user.home 2015-07-15 12:00:23 +02:00
Brian Coca
8546744418 Merge pull request #1286 from 0tmc/freebsd_mount_fix
Use of proper fstab file on FreeBSD
2015-07-07 17:59:29 -04:00
Sean Chittenden
c57d70ad20 Fix group mod and group add for FreeBSD 2015-07-07 12:06:52 -07:00
Brian Coca
03d4805074 Merge pull request #1279 from no2a/devel
Not use "is" to compare strings
2015-07-04 16:00:05 -04:00
Brian Coca
328b6b5a39 Merge pull request #1454 from grossws/patch-issue-530
Escape spaces, backslashes and ampersands in fstab
2015-07-04 15:13:27 -04:00
Brian Coca
2b209f8065 Merge pull request #1642 from sivel/core-fixups
Core module fix-ups
2015-07-01 11:00:47 -04:00
Toshio Kuratomi
1dc5074602 Merge pull request #1651 from verm666/issue-1515
fix authorized_keys in check_mode
2015-07-01 07:52:48 -07:00
Matt Martz
b6b576abf6 Replaced tabbed indentation with spaces for group module 2015-07-01 09:39:19 -05:00
verm666
b00b3f2b3c fix authorized_keys in check_mode
This change is in response to issue #1515.
Original pull request #1580.

The original problem is: in authorized_key module you have no idea about users
which will be created by Ansible at first run. I can propose next two ways to
solve this problem:

  1. Combine modules system/user.py and system/authorized_key.py in one module
     (so you will know everything about users in that module)
  2. Use small workaround: add my commit and always provide 'path' parameter
     for authorized_key module during runs with --check option.
2015-07-01 07:04:45 -07:00
Brian Coca
d59de3af63 Merge pull request #578 from sysadmin75/mount_dir_spaces
allows spaces in names for mount module
2015-06-29 18:15:06 -04:00
Evan Kaufman
1187399ffa Add disabled option to cron module 2015-06-28 11:29:31 -05:00
Brian Coca
6f6d7f5c18 updated docs to clarify use of exclusive 2015-06-27 00:10:45 -04:00
Brian Coca
fed5ff04a6 Merge pull request #742 from aseigneurin/fix-remove-cron_file
Name parameter should not be marked as mandatory
2015-06-26 19:09:45 -04:00
Hagai Kariti
9d833d1d4c Hostname module should update ansible_hostname 2015-06-21 12:07:41 +03:00
Konstantin Gribov
dadc1faebd Escape spaces, backslashes and ampersands in fstab
Fixes #530.

It's more generic than #578 which only fixes spaces escaping in name (target dir to mount).
Escaping is used in both `set_mount` (important for `src`, `name` and `opts`) and
`unset_mount` (for `name`).

It's shouldn't be used in `mount` and `umount` since `name` parameter is passed as array element
to `module.run_command`.

Signed-off-by: Konstantin Gribov <grossws@gmail.com>
2015-06-17 02:37:03 +03:00
Greg DeKoenigsberg
2a5f0bde87 Proper author info for all remaining modules 2015-06-15 15:53:30 -04:00
Brian Coca
9acc7c402f Revert "added innitial daemon-reloaded support to service module"
This reverts commit 438d87d269.
2015-06-10 12:53:34 -04:00
Brian Coca
438d87d269 added innitial daemon-reloaded support to service module 2015-06-08 20:12:30 -04:00
Patrik Lundin
fb41bdfc1e service: Fix comments in OpenBsdService class.
No functional change.
2015-05-27 08:05:30 +02:00
Brian Coca
d02ef57815 minor doc fix 2015-05-26 13:43:29 -04:00
Brian Coca
0c9dd0e6a4 Merge pull request #751 from j2sol/service_must_exist
Add service option to avoid failure on missing service
2015-05-26 13:39:08 -04:00
Brian Coca
1736c8dfea Merge pull request #1399 from SUSE/devel
Add SLE12 support to hostname.py
2015-05-26 10:08:52 -04:00
Jonathan Mainguy
442b6a2067 fixes check mode for Ubuntu 14.04 2015-05-22 21:28:36 -04:00
Vladislav Lewin
771b369005 add SLE12 support to hostname.py 2015-05-22 13:26:25 +02:00
Brian Coca
150b71f11a removed executable bit 2015-05-21 07:01:08 -04:00
Toshio Kuratomi
59ea9003ea Merge pull request #1359 from Jmainguy/hostname_64_chars
added nice error for systemd hosts where name > 64 chars
2015-05-20 17:49:21 -07:00
Toshio Kuratomi
8d2fdf2aff Update the cron docs to specify that it takes a boolean value 2015-05-19 14:23:23 -07:00
Toshio Kuratomi
4106047e77 Fix documentation of the variable that backup file name is returned in 2015-05-19 14:15:02 -07:00