Commit graph

9492 commits

Author SHA1 Message Date
sysadmin75
9bd58bd224 Fix to revoke privileges for mysql user = '' Issue #9848 2016-12-08 11:23:24 -05:00
Christian Hammerl
426ec96ea5 docker: add support to add/drop capabilities 2016-12-08 11:23:23 -05:00
Brian Coca
9b38e47d70 added rickmendes as maintainer 2016-12-08 11:23:23 -05:00
Brian Coca
1976ed931a minor doc fixes to docker_user 2016-12-08 11:23:23 -05:00
Brian Coca
b62a6f01ab added version_Added for new signal option in docker module 2016-12-08 11:23:23 -05:00
Brian Coca
723a48ca73 added versionadded to new option in pip module 2016-12-08 11:23:23 -05:00
Brian Coca
07fedaa03a corrected v ersion added 2016-12-08 11:23:23 -05:00
ayush
f46daacf67 Updated doc strings so each character isn't considered a line 2016-12-08 11:23:23 -05:00
Toshio Kuratomi
8eba30b488 Deprecated _ec2_ami_search now verifies SSL certificates 2016-12-08 11:23:23 -05:00
Daniel Kerwin
277065a302 Too late for 1.8 2016-12-08 11:23:23 -05:00
Daniel Kerwin
3a68101fa3 Switch to _cap_ver_req and add cpu_set to create_containers 2016-12-08 11:23:23 -05:00
Alan Scherger
861d260b6c fix docs; only delete network if fwname is not provided 2016-12-08 11:23:23 -05:00
HelenaTian
1b614172f5 Update gce.py to correctly handle propagated metadata type from a mother template
My project is using Ansible to automate cloud build process. Ansible has a core module gce.py for managing GCE instances.
  We've come across a use case that's not yet supported - when executing ansible-playbook, if a child template is included, then metadata which is defined in and propagated from the mother template is treated as string type and not parsed correctly(which instead is dictionary type), and triggers release flow failure.
   We currently put some fix by explicitly casting metadata to string type in our own branch, but would like to contribute the fix to Ansible so that everyone onboarding GCE and using Ansible for release management could benefit from it, or hear owner's opinion on fixing the issue if there's a better fix in owner's mind:)
2016-12-08 11:23:23 -05:00
Petros Moisiadis
68ef885e71 make migrate command idempotent with django built-in migrations
Django since version 1.7 has built-in migrations, so no need to have south installed with recent django versions. The 'migrate' command works with built-in migrations without any change, but the output is different than the output produced by south, which breaks idempotence. This commit fixes this.
2016-12-08 11:23:23 -05:00
nemunaire
f37510ebaa Add optional signal parameter when killing docker container 2016-12-08 11:23:23 -05:00
Isaac Simmons
07ccd3c86b Handle ini file properties that contain interpolation errors in the initial values 2016-12-08 11:23:23 -05:00
Wouter Bolsterlee
3d7e3e3c3d Add a virtualenv_python argument to the pip module
This allows specifying the Python version to use when creating the
virtualenv. See issue #586.
2016-12-08 11:23:23 -05:00
Wouter Bolsterlee
5a0157a4f2 A few coding style cleanups 2016-12-08 11:23:22 -05:00
Wouter Bolsterlee
e8a0b8b8ae Fix typo in version_added field. 2016-12-08 11:23:22 -05:00
Daniel Kerwin
5b029bde98 Renamed to cpu_set 2016-12-08 11:23:22 -05:00
Daniel Kerwin
940baa92a6 Add support for cpusets. Requires docker-py >= 0.6.0 2016-12-08 11:23:22 -05:00
Brian Coca
87c8d016dc added version_Added to get_url's force_basic_auth 2016-12-08 11:23:22 -05:00
Patrik Lundin
88881415e9 synchronize: add flag for verifying target host.
Add the possibility to verify the target host using a "verify_host"
flag. It is disabled by default to not change the module behaviour.
2016-12-08 11:23:22 -05:00
Brian Coca
7a6c8251dd prevent usless assignment of home 2016-12-08 11:23:22 -05:00
bambou
ac41e7c669 Check if the gid is set 2016-12-08 11:23:22 -05:00
Brian Coca
fedd1bed1f minor doc fixes, version added for latest feature 2016-12-08 11:23:22 -05:00
Herby Gillot
c0676f93f5 rds: add the ability to reboot RDS instances 2016-12-08 11:23:22 -05:00
Eero Niemi
1f560f8dae Fixed parameter validation when creating a volume from a snapshot 2016-12-08 11:23:22 -05:00
whiter
2dc689894c Added 'resource_tags' alias 2016-12-08 11:23:22 -05:00
Brian Coca
a0b0c022b8 corrected version_added 2016-12-08 11:23:22 -05:00
Brian Coca
6980503357 updated to add missing 'use' option 2016-12-08 11:23:22 -05:00
David Shrewsbury
014459e5ef Add new os_nova_flavor module.
The os_nova_flavor module allows a user with administrative privileges
to create and delete nova flavors.
2016-12-08 11:23:22 -05:00
Brian Coca
ec6e75f1cc attempt to fix check mode when state='absent' 2016-12-08 11:23:21 -05:00
Mischa ter Smitten
10cae0acb3 The tilde expansion doesn't work with user.home 2016-12-08 11:23:21 -05:00
HAMSIK Adam
e04a4a4114 Use mutually_exclusive in AnsibleModule 2016-12-08 11:23:21 -05:00
otdw
8740b44205 removed required together for resource pools, clusters, and template deployments. fixes inability to deploy from template on vsphere clusters without resource pools. Also, resource pools and cluster should not be required together as they are independant in vsphere 2016-12-08 11:23:21 -05:00
Iiro Uusitalo
d6fc0ac5be uri.py is not using module_utils/urls.py from ansible core 2016-12-08 11:23:21 -05:00
HAMSIK Adam
3d3be5e91f Fix missing , 2016-12-08 11:23:21 -05:00
whiter
a5a9c92fcd Fixed dicts comparison for tags 2016-12-08 11:23:21 -05:00
Brian Coca
e4dd0d98d4 now captures any exceptions when trying to create directories 2016-12-08 11:23:21 -05:00
whiter
54b02ee0da ec2_vpc_net refactor 2016-12-08 11:23:21 -05:00
HAMSIK Adam
b7a13e263f Add version 2016-12-08 11:23:21 -05:00
HAMSIK Adam
05df069176 Add module parameter for security group name. This make ec2_elb_lb module consitent with others 2016-12-08 11:23:21 -05:00
Maksim Losev
482d8da2dc Use HostConfig object when creating container with Docker Remote API > 1.15
This is mlosev's patch (from #1208), rebased against devel as of
2790af2.  It resolves #1707, which was caused by an API incompatibility
between the docker module and server API version 1.19.
2016-12-08 11:23:21 -05:00
Lars Kellogg-Stedman
e031efd82c Do not erroneously mask exceptions
There was a catch-all `except` statement in `create_containers`:

        try:
            containers = do_create(count, params)
        except:
            self.pull_image()
            containers = do_create(count, params)

This would mask a variety of errors that should be exposed, including
API compatability errors (as in #1707) and common Python exceptions (KeyError, ValueError, etc) that could result from errors in the code.

This change makes the `except` statement more specific, and only attempts to pull the image and start a container if the original create attempt failed due to a 404 error from the docker API.
2016-12-08 11:23:21 -05:00
Lars Kellogg-Stedman
6116e4cdab docker: permit empty or false pid
The `docker` Python module only accepts `None` or `'host'` as arguments.
This makes it difficult to conditionally set the `pid` attribute using
standard Ansible syntax.

This change converts any value that evaluates as boolean `False` to
`None`, which includes empty strings:

    pid:

As well as an explicit `false`:

    pid: false

This permits the following to work as intended:

    - hosts: localhost
      tasks:
      - name: starting container
        docker:
          docker_api_version: 1.18
          image: larsks/mini-httpd
          name: web
          pid: "{{ container_pid|default('') }}"

If `container_pid` is set to `host` somewhere, this will create a
Docker container with `pid=host`; otherwise, this will create a
container with normal isolated pid namespace.
2016-12-08 11:23:21 -05:00
Brian Coca
9e54efd3fd fixed version added, reworded description a bit 2016-12-08 11:23:21 -05:00
Brian Coca
16a4ff3462 fixed minor doc issues 2016-12-08 11:23:21 -05:00
Brian Coca
0cab021168 Revert "Revert "ec2_lc - include all launch config properties in the return"" 2016-12-08 11:23:20 -05:00
Brian Coca
af8ded66cc Revert "ec2_lc - include all launch config properties in the return" 2016-12-08 11:23:20 -05:00
Toshio Kuratomi
a655241488 Minor touch ups of vsphere_guest code. 2016-12-08 11:23:20 -05:00
Brian Coca
60d160a2e9 Also document in example that unarchive download was added in 2.0 2016-12-08 11:23:20 -05:00
Mitchell Ludwig
b664603a4d Improved stat documentation 2016-12-08 11:23:20 -05:00
Frank van Tol
39e24e89f4 Remove default port value, it does not work in _requires_destroy_and_create logic
When creating a Redis cluster, every run it gets destroyed and recreated because the port number of memcached is used as the default.
2016-12-08 11:23:20 -05:00
Frank van Tol
6655cd89c4 Update elasticache.py 2016-12-08 11:23:20 -05:00
Frank van Tol
426f93a291 Remove default for engine_version
Redis and memcached have different engine version numbering, there can not be a shared default value.
2016-12-08 11:23:20 -05:00
Nicholas O'Connor
b95cb3f4e9 Created option snapshot_to_clone. When specified, snapshot_to_clone will create a linked clone copy of the VM. 2016-12-08 11:23:20 -05:00
Apoorva Kulkarni
1f35e578b4 s3 module: Add missing version tag to "encrypt" parameter 2016-12-08 11:23:20 -05:00
Chris Church
31a01305ba Set force=yes as the default, add force parameter to module docs. 2016-12-08 11:23:20 -05:00
James Cammarata
5efeeb156b Correctly default crypt_scheme in htpasswd 2016-12-08 11:23:20 -05:00
Chris Faulkner
18b157fbac Report change status on django_manage collectstatic. 2016-12-08 11:23:20 -05:00
Evan Carter
d3ef622627 Adding default cooldown to AWS ASG 2016-12-08 11:23:20 -05:00
vanga
ddd399fe7a Throw error if encryption is set while passing a snapshot id 2016-12-08 11:23:20 -05:00
Chris Meyers
0dbf41e740 ensure password or ssh cert specified 2016-12-08 11:23:20 -05:00
Tom Paine
e97124d609 Update vsphere_guest.py 2016-12-08 11:23:20 -05:00
acaveroc
dda41fd95a Add version_added and type of parameter 2016-12-08 11:23:19 -05:00
acaveroc
2c6f69c95e Assorted minor bug fixes
- Modified data type for port definition from string to integer
- Modified login_host default value for compatibilize with port definition according with MySQL Documentation (https://dev.mysql.com/doc/refman/5.0/en/connecting.html)
2016-12-08 11:23:19 -05:00
acaveroc
1283fdd118 Add port definition support for mysql_vars module 2016-12-08 11:23:19 -05:00
Joel Thompson
f1ab33ad7b Adding ability to filter AWS Route 53 private hosted zones by attached VPC 2016-12-08 11:23:19 -05:00
Hennadiy (Gena) Verkh
098126807d Update uri.py
Added methods 'TRACE', 'CONNECT' from https://www.rfc-editor.org/rfc/rfc2616.txt, section 5.1.1
Added method 'REFRESH'
2016-12-08 11:23:19 -05:00
Tal Auslander
8766641871 use ConvertTo-Bool for the force parameter 2016-12-08 11:23:19 -05:00
Tal Auslander
64f19fc4c6 stop reading from url on error 2016-12-08 11:23:19 -05:00
Tal Auslander
9c6d829991 add force parameter to win_get_url 2016-12-08 11:23:19 -05:00
Tal Auslander
26a54897a2 win_get_url re-download file only if modified 2016-12-08 11:23:19 -05:00
Hennadiy (Gena) Verkh
852c232b2d Removed method restriction in uri module 2016-12-08 11:23:19 -05:00
Ian Babrou
9219aeaaeb Pulling missing docker image before doing anything 2016-12-08 11:23:19 -05:00
Nic O'Connor
c68d1ffa60 Added the ability to Linked_clone from snapshot 2016-12-08 11:23:19 -05:00
Simon Olofsson
a3cb6d2f16 Add option docker_user for docker module.
docker_user can be used to specify the user or UID to use within the
container.
2016-12-08 11:23:19 -05:00
Iiro Uusitalo
b92dabb9fb Refactor force basic auth, now all modules which use fetch_url() can use force_basic_auth 2016-12-08 11:23:19 -05:00
Toshio Kuratomi
05be82183f Add notes about loop squashing and 1.9.2 change to install packages in one yum transaction 2016-12-08 11:23:19 -05:00
Monty Taylor
8e26a7ae17 Fix a small typo in parameter processing 2016-12-08 11:23:19 -05:00
Brian Coca
f8f4a7dcdf added ignore hidden to assemble 2016-12-08 11:23:18 -05:00
Jesse Keating
16381fb5c0 Plumb ipv6 modes into os_subnet
Shade already supports these, we just need to plumb them into the module
code.
2016-12-08 11:23:18 -05:00
Jesse Keating
72809ac329 Fix up docs 2016-12-08 11:23:18 -05:00
Sean Chittenden
4c8b573e2c Fix group mod and group add for FreeBSD 2016-12-08 11:23:18 -05:00
Juho-Mikko Pellinen
29620b78fa Change the default flag value to None to prevent AWS complaining: "Instance creation failed => InvalidBlockDeviceMapping: the encrypted flag cannot be specified since device /dev/sda1 has a snapshot specified." 2016-12-08 11:23:18 -05:00
Monty Taylor
530f12035b Update docstring to show port ranges as optional 2016-12-08 11:23:18 -05:00
David Shrewsbury
789c1fcbe7 Correct port matching logic
Port matching logic did not take into account recent shade change
to equate (None, None) to (1, 65535) when Nova is the backend.

Also, this encapsulates the port matching logic into a single function
and heavily documents the logic.
2016-12-08 11:23:18 -05:00
Flyte
2f46364921 Provide correct kwargs to rds2 connection when making a final snapshot 2016-12-08 11:23:18 -05:00
David Shrewsbury
387fe5b0e7 Change required parameters for rules module
The ports and protocol are no longer required (and now depends on
a new version of shade).
2016-12-08 11:23:18 -05:00
Davide Guerri
531b93490b Fix reuse argument documentation 2016-12-08 11:23:18 -05:00
Davide Guerri
95cfe3da96 Update os_floating_ip with new shade methods 2016-12-08 11:23:18 -05:00
Monty Taylor
4f2028439f Use int in the parameter list instead of casting 2016-12-08 11:23:18 -05:00
dagnello
2c3fc61357 Resolving issues in rule comparison algorithm
Port range min/max values are at times represented as string and
compared to int equivalents.  This fix explicitly ensures all
port range values are ints for proper comparisons.
2016-12-08 11:23:18 -05:00
David Shrewsbury
e7dd93c5c1 Compare ports as strings
Ports as returned from shade are ints. They are strings as they come
in to the module.
2016-12-08 11:23:18 -05:00
David Shrewsbury
14212c37e2 Fix syntax error 2016-12-08 11:23:18 -05:00
Monty Taylor
60102e36e2 Return rule object 2016-12-08 11:23:18 -05:00
David Shrewsbury
174254a423 Update secgroup rules module for latest shade
This allows the rules module to work against either nova or neutron
for handling security groups. New parameters for 'direction' and
'ethertype' are added.

Check mode is supported with this version.
2016-12-08 11:23:18 -05:00
David Shrewsbury
fcc1d643f6 Recongnize None and -1 port equivalency
shade 0.7.0 represents disabled min/max ports as None (in the
neutron style) rather than -1. Recognize this as the same as -1.
2016-12-08 11:23:17 -05:00
David Shrewsbury
b42a9d56e6 Fix id value reference 2016-12-08 11:23:17 -05:00
David Shrewsbury
f02ec15c17 Update rules mode for latest shade
Shade 0.7.0 normalized the security group data that is returned,
when using nova, to look more like neutron security group data.
This adjusts for that change.
2016-12-08 11:23:17 -05:00
dagnello
ecef2aadba Minor fixes for os_security_group_rule module
Was not able to use this module as it was.  The changes submitted
resolved the issues I ran into in order to get it working.
2016-12-08 11:23:17 -05:00
Davide Guerri
2d7dbc5d0c Fix invalid syntax in openstack_module_kwargs call 2016-12-08 11:23:17 -05:00
Monty Taylor
9acc891477 Fix example code syntax 2016-12-08 11:23:17 -05:00
0tmc
6e4c5e0a12 Use of proper fstab file on FreeBSD 2016-12-08 11:23:17 -05:00
Monty Taylor
a657e80bc8 Add OpenStack Floating IP Module
Also deprecate the two old quantum floating ip modules.
2016-12-08 11:23:17 -05:00
Monty Taylor
8d5e43c14f Add OpenStack Security Group Rule module 2016-12-08 11:23:17 -05:00
Juho-Mikko Pellinen
321244d881 Remove empty aliases 2016-12-08 11:23:17 -05:00
Juho-Mikko Pellinen
54af79692a Add version number 2016-12-08 11:23:17 -05:00
Juho-Mikko Pellinen
f016cb556b Fix hosted_zone_id after rebase. 2016-12-08 11:23:17 -05:00
Juho-Mikko Pellinen
3f2d1e6bfa Add support for specifying unique hosted zone identifier 2016-12-08 11:23:17 -05:00
Scott Miller
62b6cf85d3 Update cloudformation.py
Fix for inaccurate phrasing
2016-12-08 11:23:17 -05:00
Brian Coca
e7dc05df11 updated upgrade to a more sensible default as the previous was prone to confusion fixes #1667 2016-12-08 11:23:17 -05:00
Robb Wagoner
848e9de950 remove double dict & fix increment bug 2016-12-08 11:23:16 -05:00
Mike Putnam
0e6e3e097e Upstream docs show launch_config_name as required.
http://docs.aws.amazon.com/AutoScaling/latest/APIReference/API_AutoScalingGroup.html

Fixes #11209

Ansible behavior is correct, this commit just updates the docs to
reflect that correctness.
2016-12-08 11:23:16 -05:00
verm666
ac40d9f41a fix authorized_keys in check_mode
This change is in response to issue #1515.
Original pull request #1580.

The original problem is: in authorized_key module you have no idea about users
which will be created by Ansible at first run. I can propose next two ways to
solve this problem:

  1. Combine modules system/user.py and system/authorized_key.py in one module
     (so you will know everything about users in that module)
  2. Use small workaround: add my commit and always provide 'path' parameter
     for authorized_key module during runs with --check option.
2016-12-08 11:23:16 -05:00
Matthew Gilliard
17a40aa259 Handle race condition in directory creation.
If we try to make a directory, but someone else creates the directory
at the same time as us, we don't need to raise that error to the user.
They asked for the directory to exist, and now it does. This fixes
the race condition which was causing that error to be raised, and
closes #1648.
2016-12-08 11:23:16 -05:00
Matt Martz
f33a8b09a9 Remove unnecessary imports in a docs only file for win_copy 2016-12-08 11:23:16 -05:00
Matt Martz
d47de74ade Replaced tabbed indentation with spaces for group module 2016-12-08 11:23:16 -05:00
Matt Martz
30d5c1166c Replaced tabbed indentation with spaces for subversion module 2016-12-08 11:23:16 -05:00
Matt Martz
a0f5ae8726 Replaced tabbed indentation with spaces for apt module 2016-12-08 11:23:16 -05:00
Matt Martz
3d28efaf7e Replace tabbed indentation with spaces for mysql_db module 2016-12-08 11:23:16 -05:00
Toshio Kuratomi
cf595b3c52 Fix indentation levels in os_keypair 2016-12-08 11:23:16 -05:00
Toshio Kuratomi
4c863187ad Few minor things from review of the pull request 2016-12-08 11:23:16 -05:00
verm666
6acfa5fcee unarchive: fix @bcoca's remarks, issue #1575 2016-12-08 11:23:16 -05:00
Toshio Kuratomi
432764b703 Add version that the profilename param was added 2016-12-08 11:23:16 -05:00
Jesse Keating
2b5af82706 Document auto_floating_ip argument 2016-12-08 11:23:16 -05:00
David Shrewsbury
3cd81d2dd3 Use newest documentation style for return value. 2016-12-08 11:23:16 -05:00
Jonathan Davila
f1027ae6bc no_log to iam password 2016-12-08 11:23:16 -05:00
David Shrewsbury
c4bc6dea13 Add a note about the return value. 2016-12-08 11:23:15 -05:00
Scott Miller
b43db1d2ff update docs for cloudformation 2016-12-08 11:23:15 -05:00
James Meickle
8197d7e640 Change uri debug example 2016-12-08 11:23:15 -05:00
Monty Taylor
c0190b0443 Fix dict syntax typo 2016-12-08 11:23:15 -05:00
Andreas Reischuck
3cc14a0a65 fixed win_file state=touch 2016-12-08 11:23:15 -05:00
ToBeReplaced
5e259a8dd9 Make ALL_IN_SCHEMA for tables affect views
ALL TABLES is considered to include views, so we must check for reltypes
'r' and 'v', not just 'r'. This bug was introduced due to using a
custom, backwards-compatible version of "ALL TABLES IN SCHEMA".
2016-12-08 11:23:15 -05:00
Robb Wagoner
372a2286db return health of instances and counts 2016-12-08 11:23:15 -05:00
verm666
b898cb656b unarchive: fix work with 0 bytes archives
This change is in response to issue #1575
2016-12-08 11:23:15 -05:00
Vladimir Martsul
db646757c1 Add "force" description
Add "force" option description
2016-12-08 11:23:15 -05:00
Patrick Roby
e638913c97 iterate through all keys in a more pythonic manner 2016-12-08 11:23:15 -05:00
Patrick Roby
bc5d79fc30 update documentation, adding new params 2016-12-08 11:23:15 -05:00
David Shrewsbury
341efbf7ae Update os_keypair for latest shade
Uses the latest version of shade for cleaner code. Also, always
return the key dict whether we create the key, or it already exists.
The example using public_key_file is corrected to use a full path
since ~ is not converted for us.
2016-12-08 11:23:15 -05:00
Evan Carter
98756144cf Add ClassicLink settings to EC2_launchconfig 2016-12-08 11:23:15 -05:00
Andrea Mandolo
ae1080d922 Added some block_device_mapping (disks) informations to EC2 instance module ouput 2016-12-08 11:23:15 -05:00
Andrea Mandolo
a8da674cf4 Added "EC2 instance" termination_protection and source_dest_check changeability at run-time 2016-12-08 11:23:15 -05:00
Tom Paine
df8013182e Parse out space characters in route53 value list
Fixes: https://github.com/ansible/ansible-modules-core/issues/992
2016-12-08 11:23:15 -05:00
Michael Weinrich
543cb13f42 Fix connection creation to allow usage of profiles with boto 2016-12-08 11:23:15 -05:00
Toshio Kuratomi
f422782180 Use module.fail_json() instead of sys.exit() 2016-12-08 11:23:14 -05:00
Toshio Kuratomi
53c840e275 Add testing of docs to the core repo 2016-12-08 11:23:14 -05:00
Brian Coca
b261fd8d3e added doc to note that git the command line tool is required for this moduel to function fixes http://github.com/ansible/ansible/issues/11358 2016-12-08 11:23:14 -05:00
Brian Coca
e91818ef77 updated docs to clarify use of exclusive 2016-12-08 11:23:14 -05:00
Roetman, Victor
fa612a14b1 apache2_module documetation update
requires a2enmod and a2dismod
2016-12-08 11:23:14 -05:00
Ash Wilson
9f12fd0a26 Default net to 'bridge' in container diff
This prevents an unnecessary reload when the `net` parameter is unspecified
(i.e. almost always).
2016-12-08 11:23:14 -05:00
verm666
9b3aa0a9d4 This change is in response to issue #133.
The original problem is: apt_repository.py connect to launchpad on
every playbook run. In this patch apt_repository.py checks if required
repository already exists or not. If no - paa will be added, if yes -
just skip actions.
2016-12-08 11:23:14 -05:00
Michael Weinrich
a0466f1f8d Add the option to pass a string as policy 2016-12-08 11:23:14 -05:00
Monty Taylor
869da89b35 Move the order of argument processing 2016-12-08 11:23:14 -05:00
Monty Taylor
377311db56 Add filter ability 2016-12-08 11:23:14 -05:00
Ed Hein
f11c451bfa Fix computation of port bindings. Port bindings configuration can be a list if several host ports are bound to the same guest port. 2016-12-08 11:23:14 -05:00
Davide Guerri
c1d7678cc2 Avoind using lookup() in documentation
lookup() is currently broken (current Ansible devel branch), so better to avoid
it in our examples.
2016-12-08 11:23:14 -05:00
Konstantin Gribov
8d91c3a61a Escape spaces, backslashes and ampersands in fstab
Fixes #530.

It's more generic than #578 which only fixes spaces escaping in name (target dir to mount).
Escaping is used in both `set_mount` (important for `src`, `name` and `opts`) and
`unset_mount` (for `name`).

It's shouldn't be used in `mount` and `umount` since `name` parameter is passed as array element
to `module.run_command`.

Signed-off-by: Konstantin Gribov <grossws@gmail.com>
2016-12-08 11:23:14 -05:00
Arata Notsu
cc76a479e1 Not use "is" to compare strings
As "is" tests whether if operands are the same object rather than
they have the same value, potentially causes a wrong result.
2016-12-08 11:23:14 -05:00
Bryan Fleming
6f8d60a5ed fixes #1120 - privileges using columns 2016-12-08 11:23:13 -05:00
Lucas David Traverso
20aa4c0cea django_manage: Use shebang in manage.py instead of hardcode python 2016-12-08 11:23:13 -05:00
Andrew Davis
4d4d911d6e ansible_facts reflects 1.8 output 2016-12-08 11:23:13 -05:00
Monty Taylor
0c0359798b Add OpenStack Keypair module
Also deprecate old nova_keypair module.
2016-12-08 11:23:13 -05:00
Ash Wilson
ea83727fcf Wait for process exit on detached=no. 2016-12-08 11:23:13 -05:00
Ian Clegg
f9c294f1ad Added support for comma seperated feature names in the name parameter of the win_feature module 2016-12-08 11:23:13 -05:00
Tagir Bakirov
8bd367eac7 added 'absent' option to supervisorctl 2016-12-08 11:23:13 -05:00
Stefan Junker
4ee972190b docker: Use a list instead of a dict for volumes according to the docker-py docs. Do not add host-binds to volumes list. 2016-12-08 11:23:13 -05:00
gimoh
fd69c5687b Do not insert extra newline if line already contains it
When using YAML multi-line strings, e.g.:

- lineinfile:
    dest: /tmp/foo
    line: >
      foo
      bar

the line already ends with a newline.  If an extra newline is appended unconditionally it will lead to inserting an extra newline on each run.
2016-12-08 11:23:13 -05:00
Jens Carl
9ad15cdae9 - List the name servers of a zone. 2016-12-08 11:23:13 -05:00
Alexis Seigneurin
53e9caa1d0 - 'name' should not be required so as to allow uninstalling a cron_file 2016-12-08 11:23:13 -05:00
Annika Backstrom
6b2c89a422 Force redownload if sha256sum does not match 2016-12-08 11:23:13 -05:00
Igor Khomyakov
03483d2ea5 Check if a service exists 2016-12-08 11:23:13 -05:00
Federico G. Schwindt
b6258a1e4c Document globbing support 2016-12-08 11:23:13 -05:00
sysadmin75
f096359608 ansible-modules-core #530 fix - Mount module does not accept spaces in mount point path 2016-12-08 11:23:13 -05:00
Chris Church
3048626d6e Update docs, add example of using django_manage to run other commands. 2016-12-08 11:23:13 -05:00
Stefan Junker
50fe57fff3 Fix bind-volumes on docker >= 1.4.0
If bind-volumes are submitted to docker >= 1.4.0 with the volumes set in addition to the binds, docker will create a regular volume and not bind-mount the specified path.
2016-12-08 11:23:13 -05:00
Federico G. Schwindt
fa463fb1b7 Allow globbing in creates= and removes= directives
Fixes 1904
2016-12-08 11:23:12 -05:00
Robb Wagoner
e025effc99 include all launch config properties in the return
make all properties available when registering the result
which is useful when wanting to launch a stand-alone instance based upon
an existing Launch Config.
2016-12-08 11:23:12 -05:00
Toshio Kuratomi
870446dd6b Update version_added to 2.0 for the partial option 2016-12-08 11:23:12 -05:00
Jonathan Davila
82b809f0e2 new vpc module. does not contain subnet or route table functionality.
changed name to ec2_vpc_net

refactored out IGW functionality
2016-12-08 11:23:12 -05:00
Juan Picca
81ea358b09 synchronize module: add partial option 2016-12-08 11:23:12 -05:00
Toshio Kuratomi
5118d0e3b1 Add note about redirects proxies
Fixes #1574
2016-12-08 11:23:12 -05:00
Toshio Kuratomi
0a3150f7d7 Add version_added documentation to log_driver parameter 2016-12-08 11:23:12 -05:00
Toshio Kuratomi
9ecd06fb47 Fix apt_repository so that it does not modify the mode of existing repositories 2016-12-08 11:23:12 -05:00
Michael Weinrich
1f6c177da0 Use aws connect calls that allow boto profile use 2016-12-08 11:23:12 -05:00
Ryan Walls
01a28e7d80 Fix typo in Docker module. 2016-12-08 11:23:12 -05:00
Ryan Walls
9630972c2c Update docker module to avoid false positives when containers are first created. Also have the module check for api compatibility before trying to set a "--log-driver" option. 2016-12-08 11:23:12 -05:00
Ryan Walls
f5c1d8141b Set default "log_driver" option to None in docker module. 2016-12-08 11:23:12 -05:00
Ryan Walls
0df1b01cb2 Update docker module to look at log_driver variable when deciding if container configuration has changed. 2016-12-08 11:23:12 -05:00
Ryan Walls
3419a1e253 Add support for --log-driver option that docker released with Docker 1.6 2016-12-08 11:23:12 -05:00
Alex King
c8ae53b308 Extend hashes that can be specified by crypt_scheme beyond those understood by Apache/Nginx. 2016-12-08 11:23:12 -05:00
Sebastian Gerhards
a979417a4a rhn_register: add support for profilename 2016-12-08 11:23:12 -05:00
Jim Patterson
4185ffc43e Correct check mode for pip in virtualenv.
Fix #412.  Check mode was always returning changed=True for pip
when the target was in a virtualenv.  The code now uses the normal
tests for determining if change status.
2016-12-08 11:23:11 -05:00
Lorin Hochstein
abf314c258 django_manage: expand ~ in app_path parameter
Allow users to specify app_path parameters that contain ~, for example:

app_path=~/myproject
2016-12-08 11:23:11 -05:00
Pierre-Louis Bonicoli
c366e7acb2 apt_repository: fix file mode
'set_mode_if_different' method should be called on dest filename and after
'atomic_move' method
2016-12-08 11:23:11 -05:00
Patrick Roby
b318bc8b43 Add support for listing keys in a specific S3 bucket
Includes support for specifying a prefix, marker, and/or max_keys. Returns a list of key names (as strings).
2016-12-08 11:23:11 -05:00
James Cammarata
4239922d07 Updating version_added for new spot_type param in ec2 module
Also made sure 'choices' were set on the module param, to catch errors
in user's playbooks, etc.
2016-12-08 11:23:11 -05:00
Toshio Kuratomi
cb776e6190 Fix for when the password file did not exist previously 2016-12-08 11:23:11 -05:00
Jay Taylor
ed279d8175 Added support for spot request type specification (to support persistent spot requests). 2016-12-08 11:23:11 -05:00
Toshio Kuratomi
bd87c11c2a Read the url in in chunks so that we don't use as much memory for large packages 2016-12-08 11:23:11 -05:00
Toshio Kuratomi
2e7dcf3317 Small cleanups. * Import url(lib|parse|lib2) if needed by the module rather than relying on module_utils.urls to do so. * Remove stdlib modules from requirements * Use the if __name__ conditional for invoking main() 2016-12-08 11:23:11 -05:00
Toshio Kuratomi
5f27a073ba Bump amount of file to download in a chunk to 64k. 2016-12-08 11:23:11 -05:00
Jonathan Mainguy
dd0659c83d add download ability to unarchive module 2016-12-08 11:23:11 -05:00
zimbatm
99e2557b42 route53: add support for routing policies
It is now possible to pass various routing policies if an identity is
provided.

This commit also introduces multiple optimisations:
* Only fetch records for the given domain
* Use UPSERT instead of DELETE+CREATE to update existing records
2016-12-08 11:23:11 -05:00
billwanjohi
86e679fe3c iam: use modern helper to allow sts
previous implementation ignored the session token when present
2016-12-08 11:23:11 -05:00
James Cammarata
5cd3c6ebe6 Update choices and version_added for new gce.py param service_account_permissions 2016-12-08 11:23:11 -05:00
Michal Smereczynski
9d4b252f56 Added new Premium Storage instance sizes and case-related documentation clarification. 2016-12-08 11:23:11 -05:00
murdochr
aae140e6cd Change docs to reflect correct when syntax for matching variable strings as per MD's forum post as this fails with unhelpful error otherwise.
https://groups.google.com/forum/#!topic/ansible-project/D2hQzZ_jNuM
2016-12-08 11:23:11 -05:00
Monty Taylor
186fbd7645 Remove duplicate shade requirement 2016-12-08 11:23:10 -05:00
Monty Taylor
73cb529d2c Make sure we're always returning objects too 2016-12-08 11:23:10 -05:00
dagnello
072110c757 Resolving secgroup.id issue in this module
secgroup['id'] was not being returned in all cases where the
specified security group exists.
2016-12-08 11:23:10 -05:00
toninog
bea77c938e fixes to code to enable updates of user to groups and delete groups. Fixed example yaml to use groups 2016-12-08 11:23:10 -05:00
toninog
ab7678f199 Fixed more issues with the delete_group and paramater mismatch 2016-12-08 11:23:10 -05:00
Jonathan Mainguy
c9d1cc0ce3 remove blank lines from htpasswd file
used standard mktemp()
2016-12-08 11:23:10 -05:00
Vasyl Kaigorodov
758688a667 GCE module: added Service Account permissions sanity checks 2016-12-08 11:23:10 -05:00
Vasyl Kaigorodov
4400c5e163 GCE module: document Service Account permissions parameter usage 2016-12-08 11:23:10 -05:00
Vasyl Kaigorodov
97e880a27f GCE module: add posibility to specify Service Account permissions during instance creation 2016-12-08 11:23:10 -05:00
Jonathan Davila
6482ad964f iam certificate module
boto import tweak

style patch
2016-12-08 11:23:10 -05:00
Dan Abel
a51a8e1fd6 use aws connect calls that allow boto profile use 2016-12-08 11:23:10 -05:00
Hagai Kariti
b46a1ff3e1 Hostname module should update ansible_hostname 2016-12-08 11:23:10 -05:00
Vyronas Tsingaras
654d2d3f60 This enable one to find a datastore with no config_target supplied
Signed-off-by: Vyronas Tsingaras <vtsingaras@it.auth.gr>
2016-12-08 11:23:10 -05:00
Jon Hawkesworth
a00d86946d document file size limit for win_copy module 2016-12-08 11:23:10 -05:00
Vyronas Tsingaras
56957ca45e Remember power state when starting vm reconfigure
This commit fixes #1391

Signed-off-by: Vyronas Tsingaras <vtsingaras@it.auth.gr>
2016-12-08 11:23:10 -05:00
Matt Martz
158772ffc2 Fix some remaining rax asg idempotency checks 2016-12-08 11:23:10 -05:00
Benno Joy
17c185c8d1 enable azure to provision windows instances 2016-12-08 11:23:09 -05:00
Benno Joy
2314670952 enable the module to provision windows instances 2016-12-08 11:23:09 -05:00
Colin Hutchinson
97a2cd0bd9 Indentation fix for with and register in the ec2_vol example 2016-12-08 11:23:09 -05:00
Ritesh Khadgaray
9c3f9d23c8 Add the ability to grep for content 2016-12-08 11:23:09 -05:00
Vyronas Tsingaras
bdb33b5756 Properly check if vm_hardware contains keys
This commit fixes #1475

Signed-off-by: Vyronas Tsingaras <vtsingaras@it.auth.gr>
2016-12-08 11:23:09 -05:00
Vyronas Tsingaras
262e86b36b Use either esxi:dc,host OR cluster,resource_pool
vsphere_guest now can deploy a template using a datacenter and hostname
as the target, instead of requiring a cluster and resource_pool.

This commit fixes #951.

Signed-off-by: Vyronas Tsingaras <vtsingaras@it.auth.gr>
2016-12-08 11:23:09 -05:00
Robin Roth
abc89f0df5 add comment: ports need to be exposed.
port mapping with this module only works for ports that are exposed either in the Dockerfile or via an additional arguments. This is different from the command line docker client, that is willing to also map ports that are not exposed.

This comments makes the behaviour more obvious.
2016-12-08 11:23:09 -05:00
Monty Taylor
8ff71a3fa8 Actually use changed variable 2016-12-08 11:23:09 -05:00
Monty Taylor
4125b576e9 Return the secgroup for all present states 2016-12-08 11:23:09 -05:00
Monty Taylor
b955b2f5c8 Return resource objects from OpenStack modules
It's not uncommon for people to want to do additional things after
creating a module. Also, add a note about it to the dev notes.
2016-12-08 11:23:09 -05:00
Monty Taylor
89f95471f8 Return secgroup, not just id 2016-12-08 11:23:09 -05:00
Philip Kirkland
cc214afed6 adding 'encrypted' option into volume dict so ec2 module can easily include encrypted volumes 2016-12-08 11:23:09 -05:00
Toshio Kuratomi
88ae201b20 Fix bugs found by @kustodian 2016-12-08 11:23:09 -05:00
Toshio Kuratomi
f0f1dc985f Fix incorrect line breaking 2016-12-08 11:23:09 -05:00
Toshio Kuratomi
9f043d9ba8 Further optimizations pointed out by @kustodian in #1516
* Only install yum-utils if needed (b/c we're going to use repoquery)
* Add a warning message explaining that why slower repoquery was used
  rather than yum API.
2016-12-08 11:23:08 -05:00
Toshio Kuratomi
ba566501a8 Yum API is faster than calling out to repoquery. Looking through the commit logs it looks like we weren't previously doing that because of commit 14479e6adc
The message there is that Yum API prints an error message if the
rhn-plugin is in use and no rhn-certificate is available.  So instead of
using repoquery in preference always here we use repoquery in preference
if the rhn-plugin is enabled.
2016-12-08 11:23:08 -05:00
David Shrewsbury
9cbd7b2ece Remove os_security_group_rule module
The rules module will have it's own branch.
2016-12-08 11:23:08 -05:00
David Shrewsbury
6527f895a1 Remove 'result' value
This value is pretty much useless, and a holdover from the old
module code. Let's remove it.
2016-12-08 11:23:08 -05:00
Monty Taylor
eb2f3c8a44 Update version added 2016-12-08 11:23:08 -05:00
David Shrewsbury
7f0da6d851 Update the docstring for os_security_group
Indicate that idempotence is on security group names, and give
an example for updating a security group description.
2016-12-08 11:23:08 -05:00
David Shrewsbury
640dbee643 Update for latest shade API
Shade version 0.7.0 introduces new API methods for creating,
deleting, and updating security groups. Let's use those and
clean up the module.
2016-12-08 11:23:08 -05:00
az7arul
5ffb677b00 add include_doc option 2016-12-08 11:23:08 -05:00
Jamie Hannaford
f969bc0549 Fix get_launch_config var name 2016-12-08 11:23:08 -05:00
Jamie Hannaford
6b9310ecfb Fix attribute name for Auto Scale servers 2016-12-08 11:23:08 -05:00
Julia Kreger
d67ba5e25b Updating os_ironic_node module
Updating the os_ironic_node module to the most recent version
including support for power and maintenance states.
2016-12-08 11:23:08 -05:00
Julia Kreger
51149b9643 Updating os_ironic module
Updating os_ironic module to the most recent version accounting for
changes in Ansible devel branch and the shade library since the
original creation of the module.
2016-12-08 11:23:08 -05:00
nitzmahone
548ab163f5 Added choice validation for state arg
fixes traceback on invalid state arg
2016-12-08 11:23:08 -05:00
Toshio Kuratomi
ada424078b Restore setting cachedir when non-root but don't take a useless cachedir parameter to the function
* Revert "Remove unused code"
  This reverts commit bcfba0c050.
* Re-add the changes to remove cachedir as a parameter
2016-12-08 11:23:08 -05:00
Greg DeKoenigsberg
4cdd58064d Updated author data for modules 2016-12-08 11:23:08 -05:00
Sergei Antipov
e62f870859 mysql_user | Hide password 2016-12-08 11:23:08 -05:00
Greg DeKoenigsberg
eb881d7d5d Proper author info for all remaining modules 2016-12-08 11:23:07 -05:00
Greg DeKoenigsberg
18ca7aee07 Updating cloud modules with proper github author information 2016-12-08 11:23:07 -05:00
Robert Estelle
8b2327fe3a Fix missing instance_id param in ec2_eip. 2016-12-08 11:23:07 -05:00
Kamil Madac
1ae799f361 Better error handling in supervisorctl module.
If execution of supervisorctl was not successful (exit code > 0),
module silently supress this error and returns changed = false,
which turns to OK task state.
This is very confusing, when supervisorctl needs authentication,
and credentials are not specified in module or are incorrect,
services are not restarted/started/stopped without raising an error.
2016-12-08 11:23:07 -05:00
Monty Taylor
574bcac277 Add developer docs for the OpenStack modules 2016-12-08 11:23:07 -05:00
Hagai Kariti
b154ad4cbb ec2_vol: fix race conditions because we handle errors before actually deleting
Just try to delete the volume and handle the error amazon sends
2016-12-08 11:23:07 -05:00
Tyler Cross
9babe9b07d Get specific object version with S3 module.
- allow specifying version for mode=get and mode=getstr
- when version specified doesn't exist give an error message that indicates so
2016-12-08 11:23:07 -05:00
Pepe Barbe
5dc322b911 Add OS architecture and OS name to the Windows setup module 2016-12-08 11:23:07 -05:00
Monty Taylor
51ce05bfb9 Add Ironic Node module 2016-12-08 11:23:07 -05:00
Monty Taylor
e534753092 Add Ironic module 2016-12-08 11:23:07 -05:00
Monty Taylor
0447a88c80 Add OpenStack Object module 2016-12-08 11:23:07 -05:00
Monty Taylor
234a6c93c7 Add OpenStack Security Group support
Two modules - one for security groups and one to manage rules in a
security group.
2016-12-08 11:23:07 -05:00
Robert Estelle
ecae3403af Remove unnecessary wait_timeout parameter. 2016-12-08 11:23:07 -05:00
Robert Estelle
3798c8c0ce Refactoring of ec2_eip module. 2016-12-08 11:23:07 -05:00
Robert Estelle
41f7e4ed5e ec2_eip - PEP8 and minor style cleanups. 2016-12-08 11:23:07 -05:00
Robert Estelle
a41994974c EC2 Security Group - Validate parameters. 2016-12-08 11:23:07 -05:00
Edward Torbett
3a4d8f22a6 Renamed previous pkgs variable to installed_pkgs as spotted by @strahinja 2016-12-08 11:23:06 -05:00
Edward Torbett
dad26d70fa Corrected pkg to pkgs as noted by @abadger 2016-12-08 11:23:06 -05:00
Edward Torbett
9707a5a95e Added multi package operation to remove as suggested by @abadger. Adding to latest is a little more complex due to '*' support. 2016-12-08 11:23:06 -05:00
Edward Torbett
32180c3c0e Comments by @abadger 2016-12-08 11:23:06 -05:00
Edward Torbett
4b3fff108d Rather than executing yum once per package, execute yum once for all supplied packages. This is necessary when performing a yum upgrade involving multiple dependent packages installed from RPM, for example when upgrading from PostgreSQL 9.0.11 to 9.0.21 on a Red Hat server. 2016-12-08 11:23:06 -05:00
Ching Yi, Chan
be9cddbddf Refactoring for easier to read 2016-12-08 11:23:06 -05:00
Ching Yi, Chan
7cafbb5f05 Prevent memory-error from a large file 2016-12-08 11:23:06 -05:00
Soenke Ruempler
b57bcac72f Add support for SNS notification ARNs in CloudFormation 2016-12-08 11:23:06 -05:00
Andrea Mandolo
adb53cc3c5 Add "block_device_mapping" parameter on EC2_AMI Amazon module (DOCUMENTATION) - upgraded 2016-12-08 11:23:06 -05:00
Jon Hawkesworth
c86ed93f67 remove include of files options only relevant to unix from win_file.py documentation 2016-12-08 11:23:06 -05:00
Brian Coca
f66ed3a85e minor doc fixes on win_template 2016-12-08 11:23:06 -05:00
Bruce Pennypacker
4cb7df2631 Added delobj command to delete an object within a bucket 2016-12-08 11:23:06 -05:00
Jon Hawkesworth
a9b77e8480 corrected version added which I got wrong while rebasing 2016-12-08 11:23:06 -05:00
Jon Hawkesworth
5b6195e613 Fix win_copy problems described here: https://github.com/ansible/ansible-modules-core/issues/1404 and update documentation. 2016-12-08 11:23:06 -05:00
Brian Coca
b2dadaadf8 Revert "added innitial daemon-reloaded support to service module"
This reverts commit 438d87d269.
2016-12-08 11:23:06 -05:00
Brian Coca
3d42d8897e fixed doc issue with git 2016-12-08 11:23:06 -05:00
Brian Coca
523b4d638e updated version added 2016-12-08 11:23:05 -05:00
Louis-Michel Couture
03240cfcb6 Update example to remove outdated information 2016-12-08 11:23:05 -05:00
Brian Coca
61054921cf updated package examples 2016-12-08 11:23:05 -05:00
Brian Coca
d4d362b475 corrected copyright ... does a copied the copyrightnotice require copyright? 2016-12-08 11:23:05 -05:00
Brian Coca
0f30122750 may root help us all 2016-12-08 11:23:05 -05:00
Brian Coca
55d04f4ddf added innitial daemon-reloaded support to service module 2016-12-08 11:23:05 -05:00
Dionysis Grigoropoulos
59f7db899d git: Add option to verify GPG signature of commit 2016-12-08 11:23:05 -05:00
Alex Gandy
75fa5811db Added volumes dict to ec2_lc example 2016-12-08 11:23:05 -05:00
toninog
15b65fa115 Fixed bug in example where updating a user to a group Fixed bug in create_group and update_group whereby paramaters were not being set correctly. 2016-12-08 11:23:05 -05:00
Monty Taylor
97ce6a500d Update doc params and version_added 2016-12-08 11:23:05 -05:00
Benno Joy
f6f2359400 fix for 11177 where module readds rule even if the rules exists 2016-12-08 11:23:05 -05:00
Monty Taylor
29115f0602 AnsibleModule takes a dict as a param 2016-12-08 11:23:05 -05:00
Monty Taylor
dbf821ff67 Return a list of OpenStack clouds
The main use of this is to feed jinja templating, so structure the
data returned slightly better for that purpose.
2016-12-08 11:23:05 -05:00
Monty Taylor
b87c9002ae Add OpenStack Client Config module
All of the ansible OpenStack modules are driven by a clouds.yaml config
file which is processed by os-client-config. Expose the data returned by
that library to enable playbooks to iterate over available clouds.
2016-12-08 11:23:05 -05:00
Monty Taylor
58942eba2e Use the delete method from shade
Sigh. Turns out glance v1 and glance v2 delete images differently too.
2016-12-08 11:23:05 -05:00
Monty Taylor
8958deeb02 Don't update image properties if we're deleting 2016-12-08 11:23:05 -05:00
Monty Taylor
a4e4dbd863 Add OpenStack Image module
Also deprecate old glance_image module
2016-12-08 11:23:05 -05:00
Brian Coca
5ae6f5b767 reverting pep changes that were breaking documentation 2016-12-08 11:23:04 -05:00
Brian Coca
336c22bfd9 made non exec 2016-12-08 11:23:04 -05:00
Tim Mahoney
fb3c457122 Elasticache Subnet Group 2016-12-08 11:23:04 -05:00
Monty Taylor
0bc85d461b Add missing state parameter 2016-12-08 11:23:04 -05:00
Sankalp Khare
f7055c88de Fixed a typo in ec2_vpc module documentation 2016-12-08 11:23:04 -05:00
billwanjohi
ff7dfefbd6 cloudformation: accept local templates in yaml format
Since the YAML data format is a subset of JSON, it is trivial to convert
the former to the latter. This means that we can use YAML templates to
build cloudformation stacks, as long as we translate them before passing
them to the AWS API. I figure this could potentially be quite popular in
the Ansible world, since we already use so much YAML for our playbooks.
2016-12-08 11:23:04 -05:00
James Martin
38d0f31cac Streamlined rolling udpate algorithm. Still need to account for partials, and not waiting for instances if we're mass terminating them. 2016-12-08 11:23:04 -05:00
Demian Gemperli
1c5cb83ff3 Allow to add build flags for gem installation 2016-12-08 11:23:04 -05:00
whiter
fc53c2431d Added changed=True flag when new subnet groups created. Added conditional so that modify_db_subnet_group is only called when necessary and changed=True flag will be set. 2016-12-08 11:23:04 -05:00
Jonathan Davila
77fa67a240 author fix 2016-12-08 11:23:04 -05:00
Jonathan Davila
d4aff86349 iam_policy 2016-12-08 11:23:04 -05:00
Trevor Pounds
9de952cb3f Instance deregistration should try all associated ELBs. Fixes #869 2016-12-08 11:23:04 -05:00
Trevor Pounds
eff6307ac3 Use auto scaling group managed ELBs if present. 2016-12-08 11:23:04 -05:00
Jonathan Davila
a329dc05c0 iam module with fixes
iam module. fix policy issue.

bugfix

allow for modifying path without declaring new_path
2016-12-08 11:23:04 -05:00
Gugli
a00c078912 Add support for repos with svn:externals files
When a SVN repository has some svn:externals properties, files will be
reported with the X attribute, and lines will be added at the end to
list externals statuses with a text looking like
"Performing status on external item at ....".
Such lines were counted as a local modification by the regex, and the
module returned a change, even though they were none.

To have a clean (and parsable) "svn status" output, it is recommended
to use the --quiet option. The externals will only appear if they have
been modified. With this option on, it seems even safer to consider
there are local modifications when "svn status" outputs anything.
2016-12-08 11:23:04 -05:00
Raghu Udiyar
e6e8f65e92 Creating ami should be idempotent
If the ami already exists, return details of the duplicate
ami instead of failing with an error.
2016-12-08 11:23:04 -05:00
tedder
dd6d5f0cb5 feature pull request: catch and retry recoverable errors
boto can throw SSLError when timeouts occur (among other SSL errors). Catch these so proper JSON can be returned, and also add the ability to retry the operation.

There's an open issue in boto for this: https://github.com/boto/boto/issues/2409

Here's a sample stacktrace that inspired me to work on this. I'm on 1.7, but there's no meaningful differences in the 1.8 release that would affect this. I've added line breaks to the trace for readability.

    failed to parse: Traceback (most recent call last):
      File "/home/ubuntu/.ansible/tmp/ansible-tmp-1419895753.17-160808281985012/s3", line 2031, in <module> main()
      File "/home/ubuntu/.ansible/tmp/ansible-tmp-1419895753.17-160808281985012/s3", line 353, in main download_s3file(module, s3, bucket, obj, dest)
      File "/home/ubuntu/.ansible/tmp/ansible-tmp-1419895753.17-160808281985012/s3", line 234, in download_s3file key.get_contents_to_filename(dest)
      File "/usr/local/lib/python2.7/dist-packages/boto/s3/key.py", line 1665, in get_contents_to_filename response_headers=response_headers)
      File "/usr/local/lib/python2.7/dist-packages/boto/s3/key.py", line 1603, in get_contents_to_file response_headers=response_headers)
      File "/usr/local/lib/python2.7/dist-packages/boto/s3/key.py", line 1435, in get_file query_args=None)
      File "/usr/local/lib/python2.7/dist-packages/boto/s3/key.py", line 1488, in _get_file_internal for bytes in self:
      File "/usr/local/lib/python2.7/dist-packages/boto/s3/key.py", line 368, in next data = self.resp.read(self.BufferSize)
      File "/usr/local/lib/python2.7/dist-packages/boto/connection.py", line 416, in read return httplib.HTTPResponse.read(self, amt)
      File "/usr/lib/python2.7/httplib.py", line 567, in read s = self.fp.read(amt)
      File "/usr/lib/python2.7/socket.py", line 380, in read data = self._sock.recv(left)
      File "/usr/lib/python2.7/ssl.py", line 341, in recv return self.read(buflen)
      File "/usr/lib/python2.7/ssl.py", line 260, in read return self._sslobj.read(len) ssl.SSLError: The read operation timed out
2016-12-08 11:23:04 -05:00
Toshio Kuratomi
fa60891f68 Fix a problem introduced with #1101 and optimize privilege handling
* If a db user belonged to a role which had a privilege, the user would
  not have the privilege added as the role gave the appearance that the
  user already had it.  Fixed to always check the privileges specific to
  the user.
* Make fewer db queries to determine if privileges need to be changed
  and change them (was four for each privilege.  Now two for each object
  that has a set of privileges changed).
2016-12-08 11:23:03 -05:00
Tristan Fisher
75ef963922 removes bool type from validate. 2016-12-08 11:23:03 -05:00
Tristan Fisher
0180be25c4 standardizes bools in argument_spec 2016-12-08 11:23:03 -05:00
jaypei
fbc8d4ca4a use the right way to unescape line string Reference https://github.com/ansible/ansible/issues/10864 2016-12-08 11:23:03 -05:00
Feanil Patel
36dfb78831 Output the Internet Gatewoy id directly instead of in a dict. 2016-12-08 11:23:03 -05:00
Benno Joy
70188fe02a Fixes issue 1197 for s3 module, where the file gets downloaded even if checksums match 2016-12-08 11:23:03 -05:00
Feanil Patel
bfb36f0f1f Tell me what the igw id is if we created an igw. 2016-12-08 11:23:03 -05:00
Toshio Kuratomi
5027fc0642 Expand tildes and vars in the config file path 2016-12-08 11:23:03 -05:00
Brian Coca
d7bd36a215 Revert "Add deprecated documentation for _quantum_subnet" cause it was already added
This reverts commit 3fa32c4984.
2016-12-08 11:23:03 -05:00
Toshio Kuratomi
8576d1f9d1 Add deprecated documentation for _quantum_subnet 2016-12-08 11:23:03 -05:00
Will Thames
34e0e17090 Perform privilege grants/revokes only when required
Use `has_table_privileges` and `has_database_privileges`
to test whether a user already has a privilege before
granting it, or whether a user doesn't have  a privilege
before revoking it.
2016-12-08 11:23:03 -05:00
David Shrewsbury
67d8ff197e Rename os_subnet to os_subnet.py 2016-12-08 11:23:03 -05:00
Monty Taylor
acdc90f31d Add OpenStack Subnet module
Also deprecated old quantum_subnet module
2016-12-08 11:23:03 -05:00
xiaclo
8715ce07ae Fix issue #1156
Fix as suggested in the issue.

https://github.com/ansible/ansible-modules-core/issues/1156
2016-12-08 11:23:03 -05:00
Toshio Kuratomi
4f42e752e6 Allow playbook specified login_user and login_password to override config file settings 2016-12-08 11:23:03 -05:00
James Cammarata
46b60a5b70 Fix missing expanduser on chdir value 2016-12-08 11:23:03 -05:00
James Cammarata
d07378ceac Command module changes for v2 compatibility 2016-12-08 11:23:03 -05:00
Toshio Kuratomi
0af631499a Use a list comprehension instead of map and lambda 2016-12-08 11:23:02 -05:00
Toshio Kuratomi
8976b46888 Import ansible module_utils at bottom of file to not mess with line numbers in tracebacks 2016-12-08 11:23:02 -05:00
Toshio Kuratomi
b6257f73b4 Properly flip default for verifying server cert. Add nice error messages when the cert is invalid 2016-12-08 11:23:02 -05:00
Toshio Kuratomi
a4497a7ddf Change uri module to validate ssl certs by default 2016-12-08 11:23:02 -05:00
whiter
8ee2102993 Doc update to highlight use of body_type parameter 2016-12-08 11:23:02 -05:00
Toshio Kuratomi
c291c2dfea Fix for the new import code when password is empty 2016-12-08 11:23:02 -05:00
Jonathan Mainguy
a3f30540ca add :// url support for EL 5 2016-12-08 11:23:02 -05:00
Dennis Rowe
5109628693 Strip spaces around perms 2016-12-08 11:23:02 -05:00
billwanjohi
a6fd78af37 s3 put: add support for server-side encryption
- added 'encrypt' boolean option
- reordered module options alphanumerically
2016-12-08 11:23:02 -05:00
Toshio Kuratomi
b6a312e489 Minor fixups found during review of #582 2016-12-08 11:23:02 -05:00
Patrik Lundin
899788f1a7 service: Fix comments in OpenBsdService class.
No functional change.
2016-12-08 11:23:02 -05:00
Johann Schmitz
8f8109f1e0 Improved output of mysql_db plugin
Show error number and error description on connect error to ease debugging.
2016-12-08 11:23:02 -05:00
Andrew Pashkin
a960caae96 Add 'docker_api_version' to docker_image
By default docker-py uses latest version of Docker API. This is not
always desireable, and this patch adds option to specify version, that
should be used.
2016-12-08 11:23:02 -05:00
Jonathan Mainguy
7ab2ddbe2a escapeds changes
fixed merge conflict

remove uneeded regexs

arrays
2016-12-08 11:23:02 -05:00
Brian Coca
322518d06c stat doc fix fixes #1371 2016-12-08 11:23:02 -05:00
Robin Miller
a2f685a134 Replaced lambda functions with list comprehensions. 2016-12-08 11:23:02 -05:00
whiter
d252e7c08f Fix for issue #1332 - when instance is has finished deleting and get_db_instance returns None, exit gracefully 2016-12-08 11:23:01 -05:00
Robin Miller
8859a7cf8e Only revoke actually granted permissions, not 'ALL'.
This prevents errors when the login_user does not have 'ALL'
permissions, and the 'priv' value contains fewer permissions than are
held by an existing user. This is particularly an issue when using an
Amazon Web Services RDS instance, as there is no (accessible) user with
'ALL' permissions on *.*.
2016-12-08 11:23:01 -05:00
Brian Coca
7ccc2143fd sleep when only doing a time delay to avoid cpu churn 2016-12-08 11:23:01 -05:00
fdupoux
e34c7f31dc Refactoring to avoid duplication of code which manages the decompression of database dumps in various formats 2016-12-08 11:23:01 -05:00
fdupoux
9b83311471 Simplify code which prepares the decompression command 2016-12-08 11:23:01 -05:00
Toshio Kuratomi
dd4838e4aa Refactor dump compression and use get_bin_path for finding the compressors 2016-12-08 11:23:01 -05:00
fdupoux
aa79810cc8 Decompress mysql dumps on the fly using python subprocess during an import to simplify operation 2016-12-08 11:23:01 -05:00
Wang Qiang
86b6f39cf0 Do instance update after add tags to instance. 2016-12-08 11:23:01 -05:00
Jonathan Mainguy
20301427f8 fixes check mode for Ubuntu 14.04 2016-12-08 11:23:01 -05:00
James Cammarata
3e72a0657d Re-reverting windows modules PR #384 2016-12-08 11:23:01 -05:00
Vladislav Lewin
36ce019beb add SLE12 support to hostname.py 2016-12-08 11:23:01 -05:00
marko
de813195c5 Added support for foreign security groups (Fixes: #373) 2016-12-08 11:23:01 -05:00
Jesse Keating
96b03ce138 Add an openstack servers actions module
This module supports a few of the server actions that are easy to
initially impiment. Other actions require input and provide return
values in the API calls that will be more difficult to impliment, and
thus are not part of this initial commit.
2016-12-08 11:23:01 -05:00
Vasyl Kaigorodov
70235a930b Fix "_is_package_installed() takes exactly 4 arguments, 3 provided" error 2016-12-08 11:23:01 -05:00
Schlueter
b3be960d24 Add 'version_added' to state documentation for easy_install resource 2016-12-08 11:23:01 -05:00
Schlueter
9e8ce34031 Correct reference to gem in easy_install resource 2016-12-08 11:23:01 -05:00
Schlueter
58863d3b48 Add Documentation 2016-12-08 11:23:01 -05:00
Schlueter
1fc687b19d Use standard if statement to check state in easy_install resource 2016-12-08 11:23:00 -05:00
Schlueter
1ddf4c2368 Correct pass by object reference issue 2016-12-08 11:23:00 -05:00
Jonathan Mainguy
b25bc20d3d changes hostname to lowercase 2016-12-08 11:23:00 -05:00
Jonathan Mainguy
ce4c9cccf5 fixes example documenation 2016-12-08 11:23:00 -05:00
Zoltan Kozma
1a6b273a4f - Fixed annoying bug that disablerepo was essentially broken if a package needed updating by state latest. - Replaced some unsafe practice with default parameters. However looking at the code this does not seem to matter much as the calling functions always seem to supply these parameters anyway. 2016-12-08 11:23:00 -05:00
Schlueter
e198884280 Add state to easy_install 2016-12-08 11:23:00 -05:00
Jonathan Mainguy
06cd532cc5 added nice error for systemd hosts where name > 64 chars 2016-12-08 11:23:00 -05:00
Semyon Deviatkin
732b26ab23 Fix issue #1230
When virtual package providing only one package, look up status of target package
2016-12-08 11:23:00 -05:00
Toshio Kuratomi
9eac68b417 Fix problem writing binary content to a temporary file in the uri module.
Fixes https://github.com/ansible/ansible/issues/10938
Fixes https://github.com/ansible/ansible/issues/7606
2016-12-08 11:23:00 -05:00
Monty Taylor
eeacb7486d Add OpenStack Network module
Also, deprecate the old quantum network module
2016-12-08 11:23:00 -05:00
Toshio Kuratomi
84110be91d Update the cron docs to specify that it takes a boolean value 2016-12-08 11:23:00 -05:00
Toshio Kuratomi
623f70ecd6 Fix documentation of the variable that backup file name is returned in 2016-12-08 11:23:00 -05:00
Greg Taylor
79dd0466b5 Adding directory creation example to file module. 2016-12-08 11:23:00 -05:00
Brian Coca
b4775234c9 minor docfix 2016-12-08 11:23:00 -05:00
Brian Coca
831af880f0 minor doc fix and made sure check_implicit_admin is true boolean 2016-12-08 11:23:00 -05:00
Toshio Kuratomi
5c96c5c9c2 Fix splitting of role_attrs 2016-12-08 11:23:00 -05:00
Toshio Kuratomi
7e5a4afb6b Update module "imports" to new style
Fixes #1351
2016-12-08 11:23:00 -05:00
Brian Coca
b13fd5ac9a value should be string as that is what it compares against 2016-12-08 11:22:59 -05:00
Pierre Baillet
eba0f12769 Support optional dockerfile name 2016-12-08 11:22:59 -05:00
Jonathan Mainguy
f4b07b105b added openbsd to hostname module 2016-12-08 11:22:59 -05:00
Toshio Kuratomi
20d7f929be Fix use of codecs.escape_decode() 2016-12-08 11:22:59 -05:00
Toshio Kuratomi
5204e94bda Slightly more future-proof version of the lineinfile fix 2016-12-08 11:22:59 -05:00
Toshio Kuratomi
1002fafedf Correct lineinfile documentation about double quoting... Hasn't been the case for years. 2016-12-08 11:22:59 -05:00
Semyon Deviatkin
e94140e52b Fix unused variable systemd_enabled
Removed declared but unused variable systemd_enabled
2016-12-08 11:22:59 -05:00
Benno Joy
d24fbf5c3e fixe issue #600, where ec2 module returns instance state as runing even after instance is terminated 2016-12-08 11:22:59 -05:00
fdupoux
6f2f07ef51 Add support for xz compression (for dump and import) in mysql_db module 2016-12-08 11:22:59 -05:00
Brian Coca
18e16a16b7 fixed try/except/finally to be 2.4 compatible 2016-12-08 11:22:59 -05:00
whiter
0eb17142b5 Added postgresql-license type 2016-12-08 11:22:59 -05:00
Jason Paige
329266975b update flat description
default behavior is to append the `hostname/path/to/file`, not prepend as currently stated by the flat arg docs
2016-12-08 11:22:59 -05:00