Commit graph

275 commits

Author SHA1 Message Date
Patrick Uiterwijk
414d3611cb nova_compute: indicate argument type (#4070)
Without this, ansible 2.1 will convert some arguments that are
meant to be dict or list type to their str representation.

Signed-off-by: Patrick Uiterwijk <puiterwijk@redhat.com>
2016-07-02 00:06:44 +02:00
Graham Goldstein
4f8f0cf66b Change documented options for os_networks_facts (#3970)
* Change documented options for os_networks_facts

os_network_facts currently lists 'network' as an available option, taking the Name or ID. In Ansible 2.0.2 to 2.2.0, this is not valid. Options 'name' and 'id' should be used instead.

* Update os_networks_facts.py

* Update os_networks_facts.py

Set version_added to the only accepted value

* Update os_networks_facts.py

Removed inappropriate 'ID' parameter
2016-06-22 07:52:00 +02:00
Mario David
ae5ccf29ed add project to os_router (#3869)
* add project to os_router

* version_added fix

* correct place of version_added

* remove extraneous else

* * add shade version dependency check
* option project only on router creation

* * fix shade minimal version
* remove pop of option project

* * fix square brackets
* delete router by router_id
2016-06-20 10:10:59 -04:00
codemeup @ Work
18455b2e72 Fixing open stack compile time errors irt exception handling for Python 3 (#3848) 2016-06-03 06:37:09 -07:00
David Shrewsbury
d952087557 Merge pull request #3732 from GheRivero/devel
Make add ip_floating_ip idempotent
2016-05-31 08:38:45 -04:00
Alvaro Aleman
7f7b9054fd Fix can_update test in os_subnet (#3664) 2016-05-25 08:52:51 +02:00
René Moser
215da19511 Add no_gateway_ip option to os_subnet module (#3736)
no_gateway_ip option can provide subnet that is not having a gateway.
fixes #1880
2016-05-25 08:42:11 +02:00
Ghe Rivero
c5430d0f92 Make add ip_floating_ip idempotent
Closes issue #1858
2016-05-25 00:36:28 +02:00
John R Barker
bb9572ca86 ansible-validate-modules part 4: Enable check on ansible-modules-core (#3526)
* Call ansible-validate-modules

* Correct quotes + add newline
2016-05-03 07:51:12 -07:00
tonyqui
e6fb933c3c Fixing a typo, floating-ips has been used instead of floating_ips (#3540) 2016-04-25 19:09:40 -04:00
Donovan Jones
7c52ea58f1 Make remote_group handle name and id in cloud/openstack/os_security_group_rule.py
* Make remote_group handle name and id

* fix regression breaking os_security_group_rule with no remote_group
2016-04-14 20:03:13 +02:00
David Shrewsbury
25e75e66eb Merge pull request #3236 from rcarrillocruz/network_by_project
Add project parameter to os_network
2016-04-14 10:27:42 -04:00
Ricardo Carrillo Cruz
3e93204598 Add project parameter to os_network
A cloud/domain admin should be able to create a network on any project
it is granted to.
This changes adds the possibility to pass either a project ID or
project name.
2016-04-14 13:20:28 +00:00
David Shrewsbury
cea5ceb644 Merge pull request #3237 from rcarrillocruz/os_subnet_by_project
Create subnet by project
2016-04-13 15:41:17 -04:00
Matt Davis
6d0e9327e3 Merge pull request #3342 from gundalow/docsfix
ansible-validate-modules part 1: Correct documentation
2016-04-12 12:26:27 -07:00
Ricardo Carrillo Cruz
8a03ae5287 Create subnet by domain
A cloud/domain admin should be able to create a subnet on any
project it is granted on.
This change adds the 'project' parameter that accepts either
a name (admin-only) or id.
2016-04-12 17:58:01 +00:00
Rene Moser
85c45d9fd1 openstack: doc fix, add version_added
see #3388
2016-04-10 11:37:53 +02:00
David Shrewsbury
99659036ca Merge pull request #3363 from rcarrillocruz/check_default_project_if_present
Only check default_project on resource creation
2016-04-08 14:21:26 -04:00
Monty Taylor
265c3fdfb5 Merge pull request #3388 from Shrews/os_network_provider
Add support for provider network options
2016-04-08 08:18:17 -07:00
David Shrewsbury
29bd86394e Add support for provider network options.
Adds new parameters for specifying options for provider network plugins.
2016-04-08 09:31:26 -04:00
David Shrewsbury
6970cc233f Wrap calls to main() with if check
A change was merged to the main Ansible core code that can cause

a potential hang if any libraries are called that use threading.

This change was:



  4b0aa1214c



This affected the os_object module by causing a hang on the shade

create_object() API call (which in turn calls swiftclient which

uses threading). The fix is to make sure all modules have a main()

that is wrapped with an "if __name__ == '__main__'" check.
2016-04-06 12:18:35 -07:00
John Barker
531eed80b3 Replace BOOLEANS with true/false 2016-04-05 16:31:15 +01:00
Ricardo Carrillo Cruz
ee2d436aa5 Only check default_project on resource creation
The default_project is checked at the beginning of the module.
This raises an exception if the project passed does not exist.
This logic only makes sense on resource creation, if a user
puts state=absent the module fails, even though the default
project is not relevant
2016-04-04 13:20:00 +00:00
Brian Coca
20e4ad0eef corrected required docs as only boolean is allowed
these complex values were not displayed and would always show the fields as requried
2016-04-01 16:59:12 -04:00
David Shrewsbury
aecec868d5 Pass wait/timeout parameters to floating IP APIs in os_server
If a server already exists when os_server is run, but a floating
IP was not assigned to the server when one was requested, the
module will attempt to add an IP to the existing server. But it
would not pass the wait/timeout params to the floating IP APIs.
If wait was True, you could get back a server dict that did not
show the floating IP because it did not wait.
2016-03-29 13:42:41 -04:00
David Shrewsbury
772d9eb88e Set type on floating_ip_pools in os_server
This has been expected as a list, so let's be explicit about it
so it will work correctly in 2.1 release.
2016-03-29 10:13:49 -04:00
Ricardo Carrillo Cruz
6e6817ce18 Fix is_public type on os_image
Without this fix, the is_public value is a string and the shade
call handling the module does not evaluate correctly when
passing is_public: no
2016-03-29 11:37:49 +00:00
Michael Scherer
74fd65b2d8 s/plubic/public/in the doc 2016-03-26 14:17:26 +01:00
Brian Coca
c10daa5d80 Merge pull request #3302 from rcarrillocruz/allow_domain_name_os_user
Allow passing domain name on os_user
2016-03-23 14:31:40 -07:00
Ricardo Carrillo Cruz
d26f788519 Allow passing domain name on os_server
A cloud admin can search domains, thus it should be possible
to pass a domain name, just like ids.
2016-03-22 17:56:46 +00:00
David Shrewsbury
827fd9acc2 Fix allowed_address_pairs and extra_dhcp_opts in os_port
Commit f71542c set the incorrect type for these two parameters to
dict when they are actually list of dicts.

Also, the extra_dhcp_opts was incorrectly named (without the terminal
's') and NEVER worked, so this was corrected.

Fixes #3301
2016-03-22 08:26:07 -04:00
David Shrewsbury
318cc16c27 Fix size parameter documentation
The generated documentation shows the size parameter as required.
Set 'required' to 'false' and move the explanation to the description.

Fixes #3278
2016-03-21 16:13:29 -04:00
Rene Moser
de7ceacfcd openstack: os_server: add version_added for scheduler_hints
See #3172
2016-03-18 23:45:48 +01:00
Michael Scherer
70a3891b1e Merge pull request #3172 from Comcast/feature/server_scheduler_hints
port 'scheduler_hints' feature from nova_compute to os_server module
2016-03-18 00:06:22 +01:00
Terry Howe
447d1e4b7c Fix openstack module documentation 2016-03-04 09:32:40 -07:00
David Hocky
5fb334e84b add explicit type for scheduler hints 2016-03-03 14:15:04 -05:00
David Hocky
cda0ec85b4 port 'scheduler_hints' feature from nova_compute to os_server module 2016-03-02 12:55:20 -05:00
Brian Coca
b9020155ee Merge pull request #2939 from Shrews/os_server
Fix for os_server module when specifying region
2016-02-29 23:58:24 -05:00
David Shrewsbury
f71542ccf2 Fix parameters where type is assumed.
A change is coming to Ansible where module params will default to str.
Many of our modules were taking advantage of this by not being explicit
about the type, so they will break when that change merges. This hopefully
catches those cases.
2016-02-12 12:30:52 -05:00
Monty Taylor
5f925d061b Add user_data alias for userdata in os_server
The old nova_compute module called the parameter user_data - having an
alias to the old name is friendly.

Fixes Issue #2920
2016-02-09 07:51:08 -06:00
David Shrewsbury
092791dc2c Fix for os_server module when specifying region
Fix the OpenStack os_server module for when region_name is specified.
This should not be passed through to the shade create_server() call
as it's only used with the auth parameters.

Fixes bug: https://github.com/ansible/ansible-modules-core/issues/2797
2016-02-03 09:52:18 -05:00
Brian Coca
a75fa8df05 added missing version_added 2016-01-25 23:43:46 -05:00
Brian Coca
d2c50688de Merge pull request #2814 from Shrews/purge_fip
Add purge option to os_floating_ip module
2016-01-25 23:38:58 -05:00
Brian Coca
5e38b0e0c1 added missing version_Added 2016-01-25 23:42:04 -05:00
Brian Coca
1ebe143618 Merge pull request #2829 from juliakreger/add-os-ironic-node-wait
Add wait support to os_ironic_node
2016-01-25 23:37:07 -05:00
Yair Fried
2692e494e5 Fix glance_client module
Wrong variable name.
2016-01-25 14:49:37 +02:00
Brian Coca
0d1a154fac Merge pull request #2805 from Shrews/fix_os_server_exc
Fix OpenStack module failure output
2016-01-18 20:46:22 -05:00
Julia Kreger
9c7c9e8573 Add wait support to os_ironic_node
Add support for the os_ironic_node module to be capible of waiting
until the baremetal node activation or deactivation has completed.
2016-01-17 17:42:46 -05:00
David Shrewsbury
42ed6124d4 Add purge option to os_floating_ip module
Add the ability to completely delete a floating IP from the pool
when disassociating it from a server. When state is absent and
purge is true, the IP will be completely deleted. The default
keeps the current behavior, which is to only disassociate the IP
from the server.
2016-01-14 13:48:37 -05:00
Brian Coca
fd59dccdd7 Merge pull request #2681 from timrchavez/pass_network_argument
Pass network argument to add_ips_to_server
2016-01-13 17:32:34 -05:00