- now workers passes queue to task_executor so it can send back events per item and on retry attempt
- updated result class to pass along events to strategy
- base strategy updated to forward new events to callback
- callbacks now remove 'items' on final result but process them directly when invoked per item
- new callback method to deal with retry attempt messages (also now obeys nolog)
- updated tests to match new signature of task_executor
fixes#14558fixes#14072
* Fixes bug where the task was not marked as failed if the number of
retries were exceeded (#14461)
* Reorganizing logic to be a bit cleaner, and so retrie messages are
shown before sleeping (which makes way more sense)
Fixes#14461Fixes#14580
Most issues include parts of the advice from the template, which adds noise to tickets.
E.g. A lot of tickets include the text "Please pick one and delete the rest:"
By adding the advice to the user as comments (<!--- comment -->) we achieve two important things:
1. The advice does not end up in the actual issue ticket or pull request
2. It is easier for the user to differentiate its own input and the original advice
(And my help them to clean up the advice as well, which in fact is now no longer necessary)
Prior to 75b6f61, we strictly limited variables we re-injected. After that
patch however, we re-injected everything which causes problems under certain
circumstances. For now, we'll continue to filter out some properties of
PlayContext for re-injection.
Fixes#14352
QA had asked me a while ago to clean up the way the precedence list for 1.x was worded,
as the intro from the list started with "then comes", as if something should preceed
it. The comments from OxABAB were not helpful themselves, but his issue reminded me that
this was on my to do list to make a little cleaner and clearer. Edits made to remove the
"then comes" intros for each list line, to help with clarity.
QA had asked me a while ago to clean up the way the precedence list for 1.x was worded,
as the intro from the list started with "then", as if something should preceed it. The
comments from OxABAB were not helpful, but his issue reminded me that this was on my to
do list to make a little cleaner and clearer. Edits made to remove the "then"
intros for each list line, to help with clarity.
