Commit graph

27961 commits

Author SHA1 Message Date
Xu Yuandong
9182d54e98 ce_config: Optimize multi-level views & fix a bug. (#59523)
* Optimize multi-level views

* update to rewrite load_config.

* update.

* update.

* update.

* update.
2019-07-29 08:54:51 -04:00
Tommy Brecher
4d775cbbf1 ec2_eip - added support for BYOIP and filtering reuse addresses by tag/value (#59180)
* change variable name from isinstance to is_instance (prevent overriding builtin function)

* Added support for:
  - Filtering existing Elastic IPs based on a tag name or it's value (when reuse_existing_ip_allowed is true)
  - Allocating new Elastic IPs from a given IPv4 pool (BYOIP support)

* yamllint corrections

* added examples for:
  -  tag_name,
  -  tag_value
  -  public_ipv4_pool

* remove aliases

* Added changelog fragment

* added integration tests for ec2_eip module

* removed space to trigger rebuild
2019-07-29 19:40:19 +10:00
MyronFanQiu
373e887e7f a bug fix for elastic pool name (#56820) 2019-07-29 17:13:56 +08:00
Abhijeet Kasurde
336be58665 VMware: Fix Service Content calls in vmware_deploy_ovf
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-07-29 11:00:02 +02:00
Martin Krizek
08d7905be2
Remove incorrect usage of UnsafeProxy (#59633)
This removes couple of uses of UnsafeProxy that relies on the
implementation that is no longer present in the codebase.
2019-07-29 09:48:09 +02:00
Xu Yuandong
86937e06e3 ce_file_copy: update to Compatible with multiple version of NETCONF API. (#59450)
* update to Compatible with multiple version of NETCONF API.

* update for  shippable.

* Update ce_file_copy.py

* Update ce_file_copy.py

* Update ce_file_copy.py

* Update ce_file_copy.py

* Update ce_file_copy.py
2019-07-29 02:02:32 -04:00
Tom Moore
a589cac18a Windows: new win_netbios module (#58331)
* Initial commit win_netbios module

* Ansibot sanity improvements.

* Corrected file permissions.

* Windows: module description update

* Adding integration tests

* Added missing alias file

* Improvements made to tests and WMI efficiency.

* Correction from sanity check failures

* Shippable corrections

* Moved reboot flag.

* Slight tweak to return value conditoin
2019-07-29 07:56:53 +10:00
Itai Malek
c24b841c0a fixed _merge_dictionaries calls in GcpSession class (#59375) 2019-07-28 08:00:24 +05:30
Sorin Sbarnea
7c6fb57b7d Implements extra_hosts for docker_image module (#59540)
* Implements etc_hosts for docker_image module

Allows custom hosts on docker_image module.

The of this option made impossible to use docker_image module to build
images that required a custom hostname in /etc/hosts. For running
containers this option was already present.

While the python-docker API uses extra_hosts term, our existing module
already uses etc_hosts argument, so it sounds better to have some
consistency between docker_container and docker_image.

Fixes: #59233

* Update test/integration/targets/docker_image/files/EtcHostsDockerfile

Co-Authored-By: Felix Fontein <felix@fontein.de>

* Update lib/ansible/modules/cloud/docker/docker_image.py

Co-Authored-By: Felix Fontein <felix@fontein.de>

* Update changelogs/fragments/docker_image_etc_hosts.yml

Co-Authored-By: Felix Fontein <felix@fontein.de>
2019-07-26 16:39:21 -04:00
Ihor Borodin
3b5a96fcb7 Fixing race condition in ec2 inventory plugin (#59638)
* Fixing race condition in ec2 inventory plugin

Co-Authored-By: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>

* Fixing code block according to suggestion

* Adding changelog fragment
2019-07-26 13:27:48 -04:00
Sloane Hertel
007fe842b9
aws_ec2 inv plugin - fix author field (#59649)
* Fix author field

* Add BOTMETA entry to get notifications
2019-07-26 12:23:56 -04:00
Xu Yuandong
c3d1f9b085 ce_stp: update to fix a bug. (#59347)
* update to fix a bug.

* update for shippable.

* Update ce_stp.py
2019-07-26 12:09:53 -04:00
Kevin Breit
3cdc667888 New module - meraki_mx_l7_firewall (#55485)
* Initial commit for meraki_mx_l7_firewall module

* Add argument checking

* Sanity fixes

* Fix crash and improve integration tests

* Improved integration tests and coverage

* Reformat response data
- Module does not match argument structure of API
- PR reformats the response to match Ansible arg spec
- Improved integration tests

* Fix reformatting for diffs

* Create rename_* functions
- is_update_required() ignores the key id
- Meraki expects one of the keys to be id
- Function temporarily renames key to appId to get around this

* Tweak documentation and tests
- Tests now do an include so each task doesn't need delegate_to

* Fix which files I'm editing
2019-07-26 11:43:28 -04:00
Kevin Breit
f8f3986871 New module - meraki_nat (#52889)
* Initial commit for meraki_nat module
- Query fully works
- Present is still very much in development

* Add initial code for present functionality, not complete

* Add request documentation

* Add examples and return documentation.

* Added payload to requests
- Module seems to need new idempotency check

* Allow 1:1 and 1:many NAT to work
- New idempotency check method is probably required to work

* Make all three options work
- Module isn't idempotent

* Diff support
- Added integration tests
- Diff support isn't quite done

* Fix diff output

* Enable idempotency assertion in tests

* Add test assertions for code coverage

* Update documentation and tests
- Split tests to separate file to avoid delegate_to

* Fix blank line
2019-07-26 11:42:36 -04:00
Kevin Breit
db783eb2b9 New module - meraki_firewalled_services (#57289)
* Initial commit for module
- Module can query or modify network services on Meraki gear
- Check mode supported
- Integration tests included

* Small change to examples

* Move mutual exclusive to build in approach

* Sanity err

* Split integration tests into two files to avoid delegate_to

* Add the integration tests, woops
2019-07-26 11:39:20 -04:00
Pilou
65013c4001 consul_session: ensure certificate is checked when HTTPS is used (#58693)
* consul_session: ensure SSL certificate is checked

* consul_session: don't ignore validate_certs param
2019-07-26 15:05:38 +02:00
Sachidananda Urs
08b9e18d4f Call remove-brick only if no. of bricks > 0 (#56781) (#58635) 2019-07-26 07:15:11 -04:00
Simon Dodsley
d82446652f Update FlashBlade filesystem module to support quotas and NFS v4.1 (#59559) 2019-07-26 04:06:08 -04:00
Nilashish Chakraborty
3da4c0dd3a
Update argspec to normalize across platforms (#59596)
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
2019-07-26 12:30:26 +05:30
Abhijeet Kasurde
c1ee1f142d
gcp_utils: Handle JSON decode exception (#59427)
Handle json.loads exception rather than providing stacktrace

Fixes: #56269

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-07-26 11:31:07 +05:30
Adam Miller
49da47d09f
force_basic_auth for default httpapi connection auth (#59193)
The default for a httpapi connection is to do basic auth, however
when setting the url_username and url_password without
force_basic_auth, the call to ansible.module_utils.open_url would
not always properly handle the basic auth headers based on the
combinations of **kwargs passed. This ensures that is always the
case when no session token exists and as the goal is to use basic
auth in the event of not having a session token, this should be
a safe operation.

Signed-off-by: Adam Miller <admiller@redhat.com>
2019-07-25 16:40:09 -05:00
Nilashish Chakraborty
3a103405b1
Handle lowercase in version info (#59565)
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
2019-07-25 23:06:53 +05:30
basos g
3c8838f0f7 Add check mode indicators at the beginning and the end of the playbook, play, and task (#49432)
* Add integration tests for default callback check mode markers
2019-07-25 12:05:43 -04:00
Brian Coca
a5d409a8b2
point at corresponding version (#59200) 2019-07-25 11:54:01 -04:00
Dieter De Moitie
9b9066d10f Updated references to removed modules in documentation (#59580) 2019-07-25 11:41:07 -04:00
Andrey Klychkov
db26fe2f1e module_utils.common.*: removed unused objects (#59570) 2019-07-25 11:04:18 -04:00
Sandra McCann
cfe01390aa clarify ansible-galaxy collection cli command options (#59470)
* clarify ansible-galaxy collection cli command options
2019-07-25 09:41:37 -05:00
Gonéri Le Bouder
ef59dd2ca2 vmware_guest_network: fix the network look up
Before this fix, the module was not able to look up a `VM Network` located at
`/DC0/network/VM Network`. As a consequence, the test module was failing
with a real environment (Non-govcsim).
2019-07-25 14:02:52 +02:00
Xu Yuandong
585128e5ac ce_mlag_config: update to fix a bug. (#59336)
* update to fix a bug.

* update

* Update ce_mlag_config.py

* Update ce_mlag_config.py
2019-07-25 07:12:15 -04:00
Brian Coca
e9a37f8e31
prevent templating of passwords from prompt (#59246)
* prevent templating of passwords from prompt

  fixes CVE-2019-10206
2019-07-24 16:00:20 -04:00
Tomáš Pospíšek
4ef38fcee2 remove useless overhead (#59517)
in the examples for the apt module, pass the list directly to the `pkg` option instead of providing it in `vars`
2019-07-24 14:24:53 -05:00
Nilashish Chakraborty
119f2b873a
junos_ping supports only network_cli (#59534)
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
2019-07-24 23:11:27 +05:30
Nilashish Chakraborty
f2b0bfd4aa
Add iosxr_lacp resource module (#59281)
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
2019-07-24 22:55:42 +05:30
Sandeep Bandi
1d82d25ea2 Adding Avi ansible lookup module (#58667)
* Adding Avi ansible lookup module

(cherry picked from commit 77b8951f68cbc889e6595b2a359ca27b84a43c0d)

* Added description for examples

* Added debug logs and unit tests

* Fix __builtin__ import and restting super

* Fix pep8 errors

* Updated as per review comments on IP address
2019-07-24 11:35:04 -04:00
Andrey Klychkov
e9725862ca mysql.py: remove unused import (#59511) 2019-07-24 10:36:18 -04:00
Strahinja Kustudic
5fc769f6b1 sysctl - Reload also when current system values differ (#56153)
Previously if `sysctl_set=no` (which is the default) this module only
checked for changes in the sysctl.conf file to decide whether it should
reload it or not. This means that if the values in the conf file are the
same as they are set with the module, but the current values on the
system are different, that this module wouldn't apply the changes on the
system and thus the value set with the module wouldn't be applied on the
OS. This isn't obvious and it doesn't make sense that the module works
like that by default, especially because there is a separate option
`reload`. Now sysctl will also check if the current value differs on the
system and if it does, it will reload the file again.
2019-07-24 10:04:15 -04:00
Abhijeet Kasurde
401e70c0a2
VMware: add facts about tags in vmware_cluster_facts (#56848)
Fixes: #46458

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-07-24 15:45:15 +05:30
Andrey Klychkov
fd35833554 postgresql modules: fix by flake8 (#59497) 2019-07-24 15:40:44 +05:30
Xu Yuandong
93265bf92e ce_mtu: update to fix bugs. (#59343)
* update to fix bug.

* Update ce_mtu.py

* Update ce_mtu.py

* Update ce_mtu.py
2019-07-24 05:53:08 -04:00
Abhijeet Kasurde
281307b492
VMware: make properties configurable (#53050)
This allows user to control set of properties which can be included
in the hostvars.

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-07-24 15:18:32 +05:30
Martin Krizek
1010363c0b
Preserve original variables when using a loop (#59426)
Fixes #59414
2019-07-24 11:35:14 +02:00
Jill Rouleau
5a7f579d86 Fix clouds_yaml_path type in openstack inventory
Fixes: 59442
2019-07-24 10:25:44 +02:00
Xu Yuandong
6ff54c546e update to fix a bug (#59346) 2019-07-24 04:09:53 -04:00
Abhijeet Kasurde
bafd06bc89
VMware: Fix custom value in vmware_guest (#58157)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-07-24 10:54:16 +05:30
Jordan Borean
ba7097cba3
Collection test (#59488)
* Add missing __init__.py for collection unit tests

* Added more tests for collection install and remove default path
2019-07-24 12:38:32 +10:00
Abhijeet Kasurde
d9b9e07d0b
VMware: Add datatypes in documentation (#59221)
* Remove E337 warnings
* Update docs
* Fix minor typos

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-07-24 07:55:55 +05:30
Jordan Borean
3581e63ca8
psexec - update example for for delegation example (#59475) 2019-07-24 10:12:34 +10:00
Chaz Ruhl
aebc3b0730 Update cobbler_system.py (#59316)
State was not referenced appropriately in doc examples.
2019-07-23 15:13:07 -05:00
Nathan Swartz
6a77533b57 Specify type-str for common NetApp E-Series documention options. (#59459) 2019-07-23 14:38:11 -05:00
Shachaf92
092e5515d1 win_firewall_rule - update doc for localport dep. on protocol (#59467) 2019-07-23 14:37:08 -05:00