Commit graph

11817 commits

Author SHA1 Message Date
Will Thames
92f9b74a68 Restrict ansible-pull to only do scm checkout once
This addresses a bug in ansible-pull where running ansible-pull
with an existing inventory causes the ansible job that does
the SCM checkout to run twice - once for localhost and once
for the fully qualified hostname.

This can cause a race condition, and usually results in one
of the ansible checkouts failing because one of the scm checkouts
has its references updated underneath it. Although the SCM checkout
actually succeeds, ansible fails with non-zero exit status, and
so ansible-pull does not continue.

Now that localhost is implicit for ansible runs, the ansible
scm checkout can be done using just localhost as a target.
2014-08-20 14:28:53 +10:00
Michael DeHaan
e6be619257 Merge pull request #8678 from 0x44/debconf-vtypes
debconf module: add the missing 'error' vtype and reorder vtypes as they...
2014-08-19 17:57:53 -04:00
Michael DeHaan
231fc84cce Merge pull request #8671 from nathansoz/patch-2
$powershellpath is called as ".$powershellpath"
2014-08-19 15:44:52 -04:00
Michael DeHaan
f2adee9fc9 Merge pull request #8665 from cchurch/winrm_timeout
WinRM test for long-running command.
2014-08-19 15:43:00 -04:00
James Cammarata
d4ff0d125a Make sure password files from lookups are created with restrictive permissions
Also adds checks for the lookup integration test for passwords.

Fixes #8652
2014-08-19 11:30:04 -05:00
James Cammarata
3a7aca6066 Fix no_log value for content in common file args settings
Also adds a test to ensure the content value is not logged.

Related to #8647
2014-08-19 10:47:18 -05:00
James Cammarata
8a5675ca9f Fixing no_log for the playbook level use
Fixes #8647
2014-08-19 10:35:01 -05:00
James Cammarata
8648fa175c Removing skipped=True from result when using creates= and removes=
Fixes #8645
2014-08-19 09:09:13 -05:00
James Cammarata
ca6db40cb4 When serializing inventory, pop from the start of the hosts list
Fixes #8646
2014-08-19 09:04:47 -05:00
Michael DeHaan
47f4dec676 In order to allow easier updates from upstream hardware vendors, we're going to be hosting network hardware
config modules on Galaxy as announced during the last release cycle.   (This excludes load balancers, which remain in core).

Please refer to https://eos.arista.com/introducing-arista-eos-roles-for-ansible/ and https://galaxy.ansible.com/list#/roles/1359
and where this content now lives.

Thanks to Peter Sprygada for the roles content!
2014-08-19 08:31:49 -04:00
Ding Deng
13db184d7f debconf module: add the missing 'error' vtype and reorder vtypes as they appeared in debconf-devel(7). 2014-08-19 17:44:02 +08:00
James Cammarata
c8494cdc39 Set prompt encoding to a sane value when sys.stdout.encoding is None
Fixes #8644
2014-08-18 22:04:25 -05:00
nathansoz
f0004b1604 $powershellpath is called as ".$powershellpath"
$powershell path is set to "C:\powershell" at line 27. This is fine, but on line 82 $powershellpath is called as ".$powershellpath\$filename". Because the path at line 27 is absolute, a period preceding the $powershellpath is not required at 82. It actually causes an error:

Start-Process : This command cannot be executed due to the error: Unknown error (0x80041002).
At C:\users\Nathan Sosnovske\Documents\ps2to3.ps1:81 char:14

Start-Process <<<< -FilePath ".$powershellpath\$filename" -ArgumentList /quiet
CategoryInfo : InvalidOperation: (:) [Start-Process], InvalidOperationException
FullyQualifiedErrorId : InvalidOperationException,Microsoft.PowerShell.Commands.StartProcessCommand
Removing the period on line 82 before $powershellpath fixes this error.
2014-08-18 15:55:24 -07:00
James Cammarata
379e31883c Fix check mode issues with copy module
Fixes #8639
2014-08-18 16:02:45 -05:00
James Cammarata
542f07128e Correct check for role library/ existence
Fixes #8633
2014-08-18 13:33:23 -05:00
James Cammarata
e2b8f05b79 Add option to disable ControlPath to ssh options during rsync
Fixes #8473
2014-08-18 12:59:00 -05:00
James Cammarata
e3895840d1 Make sure group_vars/all is loaded for ungrouped hosts
Fixes #6563
2014-08-18 12:29:46 -05:00
James Cammarata
92f7aa79b0 Fix bad commit from #8095 and fix bad splitting on :'s in the image
Fixes #8095
Fixes #8658
2014-08-18 10:37:07 -05:00
Chris Church
90fc6c6881 Added winrm test for long-running command. 2014-08-18 07:49:42 -04:00
Michael DeHaan
f4d649bea0 Merge pull request #8641 from ianmiell/imiell_docs
Tense correction
2014-08-16 10:45:10 -04:00
Ian Miell
340a3c68b1 Tense correction 2014-08-15 19:56:11 +01:00
Michael DeHaan
91560c00a9 Merge pull request #8627 from rghe/devel
fixes #8626 by reverting 0d8b81cd
2014-08-15 13:42:11 -04:00
James Cammarata
8dafacd4e9 Make env param a dict type instead of list
Also modifies param type checking code to remove whitespace from
around params before splitting them into k=v pairs.

Fixes #8199
2014-08-15 11:04:27 -05:00
Michael DeHaan
a230a3fad9 Merge pull request #8635 from RockinRoel/devel
Fix fonts in docs: Incosolata -> Inconsolata
2014-08-15 07:49:52 -04:00
Michael DeHaan
3035f2dcc8 Merge pull request #8367 from msabramo/make_pip_install_editable_work
Make `pip install -e` work
2014-08-15 07:46:54 -04:00
Roel Standaert
f3e951aa95 Fix fonts in docs: Incosolata -> Inconsolata 2014-08-15 10:21:41 +02:00
James Cammarata
54cbe3dcf9 Disallow args: to be specified as a string 2014-08-14 16:05:20 -05:00
James Cammarata
600a4657b4 Catch error in atomic_move when creating temporary file
Fixes #8480
2014-08-14 13:26:24 -05:00
James Cammarata
ee18c557ec Load group_vars for new groups loaded via add_host
Fixes #8605
2014-08-14 13:18:26 -05:00
James Cammarata
b4476c238f Use match() instead of search() for pattern matching
Also related to f48fa3, fix for #8614
2014-08-14 12:26:52 -05:00
James Cammarata
f48fa3759a Fix host pattern matching and enhance error detection
Fixes #8614
2014-08-14 12:13:40 -05:00
rghe
9b6df6d9a8 fixes #8626 by reverting 0d8b81cd 2014-08-14 18:10:58 +02:00
James Cammarata
a01d97f12b Fixing variable name bug introduced in ac8950f
Fixes #8617
2014-08-14 10:55:26 -05:00
James Cammarata
bea0845322 Fix vault_password positional args error 2014-08-14 10:28:08 -05:00
Michael DeHaan
448c0a950e Merge pull request #8622 from ciupicri/typo
Fix typo: & -> and
2014-08-14 10:55:16 -04:00
Michael DeHaan
9e0090e21b Merge pull request #8612 from mjaschen-forks/devel
Homebrew module: Added `+` and `.` characters to the package name regex.
2014-08-14 10:52:25 -04:00
Michael DeHaan
1faa7ec50a Merge pull request #8589 from huckphin/huckphin-fixSpellingWindows
Fix some spelling mistakes in intro_windows.rst
2014-08-14 10:42:08 -04:00
Michael DeHaan
773df2cc8a Merge pull request #8587 from ericwb/bug/8299
Update keystone_user doc for tenant_description
2014-08-14 10:41:45 -04:00
Cristian Ciupitu
b6261d05b0 Fix typo: & -> and
`and` is the boolean operator for AND in [Python][1].
`&` is the bitwise operator for AND in [Python][2].

[1]: https://docs.python.org/2/reference/expressions.html#boolean-operations
[2]: https://docs.python.org/2/reference/expressions.html#binary-bitwise-operations
2014-08-14 16:52:59 +03:00
Marcus Jaschen
c6ac95d403 Homebrew module: Added + and . characters to the package name regex.
Solves installation failures for packages like `bonnie++` or
`virtualhost.sh` as described in #8413.
2014-08-13 22:31:03 +02:00
Chad Rhyner
1c01c0c390 Fix some spelling mistakes in intro_windows.rst 2014-08-12 22:10:11 -07:00
Eric Brown
8e6c219ee9 Update keystone_user doc for tenant_description
The description var should be tenant_description.

Closes-bug: #8299
2014-08-12 16:49:33 -07:00
Michael DeHaan
9edf3a749a Merge pull request #8580 from mpeters/ec2_inv_empty_patterns
Handle the case where include_pattern and exclude_pattern exist but are empty strings
2014-08-12 18:25:52 -04:00
Michael Peters
8b1d6f5e75 fixing "else" typo 2014-08-12 15:48:14 -04:00
Michael Peters
7194fe1064 need to handle the case where include_pattern and exclude_pattern exist in the config file but contain empty strings 2014-08-12 15:40:15 -04:00
Michael DeHaan
ab6e1a43e9 Merge pull request #8579 from hahla/devel
Fix issue #8578. Setting envvar in ""'s ensures the PYTHONPATH is set to
2014-08-12 15:23:03 -04:00
Michael Salmon
e827ec702e Fix issue #8578. Setting envvar in ""'s ensures the PYTHONPATH is set to
include the lib/ directory.

Before - PYTHONPATH is empty.. ansible fails to run

    $ source hacking/env-setup.fish
    Appending PYTHONPATH

    Setting up Ansible to run out of checkout...

    PATH=/Volumes/opt/src/ansible/bin /usr/local/share/python3 /usr/local/bin
    /usr/bin /bin /usr/sbin /sbin /usr/local/bin /opt/X11/bin /usr/bin /sbin
    /usr/local/bin /Users/ms/bin/
    PYTHONPATH=
    ANSIBLE_LIBRARY=/Volumes/opt/src/ansible/library
    ...

    Traceback (most recent call last):
      File "/Volumes/opt/src/ansible/bin/ansible", line 25, in <module>
          from ansible.runner import Runner
          ImportError: No module named ansible.runner

After change - it's set.. ansible runs.

    source hacking/env-setup.fish
    Appending PYTHONPATH

    Setting up Ansible to run out of checkout...

    PATH=/Volumes/opt/src/ansible/bin /usr/local/share/python3 /usr/local/bin
    /usr/bin /bin /usr/sbin /sbin /usr/local/bin /opt/X11/bin /usr/bin /sbin
    /usr/local/bin /Users/ms/bin/
    PYTHONPATH=/Volumes/opt/src/ansible/lib:
    ANSIBLE_LIBRARY=/Volumes/opt/src/ansible/library
    ....

    $ ansible
    Usage: ansible <host-pattern> [options]
2014-08-12 12:09:20 -07:00
Michael DeHaan
d1344ec85d Merge pull request #8560 from sivel/ansible-vault-use-script
ansible-vault should support script for --vault-password-file too
2014-08-12 13:49:14 -04:00
Michael DeHaan
99c39b1ff3 By popular request, make the no_log attribute also censor tasks from callbacks. 2014-08-12 13:36:05 -04:00
James Cammarata
a04efa2d84 Update docs for copy directory_mode param per #8572 2014-08-12 12:19:13 -05:00