Commit graph

10139 commits

Author SHA1 Message Date
Michael Scherer
2ae3dbcc6a Set the locales to avoid issue with screenscrapping
See https://github.com/ansible/ansible-modules-core/pull/2462 for

details on why this could happen
2016-12-08 11:24:16 -05:00
Thomas Quinot
a5ec00f89f Reset all locale environment variables before running svn commands
We screenscrape the output of svn(1), so better ensure it is using the

C locale.

Fixes #3255
2016-12-08 11:24:16 -05:00
Kalle Lehtonen
02f737cdee Fix and add more error handling for role policies
In case role policy was deleted, we did not handle at all if there

was authorization issue to do the deletion. Also add message when

role is not found and the policy is skipped.
2016-12-08 11:24:16 -05:00
Peter Sprygada
8210ede9b4 refactor iosxr_template module to remove old diff functions
this replaces the old diff functions with the netcfg shared module for
handling configuration diffs between running and candidate
2016-12-08 11:24:16 -05:00
Peter Sprygada
bba38d2cf8 refactor iosxr_config module to remove old diff functions
this replaces the old diff functions with the netcfg lib for handling
configuration diffs between running and candidate configurations
2016-12-08 11:24:16 -05:00
Peter Sprygada
c2c8d51ba2 cleanup iosxr_command module to be consistent with other network modules
this cleans up some of the function calls and output keys to be consistent
with other command modules
2016-12-08 11:24:15 -05:00
Ricardo Carrillo Cruz
1b5288b703 Only check default_project on resource creation
The default_project is checked at the beginning of the module.
This raises an exception if the project passed does not exist.
This logic only makes sense on resource creation, if a user
puts state=absent the module fails, even though the default
project is not relevant
2016-12-08 11:24:15 -05:00
Peter Sprygada
834bc225c9 refactors nxos_template and removes diff functions
replaces the diff functions with the netcfg shared module for handling
configuration diff
2016-12-08 11:24:15 -05:00
Peter Sprygada
5a61909b4a refactors nxos_config and removes diff functions
this refactors the nxos_config module removing the diff functions and
replacing with the netcfg shared module
2016-12-08 11:24:15 -05:00
Peter Sprygada
19119a2759 cleans up nxos_command and adds some additonal info on exception
This cleans up some of the nxos_command module code function names to
be more consistent and adds additional information of failures
2016-12-08 11:24:15 -05:00
Peter Sprygada
a4bb4ee146 refactors eos_template to remove diff functions
replaces functions with netcfg shared library for handling configuration
diffs
2016-12-08 11:24:15 -05:00
Peter Sprygada
f77bb0ac28 refactors eos_config to remove config diff functions
replaces with netcfg shared library for handling configuration diffs
2016-12-08 11:24:15 -05:00
Peter Sprygada
006c11cf34 refactors the ios_template module to use netcfg diff
removes the functions for performing configuration diffs to use the
netcfg shared lib
2016-12-08 11:24:15 -05:00
Peter Sprygada
ff928d0829 refactor ios_config to use netcfg diff shared lib
Move the configuration diff code from the module to the shared lib
2016-12-08 11:24:15 -05:00
Toshio Kuratomi
708d49777d Allow async to not need an args file since new-style modules have args embedded 2016-12-08 11:24:15 -05:00
Brian Coca
ff755da1e5 fixed doc quoting 2016-12-08 11:24:15 -05:00
Brian Coca
37513ca8bb corrected required docs as only boolean is allowed
these complex values were not displayed and would always show the fields as requried
2016-12-08 11:24:15 -05:00
David Shrewsbury
1bdc3b3bb0 Pass wait/timeout parameters to floating IP APIs in os_server
If a server already exists when os_server is run, but a floating
IP was not assigned to the server when one was requested, the
module will attempt to add an IP to the existing server. But it
would not pass the wait/timeout params to the floating IP APIs.
If wait was True, you could get back a server dict that did not
show the floating IP because it did not wait.
2016-12-08 11:24:15 -05:00
David Shrewsbury
82a1208e64 Set type on floating_ip_pools in os_server
This has been expected as a list, so let's be explicit about it
so it will work correctly in 2.1 release.
2016-12-08 11:24:15 -05:00
Ricardo Carrillo Cruz
5d402f31c8 Fix is_public type on os_image
Without this fix, the is_public value is a string and the shade
call handling the module does not evaluate correctly when
passing is_public: no
2016-12-08 11:24:15 -05:00
Jan Hutar
45076bddb9 Add missing parameters so these options are usable 2016-12-08 11:24:15 -05:00
Michael Scherer
65243dfb91 Fix type of the rhn_register module
Password and activationkey should be tagged as no_log, as they
are supposed to be secret.
sslcacert is a path, so should be tagged as such.
2016-12-08 11:24:15 -05:00
Christian Aistleitner
51e3c6c49b Guard against too old boto library
route53 creates Record objects using `health check` and `failover`
parameters. Those parameters only became available in boto 2.28.0.
As some prominent LTS Linux releases (e.g.: Ubuntu 14.04) only ship
older boto versions (e.g.: 2.20.1 for Ubuntu 14.04), users are getting
unhelpful error messages like

  TypeError: __init__() got an unexpected keyword argument 'health_check'

when running Ansible 2 against their LTS install's default boto.
We improve upon this error message by checking the boto version
beforehand.

Fixes ansible/ansible#13646
2016-12-08 11:24:14 -05:00
Arnaud Lachaume
50622b4e6a fix aws elasticache idempotency 2016-12-08 11:24:14 -05:00
David Shrewsbury
4b97cd3a42 Add support for provider network options.
Adds new parameters for specifying options for provider network plugins.
2016-12-08 11:24:14 -05:00
whiter
dadf835a06 Remove access_key and secret_key as these are provided by aws doc fragment Remove ec2 doc fragment as region is not required for IAM 2016-12-08 11:24:14 -05:00
Bence Nagy
0fd89cfd44 Add prefixing and suffixing fuctionality to assemble 2016-12-08 11:24:14 -05:00
Hugh Saunders
92ebeffd6c Retry apt cache updates 2016-12-08 11:24:14 -05:00
Michael Scherer
3d415ac2da Use type='path' for path arguments for git module 2016-12-08 11:24:14 -05:00
Michael Scherer
55bbe191e5 s/plubic/public/in the doc 2016-12-08 11:24:14 -05:00
nitzmahone
eb3243c15a fix win_stat get_checksum alias issue
made it impossible to prevent gathering checksum without setting both get_md5 and get_checksum false
2016-12-08 11:24:14 -05:00
Toshio Kuratomi
6fae6c7b2d Give headers a default so that we can add to it. 2016-12-08 11:24:14 -05:00
Ash Wilson
6e2f724919 Remove myself from the docker module maintainers
Apologies, but I no longer use this module day-to-day myself, and I don't have the bandwidth right now to effectively triage changes in any kind of timely fashion.
2016-12-08 11:24:14 -05:00
Strahinja Kustudić
db45268b75 Yum module always downloads remote rpms. fixes #1452 2016-12-08 11:24:14 -05:00
Michael Scherer
daddfb490b Improve/fix type checking for docker module
tls_* point to files, so should be type=path
count is a int, so tag it as such and avoid converting later
password should be tagged as no_log
2016-12-08 11:24:14 -05:00
Ashwanth Kumar
7c5b4b142a Doing exponential backoff on route53 upon AWS throttling 2016-12-08 11:24:14 -05:00
Victor Beresnev
2e94affde6 If cmd and entrypoint not set, don't match them
Hello!
I wanted stop the containers matched only by image name, but can't do this, if I not set cmd in playbook.
This behavior confused me.

If cmd or entrypoint is defined for running container, but not defined in playbook, makes matching behavior as this sample:
https://github.com/ansible/ansible-modules-core/blob/devel/cloud/docker/docker.py#L463
2016-12-08 11:24:14 -05:00
curious-eyes
5b88ad45ef Add preemptible option on gce.py 2016-12-08 11:24:14 -05:00
Rene Moser
775521e5cb apt: doc: fix missing version_added
see #2023
2016-12-08 11:24:13 -05:00
Dag Wieers
084c597f45 Update the issue and pull-request templates in sync with ansible/ansible 2016-12-08 11:24:13 -05:00
Chris Lamb
c012358d57 os/apt.py: Add support for passing --allow-unauthenticated
This is useful for packages that bootstrap their own apt-key setup - only
the initial installation will require overriding. Notable examples are the
Dropbox and Google Chrome packages.

(Setting force=yes is far too strong: I only want to bypass
authentication!)

Signed-off-by: Chris Lamb <chris@chris-lamb.co.uk>
2016-12-08 11:24:13 -05:00
David Shrewsbury
285ab7656f Fix allowed_address_pairs and extra_dhcp_opts in os_port
Commit f71542c set the incorrect type for these two parameters to
dict when they are actually list of dicts.

Also, the extra_dhcp_opts was incorrectly named (without the terminal
's') and NEVER worked, so this was corrected.

Fixes #3301
2016-12-08 11:24:13 -05:00
Ricardo Carrillo Cruz
344a559b61 Allow passing domain name on os_server
A cloud admin can search domains, thus it should be possible
to pass a domain name, just like ids.
2016-12-08 11:24:13 -05:00
David Shrewsbury
b750b926d3 Fix size parameter documentation
The generated documentation shows the size parameter as required.
Set 'required' to 'false' and move the explanation to the description.

Fixes #3278
2016-12-08 11:24:13 -05:00
Brian Coca
d035961d1c added version added 2016-12-08 11:24:13 -05:00
Peter Sprygada
11cd361d80 fixes #3274 2016-12-08 11:24:13 -05:00
Toshio Kuratomi
4c9f9973dd If file attribs are specified set them even if file already exists.
Fixes #11821
2016-12-08 11:24:13 -05:00
Yannig Perré
72d3aab736 Add an example of extra_hosts option. 2016-12-08 11:24:13 -05:00
Rene Moser
facf61366e openstack: os_server: add version_added for scheduler_hints
See #3172
2016-12-08 11:24:13 -05:00
Ted Timmons
8c6741b2bb fix typo in documentation
let's -> lets
2016-12-08 11:24:13 -05:00
Toshio Kuratomi
b70d691832 Fix indent in documentation 2016-12-08 11:24:13 -05:00
jhawkesworth@users.noreply.github.com
63f8bdf782 Use HEAD request to determine if file should be downloaded, ensure download method is the same regardless of force mode. 2016-12-08 11:24:13 -05:00
Raphaël Dubigny
71c50aed24 typo in pip module 2016-12-08 11:24:13 -05:00
Roland Sommer
0c1cf5ee1c honour 'only_upgrade' flag for 'build_dep' case in 'apt' module 2016-12-08 11:24:13 -05:00
Taras Lipatov
b5fb47e28e Fixed typo json_fail to fail_json 2016-12-08 11:24:13 -05:00
Fabian Fülling
eaa7e717a2 Fixes #2039 Convert None to 0 when checking if ELB cookie expiration has changed 2016-12-08 11:24:12 -05:00
toshihisa
7fee8a78c9 One more bug yum non English locales
d7fac82f97
2016-12-08 11:24:12 -05:00
Toshio Kuratomi
4c40886814 Remove the ignore_ohai and ignore_facter parameters as the functionality was merged into gather_subset 2016-12-08 11:24:12 -05:00
Jonathan Davila
f24c3fb40e Clarified IAM module doc 2016-12-08 11:24:12 -05:00
Tobias Wolf
368cf59e4b Add diff and check mode to cron module
supports not writing backup file in check mode and new environment
vars.

![example screenshot](http://i.imgur.com/mkAThq8.png)
2016-12-08 11:24:12 -05:00
Geoff Wright
7b93cd7db2 Fixes: #3232. Use of datetime consistent with module_utils/basic.py 2016-12-08 11:24:12 -05:00
Yannig Perré
02abe0b7c9 Use list type in order to convert directly gather_subset option into list. 2016-12-08 11:24:12 -05:00
Matt Clay
b7a5e1e0c8 Add optional connect timeout to mysql* modules. 2016-12-08 11:24:12 -05:00
Yannig Perré
12804a80b6 Add a way to restrict gathered facts in Ansible: - Using gather_subset options - By ignoring ohai/chef or facter/puppet facts 2016-12-08 11:24:12 -05:00
Peter Sprygada
e01dd7facc update to nxos_command with additional exception handling
This update adds exception handling to catch errors when trying to parse
command output to json.  It also removes the dependency on importing json
opting to use the AnsibleModule methods instead
2016-12-08 11:24:12 -05:00
Peter Sprygada
ae9930f59f doc string fixes for eos_config
This updates eos_config with some fixes to the documentation string
2016-12-08 11:24:12 -05:00
Peter Sprygada
ed2d46bc9e bugfix in eos_template for backing up config
eos_template would connect to the remote device to get the running config
for backup even if backup is not needed.
2016-12-08 11:24:12 -05:00
Peter Sprygada
12bb95b943 minor function clean ups in eos_command
This commit cleans up a couple of functions and removes the json
import to use the json methods from AnsibleModule
2016-12-08 11:24:12 -05:00
jrk07
ca86923eb7 Doc Update: ios_template.py title and example
ios_template.py was named ios_config when viewing docs.  The examples also had net_config still.  Updated those here.
2016-12-08 11:24:12 -05:00
David Hocky
d6e32b8245 add explicit type for scheduler hints 2016-12-08 11:24:12 -05:00
David Hocky
3b800f1f34 port 'scheduler_hints' feature from nova_compute to os_server module 2016-12-08 11:24:11 -05:00
Joao Carreira
92d76e8828 added support for sles 10 & 11 2016-12-08 11:24:11 -05:00
Peter Sprygada
1fd5989b9d initial add of ops_command module
This commit adds a new module, ops_command, that handles executing commands
on OpenSwitch over the CLI.  Since this module is designed to work with the
OpenSwitch CLI, it only supports the CLI transport option
2016-12-08 11:24:11 -05:00
Peter Sprygada
9488617d19 initial add of ops_config module
This commit adds a new module, ops_config, that allows playbook designers
to create tasks for configuring OpenSwitch over the CLI.  The module
is designed to work directly with configuration mode in OpenSwitch and
therefore only supports the CLI transport option
2016-12-08 11:24:11 -05:00
Neil Saunders
83039b93f0 Fix for issue #3109: Executing ec2_group with rules fails with "Invalid rule parameter '['" 2016-12-08 11:24:11 -05:00
Kenny Gryp
69b07aaf9d added sql_log_bin setting to disable binary logging as option 2016-12-08 11:24:11 -05:00
Nate Brown
b891b0c9bc ELB Proxy Protocol support for backends 2016-12-08 11:24:11 -05:00
Joel
e3de705d0c Allow us to sort by all available datatypes 2016-12-08 11:24:11 -05:00
Roland Sommer
c96d5245f5 add 'only_upgrade' switch to apt module 2016-12-08 11:24:11 -05:00
Peter Sprygada
ba41260ae0 bugfix for ios_config module
This commit address a bug in the ios_config module when using the
match: strict argument.  When the argument is used, the module will
compare the configuration block same as match: exact which is not the
intended behavior.  This commit updates the behavior to propertly handle
the strict argument.
2016-12-08 11:24:11 -05:00
Peter Sprygada
761724f5c3 bugfix for handling match=strict in eos_config
Resolves an issue where match=strict would act like match=exact when
evaluating the configuration
2016-12-08 11:24:11 -05:00
Peter Sprygada
7cd3793128 bugfix for handling match=strict in iosxr_config
Resolves an issue where match=strict would act like match=exact when
evaluating the configuration
2016-12-08 11:24:11 -05:00
Peter Sprygada
b0a9308e0d bugfix for handling match=strict in nxos_config
Resolves an issue where match=strict would act like match=exact when
evaluating the configuration
2016-12-08 11:24:11 -05:00
Brian Coca
90650256ef fixed exit json 2016-12-08 11:24:11 -05:00
Matt Martz
e4a88eeebe Fix synchronize docs to indicate the correct default for use_ssh_args 2016-12-08 11:24:11 -05:00
Brian Coca
9e0aef8ea2 docs updates and fixes
fixes http://github.com/ansible/ansible/issues/14876
2016-12-08 11:24:11 -05:00
Schlueter
734811910e Add missing quote in docker documentation 2016-12-08 11:24:11 -05:00
Brian Coca
9084e31979 fixes to assemble
now uses atomic move to avoid data corruption
correclty cleans up temp files in every case
returns backup_file info if needed
validate validate before temp file gets created
backup AFTER validate
2016-12-08 11:24:10 -05:00
Matt Martz
ad9c487391 Set version_added to 2.1 for autoremove. Fixes #3200 2016-12-08 11:24:10 -05:00
Dag Wieers
20b7757032 Ensure that a download failure is properly raised before the read fails
Without this change, a download failure may bail out with the message:

    "Failure downloading http://foo/bar, 'NoneType' object has no attribute 'read'"

whereas with this fix, you'd get a proper error like:

    "Failure downloading http://foo/bar, Request failed: <urlopen error [Errno 113] No route to host>"

or one of the many other possible download errors that can occur.
2016-12-08 11:24:10 -05:00
Matt Martz
b4bab770f6 pip module should call exit_json for absent as well (indentation error) 2016-12-08 11:24:10 -05:00
Matt Martz
fe22ee9423 Don't pass follow_redirects to fetch_url, use module.params instead 2016-12-08 11:24:10 -05:00
Brian Coca
b61d531dfc corrected typo on aws connection arguments var 2016-12-08 11:24:10 -05:00
Terry Howe
a06b07221d Fix openstack module documentation 2016-12-08 11:24:10 -05:00
Tobias Wolf
3a00d2bb38 Add diff support to apt_repository module
The returned list of diffs aims to simulate how a file system diff would
look before and after writing the sources list files.

![screenshot](http://i.imgur.com/dH6QXtY.png)

n.b. Ternary conditional  is due to failing integration test for
python 2.4
2016-12-08 11:24:10 -05:00
Constantin07
33079b2b7f Treat 'is_public' option as a bool 2016-12-08 11:24:10 -05:00
Andrey Gubarev
edde3b49cf update docker_image's path param type to 'path'. Fixes #3175 2016-12-08 11:24:10 -05:00
moyashiki
96ce498b77 Fix ios_command fix
This is not valid YAML commands. So fix it.
2016-12-08 11:24:10 -05:00
Sam Wilson
0bd95d0f2d Fixed BOOLEANS rendering in docsite 2016-12-08 11:24:10 -05:00
Peter Sprygada
1f4625938e refactor arguments in ops_template
This commit refactors the arugments used in ops_template to be strictly
typed and handle by declarative / rest and cli based configurations.  It
also removes old arguments not supported and cleans up the documentation
strings
2016-12-08 11:24:10 -05:00
curious-eyes
e16367739e Fix #2761: gce.py - UnboundLocalError: local variable 'md' 2016-12-08 11:24:10 -05:00
davidobrien1
072c68ea79 Restore filter on Windows and version reference for Windows facts. 2016-12-08 11:24:10 -05:00
davidobrien1
a874e1e25e Change fact invocation from dotsourcing to ampersand so that scripts do not execute in global scope. 2016-12-08 11:24:10 -05:00
Stefano Mazzucco
04e9677ae0 'executable' and 'virtualenv' mutually exclusive
fixes https://github.com/ansible/ansible/issues/14415
2016-12-08 11:24:09 -05:00
Tom Bamford
1cace51ed6 Bugfix: Permit SOA record type 2016-12-08 11:24:09 -05:00
Gary Rybak
5ff79d0596 Add filter to eos_template to remove configuration mode command followed immediately by an exit command indented one level. 2016-12-08 11:24:09 -05:00
callipeo
4331fcae34 Add support for both keyserver and keyring in apt_key
Fixes Issue #2996
2016-12-08 11:24:09 -05:00
David O'Brien
ce7a86b4ce Add documentation to setup.py and remove use of $params.fact_path in setup.ps1 2016-12-08 11:24:09 -05:00
Ryan-Neal Mes
2fa3f16012 Indented code so it only executes tag comparison for matching cird values 2016-12-08 11:24:09 -05:00
Tobias Gesellchen
db14b544a5 add env_file support (original code from @vpetersson) 2016-12-08 11:24:09 -05:00
Matt Clay
53b0fd65ee Split shell command to avoid use_unsafe_shell.
This mirrors a nearly identical change made to apt_repository.py.

Also removes the use of apt-get --force-yes as it can be dangerous
and should not be necessary (apt_repository.py does not use it).

Repeating the explanation from the apt_respository change below:

Since use_unsafe_shell is suspicious from a security point
of view (or it wouldn't be unsafe), the less we have, the less
code we have to thoroughly inspect for a security audit.

In this case, the '&&' can be replaced by doing 2 calls to run_command.
2016-12-08 11:24:09 -05:00
Tobias Wolf
75e8b365b4 Add supports_check_mode=True to mysql_db module
The most important cases are state=present and state=absent.

Future work: import and dump could be simulated and hence checked.
2016-12-08 11:24:09 -05:00
Kanwei Li
a2a3d2fc06 Add new Dv2 Azure instances 2016-12-08 11:24:09 -05:00
Bert Van Vreckem
4a10eeb196 Also show stdout when validation fails. This fixes #2498 2016-12-08 11:24:09 -05:00
Jonathan Mainguy
44bde46097 Add ability to download deb from url
if :// in deb, will try to download from url.
2016-12-08 11:24:09 -05:00
nitzmahone
3abdfb1712 mark failed async_status as finished
Running async_status in an "until: result.finished" loop will mask a module failure (eg, traceback) with a
template failure, because the fail dict doesn't include "finished" (eg, you'll see "ERROR! The conditional check 'bogus_out.finished' failed. The error was: ERROR! error while evaluating conditional: bogus_out.finished ({% if bogus_out.finished %} True {% else %} False {% endif %}"). Because the failure dict still includes "failed: true",
this change has no effect on stoppage/failure reporting, it just prevents the common usage pattern from masking the underlying error message.
2016-12-08 11:24:09 -05:00
Will Thames
52accd7d1f Use connect_to_aws where possible
`connect_to_aws` fixes a bug with security tokens in AWS.
Modules should use that rather than calling
`boto.x.connect_to_region`
2016-12-08 11:24:09 -05:00
Tim Alkemade
be19982313 GCE module does not fetch disk images if not necessary 2016-12-08 11:24:09 -05:00
Matt Martz
b85d3f32da Add get_checksum option to win_stat to work with new use of the stat module for checksumming 2016-12-08 11:24:08 -05:00
Toshio Kuratomi
9551e51607 At least for now, set body to raw as it can be either a dict or jsonified-str
Since our validation does conversion as well as validation, I'm not sure
this is entirely correct.  May need to take a look at our conversion
code and re-examine to be sure we're doing it right.
2016-12-08 11:24:08 -05:00
Toshio Kuratomi
0400efa3f8 Change parameter to type=path
Read as binary for python3 preparedness
2016-12-08 11:24:08 -05:00
Toshio Kuratomi
390dbe5090 Change one param to be of type path 2016-12-08 11:24:08 -05:00
Toshio Kuratomi
8b711c1c77 change a parameter to type=path 2016-12-08 11:24:08 -05:00
Toshio Kuratomi
ecafdeeaa5 Set some module parameters to type=path 2016-12-08 11:24:08 -05:00
Toshio Kuratomi
cea1125d02 Correct dest_port to be of type int 2016-12-08 11:24:08 -05:00
Toshio Kuratomi
646d0e406d Set one parameter to be type path 2016-12-08 11:24:08 -05:00
Toshio Kuratomi
249b9511a5 Set name to type path so that tilde and env vars are expanded 2016-12-08 11:24:08 -05:00
Toshio Kuratomi
47e9a06784 Specify types in argument_spec instead of code so that checking type vs default value does not trigger 2016-12-08 11:24:08 -05:00
Michael Scherer
776d079e6b Fix non RFC 2606 domain name in doc 2016-12-08 11:24:08 -05:00
Jonathan Davila
7f338e13ff Updated ec2_lc docs 2016-12-08 11:24:08 -05:00
Peter Sprygada
24fc4dbeab fixes issue with return docstring
This commit fixes an issue with the return doc string.  The old line
was removed that would prevent the docs form being built correctly
2016-12-08 11:24:08 -05:00
Leonardo Giordani
344c976141 Added some documentation for the shell return values 2016-12-08 11:24:08 -05:00
Brian Coca
a148dbe5b4 updated with html comments to avoid posting hints
also simplified form, had too much from issue template
2016-12-08 11:24:08 -05:00
Brian Coca
f7597f916c added html comments so hints are not posted
also added verbostiy instruction
2016-12-08 11:24:08 -05:00
Constantin07
3dde5196aa Added explicit type for 'tags' option 2016-12-08 11:24:08 -05:00
Matt Martz
fada638d88 Indicate in notes that the dependency on httplib2 was removed for v2.1 2016-12-08 11:24:07 -05:00
Brian Coca
7a804fd17c tolerate environment not being set
default will be the same as before, None/null
2016-12-08 11:24:07 -05:00
Constantin07
94345349a6 Fixing issue #3057 - AttributeError: 'str' object has no attribute 'items' 2016-12-08 11:24:07 -05:00
Pete Travis
b504625f72 quote fail 2016-12-08 11:24:07 -05:00
Pete Travis
f6efa9aaa5 expand when opening too 2016-12-08 11:24:07 -05:00
Pete Travis
57703450f5 use expanduser() before testing user_data as file
I like to use ~/somepath instead of absolute paths because
that's more shareable.  Without expansion, the path wasn't
considered a file, and the resulting cloud-config user_data
contained a string for the file path instead of the file context.
So, expand it.
2016-12-08 11:24:07 -05:00
Konstantin Suvorov
762bd3a801 Fix docker container restart
restart_containers(containers.running) may try to restart containers
that are deleted when looping through get_differing_containers()
fix this by refreshing list after first loop
2016-12-08 11:24:07 -05:00
Daan Oosterveld
6b4fbe62de Adds ulimit to the docker module
The ulimit will be specified as a list and separated by colons. The
hard limit is optional, in which case it is equal to the soft limit.

The ulimits are compared to the ulimits of the container and added
or adjusted accordingly on by a reload.

The module ensures that ulimits are available in the capabilities
iff ulimits is passes as a parameter.
2016-12-08 11:24:07 -05:00
Scott Brown
ba2bc1dbfe Fixing missing interpolation variable 2016-12-08 11:24:07 -05:00
Matt Martz
a18206355a Drop dependency on httplib2 in the uri module, instead using ansible.module_utils.urls 2016-12-08 11:24:07 -05:00
Brian Coca
a546775172 fixed typo, now correctly check isdir
fixes #3089
2016-12-08 11:24:07 -05:00
Brian Coca
69b0e39220 added missing checksum alias 2016-12-08 11:24:07 -05:00
Peter Sprygada
0b49f956ce minor bugfixes for junos_config return values
The junos_config now properly returns updates and reponses
2016-12-08 11:24:07 -05:00
Brian Coca
ab6242bace fixed rax_cdb argument spec
now we pull the actual arguments and added aliases to be nice
fixes #3075
2016-12-08 11:24:07 -05:00
Ton Kersten
b58e16ed3d Fix facter path
In Puppet 4 and in the PE edition, the Puppet tree is installed in
`/opt/puppetlabs/...` and all commands can be reached from
`/opt/puppetlabs/bin`.
2016-12-08 11:24:07 -05:00
Daniel Petty
f26199d962 replaced sudo with become 2016-12-08 11:24:06 -05:00
Brian Coca
bd54067287 point to local issue temmplate 2016-12-08 11:24:06 -05:00
Brian Coca
c2a3b16155 initial add of issue/pr templates 2016-12-08 11:24:06 -05:00
Brian Coca
453d267489 documented new verbosity option 2016-12-08 11:24:06 -05:00
Peter Sprygada
025bc70acd initial add of ops_template module
This adds a new module ops_template used for configuring OpenSwitch
using local declarative config modules
2016-12-08 11:24:06 -05:00
Peter Sprygada
0f7279b967 bugfix for missing function name in ios_command
This provides a minor bugfix for a missing function name in the ios_command
network module
2016-12-08 11:24:06 -05:00
Matt Martz
aaf762573e Various simple linting type cleanups on modules 2016-12-08 11:24:06 -05:00
Brian Coca
4ec0ccd5ac fixed option name mismatch, added aliases
also removed empty aliases
2016-12-08 11:24:06 -05:00
Brian Coca
b357f4dd72 added follow to specific modules that support it
was removed from common file docs
2016-12-08 11:24:06 -05:00
Jose Moreira
cc173b445e Fixed module doc typos 2016-12-08 11:24:06 -05:00
Brian Coca
bbfb957bc1 recursive copy is not available(yet) on remote_src 2016-12-08 11:24:06 -05:00
Guruprasad
1b642fcf75 Fix typo in the copy module error message
Fix the typos in the error message shown on trying to use remote_src=yes for copying directories
2016-12-08 11:24:06 -05:00
Brian Coca
23c07ccf2c cleaner error on recursive remote copy
TODO: add recursive copy support when remote_src=yes
probably need to make shared the logic in the action plugin.
2016-12-08 11:24:06 -05:00
Peter Sprygada
06e3899860 initial add of iosxr_config module
This adds a new module, iosxr_config, that can be used for configuring
Cisco IOS XR devices.  It is provides a set of arguments for sending
configuration commands to the device over cli
2016-12-08 11:24:06 -05:00
Peter Sprygada
5725472cc6 initial add of iosxr_template module
This adds a new module, iosxr_template, that can be used to template
configurations for IOS XR devices.  Templates are then loaded into the
target device over cli
2016-12-08 11:24:06 -05:00
Peter Sprygada
671184adc4 initial add of iosxr_command module
This adds a new module, iosxr_command, that can be used to issue
commands to devices running IOS XR.  Commands are run on the
target device over cli
2016-12-08 11:24:06 -05:00
Peter Sprygada
4f4bc9ed5c update junos_command module return values
This minor update fixes the return values from the junos_command module
to be consistent with other network modules
2016-12-08 11:24:06 -05:00
Peter Sprygada
13793d7b95 update ios_command module return values
This minor change updates the return values and doc string for the
ios_command module to be consistent with other network modules
2016-12-08 11:24:05 -05:00
jjshoe
a160d5426d List which version it was added
fixes https://github.com/ansible/ansible-modules-core/issues/2605
2016-12-08 11:24:05 -05:00
Brian Coca
8d0d251003 removed 'overquoting' of example
fixes #3029
2016-12-08 11:24:05 -05:00
David Shrewsbury
d7568a50e2 Fix parameters where type is assumed.
A change is coming to Ansible where module params will default to str.
Many of our modules were taking advantage of this by not being explicit
about the type, so they will break when that change merges. This hopefully
catches those cases.
2016-12-08 11:24:05 -05:00
Peter Sprygada
ca9be1d62c add init to network/cumulus and reset module attrs
The modules were merged in without an __init__.py.  This adds the module
iniit and resets all of the module attrs to 0644
2016-12-08 11:24:05 -05:00
Toshio Kuratomi
50eda6c62e password needs to be type str.
In 1.9 this was the default.  In 2.0.0 and 2.0.1 this doesn't get set.
2.1.0 will fix the default but we should fix this now.
2016-12-08 11:24:05 -05:00
Peter Sprygada
c98ba21f45 add package init to junos/ 2016-12-08 11:24:05 -05:00
Brian Coca
5b07831a11 fixes for uri module
- clarify docs on body_json behaviour
- only tranform into json if body input is not a string
  users keep passing json string and expecint it to not be jsonified again
- fixed issue with removes not handling path expansion correctly
- switched all path variables to 'type path' to handle expansions
2016-12-08 11:24:05 -05:00
Jason Kohles
bc834ff564 Enable env vars for vsphere_guest
This commit allows the connection information for
the vsphere_guest module to be provided as environment
variables, which makes it possible to use Cloud
Credentials from Ansible Tower in playbooks that utilize
vsphere_guest.

| ENV VAR         | vsphere_guest param    |
| --------------- | ---------------------- |
| VMWARE_HOST     | vcenter_hostname       |
| VMWARE_USER     | username               |
| VMWARE_PASSWORD | password               |
2016-12-08 11:24:05 -05:00
Mike Caspar
ea8097a821 Documentation updates to use complete YAML : syntax instead of key=val syntax. Adjusted example to use "" where appropriate to pass YAML Syntax checker per Contribution guidelines.
See Issue [# 2879](https://github.com/ansible/ansible-modules-core/issues/2879)
2016-12-08 11:24:05 -05:00
Peter Sprygada
0310363a22 initial add of junos_config module
This adds a new module, junos_config, useed to configure Juniper JUNOS based
devices.  The config module can be used to set an ordered set of set and
delete statements over a cli transport
2016-12-08 11:24:05 -05:00
chouseknecht
a5fe046f90 Add ios_commnand module. 2016-12-08 11:24:05 -05:00
chouseknecht
be2a50547e Moved Conditional class to netcfg. 2016-12-08 11:24:05 -05:00
Peter Sprygada
ab210862f0 initial add of junos_template
This adds a new module, junos_template, that can read in a template
config and push the changes to the device.  It can also backup the
current config.  This module is implemented over cli
2016-12-08 11:24:05 -05:00
Peter Sprygada
fb7d5e798c initial add of junos_command module
This adds a new module, junos_command that can be used for sending commands
to Juniper JUNOS based devices.   The junos_command module is implemented
over a cli transport
2016-12-08 11:24:05 -05:00
Brian Coca
2ed38b79cb expanded info on fail on check + missing apt-python
it now explains that apt module will auto install
2016-12-08 11:24:05 -05:00
Luca Berruti
feb309e3cf Typo. 2016-12-08 11:24:04 -05:00
David Shrewsbury
66c83fc788 Fix for os_server module when specifying region
Fix the OpenStack os_server module for when region_name is specified.
This should not be passed through to the shade create_server() call
as it's only used with the auth parameters.

Fixes bug: https://github.com/ansible/ansible-modules-core/issues/2797
2016-12-08 11:24:04 -05:00
Matt Clay
4288150270 Do not install python-apt in check mode. 2016-12-08 11:24:04 -05:00
Brian Coca
b5c9945485 avoid chmod in check mode 2016-12-08 11:24:04 -05:00
Peter Sprygada
8303eadff1 update eos_config doc string and return values
This change update the return values from eos_config to be consistent with
all network config modules.  This will now return updates and responses
from the module
2016-12-08 11:24:04 -05:00
Peter Sprygada
eb5f9c216b update eos_template doc string and return values
This updates the return values form eos_template to be consistent
across all template modules.  This change now returns updates and
respones
2016-12-08 11:24:04 -05:00
Peter Sprygada
279ca048ae update eos_command doc strings and return values
This change updates the returns values from eos_command to be consistent
with network modules. It now returns stdout, stdout_lines and failed_conditionals
2016-12-08 11:24:04 -05:00
Peter Sprygada
79b50f5cf8 update nxos_config doc strings and return values
This commit unifys the return values for the nxos_config module to always
return updates and responses
2016-12-08 11:24:04 -05:00
Peter Sprygada
4873e8ab12 update nxos_template doc strings and return values
This updates the nxos_template doc string to unify the return values
across all network modules.  This change now returns stdout, stdout_lines
and failed_conditionals
2016-12-08 11:24:04 -05:00
Peter Sprygada
00d3e33dbf update nxos_command doc strings and return values
This modifies the return values to make them consistent across all
network command modules.  The module now returns stdout, stdout_lines
and failed_conditionals
2016-12-08 11:24:04 -05:00
Peter Sprygada
25d724a88d update ios_template doc strings and return values
Sets the return values from ios_template to be consistent with the rest
of the network modules.  Return values are now updates and responses
2016-12-08 11:24:04 -05:00
Peter Sprygada
d33b840ec6 update ios_config doc strings and return values
This changes the return values to be consistent across all network
config modules. The return values are now updates and responses
2016-12-08 11:24:04 -05:00
Brian Coca
5aff573098 revamped checkmode support in user module
- defaulted to commands not executing in checkmode
- added force run for info gathering (for setting changed)
- added debug for what would have been run in check mode
- added check mode for spots that made changes using system calls instead of command
- removed now redundant checkmode checks

better failure now, if i missed anything, it will misreport changed value
instead of old default of actually making the change in checkmode
2016-12-08 11:24:04 -05:00
Monty Taylor
6aaee42604 Add user_data alias for userdata in os_server
The old nova_compute module called the parameter user_data - having an
alias to the old name is friendly.

Fixes Issue #2920
2016-12-08 11:24:04 -05:00
jjshoe
56f1d6f794 Less engrish 2016-12-08 11:24:04 -05:00
Michael Baydoun
7234ead259 Update ec2.py
Documentation is not clear that tag used in count_tags must be an existing instance_tag
2016-12-08 11:24:04 -05:00
Brian Coca
f1d2c71f83 corrected description key spelling 2016-12-08 11:24:04 -05:00