Commit graph

27837 commits

Author SHA1 Message Date
Klaus Frank
fbdf6e59f2 Fix ansible-vault cipher_whitelist (#57272)
* Fix ansible-vault cipher_whitelist Fixes: #57271

* Add changelog for #57272
2019-06-22 11:14:37 -04:00
Wojciech Wypior
de03c007bc BIGIP: fixes issue with image installation on multiblade platforms (#58176)
* fixes issue with image installation on multiblade platforms

* test
2019-06-21 17:12:30 -07:00
Wojciech Wypior
30ada17d4f Adds message routing transport module (#58201) 2019-06-21 12:58:02 -07:00
Wojciech Wypior
b8fd2f4df3 adds generic routing peer module (#58189) 2019-06-21 12:56:25 -07:00
Wojciech Wypior
429bf5340e adds module for message routing protocol (#58188) 2019-06-21 12:56:03 -07:00
Wojciech Wypior
0a3a94a493 adds new module to manage firewall schedules (#58187) 2019-06-21 12:55:50 -07:00
Wojciech Wypior
92a1e6845c Adds two modules to manage AFM log profiles (#58186) 2019-06-21 12:55:37 -07:00
Sam Doran
bd55617a5b
hostname - Correct distribution for various Linux distros based on output from distro library (#56936)
* Adjust hostname classes based on output from distro

Corrects the following:
- OpenSUSE Leap
- ArchARM
- Oracle Linux

* Add CoreOS and Clear Linux distributions
2019-06-21 14:29:41 -04:00
MyronFanQiu
1539e0e855 a doc fix for azure_rm_virtualmachinescaleset (#56448) 2019-06-21 12:12:26 -04:00
Wojciech Wypior
fbca93b8ad removes args from the code and corrects few missed tests (#58175) 2019-06-21 09:09:39 -07:00
Wojciech Wypior
56b3b1ac56 adds message routing router module (#58191) 2019-06-21 09:09:14 -07:00
Wojciech Wypior
c1f2df4753 adds message routing route module (#58190) 2019-06-21 09:08:56 -07:00
Derrick Johnson
b86c7759c5 Update Documentation mso_schema_template_bd.py (#58020)
* Update mso_schema_template_bd.py
2019-06-21 12:04:38 -04:00
Fred-sun
1b7ef47776 Update azure_rm_securitygroup related document (#58035)
* Update azure_rm_securitygroup related document
2019-06-21 12:00:18 -04:00
Fred-sun
1c49a9110a Update azure_rm_servicebus related document (#58105)
* Update azure_rm_servicebus related document
2019-06-21 11:59:07 -04:00
Fred-sun
7e70184f10 Update azure_rm_servicebusqueue related document (#58160)
* Update azure_rm_servicebus related document
2019-06-21 11:55:09 -04:00
Fred-sun
af000444d2 Update azure_rm_sqldatabase related document (#58163) 2019-06-21 11:53:51 -04:00
akatch
200eed6177 Implement display_ok_hosts and display_skipped_hosts for unixy (#53179)
* Implement display_ok_hosts and display_skipped_hosts like default callback

* Implement show_custom_stats and display_failed_stderr like default callback

* Fix pep8

* Clarify conditional

* Changelog fragment

* Import from defaults.py per feedback
2019-06-21 11:22:16 -04:00
Wojciech Wypior
95e59e7ee7 adds description to bigip snatpool (#58179) 2019-06-21 07:52:46 -07:00
Wojciech Wypior
655ad7456d adds multiple new parameters to bigip_profile_http (#58183) 2019-06-21 07:16:47 -07:00
Wojciech Wypior
022b5d8b79 adds support for IPV4 addressing for interfaces (#58182) 2019-06-21 07:16:31 -07:00
Wojciech Wypior
66c828d45f adds new parameters to tcp profile module (#58185)
minor fix in policy module
2019-06-21 07:07:48 -07:00
Wojciech Wypior
07fc880b3c minor fixes in two modules (#58178) 2019-06-21 07:07:17 -07:00
Wojciech Wypior
3531bf3148 fixes issue with ssl protocols ordering (#58177) 2019-06-21 06:46:53 -07:00
Wojciech Wypior
cee3d539cb Fixes issue with failure messages (#58173) 2019-06-21 06:45:57 -07:00
Wojciech Wypior
becca36c5e Added new module for remote user management (#58171) 2019-06-21 06:45:29 -07:00
Tobias
e7c39460ed ipaddr: Handle ipaddress index in network correctly (#57896)
This commit prevents integer indices from being parsed as ip nets

Fixes #57895

Signed-off-by: Tobias Schramm <tobleminer@gmail.com>
2019-06-21 15:26:08 +02:00
Kevin Breit
0f12e1c7d8 Meraki - Improve type information in module documentation (#58114)
* Improve type information in module documentation
- Removed some duplicate documentation
- Ensure org_id is always string
- Add type information for items which don't have it

* Fix whitespace
2019-06-21 09:25:03 -04:00
Sumit Jaiswal
58d446e61a
PR to fix where ansible_net_model was not being populated (#58159)
* fix bug 57285

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* minor fix

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* adding TC fix related

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* fix shippable error

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
2019-06-21 16:18:59 +05:30
markafarrell
43872d6b88 Fix netconf guess_network_os to use ssh_config if supplied. (#55199)
* feature: use network_os=auto to trigger network os guessing

* doc: add debug messages

* fix linting

* fix test_netconf_init default network_os is auto

* add documentation

* fix rst errors

* use init lexer

* Update docs/docsite/rst/network/user_guide/platform_netconf_enabled.rst

Co-Authored-By: Sandra McCann <samccann@redhat.com>

* Update docs/docsite/rst/network/user_guide/platform_netconf_enabled.rst

Co-Authored-By: Sandra McCann <samccann@redhat.com>

* Update docs/docsite/rst/network/user_guide/platform_netconf_enabled.rst

Co-Authored-By: Sandra McCann <samccann@redhat.com>

* Update docs/docsite/rst/network/user_guide/platform_netconf_enabled.rst

Co-Authored-By: Sandra McCann <samccann@redhat.com>

* Update docs/docsite/rst/network/user_guide/platform_netconf_enabled.rst

Co-Authored-By: Sandra McCann <samccann@redhat.com>

* Update docs/docsite/rst/network/user_guide/platform_netconf_enabled.rst

Co-Authored-By: Sandra McCann <samccann@redhat.com>

* Update docs/docsite/rst/network/user_guide/platform_netconf_enabled.rst

Co-Authored-By: Sandra McCann <samccann@redhat.com>

* Update lib/ansible/plugins/connection/netconf.py

Co-Authored-By: Sandra McCann <samccann@redhat.com>

* Update lib/ansible/plugins/connection/netconf.py

Co-Authored-By: Sandra McCann <samccann@redhat.com>

* Update lib/ansible/plugins/connection/netconf.py

Co-Authored-By: Sandra McCann <samccann@redhat.com>

* Update docs/docsite/rst/network/user_guide/platform_netconf_enabled.rst

Co-Authored-By: Sandra McCann <samccann@redhat.com>

* Update docs/docsite/rst/network/user_guide/platform_netconf_enabled.rst

Co-Authored-By: Sandra McCann <samccann@redhat.com>

* Update docs/docsite/rst/network/user_guide/platform_netconf_enabled.rst

Co-Authored-By: Sandra McCann <samccann@redhat.com>
2019-06-21 09:04:13 +05:30
Ganesh Nalawade
f864f621d8
Fix junos module transport check (#58050)
*  Since new junos resource modules will
   support only network_cli connection type
   modify the transport check from network_cli
   connection netconf as netconf only supported modules
   is a fronzen set.
2019-06-21 08:56:52 +05:30
The Magician
28b67d809f Bug fixes for GCP modules (#58107) 2019-06-20 20:51:43 -04:00
Kohei Asano
ddf6d096c5 Support the new TLS termination on NLBs (#51327) (#58031) 2019-06-20 17:03:04 -07:00
Felix Fontein
f8f2738351 docker_*: make modules more robust on Docker errors (#57913)
* Improve general error behavior if a Docker error is not caught.

* Don't die when network doesn't exist.

* Add changelog.

* Make API version always available. Also catch errors when retrieving version.

* Fix error message.

* Adjust fallback error messages.
2019-06-20 16:59:15 -04:00
Dmitriy Yakovlev
122d4164c5 docker_swarm_service: Added default value for mounts.source (#58039)
* Added default value for mounts.source

* Added the changelog fragment

* Added tests

* Fixed separators

* Moved the teardown section at the end
2019-06-20 15:58:32 -04:00
Felix Fontein
4188cd299b crypto modules: Improve requirements / error messages (#57868)
* Reformat requirements.

* Include Python lib versions in lib required error messages, if available.

* Update lib/ansible/modules/crypto/openssl_publickey.py

Co-Authored-By: MarkusTeufelberger <mteufelberger@mgit.at>

* Add changelog.
2019-06-20 21:31:00 +02:00
Alberto Murillo
320d05dc30 tower_workflow_template: Add missing options (#56891)
The following options can be set on a workflow template but the
functionallity to do so from this module was missing.

inventory
ask_variables_on_launch
ask_inventory_on_launch

Fixes #49728

Signed-off-by: Alberto Murillo <albertomurillosilva@gmail.com>
2019-06-20 13:55:37 -04:00
Stefan Prietl
9dbc838d99 Add rudimentary wait for os_zone (#54391)
This adds a rudimentary wait functionality for the os_zone module.

It will wait for:
* Zone not in OpenStack API when choosing `absent`
* Zone `status` being `AVAILABLE` in OpenStack when choosing `present`
2019-06-20 13:00:57 -04:00
panticz
d0ee6e1e54 Implement protected parameter (#54114)
* Implement protected parameter

* version_added field

* Remove point at at the end of the sentence

* Update version_added to 2.9
2019-06-20 12:47:18 -04:00
A Codeweavers Infrastructure Bod
2f70c90efd Update apt.py (#56479)
* Update apt.py

Tested under Debian 9 with installation of Apache2 and PostgreSQL
In both cases the daemons are started immediately upon installation

https://www.alextomkins.com/2018/03/runlevel-apt-get-install-package-alternative/
https://major.io/2014/06/26/install-debian-packages-without-starting-daemons/
2019-06-20 12:10:28 -04:00
Josef 'veloc1ty' Stautner
bdb089b910 Update sysctl.py (#57984)
##### SUMMARY
Quote values to mitigate this ansible warning:

+label: docsite_pr
2019-06-20 11:46:25 -04:00
Tom Moore
67e02b5eee Corrected module example in documentation (#58124) 2019-06-20 11:37:05 -04:00
pratikgadiya12
2b5ad94a96 vmware_guest_disk_facts: return controller_bus_number and controller_type (#58117)
Fixes: #57608
Fixes: #57998
2019-06-20 20:07:17 +05:30
Matt Martz
ffd117132f
Create new instance of the action plugin per until iteration. Fixes #57886 (#58022) 2019-06-20 09:17:50 -05:00
Matt Martz
375ac76e58
ssh: Ensure debug messages are properly converted to text (#57850)
* ssh: Ensure debug messages are properly converted to text. Fixes #57843

* surrogate_then_replace is default, be less explicit

* We only needed to_text for display, not exceptions
2019-06-20 09:15:53 -05:00
smile37773
3a3465c47d Add the way to create a VM with the image id (#58106) 2019-06-20 16:42:09 +08:00
Cameron Nemo
cc7bea2100 plugins/connection/netconf: remove unimplemented option (#58104)
closes #51972
2019-06-20 12:07:10 +05:30
Yurii Vlasenko
8c1c2afd02 docker_container: Change expected config source (#57969)
* Change expected config source

* make it conditional

* rename property

* Add changelog fragment

* make it string

* Update changelogs/fragments/57969-docker_container-change-expected-config-source.yml

Co-Authored-By: Felix Fontein <felix@fontein.de>
2019-06-19 23:32:59 +02:00
The Magician
8b6c6cf302 Bug fixes for GCP modules (#58041) 2019-06-19 14:20:43 -04:00
Jeya
bdd0bbf50a [nxos] New parameter vrf in nxos_file_copy (#57851)
* [nxos] New parameter vrf in nxos_file_copy

* Fix version_added

* Fix documentation default value
2019-06-19 21:26:07 +05:30
Chris Van Heuveln
52c811c841 nxos_bgp_neighbor: Add bfd support (#56932)
* nxos_bgp_neighbor: Add bfd support

- Add support for bfd state in nxos_bgp_neighbor

- Feature Pull Request

- nxos_bgp_neighbor

- Tested on platforms: `N3K,N6K,N7K,N9K`

* bfd T/F now bfd enable/disable

* pep fix ws
2019-06-19 21:23:00 +05:30
Chris Van Heuveln
727a6b405a nxos_ospf_vrf: Add 'bfd' support (#57425)
* nxos_ospf_vrf: Add 'bfd' support

* Add default to bfd doc hdr

* bfd T/F now bfd enable/disable
2019-06-19 21:22:32 +05:30
Chris Van Heuveln
30830a4482 nxos_pim: Add bfd support (#56908)
* nxos_pim: Add bfd support

* Add integration sanity

* minor cleanup

* bfd T/F now bfd enable/disable
2019-06-19 21:22:03 +05:30
Mike Wiebe
12d656901f Add CmdRef logic to handle multiples (#57495)
* Add CmdRef logic to handle multiples

* Fix python 2.6 issues

* Fix bug when existing is not a dict object

* Fix python2 vs python3 incompatibilty

* Ignore unnecessary-lambda warning
2019-06-19 21:15:32 +05:30
Kevin Breit
8f68c8d438 meraki_snmp - Enable check mode (#54625)
* Add support for check mode

* Add diff support

* Remove check mode for idempotent action
2019-06-19 11:35:10 -04:00
Fred-sun
8cff96e388 Update azure_rm_roledefinition related document (#57927)
* Update azure_rm_roledefinition related documentation
2019-06-19 09:27:30 -05:00
Nathaniel Case
f656959861
Fix RESTCONF media types (#58015)
Fixes #56680
2019-06-19 10:22:24 -04:00
Andrey Klychkov
64d0559e9f Postgres module_utils: add get_connect_params + unit tests (#58067)
* add get_conn_params

* add get_conn_params: add to the modules
2019-06-19 06:49:19 -07:00
René Moser
6bace8aa54
vultr: vultr_account_facts -> info (#57563) 2019-06-19 14:10:55 +02:00
Zim Kalinowski
ee32222ae7 fixing vmss failure (#56625)
* triggering test

* deleting autocreated as last one

* fixed mistake
2019-06-19 05:00:43 -04:00
MyronFanQiu
ec95086b69 add support for https (#57785) 2019-06-19 15:14:53 +08:00
endurancetest20380119
3d452fb917 Update azure_rm_aks.py (#57898) 2019-06-19 15:13:16 +08:00
Martin Nečas
c609fad106 Ovirt vnic profile fix (#57936)
* ovirt vnic profile fix init

* ovirt vnic profile fix init

* update syntax whitespace

* document pass_through

* create get entity method

* update example syntax

* update docs

* change force_create style
2019-06-18 21:46:41 -04:00
Rob
feae35ab7e add IAM role assumption to aws_ec2 inventory (#41637)
* add IAM role assumption to aws_ec2 inventory
* Ensure inventory._options has necessary option keys populated since the plugin docs parser isn't accessible to unit tests yet
2019-06-18 15:34:41 -07:00
Dusan Matejka
8646b6953d updated zabbix modules to use missing_required_lib helper (#58002) 2019-06-18 16:57:09 -04:00
Andrey Klychkov
186210af8a postgresql modules: remove unused imports, remove blank lines after docstrings 2019-06-18 12:55:32 -07:00
The Magician
a1128b6b94 Bug fixes for GCP modules (#58016) 2019-06-18 15:45:47 -04:00
Martin Nečas
b4d4f77963 Ovirt add managed storage domain (#57995)
* init managed storage domain

* add version added

* add no log for sensitive options

* add driver default types

* update docs

* update pep8 syntax

* update example syntax

* update example syntax

* set default domain_fucntion for managed_block_storage

* correct pep8 syntax

* update managed example

* update managed docs
2019-06-18 14:05:48 -04:00
Martin Nečas
c87dbed20f Ovirt nic default vnic (#57945)
* default vnic init

* ovirt default nic

* add spacing

* use network must be specified

* Update ovirt_nic.py

* Update ovirt_nic.py

* add no vnic profile exception

* correct pep8 syntax

* correct pep8 syntax

* correct pep8 syntax

* correct pep8 syntax
2019-06-18 12:16:45 -04:00
Felix Fontein
505c99265c docsite: remove lexers which have been fixed in Pygments 2.4.0 (#57508)
* Remove lexers which have been fixed in Pygments 2.4.0.
* Add Pygments >= 2.4.0 to test runner.
* Fix pages that triggered lexer errors.

Co-Authored-By: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>
2019-06-18 10:56:33 -05:00
Ganesh Nalawade
cc00f21a35 Fix issue in netconf plugin dispatch for junos and iosxr (#57981)
*  If case xml reply is transformed or namespace is removed in ncclient
   device specific handler return modified xml response as string

*  If data xml node is present in xml response return the xml string
   with data node as root node

*  If none above is true return raw xml string received from host
   with rpc-reply as the root node
2019-06-18 10:36:03 -04:00
Fred-sun
21a95c0a16 Update azure_rm_route related document (#57928)
* Update docs for azure_rm_route, azure_rm_routetable, and azure_rm_routetable_facts
2019-06-18 09:19:52 -05:00
Gabor Szabo
d4555cbd45 Examples on how to remove files and directories (#57766)
* Docs: file module - adds examples on how to remove files and directories
2019-06-18 09:07:31 -05:00
Guillaume Martinez
ec7b18952b gitlab_runner: Fix idempotency when creating runner (#57833) 2019-06-18 13:12:12 +02:00
hexdump0x0200
81f0b70f11 junos_netconf: fix check mode, fixes #57929 (#57930) 2019-06-18 15:11:15 +05:30
Kevin Breit
d24e9ab4bb meraki_content_filtering - Add support for querying (#57273)
* Added querying functionality

* Fix PEP8 and documentation

* Increment version added

* Fix version info
2019-06-18 14:52:46 +05:30
Will Thames
a66687f2d2 rds_instance: allow empty iops and storage_type (#57943) 2019-06-18 07:56:01 +02:00
zhongjun2
c58b715f82 hwc_network_vpc: fix typo (#57977) 2019-06-18 07:42:37 +02:00
Sumit Jaiswal
d63ccb5bc8
fix 57447 bug (#57938)
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
2019-06-18 10:09:43 +05:30
Sayed Anisul Hoque
a82156a63f Updated Notes section of the meta (#57921)
Docs: note that 'meta` tasks are handled differently internally than 'normal tasks' so looping on meta tasks is not supported.
2019-06-17 16:33:06 -05:00
Felix Fontein
f56cf72e2b
ufw: remove from sanity ignores (#57910)
* Remove from pylint ignore list.

* Make sure that option is called the same as in the documentation.
2019-06-17 22:57:55 +02:00
PRASOON KARUNAN V
0cf6a418ab Correcting the documentation for win_package return value[log] (#57854)
* correcting the documentaiton for log return value

* grammar change
2019-06-18 06:56:57 +10:00
Felix Fontein
da6f6cc456 Fix missing doc type. (#57884) 2019-06-17 15:52:08 -05:00
Abhijeet Kasurde
eed7a338a0 aws: Fix typo in deprecation warning (#57946)
Changed "ec2_instance_information" to "ec2_instance_info" in deprecation warning.

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-06-17 16:32:00 -04:00
Alex Stephen
9364b4c933 better metadata formatting on gcp_compute (#57778) 2019-06-17 16:10:27 -04:00
Fred-sun
6e89fbe58a Update azure_rm_networkinterface related document (#57454)
* Update azure_rm_networkinterface related document
* fixes errors with plural nouns, typos, uses single quotes for version_added
2019-06-17 14:38:57 -05:00
ShachafGoldstein
66728cb93f win_get_url - Fix handling of restricted headers (#57892)
* fix 57880

* ADded test

* Remove host header from test

* TEst error

* Fix tests

* fix user agent test
2019-06-18 05:25:38 +10:00
ShachafGoldstein
acc01f1109 Win_copy: doc fix when using become (#57690)
* win_copy: doc update

* Community review
2019-06-17 13:55:29 -05:00
The Magician
7751e97e1e Bug fixes for GCP modules (#57883) 2019-06-17 13:40:04 -04:00
Paul Belanger
fa738613dc
Revert "Fix iosxr discard_changes netconf rpc issue (#57931)" (#57954)
This actually broken junos netconf_rpc, and was merged without properly
testing.

This reverts commit 795cb90367.
2019-06-17 11:45:30 -04:00
Paul Belanger
d40c44bd56 Fix python3 encoding with iosxr_config (#57919)
Python3 requires bytes when writing files.

Depends-On: https://github.com/ansible/ansible/pull/57909/
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2019-06-17 17:42:29 +02:00
Ganesh Nalawade
4a3e14f90b More iosxr integration zuul CI test fixes (#57909)
* Ignore `<rpc-reply>` node from candidate and
  running configuration in xml diff

* Add route-policy as prerequisite to BGP coonfiguration
  in integration test
2019-06-17 17:22:46 +02:00
Ganesh Nalawade
795cb90367
Fix iosxr discard_changes netconf rpc issue (#57931)
* If dispatch() rpc response has data element
return the xml string from <data> element
else return the complete xml string from
<rpc-reply>.

Depends-On: #57909
Depends-On: #57919
2019-06-17 16:22:23 +05:30
Abhijeet Kasurde
cf623fa62f
Terraform: Fix unbound local error (#57044)
* Added Unit tests
* Fixed regression

Fixes: #56934

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-06-17 08:23:59 +05:30
Ruben Tsirunyan
9e225fbb1e zabbix: New module zabbix mediatype (#57488)
Co-Authored-By: Dusan Matejka <D3DeFi@users.noreply.github.com>
2019-06-16 23:16:58 +02:00
Jordan Borean
d0c4914469
win_shell - fix space escaping for custom executable (#57455) 2019-06-17 05:14:58 +10:00
Simon Dodsley
0f2903780b purestorage: Add module to set MOTD banner text for Pure Storage FlashArray (#57500) 2019-06-16 09:43:51 +02:00
Abhijeet Kasurde
6b16be638d
VMware: add facts about tags in vmware_host_facts (#56837)
Fixes: #46461

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-06-16 09:02:26 +05:30
Sergey
7910361b52 Fix failed mounts in podman connector and handle errors (#57741)
Like it's described in issue #57740 ansible podman fails to run
because of failed mount of rootless container.
2019-06-15 07:35:55 -04:00
Fred-sun
019a48361b Update azure_rm_resourcegroup related document (#57819)
* Update azure_rm_resourcegroup related document

* resolve shippable error
2019-06-14 15:34:20 -04:00
Fred-sun
23eb465956 Update azure_rm_roleassignment related document (#57820)
* Update azure_rm_roleassignment related document

* add new
2019-06-14 15:27:06 -04:00
Brian Coca
342d77b32d
removal of chdir in controller (#57781)
* removal of chdir in controller

also ensure fetch/put uses relative to task cwd
2019-06-14 13:45:41 -04:00
Brian Coca
de87b25a45
show host_vars/ also in --graph (#56307)
* show host_vars/ also in --graph

  fixes #53422
2019-06-14 13:40:22 -04:00
Martin Krizek
e9c83b7a17 gather_facts: clean up tmp files upon completion (#57845)
Fixes #57248
2019-06-14 12:55:22 -04:00
Fred-sun
8d635a82a4 Update azure_rm_publicipaddress related document (#57669)
* Update azure_rm_publicipaddress related document
2019-06-14 10:43:06 -04:00
Fred-sun
aeb72dfb06 Update azure_rm_resource related document (#57786)
* Update azure_rm_resource related document

* resolve shippable check error

* Resolve format error

* resolve format error---02

* Redefine the type variable
2019-06-14 10:13:32 -04:00
Fred-sun
1903aced79 Update azure_rm_rediscache related document (#57721)
* Update azure_rm_rediscache related document

* Update according by comment
2019-06-14 10:06:18 -04:00
Paul Belanger
88a1fc28d8 Clean up iosxr get_config_diff function (#57589)
This fixes an index error issue when running tests on zuul.ansible.com
for iosxr. We can fix this by getting the last element in the list.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2019-06-14 15:06:21 +05:30
Jagadeesh N V
6e8fcbf8c9 Adding idrac_pwd alias to modules (#57733) 2019-06-14 01:43:21 -04:00
Sander Steffann
71a704cc14 netbox: inventory: fix implementation of groups option (#57689) 2019-06-14 06:29:46 +02:00
bobdoah
33d0d36eaa AWS: Fix KeyError in aws_secret lookup (#54792) 2019-06-13 17:11:44 -07:00
Skybound1
e7bf46d8bc Adds visibility parameter to gitlab group creation (#57024) 2019-06-13 18:40:14 -04:00
The Magician
138f0e875a Bug fixes for GCP modules (#57724) 2019-06-13 18:25:57 -04:00
The Magician
a58088f661 Bug fixes for GCP modules (#57725) 2019-06-13 18:25:46 -04:00
The Magician
366a9784ac Bug fixes for GCP modules (#57727) 2019-06-13 18:25:23 -04:00
The Magician
ab0a548b0c Bug fixes for GCP modules (#57728) 2019-06-13 18:25:11 -04:00
The Magician
625ef22dd9 New Module: gcp_tpu_node (#57729) 2019-06-13 18:25:00 -04:00
Martin Krizek
61ff61cdf6 Tests as filters were deprecated, remove unused param (#57796) 2019-06-13 15:36:52 -04:00
The Magician
1d6d19f400 New Module: gcp_tpu_node_facts (#57730) 2019-06-13 15:11:46 -04:00
Kevin Breit
a85750dc98 Meraki - Convert response keys to snake_case from camelCase (#53891)
* Initial proposal for new parameter option for response format
- output_version parameter dictates the response key case
- new is snake_case, old is camelCase
- If new, conversion is done at the end of module execution
- This is purely a proposal and not a final draft

* Add support for ANSIBLE_MERAKI_FORMAT env var
- If env var is set to 'camelcase' it will output camelcase
- Otherwise, will default to snakecase
- Added note to documentation fragment
- As of now, all module documentation needs to be updated

* Fix pep8 errors and remove output_version args

* Restructure check in exit_json so it actually works

* Add changelog fragment

* Change output_format to a parameter with env var fallback
- ANSIBLE_MERAKI_FORMAT is the valid env var
- Added documentation

* Convert to camel_dict_to_snake_dict() which is from Ansible
- Fixed integration tests

* Fix yaml lint error

* exit_json camel_case conversion handles no data
- exit_json would fail if data wasn't provided
- Updated 3 integration tests for new naming convention

* convert_camel_to_snake() handles lists and dicts
- The native Ansible method doesn't handle first level lists
- convert_camel_to_snake() acts simply as a wrapper for the method
- There maybe a situation where nested lists are a problem, must test
- Fixed integration tests in some modules

* A few integration test fixes

* Convert response documentation to snake case
2019-06-13 15:07:30 -04:00
jarekgajewski
e264b4126f Update gcp_storage_object.py (#57802)
"name: ansible-storage-module" removed as name is not defined as parameter  


##### ISSUE TYPE
- Docs Pull Request

+label: docsite_pr
2019-06-13 13:16:07 -04:00
Harald Albers
231f4cfcf1 Fix example in vmware_drs_group module (#57805)
Signed-off-by: Harald Albers <github@albersweb.de>
2019-06-13 13:12:59 -04:00
Adam Miller
d2dc4c9bc4 assign a sane default to yum/dnf lock_timeout, in line with cli (#57383)
* assign a sane default to yum/dnf lock_timeout, in line with cli

Fixes #57189

Signed-off-by: Adam Miller <admiller@redhat.com>

* fix typo in changelog snippet

Signed-off-by: Adam Miller <admiller@redhat.com>
2019-06-13 11:17:23 -04:00
Arnaud RENARD
1a5fd720a4 Ansible galaxy role download should not have to perform aditionnal check against tar archive file extension #56616. (#56617)
Ansible galaxy role download checked for `.tar.gz`, but `tarfile.is_tarfile(...)` can identify and open any valid tarfile. This change uses transparent stream compression to make `.tar.gz` and `.tar.bz2` formats valid with python 2.6.x/2.7.x (as well as `.tar.xz` with python 3.x).
2019-06-13 09:23:41 -05:00
Dmitry Tantsur
d33ee72085 os_ironic_node: avoid set_node_instance_info and purge_node_instance_info (#54463)
These openstacksdk calls are awkward special-case wrappers around
patch_machine, and I would like to deprecate them in openstacksdk change
https://review.openstack.org/647730. Use much simpler update_machine instead.
2019-06-13 09:08:24 -04:00
Ondra Machacek
886f4c66ca kubevirt: Add affinity parameters (#57359) 2019-06-13 12:25:30 +02:00
Martin Nečas
f7de9cb39f ovirt host facts fix (#57790) 2019-06-13 06:12:54 -04:00
Mariusz Mazur
51add5aa79 kubevirt: enable/update tests + fix merge_dicts() (#57685)
* Actually run the unit tests and separate them into two files

* Re-add recursion to merge_dicts()

* Update tests to work with current code
2019-06-13 11:07:16 +02:00
Abhijeet Kasurde
00604d3f2c
VMware: Fix vmware_guest_move undefined VM name error (#57582)
* Updated testcase
* Added check mode support
* Added check for mutual exclusive for Name and UUID

Fixes: #57580

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-06-13 13:07:26 +05:30
René Moser
5143f52def
vultr: vultr_ssh_key_facts -> info (#57571)
* vultr: deprecate vultr_ssh_key_facts

* vultr: rename tests

* vultr: adjust tests

* vultr: new vultr_ssh_key_info module

* vultr: test: vultr_ssh_key_info: improve tests

* update docs
2019-06-13 07:05:00 +02:00
Strahinja Kustudic
8e9f29c40c Added environment variables to gcp_compute to align with gcp_* modules (#57776)
Added all variables that are also used by the gcp_* modules as described
in the docs
https://docs.ansible.com/ansible/latest/scenario_guides/guide_gce.html#providing-credentials-as-environment-variables
2019-06-12 17:36:57 -04:00
Brian Coca
73a16749cb
Enable adjacent collections for ansible-doc (#57764)
* enable adjacent collections for ansible-doc
2019-06-12 17:10:17 -04:00
LucasBoisserie
1d76635206 Remove required field on service_account_file in gcp_compute plugin inventory (#57345) 2019-06-12 16:51:57 -04:00
Strahinja Kustudic
f6a0f9874d Improve speed of the gpc_compute dynamic inventory (#57591)
To get all instances gcp_compute made a call to the Google API for each
zone separately. Because of this if all zones needed to be queried
fetching hosts lasted 30+ seconds. Now the module will use a single
query that will return all the instances, so the execution should last
just a few seconds.

This commit also suppresses a warning from the google-auth library about
using user credentials because if an Ansible user wants to use user
credentials, there is no need to warn him about it.
2019-06-12 16:38:48 -04:00
Mike Garrett
4bf051b8bb redfish: fix a problem with Chassis/Power URI (#56185)
Fixes #56137 - problem with Chassis/Power URI and GetChassisPower command - assemble URI from data in Chassis resource
2019-06-12 20:40:30 +02:00
xuxiaowei0512
5bddd55703 update vxlan (#57264)
* update vxlan

* add a changelog fragment for the PR 57264

* Update 57264-update-vxlan-to-fix-bugs.yml

update for change request

* Update ce_vxlan_vap.py

remove commented codes.
2019-06-12 13:00:55 -04:00
xuxiaowei0512
e009936f87 update acl (#57268) 2019-06-12 12:58:15 -04:00
Chaitanya Deshpande
6d21cebd7d Avi credentials added sub-options (#57531)
* Split Avi Credentials into two parts - secrets and login_info

* Fixed indentation issue

* Removed trailing whitespaces

* Added sub-options to avi credentials

* Added sub-options to avi credentials

* Updated argument specs to use fallback instead of getting defaults from environment variable
2019-06-12 12:19:29 -04:00
xuxiaowei0512
5ac3661176 update snmp modules to fix bugs for cloudengine (#57025)
* update snmp modules to fix bugs for cloudengine

* update snmp modules to fix bugs for cloudengine

* update "ce_snmp_contact", list may be out range
2019-06-12 11:27:21 -04:00
Kevin Breit
17c475b101 meraki_ssid - Improve change reporting (#56201)
* Improve change reporting for meraki_ssid
- Documentation is more clear about dependencies
- Not all change reports are accurate without new algorithm
- Improved integration tests

* Rename changelog fragment

* Enable all tests in integration tests
- Fix type merging

* Add more integration tests for code coverage

* Update URL creation
2019-06-12 11:06:00 -04:00
Martin Krizek
1fa7bfcd5d Fix --diff to produce output when creating a new file (#57744)
* Fix --diff to produce output when creating a new file

Fixes #57618

* Make the check more defensive
2019-06-12 10:56:14 -04:00
Mikhail Yohman
d07d394779 Bugfix: Creating two IPs in single run of netbox_ip_address (#56550)
* Found bug, fixed by moving the serialization of objects out of try while creating objects

* Added changelog to document fix
2019-06-12 10:45:20 -04:00
Kevin Breit
a50b3d7695 meraki_syslog - Module properly handles net_id parameter (#57286) 2019-06-12 10:44:05 -04:00
Kevin Breit
87169c4aa4 meraki_vlan - Enable check mode (#54627)
* Add support for check mode

* Add diff support
- diff support is based on "have" and "want" data structures.
- Review needs to be done on the diffs for accuracy and usefulness.
- Changed change mode changed responses to be accurate.

* Remove config template based integration tests
2019-06-12 10:43:02 -04:00
Stefan Horning
77ec0549b0 New module for AWS CodeBuild (#47187)
* New AWS module for the CodeBuild service, called aws_codebuild

* Integration test for new aws_codebuild module
2019-06-12 10:25:53 -04:00
mrtwnklr
83bf90e02f Fixes #55476 (#57715)
* fixes bug introduced by commit 8cb73720f0599b08794cb7a3fbdf36d430214446: "TypeError: argument of type 'NoneType' is not iterable" when using module systemd without param 'name' (e.g. with daemon_reload)
2019-06-12 09:50:32 -04:00
Alexey Kamenskiy
793c18506a lvg: fix default value type, should be str (#57723) 2019-06-12 14:52:43 +02:00
Stefan Horning
33a26d31fd New module for AWS CodePipeline (#47189)
* New module for AWS CodePipeline

* Added integration test for new aws_codepipeline module
2019-06-12 08:50:09 -04:00
Martin Nečas
4052d6d294 set ovirt disk active default (#57464)
* set ovirt disk active default value to True

* disk default activate only when creating

* correct comment syntax

* add changelog

* ovirt disk activate update docs
2019-06-12 12:32:58 +02:00
Gonéri Le Bouder
6537d1bc0f vmware_host_ipv6: only changed when changed (#57702)
Do not return the `changed` status when a reboot is required. The
configuration is applied and so the configuration changed has already been
done.
2019-06-12 14:20:18 +05:30
Nijin Ashok
166a5c909c ovirt_vm: Fix issue in resetting the storage domain lease (#57469)
Currently, there is no way to remove the lease. The patch allows to
reset it by passing an empty string ('') to lease.
2019-06-12 04:41:51 -04:00
Brett
69ead0ba78 puppet: new arg to toggle no-/use_srv_records flag (#53095) 2019-06-12 10:02:58 +02:00
Chris Van Heuveln
205f6b1699 nxos_pim_interface: Add 'bfd' support (#57133)
* nxos_pim_interface: Add 'bfd' support

* PEP fixes

* fix copyright date

* bfd states changed from T/F to enable/disable/default
2019-06-12 09:47:41 +05:30
ShachafGoldstein
7880be240f Remove usage of global var log_path for win_domain_* modules (#57092)
* Remove usage of global var log_path

* Add changelog and edit ignore.txt

* win_pagefile: not using testPath

* Revert "win_pagefile: not using testPath"

This reverts commit c8bc10234048257414454905e1c860a8f57a3b3f.

* PSLint error

* Update win_domain_membership.ps1

* Update win_domain_controller.ps1
2019-06-12 05:31:19 +10:00
ShachafGoldstein
d2909d5ef0 win_scheduled_task: Fix start/end boundry triggers to allow for timezone sync (#57282)
* Fix 49327

* Add a test

* Join test

* Test issue

* Fix missed assertion
2019-06-12 05:27:51 +10:00
ShachafGoldstein
1b5975f17e Fixes #54550 (#56279)
* "setup.ps1" - Change $env:COMPUTERNAME to [System.Net.Dns]::GetHostName(), to support non NETBIOS compliant hostnames

* Change method to base on WMI

* changed ansible_domain to use WMI

* Fixed per review

* Fixed dot stuff

* Revert "Fixed dot stuff"

This reverts commit a1d5be00f1.

* dot stuff

* dot stuff 2.0

* Update setup.ps1

* Wrap this up to go
2019-06-12 05:25:38 +10:00
Abhijeet Kasurde
6c23a8df66 VMware: Restrict vcenter_folder for vCenter
Folder creation API is only supported by vCenter, specifying
Standalone ESXi system will raise error.
This fix adds an user warning for suggesting this restriction.

Fixes: #49938

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-06-11 14:51:38 -04:00
The Magician
31bec0dd95 Bug fixes for GCP modules (#57152) 2019-06-11 13:53:42 -04:00
The Magician
087f560b7c Bug fixes for GCP modules (#57260) 2019-06-11 13:53:27 -04:00
The Magician
142598972d Bug fixes for GCP modules (#57261) 2019-06-11 13:53:13 -04:00
The Magician
ecbd1173b9 New Module: gcp_cloudscheduler_job (#57262) 2019-06-11 13:52:56 -04:00
The Magician
fcff70f887 New Module: gcp_cloudscheduler_job_facts (#57263) 2019-06-11 13:52:41 -04:00
mirfire
20ec5e66e1 Fixed heading link password field in user module (#57694)
##### SUMMARY
In the [user module](https://docs.ansible.com/ansible/latest/modules/user_module.html#user-module), the password field links to `https://docs.ansible.com/ansible/faq.html#how-do-i-generate-crypted-passwords-for-the-user-module`, but the actual link is `https://docs.ansible.com/ansible/faq.html#how-do-i-generate-encrypted-passwords-for-the-user-module` as it was modified in d27d956d71

So I corrected the link in the user module to the actual link. 

##### ISSUE TYPE
- Docs Pull Request

+label: docsite_pr
2019-06-11 11:38:30 -04:00
Mariusz Mazur
1035a9aa49 kubevirt_pvc: fix parameter priority (#57617) 2019-06-11 11:03:32 -04:00
Chris Archibald
98da0e6c99 Bug Fixes for na_ontap_interface (#57363)
* bug fixes

* bug fix
2019-06-11 16:26:39 +02:00
Chris Archibald
e80d6f18ce Duplicate rules were being created if rule index was not set (#57379)
* bug fixes

* Revert "bug fixes"

This reverts commit 2d839ecf35.

* bug fix
2019-06-11 16:26:02 +02:00
Pilou
c4f336081e fix tower_credential example: lookup are run on controller (#57516)
- don't advise to use lookups in order to fetch path on managed nodes
- fix example:
    - use slurp instead 'file' lookup
    - remove extraneous brackets
2019-06-11 10:25:39 -04:00
Andrey Klychkov
a25acbbf83 postgresql_idx: self.__exec_sql -> module_utils.postgres.exec_sql (#57684)
* postgresql_idx: self.__exec_sql -> module_utils.postgres.exec_sql

* postgresql_idx: exec_sql, added a changelog fragment

* postgresql_idx: exec_sql, fix the changelog fragment
2019-06-11 10:07:03 -04:00
Christian Claus
aa3b2c47f1 Update azure_rm_virtualmachine.py (#57125)
Docs: Add resource_group values in examples of:
- Power On
- Restart
2019-06-11 08:54:29 -05:00
Andrey Klychkov
a8ebbecd53 postgresql modules: use postgres.exec_sql instead of __exec_sql methods (#57674)
* postgresql modules: use postgres.exec_sql instead of __exec_sql methods

* postgresql modules: use exec_sql, added changelog fragment

* Update changelogs/fragments/57674-postgres_modules_use_exec_sql_instead_of_methods.yml

Co-Authored-By: Felix Fontein <felix@fontein.de>
2019-06-11 13:42:53 +02:00
Andrey Klychkov
f80ac73316 postgresql_idx: add docstrings, remove extra doc lines (#57670) 2019-06-11 06:20:26 -04:00
chkp-orso
bab1a3ceda PR to introduce cp_network and cp_publish as modules (#57621)
* network and install policy modules for example

network and install policy modules for example

* revert the changes in version

revert the changes in version

* documentation_fragment

documentation_fragment

* Checking the status code of the set request

* delete some of Rikis' files

* retrieve Rikis' files and call equals API method

* adding blanck line between functions

* implement host, address-range and group

* mostly sintax fixes

* try again with the old host and access rule

* small changes

* adding service udp and publish

* publish command

* little fix

* choises for state parameter

* support wait_for_task and API version

* imports

* refactor of function's name

* network module

* rename modules and return value from modules

* PR before examples to: tests, lookup, check_mode

* small fixes

* fixes for code review

* small fixes

* state parameter in examples and many /n

* white spaces

* 4 tries for how choices should be, and turn true to True
2019-06-11 12:27:03 +05:30
René Moser
8c3382ec70
vultr: vultr_os_facts -> info (#57565)
* vultr: vultr_os_facts: rename to info

* vultr: vultr_os_facts: rename tests to info

* vultr: adjust tests

* vultr: new vultr_os_info module
2019-06-11 07:51:24 +02:00
René Moser
0ca50c7d6f
vultr: vultr_user_facts -> info (#57564)
* vultr: deprecate vultr_user_facts

* vultr: vultr_user_facts: rename to info

* vultr: adjust tests

* vultr: new vultr_user_info module
2019-06-11 07:49:24 +02:00
Ryan Hatter
f7e5494a67 Small grammar error (#57654) 2019-06-10 23:32:19 +02:00
ShachafGoldstein
a87495d07c win_pagefile: not using testPath (#57093)
* win_pagefile: not using testPath

* Added changelog
2019-06-10 17:07:10 -04:00
ShachafGoldstein
a8e133105c win_domain_group_membership: Fix missing @extra_vars on Get-ADObject to support different domain and credentials for retrieval (#57429)
* win_domain_group_membership - Fix missing @extra_vars on Get-ADObject to support dirrent domain and credentials for retrival

* win_domain_group_membership - Fix missing extra_vars on Get-ADObject
2019-06-11 06:26:01 +10:00
Felix Fontein
13f73adef5
AWS: _facts -> _info (part 4) (#57651)
* Rename ec2_vpc_dhcp_option_facts -> ec2_vpc_dhcp_option_info.

* Rename ec2_vpc_endpoint_facts -> ec2_vpc_endpoint_info.

* Rename ec2_vpc_igw_facts -> ec2_vpc_igw_info.

* Rename ec2_vpc_nacl_facts -> ec2_vpc_nacl_info.

* Rename ec2_vpc_nat_gateway_facts -> ec2_vpc_nat_gateway_info.

* Rename ec2_vpc_net_facts -> ec2_vpc_net_info.

* Rename ec2_vpc_peering_facts -> ec2_vpc_peering_info.

* Rename ec2_vpc_route_table_facts -> ec2_vpc_route_table_info.

* Rename ec2_vpc_subnet_facts -> ec2_vpc_subnet_info.

* Rename ec2_vpc_vgw_facts -> ec2_vpc_vgw_info.

* Rename ec2_vpc_vpn_facts -> ec2_vpc_vpn_info.

* Update module defaults, add changelog and porting guide.

* Update BOTMETA.
2019-06-10 21:40:05 +02:00
Sloane Hertel
598a058afe
[FactCache] define first_order_merge method (#55781)
* Add first_order_merge method

Add test for updating a key that already exists

* changelog
2019-06-10 14:34:06 -04:00
Felix Fontein
804d5eaf8e
AWS: _facts -> _info (part 3) (#57635)
* Rename ec2_ami_facts -> ec2_ami_info.

* Rename ec2_asg_facts -> ec2_asg_info.

* Rename ec2_customer_gateway_facts -> ec2_customer_gateway_info.

* Rename ec2_eip_facts -> ec2_eip_info.

* Rename ec2_elb_facts -> ec2_elb_info.

* Rename ec2_eni_facts -> ec2_eni_info.

* Rename ec2_group_facts -> ec2_group_info.

* Rename ec2_instance_facts -> ec2_instance_info.

* Rename ec2_lc_facts -> ec2_lc_info.

* Rename ec2_placement_group_facts -> ec2_placement_group_info.

* Rename ec2_snapshot_facts -> ec2_snapshot_info.

* Rename ec2_vol_facts -> ec2_vol_info.

* Update module defaults, add changelog and porting guide.

* Forgot one occurence of ec2_instance_facts.

* Update BOTMETA.

* Break too long line.
2019-06-10 19:33:38 +02:00
Alicia Cozine
1d054a6671 clarifies docs while we await rds_snapshot module 2019-06-10 12:51:51 -04:00
Abhijeet Kasurde
822f82468d aws: Add suggestion about rds_instance in rds
rds_instance is boto3 based module, add a note in rds module documentation
about the same.

Fixes: #54686

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-06-10 12:51:51 -04:00
Felix Fontein
fc4bbff6e1
AWS: _facts -> _info (part 2) (#57626)
* Rename cloudwatchlogs_log_group_facts -> cloudwatchlogs_log_group_info.

* Rename elasticache_facts -> elasticache_info.

* redshift_facts -> redshift_info.

* Rename route53_facts -> route53_info.

* Rename rds_instance_facts -> rds_instance_info.

* Rename rds_snapshot_facts -> rds_snapshot_info.

* Rename iam_mfa_device_facts -> iam_mfa_device_info.

* Rename iam_role_facts -> iam_role_info.

* Rename iam_server_certificate_facts -> iam_server_certificate_info.

* Rename elb_application_lb_facts -> elb_application_lb_info.

* Renaming elb_classic_lb_facts -> elb_classic_lb_info.

* elb_target_facts -> elb_target_info.

* Rename elb_target_group_facts -> elb_target_group_info.

* Update porting guide.

* Add changelog.

* Fix module defaults (both for this PR and #57613).

* Two fixes.
2019-06-10 17:48:07 +02:00
Abhijeet Kasurde
3bee49a3bb Remove trailing new line while including vars (#57605)
While including var files using _raw_params adds additional new line
character, which makes Ansible to fail to include that file in.
This fix removes extraneous new line character while parsing the var file.

Fixes: #57593

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-06-10 11:23:38 -04:00
Fred-sun
7cf0d82108 Update azure_rm_postgresqldatabase related document (#57458) 2019-06-10 10:02:42 -05:00
Felix Fontein
433e00c219 Clarify documentation on dockerfile. (#57570) 2019-06-10 10:42:59 -04:00
Fred-sun
6cd2543a2b Update azure_rm_postgresqlconfiguration related document (#57596) 2019-06-10 09:21:53 -05:00
Matt Martz
c3ca3757c9 Provide a better error when python-dnf install fails (#57622) 2019-06-10 09:21:41 -05:00
Fred-sun
2575f0e39b Update azure_rm_postgresqlfirewallrule related document (#57598) 2019-06-10 09:20:42 -05:00
Fred-sun
74c21d40f9 Update azure_rm_postgresqlserver relate document (#57600) 2019-06-10 09:20:13 -05:00
Paul Belanger
f709d2e2bb Make netconf_get python3 compat (#57578)
This uses to_text to ensure tostring() from lxml is decoded properly.

Depends-On: https://github.com/ansible/ansible/pull/57309
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2019-06-10 16:11:31 +02:00
Ganesh Nalawade
a867ced4de Fix junos integration zuul CI failures (#57309) 2019-06-10 16:10:57 +02:00
Felix Fontein
51229eb99c
AWS modules: _facts -> _info (#57613)
* Rename aws_acm_facts -> aws_acm_info.

* Rename aws_az_facts -> aws_az_info.

* Rename aws_caller_facts -> aws_caller_info.

* Rename aws_kms_facts -> aws_kms_info.

* Rename aws_region_facts -> aws_region_info.

* Rename aws_sgw_facts -> aws_sgw_info.

* Rename aws_waf_facts -> aws_waf_info.

* Adjust docs.

* Add changelog and update porting guide.
2019-06-10 15:52:49 +02:00
Anton Nikulin
4fa93d5b9b FTD configuration module: fix a bug with response parsing (#57480)
* Update dependence's name to firepower-kickstart

* Check response type before getting attributes

* Add unit test for construct_ansible_facts method

* Update error message
2019-06-10 18:30:35 +05:30
Felix Fontein
039eb892ba
Second batch for _facts -> _info rename (#57020)
* Second batch of _facts -> _info.

* Forgot one reference.
2019-06-10 13:04:07 +02:00
Sajna Shetty
e25269e1b3 Adding dell ome device_info module (#53438)
* Adding device_facts module for contribution

* changes added for pylint error

* Updated code to solve ansible-test compile error

* Changes to avoide comile error added

* Review Comments changes update

* Avoided blank line

* pylint error changes

* Removed ansible_facts return in error case

* Updated description

* modules renamed

* changing from ansible_facts to device_info

* avoide pep8 error

* Updated sample output

* version changed to 2.9

* Changed Copyright license to BSD

* Changed 3-clause BSD license to 2-clause BSD

* Added unit test support for ome_device_info

* version change

* removed pylint error in unit test modules

* Avoid Sanity error for unit test modules

* updated version
2019-06-10 06:41:48 -04:00
Felix Fontein
ef2d70a806
Rename ali_instance_facts -> ali_instance_info (#57036)
* Rename ali_instance_facts -> ali_instance_info.

* Add changelog.
2019-06-10 12:40:50 +02:00
Stefan Horning
9ba3b01ef0 Extended cloudfront_facts module to have a predictable return value… (#49061)
* Extended cloudfront_facts module to have a predictable return value for getting results.

* Updated RETURN docs with new field.

* Corrected the RETURN docs

* Fix typo in YAML
2019-06-10 19:23:05 +10:00
Andrey Klychkov
ffa172e3a6 postgresql: moved function exec_sql from the modules to module_utils (#57603) 2019-06-10 11:15:07 +02:00
Andrey Klychkov
17c5e0e016 postgresql_tablespace: remove extra lines from the doc, add docstrings (#57534) 2019-06-10 13:57:08 +05:30
Martin Nečas
c5dc48de81 Ovirt add job (#55440)
* init ovirt_job module

* ovirt job add state finished

* redone logic in ovirt job

* ovirt jobs add docs

* ovirt job update docs

* update failed status

* ovirt job update return docs

* ovirt job update docs

* check if job and step has finished

* remove job status end
2019-06-10 09:56:09 +02:00
Bill Dodd
e5972ccbab redfish_command: Avoid power on/off commands if system already in target state (#56069)
* avoid power on/off commands if system already in target state

* add changelog fragment
2019-06-10 09:50:04 +02:00
Hideki Saito
d86183f595 tower_user: Fix to create a system auditor properly (#54585)
- Fixed issue #54446: tower_user cannot create an auditor user

Signed-off-by: Hideki Saito <saito@fgrep.org>
2019-06-10 09:48:02 +02:00
Bill Dodd
7eae4761b8 redfish: Add MACAddress property to GetNicInventory (#56864)
* add MACAddress property to GetNicInventory

* add changelog fragment
2019-06-10 09:45:56 +02:00
Bill Dodd
9151f343da redfish: docs: Add type for options (#56809)
* add type: for options in docs for Redfish modules

* add changelog fragment
2019-06-10 09:27:52 +02:00
Chris Archibald
a58570f1bc na_ontap_snapshot_policy: Add ability to multiple schedules (#57366) 2019-06-10 09:24:25 +02:00
ECRR
5cc6486a2b Merge authentication options back into a single field to prevent losing options beyond the first (#57507)
* Merge authentication options back into a single field to prevent losing options beyond the first

* Add integration test and changelog

* Fix multiple options for local type connections. Also fix sorting errors between local type connections that lack a src

* Build again because of github problems?

* Add spaces before comments
2019-06-10 09:16:01 +02:00
René Moser
c001391555
vultr_server: implement support for IDs to match resources (#55762) 2019-06-09 13:34:25 +02:00
Simon Dodsley
7f68ebeed3 purefa: New module purefa_arrayname (#57496) 2019-06-09 12:15:05 +02:00
Simon Dodsley
c1e70660aa purefa: new module purefa_syslog (#57486) 2019-06-09 12:10:04 +02:00
Simon Dodsley
96b88b0510 purefa: Add module to enable or disable arrays phonehome capability (#57506) 2019-06-09 10:27:05 +02:00
Simon Dodsley
30c9322e99 Fix idempotency issue when updating host object in FlashArray (#55347) 2019-06-08 14:11:10 -04:00
Felix Fontein
9d67f476e6 acme_certificate: fix docs (#57557)
* Fix indentation.

* Forgot when condition for second acme_certificate call.
2019-06-08 02:11:58 -04:00
Sloane Hertel
cd77ea3c7f
File module - fix unicode paths and add a test (#57558)
* File module - Fix unicode paths

* Add a test for unicode paths for the file module
2019-06-07 21:27:38 -04:00
Zim Kalinowski
93a85b6c86 Additional rename fixes (#57527)
* adding symbolic link

* missing renames

* reverted version_added
2019-06-07 18:22:17 -07:00
Stefan Horning
8c631cbc0a Fix rds_instance module… (#56220)
* Fix rds_instance module to run against an (older) existing RDS instance successfully

* Only pop Iops param if no storage_type is given. If given and set to wrong type we get to the AWS client error that informs the user

* Docs syntax fix

* Fix typo in docs

Co-Authored-By: stefanhorning <stefan@hornings.de>
2019-06-07 20:32:49 -04:00
Eric Pulvino
1661c87bae Fix lack of support for Cumulus Linux with Hostname module in Ansible v2.8.0. (#57493) 2019-06-07 15:40:20 -04:00
xuxiaowei0512
76e06fa7c2 update vrf to fix bugs (#57270)
* update vrf

* update vrf
2019-06-07 13:03:53 -04:00
xuxiaowei0512
4dc6faea59 update info-center (#57269) 2019-06-07 13:02:06 -04:00
Iain Madder
91d326cb68 Update file.py's initial_diff() to list existing when state: absent (#56353) 2019-06-07 09:55:51 -04:00
Mikhail Naletov
fba67bbe53 Updated documentation for zabbix-screen module (#57325)
Updated module settings.
Do not check screens options because of module screens.
2019-06-07 13:36:25 +02:00
tcraxs
07d446825a New module postgresql_sequence (#55027)
* postgresql_sequence: initial commit with new module and tests

* change return variables and adjust tests

* fix sanity checks

* fix linter errors

* change formatting functions and put params alphabetically

* add new examples and remove restrict option
* remove restrict option
* remove `required: false`
* add links to documentation
* change some minor parts in documentation
* add new integration tests for
** drop cascade
** change owner

* change usage of owner and created a test case for set owner during creation

* remove some documents and use docsfragments

* add aliases for minvalue and maxvalue

* change to warn if sequence not exists but should be removed

* use connect_to_db from module_utils/postgres.py

* add checkmode for several tests

* fix psycopg2 import and connect_to_db

* add a test for drop nonexistent sequence

* change get_info funcrtion to use only one SQL statement

* rewrite the module for cleaner code
* remove psycopg2
* change check_mode behavior
* add docstrings for class and methods
* add test for create sequence with owner in check_mode

* fix typo in set_schema()

* fix docu and cleanup the code
* adjust documentation for state, schema and newschema
* remove mutually_exclusive for 'absent'
* remove unused code comments
* remove warning for drop non-exicsting sequence
* change autocommit condition

* adjust state documentation
2019-06-07 13:34:57 +02:00
Chris Van Heuveln
bd844bc11c nxos_interface_ospf: Add bfd support (#56807)
* nxos_interface_ospf: Add bfd support

Add support for `bfd` state in `nxos_interface_ospf`

- Feature Pull Request

`nxos_interface_ospf`

* Fix pep issues

* sanity loop: syntax

* bfd states changed from T/F to enable/disable/default

* doc hdr fixes
2019-06-07 09:58:29 +05:30
Matt Clay
b9a0086aac Fix RuntimeError on Python 3.8. 2019-06-06 18:35:07 -07:00
Matt Martz
728fce0c44 Perf improvement for Templar.is_template (#57489)
* Faster is_template
2019-06-06 15:49:26 -04:00
Kerwin Bryant
95882faca6 Optimize the code for the callback module (#56827)
* Optimize the code for the callback module

* fix pep error

* Restore incorrectly submitted code

* fix pep error

* fix pep error

* Restore incorrectly submitted code

* Restore incorrectly submitted code

* fix condition

* fix condition

* fix pep error
2019-06-06 15:37:28 -04:00
Brian Coca
b9b0b23015
safe_eval fix (#57188)
* just dont pass locals

 - also fix globals
 - added tests

* fixed tests
2019-06-06 15:36:22 -04:00
Paul Gear
99f9f49eca Correct grammar (#57385)
"it's" == "it is"
"its" == "belonging to it"
2019-06-06 15:05:01 -04:00
pratikgadiya12
72297db686 Renames Digital Ocean cloud _facts modules to _info (#57315)
Fixes: #57276
2019-06-06 19:33:19 +02:00
Junyi Yi
bd48a7fb73 Implement a new module to support Batch Account (#55074)
* Implement a new module to support Batch Account.

* Fix the schema definition.

* Fix some lint errors.

* Normalize line endings.

* Remove not-recommended idempotency check.

* adding stubs for discussion

* Add one more output attribute.

* Leverage `idempotency_check` and `normalize_resource_id`.

* Fix line is too long error.

* normalize resource id implementation

* normalizing resource id fix indentation

* Fix linting issues.

* Fix runtime errors of Azure Python SDK.

* Add info module to Batch Account.

* Remove info module per suggestion.

* adding initial comparison function

* fix in idempotency check

* batch account update to support idempotence

* don't modify azure_rm_common for timebeing to avoid excessive ci

* adding first ci

* added more description on comparison function

* fixed storage account name

* fix

* fixed indent in common function + batch account name unpacking

* fix bug

* fixing sanity

* updated class relations

* fix in common

* updated disposition

* Add two more updatable/disposition in module_arg_spec

* updated common file

* Fix documentation for auto_storage_account.

* fixed line too long

* fixed keyvault reference

* fixed batch account creation

* fix pep8

* Regenerate code according to the feedbacks.

* test deleting batch account

* Add auto-generate comments to test file.

* renamed delete task, removed unstable

* clean up storage account
2019-06-06 09:10:01 -07:00
Rohit
a87de8d7b0
flag added foy vyos_interface module (#57124)
Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>
2019-06-06 18:23:19 +05:30
hexdump0x0200
ae5d3d76f6 ios_logging improvement (#57336)
* ios_logging: documentation update, add check for 'level' parameter

* ios_logging: add 'trap' destination
2019-06-06 16:52:31 +05:30
Abhijeet Kasurde
e0f6c17857 Fixed typo in task_executor (#57461)
Changed 'requied' to 'required'

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-06-06 12:27:18 +02:00
Chris Van Heuveln
7aa0d26fda nxos_bfd_global / NxosCmdRef initial commit (#56317)
* nxos_bfd_global: initial commit

This is an initial POC with just a few commands included.  The code has been written somewhat generically so that it can act as a best practices template for re-use in future modules. The implementation follows the yaml cmd_ref style to define each command's getter/setter/type/default. It supports platform-specific defaults.

The basic logic is to collect all relevant data in a `cmd_ref` dict and pass that around to various methods.

In the BFD case the devices don't provide JSON output so we have to screen-scrape with show runs.

BFD does not support present/absent states so there is no state param.

BFD has three different property types to handle. We can add add'l types as needed:

- int
- int_list (list of ints)
- str (needs support for 'no' keyword)

* Use get_capabilities to find platform type

* PR comment fixes, round 1

* Minor cleanups

* nxos_bfd_global: create NxosCmdRef in module_utils

This commit just takes the latest bfd global code and moves the bulk
of the code into new `class NxosCmdRef` in `module_utils/nxos/nxos.py`.

The only remaining code in `nxos_bfd_global.py` are the calls from `main()`.

* Add remaining command properties and documentation

* update argument_spec

* Add check for _exclude; add sanity test

* Add targets files for bfd

* Context and state absent updates

* Add dict support to cmd_ref

* Changed remaining list commands to dict usage

* Add idempotence check for dict

* Fix existing overwrite bug

* Move pattern matching logic into its own method

* add support for 'command: absent'

* Add `get_platform_shortname`; update BFD platform-specific settings

* /absent/deleted/

* /sh/show/ in prepare_nxos_tests

* add dict check to get_platform_shortname

* Add normalize_defaults()

* UTs for bfd_global

* support yaml for both py2/py3

* update cmd_ref doc header

* Fix python2.6 incompatibility with dict comprehensions

* Fix bfd_global doc header (yaml syntax fail)

* more shippable fixes

* yet more shippable fixes

* shippable: remove r' ' wrappers

* docfix - remove ':'

* escape regex ctl chars in yaml table

* remove extra blank lines

* Fix str(None) issue

* Command context updates

* import PY2,PY3 instead of import sys

* fix ordereddict import & parent_context

* try/except for yaml import

* fix import issue for ordereddict

* remove epdb

* nxosCmdRef_import_check() workaround for shippable

* fix PEP ws errors
2019-06-06 15:52:55 +05:30
Ondra Machacek
d88739367e ovirt: Resolve also list of hrefs (#57299) 2019-06-06 10:58:26 +02:00
Marcus Watkins
6e94b472e8 Fix #56640: Map k8s ansible keys to api keys (#57418)
* Fix #56643: Map ansible keys to api keys

* Remove errant print line

* Fix pep8 issue

* Fix doc line

* Added test for validate_certs -> verify_ssl translation for k8s module
2019-06-06 18:51:23 +10:00
Martin Nečas
8a02901e5f ovirt vmpool fix (#57453) 2019-06-06 04:30:30 -04:00
Ian Wienand
6f06fc9945 openssh_keypair: make fingerprint result a string (#57295)
The extant documentation says that the fingerprint return value is a
single string, but it is currently being returned as a split list.
Convert the returned value to a string as documented, and add some
basic test-case coverage for the return values.
2019-06-06 07:58:50 +02:00
smile37773
c6097a268c rename modules azure_rm_..._facts to azure_rm_..._info (#57395) 2019-06-06 12:10:27 +08:00
Mike Wiebe
7c73dd3e78 nxos_install_os: Fix nxapi local failures (#55993)
* Fix nxapi failures

* Remove logit debug calls

* Remove msg_timestamps

* Fix code alignment issue
2019-06-06 09:35:08 +05:30
Mike Wiebe
1dc3fe5317 Add new logging facilties defaults (#57144) 2019-06-06 09:34:30 +05:30
Simon Dodsley
1637aeea29 Make purefa_pgsnap module handle its own exit correctly (#56954) 2019-06-05 18:07:39 -04:00
Matt Clay
a05be890ad Fix podman_image_info parsing of podman output.
Stripping the output from `podman image ls -q` prevents passing
a blank image ID to `podman image inspect`, which would fail.
2019-06-05 14:31:11 -07:00
Andrey Klychkov
ea9a0f36f3 postgresql_table: 57352 bugfix, add schema handling (#57391)
* 57352 bugfix, add schema handling

* 57352 bugfix, added a changelog fragment

* 57352 bugfix, added tests for rename

* 57352 bugfix, fixed tests

* 57352 bugfix, fixed typos, cosmetic changes
2019-06-05 15:06:23 -04:00
jelle van der Waa
7a3914bd8b Support --valid_pgpkeys option in Git module ()
PR #55396

Make Git module support `--valid-pgpkeys` option, which allows
configuring a list of valid PGP fingerprints which are compared with the
used PGP fingerprint if verify_commit is true. This requires
verify_commit to be set to 'yes'.

Signed-off-by: Jelle van der Waa <jelle@vdwaa.nl>
Co-authored-by: Sviatoslav Sydorenko <webknjaz@redhat.com>
2019-06-05 20:18:37 +02:00
xuxiaowei0512
05e6339c49 option is marked as required but specifies a default (#57257)
* required and default are conflicting
2019-06-05 10:43:45 -04:00
xuxiaowei0512
229d20b6d9 update ce_facts (#57187) 2019-06-05 10:42:13 -04:00
xuxiaowei0512
9c3ae4c1f4 update lib/ansible/plugins/action/ce.py to fix a bug. (#57183)
* update lib/ansible/plugins/action/ce.py
2019-06-05 10:41:33 -04:00
Kevin Breit
919f70c357 New module - meraki_malware (#56929)
* Initial commit for meraki_malware module
- Allows for manipulation of malware configuration

* Add full documentation and improve code coverage

* Add diff support

* Type change

* Sanity check fixes

* Convert org_id from str to int for consistency

* Sanity fixes again

* Fix argument type errors

* Remove ignore items for some Meraki modules so shippable is happy
2019-06-05 10:36:39 -04:00
Kevin Breit
8bcf9b5734 meraki_network - Restructure execution logic (#56818)
* Restructure meraki_network to be simpler and work for all int tests

* Enable all integration tests and enhance error reports

* Slight tweaks to integration tests
2019-06-05 10:33:55 -04:00
Daniel Mellado Area
091bebcbf7 Add support for vlan update on ovs bridges (#57168)
This commit adds support for vlan update on openvswitch_bridge module.
2019-06-05 10:32:14 -04:00
Kevin Breit
72f2d05b6f meraki_content_filtering - Enable check mode (#54638)
* Add support for check mode.

* Add diff support
- Need to analyze diff for accuracy
- Updated check mode changed value

* Improve test coverage

* Remove a duplicate integration test
2019-06-05 10:31:50 -04:00
Kevin Breit
6da2d40500 meraki_admin - Enable check mode (#54499)
* Add support for check mode

* Add changelog fragment

* Add diff support
- Fix a few changed status
- Removed auth_key check since that's done in module_utils now
2019-06-05 10:23:54 -04:00
Ed Costello
30aeab4709 Make aws_ses_identity module work when region is provided via environment or config. (#51627)
fixes #51531
2019-06-05 09:51:58 -04:00
Martin Krizek
46f8bd47ce file: return 'useful' error message for recursion error (#57222)
* file: return 'useful' error message for recursion error

Fixes #56397

* Fix line length

* Re-phrase the error message
2019-06-05 09:30:09 -04:00
Martin Krizek
18f2ed63e0
file: fix setting relative paths for src for hard links (#56055) 2019-06-05 15:26:40 +02:00
Martin Krizek
705d0201cf
file: fix setting attributes for symlinked file (#57217) 2019-06-05 15:25:43 +02:00
Fred-sun
206f18dcca Update azure_rm_mysqlserver related document (#57382) 2019-06-05 09:10:12 -04:00
Fred-sun
9b6a295ca5 Update azure_rm_mysqlfirewallrule related document (#57384) 2019-06-05 09:08:53 -04:00
Martin Nečas
6e9eac74f0 ovirt vmpools creating vm options (#55815)
* ovirt vm pools add vm vars

* remove cloud init persist

* ovirt vm pools add nics

* ovirt vm pools add vm docs

* ovirt vm pools update docs

* ovirt vm pools update cloud_init docs

* update ovirt_vm_pools docs

* correct ovirt vm pools version_added
2019-06-05 03:27:27 -04:00
Jordan Borean
b5b75daaa5
win_chocolatey - honour version when bootstrapping chocolatey and fix package listing (#57208)
* win_chocolatey - honour version when bootstrapping chocolatey

* skip upgrade all step

* Fix install latest step

* Remove test changes now that Chocolatey is released

* tweak the package version detection
2019-06-05 09:10:10 +10:00
James Cassell
1fb0335243 group_chars: default change warning only when needed 2019-06-04 14:04:17 -07:00
Abhijeet Kasurde
b8b0a2a20c aws: Update description for iam_role (#57346)
If IAM Role is created without description using aws cli or UI,
then Ansible failed to update description for such IAM role.
This fixes such condition.

Fixes: #52942

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-06-04 11:52:03 -07:00
Chris Archibald
57b3160f13 new feature (#57320) 2019-06-04 13:57:54 -04:00
dw
3fadf4a1cb Fix file descriptor leak in lineinfile module. (#57328) 2019-06-04 12:45:19 -04:00
Fred-sun
1ddb37cdc2 Update azure_rm_mariadbserver related document (#57333) 2019-06-04 11:41:26 -04:00
Nick Dokos
22b45f2c06 Clarify description of 'state' in the package module (#57241) 2019-06-04 09:45:49 -04:00
Fred-sun
2cb3094b68 Update azure_rm_mysqlconfiguration related document (#57335) 2019-06-04 09:41:00 -04:00
Fred-sun
15034fb5b5 Update azure_rm_mysqldatabase related document (#57338) 2019-06-04 09:37:22 -04:00
Abhijeet Kasurde
ee8a607cca ipaddr: Handle network address in ipmath (#57149)
* Updated testcase, documentation

Fixes: #54457

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-06-04 14:01:18 +05:30
Sumit Jaiswal
e620e27609
PR to fix the bug 57215 & 56300 under Nios Host_Record module (#57221)
* fix bug 57215 & 56300

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* fix bug 57215 & 56300

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* shippable error fix

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* review comment fix

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
2019-06-04 10:52:16 +05:30
Sandeep Kasargod
78f6a7cbb1 New module for managing export groups in Vexata storage arrays. (#55481)
* Vexata export group module.
* Fix messages / error handling paths.
2019-06-04 10:05:40 +05:30
Chris Van Heuveln
6bb13bbb84 nxos_vlan: fix broken purge behavior (issue #57101) (#57229)
* nxos_vlan: fix broken purge behavior (issue #57101)

Symptoms/Analysis:
- `nxos_vlan` `purge: true` would fail when `purge` was trying to delete all unspecified vlans, including vlan 1.
- `nxos` devices do not allow removing vlan 1 and raise a cli exception error
- Previous fix #55144 caused a side effect when `purge` was used: vlan changes specified by `aggregate` were ignored; e.g.
 - vlan 4 is not present; playbook specifies `aggregate: { vlan: 4 }, purge: true`
 - results in proper purging but vlan 4 is not created

Solutions:
- ignore vlan 1 when purging
- remove the `not purge` check from state present logic

Added additional unit tests and integration tests.
Tested against all regression platforms.

* PEP fixes

* Add agg_show_vlan_brief.txt fixture

* Add warning for removing vlan 1

* change method name check
2019-06-04 09:14:09 +05:30
Aaron Smith
333f54ec3b cloud/amazon/aws_config_recorder: add empty resourceTypes list if undefined (#50286) 2019-06-03 15:45:38 -07:00
Mikhail Naletov
8cf6f56a01 Added sort option for zabbix_screen module (#56237)
* Added sort option for zabbix_screen module

* FIX: sort variable

* Added changelog file

* Fixed misspelling

* Update lib/ansible/modules/monitoring/zabbix/zabbix_screen.py

Changed spelling in the documentation

Co-Authored-By: flowerysong <junk+github@flowerysong.com>
2019-06-03 21:23:20 +02:00
Felix Fontein
7b40b569b2
Rename memset_*_facts to memset_*_info (#57030)
* Rename memset_*_facts to memset_*_info

* Add changelog.
2019-06-03 21:19:49 +02:00
Stefan Horning
ddfaa83ccf s3_bucket: add encryption capabilities to the module (#55985)
* s3_bucket: add encryption capabilities to the module
2019-06-03 11:25:09 -07:00
Fred-sun
3587f346c0 Update azre_rm_mariadbfirewallrule related document (#57288) 2019-06-03 12:51:02 -05:00
Fred-sun
ceb91ef80a Update azure_rm_mariadbdatabase relate document (#57287) 2019-06-03 12:49:38 -05:00
Martin Nečas
ea939c7e3e ovirt vnic profile update readme (#57298)
removes second of two identical examples
2019-06-03 11:35:10 -05:00
Piotr Gbyliczek
ec511e84bc Update azure_rm_appgateway.py (#56780)
* Update azure_rm_appgateway.py documentation to explain the dependency of authentication_certificates on cookie_based_affinity being enabled
2019-06-03 10:44:15 -05:00
Fred-sun
2d5c9e06fa Update azure_rm_manageddisk related document (#57206)
* Update azure_rm_manageddisk related documentation
2019-06-03 10:32:02 -05:00
Abhijeet Kasurde
0f10c4e8d2 aws: Handle exceptions while describing metric alarm (#57304)
Handle exceptions raised while describing the metric alarms rather than
printing tracebacks.

Fixes: #55786

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-06-03 11:23:53 -04:00
schowave
e6166b40cc Fixes typo in get_url (#57305)
Fixes Typo, need instead of ned
2019-06-03 20:36:48 +05:30
Fred-sun
6306f18fc3 Update azure_rm_loganalyticsworkspace related module document (#57158)
* Update azure_rm_loganalyticsworkspace related module documentation
2019-06-03 10:05:20 -05:00
Marcello Barnaba
0e25f8aef2 Add find module patterns option use cases documentation (#57089)
* Specify that the pattern is matched against the dirent basename
* Specify that regexen must match the whole name of the dirent. It has been a pitfall for me.
2019-06-03 10:00:15 -05:00
Andrey Klychkov
86be0985ce removed_module func: removed extra spaces from msg and docstring (#57209) 2019-06-03 10:00:19 -04:00
Sam Doran
2e0229a4b6 ansible-vault: convert vault_password_files to list to prevent traceback (#57186)
* Convert vault_password_files to a list

* Add changelog and tests
2019-06-03 12:14:06 +02:00
Sloane Hertel
21cd24a0dd improve conditional warnings (#57190)
* Fix order for warning on templated conditionals

Fix bare variable warnings when the variable is a boolean

* changelog

* Add tests for cases that should and should not give warnings

If the behavior may change when the default behavior for CONDITIONAL_BARE_VARS becomes False there should be a warning. Boolean type conditionals will not change in behavior so don't warn.

* oops, forgot to add files

* typo
2019-06-03 12:12:32 +02:00
Andrey Klychkov
fecffea370 postgresql_db: add note to doc about pg_dump (#57297)
* postgresql_db: add note to doc about pg_dump

* Update lib/ansible/modules/database/postgresql/postgresql_db.py

Co-Authored-By: Abhijeet Kasurde <akasurde@redhat.com>
2019-06-03 05:19:06 -04:00
Andrey Klychkov
96bf243265 New module postgresql_copy: copy data between a file and a table (#56835)
* New module postgresql_copy

* New module postgresql_copy: added tests

* New module postgresql_copy: changed tests

* New module postgresql_copy: doc format fixes

* New module postgresql_copy: fixes

* New module postgresql_copy: added upper, PostgreSQL

* New module postgresql_copy: fixed description

* New module postgresql_copy: added note about superuser

* New module postgresql_copy: remove SQLParseError

* New module postgresql_copy: fixed opt_need_quotes type

* New module postgresql_copy: fixed check_mode

* New module postgresql_copy: small fix
2019-06-03 19:11:50 +10:00
René Moser
0c66a5d3ca
cloudcscale_floating_ip: add types (#56924) 2019-06-03 10:43:32 +02:00
rajaspachipulusu17
6b2688245e Pluribus Networks ipv6security raguard port module with UT (#57033)
* Pluribus Networks ipv6security raguard port module with UT

* Dox fix
2019-06-03 11:44:28 +05:30
rajaspachipulusu17
b8a317c527 Pluribus Networks vrouter packet relay module with UT (#57155)
* Pluribus Networks vrouter packet relay module with UT

* Doc fix
2019-06-03 11:43:29 +05:30
Felix Fontein
b33c9dad40 Improve docs w.r.t. networks_cli_compatible. (#56971) 2019-06-02 23:38:21 -04:00
Dodge245
012609b09a VMware: Update doc for num_cpus and num_cpu_cores_per_socket calculation (#57227)
Updated document to explain num_cpus is multiple num_cpu_cores_per_socket.
2019-06-02 17:39:33 +05:30
Abhijeet Kasurde
c8eda7773e
VMware: Update vmware_guest_powerstate (#57000)
* Updated documentation
* Updated testcases
* Updated example
* Updated logic
* Provided option to specify task name, task description, task enable status etc.

Fixes: #56987

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-06-01 08:10:05 +05:30
Fabrice
7364e79c0d k8s: Fix .to_dict not needed (#56147)
* k8s: Fix .to_dict not needed

* Add changelog fragment
2019-06-01 11:42:48 +10:00
Matt Martz
8bd4e2a144 cert validation fixes - Attempt 2 (#55953)
* Attempt 2 of cert validation fixes

* Remove unused code

* Cleanup the tmp cert using atexit

* Fix linting issues

* Only add SSLValidationHandler when not HAS_SSLCONTEXT

* Catch value errors on non PEM certs

* Only catch NotImplementedError to avoid masking issues

* set self._context even with PyOpenSSLContext for conformity

* Fix error building

* normalize how we interact with the context we create

* Remove unused code

* Address test for py3.7 message difference

* open_url should pass the ca_path through

* Account for new error in url lookup test

* Guard some code behind whether or not we are validating certs

* Make _make_context public

* Move atexit.register up to where the tmp file is created
2019-05-31 16:35:25 -04:00
Paddy Newman
2ef7759be1 Allow syslog_json callback options to be set in an Ansible configurat… (#57232)
* Allow syslog_json callback options to be set in an Ansible configuration file.

The syslog_json documentation says that it supports options via an Ansible
configuration file. In fact, they can only be specified via environment
variables.

I've updated the module to use the standard "get_options" handling which means
that it can now support options via environment variables *or* the
configuration file.

Options can be set in the configuration file as follows:

```
callback_whitelist = syslog_json

[callback_syslog_json]
syslog_server = localhost
syslog_port = 514
syslog_facility = user
```

* Use the original, documented, names for the modules options.

In the documentation text change syslog_server to server, syslog_port to port
and syslog_facility to facility.

* Add an item to the changelog.

* Update 57232-syslog-json-configuration-options.yml

Fix a YAML syntax error / typo.
2019-05-31 14:29:15 -04:00
Dag Wieers
fd95c7b506 Fix CI issue 2019-05-31 14:12:20 -04:00
Julian Paul Dasmarinas
e1d0795aa3 beadm: Make creation of boot environments in snapshot format idempotent 2019-05-31 14:12:20 -04:00
Andrew Klaus
d8bf4f1ebb Adding support for OpenBSD syspatch (#55561)
* Initial commit

* Fixing issue where applying always returned changed status

* Adding return variables: reboot_needed, rc, stderr, stdout, warnings
2019-05-31 13:42:01 -04:00
Nathaniel Case
4142cd595e
Plugin paths need to be sent in exectutor, too (#57126)
* Combine `_start_connection` methods into executor
2019-05-31 11:44:42 -04:00
Rohit
ae033f1ec3
vyos interfacefix and test cases (#57169)
Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>
2019-05-31 16:13:40 +05:30
Sebastiaan Mannem
223f509ea3 Issue 56430 (#57147)
* Adding integration test for 127.0.0.1/32 and ::1/128.

* Making sure file is not corrupted when render fails

* Fixes #56430

* Adding changelog for MR 57147/Issue 56430
2019-05-31 12:32:28 +02:00
Fred-sun
94b711bac5 Update azure_rm_mariadbconfiguration related document (#57207) 2019-05-31 13:46:08 +08:00
Fred-sun
3ef09496a3 Update azure_rm_hdinsightcluster related document (#57037)
* Update azure_rm_hdinsightcluster related documentation
2019-05-30 10:34:38 -05:00
Ondra Machacek
6bceea4f51 kubevirt: Rewrite merge dict method 2019-05-30 07:41:21 -07:00
Richlv
94e2d87b2f suggest to use sequential IDs (#57142)
##### SUMMARY
Suggest to use sequential IDs - otherwise action is considered to be changed always.


##### ISSUE TYPE
- Docs Pull Request

+label: docsite_pr
2019-05-30 10:39:59 -04:00
Fred-sun
42acf740e4 Update azure_rm_loadbalancer relate module document (#57154) 2019-05-30 10:37:51 -04:00
Fred-sun
511c385da6 Update azure_rm_functionapp related document (#56985)
* Update azure_rm_functionapp related documentation
2019-05-30 09:33:11 -05:00
Fred-sun
df442751f7 Update azure_rm_dnszone related document (#56984)
*  Update azure_rm_dnszone related documentation
2019-05-30 09:31:12 -05:00
Fred-sun
a7e53906a6 Update azure_rm_dnsrecordset relate document (#56895)
* Update azure_rm_dnsrecordset related documentation
2019-05-30 09:25:16 -05:00
Mariusz Mazur
cac34ac568 kubevirt_pvc: improve failure handling (#57163) 2019-05-30 05:14:27 -04:00
Tim Hunter
4c00fc7b32 update pkg_mgr.py for Amazon Linux support (#56618) 2019-05-30 10:18:31 +02:00
Kevin Breit
5008e1d479 meraki_config_template - Enable check mode (#54502)
* Add support for check mode

* Check mode returns proper changed status
- Added is_template_valid()
- Restructured check_mode so it will always return data
- Check mode should show proper changed status
- Code is untested and integration tests need to be expanded

* Fix deleting networks
- Add integration tests for deleting networks
- Refine tests based on changed/unchanged

* Remove one task from integration test
2019-05-29 16:30:26 -04:00
Kevin Breit
4df53f869e meraki_network - Add support for disableRemoteStatusPage (#48971)
* Add support for disableRemoteStatusPage
- New feature in the Meraki API
- Yes, it's a double negative, I may fix at some point

* Remove double negative
- All disables became enable and logic is reversed
- This isn't yet tested

* Switching computers!!!

* Apply changes to make the logic work, even reversed

* Attempt to fix some formatting errors

* Add documentation fragment

* Fix whitespace

* Add disable_my_meraki back, with deprecation notice

* Edit changelog notice

* Update deprecation version

* Update example to be a block and change deprecation message.

* Remove duplicate delegate_to

* Change deprecation notice.
2019-05-29 16:29:40 -04:00
Kevin Backhouse
79bb7bde5f apt_repository: Fix crash caused by cache.update() raising an IOError on timeout. (#51996)
* Fix crash caused by cache.update() raising an IOError on timeout.

* Add changelog fragment.
2019-05-29 15:59:51 -04:00
Felix Fontein
c47e9d22b4
Rename one_image_facts -> one_image_info (#57035)
* Rename one_image_facts -> one_image_info.

* Add changelog.

* Forgot symlink.
2019-05-29 21:23:25 +02:00
Fred-sun
ba18dd713a Update document related with azure_rm_keyvault module (#57110) 2019-05-29 14:15:36 -05:00
Fred-sun
163d3efbf8 Update azure_rm_image relate document (#57043) 2019-05-29 14:12:36 -05:00
szymon3
00067c8d54 Update rabbitmq_queue.py (#56912)
change description for when `state=absent`
2019-05-29 13:57:05 -05:00
Ian Wienand
39945b8570 Make query with errors='ignore' return a blank list (#57038)
The jinja2 query() function (or lookup with wantslist=True, which is
the same thing) should always return a list.

However, if you combine a query with errors='ignore' and take the
error path, the current code returns a None value.  This is important
in a case such as

 - name: Conditional include file
   import_tasks: '{{ item }}'
   vars:
     params:
       files:
         - path/file1.yaml
         - path/file2.yaml
   loop: "{{ q('first_found', params, errors='ignore') }}"

If neither file1.yaml or file2.yaml exist, this should do nothing by
returning an empty list to the loop.  Currently if you run the above
task you'll get a rather unhelpful:

 Invalid data passed to 'loop', it requires a list, got this instead: .

This change ensures that when a query ignores an error, it returns a
empty list.  The errors='ignore' case is tested in several variants
with first_found.  The extant (but deprecated) "skip: True" for
first_found doesn't seem to be explicitly tested; a test is added here
to avoid regressions before removal in 2.12.

This fixes a regression you'll hit if you follow the suggestion in the
deprecation message included with
e17a2b502d to use errors=ignore over
"skip: True" for first_found.  This change adds an example that points
out the query/lookup difference and also fixes the error message to
not mention the now deprecated "skip: True".

Closes #56775
2019-05-29 13:23:02 -04:00
xuxiaowei0512
b7f4e2a190 update ospf modules to fix bugs as software version changes (#56974) 2019-05-29 12:40:30 -04:00
xuxiaowei0512
0137c4343b update ce_ntp.py and remove the root tag name to find all nodes (#56976)
* add a maintainer

* update ce_ntp.py and remove the root tag name to find all node

* update ce_ntp.py and remove the root tag name to find all node
2019-05-29 12:39:37 -04:00
xuxiaowei0512
9e1f184b2d add terminal initial prompt for initial connection (#57057) 2019-05-29 12:37:13 -04:00
Pilou
e5b2e4c1ac tower_credential: ssh_key_data isn't a path anymore (#57113) 2019-05-29 11:15:45 -05:00
Fred-sun
8043940c93 Update azure_rm_devtestlabvirtualmachine relate document (#56828)
* Update azure_rm_devtestlabvirtualmachine documentation
2019-05-29 11:03:42 -05:00
Kevin Breit
7864df8cb9 meraki - Rewrite update requirement check (#48394)
* Rewrite idempotency check
- Check now operates recursively and works on multiple types
- Order of lists matter

* Remove blank line for lint

* Fixed idempotency checks in meraki_ssid
- New sanitize() method for finding keys unique in compared dicts
- Fixed bug in meraki_ssid where SSID specified by number breaks
  - This will require a backport
- Converted ignored_keys from tuple to list

* Made changes required for idempotency

* Add changelog fragment

* Add unidirectional option for testing

* Disable option 1 check

* General fixes for is_update_required testing
- Added commented out debug statements in method
- Fixed ignored_keys modifications

* Remove old commented algorithm
2019-05-29 10:18:01 -04:00
Kevin Breit
57e1063fc7 meraki_config_template - Remove mandatory network lookup (#56525)
* Module only makes network lookups when needed instead of every execution

* Formatting fixes
2019-05-29 19:27:38 +05:30
Rohit
b143918f30
text format fan info mismatch and module info check (#57009)
Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>
2019-05-29 19:08:46 +05:30
MyronFanQiu
a56a9e1eeb switch the deletion order (#57102) 2019-05-29 17:11:54 +08:00
Abhijeet Kasurde
2cf1dfc415 Fixed misc typos (#57103)
* Changed immuteable to immutable
* Changed conig to config

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-05-29 08:56:05 +02:00
Daniel Mellado Area
0ada6b8d8d Fix junos_facts test (#57065)
This commit fixes a non-passing junos_facts integration test, as it was
using a non-ordered frozenset to assert its result.
2019-05-28 20:25:45 -04:00
ShachafGoldstein
486370a744 Fix win_iis_virtualdirectory to remove a virtual directory that contains children (#56569)
* FIX #49755

* Added changelog fragment

* Changes according to review

* Fixed changelog
2019-05-29 05:59:50 +10:00
ShachafGoldstein
4490c0ba51 correct behaviour of win_iis when using site_id if site not found (#56567)
* Fixed #47057

* Fix trailing whitespace

* Change for review
2019-05-29 05:31:00 +10:00
ShachafGoldstein
94566ed79c Win_hostname module: Change name check to WMI (#56420)
* Change name check to WMI

* Changelog fragment

* Fixed per review
2019-05-29 05:30:16 +10:00
Ilya Zonov
35c8739c2a Add full change check for rabbitmq policy (#19073)
Add check for all policy fields (name, apply_to, pattern, tags,
priority) to have correct changed state. Previosly changed state was
based on policy name only.

* Add support for rabbitmq 3.7
* Fix exec args for rabbitmqctl status
* Add changelog and fix description for Ansible 2.9
2019-05-28 15:06:06 -04:00
Tyler Hartley
1d22909f7c Make second group match of ufw status output optional (#56678)
* Make second group match of ufw status output optional

Fixes #56674

* Fix comparison logic.

* Add changelog fragment
2019-05-28 20:54:11 +02:00
Felix Fontein
86928a5f74
docker_image: fix module failing when build option is used without specifying path (#56940)
* Fix module failing when build option is used without specifying path.

* Add changelog.
2019-05-28 20:48:08 +02:00
Felix Fontein
56e2d48612
docker_image: fix default handling of old docker-build options nocache and rm (#56610)
* Fix usage of nocache parameter.

* Fix defaults.

* Add changelog.
2019-05-28 20:47:31 +02:00
Nathaniel Case
1b66a13186
Fix flow in eos_l2_interface (#57059)
* Also fix test debug labels
2019-05-28 14:06:57 -04:00
Matt Williams
cf00883c9d Return results even when the cache is disabled (#55505)
* Return results even when the cache is disabled

By default the cache is disabled and so the results of the API call
are not placed in there for the return statement to fetch.

* Always update self._cache to return
2019-05-28 13:44:00 -04:00
The Magician
a837cc5694 Bug fixes for GCP modules (#55976) 2019-05-28 13:43:19 -04:00
The Magician
713ac29054 Bug fixes for GCP modules (#56689) 2019-05-28 13:42:12 -04:00
The Magician
0ff62fd5c4 Bug fixes for GCP modules (#56764) 2019-05-28 13:41:51 -04:00
The Magician
70ac35da3e Bug fixes for GCP modules (#56765) 2019-05-28 13:41:36 -04:00
The Magician
2220b9c851 Bug fixes for GCP modules (#56766) 2019-05-28 13:41:19 -04:00
Paul Belanger
532de89b44
Fix exception with load_provider function (#56959)
It is possible for provider.authorize to exist, but set to None. Rather
then loading this value blindly, assume the default is False.

   File "/home/zuul/src/github.com/ansible/ansible/lib/ansible/executor/task_executor.py", line 145, in run
     res = self._execute()
   File "/home/zuul/src/github.com/ansible/ansible/lib/ansible/executor/task_executor.py", line 635, in _execute
     result = self._handler.run(task_vars=variables)
   File "/home/zuul/src/github.com/ansible/ansible/lib/ansible/plugins/action/ios.py", line 50, in run
     provider = load_provider(ios_provider_spec, self._task.args)
   File "/home/zuul/src/github.com/ansible/ansible/lib/ansible/module_utils/network/common/utils.py", line 424, in load_provider
     provider['authorize'] = boolean(provider['authorize'])
   File "/home/zuul/src/github.com/ansible/ansible/lib/ansible/module_utils/parsing/convert_bool.py", line 26, in boolean
     raise TypeError("The value '%s' is not a valid boolean.  Valid booleans include: %s" % (to_text(value), ', '.join(repr(i) for i in BOOLEANS)))

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2019-05-28 12:19:34 -04:00