Commit graph

544 commits

Author SHA1 Message Date
Brian Coca
94e66cb108 fixes to assemble
now uses atomic move to avoid data corruption
correclty cleans up temp files in every case
returns backup_file info if needed
validate validate before temp file gets created
backup AFTER validate
2016-03-08 10:38:23 -05:00
Toshio Kuratomi
2920658776 Change one param to be of type path 2016-02-29 00:33:34 -08:00
Toshio Kuratomi
832e81e691 Set some module parameters to type=path 2016-02-29 00:21:02 -08:00
Toshio Kuratomi
a7cfa1c8cd Correct dest_port to be of type int 2016-02-29 00:13:21 -08:00
Toshio Kuratomi
cfbe65f8c8 Set name to type path so that tilde and env vars are expanded 2016-02-28 23:46:40 -08:00
Brian Coca
c50ca43d8d fixed typo, now correctly check isdir
fixes #3089
2016-02-22 12:36:37 -05:00
Brian Coca
ab4c542b33 added missing checksum alias 2016-02-22 12:36:37 -05:00
Brian Coca
cefdb9a494 Merge pull request #2896 from towolf/add_diff_to_lineinfile
Add diff to lineinfile.py for both file contents and file attributes
2016-02-18 05:35:17 -08:00
Brian Coca
81b827f869 fixed option name mismatch, added aliases
also removed empty aliases
2016-02-15 17:13:46 -05:00
Brian Coca
8c2ef29a7a added follow to specific modules that support it
was removed from common file docs
2016-02-15 14:14:56 -05:00
Jose Moreira
cb712f2ba8 Fixed module doc typos 2016-02-15 15:03:40 +00:00
Brian Coca
191bf977f7 Merge pull request #3042 from lgp171188/patch-1
Fix typo in the copy module error message
2016-02-15 08:16:03 -05:00
Brian Coca
238c26c7e2 recursive copy is not available(yet) on remote_src 2016-02-15 08:16:17 -05:00
Guruprasad
ea6c2573e3 Fix typo in the copy module error message
Fix the typos in the error message shown on trying to use remote_src=yes for copying directories
2016-02-15 16:22:29 +05:30
Brian Coca
b89f4c7cab cleaner error on recursive remote copy
TODO: add recursive copy support when remote_src=yes
probably need to make shared the logic in the action plugin.
2016-02-12 22:38:16 -05:00
Brian Coca
6a42e54e57 removed 'overquoting' of example
fixes #3029
2016-02-12 13:24:07 -05:00
Toshio Kuratomi
93d02189f6 Remove duplicate documentation fields 2016-01-28 09:24:20 -08:00
Tobias Wolf
99ba594f0a Add diff for both file contents and file attributes to lineinfile
Using the difflist feature added in ansible/ansible@c337293 we can add
two diffs to the `diff` dict returned as JSON: A `before` and `after` pair of
changed file contents and the diff of the file attributes.

n.b.: the difflist handling from the above commit is logically broken.
PR will follow.

Example output:

    TASK [change line and mode] ************************************************************
    changed: [localhost]
    --- before: /tmp/sshd_config (content)
    +++ after: /tmp/sshd_config (content)
    @@ -65,21 +65,21 @@
     X11DisplayOffset 10
     PrintMotd no
     PrintLastLog yes
     TCPKeepAlive yes
     #UseLogin no

     #MaxStartups 10:30:60
     #Banner /etc/issue.net

     # Allow client to pass locale environment variables
    -AcceptEnv LANG LC_*
    +AcceptEnv        LANG LC_* GF_ENV_*

     Subsystem sftp /usr/lib/openssh/sftp-server

     # Set this to 'yes' to enable PAM authentication, account processing,
     # and session processing. If this is enabled, PAM authentication will
     # be allowed through the ChallengeResponseAuthentication and
     # PasswordAuthentication.  Depending on your PAM configuration,
     # PAM authentication via ChallengeResponseAuthentication may bypass
     # the setting of "PermitRootLogin without-password".
     # If you just want the PAM account and session checks to run without

    --- before: /tmp/sshd_config (file attributes)
    +++ after: /tmp/sshd_config (file attributes)
    @@ -1,3 +1,3 @@
     {
    -    "mode": "0700"
    +    "mode": "0644"
     }
2016-01-27 12:36:11 +01:00
Toshio Kuratomi
c8d5fdaf27 Merge pull request #2891 from ansible/synchronize-better-error-missing-rsync
Better error message when rsync nad ssh aren't present where synchronize is run
2016-01-26 11:36:29 -08:00
Toshio Kuratomi
cb1fefdf92 Better error message when rsync nad ssh aren't present where synchronize is run
Fixes https://github.com/ansible/ansible/issues/9305
2016-01-26 09:43:38 -08:00
Brian Coca
3239691e9e Merge pull request #2870 from towolf/add_diff_to_synchronize
Add custom diff field to synchronize module
2016-01-26 10:09:20 -05:00
Tobias Wolf
cd3b9366fe Add custom or 'prepared' diff field to synchronize module
This PR depends on pull requeest ansible/ansible#14105

rsync has a custom diff output that cannot easily be expressed as
`/usr/bin/diff before after`
2016-01-26 09:34:25 +01:00
Toshio Kuratomi
d9e29752c1 Add an internal param instructing synchronize to replace localhost with the host that's being ssh'd from 2016-01-25 16:46:44 -08:00
Matt Martz
76925ef613 Merge pull request #2858 from sivel/issue/14064
Add note about precautions of using become with fetch
2016-01-22 11:35:22 -06:00
Matt Martz
3f232beb0a Add note about precautions of using become with fetch. Addresses https://github.com/ansible/ansible/issues/14064 2016-01-22 11:29:35 -06:00
Toshio Kuratomi
0b7469fa90 Fix documentation build 2016-01-21 08:37:15 -08:00
Toshio Kuratomi
76a478a226 Document that synchronize in 2.0.0.x has broken sudo behaviour.
Part of the changes for #13825
2016-01-21 08:24:33 -08:00
Toshio Kuratomi
78b4eac6fc Merge pull request #2722 from mscherer/fix_2630
Fix 2630
2016-01-11 11:37:34 -08:00
Brian Coca
48bd80c9cb adds diff info for file info 2016-01-05 14:52:54 -05:00
Michael Scherer
948900f7fb Fix doc inconsistency (#2630) 2015-12-22 15:22:17 +01:00
Brian Coca
f500a2ec53 added mime option to stat module
it uses file magic to now return mime_type and charset of a file as
per output of `file -i /path`
2015-12-14 21:18:13 -05:00
Adam Fields
27f561dca2 added a reference to the template module for clarity 2015-12-10 12:45:59 -05:00
quoing
877daf970d Fix: Default ACL parameters are not correctly handled 2015-12-08 11:44:03 -08:00
Brian Coca
db66144386 simplified lowercasing 2015-12-08 11:41:32 -08:00
quoing
c93de2f930 Add "default" entry option back (removed in e95bcae), update will translate entry to standard parameters so compatibility with BDS is kept 2015-12-08 11:41:32 -08:00
Brian Coca
8a2459c643 Merge pull request #2590 from noseka1/devel
Fix ini_file module, avoid bracklets in key break idempotence
2015-12-02 20:44:59 -08:00
Ales Nosek
9c74272c9b Fix #2475 ini_file module: bracklets in key break idempotence
Escape the regex special characters in the option name.
2015-12-02 20:31:27 -08:00
krdlab
61a3625ed0 Fix 'stat' module document 2015-12-02 18:20:20 +09:00
Dylan Martin
bfa7cdb5c4 improved error message when no handler found 2015-11-30 11:47:38 -08:00
Brian Coca
c6fdd3809f fixed typo EEXISTS is actually EEXIST
fixes #2585
2015-11-30 07:23:29 -08:00
Brian Coca
9030ae996c Merge pull request #2569 from gerph/gerph-fix-docs-file
Update documentation for 'file' module to include 'diff_peek'.
2015-11-27 12:57:19 -08:00
Charles Ferguson
176b4103b6 Add documentation to 'file' AnsibleModule definition for internals.
The parameters 'diff_peek' and 'validate' are not expected to be used
by users. They are internal. To make it clear, this change adds the
comments 'Internal use only' to each of those definitions to make
it clear that they are actually used, just not by end-users.
2015-11-27 20:49:27 +00:00
Charles Ferguson
9325c0ae5f Update documentation for 'file' module to include 'diff_peek'.
The 'diff_peek' option isn't documented at all, and provides a
rudimentary check that the content isn't binary. Documentation is
added to explain the option.

The 'validate' option has a declaration, but isn't implemented.
Therefore it may as well be removed from the module.
2015-11-26 15:40:09 +00:00
Charles Paul
1bc0b6ee6a create non-existent ini file
fixing fail_json

more verbose fail msg
2015-11-23 23:07:14 +09:00
Maarten Claes
e9c548da41 This fixes copy with the remote_src option
It was broken in 6e37f1dcef when the remote_src was added. Need to
pass the absolute path to copy2 instead of a tuple.
2015-11-18 13:12:59 +01:00
Brian Coca
6e37f1dcef fixed remote_src support, now actually copies and does not move 2015-11-12 09:39:37 -08:00
Timothy Appnel
ca12ed5d98 Added the checksum_algo alias to the stats module. 2015-11-07 18:16:20 -05:00
Brian Coca
e74dc8c1dd minor doc fixes 2015-11-07 08:23:57 -05:00
Ales Nosek
22790d301a Make the syntax work with Python 2.4 2015-10-30 21:57:25 -07:00
Ales Nosek
7f59773460 ini_file should only change what was specified and nothing more #5860
See also:
http://alesnosek.com/blog/2015/08/03/improving-ansibles-ini-file-module/
2015-10-28 22:11:02 -07:00