Commit graph

176 commits

Author SHA1 Message Date
Michael DeHaan
a33119dede Merge pull request #4509 from mremond/gem_executable
Add executable parameter to find gem binary in gem module
2013-10-27 08:59:19 -07:00
Michael DeHaan
ce8b0944a9 Misc pep8 fixes 2013-10-19 13:03:15 -04:00
Jimmy Tang
858b3da2ae check for ubuntu distribution first 2013-10-19 14:41:00 +01:00
Michael Scherer
ee62de7887 fix distribution detection in apt_repository module, so it also work
on Mint as it work on Debian, fix #4587.

PPAs are not supported however, since that's a Ubuntu specific feature
and mint is detected as a generic distribution and use a different
codename than the Ubuntu release it is based on, which mean that apt_repository
cannot add detect and add the proper url without a better heuristic.
2013-10-19 00:57:08 +02:00
Maykel Moya
a96f75c396 Do key validation only when key is provided
key_id is optional, the previous code didn't handle the case of key_id
not specified
2013-10-17 12:04:04 +02:00
Maykel Moya
5d41d2eaa4 apt_key: Validate key_id and accept a leading '0x' 2013-10-16 20:52:18 +02:00
James Tanner
56ffd4edbb Fixes #4532 Send easy_install to get_bin_path instead of None 2013-10-15 18:15:08 -04:00
James Tanner
875a7aa020 fix indentation in easy_install module docstring 2013-10-15 12:49:43 -04:00
Mickaël Rémond
4d334b3c86 Add executable parameter to find gem binary in gem module
This is especially needed with rvm where gem binary can be in unusual locations
2013-10-15 09:08:33 +02:00
Michael DeHaan
4105af455e Merge pull request #4488 from renanivo/devel
create install_options parameter for homebrew module
2013-10-14 16:47:59 -07:00
Pedro Romano
c73d8012b4 Implement a '_get_easy_install' helper function to find the desired
'easy_install' executable, modeled on '_get_pip'
from the 'pip' module to correctly handle all combinations of explicit
executable and virtualenv.
2013-10-14 11:48:45 -04:00
Pedro Romano
1391add126 Refactor helper function '_get_pip' to handle the cases where an absolute
path explicit executable is passed to the task and to look for an explicit executable
by basename in a virtualenv if that is specified.
2013-10-14 11:48:28 -04:00
Pedro Romano
8a843e997f New module argument to specify the executable used for running 'pip'. This allows support for system installation of packages on systems with multiple installations of Python. 2013-10-14 11:48:28 -04:00
Pedro Romano
506d476d9d New module argument to specify the executable used for running 'easy_install'. This allows support for system installation of packages on systems with multiple installations of Python. 2013-10-14 11:48:27 -04:00
Pedro Romano
0f2722d761 Rename copy/pasted variables more appropriately. 2013-10-14 11:47:59 -04:00
Pedro Romano
ddcac647ff Changes examples from using Flask to some other package (Bottle was chosen) as per @mpdehaan's suggestion. 2013-10-14 11:47:59 -04:00
Jurrien Bloemen
d56db0c85a Added full path to rhnreg_ks command for working correctly with sudo. 2013-10-14 16:05:01 +02:00
Renan Ivo
ecb9b2ea0f update version_added of homebrew module 2013-10-13 15:32:51 -03:00
Renan Ivo
086da3dafc set default options value to None in homebrew module 2013-10-13 10:42:12 -03:00
Renan Ivo
d038ea2956 create install_options parameter to homebrew module 2013-10-13 10:24:07 -03:00
Jimmy Tang
878fd17bc6 This oneliner change allows apt-key to inherit the http_proxy variable.
Before this fix

  TASK: [apt_repository repo='ppa:vbernat/haproxy-1.5'] *************************
  failed: [134.226.115.202] => {"cmd": ["apt-key", "adv", "--recv-keys", "--keyserver", "keyserver.ubuntu.com", "CFFB779AADC995E4F350A060505D97A41C61B9CD"], "failed": true, "rc": 2}
  stderr: gpg: requesting key 1C61B9CD from hkp server keyserver.ubuntu.com
  gpg: no valid OpenPGP data found.
  gpg: Total number processed: 0

After the fix

  TASK: [apt_repository repo='ppa:vbernat/haproxy-1.5'] *************************
  changed: [134.226.115.202]
2013-10-11 15:19:52 +01:00
Michael DeHaan
beae21dd40 Remove examples of module antipattern of setting the choices array for boolean types. 2013-10-11 08:45:13 -04:00
Michael DeHaan
8f896a85bf Correct typo 2013-10-10 09:15:04 -04:00
Michael DeHaan
64349632c7 For values that are booleans in the module doc, the value in the doc section should be a boolean or truthiness
is engaged in the documentation formatting.  This fixes the update_cache default in the docs to the proper
value of "no"
2013-10-09 07:52:23 -04:00
Michael DeHaan
85d0ea0d5f Use explicit boolean defaults in apt module to make the code more clear. 2013-10-09 07:47:24 -04:00
Michael DeHaan
3835c2cb3a Merge pull request #4347 from sashka/devel
Remove options and protocols in source line with regex.
2013-10-07 05:55:43 -07:00
Michael DeHaan
12308c9152 Fix module formatting in the pkgutil module. 2013-10-07 08:24:02 -04:00
Alexander Saltanov
729a6f1533 Remove options and protocols in source line with regex.
Fixes #4311
2013-10-03 03:31:04 +04:00
Andy Kluger
8f43db3167 Fix for Issue #2470 - gem version string processing
This fix assumes that no sane gem version has spaces in it, so when one like that is encountered, it will get truncated at the first space.
2013-10-02 17:55:30 -04:00
Pieter Avonts
42e4d8cb30 changed deprecated channel_label attribute 2013-09-20 12:58:43 +02:00
René Moser
2e649d21af Fixed missing required package in notes. 2013-09-19 19:34:15 +02:00
James Cammarata
bb36429fa2 Merge branch 'fix/apt_repository_update_cache' of https://github.com/resmo/ansible into resmo-fix/apt_repository_update_cache 2013-09-18 12:40:39 -05:00
René Moser
cb9308a998 apt_repository: added option update_cache.
The default behavior is to update_cache if changed.

If you add more then one repo, you may not want to update cache for every repo separately.
So you can now disable update_cache with this new option e.g. update_cache=no

Updating cache can also be handled using the apt module.
2013-09-18 19:14:08 +02:00
René Moser
53d06b932a apt_repository: fix update cache after state=changed. Closes GH-4136 2013-09-18 11:47:39 +02:00
James Cammarata
a6e339fc36 Merge pull request #4138 from resmo/fix/redundant-fail-json
apt: fixed duplicate fail_json
2013-09-17 06:08:51 -07:00
Rene Moser
8c7c0833c2 apt: fixed duplicate fail_json 2013-09-17 15:05:20 +02:00
James Cammarata
d6b7c91aa9 Merge branch 'issue_3421_apt_pkg_iU' into devel 2013-09-16 06:54:05 -05:00
Michael DeHaan
4a50a76669 Merge pull request #4075 from sayap/easy_install
Locate easy_install path after (optionally) creating virtualenv.
2013-09-15 09:29:51 -07:00
James Cammarata
c48fc23d75 Use low-level package objects in the apt module to check installed state
Packages which are half-installed are not adequately represented by
the .is_installed field of the apt.package.Package object. By using the
lower-level apt_pkg.Package object (which provides the .current_state
field), we can check for a partially-installed state more accurately.

Fixes #3421
2013-09-11 23:33:59 -05:00
Hiroaki Nakamura
868620f7d0 Add an example for installing a group with the yum module. 2013-09-11 02:14:16 +09:00
Hiroaki Nakamura
80d68320f7 Fix to getchanged correctly for yum groupinstall. 2013-09-11 02:10:53 +09:00
Yap Sok Ann
6ca45d1964 Locate easy_install path after (optionally) creating virtualenv.
Without this, the first call to the easy_install module with a new virtualenv
will only create the virtualenv without installing the intended package, since
the `_is_package_installed` check will succeed as running /usr/bin/easy_install
as non-root user will return permission denied error with empty stdout.
2013-09-10 11:22:06 +08:00
James Cammarata
5a86b82cec Fixing typos in is_keyid function definition and usage
Fixes #4068
2013-09-09 17:26:44 -05:00
James Cammarata
ab21123a5c Revert "Styling: deprecation"
This reverts commit ecc2b6e742.

Fixes #4069
2013-09-09 15:17:43 -05:00
Michael DeHaan
789d08a85d Merge pull request #3942 from jocelynj/gem
Correctly handle option user_install in gem module
2013-08-27 06:00:06 -07:00
James Cammarata
25713f0b05 Minor text corrections in the yum module documentation 2013-08-24 21:46:41 -05:00
Jocelyn Jaubert
8b5d2aeef9 Correctly handle option user_install in gem module 2013-08-24 22:49:18 +02:00
Hiroaki Nakamura
949744c194 Add description and examples for the name parameter accepts a url or a local path to a rpm file. 2013-08-25 02:30:41 +09:00
James Cammarata
0caaa023e2 Cleaning up some pep8 issues in the pkgutil module 2013-08-22 20:21:02 -05:00
James Cammarata
fb23c53e3d Merge branch 'allow_wildcard_yum' of https://github.com/mscherer/ansible into mscherer-allow_wildcard_yum 2013-08-22 16:20:10 -05:00