Commit graph

1182 commits

Author SHA1 Message Date
Martin Krizek
ed027203c6 2.8: Clear 'connection related' plugin vars for next loop iteration (#59024) v2 (#59510)
* Clear 'connection related' plugin vars for next loop iteration (#59024)

Fixes #58876

(cherry picked from commit a752e2a467)

* Preserve original variables when using a loop (#59426)

Fixes #59414

(cherry picked from commit 1010363c0b)
2019-07-29 14:48:31 -07:00
Xu Yuandong
a06b3a5174 Backport/2.8/59346 ce_startup: update to fix a bug (#59520)
* update to fix a bug (#59346)


(cherry picked from commit 6ff54c546e)

* add a changelog fragment.
2019-07-29 12:38:01 -07:00
Andrey Klychkov
9d32d06104 Backport/2.8/59497 fix code formatting, remove unused imports (#59518)
* postgresql modules: fix by flake8 (#59497)

(cherry picked from commit fd35833554)

* Backport of 59497: fix code formatting, remove unused imports
2019-07-29 12:27:50 -07:00
Xu Yuandong
282cf8fd78 backport/2.8/59343 ce_mtu: update to fix bugs. (#59343) (#59515)
* ce_mtu: update to fix bugs. (#59343)

* update to fix bug.

* Update ce_mtu.py

* Update ce_mtu.py

* Update ce_mtu.py

(cherry picked from commit 93265bf92e)

* add a changelog fragment to PR 59515.
2019-07-29 12:26:54 -07:00
Xu Yuandong
65c6306f37 Backport/2.8/59345 ce_rollback: shouldn't load xml configure via network_cli. (#59445)
* update to fix bugs.

(cherry picked from commit 657ff644ca)

* add a changelog fragment.
2019-07-29 12:07:47 -07:00
Xu Yuandong
4b81be97fa Backport/2.8/59344 ce_ntp_auth: update to fix "state is present but all of the following are missing: pas… (#59437)
* update to "state is present but all of the following are missing: password" bug

(cherry picked from commit 661b009f36)

* add a changelog fragment.

* update changelog fragment: section "bugfixes" list items must be type str not dict.

* update
2019-07-29 12:06:53 -07:00
Martin Nečas
5410128801 Ovirt host event log backport (#59432)
* Ovirt host event log (#57935)

* host event log init

* show more events

* add time check

* correct pep8 syntax

* use event id as first elem

* init start event in constr

* update pep8 syntax

* remove precreate

* add changelog
2019-07-29 12:05:22 -07:00
Ganesh Nalawade
9a3dc5f798 Fix netconf connection command timeout issue (#58322)
*  ncclient uses same timeout value at the time
   of connection initialisation and waiting response
*  Ansible has connect_timeout to control the waiting
   time during initial connection and `command_timeout`
   to control the wait time for resposne. Hence set the
   ncclient timeout seperately to Ansible command_timeout
   after the connection object is created sucessfully.

(cherry picked from commit db0fe4b188)
2019-07-29 09:32:57 -07:00
Tomáš Pospíšek
4782c6b0b8 remove ambiguity: use "my_test" as module name (#59335) (#59519)
Use "my_test" as the sample module name on the developing_modules_general page.

(cherry picked from commit 28b9f71640)
2019-07-25 15:49:03 -05:00
UNR Information Security
8e9c8c5b8f Fix return values types for find module in docs (#59480)
* Update find.py (#59456)
Return values for `matched` and `examined` in the find module are integers and not strings.
(cherry picked from commit 7b4ce9e4ae)
2019-07-25 15:47:39 -05:00
Toshio Kuratomi
be6918689a New release v2.8.3 2019-07-25 10:03:46 -07:00
Toshio Kuratomi
a0688027a5 Revert "Clear 'connection related' plugin vars for next loop iteration (#59024)"
This reverts commit 5e7e9b57c0.

This causes a new set of regressions from 2.8.2:
https://github.com/ansible/ansible/pull/59284#issuecomment-514021543

So this issue won't be fixed in 2.8.3 but work towards a fix for 2.8.4
will continue.
2019-07-22 18:54:45 -07:00
Brian Coca
37f8684330 if users are None/empty, dont assume sameness (#58875)
(cherry picked from commit 4ef2545eb5)

 also fix all cases of none remote/become users (#59397)
 some cases failed, when defaults were None on the plugins

(cherry picked from commit 74ac229fa8)
2019-07-22 18:46:09 -07:00
Brian Coca
89963a0062 Fix gather facts ignoring gather_subsets config (#59271)
* Fix gather facts ignoring gather_subsets config

 fixes #58728

* Update lib/ansible/playbook/play.py

Co-Authored-By: Abhijeet Kasurde <akasurde@redhat.com>
(cherry picked from commit 8a886a6bee)
2019-07-22 18:45:06 -07:00
Noe Gonzalez
18fc915b15 [2.8] VMware: Fix vmware_guest cloning bug
* fix vmware_guest cloning bug
* added tests for resizing disks during clone

(cherry picked from commit 3a5d13b0d7)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-07-22 18:43:53 -07:00
Martin Krizek
89d5830da0 2.8: Revert "Speed up VariableManager by preserving Templar state. (#45572)" (#59280) (#59373)
* Revert "Speed up VariableManager by preserving Templar state. (#45572)" (#59280)

This reverts commit 6069d09b9d.

Fixes #57351

(cherry picked from commit b7868529ee)

* Add changelog for #59280 (#59380)


(cherry picked from commit d6b1376006)
2019-07-22 17:07:46 -07:00
Andrey Klychkov
e989f4c38d Backport 59342, postgresql_schema: parameter ensure replaced by state (#59368)
* parameter ensure replaced by state (#59342)

corrected a typo at the absent-example.
(cherry picked from commit 883cc665e3)

* Backport 59342, postgresql_schema: parameter ensure replaced by state
2019-07-22 17:05:23 -07:00
Tyler Ramer
6e9c928817 [2.8] Address regression causing bootproto=dhcp for manual IP addresses
Commit b7724fdf85
appears to have caused a regression, where `ip4`, `gw4`, `ip6`, `gw6`
were converted to `ipv4.address`, `ipv4.gateway` etc.

This causes bootproto (or `ipv4.method`) to remain `dhcp`, as noted in https://github.com/ansible/ansible/issues/36615

This commit only reverts the key-value pairs to the original names,
which is in line with both expectation (manual ip addr == no dhcp) and
the language used in the playbook, which is, for example, "ip4" not
"ipv4.address"

Co-authored-by: Stuart Pollock <spollock@pivotal.io>
Co-authored-by: Tyler Ramer <tramer@pivotal.io>
(cherry picked from commit 8d0f2e5725)
2019-07-22 17:03:59 -07:00
Martin Nečas
02c605b4c9 ovirt vm when creating Nonetypefix (#59377)
* ovirt vm when creating Nonetypefix

* update fix and add comment

* add changelog

* Update 59377-ovirt-vm-when-creating-fix.yml
2019-07-22 16:49:02 -07:00
Sam Doran
e0dbe1bf26 [stable-2.8] Omit -A and -G options in local mode since luseradd does not support these (#55401) (#58480)
* [stable-2.8] Omit -A and -G options in local mode since luseradd does not support these (#55401)

Add integration tests
(cherry picked from commit 20ad120829)

Co-authored-by: Sam Doran <sdoran@redhat.com>

* User - make groups and append mutually exclusive with local (#59309)

* Update intigration tests

(cherry picked from commit 8edad83ae0)
2019-07-22 16:48:28 -07:00
Abhijeet Kasurde
302de41a31 [2.8] VMware: Accept 0 as valid value for memory reservation
vmware_guest accepts 0MB as valid value for memory reservation in
virtual machine hardware configuration. This fixes the regression
introduced via 193f69064f.

Fixes: #59190

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
(cherry picked from commit 1f49abb51c)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-07-22 16:37:02 -07:00
Jordan Borean
e5f68cad5a Fix win_reg_stat for HKU hives (#59359)
(cherry picked from commit 2f2b106423)
2019-07-22 16:35:06 -07:00
Sam Doran
2f5c3b3cb4 [stable-2.8] Handle situation where ansible_architecure may not be defined when gathering facts (#55466)
(cherry picked from commit f231f21669)

Co-authored-by: Sam Doran <sdoran@redhat.com>
2019-07-22 16:22:04 -07:00
Martin Nečas
c40949df8a Ovirt vnic profile docs backport (#59288)
* ovirt vnic profile update readme (#57298)

removes second of two identical examples

* add changelog
2019-07-22 16:20:30 -07:00
Martin Krizek
5e7e9b57c0 Clear 'connection related' plugin vars for next loop iteration (#59024)
Fixes #58876

(cherry picked from commit a752e2a467)
2019-07-22 15:44:33 -07:00
Jordan Borean
a2d6f9acd9 Win setup fix 2.8 (#59211)
* Wrap Get-MachineSid's body in a try/catch

It's not critical information and there's been a number of issues over
the years with trying to retrieve it. If an exception is thrown just
return null.

Fixes: #47813
(cherry picked from commit b8a41a90b8)

* add changelog


(cherry picked from commit 277690bcc6)
2019-07-22 15:21:02 -07:00
Xu Yuandong
c55d83f41e Backport/2.8/59071 ce_file_copy : update ce_file_copy to fix a bug. (#59071) (#59243)
* ce_file_copy : update ce_file_copy to fix a bug. (#59071)

* update ce_file_copy to fix a bug.

* Update ce_file_copy.py

* Update ce_file_copy.py

(cherry picked from commit 7a0a21ea7a)

* add a changelog fragment to PR 59243.
2019-07-22 15:11:16 -07:00
flowerysong
2fbf4ca99c [2.8] Fix ec2_eip parameter logic
device_id is required when private_ip_address is set, but the reverse is not true.

(cherry picked from commit 6273574eb4)

Signed-off-by: flowerysong <junk+github@flowerysong.com>
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-07-22 14:01:02 -07:00
James Cassell
d0f74f495b dzdo: fix password prompt (#59208)
(cherry picked from commit 28259ee247)
2019-07-22 13:59:53 -07:00
Martin Nečas
5447dc855b Ovirt correct sysprep backport (#59286)
* use sysprep only when needed (#59196)

* add changelog
2019-07-22 13:53:52 -07:00
Matt Davis
8074fa9a3e patch ansible-connection collection plugin loading (#59119)
(cherry picked from commit d28f25d118)
2019-07-17 15:34:16 -07:00
Martin Krizek
0d86a4dbaa group: detect duplicate GIDs when local=yes (#58469)
(cherry picked from commit 4898b0a4a2)
2019-07-17 14:30:55 -07:00
Pierre Riteau
299fff1d5e Fix os_quota when volume service not available
os_quota checks the current quotas for compute, network and volume
services and fails when no volume service is found in the catalog.

Since openstack test deployments without volume services are common,
os_quota shouldn't fail if such service is missing.

This was originally fixed in d31a09ceb7
and later adapted to catch exceptions raised by shade. Since then, this
module moved to using openstacksdk, which doesn't catch the exception
raised by keystoneauth1.

Fixes #41240

(cherry picked from commit 1aca1f21f9)
2019-07-17 14:28:26 -07:00
Pilou
afb91e5140 [2.8] tower_role: ensure alias of "validate_certs" parameter is handled
* tower_role: ensure alias of validate_certs is handled

* tower modules: remove tower_verify_ssl alias too

Error was:

    Failed to update role: The Tower server claims it was sent a bad request.
    GET https://tower/api/v2/projects/22/object_roles/
    Params: [('tower_verify_ssl', False), ('role_field', 'admin_role')]
    Data: None
    Response: {"detail": "Role has no field named 'tower_verify_ssl'"}

Full traceback:

    File "/tmp/ansible_tower_role_payload_7_2p0X/__main__.py", line 145, in main
      result = role.grant(**params)
    File "/usr/local/lib/python2.7/dist-packages/tower_cli/resources/role.py", line 365, in grant
      return self.role_write(fail_on_found=fail_on_found, **kwargs)
    File "/usr/local/lib/python2.7/dist-packages/tower_cli/resources/role.py", line 242, in role_write
      fail_on_multiple_results=True, **data)
    File "/usr/local/lib/python2.7/dist-packages/tower_cli/models/base.py", line 301, in read
      r = client.get(url, params=params)
    File "/usr/local/lib/python2.7/dist-packages/requests/sessions.py", line 546, in get
      return self.request('GET', url, **kwargs)
    File "/usr/local/lib/python2.7/dist-packages/tower_cli/api.py", line 299, in request
      kwargs.get('data', None), r.content.decode('utf8'))

(cherry picked from commit 77e01e6abc)
2019-07-17 12:44:31 -07:00
YuandongXu
863520b077 Update 58227-update-cce_evpn_bd_vni-to-fix-a-bug.yml 2019-07-17 12:16:46 -07:00
xuxiaowei0512
550cac42bc add a changelog fragment to PR 58558. 2019-07-17 12:16:46 -07:00
Xu Yuandong
6491c5cdd7 Backport/2.8/58226 ce_vxlan_gateway: update the regular expression to match the more acc… (#58557)
* ce_vxlan_gateway: update the regular expression to match the more accurate. (#58226)

* Update the regular expression to match the more accurate

* Update the regular expression to match the more accurate

* Update the regular expression to match the more accurate

(cherry picked from commit 2f91266aa9)

* add a changlog fragment to PR 58557.

* Update 58226-update-ce_vxlan_gateway-to-fix-a-bug.yml
2019-07-17 12:14:47 -07:00
Sloane Hertel
d170588ab6 [2.8] Define region for aws_secret (#58722)
* AWS: Fix KeyError in aws_secret lookup (#54792)

(cherry picked from commit 33d0d36eaa)

* changelog
2019-07-17 12:11:24 -07:00
Xu Yuandong
494ec6d752 Backport/2.8/59070 ce_interface : update ce_interface to fix a bug (#59072)
* update ce_interface to fix a bug. (#59070)


(cherry picked from commit 07a598089a)

* add a changelog fragment to PR 59072.
2019-07-17 11:49:09 -07:00
Felix Fontein
3d999dbe39 docker_* modules: improve tag validation and requests error handling (#58791)
* Add method to validate docker tags.

* Validate tag option of docker_image.

* Fix regex. Always return boolean, not None vs. Matcher object.

* Also catch requests errors.

* Linting.

* Add changelog.

(cherry picked from commit 8d6f1846a6)
2019-07-17 11:48:27 -07:00
Felix Fontein
1e20cc8bd1 docker_container: add support for nocopy mode (#59043)
* Add support for nocopy mode.

* Add changelog.

(cherry picked from commit fa7c387f9b)
2019-07-17 09:24:21 -07:00
Adam Miller
eb8c4eaa01 assign a sane default to yum/dnf lock_timeout, in line with cli (#57383)
* assign a sane default to yum/dnf lock_timeout, in line with cli

Fixes #57189

Signed-off-by: Adam Miller <admiller@redhat.com>

* fix typo in changelog snippet

Signed-off-by: Adam Miller <admiller@redhat.com>
(cherry picked from commit d2dc4c9bc4)
2019-07-16 20:03:51 -07:00
Brian Coca
e6c93bea0d Fix gather_facts error/skipped reporting (#58927)
now give back full output from each module executed
 fixes #57204

(cherry picked from commit adea964c3e)
2019-07-16 19:50:37 -07:00
pratikgadiya12
0f292cd886 nmcli: Argument vlanid (int) is changed internally to string (#58963)
* Argument vlanid (int) is changed internally to string
* Modified test case to check vlan id

Fixes: #58949
(cherry picked from commit e8f4ebb22c)
2019-07-16 17:57:45 -07:00
Ondra Machacek
4477af7f90 ovirt: Resolve also list of hrefs 2019-07-16 17:56:37 -07:00
Martin Nečas
909f68d035 Ovirt vm migrate with state present backport (#58720)
* ovirt vm migrate with state present  (#58136)

* ovirt vm migrate with state present init

* add migrate comment

* add changelog
2019-07-16 17:50:18 -07:00
Martin Krizek
d3afa17930 Use templated loop_var/index_var when looping include_* (#58866)
Fixes #58820

(cherry picked from commit 7346b699ee)
2019-07-16 15:11:57 -07:00
Lindsay Hill
044923e4ae Fix broken slxos_config due to changed backup options (#58804)
(cherry picked from commit 5b2d1cc24d)
2019-07-16 14:48:28 -07:00
Klaas Demter
6d146c89f2 Fix nagios module to recognize if file exists and is fifo pipe (#58569)
add felixfontein suggestion to changelogs/fragments/58569-nagios-fifo-fix.yaml

Co-Authored-By: Felix Fontein <felix@fontein.de>
(cherry picked from commit faf50dbace)
2019-07-16 14:46:21 -07:00
Joseph
6d467a8bd9 Backport machinectl become plugin fixes (#58734) (#58774)
* Correct machinectl become plugin function arguments (#58734)

* Correct get_option function name and change flags to become_flags

* Remove the '--' from the returned command

* add changelog fragment

* change changelog fragment description

* move the -q argument to machinectl before the shell argument to resolve issues with machinectl v230 (see #56571)

(cherry picked from commit 4f642daae5)

* Update PR number in changelog fragment

* Revert "Update PR number in changelog fragment"

This reverts commit 38e6b4785a.
2019-07-16 14:40:36 -07:00