cmueller/ansible
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity
8480 commits 47 branches 390 tags 440 MiB
Commit graph

572 commits

Author SHA1 Message Date
Toshio Kuratomi
022e5274e6 Merge pull request #460 from jbinto/file_allow_touch_hardlink 
Files module: Allow touch on hardlinks
 2015-01-07 09:04:01 -08:00
Brian Coca
6237dab4cf fix for when state=directory, follow=yes and target is symlink to directory 2015-01-06 10:06:50 -05:00
Toshio Kuratomi
c5f7fc93b2 Merge pull request #514 from jbradberry/issue9546 
Fix breakage in lineinfile check mode when target file does not exist.
 2014-12-16 23:13:34 -08:00
Jeff Bradberry
28375aae7f Fix breakage in lineinfile check mode when target file does not exist. 
Similarly to https://github.com/ansible/ansible/issues/6182, checking of the file attributes should be avoided in check mode when the file didn't originally exist.

Also, avoid creating parent directories in check mode.

Fixes https://github.com/ansible/ansible/issues/9546
 2014-12-14 20:48:36 -05:00
sysadmin75
0fee1132ad Fixes #9518 - "file state=directory" silently skips if it's currently a file 2014-12-13 15:14:32 -05:00
Brian Coca
242a1562c3 Merge pull request #36 from mscherer/fix_old_9092 
Fix old ticket #9092 where a playbook can enter in recursion
 2014-12-11 20:54:54 -05:00
Toshio Kuratomi
467ad65f73 Fix documentation formatting 2014-12-10 11:17:16 -08:00
Jesse Buchanan
2d5d7ff542 Files module: Allow touch on hardlinks 2014-12-07 13:35:24 -05:00
Piotr Gosławski
a5b1a599e2 update docs for insertbefore/insertafter 2014-12-04 17:07:03 +01:00
follower
5c38ea8374 Note that rsync must be installed on both local & remote machine 
In particular, if `rsync` is not installed on the remote machine the following error message will be encountered:

    "rsync error: remote command not found"
 2014-12-05 01:17:10 +13:00
Brian Coca
4035d24313 Merge pull request #17 from cooniur/devel 
Added support of returning owner's group name in stat module
 2014-12-01 12:02:46 -05:00
Brian Coca
e04ac864a5 Merge pull request #10 from techtonik/patch-1 
files.stat: Expose path in returned result
 2014-12-01 11:59:23 -05:00
Piotr Gosławski
3c8b4bd4b9 Fix behavior when insert* doesn't match anything 
If insertbefore/insertafter didn't match anything, lineinfile module was doing nothing, instead of adding the line at end of fille as it's supposed to.
 2014-11-30 12:32:08 +01:00
Eric
87dd3afc91 Fix lineinfile documentation typo 2014-11-29 22:41:24 -06:00
Toshio Kuratomi
19b328c4df Cannot readlink() on a hard link 2014-11-19 13:04:44 -08:00
Brian Coca
ee39fd8df0 Merge pull request #124 from jonhadfield/remove-unused-creates 
Remove redundant check for creates argument.
 2014-11-18 14:59:11 -05:00
Brian Coca
4bc1e46de2 Merge pull request #24 from sysadmind/devel 
Added note to files/synchronize module about synchronizing two directori...
 2014-11-13 19:44:24 -05:00
Jeff Geerling
b9471c9cd5 Add mention of fetch module to the copy module docs. 2014-11-11 12:22:27 -06:00
anatoly techtonik
4f2b99c1e0 acl: Fix X support in ACL permissions 
If you try to set rwX permissions, ACL fails to set them at all.

Expected:

    $ sudo setfacl -m 'group::rwX' www
    ...
    drwxrwxr-x  2 root root  4096 Nov 10 17:09 www

With Ansible:

    acl: name=/var/www permissions=rwX etype=group state=present
    ...
    drwxrw-r-x  2 root root  4096 Nov 10 17:30 www

x for group is erased. =/
 2014-11-10 20:32:05 +03:00
Toshio Kuratomi
6317d3a988 Move from md5 to sha1 to work on FIPS-140 enabled systems 2014-11-06 21:25:55 -08:00
Toshio Kuratomi
88b73afcbe Use original_basename to set the dest path even if src is not set 2014-10-20 22:25:18 -04:00
Ted Timmons
fd68b77d37 fix spelling 2014-10-11 21:11:30 -06:00
Jon Hadfield
9e0565e58f Remove redundant check for creates argument. 2014-10-03 13:00:11 +01:00
Tadej Janež
661b452fe3 Simplified condition in a stat module example testing if path is a directory. 2014-10-02 18:17:27 +02:00
James Cammarata
cb69744bce Adding file doc fragment to those modules in files/ missing it 2014-10-01 20:55:50 -05:00
Michael DeHaan
1c2995d71f Merge pull request #77 from major/suggest-selinux-enforcing 
Updating SELinux example doc in lininefile module
 2014-10-01 11:53:24 -04:00
Eric Hanchrow
cc0a38d268 Tweak docs to mention replace 2014-09-30 10:52:03 -07:00
Major Hayden
6d697780f9 Updating SELinux example doc in lininefile module 
Encouraging users to use this Ansible module to enable SELinux seems
like a better idea. It also warms Dan Walsh's heart.

Signed-off-by: Major Hayden <major@mhtx.net>
 2014-09-30 07:12:23 -05:00
Michael Scherer
9cbd4d0fad Fix old ticket #9092 where a playbook can enter in recursion 
This can be tested with this command :

    ansible -c local -m copy -a 'src=/etc/group dest=foo/' all

This is a corner case of the algorithm used to find how we should
copy recursively a folder, and this commit detect it and avoid it.

Check https://github.com/ansible/ansible/issues/9092 for the story
 2014-09-29 18:02:42 -04:00
Joe Adams
2206d4b1e0 Added note to files/synchronize module about synchronizing two directories on the same host 2014-09-29 17:02:08 -04:00
Tongliang Liu
e26cbb6ace Added support of returning owner's group name in stat module 2014-09-29 13:25:46 -07:00
anatoly techtonik
7f9305b24e files.stat: Expose path in returned result 
This is needed to apply subsequent operation on tested path
 2014-09-29 17:59:23 +03:00
Petros Moisiadis
f7c498d059 synchronize: use a single -F instead of -FF 
This small change corrects behavior when one uses an .rsync-filter file to exclude some paths from both being transferred and being deleted, so that these excluded paths can be handled separately with different tasks (e.g. in order to deploy the excluded paths independently from the rest paths and notify handlers appropriately). The problem with the double -FF option is that it excludes the .rsync-filter file from being transferred to the receiver. However, deletions are done on the side of the receiver, so it is absolutely necessary the .rsync-filter file to be transferred to the receiver, so that the receiver knows what files to delete and what not to delete.
 2014-09-28 13:24:47 +03:00
Michael DeHaan
385a037cd6 package files 2014-09-26 11:05:47 -04:00
Michael DeHaan
c8e1a2077e file extensions! 2014-09-26 10:37:56 -04:00
Michael DeHaan
417309a626 Restructuring. 2014-09-26 10:13:26 -04:00
Michael DeHaan
73123b69fa Move modules into subdirectory. 2014-09-26 09:23:50 -04:00
James Cammarata
dea00c767b Merge branch 'dmage-devel' into devel 2014-09-22 15:42:38 -05:00
James Cammarata
bb8bac490a Merge branch 'devel' of https://github.com/dmage/ansible into dmage-devel 2014-09-22 15:40:06 -05:00
Michael Scherer
d15931f15a Make file module work on python 2.4, fix #9080 
Python 2.4 do not support "except ... as ..." construct, so
revert back to the older syntax.
 2014-09-21 01:50:58 +02:00
James Cammarata
d98d76aeae Adding "follow" param for file/copy options 
Also modifies the template action plugin to use this new param
when executing the file/copy modules for templating so that links
are preserved correctly.

Fixes #8998
 2014-09-16 12:05:55 -05:00
Toshio Kuratomi
17665d962b Do not keep a new file if we fail to set its attributes. 2014-09-15 12:36:52 -07:00
James Cammarata
ab5e8201f4 Fix quoting issues in lineinfile for individual single-quotes 
Fixes #8806
 2014-09-11 16:27:48 -05:00
Oleg Bulatov
583cfa45e5 Fix #7711 
Fix relative symlinks creation in file module

Signed-off-by: Oleg Bulatov <oleg@bulatov.me>
 2014-09-01 23:23:36 +04:00
James Cammarata
311c10c8e5 Docs updates to add examples for symbolic modes 
Also fixes missing doc fragments missing in template and assemble
 2014-08-26 09:09:08 -05:00
Brian Coca
8f3bb4ff20 now acl expands tildes 2014-08-24 19:16:15 -04:00
Michael DeHaan
ef10c2dd9b Merge pull request #8441 from willthames/unarchive_dest_fix 
Unarchive should work when parent directory is not writable
 2014-08-22 15:05:42 -04:00
James Cammarata
005ca0e5ec Merge branch 'relative-path-fix' of https://github.com/major/ansible into major-relative-path-fix 2014-08-21 15:32:51 -05:00
Major Hayden
97d6807ec5 File module cannot create relative paths 
When trying to create a directory relative to the current working
directory, a directory is created at the root of the filesystem
instead.  This patch ensures that directories specified with relative
paths will be created in the current working directory.  Fully
qualified paths aren't affected

Signed-off-by: Major Hayden <major@mhtx.net>
 2014-08-21 15:31:06 -05:00
James Cammarata
0b35433654 Fix check mode issues with copy module 
Fixes #8639
 2014-08-18 16:02:45 -05:00
James Cammarata
989b14de80 Add option to disable ControlPath to ssh options during rsync 
Fixes #8473
 2014-08-18 12:59:00 -05:00
James Cammarata
6d4b429488 Update docs for copy directory_mode param per #8572 2014-08-12 12:19:13 -05:00
Michael DeHaan
ed0751984c Copy recursion works when source is a parameter, there is no parameter 'recurse' here. 2014-08-11 16:22:13 -04:00
James Cammarata
3f052ead3a Make sure we only use unquote on quoted lines in lineinfile when needed 2014-08-11 11:23:52 -05:00
James Cammarata
6c9371ea90 Unquote lines that were quoted for safety during eval in lineinfile 
Fixes #8535
 2014-08-11 11:01:23 -05:00
Piffey Parlance
c987dbcb67 Issue 8502: Fixed bug where failed when permissions weren't specified. 2014-08-09 12:02:24 -05:00
Michael DeHaan
60ce2d3853 Fix documentation builds. 2014-08-08 15:12:10 -04:00
Michael DeHaan
185d5a6221 Merge branch 'spelling' of git://github.com/cgar/ansible into devel 
Conflicts:
	docsite/rst/guide_rax.rst
	plugins/callbacks/mail.py
 2014-08-08 13:28:45 -04:00
Michael DeHaan
0591d3dfbf Merge pull request #7312 from bcoca/unarchive_docs 
reworded copy option docs
 2014-08-08 11:47:16 -04:00
Will Thames
de16785b8c Unarchive should work when parent directory is not writable 
Correct unarchive so that the checks for writeability are
sensible.

Added a test for when parent directory is not writable
 2014-08-07 16:11:02 +10:00
Michael DeHaan
f0ae6204e4 Merge pull request #8455 from nicocesar/version_check 
if python >=2.7  use the option allow_no_value=True for ini_file.
 2014-08-05 21:00:37 -04:00
Michael DeHaan
f228e0bff4 Some stray doc tweaks with file modules. 2014-08-05 20:45:16 -04:00
Michael DeHaan
d78e16ff36 Move doc fragments back into file module. 2014-08-05 20:45:16 -04:00
Nico Cesar
31b34906d0 if python >=2.7 use the option allow_no_value=True for ini_file. 2014-08-05 10:56:20 -04:00
Michael DeHaan
04568cd767 Revert ""allow_no_value=True" for ini_file module so /etc/my.cnf can be read without a problem" 
This reverts commit cbdc9f1153.

Code needs to make allowances for particular python versions and try/except
around this block.
 2014-08-04 11:49:55 -04:00
Michael DeHaan
c05a5eba58 Add version_added attribute for regexp parameter. 2014-08-04 07:51:29 -04:00
Nico Cesar
eeabda4831 "allow_no_value=True" for ini_file module so /etc/my.cnf can be read without a problem 2014-08-01 16:04:35 -04:00
RomanDolejsi
7cd6d6fb89 file: prevent replace failure when overwriting empty directory with hard/link (force=yes) 2014-07-29 10:46:32 +02:00
Michael DeHaan
03c46f016a Update unarchive example. 2014-07-28 12:07:31 -04:00
Michael DeHaan
0697bbd6dd Merge pull request #8200 from geetotes/devel 
[Docs] Added another example to demonstrate unarchive module working entirely on a remote machine
 2014-07-28 12:04:33 -04:00
Michael DeHaan
0221727050 Merge pull request #7968 from bcoca/acl_fix_compare 
acl module: now compares permissions correctly
 2014-07-28 10:47:38 -04:00
Lee Gillentine
7cdeddb740 Pushing up correct example :( 2014-07-25 14:19:02 -05:00
anatoly techtonik
fdc355d376 acl: Remove obscurity in state description 2014-07-25 12:04:45 +03:00
Lee Gillentine
1b742ca567 Adding another example to demonstrate unarchive working entirely on a remote machine 2014-07-18 22:22:37 -05:00
James Cammarata
de3133682e Merge pull request #8126 from dingus9/patch-1 
Update lineinfile validate help
 2014-07-16 13:28:21 -05:00
Michael DeHaan
1b48465106 Slight typo fix. 2014-07-15 18:08:11 -04:00
Nick Shobe
e553e24d0a Update lineinfile 2014-07-14 13:09:57 -05:00
Henry Finucane
9fd91bec5d Make 'compress' optional 2014-07-12 10:13:04 -07:00
Andreas Fleig
3c4dbd61fc ini_file: replace lambda with named function 
Fixes #6876
 2014-07-08 10:17:03 -05:00
Brian Coca
030ac743a4 now compares permissions correctly 2014-06-28 00:24:16 -04:00
James Cammarata
68295b05b4 Merge branch 'fix_lineinfile_newlines' into devel 2014-06-23 12:38:12 -05:00
James Cammarata
4adf2c4dfd Merge branch 'issue_5679_lineinfile' into fix_lineinfile_newlines 2014-06-20 00:19:35 -05:00
Norman J. Harman Jr
0f4aa34da2 lineinfile supports symlinks. 2014-06-19 17:38:34 -05:00
trbs
6567e40b6d In check mode if a symlink does not exist there is no need to check the ownership properties (which causes an exception) 2014-06-19 15:47:46 +02:00
James Cammarata
abe3655cec Double check whether the parent directory really exists using stat() 
Fixes #7760
 2014-06-18 14:54:44 -05:00
James Cammarata
bdf84b4e73 Merge branch 'unarchive-fix-7777-simple' of https://github.com/toddmowen/ansible into toddmowen-unarchive-fix-7777-simple 2014-06-18 13:48:57 -05:00
James Cammarata
2ac27fbbea Use file documentation fragement for the copy module 2014-06-16 15:36:15 -05:00
Todd Owen
dc7e1fe21e unarchive: do not assume tar supports -C 
Fixes #7777
(But don't rewrite the tar invocation in is_unarchived(), since a
tar that supports "--diff" certainly supports "-C" as well).
 2014-06-15 22:38:41 +08:00
Todd Owen
2b9402dc5c unarchive: improve failure detection and reporting 
Related to #7777
 2014-06-15 13:13:18 +08:00
James Cammarata
0c028ad881 Merge branch 'fix-lineinfile-eof-newline' of https://github.com/ahtik/ansible into ahtik-fix-lineinfile-eof-newline 2014-06-12 09:13:49 -05:00
Aleksey Khudyakov
a1d76ca8d1 Escape backslash in assemble module docs 2014-06-11 04:38:57 +11:00
James Cammarata
8d9da7e89f Merge pull request #7377 from mikhailguru/devel 
Fixed handling of paths containing whitespaces in the synchronize module
 2014-06-10 06:50:07 -05:00
Ahti Kitsik
6341cc23fb Bugfix to lineinfile to properly handle files with no newline at EOF when using insertafter=EOF. 
Looks like #6881 is also affected by this bug.

Currently when using lineinfile insertafter=EOF for a file that has no newline then the added line is not prefixed with a newline.
As a concrete example, ubuntu distro default /etc/ssh/sshd_config has no newline so lineinfile module cannot be used to add a new line to the end of the file.
 2014-06-09 19:58:45 +03:00
James Cammarata
c276dec487 Fix issue with symlink path detection 
Fixes #7627
Fixes #7664
 2014-06-04 23:31:59 -05:00
James Cammarata
090fd0a224 Fix linking issue to directories in file module 
The os.path.isdir() returns True for symlinks that point to directories,
so we also need to check to make sure it's not a symlink too.

Fixes #7657
 2014-06-04 22:48:08 -05:00
Brian Coca
ffb87adbc2 Correctly examine path for relative links in file module 
Fixes #7515
Fixes #7537
 2014-05-28 11:47:44 -05:00
Kit Westneat
aab77b46d8 Fixed documentation for etype parameter on acl module. 
The etype parameter just had a copy of the default parameter documentation.
Changed it to reflect what it really is for.
 2014-05-27 13:34:01 -04:00
Brian Coca
ac14a8d6ad unified calls to fs function vs duplicate functions for file and 
directory
 2014-05-24 09:28:45 -04:00
James Cammarata
5ec0297c04 Fixing absolute path calculation for file module when linking 
Fixes #7403
 2014-05-21 12:49:42 -05:00
telsacolton
ee60f8f710 Make file hardlink error message reasonble 
When we hard-link a file, and the link path already exists, give the link path in the error message instead of the source
 2014-05-14 16:54:26 -05:00
telsacolton
133cbee473 Give reasonable error when symlink fails 
When a symlink fails because the path already exists and force=no, we should output path in the error message instead of source.
 2014-05-14 16:31:20 -05:00
James Cammarata
8c7aafd5ae Merge branch 'file_new_dirs_perms' of https://github.com/bcoca/ansible into bcoca-file_new_dirs_perms 2014-05-14 13:53:08 -05:00
Mikhail Emelchenkov
cadb57f446 Fixed incorrect handling of paths contaiin whitespaces 2014-05-13 17:05:44 +04:00
James Cammarata
7faf766305 Merge branch 'devel' of https://github.com/jjshoe/ansible into jjshoe-devel 2014-05-09 00:31:39 -05:00
James Cammarata
261fe0ea96 Merge pull request #7013 from orgoj/replace-patch-changed 
module replace - report changed only if contents is changed
 2014-05-08 15:14:19 -05:00
Brian Coca
6cad8620d5 reworded copy option docs to be clearer 2014-05-06 08:31:26 -04:00
James Cammarata
5ce5ba5e58 Refuse to convert a non-empty directory into a link with the file module 
Also adds an integration test for the above.

Fixes #7254
 2014-05-02 14:46:38 -05:00
someda
5bb888af4b fix #7244 recursive copy fails when setting directory attributes 
- reverse the order of new_directory_list returned from split_pre_existing_dir in copy module
 2014-05-02 01:38:16 +09:00
Michael DeHaan
f57f9c950f Merge pull request #7119 from jjshoe/patch-4 
Finish reverting a broken commit in #5679
 2014-04-29 16:47:46 -04:00
James Cammarata
b53bf7c8b1 Minor tweak to rsync_path construction in synchronize module 
Fixes #7182
 2014-04-29 15:47:16 -05:00
Carlos E. Garcia
4dcaa9d9fb multiple spelling error changes 2014-04-29 10:41:05 -04:00
Skyler Leigh Amador
6eb8759ec5 Remove --timeout option to rsync from synchronize defaults 
The current 10-second default timeout for rsync seems to be behind issue #6809.

As a workaround for the underlying issue in rsync when different versions are
used on the source and destination sides, don't include the timeout option
unless the user specifies a timeout > 0.
 2014-04-27 20:21:54 -07:00
Joel Schuweiler
aed596088b Finish reverting #b73cddc 2014-04-27 09:36:13 -05:00
jjshoe
6f0808b23b Ensure the validation string has %s in it 2014-04-27 09:30:36 -05:00
Brian Coca
1e3860c47b now when making multiple dirs in path to make dir, same permissions are assigned (but only for NEW dirs) 
Signed-off-by: Brian Coca <briancoca+ansible@gmail.com>
 2014-04-23 10:38:38 -04:00
Erika Heidi
40e7c6eddc Possible docs error: 'path' instead of 'src' 
I came to this example today (line 50), and when I tried it, I got an error:

`msg: src and dest are required for creating links`

So, I changed **path** to **src** and it worked fine. Looks like the example is wrong, since the docs say "dest" is already an alias for "path", in which case we would have 2 "path" definitions.
 2014-04-23 16:00:22 +02:00
Michael Heca
6618c1e8b5 module replace - report changed only if contents is changed 2014-04-16 09:25:56 +02:00
James Cammarata
39356bd83b Get the bin path for commands in the unarchive module 
Fixes #6927
 2014-04-15 20:39:22 -05:00
James Tanner
0f82a2b53c Addresses #6702 Remove version_added from description string 2014-04-11 11:18:05 -04:00
James Tanner
f2c9c2c141 Addresses #6702 set version_added for rsync_opts 2014-04-11 11:04:05 -04:00
jctanner
7a6267690e Merge pull request #6702 from jjshoe/devel 
Allow you to pass in arbitrary rsync options
 2014-04-11 10:43:14 -04:00
James Tanner
fec4c797d9 Fixes #6929 remote file module doc fragments from copy and template 2014-04-10 16:06:35 -04:00
James Tanner
199992adb6 Fixes #6894 create docs fragment for files 2014-04-08 13:20:15 -04:00
James Cammarata
8f325afe38 Fixing newline escapes in lineinfile 
Fixes #5679
 2014-04-08 11:42:29 -05:00
James Cammarata
7a03cc69e1 Revert "Fix #5679 again after recent changes in core" 
This reverts commit 2bfaacd170.

Fixes #6821
 2014-04-07 09:55:59 -05:00
Richard C Isaacson
465b97be7e assemble module: fix insertion of newlines when not needed. 
This builds on GH-6359 and changes the logic so that a newline is only inserted between fragments if the previous fragment does not end with a newline.
 2014-04-03 16:32:35 -05:00
Peter Gehres
53c1d25c70 Fix for #6353 adding a newline between assembled files 2014-04-03 16:32:35 -05:00
Michael DeHaan
63a1330263 Use common file argument system previously implemented by @sivel for rax modules on the file modules as well (copy/file/template). 
Application to other cloud providers would make very good sense.
 2014-04-03 16:52:39 -04:00
James Tanner
7b72004eb4 Merge #5903 from rhaido/ansible 
Update files documentation for usage of force=True and hardlinks
 2014-03-31 12:53:03 -04:00
cgtx
bb3fed67aa backreferences should be double escaped 2014-03-29 18:14:56 -05:00
Michael DeHaan
a8b345ad38 Repairs for documentation build. 2014-03-28 14:57:29 -04:00
Michael DeHaan
f596ee8850 Slight docs tweak, split lines according to code standards 2014-03-28 14:04:59 -04:00
Andrea.Mandolo
2a66f356b1 correct documentation comment and version_added in "synchronize" module 2014-03-28 14:04:59 -04:00
Andrea.Mandolo
7cd21a47ef Add STDOUT lines in response of "synchronize" module 2014-03-28 14:04:59 -04:00
Andrea.Mandolo
33b440ac9f Add "checksum" option support to 'synchronize' module 2014-03-28 14:04:59 -04:00
Michael DeHaan
d1975c906f Merge branch 'update_docs_validate_cmd_not_passed_via_shell' of git://github.com/rwehner/ansible into devel 
Conflicts:
	library/files/template
 2014-03-28 11:21:41 -04:00
Michael DeHaan
38c3332b8a Merge pull request #6597 from tarka/handle-uncreated-symlink-tmpfile 
Handle missing symlink tempfile
 2014-03-28 11:11:32 -04:00
jjshoe
a5794f5d8c Allow you to pass in arbitrary rsync options. I also added help for it, and what version it was added in. 2014-03-27 08:00:20 -05:00
Jeff Geerling
177bf3eb20 Fixed template validation docs and example. 2014-03-26 12:42:15 -05:00
jjshoe
e62b38c250 Show argument dependency 
failed: [192.168.1.2] => {"cmd": "rsync --delay-updates -FF --compress --timeout=10 --delete-after --rsh 'ssh -i /home/jjshoe/.vagrant.d/insecure_private_key -o StrictHostKeyChecking=no' --rsync-path 'sudo rsync' --out-format='<<CHANGED>>%i %n%L' /tmp/app vagrant@192.168.1.2:/home/ubuntu/app", "failed": true, "item": "", "rc": 1}
msg: rsync: --delete does not work without --recursive (-r) or --dirs (-d).
rsync error: syntax or usage error (code 1) at main.c(1453) [client=3.0.9]
 2014-03-26 08:32:55 -05:00
James Cammarata
68327fa172 Cleanup from merge of replace module and CHANGELOG update 2014-03-25 11:13:51 -05:00
James Cammarata
2c05e337cb Merge branch 'devel' of https://github.com/EvanK/ansible into EvanK-devel 2014-03-25 10:38:59 -05:00
James Cammarata
d6a2befb0d Merge branch 'file_fixes_agg' of https://github.com/bcoca/ansible into bcoca-file_fixes_agg 2014-03-24 16:38:35 -05:00
Robert Wehner
406317371b Update 'validate=' parameter documentation to make clear that the command 
passed via this paramter is not passed via shell and so all shell features
will not work.
 2014-03-24 09:06:25 -06:00
James Tanner
7c263fcdad Fixes #6590 add set_remote_user parameter to synchronize 
This allows usage of custom ssh configs for remote hosts where
the inventory user does not match the configured user.
 2014-03-20 13:56:07 -04:00
Steve Smith
5b5af14921 Only unlink the symlink tempfile on error if it was created in the 
previous operation.
 2014-03-20 13:14:24 +01:00
Brian Coca
a395eb3aba fixed issue with tmp file (path can include filename) and added missing 
else which made it try to link x2
 2014-03-20 07:55:53 -04:00
Brian Coca
4fd957620a now correctly checks absolute path for src= existance for links 
also updated docs to be a bit clearer on symlink behaviour
 2014-03-20 07:49:25 -04:00
Brian Coca
402cd11c52 fixed issue with directory permissions on copy #6552 2014-03-18 22:29:22 -04:00
James Cammarata
d60ac967b9 Merge branch 'file_fixes_clean' of https://github.com/bcoca/ansible into bcoca-file_fixes_clean 2014-03-17 14:03:26 -05:00
Michael DeHaan
4ec2a79aae Merge pull request #6515 from lotia/fix-acl-doc-and-error 
Fix acl doc and error
 2014-03-16 13:15:42 -05:00
Ali Asad Lotia
fc5aa9ac28 Whitespace fixes in incompatible param check 
- Remove extra whitespace in conditional that checks if etype, entity or
  permissions are also set when entry is set.
 2014-03-16 17:49:36 +00:00
Michael DeHaan
ec14b25e23 Merge pull request #6448 from jirutka/fix-5679-2 
Fix #5679 again after recent changes in core
 2014-03-16 12:43:10 -05:00
Cristian Ciupitu
7f681c33a2 Micro-optimization: replace s.find(x)!=-1 with x in s 
timeit shows a speedup of ~3x on Python 2.7.5 x86_64.
It also makes the code a bit shorter.
 2014-03-16 13:10:28 -04:00
Ali Asad Lotia
77e6dded62 Fix acl module doc and error messages 
- Fix typos in module doc
- Provide clearer error message when entry and etype are both missing
 2014-03-16 16:41:37 +00:00
Brian Coca
7ca6343ca3 Fixes and cleanup to file functions and module 
- unified set attribute functions ... not sure why 2 identical functions
exist with diff names, now there are 3 while i repoint all modules to 1
- fixed issue with symlinks being created w/o existing src when force=no
- refactored conditionals, simplified where possible
- added tests for symlink to nonexistant source, with both force options
- made symlink on existing attomic (force)
 2014-03-15 13:54:24 -04:00
Michael DeHaan
4f1ccfd66f Merge pull request #6504 from follower/patch-2 
Fix typo
 2014-03-15 09:15:53 -05:00
follower
5beee66d1d Fix typo 
"resort" -> "result"
 2014-03-15 20:04:38 +13:00
Brian Coca
5dd041ae7e fixed bad detection of change on default and premature break 2014-03-15 01:10:15 -04:00
Jakub Jirutka
f39b8cae95 Fix #5679 again after recent changes in core 2014-03-12 18:21:53 +01:00
Brian Coca
3b98ed15bc now stat skips md5 if file isn't readable 2014-03-11 22:50:05 -04:00
James Tanner
fc33860e5d Force command action to not be executed by the shell unless specifically enabled 2014-03-10 16:13:30 -05:00
Dolph Mathews
289f8f7ed9 spelling correction for "separate" 
s/seperate/separate/

http://en.wiktionary.org/wiki/separate
 2014-03-08 04:51:34 -06:00
Richard C Isaacson
7fff5abd5b unarchive module: Add creates functionality. 
Closes GH-5354.

Forklift copy logic into unarchive. Provides integration unit tests.
 2014-03-07 18:19:46 -06:00
Michael DeHaan
87677c96c6 Merge pull request #6308 from muffl0n/file_fix_documentation 
Module "file": Fix link to "path" in documentation
 2014-03-06 11:04:47 -06:00
James Cammarata
bdd3ccec65 Un-escape newlines in delimiters for assemble module 2014-03-06 09:44:56 -06:00
Sven Schliesing
b55f99b803 Fix link in documentation 
c(dest) -> c(path)
 2014-03-06 13:16:29 +01:00
Michael DeHaan
2f12c6ddf6 Simplify file module parameter description. 2014-02-28 13:55:07 -05:00
Richard C Isaacson
7263148156 Typo fix. 2014-02-28 11:02:58 -06:00
Richard C Isaacson
1e2eb88926 Replace mode with octal renaming to mode. 
Closes GH-6176

This way for mode we return in an octal format which is immediately usable compared to transforming it later.
 2014-02-28 10:42:20 -06:00
Richard Isaacson
6ffeaa7ddd Merge pull request #1 from bcoca/stat_updaates 
added octal representation of mode and made md5 checksumming optional
 2014-02-28 10:39:41 -06:00
Richard C Isaacson
a707e858cd Minor cleanup. 2014-02-28 10:04:05 -06:00
Richard C Isaacson
3ca9fc64d5 copy module: cleanup and if directory_mode not set default to umask 2014-02-28 10:00:54 -06:00
Richard C Isaacson
326ed4eeeb Copy Module: Add the ability to set directory attributes on recursive copy. 
Closes GH-6194.

These changes pass attribute modifications through to new directories during a recursive copy with an addition allowing for the directory mode to be set independantly.
 2014-02-28 01:14:32 -06:00
James Cammarata
b667e1d404 Add expanduser calls on src/dest in the module too 2014-02-26 15:19:45 -06:00
James Cammarata
1762557ff4 Merge branch 'devel' of https://github.com/muffl0n/ansible into muffl0n-devel 2014-02-26 12:28:26 -06:00
Brian Coca
21854d54d4 added octal representation of mode and made md5 checksumming optional 
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
 2014-02-25 21:33:14 -05:00
James Cammarata
6283754340 Fixing several bugs in assemble and updating tests 
Bugfixes:
* the remote_src param was not being converted to a boolean correctly,
  resulting in it never being used by the module as the default behavior
  was remote_src=True (issue #5581)
* the remote_src param was not listed in the generic file params, leading
  to a failure when the above bug regarding remote_src was fixed
* the delimiter should always end with a newline to ensure that the file
  fragments do not run together on one line

Fixes #5581
 2014-02-24 14:27:23 -06:00
James Cammarata
33d9a662ee Adding new tests for assemble role 2014-02-24 14:27:23 -06:00
James Cammarata
d80b9ac137 Adding the backup destination to the resut dictionary for lineinfile 2014-02-20 13:31:54 -05:00
muffl0n
68bef304c8 already call expanduser in action_plugin 2014-02-19 21:41:57 +01:00
Michael DeHaan
62f8ebe51e Merge pull request #6036 from mxxcon/patch-1 
docs_pull_request: Add parameters highlighting
 2014-02-18 13:58:44 -05:00
James Cammarata
f1ba67e547 Merge branch 'fix-5679' of https://github.com/jirutka/ansible into jirutka-fix-5679 2014-02-17 14:54:29 -06:00
mxxcon
544c08a211 docs_pull_request: Add parameters highlighting 
Added highlighting to parameter references in docs so that they standout a bit better.
 2014-02-15 23:26:21 -05:00
Michael DeHaan
77ac23cc26 Document ansible_managed changing the template. 2014-02-15 14:13:42 -05:00
Michael DeHaan
b1e442639f Some minor docs corrections. 2014-02-15 14:05:42 -05:00
Richard C Isaacson
54c799d3fb Cleanup per notes. 
Some small changes to per notes from @mpdehann.
 2014-02-12 10:01:10 -06:00
Richard C Isaacson
9795eec24b Updates for the unarchive module and action_plugin. 
There is a bit going on with the changes here. Most of the changes are cleanup of files so that they line up with the standard files.

PR #5136 was merged into the current devel and brought up to working order. A few bug fixes had to be done to get the code to test correctly. Thanks out to @pib!

Issue #5431 was not able to be confirmed as it behaved as expected with a sudo user.

Tests were added via a playbook with archive files to verify functionality.

All tests fire clean including custom playbooks across multiple linux and solaris systems.
 2014-02-12 01:57:00 -06:00
Richard C Isaacson
a3be027909 Merge remote-tracking branch 'pib/unarchive_remote' into pull_5136 2014-02-11 22:55:34 -06:00
Mike Grozak
3f74dd6592 Updated the force parameter description; added one example how to create the symlinks pointing to non-absolute paths 2014-02-07 14:29:20 +01:00
Mike Grozak
ecd8b5d064 Found a way how to have symlinks towards files without absolute paths in prefixes; fixed incorrect force setting on the hard links, which can not point to non-existing files 2014-02-07 14:13:41 +01:00
Mike Grozak
4f262779cd Started the development of the 'chdir' functionality for file module - creation symlinks without the base directory prefix 2014-02-06 17:20:32 +01:00
jctanner
5a6fc3d940 Merge pull request #5363 from bcoca/acl_improved 
acl module: acl now supports 'default'
 2014-02-05 18:40:59 -05:00
Brian Coca
3aa3a42c45 fixed docstring and changed type to etype avoiding python builtin 
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
 2014-02-05 18:36:29 -05:00
jctanner
552ce8b68c Merge pull request #5051 from deontologician/patch-1 
Added -FF flag to rsync invocation in synchronize
 2014-02-05 12:02:48 -05:00
jctanner
e13a10def7 Merge pull request #5127 from ovcharenko/patches 
synchronize module: Added existing_only options to skip creating new files on receiver
 2014-02-05 11:49:05 -05:00
jctanner
27362ebbf1 Merge pull request #5187 from 42wim/devel 
Add support for --copy-links in synchronize
 2014-02-05 11:26:08 -05:00
Michael DeHaan
f16f2f23f5 Update copy 
Update copy documentation to reference synchronize module
 2014-01-30 17:43:40 -05:00
Wim
7b8918d37c Add support for --copy-links 2014-01-29 23:05:51 +01:00
Jan-Piet Mens
95c826a533 documentation typos 2014-01-21 09:03:14 +01:00
Jakub Jirutka
ec80066cee Fixes #5679: lineinfile ignores newline in line argument 2014-01-19 02:24:26 +01:00
Laurent Defert
9fb39ce4aa Mark stat module as supporting check_mode 2014-01-18 22:32:58 +01:00
jctanner
95131937df Merge pull request #5282 from rhaido/hard_link_fix 
file module: Added to the file module the functionality to force conversion hard link...
 2014-01-14 07:15:46 -08:00
jctanner
87b58666f9 Merge pull request #5264 from drewlll2ll/file-fix 
file module: Fixed missing prev_state == 'directory' in file
 2014-01-06 14:07:07 -08:00
Aleksey Ovcharenko
d8b160d385 Downgraded module version_added. 2014-01-03 17:22:10 +02:00
Michael DeHaan
a11e5d609e Basic docsite formatting fixups 2014-01-02 17:36:52 -05:00
Michael DeHaan
0a3293cf53 add a note about raw/endraw 2013-12-27 15:01:27 -05:00
Michael DeHaan
0ad0f795f3 Merge pull request #5427 from bcoca/template_docs2 
added more usefull example for jinja2 overrides
 2013-12-26 10:30:44 -08:00
Brian Coca
9affb6ed37 added more usefull example for jinja2 overrides (this one is actually 
used)

Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
 2013-12-26 12:01:41 -05:00
Maykel Moya
8f766bdcdd Missing "is" in file module description 2013-12-26 12:34:46 +01:00
Brian Coca
bdd6eaa62a now handles default and allaows for either shorthand entry or specific 
fields per entry section

the default option works both when added to entry or as stand alone.
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
 2013-12-19 20:36:49 -05:00
Peter Salvatore
4c168abccc fix typo in synchronize module 2013-12-18 13:06:35 -08:00
Aleksey Ovcharenko
1b2d359a69 Added version_added 2013-12-16 19:20:02 +02:00
Jens Rantil
38d0df65d8 module(file): Fail instead of exit on exception 2013-12-13 21:34:19 +01:00
Jens Rantil
4262e76aec module(file): state what went wrong on exception 2013-12-13 21:33:19 +01:00
Mike Grozak
5a66a95bf3 Added to the file module the functionality to force conversion hard link and symlink when the force attribute is set to 'yes' 2013-12-13 17:10:50 +01:00
drewlll2ll
8fe3b05262 Added prev_state for directory 2013-12-12 09:44:29 -05:00
Jens Rantil
b8347a3144 file module: Don't catch SystemExit 
This fixes issue #5159.
 2013-12-04 13:13:49 +01:00
James Tanner
f210e0c862 Fixes #5109 synchronize module ssh port 
Added a parameter for dest_port and also check ansible_ssh_port inventory variable.
 2013-12-03 14:48:20 -05:00
Paul Bonser
4df9dd9232 Optionally unarchive a file already on the remote machine 2013-12-02 19:51:10 -06:00
James Tanner
4f9aadcc07 Addresses #5023 Fix import comments 2013-12-02 15:13:49 -05:00
James Tanner
38edad70ac Fixes #5023 Convert all modules to use new snippet import pattern 2013-12-02 15:11:23 -05:00
Aleksey Ovcharenko
8413552642 Fixed a typo. 2013-12-02 16:35:44 +02:00
Michael DeHaan
4c35b7f380 There's a cleaner way to do this, commit to module formatter pending. 
Revert "No longer need to reference 'version_added' in docs for these, as this was quite a while ago."

This reverts commit ff0a41d446.
 2013-11-27 21:23:03 -05:00
Michael DeHaan
9e4d71203d No longer need to reference 'version_added' in docs for these, as this was quite a while ago. 2013-11-27 21:19:32 -05:00
Josh Kuhn
c2a59a97c4 Added note about .rsync-filter files, with example 2013-11-25 15:12:58 -05:00
Josh Kuhn
eccaf457af Added -FF flag to rsync invocation in synchronize 
The `-FF` option causes rsync to look for files in the source directory named `.rsync-filter` and uses them to filter directories underneath them. If no `.rsync-filter` files are found, the behavior is identical to the command run without the -FF option. This flag does not sync the .rsync-filter files themselves.

This change should be backwards compatible and not produce surprising behavior for users, since they are unlikely to create `.rsync-filter` files unintentionally.
 2013-11-25 12:27:58 -05:00
greenbrian
74a2bf4369 Update unarchive 
Modified argument order provided to unzip command as the -o was being interpreted as a file.
 2013-11-25 10:44:39 -06:00
Aleksey Ovcharenko
bb3a23d40a Added existing_only options to skip creating new files on receiver 2013-11-22 23:59:57 +02:00
Michael Scherer
b3758f6ea4 Do not use construct not compatible with python 2.4, fix #5006 2013-11-22 16:06:41 +01:00
Joshua Lund
4b9227a673 Fixed a typo in the 'unarchive' module documentation 2013-11-21 16:22:20 -07:00
James Tanner
aa0af14734 Fix pep8 errors in unarchive module 2013-11-19 16:35:06 -05:00
Michael DeHaan
08996d78d6 Add version_added to all modules missing version_added information, the docs formatter will now 
raise errors when omitted, updated changelog with new modules.
 2013-11-18 18:55:49 -05:00
Evan Kaufman
2c8b761a65 Added replace module 
Heavily based on existing lineinfile module, but where it literally tests a regexp against
*each individual line* of a file, this replace module is more analogous to common uses of
a `sed` or `perl` match + replacement of all instances of a pattern anywhere in the file.

Was debating adding `all` boolean or `count` numeric options to control how many
replacements to make in the destfile (vs currently replacing all instances)

Noted use of MULTILINE mode in docs, per suggestion from @jarv
 2013-11-16 13:23:50 -06:00
James Tanner
b982a3d353 Clean up erroneous lineinfile.orig file 2013-11-15 12:17:17 -05:00
James Tanner
a3631638e5 Set required = True for src in unarchive module. 2013-11-14 10:59:24 -05:00
jctanner
4e76e6047d Merge pull request #4625 from pileofrogs/devel 
unarchive module & action plugin
 2013-11-14 07:57:57 -08:00
James Tanner
0f806cfdfa Merge pull request #4525 from ko-zu/ansible 
Add a regexp parameter to assemble module to match or exclude filenames.
 2013-11-14 10:30:12 -05:00
James Tanner
0f3093516d Merge pull request #4375 from pfalcon/ansible 
copy: Implement recursive copying if src is a directory.
 2013-11-13 15:52:40 -05:00
James Tanner
53ba890312 Fixes #4884 Do not prematurely exit from file module if src not defined 2013-11-12 18:17:20 -05:00
James Tanner
2e916df20f Add default for remote_src to assemble dostrings to avoid confusion 2013-11-12 13:21:49 -05:00
jctanner
28de7dab2f Merge pull request #4738 from bcoca/assemble_action_plugin 
assemble can now use src from master/origin
 2013-11-12 08:23:39 -08:00
James Tanner
1ad4f6e325 Fixes #4522 Document that comments in ini files will be discarded with the ini module 2013-11-08 09:57:22 -05:00
James Tanner
2c57b999fc Addresses #4801 Update file module docs to indicate behavior for relative src paths 2013-11-07 17:02:34 -05:00
jctanner
f340f916b4 Merge pull request #4801 from sspans/devel 
Add support for relative symlinks
 2013-11-07 13:57:18 -08:00
James Tanner
39fdb934be Add doc example for lineinfile without a regexp parameter 2013-11-06 18:51:31 -05:00
James Tanner
f8eea4e155 Merge pull request #4660 from kolbyjack/lineinfile_no_regexp 2013-11-06 18:43:10 -05:00
James Tanner
3ae95c8953 Fix merge conflict 2013-11-06 18:38:01 -05:00
James Tanner
7b3fbeee16 Addresses #4676 Add module notes about the behavior of sudo and the destination paths within the synchronize module. 2013-11-04 12:19:31 -05:00
James Tanner
403469bf19 Update synchronize docstrings for rsync_timeout parameter 2013-11-04 10:57:08 -05:00