Commit graph

39953 commits

Author SHA1 Message Date
Matt Clay
7d8f1a7aae Disable failing sts_assume_role integration test. 2018-09-21 18:38:02 -07:00
Matt Davis
3b52d968e6
fix premature exit when RG doesn't exist (#46013)
* fixes #45941
* corrects regression introduced by #26104; when the resource group doesn't exist, the module exits prematurely with an error instead of creating it.
2018-09-21 16:23:21 -07:00
Simon Metzger
fc7e5f16e8 Update developing_modules_general_aci.rst
<!--- Your description here -->

+label: docsite_pr
2018-09-21 23:52:51 +02:00
Matt Clay
339d22a2bd
Improve stability of Docker integration tests. (#46005) 2018-09-21 14:48:40 -07:00
Matt Clay
d603cd41fe Fix integration test library search path.
This prevents tests from loading modules outside the source tree,
which could result in testing the wrong module if a system-wide
install is present, or custom modules exist.
2018-09-21 13:53:09 -07:00
mrmagooey
991f61c138 Improve symlink install error message in setup.py
PR #45132

Co-authored-by: Sviatoslav Sydorenko <wk@sydorenko.org.ua>
2018-09-21 23:40:30 +03:00
Adam Harvie
8659a88fea Add 'signalled' state to supervisorctl module with associated 'signal' parameter. (#32694)
https://github.com/ansible/ansible/issues/29847
2018-09-21 15:59:14 -04:00
Brian Coca
03d8b68549 added note about cli execution of include_x (#45227) 2018-09-21 14:08:57 -05:00
Matt Clay
ac492476e5
Bug fixes and cleanup for ansible-test. (#45991)
* Remove unused imports.
* Clean up ConfigParser usage in ansible-test.
* Fix bare except statements in ansible-test.
* Miscellaneous cleanup from PyCharm inspections.
* Enable pylint no-self-use for ansible-test.
* Remove obsolete pylint ignores for Python 3.7.
* Fix shellcheck issuers under newer shellcheck.
* Use newer path for ansible-test.
* Fix issues in code-smell tests.
2018-09-21 11:38:22 -07:00
Sam Doran
b60854357b
Unify terms and UI between 1Password lookups and facts module (#45427)
* Unify login behavior between 1Password lookup plugins and module

- Use the same names for all credential aspects
- Only require the minimal amount of information for each
- Add more examples

* Change parameter terms

- use terms in line with 1Password documentation.
- update examples
- update tests

* Improve error messages in lookup plugin

* Unify onepassword_facts with lookup plugins

- use same methods and logic for signing in or reusing existing session
- unify terms with lookup plugins

* Change rc test for determing login

An rc other than 1 can be returned when a current login session does not exist.

* Create AnsibleModuleError class

ansible.errors is not available to modules, so create an AnsibleModuleError class within the module

Do not user os.path.expanduser since this is already done by virtue of the type being "path" in the argument spec.

* Add note about risk with fact caching sensitive data

* Add note on op version that was used for testing
2018-09-21 14:26:05 -04:00
Matt Clay
45b5685037 Add python.py coverage injector for ansible-test.
This can be used to run Python scripts from the repository with the
correct interpreter and allow collection of code coverage.

Useful for testing contrib inventory scripts.
2018-09-21 11:21:32 -07:00
Rémy Léone
d3d1ff7990 Add a guide for using Online with Ansible (#45277) 2018-09-21 11:43:56 -05:00
Brian Coca
a47671aad1 allow openstack invetnory to work cacheless
fixes #45431
2018-09-21 12:33:24 -04:00
Dag Wieers
66eec42f53 Fix calling deprecate with correct arguments (#44726)
This fixes #44702
2018-09-21 12:30:31 -04:00
Rémy Léone
574ed8dc7f Add documentation about the query filters (#45835) 2018-09-21 12:09:35 -04:00
Colin McCarthy
ccb89a8cb8 [network] fix typo in ftd_configuration - all operation(s) are performed over REST API (#45977) 2018-09-21 11:35:54 -04:00
Matt Clay
2148999048 Improve error handling for docs-build test. 2018-09-21 08:34:07 -07:00
Chris Smolen
0677dabad4 Add docs for say.py to indicate how to list voices (#37737)
* Update say.py

* Update say.py

* Update say.py
2018-09-21 14:51:34 +01:00
Abhijeet Kasurde
0ecbd50c3b Misc typo fixes (#45969)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-09-21 14:43:22 +01:00
Omar Osman
623f803e0b update example to YAML style in documentation (#45968)
The example is in a key=value format which is deprecated.

+label: docsite_pr
2018-09-21 08:42:31 -05:00
tstoner
216da1c475 Changed when condition from checking image version to checking keys being (#45943)
defined
2018-09-21 16:36:37 +05:30
Abhijeet Kasurde
a9680ee3ef
VMware: new module vcenter_extension_facts (#45472)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-09-21 13:57:47 +05:30
Matt Clay
2056c981ae Improve ansible-test match error handling. 2018-09-21 00:05:33 -07:00
Jordan Borean
27c10fa502
add skip/docker alias to skip tests when running on Docker (#45955)
* add skip/docker alias to skip tests when running on Docker

* changed warning message wording
2018-09-21 16:09:54 +10:00
Jordan Borean
198423d6fb
powershell: do not quote join_path result to reflect ShellBase join_path (#45944) 2018-09-21 15:31:12 +10:00
Jordan Borean
ce515a626c
powershell - fix for ANSIBLE_KEEP_REMOTE_FILES on older Pythons (#45942) 2018-09-21 10:03:57 +10:00
Yanis Guenane
a7bf505474 inventory/tower: authors -< author so Doc can pick it up (#45936) 2018-09-20 16:44:22 -05:00
Sam Doran
4b121ea2ad
Remove temp checksum file (#45871) 2018-09-20 16:32:21 -04:00
lwm
0947948d6b Use dashes not underscores for linode labels. (#44719)
This is because underscores are illegals in hostnames and users might
want to create the same host names are the name of the Linode machine
(as in the report in #30059).

Closes https://github.com/ansible/ansible/issues/30059.
2018-09-20 15:42:45 -04:00
lwm
4774ea7a15 Linode: docs note for py3 limitation and deprecated API (#44723)
* Add note that linode-python having no py3 support.

Closes https://github.com/ansible/ansible/issues/44695.

* Add note that the module uses the deprecated API.
2018-09-20 15:41:46 -04:00
Nathaniel Case
0d143ed7f6
Clean up after ansible-connection if failure occurred in start() (#45929) 2018-09-20 15:04:30 -04:00
Andrew Gaffney
acac001742 Add number of skipped tasks to play recap in 'default' callback (#45797) 2018-09-20 14:38:54 -04:00
Michael Johnson
1a3bc7d746 Update azure_rm_virtualmachine.py (#45325)
* Update azure_rm_virtualmachine.py

A lot of Azure images are not cloud-init ready and need to be prepared manually before attempting to use the custom_data option of this module. Adding a line to the description to make others aware. If, like me, they are used to working with AWS AMIs that all seem to have cloud-init baked in, this could prevent some troubleshooting as to why their custom_data scripts aren't running in Azure.

* fixing addition to azure_rm_virtualmachine.py

* Update azure_rm_virtualmachine.py

* final update

* fixed url syntax

* nuked trailing whitespace
2018-09-21 02:22:53 +08:00
Matt Martz
95e77ac853
Ensure that the src file contents is converted to unicode in diff info (#45744)
* Ensure that the src file contents is converted to unicode in diff info. Fixes #45717

* Fix up and cleanup

* The diff functionality in the callback plugins should have the
  to_text() calls removed since we're now doing it in ActionBase
* catching of UnicodeError and warnings in the callback diff
  functionality from 61d01f549f haven't been
  needed since we switched to to_text so remove them.
* Add a note to ActionBase's diff function giving an example of when the
  diff function will be inaccurate and how to fix it

* Fix callback get_diff() tests

I believe the unittests of callback's get_diff() were wrong.  They were
sending in a list where strings were expected.  Because previous code
was transforming the lists into strings via their repr, the previous
tests did not fail but they would have formatted the test cases output
in an odd way if we had looked at it.
2018-09-20 12:31:48 -05:00
Dag Wieers
24dd87bd0a Fix incorrect use of subprocess.CalledProcessError (#45890) 2018-09-20 10:14:11 -07:00
Rémy Léone
693f3219d4 Add Scaleway co-worker (#45925) 2018-09-20 17:41:02 +01:00
Roman D
dd5d191d7a Clarified documentation for the unsafe_writes option (#27471)
* Clarified documentation for the unsafe_writes option per #24449.
2018-09-20 11:40:14 -05:00
Larry Singer
17ca0a9bd9 The keyword 'cloud' has been deprecated in favor of the 'profile' keyword by os-client-config. (#31389) 2018-09-20 11:31:19 -05:00
Rémy Léone
7c7a7efbbe Add an option to enable public ip at server creation (#44826) 2018-09-20 12:13:26 -04:00
Adam Miller
2fe150a1ef fix dnf wildcard pkg removal - fixes #27744 and #36970 (#45357)
Signed-off-by: Adam Miller <admiller@redhat.com>
2018-09-20 12:13:17 -04:00
max-allan-surevine
cb460dee74 Update keycloak_client.py (#43547)
* Update keycloak_client.py to document the 'realm' parameter, eliminate E322 ignore
2018-09-20 10:34:04 -05:00
Nathaniel Case
406b59aeba
Move persistent connections to only use registered variables (#45616)
* Try to intuit proper plugins to send to ansible-connection

* Move sub-plugins to init so that vars will be populated in executor

* Fix connection unit tests
2018-09-20 09:56:43 -04:00
John R Barker
86c48205c4 BOTMETA - redfish (#45909) 2018-09-20 08:38:10 -04:00
Jose Delarosa
e701b5a412 Fixes HTTP redirect issue (#45513) 2018-09-20 15:23:51 +03:00
Alicia Cozine
34b8cbd365 Explain what happens when gpgcheck is not set in yum
PR #45796
2018-09-20 15:14:55 +03:00
Yanis LISIMA
45c7facd64 ec2_vpc_igw: migrate to boto3 (#45346)
* ec2_vpc_igw: draft migrate to boto3

* ec2_vpc_igw: migrate to boto3

* ec2_vpc_igw: fix error and implement code review

* ec2_vpc_igw: always catch BotoCoreError with ClientError, remove unused fail method

* ec2_vpc_igw: fix pep error
2018-09-20 19:56:19 +10:00
Jordan Borean
5c73d4f4bd
async: use async_dir for the async results file directory (#45461)
* win async: use async_dir for the async results file directory

* tried to unify POSIX and PowerShell async implementations of async_dir

* fix sanity issue
2018-09-20 19:37:54 +10:00
Zim Kalinowski
60979a96a9
Fixing azure_rm_containerregistry_facts (#45897)
* fixing cr facts

* final fix?

* fixed

* syntax

* sanity
2018-09-20 16:58:07 +08:00
Matt Clay
5a3000af19 Support comments in ansible-test flat files. 2018-09-20 00:48:00 -07:00
Dag Wieers
cb4bf04be6 Fix pylint error on utf8 character in string (#45880)
Small fix
2018-09-20 12:01:44 +10:00