Commit graph

2489 commits

Author SHA1 Message Date
Dennis Conrad
c1787da7ff Fix UnboundLocalError if 'access_key_ids' not supplied
'key_ids' is referenced before it is assigned, causing the module to fail with a UnboundLocalError instead of failing gracefully with a helpful error message.  This very small patch moves the assignment of 'key_ids' to before the variable is referenced.
2016-04-19 19:53:21 +02:00
Marcin
5312627091 rebase for #2477, ready_for_review (#2581) 2016-04-16 21:50:53 +02:00
Michael Fenn
09f14731f2 Support altering the virtual cdrom when state == reconfigured (#2394)
This allows a user to modify the state of the virtual cdrom in a VM
by using the state == reconfigured action.  This is useful for
provisioning VMs from templates which do not have ISO images connected.
2016-04-16 21:49:43 +02:00
Alexey Wasilyev
1c3071af61 docker: support polling image by digest (#2932) 2016-04-16 21:46:02 +02:00
Joel Thompson
a39d11e8f5 Add exponential backoff retries to ec2_elb_lb (#3379)
ec2_elb_lb doesn't react well to AWS API throttling errors. This
implements an exponential backoff operation around some of the AWS API
calls (with random jitter, in line with AWS recommendations) to make
this more resilient.
2016-04-16 21:43:03 +02:00
Donovan Jones
7c52ea58f1 Make remote_group handle name and id in cloud/openstack/os_security_group_rule.py
* Make remote_group handle name and id

* fix regression breaking os_security_group_rule with no remote_group
2016-04-14 20:03:13 +02:00
David Shrewsbury
25e75e66eb Merge pull request #3236 from rcarrillocruz/network_by_project
Add project parameter to os_network
2016-04-14 10:27:42 -04:00
Ricardo Carrillo Cruz
3e93204598 Add project parameter to os_network
A cloud/domain admin should be able to create a network on any project
it is granted to.
This changes adds the possibility to pass either a project ID or
project name.
2016-04-14 13:20:28 +00:00
David Shrewsbury
cea5ceb644 Merge pull request #3237 from rcarrillocruz/os_subnet_by_project
Create subnet by project
2016-04-13 15:41:17 -04:00
Michael Moussa
ff414b79f2 Fixes read replica create BC break (#3365) 2016-04-12 23:32:12 +02:00
William Holroyd
4837b04668 Added ap-northeast-2 region (#2849) 2016-04-12 23:29:04 +02:00
Rob
68c8669200 Fix to ensure youngest snapshot is retrieved rather than oldest (#3115) 2016-04-12 23:21:58 +02:00
jjshoe
52823bdb5b Speed up AMI code by not attempting to create the AMI without checkin… (#2551)
* Speed up AMI code by not attempting to create the AMI without checking on the name first. Also simplifies code for reporting errors from AMI creation, greatly.

* remove sys.exit
2016-04-12 23:17:01 +02:00
Marcin
2e20e548f8 Check if identifier is specified for geo,weighted or failover routing. Don't fail if record set already exist. Set choices for failover - capital PRIMARY and SECONDARY. (#2470) 2016-04-12 22:06:41 +02:00
Fabian von Feilitzsch
edc8698c14 make binds a list instead of a dict (to prevent overwriting when copying the same file to two places) (#2294) 2016-04-12 22:01:45 +02:00
Matt Davis
6d0e9327e3 Merge pull request #3342 from gundalow/docsfix
ansible-validate-modules part 1: Correct documentation
2016-04-12 12:26:27 -07:00
Ricardo Carrillo Cruz
8a03ae5287 Create subnet by domain
A cloud/domain admin should be able to create a subnet on any
project it is granted on.
This change adds the 'project' parameter that accepts either
a name (admin-only) or id.
2016-04-12 17:58:01 +00:00
Rene Moser
85c45d9fd1 openstack: doc fix, add version_added
see #3388
2016-04-10 11:37:53 +02:00
David Shrewsbury
99659036ca Merge pull request #3363 from rcarrillocruz/check_default_project_if_present
Only check default_project on resource creation
2016-04-08 14:21:26 -04:00
Matt Martz
e9227c4d8f overwrite option was added for 2.1 2016-04-08 11:36:14 -05:00
Monty Taylor
265c3fdfb5 Merge pull request #3388 from Shrews/os_network_provider
Add support for provider network options
2016-04-08 08:18:17 -07:00
David Shrewsbury
29bd86394e Add support for provider network options.
Adds new parameters for specifying options for provider network plugins.
2016-04-08 09:31:26 -04:00
David Shrewsbury
6970cc233f Wrap calls to main() with if check
A change was merged to the main Ansible core code that can cause

a potential hang if any libraries are called that use threading.

This change was:



  4b0aa1214c



This affected the os_object module by causing a hang on the shade

create_object() API call (which in turn calls swiftclient which

uses threading). The fix is to make sure all modules have a main()

that is wrapped with an "if __name__ == '__main__'" check.
2016-04-06 12:18:35 -07:00
John Barker
531eed80b3 Replace BOOLEANS with true/false 2016-04-05 16:31:15 +01:00
Kalle Lehtonen
5aa652c6fd Fix and add more error handling for role policies
In case role policy was deleted, we did not handle at all if there

was authorization issue to do the deletion. Also add message when

role is not found and the policy is skipped.
2016-04-05 09:55:49 -04:00
Ricardo Carrillo Cruz
ee2d436aa5 Only check default_project on resource creation
The default_project is checked at the beginning of the module.
This raises an exception if the project passed does not exist.
This logic only makes sense on resource creation, if a user
puts state=absent the module fails, even though the default
project is not relevant
2016-04-04 13:20:00 +00:00
Brian Coca
2ddeb5cdec fixed doc quoting 2016-04-01 17:48:39 -04:00
Brian Coca
20e4ad0eef corrected required docs as only boolean is allowed
these complex values were not displayed and would always show the fields as requried
2016-04-01 16:59:12 -04:00
René Moser
bd2924b8ff Merge pull request #3133 from alachaum/fix-elasticache-idempotency
Fix aws elasticache idempotency
2016-03-31 19:27:15 +02:00
René Moser
18367243e4 Merge pull request #3341 from Shrews/os_server_wait
Pass wait/timeout parameters to floating IP APIs in os_server
2016-03-31 15:32:58 +02:00
Jonathan Davila
8b13f2a693 Merge pull request #2278 from wimnat/feature/iam_doc_fix
IAM doc fix
2016-03-30 08:27:32 -04:00
René Moser
fa8cb762ed Merge pull request #3161 from somechris/fix-boto-version-requirement
Guard against too old boto library
2016-03-30 07:23:52 +02:00
David Shrewsbury
aecec868d5 Pass wait/timeout parameters to floating IP APIs in os_server
If a server already exists when os_server is run, but a floating
IP was not assigned to the server when one was requested, the
module will attempt to add an IP to the existing server. But it
would not pass the wait/timeout params to the floating IP APIs.
If wait was True, you could get back a server dict that did not
show the floating IP because it did not wait.
2016-03-29 13:42:41 -04:00
David Shrewsbury
772d9eb88e Set type on floating_ip_pools in os_server
This has been expected as a list, so let's be explicit about it
so it will work correctly in 2.1 release.
2016-03-29 10:13:49 -04:00
Ricardo Carrillo Cruz
6e6817ce18 Fix is_public type on os_image
Without this fix, the is_public value is a string and the shade
call handling the module does not evaluate correctly when
passing is_public: no
2016-03-29 11:37:49 +00:00
René Moser
5e90c86519 Merge pull request #2702 from curious-eyes/add-gce-preemptible
Add preemptible option on gce.py
2016-03-28 00:06:43 +02:00
René Moser
7e879eca32 Merge pull request #2968 from ashwanthkumar/exponential-backoff-in-route53
add retry with exponential backoff on route53
2016-03-27 23:54:37 +02:00
Michael Scherer
74fd65b2d8 s/plubic/public/in the doc 2016-03-26 14:17:26 +01:00
René Moser
13f4b40c15 Merge pull request #3284 from mscherer/fix_docker_args
Improve/fix type checking for docker module
2016-03-25 23:43:52 +01:00
Ash Wilson
f4557c1631 Remove myself from the docker module maintainers
Apologies, but I no longer use this module day-to-day myself, and I don't have the bandwidth right now to effectively triage changes in any kind of timely fashion.
2016-03-24 10:03:47 -04:00
Brian Coca
dabf28edbe Merge pull request #2853 from Igelko/patch-1
docker: If cmd and entrypoint not set, don't match them
2016-03-24 06:29:49 -07:00
curious-eyes
24f1afc606 Add preemptible option on gce.py 2016-03-24 18:17:21 +09:00
Victor Beresnev
6a279fd421 If cmd and entrypoint not set, don't match them
Hello!
I wanted stop the containers matched only by image name, but can't do this, if I not set cmd in playbook.
This behavior confused me.

If cmd or entrypoint is defined for running container, but not defined in playbook, makes matching behavior as this sample:
https://github.com/ansible/ansible-modules-core/blob/devel/cloud/docker/docker.py#L463
2016-03-24 11:53:49 +04:00
Brian Coca
c10daa5d80 Merge pull request #3302 from rcarrillocruz/allow_domain_name_os_user
Allow passing domain name on os_user
2016-03-23 14:31:40 -07:00
Ricardo Carrillo Cruz
d26f788519 Allow passing domain name on os_server
A cloud admin can search domains, thus it should be possible
to pass a domain name, just like ids.
2016-03-22 17:56:46 +00:00
David Shrewsbury
827fd9acc2 Fix allowed_address_pairs and extra_dhcp_opts in os_port
Commit f71542c set the incorrect type for these two parameters to
dict when they are actually list of dicts.

Also, the extra_dhcp_opts was incorrectly named (without the terminal
's') and NEVER worked, so this was corrected.

Fixes #3301
2016-03-22 08:26:07 -04:00
David Shrewsbury
318cc16c27 Fix size parameter documentation
The generated documentation shows the size parameter as required.
Set 'required' to 'false' and move the explanation to the description.

Fixes #3278
2016-03-21 16:13:29 -04:00
Brian Coca
cf03730fa2 added version added 2016-03-21 11:34:56 -07:00
Brian Coca
73586f7ddb Merge pull request #3124 from nbrownus/elb_proxy_protocol
ELB Proxy Protocol support for backends
2016-03-21 11:25:56 -07:00
Brian Coca
62310c8954 Merge pull request #3077 from jjshoe/devel
Allow us to sort by all available datatypes
2016-03-21 11:23:23 -07:00