cmueller/ansible
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity
11668 commits 47 branches 390 tags 440 MiB
Commit graph

4739 commits

Author SHA1 Message Date
James Cammarata
e6fa50a306 Move splitter to module_utils so modules can use it and fix command arg splitting 
Fixes #8338
 2014-07-29 14:55:16 -05:00
Wayne Rosario
eaf4571e42 Adding the following Test Coverage: 
Use mysql_user module to create, delete users.
Update user password and ensure new password was updated for the correct user.
Assert user has access to multiple databases
Assert user creation, deleting using different user privilege and ensure privilege work correctly.
 2014-07-29 11:49:53 -04:00
RomanDolejsi
fcf7f03398 file: prevent replace failure when overwriting empty directory with hard/link (force=yes) 2014-07-29 10:46:32 +02:00
Michael DeHaan
f948a94f51 Merge pull request #8313 from sivel/issue/8250 
Make sure to assign pyrax.cloudservers to cs. Fixes #8250
 2014-07-28 15:48:51 -04:00
Michael DeHaan
6300ded89c Merge pull request #8311 from neersighted/wrap_distroversion 
Wrap get_distribution_version() in the hostname module
 2014-07-28 15:48:18 -04:00
Matt Martz
571f343e7d Make sure to assign pyrax.cloudservers to cs. Fixes #8250 2014-07-28 12:44:42 -05:00
Michael DeHaan
226dacc7e6 Cleaning up explanation of mount module states. 2014-07-28 12:18:45 -04:00
Bjorn Neergaard
adcdbdf894 Wrap get_distribution_version() in the hostname module 
We wrap get_distribution_version() with a new function,
_get_distribution_version(), that returns `0` when the result is a string or
`None`.

This accounts for the case when get_distribution_version() returns a string,
and we try to compare it to a float. We do this in the hostname module instead
of the module snippets because other modules may want the real string
version.module snippets because other modules may want the real string version.
 2014-07-28 11:16:30 -05:00
Michael DeHaan
b69f096e8a Merge branch 'ufw' of git://github.com/Trozz/ansible into devel 2014-07-28 12:08:29 -04:00
Michael DeHaan
726a1a33e0 Update unarchive example. 2014-07-28 12:07:31 -04:00
Michael DeHaan
f412d341e3 Merge pull request #8200 from geetotes/devel 
[Docs] Added another example to demonstrate unarchive module working entirely on a remote machine
 2014-07-28 12:04:33 -04:00
Michael DeHaan
c8d3c0c654 Merge pull request #8244 from wrosario/mysql_user_doc 
Update mysql_user doc and example
 2014-07-28 12:03:15 -04:00
Michael DeHaan
8b77aa9843 Merge pull request #7949 from hacosta/apt_key 
Check at most 16 characters of the key. Fixes #7936
 2014-07-28 11:30:27 -04:00
Michael DeHaan
216f803aa5 Merge pull request #7954 from alimony/patch-3 
cron module: Use correct parameter name in error message.
 2014-07-28 11:29:05 -04:00
Michael DeHaan
a52cbdbced Merge pull request #8068 from trondhindenes/win_feature_improvements 
Updates to the parameters of win_feature
 2014-07-28 11:25:41 -04:00
Michael DeHaan
e75964e206 Merge pull request #7969 from dedalusj/devel 
Fixed bug with environment path for homebrew_cask
 2014-07-28 10:49:04 -04:00
Michael DeHaan
58a23bc6d1 Merge pull request #7968 from bcoca/acl_fix_compare 
acl module: now compares permissions correctly
 2014-07-28 10:47:38 -04:00
James Cammarata
d1d318b028 Merge pull request #8308 from robinro/extend-hostname-distrolist 
Extended distributions list for hostname module
 2014-07-28 09:12:59 -05:00
Robin Roth
e91c318327 Fix extra newline at end of hostname for Fedora 
This fixes a bug introduced by 138b45e3.
The hostname has an additional newline at the end which leads to the
state always being 'changed: true' even if the hostname is unchanged.
 2014-07-28 15:22:10 +02:00
Robin Roth
7a09f87b8c Extended distributions list for hostname module 
Implementations already present
 2014-07-28 15:19:41 +02:00
James Laska
d51e10a3f4 Correct BotoServerError typo in ec2 module 
Resolves a traceback due to an undefined 'BotoSeverError' exception.
 2014-07-26 12:11:25 -04:00
Lee Gillentine
d631056f27 Pushing up correct example :( 2014-07-25 14:19:02 -05:00
James Cammarata
1134f6169c Minor indentation fixes on ec2_eip 2014-07-25 12:41:25 -05:00
James Cammarata
3281139981 Merge branch 'fix_ec2_eip' of https://github.com/jsmartin/ansible into jsmartin-fix_ec2_eip 2014-07-25 12:37:36 -05:00
James Cammarata
4a8e068855 Merge pull request #8292 from jimi-c/issue_7863_deb_with_items 
Allow deb package installation via with_items
 2014-07-25 10:46:37 -05:00
James Martin
1453f7b013 Fixes #8290. 2014-07-25 11:08:49 -04:00
Tom Lazar
146a0f1cb7 FreeBSD 10 compatibility fix 
On FreeBSD the whitespace around the ``=`` triggers a (cryptic) ``no such file or directory`` error. removing the whitespace like above fixes this.
 2014-07-25 14:33:24 +02:00
anatoly techtonik
b28848eee3 acl: Remove obscurity in state description 2014-07-25 12:04:45 +03:00
Philip Jay
138fffb152 Add fstype arg to the mount examples 
Needed fstype in the examples, since fstype is a required argument for
mount.
 2014-07-25 09:58:54 +10:00
Michael DeHaan
c9a3b6c358 Pagerduty corrected misleading blog post, so no problems with them being in core now. Thank you guys! 2014-07-24 15:21:53 -04:00
Wayne Rosario
d595fd00e9 updating doc to include revoke example for mysql_user docs 2014-07-24 10:32:28 -04:00
Michael DeHaan
1e427d4ace Merge pull request #7710 from brad/zounds 
use the full list of available campfire sounds
 2014-07-24 09:35:27 -04:00
Michael DeHaan
2e2a1d4bd1 Merge pull request #8270 from berenddeboer/mount-fstab 
Default for fstab missing, causing KeyError: 'fstab'
 2014-07-24 08:03:33 -04:00
James Cammarata
2cc602beea Fixes for module param counting and additional shell quoting issues 2014-07-23 22:54:59 -05:00
Berend de Boer
869cc7947e Default for fstab missing, causing KeyError: 'fstab' 2014-07-24 13:14:46 +12:00
James Cammarata
75e5b6401c Fixing up shell quoting issues 2014-07-22 10:09:11 -05:00
Trond Hindenes
387759ada6 win_setup improvements: Correcly outputs ansible_totalmem on computers with multiple ram chips 2014-07-22 01:38:46 +02:00
James Cammarata
593057515c Merge pull request #8223 from renard/create-fstab-if-not-exists 
Create fstab if not exists
 2014-07-21 15:03:14 -05:00
Sébastien Gross
48128ec0ab [mount] make sure fstab exists 
This is mainly to prevent from failing with no such file or directory
during module execution.
 2014-07-21 18:32:02 +02:00
Sébastien Gross
f2e2337d07 [mount] Add documentation for fstab option 2014-07-21 18:30:59 +02:00
James Cammarata
84759faa09 Security fixes: 
* Strip lookup calls out of inventory variables and clean unsafe data
  returned from lookup plugins (CVE-2014-4966)
* Make sure vars don't insert extra parameters into module args and prevent
  duplicate params from superseding previous params (CVE-2014-4967)
 2014-07-21 11:20:49 -05:00
Michael DeHaan
2769b3d0b2 Update version_added attribute on recent GCE module additions. 2014-07-19 19:08:28 -04:00
Michael DeHaan
98c6688343 Merge pull request #6976 from clconway/gce-snapshots 
Adds support for snapshots and extra persistent disks to the gce modules
 2014-07-19 19:07:29 -04:00
Hector Acosta
ec70bb01ef Add check_mode support to authorized_key. Fixes #7300 
Signed-off-by: Hector Acosta <hector.acosta@gmail.com>
 2014-07-19 17:55:58 -05:00
Lee Gillentine
69337362e7 Adding another example to demonstrate unarchive working entirely on a remote machine 2014-07-18 22:22:37 -05:00
Michael DeHaan
9caa93c1cf Add note about useful quote filter. 2014-07-18 18:23:48 -04:00
Jonathan Mainguy
6789098bc5 This fixes 8173, if target was not defined it would break, now it wont 2014-07-18 09:52:37 -04:00
Will Angenent
0e33db837a Fix for issue #8152: Missing auth headers and a faulty JSON decode 
Looks like this regressed in commit 9730157 due to fetch_url refactors.
 2014-07-17 23:04:51 +01:00
Yasser Nabi
8a6bbfd3b5 Enable puppet facts 
Currently facter facts omit facts that a distributed via Puppet. This
commit adds the `--puppet` option.

In cases where puppet is not installed, the command sends a warning to
STDERR *but* completes successfully. So should not cause any issues.

The benefit is, filtering can be done based on facts set by Puppet.
 2014-07-17 17:53:12 +01:00
Jacob Hickey
ea9af2cbb1 Add missing params to get_target_from_rule 
get_target_from_rule was extracted from main() without enough parameters for
all the local variables it took with it from the extraction site.
 2014-07-17 11:03:38 -04:00
Michael DeHaan
515d10fd88 Merge pull request #8172 from phenomenes/channel-key-parameter 
Adds channel key parameter
 2014-07-17 08:14:26 -04:00
Michael DeHaan
3aa10d9db5 Merge pull request #8145 from amandolo/ec2_tag 
Fix EC2_TAG module output structure when listing tags
 2014-07-17 07:45:53 -04:00
Jimena Cabrera-Notari
7efd8b61a6 Adds channel key parameter 2014-07-16 21:44:52 +01:00
Michael DeHaan
64b874129f Merge pull request #8139 from peterkh/devel 
Fix "TypeError: group id must be integer" if groupid passed in for group key
 2014-07-16 15:55:14 -04:00
Michael DeHaan
ec874193fe Merge pull request #8143 from PinGwynn/feature 
portage: default exit (not fail) if sync=yes in check mode
 2014-07-16 15:51:56 -04:00
James Cammarata
68e59332c7 Merge branch 'patch-2' of https://github.com/napkindrawing/ansible into napkindrawing-patch-2 2014-07-16 13:46:00 -05:00
James Cammarata
ac73822405 Expand target for mysql_db 
Fixes #8128
 2014-07-16 13:39:47 -05:00
James Cammarata
d7469218a5 Merge pull request #8126 from dingus9/patch-1 
Update lineinfile validate help
 2014-07-16 13:28:21 -05:00
James Cammarata
02a6d5224f Merge pull request #8124 from dataxu/dev-asg-set-health-checks 
Added setting of the health_check options on an existing ASG
 2014-07-16 13:19:52 -05:00
Michael DeHaan
616d749ab3 Merge pull request #8156 from jirutka/fix-layman 
layman: remove my email address
 2014-07-16 11:22:13 -04:00
James Cammarata
3492e8748e Merge pull request #8146 from rmarchei/8102 
fix get_distribution_version() on amazon linux
 2014-07-16 09:57:28 -05:00
James Cammarata
19571d3f23 Merge pull request #7914 from hacosta/devel 
Correctly handle .repo files in zypper_repository module
 2014-07-16 09:55:35 -05:00
Ruggero Marchei
8904c61932 fix LooseVersion exception with empty distribution_version 2014-07-16 07:55:20 +02:00
Jakub Jirutka
437dc0a9ef layman: remove my email address 2014-07-16 01:29:36 +02:00
Michael DeHaan
ca918cd3dd Merge pull request #8118 from oxyrox/devel 
Typo
 2014-07-15 18:15:08 -04:00
Michael DeHaan
ee179e1149 Merge pull request #8111 from hfinucane/gh-8108 
Fix pip failure when version is parsed as a float
 2014-07-15 18:07:03 -04:00
Michael DeHaan
8da853ec7a Slight typo fix. 2014-07-15 18:08:11 -04:00
Michael DeHaan
3d1865e6c9 Pagerduty has advocated not using ansible for certain sizes of infrastructure. This module is removed until this is corrected. 
http://blog.pagerduty.com/2014/06/10-common-ops-mistakes/?utm_source=twitter&utm_medium=social&utm_campaign=blog
 2014-07-15 18:07:24 -04:00
Michael DeHaan
8f97f8a5f1 Merge pull request #8107 from hfinucane/optional-rsync-compress 
Make 'compress' optional
 2014-07-15 18:05:25 -04:00
Michael DeHaan
50f51367f9 Merge pull request #8106 from muff1nman/pacman-update-checkmode-fix 
Fix #8047
 2014-07-15 18:04:50 -04:00
Maxim Odinintsev
a587d13c65 portage: default exit (not fail) if sync=yes in check mode 2014-07-15 16:04:19 +03:00
Andrea Mandolo
d346b76fb7 Fix EC2_TAG module output structure when listing tags 2014-07-15 14:26:53 +02:00
Peter Hall
09a5d8f6d1 Fix "TypeError: group id must be integer" if groupid passed in for group 
key
 2014-07-15 11:16:47 +10:00
Ruggero Marchei
d6bca15aa5 fix issue #8102 2014-07-15 01:26:44 +02:00
James Cammarata
eb80bd1a56 Break out of loop for sockets in wait_for when there's no data to read 2014-07-14 14:14:13 -05:00
napkindrawing
fe74cb0ad0 New option for route53: retry_interval 
The current (hard-coded) retry interval of 500 seconds can cause ansible to have excessive run-times in the case of many domains. `retry_interval` provides a way to customize the wait between retries of calls to route53.
 2014-07-14 15:07:47 -04:00
James Cammarata
d80f4cee9d Merge branch 'wait-for-port-search-regex' of https://github.com/sivel/ansible into sivel-wait-for-port-search-regex 2014-07-14 13:16:11 -05:00
Nick Shobe
d1ebf7fcf1 Update lineinfile 2014-07-14 13:09:57 -05:00
James Cammarata
49d07ca4cc Adding a note about 'type' field becoming required in rax_dns_record 2014-07-14 12:30:39 -05:00
James Cammarata
b2f09d3989 Merge branch 'rax-ptr' of https://github.com/sivel/ansible into sivel-rax-ptr 2014-07-14 12:27:46 -05:00
Matt Ferrante
66d3d75b35 Added setting of the health_check options on an existing ASG 2014-07-14 13:21:02 -04:00
James Cammarata
d52b50cb03 Merge pull request #7478 from sivel/rax-keypair-filepath 
rax_keypair module: Allow public_key to be a path to a file
 2014-07-14 10:41:38 -05:00
James Cammarata
8753849959 Merge pull request #7477 from sivel/rax-user-data 
rax module: Support config_drive and user_data
 2014-07-14 10:25:28 -05:00
Aladin Jaermann
015a22ffba Correct typo 2014-07-14 10:49:08 +02:00
Henry Finucane
dfd1470c22 Ensure version is a string 2014-07-12 21:05:32 -07:00
Henry Finucane
49889bd808 Make 'compress' optional 2014-07-12 10:13:04 -07:00
Andrew DeMaria
5fdd2a7b01 Fix #8047 
Ensure that json is returned when only updating the cache and in check mode
 2014-07-12 10:57:30 -05:00
James Martin
e36ef4defb Updated tag behavior. 2014-07-11 16:48:37 -04:00
James Cammarata
8a6cfa1a23 Merge pull request #8103 from Jmainguy/mysql_db_6214 
mysql_db: Fix error message for #6214
 2014-07-11 14:47:03 -05:00
James Cammarata
fe3f6b3253 Merge pull request #8104 from AdmiralNemo/patch-1 
Correct regex in is_keyid
 2014-07-11 14:30:35 -05:00
James Cammarata
aa08368b8f Merge pull request #8094 from ghjm/vsphere-fixes 
Fixed tracebacks during VM creation. Fixes #8067.
 2014-07-11 14:22:53 -05:00
Dustin C. Hatch
dc304e6488 Correct regex in is_keyid 
The `rpm_key` module claims to take a key ID as an argument, however it fails if one is actually given:

    msg: Not a valid key DEADBEEF

The reason for this is the regular expression in the `RpmKey.is_keyid` method is incorrect; it will only match the literal string "0-9a-f" exactly 8 times, rather than exactly 8 characters in the set 0-9 or a-f.
 2014-07-11 14:02:25 -05:00
Jonathan Mainguy
40ef07a286 Errors out with stderr 1049, unknown database: when importing a database that does not exist 2014-07-11 14:57:45 -04:00
James Cammarata
5e0d07c93e Merge pull request #8092 from ghjm/mysql-exceptions 
Added exception handling to database creation and deletion. Fixes #8075.
 2014-07-11 11:59:12 -05:00
James Cammarata
9dc1931576 Merge pull request #8093 from ghjm/mysql-dbname 
Switched primary and alias names of the name/db parameter. Fixes #8065.
 2014-07-11 11:57:20 -05:00
Michael DeHaan
fbdb10d8a5 Documentation simplification for git module parameter 2014-07-11 08:44:29 -04:00
Graham Mainwaring
fb83bdffa8 Fixed tracebacks when datacenter not found, when notes not given, and when collecting facts after VM creation. Fixes #8067. 2014-07-10 23:05:23 -04:00
Graham Mainwaring
22390e50e5 Switched primary and alias names of the name/db parameter, to match documentation. Fixes #8065. 2014-07-10 22:37:46 -04:00
Graham Mainwaring
980d9da7e9 Added exception handling to database creation and deletion. Fixes #8075. 2014-07-10 22:28:56 -04:00
James Cammarata
c96b2ae391 Merge pull request #8080 from ciupicri/service 
Remove unused code
 2014-07-10 12:27:53 -05:00
James Cammarata
4d86bbe6dc Merge pull request #8086 from dataxu/dev-fix-typo 
Bug Fix - fixed the choices typo got the ec2_asg module
 2014-07-10 12:20:21 -05:00
James Cammarata
3a6d00f81d Add note about changing resource_tags to required in ec2_vpc 2014-07-10 12:18:35 -05:00
James Cammarata
2184b15542 Merge branch 'psa-resource-tag-required' into devel 2014-07-10 12:17:39 -05:00
Matt Ferrante
03fc2714f1 fixed the choices typo got the ec2_asg module 2014-07-10 11:01:19 -04:00
James Cammarata
3e7d91723f Adding version_added for new vm_hw_version field in vpshere_guest 2014-07-10 08:53:56 -05:00
James Cammarata
87d1cdd035 Merge branch 'fix-7206' of https://github.com/hiciu/ansible into hiciu-fix-7206 2014-07-10 08:19:05 -05:00
Trond Hindenes
d5a0c18170 Better result handling 2014-07-10 12:00:00 +02:00
James Cammarata
dc89cc5f44 Merge pull request #8079 from Jmainguy/mysql_db_8070 
Makes ansible fail if login_port is defined and login_host is either not...
 2014-07-09 15:49:45 -05:00
Cristian Ciupitu
6a8bc42014 Remove useless code 2014-07-09 23:11:15 +03:00
Jonathan Mainguy
90f7f82224 Makes ansible fail if login_port is defined and login_host is either not defined, or defined as localhost. This is because if login_host is localhost then MySQLdb will use the socket instead of TCP. This leads to confusion for ansible users as, when a port is defined it gets ignored if login_host is localhost. This is to fix the bug reported by wrosario #8070. Info on MysqlDb can be read here http://mysql-python.sourceforge.net/MySQLdb.html 2014-07-09 14:38:27 -04:00
James Cammarata
0798f3cda4 Merge branch 'issue_7848' of https://github.com/mpeters/ansible into mpeters-issue_7848 2014-07-09 12:24:06 -05:00
James Cammarata
26707568c7 Merge branch 'issue_7906' of https://github.com/mpeters/ansible into mpeters-issue_7906 2014-07-09 12:09:40 -05:00
James Cammarata
aecd292f13 Merge branch 'resource-tag-required' of https://github.com/psa/ansible into psa-resource-tag-required 2014-07-09 11:49:41 -05:00
James Cammarata
06f72ca3b1 Merge branch 'bug/8057' of https://github.com/ericwb/ansible into ericwb-bug/8057 2014-07-08 14:38:35 -05:00
Trond Hindenes
3bf16805e1 improvements to win_feature 2014-07-08 18:04:12 +02:00
Andreas Fleig
30ad859fe0 ini_file: replace lambda with named function 
Fixes #6876
 2014-07-08 10:17:03 -05:00
James Cammarata
0da5996bb5 Merge pull request #8049 from ranjan/dev 
Provision VM using virtual network.
 2014-07-08 10:11:18 -05:00
Eric Brown
cdedb0f817 Adds an option to specify the glance endpoint type 
Some environments that utilize an SSL terminator with a self-signed
certificate can use the publicURL without getting certificate
verify errors.  This allows using the internalURL with in my case
is HTTP and not HTTPS.

Closes issue: #8057
 2014-07-08 00:30:40 -07:00
James Cammarata
1f2a436bbf Merge pull request #8038 from caphrim007/correct-missing-msg-argument 
Fix missing msg argument
 2014-07-05 00:30:20 -05:00
James Cammarata
ec16b18bab Merge pull request #8036 from sqs/remove-fragile-RDS-instance-type-validation 
Remove validation of RDS DB instance type names because Amazon frequently adds new ones
 2014-07-05 00:29:12 -05:00
James Cammarata
1f813ba128 Merge pull request #8022 from psa/vpc-gateway-peering 
Fix for #7368 breaks peering connections. Unreak them.
 2014-07-05 00:08:04 -05:00
Tim Rupp
4a871f496a Fix missing msg argument 
The following patch adds a missing 'msg=' syntax. An exception is raised
in ansible if this block is reached during the execution of the module

    TypeError: fail_json() takes exactly 1 argument (2 given)

With the 'msg=' added, you get a more informative error. For example

    msg: No settings provided to update_domain().
 2014-07-04 14:00:15 -05:00
Michael DeHaan
1a3a3af04c Merge pull request #8015 from cchurch/test_win_service 
win_service module updates and tests
 2014-07-03 19:29:24 -05:00
Quinn Slack
9190df2aa9 Remove validation of RDS DB instance type names because Amazon frequently adds new ones 2014-07-03 15:57:28 -07:00
Ranjan Kumar
ac252ea731 Provision VM using virtual network. 2014-07-03 15:36:51 +05:30
Paul Armstrong
97b3e8c6e4 Fix for #7368 breaks peering connections. Unreak them. 2014-07-02 23:13:29 +00:00
James Cammarata
746f52c5aa Merge pull request #7896 from botify-labs/feature/add-instance-monitoring-to-ec2-lc 
Adds support for Cloudwatch detailled monitoring in ec2_lc module.
 2014-07-02 09:50:27 -05:00
James Cammarata
0ee28c1a0e Make sure subnets and route_tables are initialized before using 
Fixes #7712
 2014-07-02 09:26:51 -05:00
Chris Church
efc07cf627 Return service name, display name, start mode and state from win_service module. 2014-07-02 08:12:40 -04:00
Paul Armstrong
d5b6781482 Make resource_tags required and do whitespace cleanup 2014-07-01 12:33:06 -07:00
Michael Leer
891aa41001 add interfact documentation #7704 2014-07-01 18:49:07 +01:00
Prune
42966c22da added missing force flag on mkfs commandline 
even if the option ```force=yes``` is used in the playbook, it is not reflected in the mkfs command line.
As force option is dependent of the fs type, a "if-then-else" case have been added. Also, some FS types does not have a force option.
 2014-07-01 15:09:39 +02:00
Lorin Hochstein
7413e501a1 ec2_ami_search: new EBS types 
In ec2_ami_search module, add support for the new SSD-backed EBS (ebs-ssd)
volume as well as support for provisioned IOPS (ebs-io1).
 2014-06-29 16:53:52 -04:00
Jacopo
0a5cac5657 Fixed bug with environment path for homebrew_cask 2014-06-28 14:27:33 +10:00
Brian Coca
e1d57d8876 now compares permissions correctly 2014-06-28 00:24:16 -04:00
Markus Amalthea Magnuson
a44e322db4 Use correct parameter name in error message. 
The parameter is called `cron_file` but the error message uses `file` which is confusing.
 2014-06-27 14:53:54 +02:00
Hector Acosta
f870120b3c Check at most 16 characters of the key. Fixes #7936 
Signed-off-by: Hector Acosta <hector.acosta@gmail.com>
 2014-06-27 03:18:54 -05:00
Hector Acosta
d3268d05ec Correctly handle .repo files in zypper_repository module 
Before the changes, removing a repository required a repo url. This shouldn't be required since zypper allows removing a repo based on its alias (mapped to name in this module).

The name variable was always required, which is misleading since repofiles provide their own alias. So a runtime check was added to avoid this confusion.

Additionaly, running this module on .repo files weren't idempotent. e.g

Before:
$ ./hacking/test-module -m library/packaging/zypper_repository -a "repo=http://download.opensuse.org/repositories/devel:/languages:/python/SLE_11_SP3/devel:languages:python.repo name=foo"
{"repo": "http://download.opensuse.org/repositories/devel:/languages:/python/SLE_11_SP3/devel:languages:python.repo", "state": "present", "changed": true}
$ ./hacking/test-module -m library/packaging/zypper_repository -a "repo=http://download.opensuse.org/repositories/devel:/languages:/python/SLE_11_SP3/devel:languages:python.repo name=foo"
{"msg": "Repository named 'devel_languages_python' already exists. Please use another alias.\n", "failed": true}

After:
$ ./hacking/test-module -m library/packaging/zypper_repository -a "repo=http://download.opensuse.org/repositories/devel:/languages:/python/SLE_11_SP3/devel:languages:python.repo"
{"repo": "http://download.opensuse.org/repositories/devel:/languages:/python/SLE_11_SP3/devel:languages:python.repo", "state": "present", "changed": true}
$ ./hacking/test-module -m library/packaging/zypper_repository -a "repo=http://download.opensuse.org/repositories/devel:/languages:/python/SLE_11_SP3/devel:languages:python.repo"
{"repo": "http://download.opensuse.org/repositories/devel:/languages:/python/SLE_11_SP3/devel:languages:python.repo", "state": "present", "changed": false}

Signed-off-by: Hector Acosta <hector.acosta@gmail.com>
 2014-06-26 13:17:27 -07:00
James Cammarata
29434b06b8 Merge pull request #7942 from sidred10/devel 
Fixed FreeBSD ports install issue
 2014-06-26 11:50:33 -05:00
sid
08370b3caf Fixed FreeBSD ports install issue 2014-06-26 20:52:57 +05:30
Maxim Odinintsev
82c026387f Successfull exit if sync=yes and no package provided 2014-06-26 15:02:15 +03:00
Maxim Odinintsev
a58912773d Success exit if sync=yes and no package provided 2014-06-26 14:55:16 +03:00
James Cammarata
05eb6aacec Merge pull request #7925 from devpopol/fixes/api_error 
fixes the now-incorrect module for ApiError -- noticed since 0.3.2
 2014-06-25 22:33:22 -05:00
James Cammarata
2305ac9881 Merge pull request #7930 from trbs/apt_key_fetch_url_failure_codes 
apt_key clear message when downloading key returns an (http) error code
 2014-06-25 22:27:08 -05:00
Michael DeHaan
f6c7e34527 Merge pull request #7931 from quiver/fix-yum-module-doc 
In yum module example, use present/absent instead of installed/removed
 2014-06-25 17:03:10 -05:00
George Yoshida
779c6cb7f8 In the yum module example, use present/absent instead of installed/removed 2014-06-25 23:21:43 +09:00
trbs
dfc625a7df apt_key clear message when downloading key returns an (http) error code 2014-06-25 15:30:34 +02:00
Tim Ruffles
676f0a6e76 grammar fix 2014-06-25 14:00:01 +01:00
Stephen Paul Suarez
49cf5831c5 support old and new versions of APIError 2014-06-25 14:52:00 +08:00
Stephen Paul Suarez
dfabf2707a fixes the now-incorrect module for ApiError 
https://github.com/dotcloud/docker-py/blob/0.3.2/docker/errors.py
- ApiError is now(0.3.2) under the docker.errors
 2014-06-25 14:20:07 +08:00