Brian Scholer
9afe87139a
Add win_psrepository_info module ( #67594 )
...
* Add win_psrepository_info module
* Change return type
* Add tests for win_psrepository_info
2020-02-27 16:05:37 +10:00
Andrew Klychkov
10feb24870
mongodb_shard: fix doc formatting ( #67750 )
2020-02-27 08:04:12 +05:30
Mark Chappell
d5c17118ed
s3_bucket - cleanup and test stabilisation. ( #66778 )
...
* AnsibleAWSModule related cleanup - s3_bucket
* Add extra information to s3_bucket timeout failures, it's possible the comparisons are doing something weird...
* Move Bucket Encryption boto support logic into the pre-flight checks
* Use the built in required_by logic
* Rework s3_bucket integration tests
* Add a retry around put_bucket_encryption
s3_client.put_bucket_encryption is occasionally dropped on the floor
by Amazon add some logic to retry s3_client.put_bucket_encryption call
* Catch OperationAborted and retry, it is caused by a conflicting change
still being in progress. (For example an Encryption setting applying)
* Make sure we don't explode if the botocore version's too old
* Review tweaks
2020-02-26 16:54:39 -07:00
Markus Bergholz
9463d28967
read enabled_key_rotation status also in aws_kms_info ( #67770 )
...
* read enabled_key_rotation status
* add changelog
* use AWSRetry decorator to prevent api rate limits
* fix pip8
2020-02-26 16:51:04 -07:00
sky-joker
454b043c13
Reflect changed JSON structure than zabbix version 4.4 or more to zabbix_user
...
add fragments file
Fix several pointed out
https://github.com/ansible/ansible/pull/67475#discussion_r380528775
https://github.com/ansible/ansible/pull/67475#discussion_r380532685
Enable integration test
2020-02-26 15:40:17 -08:00
Paul Belanger
357ae7ec0e
Remove unused import from frr cli plugin ( #67790 )
...
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2020-02-26 16:48:07 -05:00
Andrew Klychkov
dd53c104d7
postgresql_info: move subscription info to corresponding database dict ( #67772 )
2020-02-26 22:25:16 +01:00
Sumit Jaiswal
d8c5c6eb9d
Add Switchport mode support in newly introduced *_l2_interfaces resource module ( #67456 )
...
* fixes 65032
2020-02-26 23:49:00 +05:30
Abhijeet Kasurde
a4da73e961
misc typo fixes ( #67775 )
...
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2020-02-26 10:58:39 -05:00
sky-joker
829a29ef18
Fix to be support for zabbix 4.4 or more and python3 ( #67693 )
...
add fragments file
2020-02-26 07:48:29 -05:00
sky-joker
305789144a
Fix to remove unnecessary duplicate line ( #67761 )
2020-02-26 07:48:15 -05:00
Matt Martz
6e1a59174a
Clean up CONDITIONAL_BARE_VARS warning. Fixes #67735 ( #67751 )
2020-02-25 16:36:01 -06:00
flowerysong
370f788731
adhoc: Load callbacks before sending v2_playbook_on_start ( #67673 )
2020-02-25 17:00:08 -05:00
Kevin P. Fleming
4c016e64dd
Update 'server' doc in nsupdate module to avoid DNS names ( #67597 )
2020-02-25 16:07:55 -05:00
John Nelson
e9f22a2269
win_dns_record: Improve examples documentation ( #67744 )
2020-02-25 16:03:03 -05:00
Andrew Klychkov
1b5c69deef
mysql_info: remove irrelevant comment ( #67753 )
2020-02-25 16:00:41 -05:00
Mark Chappell
9d455bed7b
aws_acm Add additional AWSRetry error codes ( #67671 )
...
* Cleanup tests
* Auto-Retry on ResourceNotFound and RequestInProgress exceptions
* Use AnsibleModule options for required_if logic
* changelog
* Remove (now) duplicate RequestInProgressException catching
* Allow a single retry when attempting to fetch the information about a cert directly after deleting it.
There is a small chance that it goes away while we pull the details.
2020-02-25 13:48:26 -07:00
Markus Bergholz
99f6f0c832
add key rotation option to aws_kms ( #67651 )
...
* add key rotation option
* add changelog fragment
* provide version added as string
* change changelog to minor_changes
* Update changelogs/fragments/67651-aws-kms-key-rotation.yml
Co-Authored-By: Mark Chappell <mchappel@redhat.com>
* Update lib/ansible/modules/cloud/amazon/aws_kms.py
Co-Authored-By: Mark Chappell <mchappel@redhat.com>
* prevent key upgrade if key rotation was enabled manually. In that case, the key rotation would be disabled, if not mentioned in the playbook
* Update lib/ansible/modules/cloud/amazon/aws_kms.py
Co-Authored-By: Mark Chappell <mchappel@redhat.com>
* Update lib/ansible/modules/cloud/amazon/aws_kms.py
Co-Authored-By: Mark Chappell <mchappel@redhat.com>
* Update lib/ansible/modules/cloud/amazon/aws_kms.py
Co-Authored-By: Mark Chappell <mchappel@redhat.com>
Co-authored-by: Mark Chappell <mchappel@redhat.com>
2020-02-25 13:30:45 -07:00
Andrew Klychkov
f0159b8870
postgresql_info: add getting publication statistics ( #67614 )
...
* postgresql_info: add getting publication statistics
* add changelog
* fix
* fix server_version check
2020-02-25 20:58:23 +01:00
Andrew Klychkov
b9a315a2c0
mysql_db: add dump_extra_args parameter ( #67747 )
...
* mysql_db: add dump_extra_args parameter
* add changelog fragment
2020-02-25 20:48:32 +01:00
Abhijeet Kasurde
848aa06cac
Remove unused variables in collection API ( #67724 )
...
Remove unused variables in _download_file API
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2020-02-25 12:30:53 -05:00
Sloane Hertel
8eb00dd14c
Fix inline vaults for plugins in ensure_type ( #67492 )
...
* Fix implicit string - only looked right because of the vault __repr__
* Add tests for strings and implicit strings
2020-02-25 10:42:31 -05:00
Brian Coca
9ea5bb3364
strip spaces for each value in host list lists ( #67701 )
2020-02-25 09:16:27 -05:00
GomathiselviS
726d6455d8
eos static_routes module added ( #65480 )
...
* Adding files for RM static_routes
* Added Integration tests
* Added Unit testcases
* Addressed review comments
* corrected lint errors
* corrected documentation errors
* Lint errors
* corrected test/sanity
* corrected documentation for deprecation
* corrected case sensitivity
* Again Documentation eroor
* Lint errors again
* corrected deprecated module in ignoretxt
* added new gethered,rendered,parsed state checks to unit test
* New code broke the old flow-fixed
* Lint errs
* Added check for running_config
* Add rtt testcase
* Fixed unit tcs
* lint errors
* lint errors
* Modified replaced operation behavior
* updated documentation and tests for delete opration
* fixed shippable errors
* review comments and flake8 error fix
* syntax errors fixed
2020-02-25 07:50:27 -05:00
Abhijeet Kasurde
6f0924a892
Remove unnecessary indent ( #67728 )
...
total_size fact is populated if schema is not specified in
postgresql_user_obj_stat_info module.
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2020-02-25 14:12:56 +05:30
Paul Belanger
81ffc315a4
Remove unused imports for iosxr_acls ( #67711 )
...
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2020-02-24 17:47:35 -05:00
Paul Belanger
bfea5cfca0
Remove unused imports from vyos_firewall_global ( #67710 )
...
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2020-02-24 15:26:42 -05:00
Noboru Iwamatsu
d317cc71c7
s3_bucket: accept NetApp StorageGRID create_bucket response. ( #67462 )
2020-02-24 13:00:38 -07:00
WilliamVannuffelen
c5ec0fcb34
Setup documentation - windows custom fact variable name ( #67690 )
2020-02-24 14:58:18 -05:00
Martin Nečas
4b382b78d0
ovirt_vm: add cpu_pinning example ( #67612 )
2020-02-24 14:41:50 -05:00
as-hbk
e2f1b57299
adds missing alias to win_regedit documentation ( #67662 )
2020-02-24 14:35:21 -05:00
roxyland
febbb66d71
Change package_license to accept_license ( #67676 )
2020-02-24 14:28:11 -05:00
Fred-sun
a173ce9630
change intelligence_pack to intelligence_packs ( #67686 )
2020-02-24 14:25:23 -05:00
Mark Chappell
f520238d60
Migrate a batch of AWS modules to AnsibleAWSModule (1) ( #67191 )
...
* Move various Amazon modules over to AnsibleAWSModule
* Remove HAS_BOTO3 logic, it's handled by AnsibleAWSModule
* Simplify argument_spec handling ec2_argument_spec is automatically added by AnsibleAWSModule
* Cleanup boto3 error handling using fail_json_aws
* Migrate simple cases from boto3_conn to module.client()
* Migrate batch modules over to module.client()
* Migrate EFS module over to module.client()
* Comment cleanup
* Use deprecated_aliases in argument_spec rather than custom code
* Cleanup unused imports
* Make use of module.region
* Deprecate batch.AWSConnection it's now dead code
2020-02-24 14:01:14 -05:00
Graeme Davidson
bd26b6c0b4
updated single quote handling to not strip and error on odd number ( #67500 )
...
Fixes #67274
2020-02-24 13:45:19 -05:00
GomathiselviS
d283126c31
eos_acls : Add eos acls resource module ( #66308 )
...
* Adding files for RM static_routes
* Added Integration tests
* Added Unit testcases
* Addressed review comments
* corrected lint errors
* corrected documentation errors
* Lint errors
* corrected test/sanity
* corrected documentation for deprecation
* corrected case sensitivity
* Again Documentation eroor
* Lint errors again
* corrected deprecated module in ignoretxt
* added new gethered,rendered,parsed state checks to unit test
* New code broke the old flow-fixed
* Lint errs
* Added check for running_config
* eos_acls resource module added
* Corrected errors
* corrected documentation errors
* corrected typo
* Testcases in progress
* Integration tests in progress
* Integration tests
* Added Intergration tcs
* Corrected pylint errors
* Resolving issues due to rebase
* Corrected Typo
* more pylint errors
* more pylint errors
* more pylint errors
* Documentation
* Documentation
* More lint errors
* Fixed Indentation
* Indentation issues - not getting fixed
* Indentation issues - not getting fixed
* Added rtt testcase
* Corrected whitespaces
* addressed review comments
* moved integration tests to common - to support eapi tests
* modification for merge update
* indentation errors
* added line key
* Fixing shippable errors
* fixing doc errors
* fixing doc errors
* fixing doc errors
* fixing doc errors
* fixing indentation
* modified replaced operation
* rebase issue fixed
* Corrected typo
* review comments and flake8 error fixed
2020-02-24 12:27:11 -05:00
Paul Belanger
74e948e6e4
Fix flake8 errors with eos_acl_interfaces ( #67695 )
...
Theses were exposed by our collections testing.
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2020-02-24 09:47:43 -05:00
James McClune
059a193dff
lib/ansible/plugins/inventory/ini.py: added spacing for error message ( #67361 )
...
Signed-off-by: James McClune <falcon78921@users.noreply.github.com>
2020-02-24 09:26:48 -05:00
Rohit
fc05c50b7f
VyOS: firewall global module added ( #66800 )
...
* firewall global module
Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>
* sanity fixed
Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>
* test updated
Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>
* sanity fixes
Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>
* group member handling updated
Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>
* comments incorporated
Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>
2020-02-24 09:03:02 -05:00
Nilashish Chakraborty
b818436c5f
Add iosxr_acls RM ( #66207 )
...
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
2020-02-24 18:34:27 +05:30
GomathiselviS
3acd8f6f7f
Fix to - nxos_lag_interfaces not idempotent ( #67359 )
...
* Added fix for bug # 54400
* Adding files for RM static_routes
* Added Integration tests
* Revert "Added fix for bug # 54400"
This reverts commit bf42db4269dafdd92d43129dc87682bf42db4269dafdd92d43129dc87682#67169
* corrected rebase spillover
* indentation errors fixed
* modified integration testcase
2020-02-24 07:57:11 -05:00
Sumit Jaiswal
f292f21d86
Fixes nxos_l2_interfaces module traceback if allowed vlans are not preconfigured ( #67457 )
...
* fixes 67455
* fix review
2020-02-24 17:44:21 +05:30
Martin Nečas
0d72d2d4d2
ovirt_vm: correct numa nodes ( #67611 )
...
* init commit
* update docs
* update numa function name
* correct whitespaces
2020-02-24 04:20:46 -05:00
Alexis Camilleri
feeb380649
scaleway_compute: check image on get instead of list ( #67655 )
...
* fix scaleway_compute: check image on get instead of list
* add changelog
Signed-off-by: Alexis Camilleri <acamilleri@scaleway.com>
2020-02-24 11:08:14 +05:30
Xu Yuandong
dbaa421f9d
Some cloudengine modules miss "import __future__" and "mateclass", update to add them. ( #67634 )
...
* update doc missing future & mateclass.
* update ignore.txt.
* add a changelog.
* update changelog.
2020-02-22 17:35:18 +01:00
Abhijeet Kasurde
6936e7b698
Handle NoneType error in vmware_host_service_info ( #67641 )
...
Handle NoneType error occured due to accessing host system service info
in vmware_host_service_info module.
Fixes : #67615
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2020-02-22 21:46:18 +05:30
Brian Coca
00b70bf36a
Show field instead of value ( #59926 )
...
* Show argument name vs value on failed conversion
generally more useful to user as they might set values indirectly
* clog
2020-02-21 17:01:09 -05:00
Moritz Grimm
79dfae9624
copy: ensure _original_basename is set: fixes #47050 ( #47238 )
...
* fixed #47050
* added changelog fragment
* added quick and basic test
* Revert "added quick and basic test"
This reverts commit 75f4141656
2020-02-21 12:55:12 -05:00
Mark Chappell
d74ed41a4c
AnsibleAWSModule add 'region' method ( #66988 )
...
* Add get_aws_region to module_utils.ec2 and region to AnsibleAWSModule
* Add example use
* Add changelog
2020-02-21 11:58:02 -05:00
Alexis Camilleri
f70dc261cc
fix(scaleway): use jsonify for application/json content-type only ( #66957 )
...
* fix(scaleway): use jsonify for application/json content-type
* add changelog
2020-02-21 17:14:22 +01:00
