Commit graph

9198 commits

Author SHA1 Message Date
Abhijit Menon-Sen
9b496818cf Simplify distribution test
If it's Ubuntu, use UbuntuSourcesList; if it's any other apt-friendly
distribution, use SourcesList; otherwise, fail.
2016-12-08 11:23:27 -05:00
Abhijit Menon-Sen
ca50b5c5e0 Make SourcesList __init__ method also set self.module
This was originally required to allow other methods in SourcesList to
fail, but subsequent changes rendered that unnecessary, and it's just
a cleanup now, and avoids passing in module separately to save().
2016-12-08 11:23:27 -05:00
Abhijit Menon-Sen
46c015375d Clarify HAVE_PYTHON_APT/install_python_apt handling in apt_repository
1. Don't test check_mode in both the caller and in the callee.
2. Don't test HAVE_PYTHON_APT inside an if that tests HAVE_PYTHON_APT
3. Don't be irritatingly vague about why the module fails ("You may be
   seeing this because…").

Note that if «apt-get -y install python-apt» succeeds with rc==0, but
for some reason python_apt is not usable afterwards, this will break
because the imports in install_python_apt aren't wrapped inside a
try/except.

In other words, we assume that install_python_apt either succeeds or
fails with a traceback. This commit doesn't affect that behaviour.
2016-12-08 11:23:27 -05:00
Abhijit Menon-Sen
7643d3aecf Fix call to _expand_ppa 2016-12-08 11:23:27 -05:00
brannon
824503fc19 Fix windows feature example to actually install IIS 2016-12-08 11:23:27 -05:00
Brian Coca
7d660adb39 changed verbose override variable 2016-12-08 11:23:27 -05:00
Micheal Waltz
5f0d989973 Fix incorrect var name for api_version 2016-12-08 11:23:27 -05:00
Luke Rohde
05974273b3 Use msg kwarg to pass error message in ec2_snapshot 2016-12-08 11:23:27 -05:00
Brian Coca
cd072e3090 added version added to headers in s3 2016-12-08 11:23:26 -05:00
Jaime Gago
b203deee31 Fix example indentation bug 2016-12-08 11:23:26 -05:00
Brian Coca
92dfe33021 defined DEFAULT_DOCKER_API_VERSION to avoid it erroring out before we send the message that docker.py is missing 2016-12-08 11:23:26 -05:00
Toshio Kuratomi
a01a800b65 Fi the local_rsync_path parameter used by the action plugin 2016-12-08 11:23:26 -05:00
Brian Coca
3b94910d4e minor doc fixes to get_url 2016-12-08 11:23:26 -05:00
Toshio Kuratomi
103b150090 Convert object into dict so it will turn into json properly 2016-12-08 11:23:26 -05:00
James Cammarata
05c6732462 Prefer non-zero rc's over text analyis in service status checks
Fixes ansible/ansible#10441
2016-12-08 11:23:26 -05:00
Bill Nottingham
d4069a8a8a Warn on use of sudo, etc. in shell/command. 2016-12-08 11:23:26 -05:00
James Cammarata
ba9ba7d0f5 In copy, set the mode before running th validation
Because some programs that do validation (like visudo) may require
the permissions to be more restricted.

Fixes ansible/ansible#11385
2016-12-08 11:23:26 -05:00
saito-hideki
19cd35806f Add Solaris support in hostname module
feature_pull_request: #1804
2016-12-08 11:23:26 -05:00
Brian Coca
357d542bb3 clarified error messages to actually give back ansible module option instead of internal boto field name 2016-12-08 11:23:26 -05:00
Jesse Keating
a913370687 Handle non-updatable openstack subnet details
Some things cannot be updated via the API, so check for those and fail
if the user is wanting to update them. Also don't try to update ipv6
stuff, as that doesn't work and will cause a traceback.
2016-12-08 11:23:26 -05:00
Jens Carl
c0eedc6e87 Fix missing alias "groups". 2016-12-08 11:23:26 -05:00
Brian Coca
56354731ce fixed fragment docs 2016-12-08 11:23:26 -05:00
Brian Coca
e5fe763474 fixed version added 2016-12-08 11:23:26 -05:00
Feanil Patel
e4898a4348 If overwrite is set, download eagerly.
If the we are going to overwrite the file anyway,
there is no need to do any checksums locally or
grab the remote etag.
2016-12-08 11:23:26 -05:00
Micheal Waltz
950701ba3e Use a if/else instead to avoid loading possibly invalid values for Memory 2016-12-08 11:23:25 -05:00
Micheal Waltz
af5e402b87 Set the API version when checking differences in containers and use this to determine the location of the Memory value depending on the version used.
In v1.18 and earlier it was ['Config']['Memory'], but in v1.19 it
changed to ['HostConfig']['Memory'].
2016-12-08 11:23:25 -05:00
billwanjohi
167e940e78 iam: don't delete passwords by default 2016-12-08 11:23:25 -05:00
Igor Khomyakov
9a599e35c1 fixed 'present' 2016-12-08 11:23:25 -05:00
Micheal Waltz
f36666ae1d Use proper HostConfig element which contians the proper Memory value - fixes #1766 2016-12-08 11:23:25 -05:00
Lars Kellogg-Stedman
3d79d96a1b restore mem_limit
mem_limit got lost in the #1744; this restores it.  Thanks to @dgromov
for the report.
2016-12-08 11:23:25 -05:00
Lars Kellogg-Stedman
562341049e docker: fix parsing of docker __version__ string
If `docker.__version__` contains non-digit characters, such as:

    >>> import docker
    >>> docker.__version__
    '1.4.0-dev'

Then `get_docker_py_versioninfo` will fail with:

    ValueError: invalid literal for int() with base 10: '0-de'

This patch corrects the parsing of the version string so that
`get_docker_py_versioninfo` in this example would return:

    (1, 4, 0, '-dev')
2016-12-08 11:23:25 -05:00
Mike Putnam
9623cd570c Add missing GPLv3 License header
Fixes #1643
2016-12-08 11:23:25 -05:00
Ash Caire
682bf34a43 add headers param to s3 uploads 2016-12-08 11:23:25 -05:00
Dan
5b4e7c797f Added header support
Added the ability to pass custom http headers to the fetch_url method.
2016-12-08 11:23:25 -05:00
KIKUCHI Koichiro
dab7305d3b Fix service enabled check failure on FreeBSD 2016-12-08 11:23:25 -05:00
Sébastien Gross
0fd3ece053 Allow '*' as empty password.
If `password` is defined as `*` `useradd` or `usermod` returns an error:

    msg: usermod: Invalid password: `*'

This works very well on Linux host to not define any password for a
user (mainly useful if your setup is only based on SSH keys for
auth). On OpenBSD this does not work, so we have to ignore the encrypted
password parameter if it defined as `*`.
2016-12-08 11:23:25 -05:00
Andrey Trubachev
b93633d7c2 Fix python-2.4 compatibility 2016-12-08 11:23:25 -05:00
Andrey Trubachev
c55187ff42 Fix 'wait_for' doesn't work with ipv6only host 2016-12-08 11:23:25 -05:00
khassen
8b60dd349d Use the common/shared MD5 function. 2016-12-08 11:23:25 -05:00
Brian Coca
f15ce1433a added version_added to body_format in uri 2016-12-08 11:23:25 -05:00
fti7
581ce7dd32 mount: Support for Check-Mode 2016-12-08 11:23:24 -05:00
Greg DeKoenigsberg
ffb1cab213 Add new policy guidelines for Core 2016-12-08 11:23:24 -05:00
Johan Haals
6a9a4d905a ensures API compatibility for read_only containers 2016-12-08 11:23:24 -05:00
Guilherme Carlos
aaac05c96c Fix login_user on mysql_user
`login_username` was provided but `login_user` is the correct option
2016-12-08 11:23:24 -05:00
Toshio Kuratomi
55271467d4 Remove validate_certs as the url is not user settable so we always want to validate the certificate 2016-12-08 11:23:24 -05:00
Artur Cygan
d71b1444a9 Update route53.py
Fix typos
2016-12-08 11:23:24 -05:00
Chris Church
d8f5a34d85 Save user after creating before trying to read/set other properties. Fixes #1241 2016-12-08 11:23:24 -05:00
Johan Haals
c88feaff7e changed version_added for read_only param
this feature will be released in 2.0
2016-12-08 11:23:24 -05:00
Baraa Basata
63a619fbae Fix iam_policy example 2016-12-08 11:23:24 -05:00
Will Thames
e5d96dc934 Correct handling of empty role_attr_flags
role_attr_flags is the empty string by default, not None.
2016-12-08 11:23:24 -05:00