Commit graph

20 commits

Author SHA1 Message Date
Stijn Tintel
9d0fc0fd67 Only revoke GRANT OPTION when user actually has it
When revoking privileges from a user, the GRANT OPTION is always
revoked, even if the user doesn't have it. If the user exists, this
doesn't give an error, but if the user doesn't exist, it does:

mysql> GRANT ALL ON test.* TO 'test'@'localhost';
Query OK, 0 rows affected (0.00 sec)

mysql> REVOKE GRANT OPTION ON test.* FROM 'test'@'localhost';
Query OK, 0 rows affected (0.00 sec)

mysql> REVOKE GRANT OPTION ON test.* FROM 'test'@'localhost';
Query OK, 0 rows affected (0.00 sec)

mysql> REVOKE ALL ON test.* FROM 'test'@'localhost';
Query OK, 0 rows affected (0.00 sec)

mysql> REVOKE GRANT OPTION ON test.* FROM 'test'@'localhost';
ERROR 1141 (42000): There is no such grant defined for user 'test' on
host 'localhost'

Additionally, in MySQL 5.6 this breaks replication because of
http://bugs.mysql.com/bug.php?id=68892.

Rather than revoking the GRANT OPTION and catching the error, check if
the user actually has it and only revoke it when he does.
2013-07-23 13:00:29 +02:00
Michael DeHaan
10b967374d Add version_added information to module parameter. 2013-07-20 12:33:42 -04:00
Michael DeHaan
34315c63ca Merge pull request #3396 from adq/mysql
Check if mysql allows login as root/nopassword before trying supplied credentials.
2013-07-20 09:32:00 -07:00
Jan-Piet Mens
c4189dfd3c mysql_db small fix to docs 2013-07-14 13:11:03 +02:00
James Martin
93d5d76468 Fixed #3433. Using get_bin_path, removed uneeded imports, "module" is inlined, misc other style improvements. 2013-07-05 13:22:44 -04:00
Andrew de Quincey
4cb48f0dcc Check if mysql allows login as root/nopassword before trying supplied credentials. 2013-07-01 11:56:04 +01:00
Jan-Piet Mens
30d641094b Docs: consistently format playbook EXAMPLES 2013-06-17 08:53:46 +02:00
Michael DeHaan
3e1e163ec3 Merge pull request #3172 from gw0/fix-mongodb2.2-compat
Fix `mongodb_user` compatibility with MongoDB 2.2 (used in Debian 7).
2013-06-16 20:24:31 -07:00
Michael DeHaan
294230d529 Merge pull request #3177 from stintel/mysql56-compat
Fix MySQL 5.6 compatibility
2013-06-16 19:27:17 -07:00
Jan-Piet Mens
5c69918d53 DOCS: standardize on EXAMPLES (a.k.a. Docs-JumboPatch JetLag Edition)
Migrated all examples: in DOCUMENTATION=''' string to standalone EXAMPLES=''' string
  Added deprecation warning to moduledev.rst and remove deprecated example from it
  Fixed up a few typos and uppercased some acronyms.
  add consistency to how EXAMPLES are formatted
2013-06-15 20:54:25 +02:00
Stijn Tintel
767c208e6c Fix MySQL 5.6 compatibility
In MySQL 5.6, the root account created by default during MySQL
installation has the PROXY ... WITH GRANT OPTION privilege for ''@'',
that is, for all users.

The mysql_user module tries to revoke this privilege, but this fails:
_mysql_exceptions.ProgrammingError: (1064, "You have an error in your
SQL syntax; check the manual that corresponds to your MySQL server
version for the right syntax to use near '''@'' FROM 'root'@'localhost''
at line 1")

Quick fix: don't revoke privilege if user is root and the privilege to
revoke contains PROXY.
2013-06-11 15:00:14 +02:00
gw0 [http://gw.tnode.com/]
47c8396598 Fix mongodb_user compatibility with MongoDB 2.2 (used in Debian 7). 2013-06-10 22:43:50 +02:00
Michael DeHaan
caa07e7fab pep8 fixes 2013-06-01 12:29:03 -04:00
Michael DeHaan
16c7c50e8f Docs standardization 2013-06-01 12:12:11 -04:00
Michael DeHaan
e5d911fbce Docs standardization 2013-06-01 12:11:26 -04:00
James Martin
1aec4c0e74 Now can specify amount of time to wait_for_handoffs or ring ready instead of booleans. 2013-05-27 17:24:10 -04:00
James Martin
633724dc8c Timeouts implemented for riak stats operation. Removed failback mode
for fetching riak stats.
2013-05-27 17:12:13 -04:00
James Martin
cf304b43b0 Fixed docs. Fixed fallback status method. Fixed "changed" message with cluster commit. 2013-05-05 14:54:23 -04:00
Bernhard Weitzhofer
119f33ed34 postgresql_privs: fix wrong codec specification
Use psycopg2's mapping from PostgreSQL encoding names to Python codec names.
2013-05-03 21:31:20 +02:00
Michael DeHaan
391fb98ee2 Allow modules to be categorized, and also sort them when generating the documentation. 2013-04-28 15:03:45 -04:00