Commit graph

1998 commits

Author SHA1 Message Date
Dag Wieers
3b7feb8980 Don't require thirsty mode for directory destination
There is no need to require thirsty mode when the destination is a directory. We add the basename of the url to the destination directory and proceed with that. If that file exists in non-thirsty mode continue as expected.

I also cleaned up some of the logic that is no longer necessary if we simply rewrite the destination from the very start the way it is expected.
2012-11-07 14:16:48 +01:00
Fabian Arrotin
1151381ab1 Fixed the way dom0/domU xen role is defined in the setup module 2012-11-06 22:49:33 +01:00
Stephen Fromm
f49d2bc557 Fix to user module to use self when calling group_exists 2012-11-06 09:05:25 -08:00
Daniel Hokka Zakrisson
8fba4cc04f Keep fireball from spreading its socket around 2012-11-06 15:10:34 +01:00
Nigel Metheringham
fc3b04e281 FreeBSD user mod only fires when there are changes
Also fix missing -G on groups change
2012-11-04 12:09:19 +00:00
Nigel Metheringham
c6c7189e23 Take SHADOWFILE from existing user object rather than class 2012-11-04 09:54:50 +00:00
Nigel Metheringham
ed5bf78485 Use the existing framework when running ssh_keygen 2012-11-04 09:47:30 +00:00
Nigel Metheringham
eecf6cf94f Ensure user owns their ssh key directory on creation
Lost section from commit 8049777
2012-11-04 09:44:38 +00:00
Michael DeHaan
bb2929b508 Merge branch 'playbook_ssh_ask_pass' of git://github.com/clatour/ansible into devel
Conflicts:
	examples/ansible.cfg

+ doc tweak
2012-11-03 19:23:38 -04:00
Michael DeHaan
15af4c63e5 Merge branch 'service_bsd' of git://github.com/bcoca/ansible into devel 2012-11-03 18:58:29 -04:00
Michael DeHaan
ade071eb29 Fix user example 2012-11-03 18:57:19 -04:00
Michael DeHaan
78669c57d5 Module documentation should have options sorted 2012-11-03 18:52:59 -04:00
Michael DeHaan
61a4674413 Merge branch 'nigelm_freebsd' of git://github.com/nigelm/ansible into merge-service
Make things more reusable, correct some errors along the SSH key path

Conflicts:
	library/user
2012-11-03 18:38:05 -04:00
Nigel Metheringham
871d3afdf4 Added some documentation to the classes 2012-11-01 19:16:54 +00:00
Daniel Hokka Zakrisson
1ec38eb435 Fix service module for varnish initscript in EPEL
It outputs 'dead but pid file exists'.
2012-10-31 12:31:08 +01:00
Brian Coca
e18ef3d640 Now can handle rc.conf and init.d/rc.d based systems
Signed-off-by: Brian Coca <briancoca+ansible@gmail.com>
2012-10-30 23:34:18 -04:00
Dag Wieers
1954e60e95 Use return codes > 255 for Ansible-specific errors.
I had made and pushed this change after you already pulled the request.

@dhozac indicated that it would probably be better to use return codes > 255 for anything related to Ansible itself. Which makes sens :)
2012-10-30 23:34:18 -04:00
Michael DeHaan
8d3f73d562 pep8 fixes 2012-10-30 20:42:07 -04:00
Michael DeHaan
958b2909f8 Rename 'domainname' to 'domain' 2012-10-30 20:07:36 -04:00
Michael DeHaan
d7f740ffbe Merge pull request #1490 from sfromm/issue1484
Make sure ownership is set correctly for user's new ssh keys
2012-10-30 17:03:07 -07:00
Michael DeHaan
614bbcc5a7 Merge pull request #1488 from dagwieers/lineinfile-create
Add option create= to lineinfile module
2012-10-30 17:02:00 -07:00
Michael DeHaan
1a70cf965c Merge pull request #1487 from skvidal/devel
fix up remove and fix fixme checking to see if pkg was removed
2012-10-30 17:00:54 -07:00
Michael DeHaan
125a30eef7 Merge pull request #1474 from jhoekx/group-by-plugin-template
Add a group_by action plugin.
2012-10-30 16:54:07 -07:00
Serge van Ginderachter
4ebea7acba Add domainname to ansible facts 2012-10-30 19:47:31 -04:00
Serge van Ginderachter
8a823acf20 Fix typo 2012-10-30 19:43:22 +01:00
Dag Wieers
835d7d854e Add option create= to lineinfile module
We use the lineinfile module to modify configuration files of a proprietary application. This application reads configuration options from files, but does not require those files to exist (if the default options are fine). However this application may modify the configuration file at will, so we cannot copy or template those files. And after a silent install the configuration may not exist (depending on the response file).

Whatever the case, during deployment we need to make sure some configuration options are set after the installation.

So the cleanest way to handle this situation is to allow the lineinfile module to create the file if it is missing (and this is the expected behavior). When I proposed this behavior, @sergevanginderachter needed the same functionality and was now working around it as well.
2012-10-30 17:57:15 +01:00
Stephen Fromm
f0d2a1260b Make sure ownership is set correctly for user's new ssh keys 2012-10-30 09:37:23 -07:00
Michael DeHaan
86e744d658 Merge pull request #1480 from dagwieers/command-fix2
Use return codes > 255 for Ansible-specific errors.
2012-10-30 05:04:44 -07:00
Michael DeHaan
94c1ba753a Merge pull request #1479 from wzzrd/selinux
More useful error message for if not HAVE_SELINUX
2012-10-30 05:04:28 -07:00
Dag Wieers
f26148d4b9 Use return codes > 255 for Ansible-specific errors.
I had made and pushed this change after you already pulled the request.

@dhozac indicated that it would probably be better to use return codes > 255 for anything related to Ansible itself. Which makes sens :)
2012-10-30 10:36:11 +01:00
Seth Vidal
0c65102c42 fix up remove and fix fixme checking to see if pkg was removed 2012-10-29 23:48:21 -04:00
Nigel Metheringham
0fc939d33f Turn off some of the additional debug syslogging 2012-10-29 22:04:06 +00:00
Nigel Metheringham
346f8ffe0e Rework of user module to support portability
Split module into a main calling function, and a generic
(Linux useradd/usermod/userdel) User class.
Added a __new__ function that selects most appropriate superclass
Added a FreeBSD User class
Tested against FreeBSD 9.0
2012-10-29 22:00:58 +00:00
Seth Vidal
9dd9db6296 fix removal case where first pkg in a list is not installed at all
and the next one gets ignored despite being installed.

also clean up unnecessary second check.
2012-10-29 13:48:20 -04:00
Maxim Burgerhout
fd9c0ca341 More useful error message for if not HAVE_SELINUX 2012-10-29 16:23:00 +01:00
Jeroen Hoekx
e2419cbf9d Add a group_by action plugin. 2012-10-29 13:10:23 +01:00
Dag Wieers
2c4d559523 Make sure we always return 'rc' from the command module
If this is not a certainty, playbooks will fail without an 'rc' and checking both if there is an rc, and whether the 'rc' is (not) 0 is very complicated. (especially because ${something.rc} will not be substituted and all that)
2012-10-26 15:02:03 +02:00
Daniel Hokka Zakrisson
447ea1624a When atomically replacing files, copy attributes 2012-10-25 21:40:05 -04:00
Michael DeHaan
d55e7f35cd Merge pull request #1455 from bleader/devel
user module: fix typo in documentation
2012-10-25 18:26:58 -07:00
Michael DeHaan
68bf6b1343 Merge pull request #1453 from sfromm/issue1211
Use shutil.copyfile so as to preserve file ownership in authorized_keys
2012-10-25 18:22:56 -07:00
Michael DeHaan
995c0a9f88 Merge pull request #1451 from dhozac/command-strip-newlines
Only strip trailing newlines from output, preserving other space
2012-10-25 18:21:16 -07:00
Michael DeHaan
24637fa9b0 Merge pull request #1448 from jpmens/user_user1
User is alias for name in 'user' module
2012-10-25 18:18:56 -07:00
bleader
fd650d783a user module: fix typo in documentation
tyep -> type

Signed-off-by: bleader <bleader@ratonland.org>
2012-10-25 20:56:13 +02:00
Stephen Fromm
93081eab8e Use shutil.copyfile so as to preserve file ownership in authorized_keys 2012-10-25 11:20:53 -07:00
Daniel Hokka Zakrisson
57df6da305 Only strip trailing newlines from output, preserving other space 2012-10-25 14:26:37 +02:00
Jan-Piet Mens
9484f55581 User is alias for name in 'user' module 2012-10-25 14:03:13 +02:00
Michael DeHaan
fba30c8fcb Merge pull request #1445 from sfromm/issue1439
Skip check of primary group when checking other group membership
2012-10-25 03:58:17 -07:00
Stephen Fromm
f70fcf6abb Create temp file in directory where ssh key lives 2012-10-24 20:50:11 -07:00
Stephen Fromm
4bce10c303 Write keys file to temp location to avoid potential corruption 2012-10-24 20:47:45 -07:00
Stephen Fromm
d7b5cbb6ac Skip check of primary group when checking other group membership 2012-10-24 20:39:42 -07:00