Commit graph

8901 commits

Author SHA1 Message Date
Monty Taylor
0e8ce4ad52
Rename a confusing variable
I had to read the two lines in question twice. That might just make me
dumb, but if I'm dumb, someone else might be too.
2016-08-01 08:33:09 -05:00
Rick Mendes
203b332cdb please remove me as maintainer 2016-07-31 13:24:12 -07:00
Rick Mendes
9cf83ab764 Fixes #4227 2016-07-30 15:11:45 -07:00
Jasmine Hegman
a3bae3e6ce Update docs to indicate ec2_asg state defaults to present (#4046)
* Update docs to indicate ec2_asg state defaults to present

Hopefully fixes Issue #4016

* Forgot to flip required to false
2016-07-30 10:45:01 -04:00
Ryan Brown
52e39b545e Merge pull request #4267 from shaunbrady/ec2_group_respect_vpc
Make `ec2_group` group_name property VPC-aware
2016-07-29 16:49:05 -04:00
Matt Clay
b3f363a46f Enable Windows tests on Shippable. (#4278) 2016-07-28 23:07:38 -07:00
Shaun Brady
de29bafc1e Make ec2_elb_lb respect VPCs when resolving groups
AWS security groups are unique by name only by VPC (Restated, the VPC
and group name form a unique key).

When attaching security groups to an ELB, the ec2_elb_lb module would
erroneously find security groups of the same name in other VPCs thus
causing an error stating as such.

To eliminate the error, we check that we are attaching subnets (implying
that we are in a VPC), grab the vpc_id of the 0th subnet, and filtering
the list of security groups on this VPC.  In other cases, no such filter
is applied (filters=None).
2016-07-28 18:49:11 -04:00
Shaun Brady
8fa56c16ee Remove trailing white space 2016-07-28 13:43:40 -04:00
Shaun Brady
890bba6a0e Make group_name resolution VPC aware
EC2 Security Group names are unique given a VPC.  When a group_name
value is specified in a rule, if the group_name does not exist in the
provided vpc_id it should create the group as per the documentation.

The groups dictionary uses group_names as keys, so it is possible to
find a group in another VPC with the name that is desired.  This causes
an error as the security group being acted on, and the security group
referenced in the rule are in two different VPCs.

To prevent this issue, we check to see if vpc_id is defined and if so
check that VPCs match, else we treat the group as new.
2016-07-27 14:11:59 -04:00
Rob Phoenix
aedf21b285 various typo corrections to ios network modules 2016-07-27 09:14:06 +01:00
John Baublitz
2de9fe0e67 Doc update 2016-07-26 18:05:37 +00:00
John Baublitz
4d9b872c3e Fix exception handling to be compatible with Python 3 2016-07-26 18:05:34 +00:00
John Baublitz
b8569ae38b Additional error handling for corner cases like deleting networks with active subnetworks 2016-07-26 18:05:32 +00:00
John Baublitz
a7702c1f67 Documentation 2016-07-26 17:59:15 +00:00
John Baublitz
1ea678e4ac Logic to allow subnet creation 2016-07-26 17:59:13 +00:00
John Baublitz
afe17834ce Add error handling for specifying 'mode' with insufficiently recent libcloud 2016-07-26 17:59:12 +00:00
John Baublitz
4b5a459fc1 Changes to allow 'auto' mode which does not allow IP address specification 2016-07-26 17:59:09 +00:00
John Baublitz
d8147f6226 Support for newer networking modes in GCE 2016-07-26 17:59:07 +00:00
Ryan Brown
24db4de245 Merge pull request #4156 from supertom/ansible-2111-fix
Support updating GCE firewall rules when attributes change

Fixes #2111
2016-07-25 14:09:06 -04:00
Ryan Brown
d288ef2abc Merge pull request #4163 from kaikousa/improve-ec2_lc-documentation
Improve `ec2_lc` documentation on security_groups option
2016-07-25 14:06:33 -04:00
Ryan Brown
a960f01bf3 Merge pull request #4234 from chrisweaver/patch-1
Enforce `bool` type for dup_ok option on AWS `iam_cert` module
2016-07-25 12:35:18 -04:00
Ryan Brown
95c67dc72a Merge pull request #4231 from phy1729/cfn-iam-capabilities
Support CAPABILITY_NAMED_IAM in AWS CloudFormation module
2016-07-25 12:34:01 -04:00
Ryan Brown
92a17c61f4 Merge pull request #4190 from jbaublitz/gce_suspend_node
Add states for stopping and starting GCE ☁️ instances
2016-07-25 11:30:36 -04:00
Ryan Brown
1e6d93cc52 Merge pull request #4203 from MichaelBaydoun/iam_policy_fix
Stop iam_policy from always reporting `changed` status
2016-07-25 11:16:00 -04:00
Brian Coca
d64060ace0 updated docs to reflect new feature 2016-07-24 21:32:44 -04:00
yfried-redhat
6b20645b40 Make os_floating_ip module idempotent
Current module fails when tries to assign floating-ips to server that
already have them and either fails or reports "changed=True" when no
ip was added

Removing floating-ip doesn't require address

Server name/id is enough to remove a floating ip.
2016-07-24 12:30:31 +03:00
Ryan
810b40aee9 fix typo in azure_rm_storageaccount (#4236) 2016-07-22 09:47:06 -07:00
Brian Coca
53b4bd06f5 deprecated accelerate 2016-07-22 11:48:38 -04:00
Brian Coca
1c55fa9bda deprecated accelerate 2016-07-22 11:48:06 -04:00
chrisweaver
8879931f0c Enforce boolean type for dup_ok
Stop "choices" from being interpreted as strings.
2016-07-21 15:02:49 -04:00
Toshio Kuratomi
b3c606047d Remove git and synchronize modules from list of commands we want users to use the module for instead. (#4233) 2016-07-21 10:57:41 -07:00
Matthew Martin
34d48eb89b Add CAPABILITY_NAMED_IAM to cloudformation capabilities
While from the documentation[1] one would assume that replacing
CAPABILITY_IAM with CAPABILITY_NAMED_IAM; this as empirically been shown
to not be the case.

1: "If you have IAM resources, you can specify either capability. If you
have IAM resources with custom names, you must specify
CAPABILITY_NAMED_IAM."
http://docs.aws.amazon.com/AWSCloudFormation/latest/APIReference/API_CreateStack.html
2016-07-21 10:54:40 -05:00
Michael Baydoun
07383c40d7
fixes issues where iam_policy incorrected reported changed 2016-07-18 13:43:28 +00:00
Andrei Lukovenko
3945794704 Bug: repeatable invocation with state=present leads to (#3052)
[localhost]: FAILED! => {"changed": false, "failed": true, "msg":
"'Domain' object has no attribute 'id'"}

How to reproduce:

- name: create domain
  digital_ocean_domain: state=present name=DOMAIN_NAME ip=DROPLET_IP

- name: create domain
  digital_ocean_domain: state=present name=DOMAIN_NAME ip=DROPLET_IP

Problem: DigitalOcean API changed API
(https://developers.digitalocean.com/documentation/v2/#list-all-domain-records)
2016-07-17 15:24:22 +02:00
Peter Sprygada
3d65c82d7c Merge pull request #4196 from privateip/ios_config
adds update_config argument to ios_config
2016-07-15 18:03:25 -04:00
Peter Sprygada
fb3916f002 adds update_config argument to ios_config
New argument controls whether or not configuration is applied to the
remote device.
2016-07-15 17:56:34 -04:00
Peter Sprygada
01c0093be5 Merge pull request #4193 from privateip/vyos_config
WIP initial add of new module vyos_config
2016-07-15 16:34:47 -04:00
Peter Sprygada
fe76a74e8c initial add of new module vyos_config
New module for sending configuration commands to remote devices running
the VyOS operating system.
2016-07-15 16:11:44 -04:00
John Baublitz
e85c2f8253 Collapse boilerplate code into change_instance_state function 2016-07-15 18:40:56 +00:00
Brian Coca
7de287237f stop trying to set permissions in check mode
fixes #4195
2016-07-15 11:43:05 -04:00
Brian Coca
4c59da1cf4 documenting behaviour as clear as possible 2016-07-15 09:49:47 -04:00
Toshio Kuratomi
55e6703209 Remove version-added on name field.
This parameter was actually added in 2.0.  It's just that the
documentation in previous versions of the module were wrong (it said the
name was  "network" rather than "name.)  I've renamed the parameter in
the documentation of prior versions so ansible-module-validate should no
longer think that this is a new parameter.
2016-07-15 06:40:50 -07:00
Peter Sprygada
800bd92026 Merge pull request #4187 from privateip/vyos_facts
WIP initial add of new module vyos_facts
2016-07-15 05:25:53 -07:00
Peter Sprygada
3b8cedfddb Merge pull request #4186 from privateip/vyos_command
initial commit of vyos_command module
2016-07-15 05:17:11 -07:00
Peter Sprygada
77f6c34ee4 initial add of new module vyos_facts
* adds collection of default facts
* adds collection of configuration facts
* adds collection of lldp neighbors
2016-07-15 07:59:49 -04:00
John Baublitz
b5da9d190d Add states for stopping and starting machines 2016-07-14 18:16:40 +00:00
Ryan S. Brown
3a04ec5a70 Indent unarchive module documentation to fix parsing error. 2016-07-14 14:05:00 -04:00
Ryan Brown
f61ddbc8a9 Merge pull request #3863 from ryansb/iam-pass-module
Bugfix: IAM group modules need `module` passed
2016-07-14 13:34:46 -04:00
James Cammarata
bfeab3ae1a Merge branch 'feature_10218' into devel 2016-07-14 12:14:54 -05:00
tobixx
3139b90f7e added read-/write-/executeable flags for invoking user (#4130) 2016-07-14 19:11:35 +02:00